ira/wip.git
13 years agoIgnore testing tdb.
Günther Deschner [Mon, 5 Nov 2007 01:35:04 +0000 (02:35 +0100)]
Ignore testing tdb.

Guenther
(This used to be commit 5bf02c6cdf6fc4596827755f7d659709adb0a7d6)

13 years agoDon't alloc struct iface_struct nics[MAX_INTERFACES]; (128 entries)
Jeremy Allison [Mon, 5 Nov 2007 06:20:04 +0000 (22:20 -0800)]
Don't alloc struct iface_struct nics[MAX_INTERFACES]; (128 entries)
on the stack - use talloc.
Jeremy
(This used to be commit b5e37af251a26648b0e4f59ca548c5374399175e)

13 years agoThis should really be a cond_set_smb_read_error().
Jeremy Allison [Mon, 5 Nov 2007 06:14:19 +0000 (22:14 -0800)]
This should really be a cond_set_smb_read_error().
Jeremy.
(This used to be commit 5ab76b58c00dde89b56060482f5cdc5d0c6c56cb)

13 years agoDon't use 0 when we mean SMB_READ_OK.
Jeremy Allison [Mon, 5 Nov 2007 06:12:31 +0000 (22:12 -0800)]
Don't use 0 when we mean SMB_READ_OK.
Jeremy.
(This used to be commit 08ee4314a9e25700288f4ea1af22ee1732dfea61)

13 years agoMerge commit 'origin/v3-2-test' into branches/upstream
Günther Deschner [Mon, 5 Nov 2007 02:39:18 +0000 (03:39 +0100)]
Merge commit 'origin/v3-2-test' into branches/upstream
(This used to be commit d0bf0ad2ae9a2bff4cec8c7e801a22c624b874ae)

13 years agoRemove unnecessary code
Volker Lendecke [Thu, 1 Nov 2007 16:42:35 +0000 (17:42 +0100)]
Remove unnecessary code

SAFE_FREE checks for NULL anyway, and SMB_STRDUP panics on failure
(This used to be commit 4cdebda39b9b1790fc5c7df3dc81bfb46b047ad7)

13 years agoFix a debug message
Volker Lendecke [Tue, 30 Oct 2007 21:58:09 +0000 (22:58 +0100)]
Fix a debug message
(This used to be commit a86849e4f9512b680f26010c297cec14251dafdd)

13 years agoDisplay sec ace flags.
Günther Deschner [Fri, 26 Oct 2007 10:58:01 +0000 (12:58 +0200)]
Display sec ace flags.

Guenther
(This used to be commit 52bf835c5e9b2fa759c61bf4a7a364eeaeae6043)

13 years agoMake sure we can read SACLs from the registry.
Günther Deschner [Mon, 5 Nov 2007 01:33:58 +0000 (02:33 +0100)]
Make sure we can read SACLs from the registry.

Guenther
(This used to be commit 62d4cce4562b77403f9353d333b9553352bdf1d8)

13 years agoFix the smbmount build
Volker Lendecke [Mon, 5 Nov 2007 02:14:16 +0000 (03:14 +0100)]
Fix the smbmount build
(This used to be commit 5b8ca7ebdef5d385420c89af246c2dae737c5717)

13 years agostatic pstring removal
Volker Lendecke [Sun, 4 Nov 2007 17:15:37 +0000 (18:15 +0100)]
static pstring removal
(This used to be commit 5490e2d77233f594a42cb32eda8215014db544e3)

13 years agopstring removal
Volker Lendecke [Thu, 1 Nov 2007 16:49:31 +0000 (17:49 +0100)]
pstring removal
(This used to be commit f5468d2c9abad41cb1e9d9b9ec6a1b56564961a4)

13 years agoMake load_registry_service return the share number
Volker Lendecke [Sat, 3 Nov 2007 14:03:26 +0000 (15:03 +0100)]
Make load_registry_service return the share number
(This used to be commit 934964c90f39d588d2399f10e3738ab1b4e01290)

13 years agoForgot arg type.
Jeremy Allison [Mon, 5 Nov 2007 01:15:35 +0000 (17:15 -0800)]
Forgot arg type.
Jeremy.
(This used to be commit 46f3b04ddea4c63c6b37c7038d4bbd2ee1c9ca0c)

13 years agoDon't believe len returned from read_smb_length_return_keepalive(),
Jeremy Allison [Sun, 4 Nov 2007 23:38:43 +0000 (15:38 -0800)]
Don't believe len returned from read_smb_length_return_keepalive(),
it may be a UNIX large writeX (which wraps len in that case).
Stevef this should fix your 128k write bug.
Jeremy.
(This used to be commit de2ebffa3c99ed28a3868fd956ef45629ca855b6)

13 years agoRemove most of the remaining globals out of lib/util_sock.c.
Jeremy Allison [Sun, 4 Nov 2007 06:20:10 +0000 (23:20 -0700)]
Remove most of the remaining globals out of lib/util_sock.c.
I have a plan for dealing with the remaining..... Watch
this space.
Jeremy.
(This used to be commit 963fc7685212689f02b3adcc05b4273ee5c382d4)

13 years agoRemove more static data from lib/util_sock.c and
Jeremy Allison [Sun, 4 Nov 2007 05:34:46 +0000 (22:34 -0700)]
Remove more static data from lib/util_sock.c and
callers.
Jeremy.
(This used to be commit 35aaa36f82c70964cee5d0778eb04547b226dd3f)

13 years agoMissed one case where I need to pass down addrlen.
Jeremy Allison [Sun, 4 Nov 2007 03:27:59 +0000 (20:27 -0700)]
Missed one case where I need to pass down addrlen.
Jeremy
(This used to be commit 62b5ca3334598aec3304d21118f67702afc3854a)

13 years agoI can't get away without a 'length' arg. :-).
Jeremy Allison [Sun, 4 Nov 2007 01:41:26 +0000 (18:41 -0700)]
I can't get away without a 'length' arg. :-).
Jeremy.
(This used to be commit 95d01279a5def709d0a5d5ae7224d6286006d120)

13 years agoStop get_peer_addr() and client_addr() from using global
Jeremy Allison [Sun, 4 Nov 2007 01:15:45 +0000 (18:15 -0700)]
Stop get_peer_addr() and client_addr() from using global
statics. Part of my library cleanups.
Jeremy.
(This used to be commit e848506c858bd16706c1d7f6b4b032005512b8ac)

13 years agoRemove the smb_read_error global variable and replace
Jeremy Allison [Sat, 3 Nov 2007 22:12:42 +0000 (15:12 -0700)]
Remove the smb_read_error global variable and replace
it with accessor functions. "One global or pstring a day...." :-).
Jeremy.
(This used to be commit d50d14c300abc83b7015718ec48acc8b3227a273)

13 years agoRemove unused var noticed by metze.
Jeremy Allison [Sat, 3 Nov 2007 17:25:51 +0000 (10:25 -0700)]
Remove unused var noticed by metze.
Jeremy.
(This used to be commit ac4f897f0dec0e33e79c316340b47c2803104635)

13 years agoFix the snprintf checks, and fix a typo in pointer indirection.
Jeremy Allison [Fri, 2 Nov 2007 21:23:10 +0000 (14:23 -0700)]
Fix the snprintf checks, and fix a typo in pointer indirection.
These fixes are needed for a working getaddrinfo etc. replacement.
Fixes from Wayne Davison <wayned@samba.org> from rsync.
Jeremy.
(This used to be commit 494bf6293bedbda4b10aa2eae452377b8130cd01)

13 years agoEnsure we use the correct socklen_t values for bind() for
Jeremy Allison [Fri, 2 Nov 2007 21:22:19 +0000 (14:22 -0700)]
Ensure we use the correct socklen_t values for bind() for
Solaris.
Jeremy.
(This used to be commit 638579d75a2aa00836dc4c0c772381b775944b16)

13 years agoFix typos in calc_sa_size, noticed by jim.brown@miami.edu
Jeremy Allison [Fri, 2 Nov 2007 19:56:21 +0000 (12:56 -0700)]
Fix typos in calc_sa_size, noticed by jim.brown@miami.edu
Jeremy.
(This used to be commit 6b7ccd3efb05291f3b8779845a3842a09bb9aa07)

13 years agoChange the client library to write directly out of
Jeremy Allison [Fri, 2 Nov 2007 19:21:34 +0000 (12:21 -0700)]
Change the client library to write directly out of
the incoming buffer in the non-signed case. Speeds
up writes by over 10% or so. Complete the server
recvfile implementation.
Jeremy.
(This used to be commit 81ca5853b2475f123faab3b550f0a7b24ae3c208)

13 years agoMerge branch 'v3-2-test' of ssh://jra@git.samba.org/data/git/samba into v3-2-test
Jeremy Allison [Fri, 2 Nov 2007 19:06:15 +0000 (12:06 -0700)]
Merge branch 'v3-2-test' of ssh://jra@git.samba.org/data/git/samba into v3-2-test
(This used to be commit 319dfbaf1b8d08171731d4575127f4bb5255a229)

13 years agoForgot one more getnameinfo.
Jeremy Allison [Fri, 2 Nov 2007 19:05:17 +0000 (12:05 -0700)]
Forgot one more getnameinfo.
Jeremy.
(This used to be commit 619e33248d12e764e902e4fdb5fb223cb9cfea3b)

13 years agoMerge branch 'v3-2-test' of git://git.samba.org/samba into v3-2-test
Gerald (Jerry) Carter [Fri, 2 Nov 2007 18:16:40 +0000 (14:16 -0400)]
Merge branch 'v3-2-test' of git://git.samba.org/samba into v3-2-test
(This used to be commit 95de80218c10a72c7b28541c3c2e475e083b68f1)

13 years agoFix build breakage when not specifying --with-fhs.
Gerald (Jerry) Carter [Fri, 2 Nov 2007 18:16:06 +0000 (14:16 -0400)]
Fix build breakage when not specifying --with-fhs.
Ensure that CODEPAGEDIR, STATEDIR, and CACHEDIR have values.
(This used to be commit 10af752391be51c7381a4eaca27f29e1f2a677b3)

13 years agoArgggh. smblen doesn't include the +4, so my smb_doff calculations
Jeremy Allison [Fri, 2 Nov 2007 17:35:10 +0000 (10:35 -0700)]
Argggh. smblen doesn't include the +4, so my smb_doff calculations
shouldn't either :-).
Jeremy.
(This used to be commit c3de44b6b063e126095b30536fdcb643c70e395e)

13 years agoFix Solaris by ensuring we use the IPv4 or IPv6 length
Jeremy Allison [Fri, 2 Nov 2007 17:25:34 +0000 (10:25 -0700)]
Fix Solaris by ensuring we use the IPv4 or IPv6 length
in any getnameinfo calls.
Jeremy
(This used to be commit 4d7badb0c44f287034f58d9a412e662c0fbecdc9)

13 years agoFix state_path to take a const string, not use pstring.
Jeremy Allison [Fri, 2 Nov 2007 16:27:04 +0000 (09:27 -0700)]
Fix state_path to take a const string, not use pstring.
Jeremy.
(This used to be commit 8c73e19f51d6e3f520cf44dd22f9b9584d4b460f)

13 years agoEnsure we can't accidently do a pipe write with
Jeremy Allison [Fri, 2 Nov 2007 05:42:21 +0000 (22:42 -0700)]
Ensure we can't accidently do a pipe write with
unread bytes in the socket buffer.
Jeremy
(This used to be commit 84d22f7747126608b9460f9591bb5967d871b82d)

13 years agoBe careful and take care of the correct lengths in large
Jeremy Allison [Fri, 2 Nov 2007 05:24:39 +0000 (22:24 -0700)]
Be careful and take care of the correct lengths in large
writeX calls.
Jeremy.
(This used to be commit 2d3ff9c502105f92720131355b41e48be8d656c2)

13 years agoEnsure we detect a large writeX when using recvfile.
Jeremy Allison [Fri, 2 Nov 2007 04:51:45 +0000 (21:51 -0700)]
Ensure we detect a large writeX when using recvfile.
More changes needed to make the UNIX_LARGE_WRITEX_CAP
writes work (I'll add these tomorrow).
Jeremy.
(This used to be commit 1c71546b6152d2930b98f766311bbd161ee0ee4e)

13 years agoMerge branch 'v3-2-test' of git://git.samba.org/samba into v3-2-test
Gerald (Jerry) Carter [Fri, 2 Nov 2007 01:30:43 +0000 (21:30 -0400)]
Merge branch 'v3-2-test' of git://git.samba.org/samba into v3-2-test
(This used to be commit 779353b86d1699324149896f1ffa237c6ebe46ec)

13 years agoAdd brackets so as not to break the POSIX caps return.
Jeremy Allison [Fri, 2 Nov 2007 01:30:02 +0000 (18:30 -0700)]
Add brackets so as not to break the POSIX caps return.
Jeremy.
(This used to be commit 47dbddcb5361caa30ee60cf4e15bb50d557d1191)

13 years agoFix for bug 5021
Volker Lendecke [Sat, 20 Oct 2007 09:12:11 +0000 (11:12 +0200)]
Fix for bug 5021

This is a different fix than the bug reporter (Evgeniy Dushistov
<dushistov at mail.ru>, thanks!) created, but it lives without the boolean
status variable. Untested so far, but I can not add attachments to bugs right
now. But to me this looks really obvious.
(This used to be commit b481abf5914dcafe5642c4d9394d02603e905bbb)

13 years agoPatch 2 of 3 from Debian Samba packagers:
Gerald (Jerry) Carter [Thu, 1 Nov 2007 19:53:44 +0000 (15:53 -0400)]
Patch 2 of 3 from Debian Samba packagers:

The point is doing the following associations:

- non discardable state data (all TDB files that may need to be backed
  up) go to statedir
- shared data (codepage stuff) go to codepagedir

The patch *does not change* the default location for these
directories. So, there is no behaviour change when applying it.

The main change is for samba developers who have to think when dealing
with files that previously pertained to libdir whether they:
- go in statedir
- go in codepagedir
- stay in libdir
(This used to be commit d6cdbfd875bb2653e831d314726c3240beb0a96b)

13 years agosave memory
Volker Lendecke [Wed, 31 Oct 2007 14:06:22 +0000 (15:06 +0100)]
save memory

Hi!

Attached find a patch that I've wanted to check in for ages.
The whole area probably needs a major rewrite, but this is a
minimal patch that on a 32-bit box saves 1.5k per smbd per
defined share, twice as much on a 64-bit box.

Volker

From ebb80e664ecc49eb597a45cb57e1067fbae49e62 Mon Sep 17 00:00:00 2001
From: Volker Lendecke <vl@sernet.de>
Date: Wed, 31 Oct 2007 15:04:34 +0100
Subject: [PATCH] Change global->copymap from bool* to a bitmap

We right now have 401 parameters, so with bool being represented as a 64-bit
integer this saves about 3k of memory per smbd per share that is defined in
smb.conf.
(This used to be commit 94f2c35a683eace7f9f3dad9748aaec93f7c534f)

13 years agoAdd missing recvfile_bytes element - noticed by Kukks.
Jeremy Allison [Thu, 1 Nov 2007 17:21:27 +0000 (10:21 -0700)]
Add missing recvfile_bytes element - noticed by Kukks.
Jeremy.
(This used to be commit 5cf2811e8e1d9e6a1114bbdff89c333d5b374282)

13 years agoPatch from Debian Samba package maintainers:
Gerald (Jerry) Carter [Thu, 1 Nov 2007 17:00:10 +0000 (13:00 -0400)]
Patch from Debian Samba package maintainers:

Patch 1 of 3:

- Patch 1 adds the new variables
- Patch 2 makes uses of them for files belonging to the "state" path
  and the "code pages" path
  This patch seemed more easily acceptable, which explains why we
  separated it from patch 3
- Patch 3 reassigns files to the "cache" path. Indeed all "debatable"
  changes have been moved to that one

The point is adding:

- a path for non discardable state data: basically all TDB files
  that may need to be backed up
- a path for shared data: mostly codepage stuff
- a path for cache data to host files such as
  browse.dat, printers.tbd, <printer>.tdb

All these are currently mixed in "libdir" (${prefix}/lib/samba by default).
The patch keeps these new paths to point to ${prefix}/lib/samba by default
and does therefore not change the software behaviour.  Used alone, it just
adds unused variables...so it can safely be used in sources without any
behaviour change and no impact on Samba developers work.
(This used to be commit b7d2fadbef044a89920da613b1aafc74a3d94e24)

13 years agoEnable building the zfsacl VFS module by specifying
Michael Adam [Thu, 1 Nov 2007 13:24:27 +0000 (14:24 +0100)]
Enable building the zfsacl VFS module by specifying
"--with-shared-modules=vfs_zfsacl" on the configure command line.

Michael
(This used to be commit 69135360648e395eda29b15625b20a877e38bdd8)

13 years agoNote when we're setting change time, not write time, and send
Jeremy Allison [Wed, 31 Oct 2007 23:32:48 +0000 (16:32 -0700)]
Note when we're setting change time, not write time, and send
message accordingly. Apart from not supporting create time we
now pass the S4 RAW-NOTIFY torture.
Jeremy.
(This used to be commit 8a77f520fa03afa60eac2aaeab4babe7dd8db4f0)

13 years agoFix some cases where file_set_dosmode was being passed
Jeremy Allison [Wed, 31 Oct 2007 22:45:45 +0000 (15:45 -0700)]
Fix some cases where file_set_dosmode was being passed
False instead of NULL. Fix more of the notifications to
be correct for Samba4 RAW-NOTIFY torture (we had missed
one when calling set_ea_dos_attribute().
Jeremy.
(This used to be commit 39d265375cf55eedddef2c4faa65398df73d5ed2)

13 years agoFix vfstest link - move socket calls into smbd/process.c
Jeremy Allison [Wed, 31 Oct 2007 21:24:52 +0000 (14:24 -0700)]
Fix vfstest link - move socket calls into smbd/process.c
not smbd/server.c
Jeremy
(This used to be commit 8fbefe18a2dc23adb0ebe488cfb37ab4a382207d)

13 years agoAdd printout of large read/write caps if detected.
Jeremy Allison [Wed, 31 Oct 2007 21:12:50 +0000 (14:12 -0700)]
Add printout of large read/write caps if detected.
Jeremy.
(This used to be commit 52f13d84955224ebbaead53d8428baade6a22fe0)

13 years agoMake explicit draining the socket on RECVFILE. Add
Jeremy Allison [Wed, 31 Oct 2007 21:01:35 +0000 (14:01 -0700)]
Make explicit draining the socket on RECVFILE. Add
capability for large UNIX write if not signing and
recvfile set. Cope with large UNIX write length on
incoming processing. Stevef - we can now test 1-16Mb
writes from CIFFS.
Jeremy.
(This used to be commit 8cf78776b0a44bd026cef3d74eb11cfb415f8303)

13 years agoHandle the disk full error case correctly.
Jeremy Allison [Wed, 31 Oct 2007 01:18:40 +0000 (18:18 -0700)]
Handle the disk full error case correctly.
Jeremy.
(This used to be commit b7088bb9c2a00d4717b9a7efa4bddc0c005f4efb)

13 years agoEnsure we don't prematurely clean out the bytes read.
Jeremy Allison [Wed, 31 Oct 2007 00:42:02 +0000 (17:42 -0700)]
Ensure we don't prematurely clean out the bytes read.
Jeremy.
(This used to be commit 247675695dfbff503b5792de62f8bb1567ea2327)

13 years agoAdd new parameter, "min receivefile size" (by default set
Jeremy Allison [Tue, 30 Oct 2007 23:22:24 +0000 (16:22 -0700)]
Add new parameter, "min receivefile size" (by default set
to zero). If non-zero, writeX calls greater than this
value will be left in the socket buffer for later handling
with recvfile (or userspace equivalent). Definition of
recvfile for your system is left as an exercise for
the reader (I'm working on getting splice working :-).
Jeremy.
(This used to be commit 11c03b75ddbcb6e36b231bb40a1773d1c550621c)

13 years agoMerge branch 'v3-2-test' of ssh://jra@git.samba.org/data/git/samba into v3-2-test
Jeremy Allison [Tue, 30 Oct 2007 19:55:56 +0000 (12:55 -0700)]
Merge branch 'v3-2-test' of ssh://jra@git.samba.org/data/git/samba into v3-2-test
(This used to be commit 765b37c693516757686118fffd3c80cf4d5e7344)

13 years agoOur userlevel SMBwriteX call is non-standard in that it
Jeremy Allison [Tue, 30 Oct 2007 19:54:39 +0000 (12:54 -0700)]
Our userlevel SMBwriteX call is non-standard in that it
sometimes uses a 12-word write and doesn't include a pad
byte (as Windows does). Fix this so that we are identical
to Windows clients. This will make recvfile processing
much easier to detect (as we can just read a standard
writeX header length to decide).
Jeremy.
(This used to be commit 3d3d1b806aef3617abaac46daf230ed32076e2ce)

13 years agoMerge branch 'v3-2-test' of ssh://jra@git.samba.org/data/git/samba into v3-2-test
Jeremy Allison [Tue, 30 Oct 2007 17:19:45 +0000 (10:19 -0700)]
Merge branch 'v3-2-test' of ssh://jra@git.samba.org/data/git/samba into v3-2-test
(This used to be commit c833c336435cffd20579903d22ccb910ab467e53)

13 years agostart smbd, nmbd and winbindd with the same startup message
Stefan Metzmacher [Tue, 30 Oct 2007 14:44:27 +0000 (15:44 +0100)]
start smbd, nmbd and winbindd with the same startup message
at debug level 0.

metze
(This used to be commit 95f76ae7a52c6b22db22d03fed6b0848d2a61bee)

13 years agoForgot to add recvfile.c
Jeremy Allison [Tue, 30 Oct 2007 00:17:16 +0000 (17:17 -0700)]
Forgot to add recvfile.c
Jeremy.
(This used to be commit d5886218e53910b7015e6f13bc634e1bf338565a)

13 years agoAdd in the recvfile entry to the VFS layer with a default
Jeremy Allison [Tue, 30 Oct 2007 00:16:13 +0000 (17:16 -0700)]
Add in the recvfile entry to the VFS layer with a default
implementation. Needed for the zero-copy write code.
Jeremy.
(This used to be commit bfbdb6324c5d13bfde8b742e9c5a0e0c9092bd86)

13 years agoFix the setup_kaddr() call to cope with IPv6.
Jeremy Allison [Mon, 29 Oct 2007 22:03:36 +0000 (15:03 -0700)]
Fix the setup_kaddr() call to cope with IPv6.
This is the last obvious change I can see. At
this point we can start claiming IPv6 support
(Hurrah !:-).
Jeremy.
(This used to be commit bda8c0bf571c994b524a9d67eebc422033d17094)

13 years agoChange our DNS code to cope with AAAA records. A6 records
Jeremy Allison [Mon, 29 Oct 2007 20:34:00 +0000 (13:34 -0700)]
Change our DNS code to cope with AAAA records. A6 records
look like a nightmare to use, so ignore them for now.
Jeremy.
(This used to be commit 814daded90781dc5a5bdd522ea8cfe5d47e6d7a7)

13 years agoEnable vfs objects = /full/path/to/object.so
Volker Lendecke [Sun, 28 Oct 2007 10:58:26 +0000 (11:58 +0100)]
Enable vfs objects = /full/path/to/object.so

Right now I'm testing a vfs object. I can't right now in make test, because
"vfs objects" assumes the .so files to be in $libdir/vfs. This patch parses the
module name out of the object name in case it starts with "/". The module name
is assumed to be the last path component's basename.
(This used to be commit 95cc019af775a6ab28ea602ad767fa54d7c86197)

13 years agoChange all occurrences of zero_addr(&ss,AF_INET) to
Jeremy Allison [Sun, 28 Oct 2007 03:29:36 +0000 (20:29 -0700)]
Change all occurrences of zero_addr(&ss,AF_INET) to
zero_addr(&ss). All current uses were always of the
AF_INET form, so simplify the call. If in the future
we need to zero an addr to AF_INET6 this can be
done separately.
Jeremy.
(This used to be commit 2e92418a138bf2738b77b7e0fcb2fa37ad84fc0c)

13 years agoFix zero_addr(&ip, INADDR_ANY); -> zero_addr(&ip, AF_INET)
Jeremy Allison [Sat, 27 Oct 2007 19:51:38 +0000 (12:51 -0700)]
Fix zero_addr(&ip, INADDR_ANY); -> zero_addr(&ip, AF_INET)
from Volker's patch.
Jeremy.
(This used to be commit 9f82a5766968dc72db5a86ad0afc71e8cffd5be0)

13 years agoTwo patches
Volker Lendecke [Sat, 27 Oct 2007 19:15:07 +0000 (21:15 +0200)]
Two patches

Hi!

Can you check and push them?

Thanks,

Volker

From b488af5905e2dee12a1a72a3b40801ae5c26f24f Mon Sep 17 00:00:00 2001
From: Volker Lendecke <vl@sernet.de>
Date: Sat, 27 Oct 2007 14:20:09 +0200
Subject: [PATCH] Fix some warnings and errors
(This used to be commit e17d3e10e860c96b6d5208e5fe51e43b8e58c174)

13 years agorerun make idl
Stefan Metzmacher [Sat, 27 Oct 2007 09:57:48 +0000 (11:57 +0200)]
rerun make idl

metze
(This used to be commit 83b3ecde1312092fd9875a2a8628652ffa6b6aca)

13 years agoadd NDR_ERR_INVALID_POINTER
metze [Sat, 27 Oct 2007 08:10:14 +0000 (08:10 +0000)]
add NDR_ERR_INVALID_POINTER

metze

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_4_0@25744 0c0555d6-39d7-0310-84fc-f1cc0bd64818
(This used to be commit 3625ed395c23101095321de80e89fcbc8c76be4c)

13 years agoEnsure temporary memory is freed - pointed out by "Li, Ying (ESG)" <ying.li2@hp.com>.
Jeremy Allison [Sat, 27 Oct 2007 00:58:28 +0000 (17:58 -0700)]
Ensure temporary memory is freed - pointed out by "Li, Ying (ESG)" <ying.li2@hp.com>.
We aren't currently leaking memory, but are leaving it around for
longer than we need to.
Jeremy.
(This used to be commit 25bbc9a6613bef0f3f73ecf634a38a9d56020f40)

13 years agoFix popt bool problems (need POPT_ARG_NONE, not POPT_ARG_VALUE).
Jeremy Allison [Fri, 26 Oct 2007 23:22:18 +0000 (16:22 -0700)]
Fix popt bool problems (need POPT_ARG_NONE, not POPT_ARG_VALUE).
Reported by kukks - thanks !
Jeremy.
(This used to be commit 9993f8d1af23735f3a4b6de82f5825a6a6ba22d6)

13 years agoMove the horrible hack for link local addresses out of namequery.c
Jeremy Allison [Fri, 26 Oct 2007 23:03:20 +0000 (16:03 -0700)]
Move the horrible hack for link local addresses out of namequery.c
and into util_sock.c. is_ipaddress() now copes with link:local:v6%ifname
addresses, as does interpret_string_addr().
Jeremy
(This used to be commit a3f7db3d30ced566c8340696914f1be3293a9c5b)

13 years agoFix a few more sockaddr -> sockaddr_storgage.
Jeremy Allison [Fri, 26 Oct 2007 23:02:16 +0000 (16:02 -0700)]
Fix a few more sockaddr -> sockaddr_storgage.
Jeremy.
(This used to be commit 4b3635d6bc1bd5e4135ef208dff052e1d9b58a12)

13 years agoone more struct in_addr => struct sockaddr_storage
Stefan Metzmacher [Fri, 26 Oct 2007 14:37:32 +0000 (16:37 +0200)]
one more struct in_addr => struct sockaddr_storage

jra: please check this...

metze
(This used to be commit cecc8075513a3cca17aeab0c88ae05ed13a07ee3)

13 years agoFix bug in writing names into gencache
Jeremy Allison [Fri, 26 Oct 2007 02:07:25 +0000 (19:07 -0700)]
Fix bug in writing names into gencache
as well as 2 typos where AF_INET6 was mistypes as AF_INET.
JERRY YOU NEED THESE FIXES.
Fixes smbclient -L localhost -U%
Bugs reported by Kukks (thanks kukks).
Jeremy.
(This used to be commit f109f82622ca30ae2360e8300152e90b9587ffd8)

13 years agoFix resolve name to resolve IPv6 addresses of link-local%ifaddr
Jeremy Allison [Fri, 26 Oct 2007 01:28:36 +0000 (18:28 -0700)]
Fix resolve name to resolve IPv6 addresses of link-local%ifaddr
Jeremy.
(This used to be commit e6609cab732d5cd5cc9a5ae50aee15147f2ec6ec)

13 years agoFix a mismatched interface where we were using
Jeremy Allison [Fri, 26 Oct 2007 01:29:49 +0000 (18:29 -0700)]
Fix a mismatched interface where we were using
uint32 instead of enum lsa_SidType.
Jeremy.
(This used to be commit 2df8252ff76406bfe57cd76e9927b5056e89e6ae)

13 years agoFix cast typo - would have broken all dgram sends.
Jeremy Allison [Fri, 26 Oct 2007 01:15:02 +0000 (18:15 -0700)]
Fix cast typo - would have broken all dgram sends.
Jeremy.
(This used to be commit 17ea899f39e80241afa235cb933695ba6bae846a)

13 years agoFixed missing in_addr -> sockaddr_storage conversion (how did
Jeremy Allison [Fri, 26 Oct 2007 01:11:29 +0000 (18:11 -0700)]
Fixed missing in_addr -> sockaddr_storage conversion (how did
I miss this...).
Jeremy.
(This used to be commit f982774c8d95c48355bbd821c8224fadb8bb303e)

13 years agoFix reversed bool check for access. Found by kukks.
Jeremy Allison [Fri, 26 Oct 2007 00:17:46 +0000 (17:17 -0700)]
Fix reversed bool check for access. Found by kukks.
Thanks !
Jeremy.
(This used to be commit a13e8bd39de978d69666b8aeb884d943885a3605)

13 years agoMerge branch 'v3-2-test' of ssh://jra@git.samba.org/data/git/samba into v3-2-test
Jeremy Allison [Thu, 25 Oct 2007 23:22:40 +0000 (16:22 -0700)]
Merge branch 'v3-2-test' of ssh://jra@git.samba.org/data/git/samba into v3-2-test
(This used to be commit ec891be53cc4042baf418c1f7b037a11e5055273)

13 years agoWhen doing reverse lookups actually look up the name, not
Jeremy Allison [Thu, 25 Oct 2007 23:14:52 +0000 (16:14 -0700)]
When doing reverse lookups actually look up the name, not
just the numeric address (doh!) :-).
Jeremy.
(This used to be commit 9aa9ecd8cc29d055d78f16b8fb2156ec04063c42)

13 years agoTry and fix the Solaris build by adding a missing define
Jeremy Allison [Thu, 25 Oct 2007 22:43:44 +0000 (15:43 -0700)]
Try and fix the Solaris build by adding a missing define
(from Jerry).
Jeremy
(This used to be commit a68bbea0d42cc64b9fa731ab2a1da82ef30937c6)

13 years agoEnsure we don't terminate if we fail to bind to a socket,
Jeremy Allison [Thu, 25 Oct 2007 21:11:35 +0000 (14:11 -0700)]
Ensure we don't terminate if we fail to bind to a socket,
only fail if we can't bind to any socket.
Jeremy.
(This used to be commit 2ec6224b552ef86fa1739c9e396c39c7ec6c76c6)

13 years ago[libreplace] define AI_NUMERICSERV as it's used in getaddrinfo.c
metze [Thu, 25 Oct 2007 09:16:11 +0000 (09:16 +0000)]
[libreplace] define AI_NUMERICSERV as it's used in getaddrinfo.c

metze

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_4_0@25728 0c0555d6-39d7-0310-84fc-f1cc0bd64818
(This used to be commit 11a977aa0757801fb0fa805b123e7bc75c8be447)

13 years ago[libreplace] move and fix getaddrinfo configure checks
metze [Thu, 25 Oct 2007 08:43:00 +0000 (08:43 +0000)]
[libreplace] move and fix getaddrinfo configure checks

- move getaddrinfo check into getaddrinfo.m4
- add getaddrinfo.o to LIBREPLACEOBJ so that we really build the replacements

metze

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_4_0@25726 0c0555d6-39d7-0310-84fc-f1cc0bd64818
(This used to be commit de01c503f4d16b8c3c0ad75225cf0b1822fd8c7f)

13 years ago- include getaddrinfo.h after we have defined struct addrinfo
metze [Thu, 25 Oct 2007 06:53:38 +0000 (06:53 +0000)]
- include getaddrinfo.h after we have defined struct addrinfo
- use rep_ instead of pg_ as prefix in getaddrinfo.[ch]
- define HAVE_<name> macros when we replace functions

metze

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_4_0@25724 0c0555d6-39d7-0310-84fc-f1cc0bd64818
(This used to be commit e56977ea459b3615d33237d19ed8e7ad8b509853)

13 years ago[libreplace] if we replace types define the HAVE_<type> macro
metze [Wed, 24 Oct 2007 13:01:03 +0000 (13:01 +0000)]
[libreplace] if we replace types define the HAVE_<type> macro

this is needed as heimdal's roken.h also tries to replace the types

metze

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_4_0@25718 0c0555d6-39d7-0310-84fc-f1cc0bd64818
(This used to be commit b81d8bc43cd7167a5cd4b18c26ba3eecf75043eb)

13 years ago[libreplace] move definition of struct addrinfo so that it can use socklen_t
metze [Wed, 24 Oct 2007 12:57:57 +0000 (12:57 +0000)]
[libreplace] move definition of struct addrinfo so that it can use socklen_t

metze

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_4_0@25715 0c0555d6-39d7-0310-84fc-f1cc0bd64818
(This used to be commit 45150075677451b48ce56ebdce96aca1ed13fa80)

13 years ago[libreplace] move define of a constant to near to the others
metze [Wed, 24 Oct 2007 12:55:40 +0000 (12:55 +0000)]
[libreplace] move define of a constant to near to the others

metze

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_4_0@25714 0c0555d6-39d7-0310-84fc-f1cc0bd64818
(This used to be commit fa120f7c50d0084e7d887811e5fa59ae3bcfe53e)

13 years ago[libreplace] include socket_wrapper.h after we have typedef'ed socklen_t
metze [Wed, 24 Oct 2007 12:53:34 +0000 (12:53 +0000)]
[libreplace] include socket_wrapper.h after we have typedef'ed socklen_t

metze

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_4_0@25713 0c0555d6-39d7-0310-84fc-f1cc0bd64818
(This used to be commit f1d434a132e424f2fdce59d51a7c398988c1474d)

13 years agoDon't terminate on an invalid address family.
Jeremy Allison [Wed, 24 Oct 2007 23:11:01 +0000 (16:11 -0700)]
Don't terminate on an invalid address family.
Jeremy.
(This used to be commit d04a8a6cdcc505e0244882a9abb7174eadbf81a7)

13 years agoWe do support name lookups for host and service in our replacement
Jeremy Allison [Wed, 24 Oct 2007 21:40:24 +0000 (14:40 -0700)]
We do support name lookups for host and service in our replacement
code - remove the restrictions from the original Postgres code.
Jeremy.
(This used to be commit bc9008aa1dcb66890795f0ff2d3046da7df867d9)

13 years agoThis is a large patch (sorry). Migrate from struct in_addr
Jeremy Allison [Wed, 24 Oct 2007 21:16:54 +0000 (14:16 -0700)]
This is a large patch (sorry). Migrate from struct in_addr
to struct sockaddr_storage in most places that matter (ie.
not the nmbd and NetBIOS lookups). This passes make test
on an IPv4 box, but I'll have to do more work/testing on
IPv6 enabled boxes. This should now give us a framework
for testing and finishing the IPv6 migration. It's at
the state where someone with a working IPv6 setup should
(theorecically) be able to type :
smbclient //ipv6-address/share
and have it work.
Jeremy.
(This used to be commit 98e154c3125d5732c37a72d74b0eb5cd7b6155fd)

13 years agoFix for AIX interface code from Kyle Stemen <kstemen@centeris.com>
Jeremy Allison [Wed, 24 Oct 2007 19:44:38 +0000 (12:44 -0700)]
Fix for AIX interface code from Kyle Stemen <kstemen@centeris.com>
Jeremy.
(This used to be commit 4d4ab9aeb9d85b4c98cbf8a8363a9cefecd4b365)

13 years agohandle wellknown sids in winbindd_passwd.c
Stefan Metzmacher [Wed, 24 Oct 2007 11:19:35 +0000 (13:19 +0200)]
handle wellknown sids in winbindd_passwd.c

metze
(This used to be commit 251bd4ea4cdd0a751ed3b91562272221af148e37)

13 years ago[crash fix] don't use already free'ed memory
Stefan Metzmacher [Wed, 24 Oct 2007 12:29:06 +0000 (14:29 +0200)]
[crash fix] don't use already free'ed memory

(found by "make valgrindtest" and my "start winbindd on make test" patch)

metze
(cherry picked from commit fe21e48489852720a05b305b251e4f5cbb200f7a)
(cherry picked from commit 26d8a1ad20c10da495970c584983fbd261b4946e)
(This used to be commit a128a8805e172738334ec6854548f138c335058b)

13 years agoignore source/cscope.out
Stefan Metzmacher [Wed, 24 Oct 2007 09:19:29 +0000 (11:19 +0200)]
ignore source/cscope.out

metze
(This used to be commit 49b2b8784b75c10cdf6e91de6a06f0ca435089cc)

13 years agoadded a syncops VFS module for filesystems which do not guarantee meta-data operation...
Andrew Tridgell [Tue, 23 Oct 2007 10:43:27 +0000 (20:43 +1000)]
added a syncops VFS module for filesystems which do not guarantee meta-data operations are immediately committed to disk in stable form. Essential for clustered Samba setups
(This used to be commit 8b19cb17b9ae9e1cd4a96df6e7dedb75aff7ee96)

13 years agoReorder pthread mutex check so that it doesn't output its result
James Peach [Tue, 23 Oct 2007 05:03:40 +0000 (22:03 -0700)]
Reorder pthread mutex check so that it doesn't output its result
in the middle of the output for the winbind nss check.
(This used to be commit 1eddefa72cefd0c6836ddbe8eaef074ce732b0d9)

13 years agor25573: Add my (C) as well
Simo Sorce [Mon, 8 Oct 2007 12:56:57 +0000 (12:56 +0000)]
r25573: Add my (C) as well
(cherry picked from commit a024e27e7136deb87aeed995348a1c494a850ce6)
(This used to be commit 37ee6f498b175b8f3b7e75eba8dd7c709327384c)

13 years agor25571: split up child_dispatch_table into domain, idmap and locator tables
Stefan Metzmacher [Mon, 8 Oct 2007 12:25:57 +0000 (12:25 +0000)]
r25571: split up child_dispatch_table into domain, idmap and locator tables

metze
(cherry picked from commit abbb36a37c1dba2218a6c7ec31739eba5f250127)
(This used to be commit 5af1b45ed31043f952ec141d0f5f2973aec69d1a)

13 years agor25570: move code of the locator child into its own file
Stefan Metzmacher [Mon, 8 Oct 2007 11:15:28 +0000 (11:15 +0000)]
r25570: move code of the locator child into its own file

metze
(This used to be commit 56640908a6367acfdfd53568a0d329c13330e5eb)