13 years agos3:smbd: add support for SMB2 Keepalive (SMB2 Echo)
Stefan Metzmacher [Fri, 15 May 2009 10:07:28 +0000 (12:07 +0200)]
s3:smbd: add support for SMB2 Keepalive (SMB2 Echo)


13 years agos3:smbd: allow SMB 2.002 dialect in SMB1 negprot
Stefan Metzmacher [Tue, 19 May 2009 08:47:51 +0000 (10:47 +0200)]
s3:smbd: allow SMB 2.002 dialect in SMB1 negprot

We create a dummy SMB2 Negotiate inbuf and pass the
connection to the SMB2 engine.


13 years agos3:smbd: add support for SMB2 Negotiate
Stefan Metzmacher [Thu, 14 May 2009 13:32:02 +0000 (15:32 +0200)]
s3:smbd: add support for SMB2 Negotiate

This is not complete, but a start that makes the
samba4 smb2 client happy.


13 years agos3:smbd: make negprot_spnego() non static
Stefan Metzmacher [Tue, 19 May 2009 08:46:35 +0000 (10:46 +0200)]
s3:smbd: make negprot_spnego() non static


13 years agos3:smbd: add infrastructure for SMB2 support
Stefan Metzmacher [Thu, 14 May 2009 12:17:28 +0000 (14:17 +0200)]
s3:smbd: add infrastructure for SMB2 support

This is disabled by default and activated by
"max protocol = SMB2".


13 years agos3:param: add PROTOCOL_SMB2
Stefan Metzmacher [Tue, 19 May 2009 08:45:38 +0000 (10:45 +0200)]
s3:param: add PROTOCOL_SMB2


13 years agoSMB2-LOCK: let the test pass against samba4
Stefan Metzmacher [Wed, 20 May 2009 13:23:51 +0000 (15:23 +0200)]
SMB2-LOCK: let the test pass against samba4


13 years agoFix bug disclosed by lock8 torture test
Volker Lendecke [Mon, 18 May 2009 04:02:07 +0000 (06:02 +0200)]
Fix bug disclosed by lock8 torture test

We have to drop the gpfs level share modes, regardless of whether we put
the file into the pending close queue.

13 years agoDemonstrate a bug we have when dealing with real os-level share modes
Volker Lendecke [Wed, 20 May 2009 12:56:04 +0000 (14:56 +0200)]
Demonstrate a bug we have when dealing with real os-level share modes

Another one of those where you stare at logfiles for hours, and when you found
it, it's absolutely obvious what is happening...

13 years agos4: try to fix privileges implementation in order to pass the RPC-SAMR-USERS-PRIVILEG...
Günther Deschner [Wed, 20 May 2009 11:32:25 +0000 (13:32 +0200)]
s4: try to fix privileges implementation in order to pass the RPC-SAMR-USERS-PRIVILEGES test.


13 years agoHave ntvfs_connect() accept union smb_tcon *tcon instead of char* sharename
Sam Liddicott [Thu, 14 May 2009 07:58:50 +0000 (08:58 +0100)]
Have ntvfs_connect() accept union smb_tcon *tcon instead of char* sharename

This change brings ntvfs_connect into compliance with other ntvfs functions
which take an ntvfs module, an ntvfs request and an smb io union.

It now becomes the responsibility of ntvfs modules to examine
tcon->generic.level themselves and derive the share name and any other
directly; e.g.

const char *sharename;

switch (tcon->generic.level) {
sharename = tcon->;
sharename = tcon->;

if (strncmp(sharename, "\\\\", 2) == 0) {
char *p = strchr(sharename+2, '\\');
if (p) {
sharename = p + 1;

service.c smbsrv_tcon_backend() is called before ntvfs_connect and fills in
some of the tcon->..out values.
For the case of RAW_TCON_TCONX, it filles out tcon->tconx.out.tid and

For the case of RAW_TCON_TCON it fills out tcon->tcon.out.tid and

Thus the ntvfs_connect function for vfs modules may override these values
if desired, but are not required to.

ntvfs_connect functions are required to fill in the tcon->tconx.out.*_type
fields, for RAW_TCON_TCONX, perhaps something like:

if (tcon->generic.level == RAW_TCON_TCONX) {
tcon->tconx.out.fs_type = ntvfs->ctx->fs_type;
tcon->tconx.out.dev_type = ntvfs->ctx->dev_type;

Signed-off-by: Sam Liddicott <>
(I fixed the ntvfs_connect() in the smb_server/smb2/
 and the RAW_TCON_SMB2 switch case in the modules)

Signed-off-by: Stefan Metzmacher <>
13 years agos3-selftest: add add and delete group scripts using nss_wrapper.
Günther Deschner [Wed, 20 May 2009 00:12:17 +0000 (02:12 +0200)]
s3-selftest: add add and delete group scripts using nss_wrapper.


13 years agonsswrapper: implement group_del() in
Günther Deschner [Wed, 20 May 2009 00:10:12 +0000 (02:10 +0200)]
nsswrapper: implement group_del() in


13 years agonsswrapper: implement group_add() in
Günther Deschner [Wed, 20 May 2009 00:06:22 +0000 (02:06 +0200)]
nsswrapper: implement group_add() in


13 years agos4:smb_server: initialy read the first 4 bytes only
Sam Liddicott [Tue, 19 May 2009 14:42:39 +0000 (15:42 +0100)]
s4:smb_server: initialy read the first 4 bytes only

Stop packet_recv getting greedy and reading the whole socket
and then dispatching te extra packets in a timer loop

Signed-off-by: Sam Liddicott <>
Signed-off-by: Stefan Metzmacher <>
13 years agos4:libcli/raw: initialy read the first 4 bytes only
Stefan Metzmacher [Tue, 19 May 2009 14:18:38 +0000 (16:18 +0200)]
s4:libcli/raw: initialy read the first 4 bytes only


13 years agoDo not do a merged build without shared libs
Volker Lendecke [Wed, 20 May 2009 06:58:13 +0000 (08:58 +0200)]
Do not do a merged build without shared libs

Jelmer, you might want to take a look at Andrew B's problem with

--enable-developer --disable-shared --disable-shared-libs

13 years agoOnly build the krb5 locator when building shared libs
Volker Lendecke [Wed, 20 May 2009 06:39:45 +0000 (08:39 +0200)]
Only build the krb5 locator when building shared libs

13 years agoSet errno=ENOMEM if tevent_add_fd fails
Volker Lendecke [Tue, 19 May 2009 21:48:41 +0000 (23:48 +0200)]
Set errno=ENOMEM if tevent_add_fd fails

tevent_add_fd does not properly set that. At least in epoll and select this is
the only error condition.

Metze, please check!

13 years agoAdded mapping table for account object in lsa.
Jeremy Allison [Tue, 19 May 2009 21:47:25 +0000 (14:47 -0700)]
Added mapping table for account object in lsa.

13 years agoSimplify the logic of tsocket_bsd_pending
Volker Lendecke [Tue, 19 May 2009 21:31:55 +0000 (23:31 +0200)]
Simplify the logic of tsocket_bsd_pending

Remove two indentation levels by returning early on error.

Metze, please check!

13 years agotevent/python: Makefile was still trying to build some non AC_SUBST python targets
Jelmer Vernooij [Tue, 19 May 2009 21:31:34 +0000 (23:31 +0200)]
tevent/python: Makefile was still trying to build some non AC_SUBST python targets

Signed-Off-By: Jelmer Vernooij <>
13 years agoMake local-wbclient flexible in # of connections and ops
Volker Lendecke [Tue, 19 May 2009 21:07:36 +0000 (23:07 +0200)]
Make local-wbclient flexible in # of connections and ops

13 years agoFix wb_trans_done after conversion to unix calling conventions
Volker Lendecke [Tue, 19 May 2009 21:06:48 +0000 (23:06 +0200)]
Fix wb_trans_done after conversion to unix calling conventions

13 years agoFix an uninitialized variable in wb_context_init
Volker Lendecke [Tue, 19 May 2009 21:05:51 +0000 (23:05 +0200)]
Fix an uninitialized variable in wb_context_init

13 years agoAnother attempt at fixing the static build of vfs_notify_fam
Volker Lendecke [Tue, 19 May 2009 18:45:45 +0000 (20:45 +0200)]
Another attempt at fixing the static build of vfs_notify_fam

13 years agoFix detection of "enum FAMCodes"
Volker Lendecke [Tue, 19 May 2009 18:45:22 +0000 (20:45 +0200)]
Fix detection of "enum FAMCodes"

13 years agos3 onefs: Removing an incorrect TALLOC_FREE
Aravind Srinivasan [Thu, 14 May 2009 15:54:46 +0000 (15:54 +0000)]
s3 onefs: Removing an incorrect TALLOC_FREE

Signed-off-by: Tim Prouty <>
13 years agoUse TDB_VOLATILE instead of tdb_set_max_dead()
Volker Lendecke [Tue, 19 May 2009 12:51:03 +0000 (14:51 +0200)]
Use TDB_VOLATILE instead of tdb_set_max_dead()

13 years agos3/docs: Fix shutdown script example.
Karolin Seeger [Tue, 19 May 2009 11:42:16 +0000 (13:42 +0200)]
s3/docs: Fix shutdown script example.

This fixes bug #5897. Thanks to TAKAHASHI Motonobu
<monyo [at]> for reporting and providing the example!


13 years agos3: Always allocate memory in dptr_ReadDirName
Aravind Srinivasan [Mon, 11 May 2009 22:39:05 +0000 (22:39 +0000)]
s3: Always allocate memory in dptr_ReadDirName

This is a follow up to 69d61453df6019caef4e7960fa78c6a3c51f3d2a to
adjust the API to allow the lower layers allocate memory.  Now the
memory can explicitly be freed rather than relying on talloc_tos().

Signed-off-by: Tim Prouty <>
13 years agos4 torture: Fix typo
Tim Prouty [Tue, 19 May 2009 01:31:46 +0000 (18:31 -0700)]
s4 torture: Fix typo

13 years agos3 sendfile: Fix two bugs in sendfile
Tim Prouty [Tue, 19 May 2009 01:20:18 +0000 (18:20 -0700)]
s3 sendfile: Fix two bugs in sendfile

These were found interally via code inspection.

1) fake_sendfile was incorrectly writing zeros over real data on a
   short read.

2) sendfile_short_send was doing 4 byte writes instead of 1024 byte
   writes due to an incorrect sizeof usage.

Jermey, Vl please check

13 years agos4-smbtorture: Fix build warning in RPC-SAMR tests.
Günther Deschner [Tue, 19 May 2009 00:01:27 +0000 (02:01 +0200)]
s4-smbtorture: Fix build warning in RPC-SAMR tests.


13 years agos3: re-run make samba3-idl.
Günther Deschner [Tue, 19 May 2009 00:00:34 +0000 (02:00 +0200)]
s3: re-run make samba3-idl.


13 years agolsa: add access_masks for accounts, secrets and trusted domains to IDL.
Günther Deschner [Mon, 18 May 2009 23:59:55 +0000 (01:59 +0200)]
lsa: add access_masks for accounts, secrets and trusted domains to IDL.


13 years agoChange access_check_samr_object -> access_check_object.
Jeremy Allison [Mon, 18 May 2009 22:44:03 +0000 (15:44 -0700)]
Change access_check_samr_object -> access_check_object.
Make map_max_allowed_access global. Change lsa_get_generic_sd
to add Everyone:LSA_POLICY_READ|LSA_POLICY_EXECUTE, not just

13 years agos3-lsa: let _lsa_OpenPolicy() just call _lsa_OpenPolicy2().
Günther Deschner [Mon, 18 May 2009 22:16:26 +0000 (00:16 +0200)]
s3-lsa: let _lsa_OpenPolicy() just call _lsa_OpenPolicy2().


13 years agos3-selftest: enable RPC-SAMR-USERS-PRIVILEGES.
Günther Deschner [Mon, 18 May 2009 19:14:42 +0000 (21:14 +0200)]
s3-selftest: enable RPC-SAMR-USERS-PRIVILEGES.


13 years agoFix SAMR server for winbindd access. Ensure we allow
Jeremy Allison [Mon, 18 May 2009 21:26:37 +0000 (14:26 -0700)]
Fix SAMR server for winbindd access. Ensure we allow
MAX_ACCESS to be mapped to what we're giving Everyone.

13 years agos3-lsa: let _lsa_GetSystemAccessAccount() call into _lsa_EnumPrivsAccount().
Günther Deschner [Mon, 18 May 2009 19:05:08 +0000 (21:05 +0200)]
s3-lsa: let _lsa_GetSystemAccessAccount() call into _lsa_EnumPrivsAccount().

Inspired by lsa server from Samba 4.

Just removing a user in SAMR does not remove a user in LSA. If you use
usermanager from windows, the "User Rights" management gui gets unaccessable as
soon as you delete a user that had privileges granted. With this fix, that
no longer existing user would properly appear as an unknown account in the GUI
(as it does while using usermanager with windows domains).

This almost makes Samba3 pass the RPC-SAMR-USERS-PRIVILEGES test.


13 years agos3-lsa: start a very basic implementation of _lsa_DeleteObject().
Günther Deschner [Mon, 18 May 2009 19:00:29 +0000 (21:00 +0200)]
s3-lsa: start a very basic implementation of _lsa_DeleteObject().

Certainly not the full story but this gets us closer to pass the


13 years agos4-smbtorture: add RPC-SAMR-USERS-PRIVILEGES test.
Günther Deschner [Mon, 18 May 2009 17:37:13 +0000 (19:37 +0200)]
s4-smbtorture: add RPC-SAMR-USERS-PRIVILEGES test.

This test demonstrates the independence of the lsa and samr accounts while
remove a samr users that still has privileges granted.


13 years agoMove down the become_root()/unbecome_root() calls into the VFS modules
Volker Lendecke [Mon, 18 May 2009 11:30:16 +0000 (13:30 +0200)]
Move down the become_root()/unbecome_root() calls into the VFS modules

The aio_fork module does not need this, as it does not communicate via signals
but with pipes. Watching a strace log with those become_root() calls in aio.c
is absolutely awful, and it does affect performance.

13 years agoFix bug 5681: Do not limit the number of network interfaces
Volker Lendecke [Mon, 18 May 2009 08:32:27 +0000 (10:32 +0200)]
Fix bug 5681: Do not limit the number of network interfaces

Jeremy as far as I can see there is no real technical reason to limit the
number of interfaces. If you like this patch, can you please merge it to 3.4?
If you don't please tell me :-)



13 years agoIn aio_fork, we have to close all fd's, we might hold a gpfs share mode
Volker Lendecke [Mon, 18 May 2009 07:49:23 +0000 (09:49 +0200)]
In aio_fork, we have to close all fd's, we might hold a gpfs share mode

Keeping such an fd open prohibits another open of that same file.

13 years agoAdd "file_walk_table" to do stuff with all open files
Volker Lendecke [Mon, 18 May 2009 07:46:05 +0000 (09:46 +0200)]
Add "file_walk_table" to do stuff with all open files

13 years agoFix a race condition in vfs_aio_fork with gpfs share modes
Volker Lendecke [Mon, 18 May 2009 07:36:16 +0000 (09:36 +0200)]
Fix a race condition in vfs_aio_fork with gpfs share modes

13 years agoFix broken pipe handling
Volker Lendecke [Mon, 18 May 2009 05:08:34 +0000 (07:08 +0200)]
Fix broken pipe handling

Metze is right: If we have *any* error at the socket level, we just can
not continue.

Also, apply some defensive programming: With this async stuff someone else
might already have closed the socket.

13 years agoFix a type-punned warning
Volker Lendecke [Mon, 18 May 2009 05:08:28 +0000 (07:08 +0200)]
Fix a type-punned warning

13 years agos3: tevent_req_poll() loops forever when pipe is broken
Bo Yang [Mon, 18 May 2009 17:13:36 +0000 (01:13 +0800)]
s3: tevent_req_poll() loops forever when pipe is broken

Signed-off-by: Bo Yang <>
13 years agos3:fix bug #6371, unsuccessful net conf setparm leaves empty share
Michael Adam [Sun, 17 May 2009 20:15:02 +0000 (22:15 +0200)]
s3:fix bug #6371, unsuccessful net conf setparm leaves empty share

Wrap creation of share and setting of parameter into a transaction.


13 years agos3-events: Not only timed, also immediate events generate a timeout return
Volker Lendecke [Sun, 17 May 2009 09:43:54 +0000 (11:43 +0200)]
s3-events: Not only timed, also immediate events generate a timeout return

13 years agoMove smb_create_user() in samsync
Simo Sorce [Sat, 16 May 2009 17:04:06 +0000 (13:04 -0400)]
Move smb_create_user() in samsync

It is not used anywhere else, so make it also static and remove
it from proto.h

13 years agotevent: Define TALLOC_FREE() if it's not defined yet, to allow building
Jelmer Vernooij [Sat, 16 May 2009 18:31:59 +0000 (20:31 +0200)]
tevent: Define TALLOC_FREE() if it's not defined yet, to allow building
with released versions of talloc.

13 years agoFix static linking of vfs_notify_fam
Volker Lendecke [Sat, 16 May 2009 16:20:02 +0000 (18:20 +0200)]
Fix static linking of vfs_notify_fam

13 years agoFix a typo
Volker Lendecke [Sat, 16 May 2009 14:05:37 +0000 (16:05 +0200)]
Fix a typo

13 years agos3-events: If immediate requests are pending, the timeout is 0
Volker Lendecke [Sat, 16 May 2009 13:42:53 +0000 (15:42 +0200)]
s3-events: If immediate requests are pending, the timeout is 0

13 years agoFix the merged build -- thanks jelmer for the hint!
Volker Lendecke [Sat, 16 May 2009 17:03:37 +0000 (19:03 +0200)]
Fix the merged build -- thanks jelmer for the hint!

13 years agotevent: Remove python module.
Jelmer Vernooij [Sat, 16 May 2009 12:56:37 +0000 (14:56 +0200)]
tevent: Remove python module.

This module didn't have any functionality that we actually used yet, and
it was quite small.

Tevent is quite low level and perhaps doesn't make much sense to expose
directly as a Python module. It was also causing build problems when used with a
system-tevent. We can always back later if necessary.

13 years agotevent: Install tevent_internal.h in the standalone build.
Jelmer Vernooij [Sat, 16 May 2009 02:14:21 +0000 (04:14 +0200)]
tevent: Install tevent_internal.h in the standalone build.

This is not ideal, but at least it fixes the build of samba-gtk for now.
I've also added a warning about API guarantees at the top of the header.

13 years agoFix linker flags on non-Linux GNU platforms.
Samuel Thibault [Sat, 16 May 2009 02:05:53 +0000 (04:05 +0200)]
Fix linker flags on non-Linux GNU platforms.

(e.g. Debian GNU/kFreeBSD)

Signed-off-by: Jelmer Vernooij <>
13 years agoUpdate copies of config.guess and config.sub.
Jelmer Vernooij [Sat, 16 May 2009 02:03:12 +0000 (04:03 +0200)]
Update copies of config.guess and config.sub.

13 years agotevent: Don't install headers, since we don't install a shared lib
Jelmer Vernooij [Fri, 15 May 2009 23:54:10 +0000 (01:54 +0200)]
tevent: Don't install headers, since we don't install a shared lib
either (from Samba).

13 years agos3-privileges: add privilege_delete_account().
Günther Deschner [Fri, 15 May 2009 23:22:28 +0000 (01:22 +0200)]
s3-privileges: add privilege_delete_account().


13 years agos3-privileges: remove trailing whitespace from privileges codes.
Günther Deschner [Fri, 15 May 2009 23:21:08 +0000 (01:21 +0200)]
s3-privileges: remove trailing whitespace from privileges codes.


13 years agoOops. Forgot to delete now unused local from the previous patch.
Jeremy Allison [Fri, 15 May 2009 23:16:47 +0000 (16:16 -0700)]
Oops. Forgot to delete now unused local from the previous patch.

13 years agoFix bug #6359 - smbclient -L does not list workgroup for hosts with both IPv4 and...
Ole Hansen [Fri, 15 May 2009 23:13:59 +0000 (16:13 -0700)]
Fix bug #6359 - smbclient -L does not list workgroup for hosts with both IPv4 and IPv6 addresses

13 years agos3:build: fix linking with --disable-shared-libs
Michael Adam [Fri, 15 May 2009 21:35:55 +0000 (23:35 +0200)]
s3:build: fix linking with --disable-shared-libs


13 years agoEnsure users with SeAddUser privs get full access to
Jeremy Allison [Fri, 15 May 2009 21:20:00 +0000 (14:20 -0700)]
Ensure users with SeAddUser privs get full access to
groups/aliases when opening.

13 years agoAdd extra abilities for a user with SeAddUsers, so they
Jeremy Allison [Fri, 15 May 2009 20:36:43 +0000 (13:36 -0700)]
Add extra abilities for a user with SeAddUsers, so they
can manipulate groups and aliases.

13 years agoDeleteUser doesn't need the priv checks, this is done at OpenUser time.
Jeremy Allison [Fri, 15 May 2009 20:13:01 +0000 (13:13 -0700)]
DeleteUser doesn't need the priv checks, this is done at OpenUser time.

13 years agos3-samr: Fix samr access checks in _samr_RemoveMemberFromForeignDomain().
Günther Deschner [Fri, 15 May 2009 18:05:30 +0000 (20:05 +0200)]
s3-samr: Fix samr access checks in _samr_RemoveMemberFromForeignDomain().


13 years agoFix bug 6361: Make --rcfile work in smbget
Volker Lendecke [Fri, 15 May 2009 19:02:08 +0000 (21:02 +0200)]
Fix bug 6361: Make --rcfile work in smbget

Thanks to j scott <> for reporting!

13 years agomount.cifs: directly include sys/stat.h in mtab.c
Jeff Layton [Fri, 15 May 2009 18:31:28 +0000 (14:31 -0400)]
mount.cifs: directly include sys/stat.h in mtab.c

This file is mysteriously getting included when built via the makefile,
but when you try to build mtab.o by hand it fails to build. Directly
include it to remove any ambiguity.

Signed-off-by: Jeff Layton <>
13 years agos3-netdomjoin-gui: allow to switch between workgroups/domains with the same name.
Günther Deschner [Fri, 15 May 2009 17:43:19 +0000 (19:43 +0200)]
s3-netdomjoin-gui: allow to switch between workgroups/domains with the same name.


13 years agos3-netdomjoin-gui: cosmetic fix for empty hostnames.
Günther Deschner [Fri, 15 May 2009 17:42:05 +0000 (19:42 +0200)]
s3-netdomjoin-gui: cosmetic fix for empty hostnames.


13 years agos3-netdomjoin-gui: only gray out labels when not root and not connecting to
Günther Deschner [Fri, 15 May 2009 15:06:54 +0000 (17:06 +0200)]
s3-netdomjoin-gui: only gray out labels when not root and not connecting to
remote machines.


13 years agos3:swat: hide "config backend" from swat
Michael Adam [Fri, 15 May 2009 16:00:59 +0000 (18:00 +0200)]
s3:swat: hide "config backend" from swat


13 years agos3:param: prevent includes from being dumped in dump_*() functions.
Michael Adam [Thu, 14 May 2009 23:46:09 +0000 (01:46 +0200)]
s3:param: prevent includes from being dumped in dump_*() functions.

This fixes bug #4271: testparm should not print includes.


13 years agos3:build: add install-dbwrap_tool target
Michael Adam [Fri, 15 May 2009 13:41:41 +0000 (15:41 +0200)]
s3:build: add install-dbwrap_tool target


13 years agos3:build dbwrap_tool with make everything
Michael Adam [Fri, 15 May 2009 13:41:26 +0000 (15:41 +0200)]
s3:build dbwrap_tool with make everything


13 years agoerrormap: Remove wbc -> NTSTATUS error map for now. It is not used.
Jelmer Vernooij [Fri, 15 May 2009 14:02:33 +0000 (16:02 +0200)]
errormap: Remove wbc -> NTSTATUS error map for now. It is not used.

This was breaking the Samba 4 installation since it added dependencies
on header files we weren't installing.

Confirmed with Kai.

13 years agos3-samr: Fix samr access checks in _samr_SetUserInfo().
Günther Deschner [Fri, 15 May 2009 11:04:01 +0000 (13:04 +0200)]
s3-samr: Fix samr access checks in _samr_SetUserInfo().


13 years agos3-samr: Fix samr access checks in _samr_QueryUserInfo().
Günther Deschner [Fri, 15 May 2009 01:10:02 +0000 (03:10 +0200)]
s3-samr: Fix samr access checks in _samr_QueryUserInfo().


13 years agos3-samr: in _samr_QueryUserInfo() make sure to not return any info in error case.
Günther Deschner [Fri, 15 May 2009 12:34:50 +0000 (14:34 +0200)]
s3-samr: in _samr_QueryUserInfo() make sure to not return any info in error case.


13 years agos3-samr: Fix samr access checks in _samr_SetDomainInfo().
Günther Deschner [Thu, 14 May 2009 22:56:54 +0000 (00:56 +0200)]
s3-samr: Fix samr access checks in _samr_SetDomainInfo().


13 years agos3-samr: Fix samr access checks in _samr_QueryDomainInfo().
Günther Deschner [Thu, 14 May 2009 22:40:14 +0000 (00:40 +0200)]
s3-samr: Fix samr access checks in _samr_QueryDomainInfo().


13 years agos3-samr: use normal integer in r->in.level switch statements.
Günther Deschner [Thu, 14 May 2009 22:31:16 +0000 (00:31 +0200)]
s3-samr: use normal integer in r->in.level switch statements.


13 years agos3:build: rename OBJ collection for dbwrap_tool consistently
Michael Adam [Fri, 15 May 2009 09:58:17 +0000 (11:58 +0200)]
s3:build: rename OBJ collection for dbwrap_tool consistently


13 years agos3:first cut at dbwrap_tool - a tdb tool that is CTDB-aware.
Michael Adam [Thu, 14 May 2009 23:48:55 +0000 (01:48 +0200)]
s3:first cut at dbwrap_tool - a tdb tool that is CTDB-aware.

This tool (in contrast to tdbtool) reads Samba's configuration
and if clustering = yes, it talks to CTDB instead of accessing
the TDB data bases directly. This is done by simply using
the dbwrap mechanim, just like the Samba daemons.

This first version can read and write int32 and uint32 values
and delete records from a (c)tdb database.
More operations will follow.

This tool can already be useful in CTDB environments, e.g. when
"net idmap restore" fails to set the USER and GROUP HWM keys,
because the methods are deliberately not implemented in
idmap_tdb2.c. You can manually set the high water marks
"dbwrap_tool store idmap_tdb2.tdb 'USER HWM' int32 12345"
"dbwrap_tool store idmap_tdb2.tdb 'GROUP HWM' int32 67890"


13 years agoTurn on SHORTNAME-TEST in torture.
Jeremy Allison [Thu, 14 May 2009 23:49:34 +0000 (16:49 -0700)]
Turn on SHORTNAME-TEST in torture.

13 years agoMake us pass SHORTNAME-TEST.
Jeremy Allison [Thu, 14 May 2009 23:49:18 +0000 (16:49 -0700)]
Make us pass SHORTNAME-TEST.

13 years agoMake error message clearer on fail.
Jeremy Allison [Thu, 14 May 2009 23:30:11 +0000 (16:30 -0700)]
Make error message clearer on fail.

13 years agoAdd a test showing what ascii values cause an NTFS volume to
Jeremy Allison [Thu, 14 May 2009 23:03:31 +0000 (16:03 -0700)]
Add a test showing what ascii values cause an NTFS volume to
create a mangled name. We don't pass this yet, but it's not
run by default.

13 years agoRemove one use of mangle_is_8_3(), not needed.
Jeremy Allison [Thu, 14 May 2009 23:03:18 +0000 (16:03 -0700)]
Remove one use of mangle_is_8_3(), not needed.

13 years agoFix the core of the SAMR access functions. This passes make test, but
Jeremy Allison [Thu, 14 May 2009 22:11:50 +0000 (15:11 -0700)]
Fix the core of the SAMR access functions. This passes make test, but
usrmgr fails against it. The core of this patch is to move all the
access mask setup into the _samr_OpenXXX functions, and then have
each specific function check the attached access_mask against the
required bits. We can then go through the MS-SAMR doc and match
things up. Signed off by Guenther, and writespace cleanup removal
by Volker.

13 years agoMaximum password length check too short in mount.cifs
Steve French [Thu, 14 May 2009 20:04:27 +0000 (15:04 -0500)]
Maximum password length check too short in mount.cifs

    Windows allows up to 127 byte passwords, and we using a 64 byte limit
    in most places and a 16 byte limit when using the "pass=" mount option

Acked-by: Jeff Layton <>
Signed-off-by: Steve French <>
13 years agoAdd extensive tests for str_list function behaviour
Andrew Bartlett [Thu, 14 May 2009 15:47:39 +0000 (01:47 +1000)]
Add extensive tests for str_list function behaviour

13 years agoRemove two unused variables
Volker Lendecke [Thu, 14 May 2009 13:39:52 +0000 (15:39 +0200)]
Remove two unused variables