ira/wip.git
14 years agoMerge commit 'origin/v3-2-stable' into v3-2-test
Stefan Metzmacher [Thu, 6 Mar 2008 12:16:30 +0000 (13:16 +0100)]
Merge commit 'origin/v3-2-stable' into v3-2-test

This brings the release-3-2-0pre2 tag into the v3-2-test history.

I skipped the source/VERSION changes.

metze
(This used to be commit 6761fed30821b30246a0f25874566f8a6019abde)

14 years agoBe more verbose why create local token has failed during
Günther Deschner [Thu, 6 Mar 2008 11:24:37 +0000 (12:24 +0100)]
Be more verbose why create local token has failed during
NTLMSSP and Kerberos session setup

Guenther
(This used to be commit 18b8c2c19e50aee8fc900c7507244cb95014a4fa)

14 years agoFix an uninitialized variable, Coverity ID 481
Volker Lendecke [Thu, 6 Mar 2008 10:42:48 +0000 (11:42 +0100)]
Fix an uninitialized variable, Coverity ID 481
(This used to be commit 9e4f576abfdd5605f4db9bb87c22ec68c94ff850)

14 years agoFix a memleak
Volker Lendecke [Thu, 6 Mar 2008 10:37:01 +0000 (11:37 +0100)]
Fix a memleak

Fixes Coverity ID 557
(This used to be commit fe882a575152233de6f4bf2143aca681319b0226)

14 years agoCheck the right pointer for non-NULL
Volker Lendecke [Thu, 6 Mar 2008 10:27:49 +0000 (11:27 +0100)]
Check the right pointer for non-NULL

Fix Coverity ID 558, 559
(This used to be commit 8e33d19d93ef57a9438aad085aaf04b7c09fe09b)

14 years agoMake test: set LD_LIBRARY_PATH for make test_shlibs and friends.
Michael Adam [Thu, 6 Mar 2008 09:26:29 +0000 (10:26 +0100)]
Make test: set LD_LIBRARY_PATH for make test_shlibs and friends.

Michael
(cherry picked from commit 21a527569bccff8e8cb6e751c9f3fce6ff598204)
(This used to be commit 25a63d044e82ae3cbd9b8e350fcf4cf548236caa)

14 years agoFix build targets for bin/net.
Günther Deschner [Wed, 5 Mar 2008 21:21:10 +0000 (22:21 +0100)]
Fix build targets for bin/net.

Guenther
(cherry picked from commit 5159e3dafa9f9bb85cde6681052d8f54b8bf8a2e)
(This used to be commit 1718c1b5448d0e73cbd50da5ffba29a487d68b3d)

14 years agoAnother build fix for pam_smbpass: make sure libwbclient is there.
Günther Deschner [Wed, 5 Mar 2008 18:54:34 +0000 (19:54 +0100)]
Another build fix for pam_smbpass: make sure libwbclient is there.

Guenther
(cherry picked from commit f6762f9cd0b2ace46e16d246adf2e386749650f9)
(This used to be commit 4c2a6ef16090df2bca0811806c982e0e8f3f1eb8)

14 years agoRespect FAMChanged -- attempt to fix bug 5307
Volker Lendecke [Thu, 6 Mar 2008 06:19:46 +0000 (07:19 +0100)]
Respect FAMChanged -- attempt to fix bug 5307

Thanks to Ricardo Santos
(cherry picked from commit 8ef57a34ebf24e577ba7bca57a5456c1f78a3659)
(This used to be commit a00275fde179ab8228fa9d678ec114b677bdecc0)

14 years agoBuild: fix bin/net on Solaris - use -ltdb instead of bin/libtdb.so
Michael Adam [Wed, 5 Mar 2008 22:47:59 +0000 (23:47 +0100)]
Build: fix bin/net on Solaris - use -ltdb instead of bin/libtdb.so

Reported by Christian McHugh <christian.mchugh@nau.edu> on the samba ML.

Michael
(cherry picked from commit 3398403c22c0f39b0d91621d81e31004fc8d28bc)
(This used to be commit 350edda357a527822468bc055f6b866e11a99de7)

14 years agoMakefile: reformat - break long target lines.
Michael Adam [Wed, 5 Mar 2008 14:04:28 +0000 (15:04 +0100)]
Makefile: reformat - break long target lines.

Michael
(cherry picked from commit e26133808469cb7e9acc41cb15219d7b736d228a)
(This used to be commit f3c06fccd6011d4e3c2e3f0dc1e37a0eb7e0f645)

14 years agoMakefile: untangle -ltalloc from LIBS, making use of libtalloc explicit.
Michael Adam [Wed, 5 Mar 2008 13:16:46 +0000 (14:16 +0100)]
Makefile: untangle -ltalloc from LIBS, making use of libtalloc explicit.

Michael
(cherry picked from commit 237ea62a49fbf47634b55795c1065250d5148600)
(This used to be commit 393fc8df2898208dff14aedd7b0924624cc4f164)

14 years agoMake test: set LD_LIBRARY_PATH for make test_shlibs and friends.
Michael Adam [Thu, 6 Mar 2008 09:26:29 +0000 (10:26 +0100)]
Make test: set LD_LIBRARY_PATH for make test_shlibs and friends.

Michael
(This used to be commit 21a527569bccff8e8cb6e751c9f3fce6ff598204)

14 years agoRespect FAMChanged -- attempt to fix bug 5307
Volker Lendecke [Thu, 6 Mar 2008 06:19:46 +0000 (07:19 +0100)]
Respect FAMChanged -- attempt to fix bug 5307

Thanks to Ricardo Santos
(This used to be commit 8ef57a34ebf24e577ba7bca57a5456c1f78a3659)

14 years agoIn libnetapi, point out that lp_load has failed.
Günther Deschner [Wed, 5 Mar 2008 23:45:20 +0000 (00:45 +0100)]
In libnetapi, point out that lp_load has failed.

Guenther
(cherry picked from commit be673bfc61559f661040c6fb1ba7d2e4552967f2)
(This used to be commit 0fba3713e1c3379edcd99fb28ddac21616f34777)

14 years agoFix lp_load with an empty registry and "config backend = registry". Michael, please...
Günther Deschner [Wed, 5 Mar 2008 23:51:20 +0000 (00:51 +0100)]
Fix lp_load with an empty registry and "config backend = registry". Michael, please check.

Guenther
(cherry picked from commit d9f4060c660da0ad671e061b123df71d109d51b9)
(This used to be commit 11b151f3552cbcddcfe671dcda4fe0110c4f2b48)

14 years agoFix lp_load with an empty registry and "config backend = registry". Michael, please...
Günther Deschner [Wed, 5 Mar 2008 23:51:20 +0000 (00:51 +0100)]
Fix lp_load with an empty registry and "config backend = registry". Michael, please check.

Guenther
(This used to be commit d9f4060c660da0ad671e061b123df71d109d51b9)

14 years agoIn libnetapi, point out that lp_load has failed.
Günther Deschner [Wed, 5 Mar 2008 23:45:20 +0000 (00:45 +0100)]
In libnetapi, point out that lp_load has failed.

Guenther
(This used to be commit be673bfc61559f661040c6fb1ba7d2e4552967f2)

14 years agoTest: Properly track current test binary for tracking crashes.
Michael Adam [Thu, 6 Mar 2008 08:25:38 +0000 (09:25 +0100)]
Test: Properly track current test binary for tracking crashes.

Make sure the panic action always has the right test binary set.

Michael
(This used to be commit 567ac329dcec6fc839d6b25cbf1872f1f51ff7e5)

14 years agoGive a better error message why NetServerSetInfo() may fail in the gui.
Günther Deschner [Wed, 5 Mar 2008 14:21:43 +0000 (15:21 +0100)]
Give a better error message why NetServerSetInfo() may fail in the gui.

Guenther
(cherry picked from commit 1bbbebb7767b8a25532e8be3dbd274c211e34bbd)
(This used to be commit 370d030b227486ba87a98f4f6e8920f52f743a94)

14 years agoAdd PICFLAG to libnetapi Makefile.
Günther Deschner [Wed, 5 Mar 2008 12:20:32 +0000 (13:20 +0100)]
Add PICFLAG to libnetapi Makefile.

Guenther
(cherry picked from commit 29fca3c0353f2be4577613d7e38fbc51d2a370fa)
(This used to be commit 1e7ee35c0cb937405689f58e8846016b2ab44582)

14 years agoFix coverity ID 525, 526, 527, 528, 529 and 530
Volker Lendecke [Wed, 5 Mar 2008 15:20:34 +0000 (16:20 +0100)]
Fix coverity ID 525, 526, 527, 528, 529 and 530

Upon failure to allocate one of the arrays, further down the TALLOC_FREE would
have looked at the variables given to it without initizalizing.
(cherry picked from commit 6cac3127312acaac65fcd54280605605765787ad)
(This used to be commit f990498818e28cbf12fe387746b182c6893d2639)

14 years agoBuild: fix bin/net on Solaris - use -ltdb instead of bin/libtdb.so
Michael Adam [Wed, 5 Mar 2008 22:47:59 +0000 (23:47 +0100)]
Build: fix bin/net on Solaris - use -ltdb instead of bin/libtdb.so

Reported by Christian McHugh <christian.mchugh@nau.edu> on the samba ML.

Michael
(This used to be commit 3398403c22c0f39b0d91621d81e31004fc8d28bc)

14 years agoFix coverity ID 525, 526, 527, 528, 529 and 530
Volker Lendecke [Wed, 5 Mar 2008 15:20:34 +0000 (16:20 +0100)]
Fix coverity ID 525, 526, 527, 528, 529 and 530

Upon failure to allocate one of the arrays, further down the TALLOC_FREE would
have looked at the variables given to it without initizalizing.
(This used to be commit 6cac3127312acaac65fcd54280605605765787ad)

14 years agoFix build targets for bin/net.
Günther Deschner [Wed, 5 Mar 2008 21:21:10 +0000 (22:21 +0100)]
Fix build targets for bin/net.

Guenther
(This used to be commit 5159e3dafa9f9bb85cde6681052d8f54b8bf8a2e)

14 years agoAnother build fix for pam_smbpass: make sure libwbclient is there.
Günther Deschner [Wed, 5 Mar 2008 18:54:34 +0000 (19:54 +0100)]
Another build fix for pam_smbpass: make sure libwbclient is there.

Guenther
(This used to be commit f6762f9cd0b2ace46e16d246adf2e386749650f9)

14 years agoMerge branch 'v3-2-test' of ssh://git.samba.org/data/git/samba into v3-2-test
Jelmer Vernooij [Wed, 5 Mar 2008 18:42:15 +0000 (19:42 +0100)]
Merge branch 'v3-2-test' of ssh://git.samba.org/data/git/samba into v3-2-test
(This used to be commit 3482cd9b0e81bbc801f1cec33fca82fc45a3ddef)

14 years agoFix Coverity ID 565
Volker Lendecke [Wed, 5 Mar 2008 16:20:01 +0000 (17:20 +0100)]
Fix Coverity ID 565

This would crash safely
(This used to be commit 0f14357c86aee9a76ffbb45ea6419f4cc4106d62)

14 years agoFix a memleak -- Coverity ID 222
Volker Lendecke [Wed, 5 Mar 2008 15:28:43 +0000 (16:28 +0100)]
Fix a memleak -- Coverity ID 222
(cherry picked from commit a40781bafa3a8f0c7737164bca6cf74b0a452e72)
(This used to be commit 86cabcad74ac06d888f2a352a2bef3abea1ed85c)

14 years agoFix formatting.
Jelmer Vernooij [Wed, 5 Mar 2008 16:30:18 +0000 (17:30 +0100)]
Fix formatting.
(This used to be commit e2345ce90c3f1548f63d720c5943c8d61fdc899a)

14 years agoRevert "Make sure to generate pkgconfig files for libtdb and libtalloc."
Günther Deschner [Wed, 5 Mar 2008 15:31:04 +0000 (16:31 +0100)]
Revert "Make sure to generate pkgconfig files for libtdb and libtalloc."

This uses incorrect version numbers for tdb and talloc.

Guenther

This reverts commit df97fb019b89a147a0a2c560003d74c354fcc4b6.
(This used to be commit ead849949b1b879e2bc4a6b1f7c3d2df1962170a)

14 years agoMake sure to generate pkgconfig files for libtdb and libtalloc.
Günther Deschner [Wed, 5 Mar 2008 14:40:23 +0000 (15:40 +0100)]
Make sure to generate pkgconfig files for libtdb and libtalloc.

Guenther
(This used to be commit df97fb019b89a147a0a2c560003d74c354fcc4b6)

14 years agoGive a better error message why NetServerSetInfo() may fail in the gui.
Günther Deschner [Wed, 5 Mar 2008 14:21:43 +0000 (15:21 +0100)]
Give a better error message why NetServerSetInfo() may fail in the gui.

Guenther
(This used to be commit 1bbbebb7767b8a25532e8be3dbd274c211e34bbd)

14 years agoAdd --update option to smbget.
Charles [Wed, 5 Mar 2008 14:20:29 +0000 (15:20 +0100)]
Add --update option to smbget.
(This used to be commit 3cfa35fca64b059b307668ca0113503679e0b1fa)

14 years agoMakefile: reformat - break long target lines.
Michael Adam [Wed, 5 Mar 2008 14:04:28 +0000 (15:04 +0100)]
Makefile: reformat - break long target lines.

Michael
(This used to be commit e26133808469cb7e9acc41cb15219d7b736d228a)

14 years agoMakefile: untangle -ltalloc from LIBS, making use of libtalloc explicit.
Michael Adam [Wed, 5 Mar 2008 13:16:46 +0000 (14:16 +0100)]
Makefile: untangle -ltalloc from LIBS, making use of libtalloc explicit.

Michael
(This used to be commit 237ea62a49fbf47634b55795c1065250d5148600)

14 years agoAdd PICFLAG to libnetapi Makefile.
Günther Deschner [Wed, 5 Mar 2008 12:20:32 +0000 (13:20 +0100)]
Add PICFLAG to libnetapi Makefile.

Guenther
(This used to be commit 29fca3c0353f2be4577613d7e38fbc51d2a370fa)

14 years agoMakefile: Add explicit dependecies to libtalloc.so.
Michael Adam [Wed, 5 Mar 2008 10:39:47 +0000 (11:39 +0100)]
Makefile: Add explicit dependecies to libtalloc.so.

So as to fix building of isolated targets.

Michael
(cherry picked from commit 7dbc251e1cd28abf28342529607fa4b5f579a9c4)
(This used to be commit ad711da7972b9ccc8b82c506db830b192a833918)

14 years agoMakefile: Add explicit dependecies to libtalloc.so.
Michael Adam [Wed, 5 Mar 2008 10:39:47 +0000 (11:39 +0100)]
Makefile: Add explicit dependecies to libtalloc.so.

So as to fix building of isolated targets.

Michael
(This used to be commit 7dbc251e1cd28abf28342529607fa4b5f579a9c4)

14 years agoFix build of pam_smbpass.
Günther Deschner [Wed, 5 Mar 2008 10:31:26 +0000 (11:31 +0100)]
Fix build of pam_smbpass.

Guenther
(cherry picked from commit cd582b7705dca40b3c688c9e23d8375dab43b4d0)
(This used to be commit ecdbc96b4dd56629bb8f99c41ecf76506df91d71)

14 years agoFix build of pam_smbpass.
Günther Deschner [Wed, 5 Mar 2008 10:31:26 +0000 (11:31 +0100)]
Fix build of pam_smbpass.

Guenther
(This used to be commit cd582b7705dca40b3c688c9e23d8375dab43b4d0)

14 years agoRemove unused marshalling for SRV_NET_REMOTE_TOD.
Günther Deschner [Wed, 5 Mar 2008 09:40:52 +0000 (10:40 +0100)]
Remove unused marshalling for SRV_NET_REMOTE_TOD.

Guenther
(This used to be commit 9f0ea1d727046fef4c23bcf1e71d10f33c93b00f)

14 years agoUse rpccli_srvsvc_NetRemoteTOD() in rpcclient.
Günther Deschner [Wed, 5 Mar 2008 09:38:13 +0000 (10:38 +0100)]
Use rpccli_srvsvc_NetRemoteTOD() in rpcclient.

Guenther
(This used to be commit 5e9d8cdc948b678e5aa6e04ee13635376b7306f5)

14 years agoUse pidl for _srvsvc_NetRemoteTOD().
Günther Deschner [Wed, 5 Mar 2008 09:34:45 +0000 (10:34 +0100)]
Use pidl for _srvsvc_NetRemoteTOD().

Guenther
(This used to be commit 2b4e0f0593c6378cdac4811ded830ca694afac9e)

14 years agoRe-run make idl.
Günther Deschner [Wed, 5 Mar 2008 09:32:55 +0000 (10:32 +0100)]
Re-run make idl.

Guenther
(This used to be commit b9abb783200f6c14543c3b884b9393797cfa8dbd)

14 years agoFix IDL for srvsvc_NetRemoteTOD().
Günther Deschner [Wed, 5 Mar 2008 09:32:04 +0000 (10:32 +0100)]
Fix IDL for srvsvc_NetRemoteTOD().

Guenther
(This used to be commit cc3ec6ac65eab8c955cd17f3d4bdf58d6fcc22be)

14 years agoUse pidl for _srvsvc_NetShareSetInfo().
Günther Deschner [Wed, 5 Mar 2008 00:26:39 +0000 (01:26 +0100)]
Use pidl for _srvsvc_NetShareSetInfo().

Guenther
(This used to be commit 9bfa77edc68a887972b609bfb0aee8bbbc89ce04)

14 years agoRe-run make idl.
Günther Deschner [Tue, 4 Mar 2008 22:50:51 +0000 (23:50 +0100)]
Re-run make idl.

Guenther
(This used to be commit 4ace93c3df280558ef75b6619297e367ac9713c9)

14 years agoFix IDL for srvsvc_NetShareSetInfo().
Günther Deschner [Tue, 4 Mar 2008 22:50:23 +0000 (23:50 +0100)]
Fix IDL for srvsvc_NetShareSetInfo().

Guenther
(This used to be commit 40d780f2e75c3a62853568a149a1229828ac9da4)

14 years agoFix rpccli_srvsvc_NetSrvSetInfo call in libnetapi.
Günther Deschner [Wed, 5 Mar 2008 08:53:33 +0000 (09:53 +0100)]
Fix rpccli_srvsvc_NetSrvSetInfo call in libnetapi.

Guenther
(This used to be commit 5911529205ca69c438e0782c07ee4fe5aa95de62)

14 years agoRemove unused marshalling for SRV_NET_SRV_SET_INFO.
Günther Deschner [Tue, 4 Mar 2008 22:40:53 +0000 (23:40 +0100)]
Remove unused marshalling for SRV_NET_SRV_SET_INFO.

Guenther
(This used to be commit a7aef18797407b1f451191647d4b0225ac838817)

14 years agoUse pidl for _srvsvc_NetSrvSetInfo().
Günther Deschner [Tue, 4 Mar 2008 22:40:25 +0000 (23:40 +0100)]
Use pidl for _srvsvc_NetSrvSetInfo().

Guenther
(This used to be commit 75b0bbf790da44c45c679c374dbe09f288f3fb8c)

14 years agoRe-run make idl.
Günther Deschner [Tue, 4 Mar 2008 22:47:28 +0000 (23:47 +0100)]
Re-run make idl.

Guenther
(This used to be commit ea03cb92c481b9bb47d2a4e133cf830acb0f22a3)

14 years agoFix IDL for srvsvc_NetSrvSetInfo().
Günther Deschner [Tue, 4 Mar 2008 22:47:01 +0000 (23:47 +0100)]
Fix IDL for srvsvc_NetSrvSetInfo().

Guenther
(This used to be commit 024021daabe825bc7a033951aa1073ab76bd34aa)

14 years agoRemove unused marshalling for SRV_NET_SRV_GET_INFO.
Günther Deschner [Tue, 4 Mar 2008 22:26:27 +0000 (23:26 +0100)]
Remove unused marshalling for SRV_NET_SRV_GET_INFO.

Guenther
(This used to be commit 53a7e9b07d07d3e9d21360dee35fee27b46929b3)

14 years agoUse rpccli_srvsvc_NetSrvGetInfo() in rpcclient.
Günther Deschner [Tue, 4 Mar 2008 22:11:53 +0000 (23:11 +0100)]
Use rpccli_srvsvc_NetSrvGetInfo() in rpcclient.

Guenther
(This used to be commit 4a74f1e8d2c45574973fc4c0ce4fbc9a843afaa0)

14 years agoUse pidl for _srvsvc_NetSrvGetInfo().
Günther Deschner [Tue, 4 Mar 2008 22:07:45 +0000 (23:07 +0100)]
Use pidl for _srvsvc_NetSrvGetInfo().

Guenther
(This used to be commit 34caa41fa6d44165b470508261c2bde124fc4955)

14 years agoWhitespace cleanup in srvsvc server.
Günther Deschner [Tue, 4 Mar 2008 20:46:09 +0000 (21:46 +0100)]
Whitespace cleanup in srvsvc server.

Guenther
(This used to be commit 3c0a3f8de742678b56f6b998a014105c05400666)

14 years agoFix proxy_srvsvc_call().
Günther Deschner [Tue, 4 Mar 2008 21:54:14 +0000 (22:54 +0100)]
Fix proxy_srvsvc_call().

Wow, this must have been broken a long time already.

Guenther
(This used to be commit 821762e5ab32a2fbea7c41f1d2c2ea8589daa1d3)

14 years agoAdd secure_channel_type to libnetjoin.
Günther Deschner [Tue, 4 Mar 2008 18:04:54 +0000 (19:04 +0100)]
Add secure_channel_type to libnetjoin.

Guenther
(This used to be commit f88910c1e5186737da4eda5a7a396c3238fc6775)

14 years agoask for the keyid in the release script.
Karolin Seeger [Tue, 4 Mar 2008 16:27:08 +0000 (17:27 +0100)]
ask for the keyid in the release script.
(This used to be commit bccae9487485a6c9468bc6afb9ada8c8d9f6e135)

14 years agoRe-run make idl.
Günther Deschner [Tue, 4 Mar 2008 11:28:36 +0000 (12:28 +0100)]
Re-run make idl.

Guenther
(cherry picked from commit 8e601e2365f50e582de442daa1559f828bda3e89)
(This used to be commit 3c26f1899e4b1d47f0463f05a81ac70d6d484e7a)

14 years agoAdd new Windows 2008 Kerberos PAC Type 12 (apparently again undocumented).
Günther Deschner [Tue, 4 Mar 2008 11:26:05 +0000 (12:26 +0100)]
Add new Windows 2008 Kerberos PAC Type 12 (apparently again undocumented).

We need at least to parse this in order to correctly support kerberized session
setup from w2k8 as well as local pam_winbind logons using kerberos.

Guenther
(cherry picked from commit 4ba62d49d740c43cf17ceef1534cf1c8a7e4a130)
(This used to be commit a3b623bfbbfb1abe0c1f0adcf83afbf808df60a4)

14 years agoRe-run make idl.
Günther Deschner [Tue, 4 Mar 2008 11:28:36 +0000 (12:28 +0100)]
Re-run make idl.

Guenther
(This used to be commit 8e601e2365f50e582de442daa1559f828bda3e89)

14 years agoAdd new Windows 2008 Kerberos PAC Type 12 (apparently again undocumented).
Günther Deschner [Tue, 4 Mar 2008 11:26:05 +0000 (12:26 +0100)]
Add new Windows 2008 Kerberos PAC Type 12 (apparently again undocumented).

We need at least to parse this in order to correctly support kerberized session
setup from w2k8 as well as local pam_winbind logons using kerberos.

Guenther
(This used to be commit 4ba62d49d740c43cf17ceef1534cf1c8a7e4a130)

14 years agoFix counter mismatch in lsa_LookupNames3 server.
Günther Deschner [Tue, 4 Mar 2008 12:19:38 +0000 (13:19 +0100)]
Fix counter mismatch in lsa_LookupNames3 server.

Guenther
(cherry picked from commit e052d6f2c82a644986e5d99f640310d71cd5c396)
(This used to be commit 59d5e15ee50fbae858358aedf0e458b7e4a4af20)

14 years agoFix counter mismatch in lsa_LookupNames server.
Günther Deschner [Tue, 4 Mar 2008 12:16:02 +0000 (13:16 +0100)]
Fix counter mismatch in lsa_LookupNames server.

Guenther
(cherry picked from commit 80fd085c34befd38d33cf6e59080a2a36016a92d)
(This used to be commit af7aded25d9007a8c2037940ab90fb30d0a3eef2)

14 years agoFix lsa_QueryInfoPolicy: make proper talloc copies of the sids.
Günther Deschner [Tue, 4 Mar 2008 11:46:15 +0000 (12:46 +0100)]
Fix lsa_QueryInfoPolicy: make proper talloc copies of the sids.

Guenther
(cherry picked from commit b9441232d66d78e66464be6c9748a023681ce6ca)
(This used to be commit 1081da4d83dbfb6d87c3267c5e00e668b2151294)

14 years agoZero more structs initially in LSA rpc server.
Günther Deschner [Tue, 4 Mar 2008 10:06:02 +0000 (11:06 +0100)]
Zero more structs initially in LSA rpc server.

Guenther
(cherry picked from commit d7ce643285276790a65faff76666498595a508d7)
(This used to be commit 7867f40567503db32dbb13b4fca19792cf198505)

14 years agoFix counter mismatch in lsa_LookupNames3 server.
Günther Deschner [Tue, 4 Mar 2008 12:19:38 +0000 (13:19 +0100)]
Fix counter mismatch in lsa_LookupNames3 server.

Guenther
(This used to be commit e052d6f2c82a644986e5d99f640310d71cd5c396)

14 years agoFix counter mismatch in lsa_LookupNames server.
Günther Deschner [Tue, 4 Mar 2008 12:16:02 +0000 (13:16 +0100)]
Fix counter mismatch in lsa_LookupNames server.

Guenther
(This used to be commit 80fd085c34befd38d33cf6e59080a2a36016a92d)

14 years agoUpdate release date.
Karolin Seeger [Tue, 4 Mar 2008 08:53:37 +0000 (09:53 +0100)]
Update release date.

Karolin
(cherry picked from commit 491535d0911c64869055b85a210c2ef076086b83)
(This used to be commit 5eacf7c672ce8a2cf17f05c62789d321ed9d89bb)

14 years agoFix lsa_QueryInfoPolicy: make proper talloc copies of the sids.
Günther Deschner [Tue, 4 Mar 2008 11:46:15 +0000 (12:46 +0100)]
Fix lsa_QueryInfoPolicy: make proper talloc copies of the sids.

Guenther
(This used to be commit b9441232d66d78e66464be6c9748a023681ce6ca)

14 years agoFix crash bug in pdb_init_ldapsam().
Günther Deschner [Tue, 4 Mar 2008 10:02:26 +0000 (11:02 +0100)]
Fix crash bug in pdb_init_ldapsam().

Karolin, this needs to be in 3-2-stable.

Guenther
(cherry picked from commit 0d73bde6de4391e7aec862424762473441fa0905)
(This used to be commit 4c2d6ce18daf07de7233e3e90bd24fa2a5f9e945)

14 years agoUse TALLOC_FREE in libnetjoin debugging dump code.
Günther Deschner [Tue, 4 Mar 2008 10:07:13 +0000 (11:07 +0100)]
Use TALLOC_FREE in libnetjoin debugging dump code.

Guenther
(This used to be commit b753087ff79c1d35a409eddc1f61e115e887c1e1)

14 years agoZero more structs initially in LSA rpc server.
Günther Deschner [Tue, 4 Mar 2008 10:06:02 +0000 (11:06 +0100)]
Zero more structs initially in LSA rpc server.

Guenther
(This used to be commit d7ce643285276790a65faff76666498595a508d7)

14 years agoMove talloc_init to the right place in "net ads join".
Günther Deschner [Tue, 4 Mar 2008 10:04:36 +0000 (11:04 +0100)]
Move talloc_init to the right place in "net ads join".

Guenther
(This used to be commit 8cd07c1fa8f435f7ff3dc79c195da9324fb2452f)

14 years agoFix crash bug in pdb_init_ldapsam().
Günther Deschner [Tue, 4 Mar 2008 10:02:26 +0000 (11:02 +0100)]
Fix crash bug in pdb_init_ldapsam().

Karolin, this needs to be in 3-2-stable.

Guenther
(This used to be commit 0d73bde6de4391e7aec862424762473441fa0905)

14 years agoUpdate release date.
Karolin Seeger [Tue, 4 Mar 2008 08:53:37 +0000 (09:53 +0100)]
Update release date.

Karolin
(This used to be commit 491535d0911c64869055b85a210c2ef076086b83)

14 years agoFix init_registry_data for subkeyless top-level keys.
Günther Deschner [Fri, 29 Feb 2008 23:32:36 +0000 (00:32 +0100)]
Fix init_registry_data for subkeyless top-level keys.

On a fresh install with no existing registry.tdb, make sure we are able to
create our initial top-level entries.

Michael, Volker, please check.

Guenther
(cherry picked from commit 956bc602062825493e1c357e2388fee1e5514b50)
(This used to be commit bf03cba57d3cfe07b8d848aa3b5a165bb198b7aa)

14 years agouse constant name less likely to cause conflict
Derrell Lipman [Tue, 4 Mar 2008 03:56:32 +0000 (22:56 -0500)]
use constant name less likely to cause conflict
(cherry picked from commit fd18b01016d1dc4b08983975353e62084fdc323c)
(This used to be commit 4279cc49ff73d4503df2fd0c6176c3f90f67066c)

14 years agoMissed a few 'deprecated' markers
Derrell Lipman [Mon, 3 Mar 2008 23:25:49 +0000 (18:25 -0500)]
Missed a few 'deprecated' markers
(cherry picked from commit 76ba37ac46b4a77fe228ca90635fa19140541ccd)
(This used to be commit 7c2a0be9cb2916c07074d8d56d698721b02bcfc3)

14 years agoContinued revamping of libsmbclient.
Derrell Lipman [Mon, 3 Mar 2008 23:13:33 +0000 (18:13 -0500)]
Continued revamping of libsmbclient.

- James suggested using gcc's "deprecated" attribute to mark the context
  structure fields to generate warnings.  This creates a scenario with the
  best of all worlds.  I'm able to move to an organization that more easily
  allows future enhancements, while avoiding any mandatory changes by
  applications.  Thanks, James!

- Updated WHATSNEW.txt so that it accurately reflects the current state of
  affairs.

Derrell
(cherry picked from commit a67f96fbe9683b46c2149f7cb439d13f7f0e6ecd)
(This used to be commit 046653403fadfa2d42decce7048eca6321b321c6)

14 years agoRemove use of deprecated function
Derrell Lipman [Sun, 2 Mar 2008 21:21:48 +0000 (16:21 -0500)]
Remove use of deprecated function
(cherry picked from commit 93580bce833453ba512ee436d6dfdbdcd2c53777)
(This used to be commit 0621dfe10f1fd3d8ce04a039d2d44d6c67407746)

14 years agofixed missing white space
Derrell Lipman [Sun, 2 Mar 2008 21:13:25 +0000 (16:13 -0500)]
fixed missing white space
(cherry picked from commit 71e86f13b0ace3841c6712084728c79db74ff803)
(This used to be commit 8bf707c13794539029be2229f0c587b713b4fd20)

14 years agoUpdate WHATSNEW for libsmbclient changes
Derrell Lipman [Sun, 2 Mar 2008 04:08:19 +0000 (23:08 -0500)]
Update WHATSNEW for libsmbclient changes
(cherry picked from commit f07407a32e178a47c8f9b3e3703aa5a20f0a4f06)
(This used to be commit 938c6aef24c696be9bd247e43c7c5ec1f792dbd6)

14 years agoReturn NULL, not 0, from a function which returns a pointer.
Derrell Lipman [Sun, 2 Mar 2008 02:19:52 +0000 (21:19 -0500)]
Return NULL, not 0, from a function which returns a pointer.
(cherry picked from commit 23cb9c49e3724cecaa66655ef64c3111bf14c552)
(This used to be commit 9b4bd6473ed3f93c1bbfae3f82d0a100e832df48)

14 years agochange variable name from f to fn for function pointers
Derrell Lipman [Sun, 2 Mar 2008 02:19:15 +0000 (21:19 -0500)]
change variable name from f to fn for function pointers
(cherry picked from commit 1fd65359f6cd07539cfe43146ac367a48708a678)
(This used to be commit b7f10bd31dec8047ea996c4738a6db5535c9261a)

14 years agoComment was in wrong place
Derrell Lipman [Sun, 2 Mar 2008 01:56:54 +0000 (20:56 -0500)]
Comment was in wrong place
(cherry picked from commit dec70fa3c0424c148016cc667a3c159e16d8a944)
(This used to be commit eb4d6dda1091199af7e62fb584525deb382978e2)

14 years agoMark smbc_option_{get,set} as deprecated
Derrell Lipman [Sun, 2 Mar 2008 01:55:21 +0000 (20:55 -0500)]
Mark smbc_option_{get,set} as deprecated
(cherry picked from commit a8b4b773d4647f28e7b92c5968469721d34eb550)
(This used to be commit 7b05e264d58c65af37af457947548611fc77edce)

14 years agoAdditional revamped libsmbclient documentation
Derrell Lipman [Sun, 2 Mar 2008 01:44:21 +0000 (20:44 -0500)]
Additional revamped libsmbclient documentation

- Ensured that all public functions have documentation in libsmbclient.h
- Reformatted for "proper" indentation
- Re-added temporarily-disabled alternate authentication function capability

Derrell
(cherry picked from commit 64b7150d92849a1e1e2416b9dcc12fae8d6bea99)
(This used to be commit dca8a612e94095e38df50f0fe567c75ceb8124fe)

14 years agoModified revamp of the libsmbclient interface.
Derrell Lipman [Fri, 29 Feb 2008 18:34:35 +0000 (13:34 -0500)]
Modified revamp of the libsmbclient interface.

Given the tacit (if that) approval by some people, and clear disapproval by
others for my proposed clean-up and reorganization of libsmbclient, I've come
up with a slightly different approach.  This commit changes back to the
original libsmbclient.h SMBCCTX structure which will maintain ABI
compatibility.  I retain, here, the setter and getter functions which all new
code should use.  Older programs already compiled should continue to work
fine.  Older programs being recompiled will encounter compile-time errors
(intentionally!) so that the code can be corrected to use the setter/getter
interfaces.

Although this doesn't clean up the interface in the way I had wanted, the code
reorganization and requirement for new programs to use the setters and getters
allows future progress to be made on libsmbclient without further muddying up
the interface, while retaining the ABI compatibility that was the big issue
causing disapproval.  I hope that this compromise is adequate.

Derrell
(cherry picked from commit 56429a3d60b2a48963342f6340b3c01469a892c6)
(This used to be commit 7bc53f57dcb1c3bb80cb20796ebfc743c22a76e3)

14 years agoInitial revamp of the libsmbclient interface.
Derrell Lipman [Thu, 28 Feb 2008 16:23:20 +0000 (11:23 -0500)]
Initial revamp of the libsmbclient interface.

The libsmbclient interface has suffered from difficulty of improvement and
feature enrichment without causing ABI breakage.  Although there were a number
of issues, the primary ones were:

(a) the user of the library would manually manipulate the context structure
    members, meaning that nothing in the context structure could change other
    than adding stuff at the end;

(b) there were three methods of setting options: setting bits in a flags field
    within the context structure, setting explicit options variables within an
    options structure in the context structure, and by calling the
    smbc_option_set() function;

(c) the authentication callback did not traditionally provide enough
    information to the callee which required adding an option for a callback
    with a different signature, and now there are requests for even more
    information at the callback, requiring yet a third signature and option to
    set it (if we implement that feature).

This commit provides a reorganization of the code which fixes (a) and (b).
The context structure is now entirely opaque, and there are setter and getter
functions for manipulating it.  This makes maintaining ABI consistency much,
much easier.

Additionally, the options setting/getting has been unified into a single
mechanism using smbc_option_set() and smbc_option_get().

Yet to be completed is a refactoring of the authentication callback (c).

The test programs in examples/libsmbclient have been modified (if necessary;
some applications require no changes at all) for the new API and a few have
been minimally tested.

Derrell
(cherry picked from commit d4b4bae8ded824d06ad5ab0e219f71187ee5c771)
(This used to be commit 59292c0da8880afd7bac82f6a5bba009f3827ea0)

14 years agoZero out the out policy handler in lsa_Close
Volker Lendecke [Mon, 3 Mar 2008 17:12:26 +0000 (18:12 +0100)]
Zero out the out policy handler in lsa_Close

... after a REALLY long session staring at sniffs we can now join XP to
v3-2-test again...

Apparently not doing this makes XP keep an internal handle to LSA open which
confuses the hell out of it.

Karolin, this needs to be in v3-2-stable :-)

Volker
(cherry picked from commit 2c42fc21d8bede226e411623aecd69038477373b)
(This used to be commit a94313e06a030e1a1afff18c797e700eb6b25248)

14 years agouse constant name less likely to cause conflict
Derrell Lipman [Tue, 4 Mar 2008 03:56:32 +0000 (22:56 -0500)]
use constant name less likely to cause conflict
(This used to be commit fd18b01016d1dc4b08983975353e62084fdc323c)

14 years agoMerge branch 'v3-2-test' of ssh://git.samba.org/data/git/samba into v3-2-test
Derrell Lipman [Mon, 3 Mar 2008 23:27:41 +0000 (18:27 -0500)]
Merge branch 'v3-2-test' of ssh://git.samba.org/data/git/samba into v3-2-test
(This used to be commit 8927b50d6051fcefd87f19dc90c5826378d03e4e)

14 years agoMissed a few 'deprecated' markers
Derrell Lipman [Mon, 3 Mar 2008 23:25:49 +0000 (18:25 -0500)]
Missed a few 'deprecated' markers
(This used to be commit 76ba37ac46b4a77fe228ca90635fa19140541ccd)

14 years agoContinued revamping of libsmbclient.
Derrell Lipman [Mon, 3 Mar 2008 23:13:33 +0000 (18:13 -0500)]
Continued revamping of libsmbclient.

- James suggested using gcc's "deprecated" attribute to mark the context
  structure fields to generate warnings.  This creates a scenario with the
  best of all worlds.  I'm able to move to an organization that more easily
  allows future enhancements, while avoiding any mandatory changes by
  applications.  Thanks, James!

- Updated WHATSNEW.txt so that it accurately reflects the current state of
  affairs.

Derrell
(This used to be commit a67f96fbe9683b46c2149f7cb439d13f7f0e6ecd)

14 years agoZero out the out policy handler in lsa_Close
Volker Lendecke [Mon, 3 Mar 2008 17:12:26 +0000 (18:12 +0100)]
Zero out the out policy handler in lsa_Close

... after a REALLY long session staring at sniffs we can now join XP to
v3-2-test again...

Apparently not doing this makes XP keep an internal handle to LSA open which
confuses the hell out of it.

Karolin, this needs to be in v3-2-stable :-)

Volker
(This used to be commit 2c42fc21d8bede226e411623aecd69038477373b)

14 years agoRestore 3.0 behaviour with empty /etc/hosts
Volker Lendecke [Fri, 29 Feb 2008 21:38:10 +0000 (22:38 +0100)]
Restore 3.0 behaviour with empty /etc/hosts

Jeremy, in 3.0 we allowed get_mydnsdomname and get_mydnsfullname to fail
without filling in anything useful. Worked fine. Without this patch and a empty
/etc/hosts and no DNS configured, session setup would return
NT_STATUS_BAD_NETWORK_NAME. This is confusing at best, BAD_NETWORK_NAME afaik
is only ever returned from tcon normally.

This restores the 3.0 behaviour.

Comments?

Volker
(This used to be commit 4170259e5f83c281966a80916e4ece6937e08988)