15 years agor17508: I didn;t realize we had this in our packages, remove it
Simo Sorce [Sat, 12 Aug 2006 20:22:55 +0000 (20:22 +0000)]
r17508: I didn;t realize we had this in our packages, remove it

15 years agor17496: net groupmap add could add uninitialized sid_name_type
Jeremy Allison [Fri, 11 Aug 2006 18:09:59 +0000 (18:09 +0000)]
r17496: net groupmap add could add uninitialized sid_name_type
entries to the group mapping db. Ensure this can't happen.

15 years agor17487: Allocate some OID space for Samba4, so we don't trip on each other.
Andrew Bartlett [Fri, 11 Aug 2006 06:44:31 +0000 (06:44 +0000)]
r17487: Allocate some OID space for Samba4, so we don't trip on each other.

Andrew Bartlett

15 years agor17477: Add talloc_asprintf_len and make use of it.
Volker Lendecke [Thu, 10 Aug 2006 11:33:42 +0000 (11:33 +0000)]
r17477: Add talloc_asprintf_len and make use of it.


15 years agor17470: This is the group mapping rewrite announced a few days ago. I'm afraid it's
Volker Lendecke [Wed, 9 Aug 2006 20:25:13 +0000 (20:25 +0000)]
r17470: This is the group mapping rewrite announced a few days ago. I'm afraid it's
more than 1000 lines of patch, but doing it in smaller pieces is hardly

Anybody interested please look over this. The patch is not really interesting,
just look at the new groupdb/mapping.c file.

Jerry, one entry for the 3.0.24 release notes: smbd will refuse to start if we
have overlapping mappings in group_mapping.tdb. With the old db a unix gid can
be mapped to two different SIDs. This will be refused with the new code.


15 years agor17469: remove unused variable
Simo Sorce [Wed, 9 Aug 2006 15:36:57 +0000 (15:36 +0000)]
r17469: remove unused variable

15 years agor17468: To minimize the diff later on, pre-commit some changes independently: Change
Volker Lendecke [Wed, 9 Aug 2006 15:25:26 +0000 (15:25 +0000)]
r17468: To minimize the diff later on, pre-commit some changes independently: Change
internal mapping.c functions to return NTSTATUS instead of BOOL.


15 years agor17465: Get rid of add_initial_entry. In the two places it was called in it seemed a
Volker Lendecke [Tue, 8 Aug 2006 20:50:35 +0000 (20:50 +0000)]
r17465: Get rid of add_initial_entry. In the two places it was called in it seemed a
bit pointless to me.


15 years agor17464: Ensure we use a hash16 data type, not a string,
Jeremy Allison [Tue, 8 Aug 2006 20:35:17 +0000 (20:35 +0000)]
r17464: Ensure we use a hash16 data type, not a string,
for storing offline hashes.

15 years agor17463: A bit of cleanup work:
Volker Lendecke [Tue, 8 Aug 2006 19:29:34 +0000 (19:29 +0000)]
r17463: A bit of cleanup work:

Remove some unused code: pdb_find_alias is not used anymore, and nobody I
think has ever used the pdb_nop operations for group mapping. smbpasswd and
tdb use the default ones and ldap has its own.

Make the functions pdb_getgr* return NTSTATUS instead of BOOL. Nobody right
now really makes use of it, but it feels wrong to throw away information so


15 years agor17462: Fix a cut&paste bug that caused us to return a null SID on some error conditions
Simo Sorce [Tue, 8 Aug 2006 18:38:33 +0000 (18:38 +0000)]
r17462: Fix a cut&paste bug that caused us to return a null SID on some error conditions

15 years agor17461: Ensure we never save a NULL SID mapping. || should be &&.
Jeremy Allison [Tue, 8 Aug 2006 17:34:51 +0000 (17:34 +0000)]
r17461: Ensure we never save a NULL SID mapping. || should be &&.
Found by Whitfield school.

15 years agor17460: First step at fixing the build breakage with the groupmapping test. On Linux,
Volker Lendecke [Tue, 8 Aug 2006 16:08:22 +0000 (16:08 +0000)]
r17460: First step at fixing the build breakage with the groupmapping test. On Linux,
F_RDLCK is defined to 0, for example NetBSD has it at 1.

Still does not work fully though. Still investigating.

This might also be interesting to Samba4.


15 years agor17459: As by Jerry's word commit this without his review.
Simo Sorce [Tue, 8 Aug 2006 15:33:09 +0000 (15:33 +0000)]
r17459: As by Jerry's word commit this without his review.

This patch add some missing async functions to
solve UID/GID -> SID requests not just out of the cache,
but down the remote idmap if necessary.

This patch solves the problem of servers not showing users/groups names
for allocated UID/GIDs when joined to a group of servers that share a
prepopulated idmap backend.

Also correctly resolve UID/GIDs to SIDs when looking ACLs from the
windows security tab on teh same situation.


15 years agor17457: Add a test to do some operations on group mapping.
Volker Lendecke [Tue, 8 Aug 2006 13:54:43 +0000 (13:54 +0000)]
r17457: Add a test to do some operations on group mapping.


15 years agor17454: Adding dfs_EnumEx for rpcclient (Samba4 IDL to follow).
Günther Deschner [Tue, 8 Aug 2006 11:45:57 +0000 (11:45 +0000)]
r17454: Adding dfs_EnumEx for rpcclient (Samba4 IDL to follow).


15 years agor17453: Fix msdfs RPC management (this broke with the autogenerated dfs rpcs).
Günther Deschner [Tue, 8 Aug 2006 11:00:16 +0000 (11:00 +0000)]
r17453: Fix msdfs RPC management (this broke with the autogenerated dfs rpcs).

* Remove "unknown" from dfs_Enum (samba4 dfs IDL updates to follow).

* When encountering an unsupported infolevel the rpc server must reply
with a dfs_info_0 structure and WERR_OK (observed from w2k3 when talking
to nt4).


15 years agor17452: Some C++ warnings
Volker Lendecke [Tue, 8 Aug 2006 09:56:38 +0000 (09:56 +0000)]
r17452: Some C++ warnings

15 years agor17451: Change pdb_getgrsid not to take a DOM_SID but a const DOM_SID * as an
Volker Lendecke [Tue, 8 Aug 2006 08:26:40 +0000 (08:26 +0000)]
r17451: Change pdb_getgrsid not to take a DOM_SID but a const DOM_SID * as an


15 years agor17446: Fix some C++ warnings and two memleaks found by Coverity, IDs 304 and 305.
Volker Lendecke [Mon, 7 Aug 2006 20:15:31 +0000 (20:15 +0000)]
r17446: Fix some C++ warnings and two memleaks found by Coverity, IDs 304 and 305.


15 years agor17445: fix bad PAM file on 64 bit boxes
Gerald Carter [Mon, 7 Aug 2006 18:55:42 +0000 (18:55 +0000)]
r17445: fix bad PAM file on 64 bit boxes

15 years agor17444: put pam and nss libs in samba-common on RHEL for compatibility with system...
Gerald Carter [Mon, 7 Aug 2006 18:25:28 +0000 (18:25 +0000)]
r17444: put pam and nss libs in samba-common on RHEL for compatibility with system provides rpms

15 years agor17439: Fix logic error in checking TALLOC return. Spotted by Volker.
Jeremy Allison [Mon, 7 Aug 2006 15:41:43 +0000 (15:41 +0000)]
r17439: Fix logic error in checking TALLOC return. Spotted by Volker.

15 years agor17431: Fix bug #4003, reported by
Jeremy Allison [Sat, 5 Aug 2006 20:05:37 +0000 (20:05 +0000)]
r17431: Fix bug #4003, reported by
NTcancel doesn't send a reply, so in this case the signing
sequence number is only incremented by 1, not 2.

15 years agor17425: Add the multi-key wrapper. If it's necessary to add general blobs as keys,
Volker Lendecke [Sat, 5 Aug 2006 17:49:35 +0000 (17:49 +0000)]
r17425: Add the multi-key wrapper. If it's necessary to add general blobs as keys,
this can trivially be added later.


15 years agor17408: Let us use netgroups even without a NIS domain but just using files
Simo Sorce [Fri, 4 Aug 2006 22:18:02 +0000 (22:18 +0000)]
r17408: Let us use netgroups even without a NIS domain but just using files

15 years agor17407: Don't do strchr_m twice when once will do.
Jeremy Allison [Fri, 4 Aug 2006 21:15:52 +0000 (21:15 +0000)]
r17407: Don't do strchr_m twice when once will do.

15 years agor17406: We need to do a translation of winbind separator -> '\\' in
Volker Lendecke [Fri, 4 Aug 2006 21:07:32 +0000 (21:07 +0000)]
r17406: We need to do a translation of winbind separator -> '\\' in
lookup_name_smbconf, otherwise

force user = domain+administrator

can not work. Also attempt to fix the 'valid users = domain+group' bug at the
same time.


15 years agor17404: Is this XP (extreme programming)? :-)
Volker Lendecke [Fri, 4 Aug 2006 20:43:21 +0000 (20:43 +0000)]
r17404: Is this XP (extreme programming)? :-)

With lp_workgroup we end up with remote names again...


15 years agor17403: add a helpful debug msg
Gerald Carter [Fri, 4 Aug 2006 20:39:37 +0000 (20:39 +0000)]
r17403: add a helpful debug msg

15 years agor17402: Added lookup_name_smbconf() to be called when looking
Jeremy Allison [Fri, 4 Aug 2006 20:35:52 +0000 (20:35 +0000)]
r17402: Added lookup_name_smbconf() to be called when looking
up names from smb.conf. If the name is unqualified it
causes the lookup to be done in WORKGROUP\name, then
"Unix [users|groups]"\name rather than searching the
domain. Should fix the problems with "force user"
selecting a domain user by preference.

15 years agor17401: BUG 3855: remove bits of XML and SQL checks from aclocal.m4
Gerald Carter [Fri, 4 Aug 2006 17:36:31 +0000 (17:36 +0000)]
r17401: BUG 3855: remove bits of XML and SQL checks from aclocal.m4

15 years agor17399: Some C++ warnings
Volker Lendecke [Fri, 4 Aug 2006 12:15:53 +0000 (12:15 +0000)]
r17399: Some C++ warnings

15 years agor17393: Remove Volker's ASSERT that num_groupsids > 0.
Jeremy Allison [Fri, 4 Aug 2006 01:09:57 +0000 (01:09 +0000)]
r17393: Remove Volker's ASSERT that num_groupsids > 0.
For guest connection they may well be zero.
This should fix up the buildfarm (fingers

15 years agor17392: Commit Volker's fix for the valid users problem.
Jeremy Allison [Fri, 4 Aug 2006 00:00:15 +0000 (00:00 +0000)]
r17392: Commit Volker's fix for the valid users problem.
Let's look at the build farm now... :-).

15 years agor17391: Revert the second part of the valid users fix - the
Jeremy Allison [Thu, 3 Aug 2006 23:44:07 +0000 (23:44 +0000)]
r17391: Revert the second part of the valid users fix - the
netlogon code uses pdb_get_group_sid() which could
return a S-1-1-22 unix sid. Who knew.... :-(.
I'm going to test Volker's fix instead. Once
3.0.23b is out we *have* to rip out the pdb_set_group_sid()

15 years agor17388: Fix the "valid users"/token issue for now. Volker,
Jeremy Allison [Thu, 3 Aug 2006 19:07:12 +0000 (19:07 +0000)]
r17388: Fix the "valid users"/token issue for now. Volker,
please come in and fix it in a less ugly way once
you have some time. Thanks,

15 years agor17386: fix inverted logic pointed out by Volker. When deleting a printer return...
Gerald Carter [Thu, 3 Aug 2006 15:19:01 +0000 (15:19 +0000)]
r17386: fix inverted logic pointed out by Volker.  When deleting a printer return access denied if the printer still exists after the delete_printer_hook() is called

15 years agor17383: Patch from Michael Adams <> to catch
Gerald Carter [Thu, 3 Aug 2006 12:41:20 +0000 (12:41 +0000)]
r17383: Patch from Michael Adams <> to catch
some memory leaks on error paths in net_ads_join()

15 years agor17378: Fix the issues people have been having with mapped
Jeremy Allison [Thu, 3 Aug 2006 01:49:14 +0000 (01:49 +0000)]
r17378: Fix the issues people have been having with mapped
users (username map) and failure to connect to a
share. Essentially, even on a standalone system
we were going into the create_token_from_username()
code (I think by mistake) if the username was mapped.
Fixes bug #3991.

Volker & Jerry - please go over this with a very careful eye
and let me know if this isn't correct (I think it is,
but this isn't my code and it's a dangerous area for
me to be playing in :-).


15 years agor17376: Fix bug #3985 - ensure in msdfs we check for our
Jeremy Allison [Wed, 2 Aug 2006 16:18:45 +0000 (16:18 +0000)]
r17376: Fix bug #3985 - ensure in msdfs we check for our
netbios aliases. Reported by Björn Jacke <>.
Probably needs to be in 3.0.23b (if Björn approves
of the fix).

15 years agor17375: If a field containts only whitespace, we need to do base64 as well.
Volker Lendecke [Wed, 2 Aug 2006 09:32:18 +0000 (09:32 +0000)]
r17375: If a field containts only whitespace, we need to do base64 as well.


15 years agor17374: Get rid of a silly "System User" default for "description", also fetch the
Volker Lendecke [Wed, 2 Aug 2006 08:53:22 +0000 (08:53 +0000)]
r17374: Get rid of a silly "System User" default for "description", also fetch the


15 years agor17367: Reverting the ab code. Note I'm not saying this
Jeremy Allison [Tue, 1 Aug 2006 18:40:19 +0000 (18:40 +0000)]
r17367: Reverting the ab code. Note I'm not saying this
code is wrong or bad or anything, just that it
needs to be discussed & reviewed on the samba-technical
list before we add a platform-specific NFSv4 mapping.
That way lies a lot of future pain :-).

15 years agor17366: Save the logon script path from the info3 in the PAM session allowing
Günther Deschner [Tue, 1 Aug 2006 15:31:16 +0000 (15:31 +0000)]
r17366: Save the logon script path from the info3 in the PAM session allowing
other PAM modules to pick it up from there.


15 years agor17365: Fix memleak.
Günther Deschner [Tue, 1 Aug 2006 15:17:18 +0000 (15:17 +0000)]
r17365: Fix memleak.


15 years agor17364: Another NT4 join bug: The idealx tools set the primary group sid, and if...
Volker Lendecke [Tue, 1 Aug 2006 14:46:08 +0000 (14:46 +0000)]
r17364: Another NT4 join bug: The idealx tools set the primary group sid, and if we do
an update_sam_account later on, we want to also set it using the delete/add
method. As the idealx tools use the replace method, they don't care about what
has been in there before.

Jerry, this is a likely 3.0.23b candidate. Not merging, it's your call :-)


15 years agor17363: Some C++ warnings
Volker Lendecke [Tue, 1 Aug 2006 12:45:12 +0000 (12:45 +0000)]
r17363: Some C++ warnings

15 years agor17358: Re-add JFS2 NFS4 ACLs support, move readme for it into AIX-specific examples...
Alexander Bokovoy [Tue, 1 Aug 2006 09:25:24 +0000 (09:25 +0000)]
r17358: Re-add JFS2 NFS4 ACLs support, move readme for it into AIX-specific examples directory.

15 years agor17356: Also transfer the sambaHomePath attribute.
Volker Lendecke [Tue, 1 Aug 2006 09:06:18 +0000 (09:06 +0000)]
r17356: Also transfer the sambaHomePath attribute.


15 years agor17354: Revert -r 17353 per Volker request while gpfs compatibility layer code will...
Alexander Bokovoy [Tue, 1 Aug 2006 08:27:19 +0000 (08:27 +0000)]
r17354: Revert -r 17353 per Volker request while gpfs compatibility layer code will be released.

15 years agor17353: Add support for JFS2 NFS4/AIXC and GPFS acls based on NFSv4 ACLs.
Alexander Bokovoy [Tue, 1 Aug 2006 07:38:36 +0000 (07:38 +0000)]
r17353: Add support for JFS2 NFS4/AIXC and GPFS acls based on NFSv4 ACLs.

15 years agor17348: Some C++ warnings
Volker Lendecke [Mon, 31 Jul 2006 21:40:25 +0000 (21:40 +0000)]
r17348: Some C++ warnings

15 years agor17347: Some C++ warnings -- 271 left
Volker Lendecke [Mon, 31 Jul 2006 21:11:03 +0000 (21:11 +0000)]
r17347: Some C++ warnings -- 271 left

15 years agor17346: Add optimisation vl needs for the cluster code where
Jeremy Allison [Mon, 31 Jul 2006 20:58:02 +0000 (20:58 +0000)]
r17346: Add optimisation vl needs for the cluster code where
we don't get the chainlock when getting the byte range
lock record read-only.

15 years agor17345: Some C++ warnings
Volker Lendecke [Mon, 31 Jul 2006 20:51:55 +0000 (20:51 +0000)]
r17345: Some C++ warnings

15 years agor17338: Add support for multiple shares test inspired by Samba 4 torture's --unclist...
Alexander Bokovoy [Mon, 31 Jul 2006 09:41:25 +0000 (09:41 +0000)]
r17338: Add support for multiple shares test inspired by Samba 4 torture's --unclist option. Triggered by -b sharelist_file option.
Based on Peter Samogyi's work. I'm not sure what concept for fstring replacement is currently in place though (talloc-ed strings? or it was for pstring only?)

15 years agor17335: Some more fixes to net rpc vampire ldif. Still not good though :-(
Volker Lendecke [Mon, 31 Jul 2006 06:01:54 +0000 (06:01 +0000)]
r17335: Some more fixes to net rpc vampire ldif. Still not good though :-(


15 years agor17334: Some C++ warnings
Volker Lendecke [Mon, 31 Jul 2006 04:30:55 +0000 (04:30 +0000)]
r17334: Some C++ warnings

15 years agor17333: Some C++ warnings
Volker Lendecke [Mon, 31 Jul 2006 03:53:39 +0000 (03:53 +0000)]
r17333: Some C++ warnings

15 years agor17316: More C++ warnings -- 456 left
Volker Lendecke [Sun, 30 Jul 2006 16:36:56 +0000 (16:36 +0000)]
r17316: More C++ warnings -- 456 left

15 years agor17315: Make talloc and tdb C++-warning-free. Would this also be interesting in talloc
Volker Lendecke [Sun, 30 Jul 2006 10:42:11 +0000 (10:42 +0000)]
r17315: Make talloc and tdb C++-warning-free. Would this also be interesting in talloc
and tdb "upstream"?


15 years agor17314: Optimisation for POSIX locking. If we're downgrading
Jeremy Allison [Sat, 29 Jul 2006 19:14:24 +0000 (19:14 +0000)]
r17314: Optimisation for POSIX locking. If we're downgrading
a POSIX lock (applying a read-lock) and we overlap
pending read locks then send them an unlock message,
we may have allowed them to proceed.

15 years agor17313: Non-Ascii attribute values need to be encoded as base64, with an attribute
Volker Lendecke [Sat, 29 Jul 2006 17:33:48 +0000 (17:33 +0000)]
r17313: Non-Ascii attribute values need to be encoded as base64, with an attribute
name attr:: instead of attr:

German domains tend to have umlauts in group names.

More to come tomorrow.


15 years agor17312: Do some reformatting on net rpc samsync ldif. Not doing this checkin easily,
Volker Lendecke [Sat, 29 Jul 2006 15:45:19 +0000 (15:45 +0000)]
r17312: Do some reformatting on net rpc samsync ldif. Not doing this checkin easily,
as this puts me into svn blame in places I'm not sure I want my name to show


15 years agor17307: Add datarootdir setting (required for newer autoconfs)
Jelmer Vernooij [Sat, 29 Jul 2006 11:33:04 +0000 (11:33 +0000)]
r17307: Add datarootdir setting (required for newer autoconfs)

15 years agor17296: Replace the understandable parts of the quota
Jeremy Allison [Fri, 28 Jul 2006 23:16:52 +0000 (23:16 +0000)]
r17296: Replace the understandable parts of the quota
code with become_root_uid_only()/unbecome_root_uid_only()
pairs. This code needs working on.....

15 years agor17295: Back out the become_root_uid_only change on the POSIX
Jeremy Allison [Fri, 28 Jul 2006 23:09:12 +0000 (23:09 +0000)]
r17295: Back out the become_root_uid_only change on the POSIX
acls code. I'm pretty sure this was safe, but become_root()
does other things to the token stack that become_root_uid_only()
does not, and as we're going into a vfs redirectred function
I decided it wasn't safe for now.

15 years agor17294: Make the code a little cleaner. Instead of using the two
Jeremy Allison [Fri, 28 Jul 2006 22:56:41 +0000 (22:56 +0000)]
r17294: Make the code a little cleaner. Instead of using the two
calls make it :


saving errno across the second call. Most of our internal
change calls can be replaced with these simple calls.


15 years agor17293: After the results from the cluster tests in Germany,
Jeremy Allison [Fri, 28 Jul 2006 22:42:39 +0000 (22:42 +0000)]
r17293: After the results from the cluster tests in Germany,
fix the messaging code to call the efficient calls :




instead of using heavyweight become_root()/unbecome_root()
pairs around all messaging code. Fixup the messaging
code to ensure sec_init() is called (only once) so that non-root
processes still work when sending messages.

This is a lighter weight solution to become_root()/unbecome_root()
(which swaps all the supplemental groups) and should be more
efficient. I will migrate all server code over to using this
(a similar technique should be used in the passdb backend
where needed).


15 years agor17292: Try and fix bug #3967 - signing problems on trans
Jeremy Allison [Fri, 28 Jul 2006 21:23:53 +0000 (21:23 +0000)]
r17292: Try and fix bug #3967 - signing problems on trans
calls introduced by signing code simplification.
Please test if you've seen signing problems with

15 years agor17291: Fix memory leaks on early exit path.
Jeremy Allison [Fri, 28 Jul 2006 20:35:00 +0000 (20:35 +0000)]
r17291: Fix memory leaks on early exit path.

15 years agor17279: conn->cnum is the tid we've given to the client. This has nothing to do with
Volker Lendecke [Thu, 27 Jul 2006 17:23:57 +0000 (17:23 +0000)]
r17279: conn->cnum is the tid we've given to the client. This has nothing to do with
our internal share number.

Funny that it worked at all :-)


15 years agor17276: Don't change the POSIX lock ref count if posix locking = no.
Jeremy Allison [Thu, 27 Jul 2006 15:23:46 +0000 (15:23 +0000)]
r17276: Don't change the POSIX lock ref count if posix locking = no.

15 years agor17271: Fix a regression in the ldapsam uri syntax.
Gerald Carter [Thu, 27 Jul 2006 12:20:19 +0000 (12:20 +0000)]
r17271: Fix a regression in the ldapsam uri syntax.
Allow multiple LDAP URIs to be grouped by  ""

15 years agor17262: After messages from Metze and traces from Karolin Seeger,
Jeremy Allison [Wed, 26 Jul 2006 17:24:54 +0000 (17:24 +0000)]
r17262: After messages from Metze and traces from Karolin Seeger,
turns out that EDQUOTA must map to NT_STATUS_DISK_FULL
for Windows apps to work correctly. My mistake.

15 years agor17260: remove extra ;SAMBA_3_0_23/source/utils/netlookup.c
Gerald Carter [Wed, 26 Jul 2006 16:47:58 +0000 (16:47 +0000)]
r17260: remove extra ;SAMBA_3_0_23/source/utils/netlookup.c

15 years agor17258: Cleanup the 'net ads help join' output and document createupn
Gerald Carter [Wed, 26 Jul 2006 15:26:51 +0000 (15:26 +0000)]
r17258: Cleanup the 'net ads help join' output and document createupn
and createcomputer options

15 years agor17254: Simple flattening of an if-statement, no logic change.
Volker Lendecke [Wed, 26 Jul 2006 08:08:48 +0000 (08:08 +0000)]
r17254: Simple flattening of an if-statement, no logic change.

Jeremy, I'm sure you will look at this nevertheless :-)


15 years agor17249: Ensure we only set the FILE_WRITE_DATA on O_TRUNC
Jeremy Allison [Wed, 26 Jul 2006 04:42:18 +0000 (04:42 +0000)]
r17249: Ensure we only set the FILE_WRITE_DATA on O_TRUNC
in one place.

15 years agor17248: Ensure we definately add the WRITE_DATA on O_TRUNC.
Jeremy Allison [Wed, 26 Jul 2006 02:15:01 +0000 (02:15 +0000)]
r17248: Ensure we definately add the WRITE_DATA on O_TRUNC.

15 years agor17247: When we map generic to specific we need to remember
Jeremy Allison [Wed, 26 Jul 2006 01:53:23 +0000 (01:53 +0000)]
r17247: When we map generic to specific we need to remember
to copy over the copy of the access_mask, open_access_mask.
Jerry - this is a definate fix for a 3.0.23b and should also
be on the patches page. CIFSFS breaks without this.

15 years agor17246: BUG 3964: lower case username prior to getpwnam() call in smbpasswd
Gerald Carter [Tue, 25 Jul 2006 21:48:13 +0000 (21:48 +0000)]
r17246: BUG 3964: lower case username prior to getpwnam() call in smbpasswd

15 years agor17245: Second part of fix for #3962. Don't do a double
Jeremy Allison [Tue, 25 Jul 2006 21:33:13 +0000 (21:33 +0000)]
r17245: Second part of fix for #3962. Don't do a double
free in the infolevel2 case. Free both queue and
NT_PRINTER_INFO_LEVEL in the same place.

15 years agor17244: There were several error paths where NT_PRINTER_INFO_LEVEL
Jeremy Allison [Tue, 25 Jul 2006 21:23:34 +0000 (21:23 +0000)]
r17244: There were several error paths where NT_PRINTER_INFO_LEVEL
wasn't being freed - also one enum jobs case where the
NT_PRINTER_INFO_LEVEL and queue weren't being freed.
Strange that Coverity or Klokwork didn't pick these up.
Hopefully will fix #3962.

15 years agor17242: BUG 3957: make sure to zero memory in the SRV hostlist in case there is not...
Gerald Carter [Tue, 25 Jul 2006 20:11:03 +0000 (20:11 +0000)]
r17242: BUG 3957: make sure to zero memory in the SRV hostlist in case there is not an A record for each SRV name

15 years agor17239: BUG 3959: patch from William Charles <> to fix a segv...
Gerald Carter [Tue, 25 Jul 2006 19:59:35 +0000 (19:59 +0000)]
r17239: BUG 3959: patch from William Charles <> to fix a segv in the DNS SRV lookups dur to calling rand()

15 years agor17234: Fix error mappings for EQUOTA and ENOBUFS.
Jeremy Allison [Tue, 25 Jul 2006 16:48:08 +0000 (16:48 +0000)]
r17234: Fix error mappings for EQUOTA and ENOBUFS.
Based on an idea from Shlomi Yaakobovich <>.

15 years agor17231: Some patch cosmetics
Volker Lendecke [Tue, 25 Jul 2006 14:59:32 +0000 (14:59 +0000)]
r17231: Some patch cosmetics

15 years agor17229: Indent-style reformatting -- getting used to the code again :-)
Volker Lendecke [Tue, 25 Jul 2006 08:51:54 +0000 (08:51 +0000)]
r17229: Indent-style reformatting -- getting used to the code again :-)

15 years agor17228: Modest reformatting
Volker Lendecke [Tue, 25 Jul 2006 08:40:04 +0000 (08:40 +0000)]
r17228: Modest reformatting

15 years agor17220: If we're going to fail a write with an errno, make
Jeremy Allison [Tue, 25 Jul 2006 00:16:45 +0000 (00:16 +0000)]
r17220: If we're going to fail a write with an errno, make
sure we return -1.

15 years agor17217: Fix a couple of "smbldap_open(): Cannot open when not root" bugs
Gerald Carter [Mon, 24 Jul 2006 12:05:20 +0000 (12:05 +0000)]
r17217: Fix a couple of "smbldap_open(): Cannot open when not root" bugs
when viewing or modifying local group membership.

15 years agor17216: From Kai Blin <>:
Andrew Bartlett [Mon, 24 Jul 2006 05:02:38 +0000 (05:02 +0000)]
r17216: From Kai Blin <>:

A patch to make ntlm_auth recognize three new commands in
ntlmssp-client-1 and squid-2.5-ntlmssp:

The commands are the following:

Command: SF <hex number>
Reply: OK
Description: Takes feature request flags similar to samba4's
gensec_want_feature() call. So far, only NTLMSSP_FEATURE_SESSION_KEY,
NTLMSSP_FEATURE_SIGN and NTLMSSP_FEATURE_SEAL are implemented, using the same
values as the corresponding GENSEC_FEATURE_* flags in samba4.

Command: GF
Reply: GF <hex number>
Description: Returns the negotiated flags.

Command: GK
Reply: GK <base64 encoded session key>
Description: Returns the negotiated session key.

(These commands assist a wine project to use ntlm_auth for signing and
sealing of bulk data).

Andrew Bartlett

15 years agor17199: Add comment to the RID/SID miracle
Volker Lendecke [Sun, 23 Jul 2006 08:18:31 +0000 (08:18 +0000)]
r17199: Add comment to the RID/SID miracle

15 years agor17198: Fix wins_nss dependencies
Alexander Bokovoy [Sun, 23 Jul 2006 03:33:28 +0000 (03:33 +0000)]
r17198: Fix wins_nss dependencies

15 years agor17194: To run rpc-samba3-lsa in the build farm, we can't rely on geteuid()==0. Adapt
Volker Lendecke [Sat, 22 Jul 2006 20:46:02 +0000 (20:46 +0000)]
r17194: To run rpc-samba3-lsa in the build farm, we can't rely on geteuid()==0. Adapt
it to other "Am I root?" checks.

Jerry, Jeremy, please check this!



15 years agor17192: Make this actually survive valgrind. We NEED pidl here...
Volker Lendecke [Sat, 22 Jul 2006 19:44:17 +0000 (19:44 +0000)]
r17192: Make this actually survive valgrind. We NEED pidl here...

Maybe bzr is not such a bad idea, then you would probably see less spam on
samba-cvs, sorry for that... :-)


15 years agor17191: Forgotten file, sorry!
Volker Lendecke [Sat, 22 Jul 2006 19:34:10 +0000 (19:34 +0000)]
r17191: Forgotten file, sorry!

15 years agor17190: Remove a warning from "opi", a 64-bit machine
Volker Lendecke [Sat, 22 Jul 2006 19:29:02 +0000 (19:29 +0000)]
r17190: Remove a warning from "opi", a 64-bit machine