ira/wip.git
11 years agosocket_wrapper: prepare pcap support for ipv6 traffic
Stefan Metzmacher [Tue, 3 Mar 2009 13:58:53 +0000 (14:58 +0100)]
socket_wrapper: prepare pcap support for ipv6 traffic

metze

11 years agos4:blackbox/test_ldb: make use of the $VALGRIND envvar
Stefan Metzmacher [Tue, 3 Mar 2009 18:23:25 +0000 (19:23 +0100)]
s4:blackbox/test_ldb: make use of the $VALGRIND envvar

metze

11 years agosocket_wrapper: don't crash if we get EAGAIN from real_recv()
Stefan Metzmacher [Tue, 3 Mar 2009 18:20:43 +0000 (19:20 +0100)]
socket_wrapper: don't crash if we get EAGAIN from real_recv()

This fixes a crash in the ldaps tests with socket wrapper pcap support.

metze

11 years agoMerge branch 'master' of ssh://git.samba.org/data/git/samba into abartlet-devel
Andrew Bartlett [Wed, 4 Mar 2009 03:10:41 +0000 (14:10 +1100)]
Merge branch 'master' of ssh://git.samba.org/data/git/samba into abartlet-devel

11 years agoPull in all the schema information during DRS schema fetch
Andrew Bartlett [Wed, 4 Mar 2009 03:06:11 +0000 (14:06 +1100)]
Pull in all the schema information during DRS schema fetch

This includes things such as allowed attributes, which were not
populated into the schema structure before.

Andrew Bartlett

11 years agoDon't print the admin password if we don't set one.
Andrew Bartlett [Wed, 4 Mar 2009 03:02:35 +0000 (14:02 +1100)]
Don't print the admin password if we don't set one.

For example, if we don't create the admin user (perhaps expecting
users to be in LDAP already, or we are due an incoming replication) we
should not confuse the administrator by printing a unused password.

Andrew Bartlett

11 years agoAllow 'net vampire' to work without an existing smb.conf
Andrew Bartlett [Wed, 4 Mar 2009 02:58:07 +0000 (13:58 +1100)]
Allow 'net vampire' to work without an existing smb.conf

Now the provision can generate one based on the detected settings from
the target domain.

Andrew Bartlett

11 years agos3 passdb: Add back some useful debug statements
Tim Prouty [Wed, 4 Mar 2009 00:47:48 +0000 (16:47 -0800)]
s3 passdb: Add back some useful debug statements

Originally removed in be1dfff02d562e42a7847bd02fed8538630d3f41

11 years agoFix bug #6155 - "force group" is no longer working as expected.
Jeremy Allison [Wed, 4 Mar 2009 00:08:56 +0000 (16:08 -0800)]
Fix bug #6155 - "force group" is no longer working as expected.
We need to store the "force group" uid separately from the
conn->server_info token as we need to apply it separately also.
Volker PLEASE CHECK !
Jeremy.

11 years agos3 OneFS: Add parameter to ignore streams
Tim Prouty [Sat, 28 Feb 2009 00:25:31 +0000 (16:25 -0800)]
s3 OneFS: Add parameter to ignore streams

11 years agolib/util: remove samba specific talloc_get_type_abort()
Stefan Metzmacher [Tue, 3 Mar 2009 17:03:57 +0000 (18:03 +0100)]
lib/util: remove samba specific talloc_get_type_abort()

metze

11 years agotalloc: add talloc_get_type_abort()
Stefan Metzmacher [Tue, 3 Mar 2009 17:01:01 +0000 (18:01 +0100)]
talloc: add talloc_get_type_abort()

metze

11 years agoFix "ignore return" warning.
Jeremy Allison [Tue, 3 Mar 2009 16:50:35 +0000 (08:50 -0800)]
Fix "ignore return" warning.
Jeremy.

11 years agoIt appears that the first time we see a uid/gid that winbind can't map,
Dan Sledz [Tue, 3 Mar 2009 00:50:19 +0000 (16:50 -0800)]
It appears that the first time we see a uid/gid that winbind can't map,
we end up returning the null sid instead of falling back to the legacy
code.  Next time through the code we'll hit the negative cache and do
the right thing, but we still fail the first time.

If we fail the winbind id to sid mapping, call the legacy version.  This
catches the case where we don't have a negative cache entry for the mapping.
This is better than returning the NULL sid to the caller.

11 years agoMore fix to initialize idmap statuses
Bo Yang [Mon, 2 Mar 2009 06:19:50 +0000 (14:19 +0800)]
More fix to initialize idmap statuses

11 years agouse test -f, Solaris /bin/sh doesn't know test -e
Björn Jacke [Mon, 2 Mar 2009 16:01:37 +0000 (17:01 +0100)]
use test -f, Solaris /bin/sh doesn't know test -e

11 years agoFix wbclient.c wrt tevent_req changes too.
Simo Sorce [Mon, 2 Mar 2009 20:38:45 +0000 (15:38 -0500)]
Fix wbclient.c wrt tevent_req changes too.

11 years agoAttempt to fix the build
Volker Lendecke [Mon, 2 Mar 2009 19:10:13 +0000 (20:10 +0100)]
Attempt to fix the build

Simo, with which compiler did you build this? I'd be curious to learn about the
compiler settings that make this build.

Thanks,

Volker

11 years agoMake struct tevent_req opaque
Simo Sorce [Sat, 28 Feb 2009 20:44:30 +0000 (15:44 -0500)]
Make struct tevent_req opaque

Move struct tevent_req in tevent_internal, and ad getters and setters
for private data and the callback function.
This patch also renames 'private_state' into 'data'. What is held in this
pointer is in fact data and not a state like enum tevent_req_state.
Calling it 'state' is confusing.

The functions addedd are:
tevent_req_set_callback() - sets req->async.fn and req->async.private_data
tevent_req_set_print_fn() - sets req->private_print
tevent_req_callback_data() - gets req->async.private_data
tevent_req_data() - gets rea->data

This way it is much simpler to keep API/ABI compatibility in the future.

11 years agos3-spoolss: PRINTER_STATUS_OK has been moved to IDL.
Günther Deschner [Mon, 2 Mar 2009 12:09:19 +0000 (13:09 +0100)]
s3-spoolss: PRINTER_STATUS_OK has been moved to IDL.

Guenther

11 years agos3-rpcclient: zero out devmode and secdesc in setdriver and setprinter command.
Günther Deschner [Mon, 2 Mar 2009 10:21:26 +0000 (11:21 +0100)]
s3-rpcclient: zero out devmode and secdesc in setdriver and setprinter command.

Guenther

11 years agos3: re-run make samba3-idl.
Günther Deschner [Mon, 2 Mar 2009 13:23:42 +0000 (14:23 +0100)]
s3: re-run make samba3-idl.

Guenther

11 years agospoolss: move up printer and job status codes.
Günther Deschner [Mon, 2 Mar 2009 12:08:55 +0000 (13:08 +0100)]
spoolss: move up printer and job status codes.

Guenther

11 years agospoolss: use dummy pointers for truncated devmode and secdesc in SetJobInfo2/4.
Günther Deschner [Mon, 2 Mar 2009 10:19:57 +0000 (11:19 +0100)]
spoolss: use dummy pointers for truncated devmode and secdesc in SetJobInfo2/4.

Guenther

11 years agoerror-codes: add WERR_DEVICE_NOT_CONNECTED.
Günther Deschner [Mon, 2 Mar 2009 12:07:46 +0000 (13:07 +0100)]
error-codes: add WERR_DEVICE_NOT_CONNECTED.

Guenther

11 years agomake man page (un)install more portable
Björn Jacke [Sun, 1 Mar 2009 20:08:33 +0000 (21:08 +0100)]
make man page (un)install more portable

11 years agosome shells are picky about ^ without quotes
Björn Jacke [Sun, 1 Mar 2009 20:38:31 +0000 (21:38 +0100)]
some shells are picky about ^ without quotes

11 years agos3/docs: Add missing full stop.
Karolin Seeger [Fri, 27 Feb 2009 10:09:59 +0000 (11:09 +0100)]
s3/docs: Add missing full stop.

Karolin

11 years agolibcli/security: fix the source4 build
Stefan Metzmacher [Mon, 2 Mar 2009 11:05:43 +0000 (12:05 +0100)]
libcli/security: fix the source4 build

metze

11 years agolibcli/security: fix the source3 build
Stefan Metzmacher [Mon, 2 Mar 2009 07:55:00 +0000 (08:55 +0100)]
libcli/security: fix the source3 build

metze

11 years agoFix test_surrounding in samba4.rpcecho.python.
Jelmer Vernooij [Mon, 2 Mar 2009 04:07:30 +0000 (05:07 +0100)]
Fix test_surrounding in samba4.rpcecho.python.

11 years agoUse samba3's own iconv implementation for now, until all changes are
Jelmer Vernooij [Mon, 2 Mar 2009 04:04:07 +0000 (05:04 +0100)]
Use samba3's own iconv implementation for now, until all changes are
merged.

11 years agoMerge branch 'master' of git://git.samba.org/samba into convenience
Jelmer Vernooij [Mon, 2 Mar 2009 03:15:11 +0000 (04:15 +0100)]
Merge branch 'master' of git://git.samba.org/samba into convenience

11 years agoImport ISO-8859-1, 646 from Samba 3 iconv.
Jelmer Vernooij [Mon, 2 Mar 2009 03:12:57 +0000 (04:12 +0100)]
Import ISO-8859-1, 646 from Samba 3 iconv.

11 years agos3: Fix incompatible type warnings
Tim Prouty [Sun, 1 Mar 2009 21:58:46 +0000 (13:58 -0800)]
s3: Fix incompatible type warnings

11 years agos3 OneFS: Refactor config code and cleanup includes
Tim Prouty [Fri, 27 Feb 2009 22:47:47 +0000 (14:47 -0800)]
s3 OneFS: Refactor config code and cleanup includes

11 years agoUse shared header file for character sets, remove old definitions from samba3 smb.h.
Jelmer Vernooij [Sun, 1 Mar 2009 21:31:10 +0000 (22:31 +0100)]
Use shared header file for character sets, remove old definitions from samba3 smb.h.

11 years agoMerge branch 'master' of git://git.samba.org/samba into convenience
Jelmer Vernooij [Sun, 1 Mar 2009 21:25:57 +0000 (22:25 +0100)]
Merge branch 'master' of git://git.samba.org/samba into convenience

11 years agoUse common header file for character set handling in Samba 3 and Samba 4.
Jelmer Vernooij [Sun, 1 Mar 2009 21:24:34 +0000 (22:24 +0100)]
Use common header file for character set handling in Samba 3 and Samba 4.

11 years agoAdd header files for secace and secacl.
Jelmer Vernooij [Sun, 1 Mar 2009 19:06:55 +0000 (20:06 +0100)]
Add header files for secace and secacl.

11 years agos4: Use same function signature for convert_* as s3.
Jelmer Vernooij [Sun, 1 Mar 2009 18:55:46 +0000 (19:55 +0100)]
s4: Use same function signature for convert_* as s3.

11 years agoMove secacl to top-level.
Jelmer Vernooij [Sun, 1 Mar 2009 17:15:36 +0000 (18:15 +0100)]
Move secacl to top-level.

11 years agodom_sid.h: Include dependency security.h that provides the dom_sid struct.
Jelmer Vernooij [Sun, 1 Mar 2009 17:15:15 +0000 (18:15 +0100)]
dom_sid.h: Include dependency security.h that provides the dom_sid struct.

11 years agoAlso re-add removed codepoint_t; I'm clearly not having my day today.
Jelmer Vernooij [Sun, 1 Mar 2009 17:05:22 +0000 (18:05 +0100)]
Also re-add removed codepoint_t; I'm clearly not having my day today.

11 years agoKeep using Samba3's charset.h for now.
Jelmer Vernooij [Sun, 1 Mar 2009 17:02:24 +0000 (18:02 +0100)]
Keep using Samba3's charset.h for now.

11 years agoMove secace.c to top-level.
Jelmer Vernooij [Sun, 1 Mar 2009 16:59:30 +0000 (17:59 +0100)]
Move secace.c to top-level.

11 years agoMerge branch 'master' of git://git.samba.org/samba into convenience
Jelmer Vernooij [Sun, 1 Mar 2009 16:29:04 +0000 (17:29 +0100)]
Merge branch 'master' of git://git.samba.org/samba into convenience

11 years agoMerge branch 'master' of ssh://git.samba.org/data/git/samba into talloc-next
Jelmer Vernooij [Sun, 1 Mar 2009 16:13:10 +0000 (17:13 +0100)]
Merge branch 'master' of ssh://git.samba.org/data/git/samba into talloc-next

11 years agoRerun pidl.
Jelmer Vernooij [Sun, 1 Mar 2009 16:09:45 +0000 (17:09 +0100)]
Rerun pidl.

11 years agoDon't generate array iterators when the length of the array is always 0.
Jelmer Vernooij [Sun, 1 Mar 2009 16:09:07 +0000 (17:09 +0100)]
Don't generate array iterators when the length of the array is always 0.
(bug #6140)

11 years agoMerge branch 'master' of git://git.samba.org/samba into convenience
Jelmer Vernooij [Sun, 1 Mar 2009 15:41:57 +0000 (16:41 +0100)]
Merge branch 'master' of git://git.samba.org/samba into convenience

11 years agoMerge branch 'master' of git://git.samba.org/samba into teventfix
Jelmer Vernooij [Sun, 1 Mar 2009 15:39:35 +0000 (16:39 +0100)]
Merge branch 'master' of git://git.samba.org/samba into teventfix

Conflicts:
lib/tevent/pytevent.c

11 years agoAvoid using tevent_util.h, which won't be available if we use the system
Jelmer Vernooij [Sun, 1 Mar 2009 15:38:07 +0000 (16:38 +0100)]
Avoid using tevent_util.h, which won't be available if we use the system
tevent.

11 years agoMerge branch 'master' of ssh://git.samba.org/data/git/samba into talloc-next
Jelmer Vernooij [Sun, 1 Mar 2009 15:23:53 +0000 (16:23 +0100)]
Merge branch 'master' of ssh://git.samba.org/data/git/samba into talloc-next

11 years agoMove next_token_talloc to util.c, as util_str.c is only compiled inside samba 4.
Jelmer Vernooij [Sun, 1 Mar 2009 15:19:38 +0000 (16:19 +0100)]
Move next_token_talloc to util.c, as util_str.c is only compiled inside samba 4.

11 years agoMove next_token_talloc() to top-level.
Jelmer Vernooij [Sun, 1 Mar 2009 15:16:16 +0000 (16:16 +0100)]
Move next_token_talloc() to top-level.

11 years agoSync smb_iconv_t type, convert_string return type with Samba 3 equivalents.
Jelmer Vernooij [Sun, 1 Mar 2009 11:59:58 +0000 (12:59 +0100)]
Sync smb_iconv_t type, convert_string return type with Samba 3 equivalents.

11 years agoOnly copy sharename up from rap_to_pjobid
Volker Lendecke [Sun, 1 Mar 2009 10:39:44 +0000 (11:39 +0100)]
Only copy sharename up from rap_to_pjobid

Why?? :-)

Another one of the little micro-optimizations that I just came across: If you
allocate a variable in a sub-block like the "fstring sharename" in
write_file(), gcc even with -O3 will allocate this variable unconditionally on
the stack at the beginning of the routine. So with eliminating this fstring we
cut 256 bytes of stack in a very hot code path writing to a file. It might make
us a bit more cache-friendly.

This would probably not be worth a second look if it involved larger code
changes, but this one was just too simple to let it pass :-)

11 years agoAdd allow_badcharcnv argument to all conversion function, for
Jelmer Vernooij [Sun, 1 Mar 2009 05:33:40 +0000 (06:33 +0100)]
Add allow_badcharcnv argument to all conversion function, for
consistency with Samba 3.

11 years agoMerge branch 'master' of git://git.samba.org/samba into HEAD
Jelmer Vernooij [Sun, 1 Mar 2009 04:46:15 +0000 (05:46 +0100)]
Merge branch 'master' of git://git.samba.org/samba into HEAD

11 years agoEliminate two duplicate SEC_ACE_TYPE constants already provided by
Jelmer Vernooij [Sun, 1 Mar 2009 03:59:07 +0000 (04:59 +0100)]
Eliminate two duplicate SEC_ACE_TYPE constants already provided by
security.idl.

11 years agoFix bug #6082 - smbd_gpfs_getacl failed: Windows client can´t rename or
Jeremy Allison [Sat, 28 Feb 2009 21:14:23 +0000 (13:14 -0800)]
Fix bug #6082 - smbd_gpfs_getacl failed: Windows client can´t rename or
delete file (directory fix).
Jeremy.

11 years agoFix async reading winbindd_response
Volker Lendecke [Sat, 28 Feb 2009 11:20:56 +0000 (12:20 +0100)]
Fix async reading winbindd_response

11 years agoSimplify async_connect_send slightly
Volker Lendecke [Sat, 28 Feb 2009 11:19:24 +0000 (12:19 +0100)]
Simplify async_connect_send slightly

11 years agoAnd the prize for the most pain caused in the build farm for a simple
Jeremy Allison [Sat, 28 Feb 2009 04:57:49 +0000 (20:57 -0800)]
And the prize for the most pain caused in the build farm for a simple
typo goes to.....
Tim Prouty !!!!
Sorry Tim, nice test but you made a typo in passing in
the size of an array so we were reading uninitialized
memory :-).
That took far longer than it should have to track down...
(%$&#ing build system....).
The build farm should now slowly go back to normal.
Jeremy.

11 years agoInitialize the id_map status in idmap_ldap to avoid surprise
Bo Yang [Thu, 26 Feb 2009 09:44:33 +0000 (17:44 +0800)]
Initialize the id_map status in idmap_ldap to avoid surprise

11 years agos3: re-run make samba3-idl.
Günther Deschner [Fri, 27 Feb 2009 12:33:51 +0000 (13:33 +0100)]
s3: re-run make samba3-idl.

Guenther

11 years agospoolss: fill in spoolss_SetJobInfo1,2,3,4.
Günther Deschner [Fri, 27 Feb 2009 12:31:02 +0000 (13:31 +0100)]
spoolss: fill in spoolss_SetJobInfo1,2,3,4.

Guenther

11 years agospoolss: add spoolss_PortInfo3 and spoolss_PortInfoFF.
Günther Deschner [Fri, 27 Feb 2009 10:27:44 +0000 (11:27 +0100)]
spoolss: add spoolss_PortInfo3 and spoolss_PortInfoFF.

Guenther

11 years agos3-spoolss: use DSPRINT flags instead of SPOOLS_DS flags.
Günther Deschner [Thu, 26 Feb 2009 22:40:58 +0000 (23:40 +0100)]
s3-spoolss: use DSPRINT flags instead of SPOOLS_DS flags.

Guenther

11 years agoUse talloc_tos() in regkey_access_check()
Volker Lendecke [Fri, 27 Feb 2009 10:18:35 +0000 (11:18 +0100)]
Use talloc_tos() in regkey_access_check()

11 years agos3: fix guest auth when winbindd is running
Steven Danneman [Fri, 27 Feb 2009 01:47:32 +0000 (17:47 -0800)]
s3: fix guest auth when winbindd is running

This fix is very subtle.  If a server is configured with "security = share"
and "guest ok = yes" and winbindd is running authorization will fail during
tree connect.

This is due to our inability to map the guest sid S-1-5-21-X-501 to a uid
through sid_to_uid().  Winbindd is unaware of the hard coded mapping
between this sid and whatever uid the name in lp_guestaccount() is assigned.
So sid_to_uid() fails and we exit create_token_from_username() without
ever calling pdb_getsampwsid() which IS aware of the hard coded mapping.

This patch just reorganizes the code, moving sid_to_uid() down to the
block of code in which it is needed, avoiding this early failure.

11 years agos3-rpcclient: add getjob spoolss command.
Günther Deschner [Thu, 26 Feb 2009 14:35:12 +0000 (15:35 +0100)]
s3-rpcclient: add getjob spoolss command.

Guenther

11 years agos3-rpcclient: use is_valid_policy_hnd before closing handles.
Günther Deschner [Thu, 26 Feb 2009 14:33:16 +0000 (15:33 +0100)]
s3-rpcclient: use is_valid_policy_hnd before closing handles.

Guenther

11 years agos3-spoolss: remove old rpccli_spoolss_getjob.
Günther Deschner [Thu, 26 Feb 2009 14:34:46 +0000 (15:34 +0100)]
s3-spoolss: remove old rpccli_spoolss_getjob.

Guenther

11 years agos3-spoolss: add rpccli_spoolss_getjob convenience wrapper.
Günther Deschner [Thu, 26 Feb 2009 14:33:57 +0000 (15:33 +0100)]
s3-spoolss: add rpccli_spoolss_getjob convenience wrapper.

Guenther

11 years agos3: re-run make samba3-idl.
Günther Deschner [Thu, 26 Feb 2009 21:01:55 +0000 (22:01 +0100)]
s3: re-run make samba3-idl.

Guenther

11 years agospoolss: add 2 new SPOOLSS_JOB_CONTROL values.
Günther Deschner [Thu, 26 Feb 2009 14:52:51 +0000 (15:52 +0100)]
spoolss: add 2 new SPOOLSS_JOB_CONTROL values.

Guenther

11 years agospoolss: add spoolss_JobInfo2, JobInfo3 and JobInfo4 (new in vista).
Günther Deschner [Thu, 26 Feb 2009 14:29:23 +0000 (15:29 +0100)]
spoolss: add spoolss_JobInfo2, JobInfo3 and JobInfo4 (new in vista).

Guenther

11 years agodon't hardcode python path
Björn Jacke [Thu, 26 Feb 2009 15:32:57 +0000 (16:32 +0100)]
don't hardcode python path

Signed-off-by: Michael Adam <obnox@samba.org>
11 years agoMake us pass the RAW-RENAME torture test I just added.
Jeremy Allison [Thu, 26 Feb 2009 19:42:23 +0000 (11:42 -0800)]
Make us pass the RAW-RENAME torture test I just added.

Inside a directory, keep a file open and then renaming
the directory should fail with ACCESS_DENIED.

Jeremy.

11 years agoAdd another torture test inspired by George @ Apple.
Jeremy Allison [Thu, 26 Feb 2009 18:13:57 +0000 (10:13 -0800)]
Add another torture test inspired by George @ Apple.
Inside a directory, keep a file open and then renaming
the directory should fail with ACCESS_DENIED. This
is connected to the test case where the close was
failing due to a delayed write on a file not being
able to succeed when Samba allowed the containing
directory to be renamed.

I will fix this in the server shortly (this should be done
across connections also but with will be very hard
in Samba - would need a full scan of the open file
db on every directory rename) - so I will fix for
the local case first (scanning local file opens
inside an smbd is cheap).

Jeremy.

11 years agolib/torture: fix depency to map_nt_error_from_unix()
Stefan Metzmacher [Thu, 26 Feb 2009 14:36:16 +0000 (15:36 +0100)]
lib/torture: fix depency to map_nt_error_from_unix()

This should fix the build on Mac OS 10

metze

11 years agos3: fix the build JOB_STATUS_BLOCKED -> JOB_STATUS_BLOCKED_DEVQ
Michael Adam [Thu, 26 Feb 2009 13:34:38 +0000 (14:34 +0100)]
s3: fix the build JOB_STATUS_BLOCKED -> JOB_STATUS_BLOCKED_DEVQ

Günther, please check...

Michael

11 years agotevent: add tevent_queue infrastructure
Stefan Metzmacher [Tue, 17 Feb 2009 10:42:01 +0000 (11:42 +0100)]
tevent: add tevent_queue infrastructure

metze

11 years agos3:registry: tighten the subkey loop in reg_deletekey_recursive()
Michael Adam [Thu, 26 Feb 2009 01:59:07 +0000 (02:59 +0100)]
s3:registry: tighten the subkey loop in reg_deletekey_recursive()

and loop from the end to the beginning so that we don't need
to rehash the subkeys...

This gets "net conf drop" with 2000 shares down to 14 seconds
on my box.

Michael

11 years agos3:registry: use delete_reg_subkey() in reg_deletekey()
Michael Adam [Thu, 26 Feb 2009 01:57:59 +0000 (02:57 +0100)]
s3:registry: use delete_reg_subkey() in reg_deletekey()

This further speeds up net conf drop.

Michael

11 years agos3:registry: implement delete_subkey in the smbconf backend
Michael Adam [Thu, 26 Feb 2009 01:56:50 +0000 (02:56 +0100)]
s3:registry: implement delete_subkey in the smbconf backend

delegating the call to the db backend

Michael

11 years agos3:registry: implement delete_subkey in the db backend
Michael Adam [Thu, 26 Feb 2009 01:56:00 +0000 (02:56 +0100)]
s3:registry: implement delete_subkey in the db backend

Michael

11 years agos3:registry: add a delete_subkey method to the backend ops.
Michael Adam [Thu, 26 Feb 2009 01:54:50 +0000 (02:54 +0100)]
s3:registry: add a delete_subkey method to the backend ops.

This is to provide a more atomic means of deleting a subkey of a key.

Michael

11 years agos3:registry: refactor deletion of various subkey lists out of regdb_store_keys()
Michael Adam [Thu, 26 Feb 2009 00:43:58 +0000 (01:43 +0100)]
s3:registry: refactor deletion of various subkey lists out of regdb_store_keys()

Micheal

11 years agos3:registry: streamline and cleanup regdb_set_secdesc() somewhat.
Michael Adam [Thu, 26 Feb 2009 00:22:03 +0000 (01:22 +0100)]
s3:registry: streamline and cleanup regdb_set_secdesc() somewhat.

Michael

11 years agos3:registry: refactor deletion of value/secdesc/subkey list tdb records out
Michael Adam [Thu, 26 Feb 2009 00:16:07 +0000 (01:16 +0100)]
s3:registry: refactor deletion of value/secdesc/subkey list tdb records out

of regdb_store_values().

Michael

11 years agos3:registry: streamline reg_deletekey() somewhat.
Michael Adam [Wed, 25 Feb 2009 22:13:07 +0000 (23:13 +0100)]
s3:registry: streamline reg_deletekey() somewhat.

use W_ERROR_... macros and separate assignments from checks

Michael

11 years agos3:registry: use create_reg_subkey() in reg_createkey().
Michael Adam [Wed, 25 Feb 2009 21:06:47 +0000 (22:06 +0100)]
s3:registry: use create_reg_subkey() in reg_createkey().

Instead of calling store_reg_keys()

On my box, importing 2000 shares into an empty smbconf key
now takes some 32 seconds.

Michael

11 years agos3:registry: implement create_subkey for the smbconf backend
Michael Adam [Wed, 25 Feb 2009 21:04:58 +0000 (22:04 +0100)]
s3:registry: implement create_subkey for the smbconf backend

by delegating to the db backend

Michael

11 years agos3:registry: implement create_subkey for the db backend.
Michael Adam [Wed, 25 Feb 2009 21:04:07 +0000 (22:04 +0100)]
s3:registry: implement create_subkey for the db backend.

Michael

11 years agos3:registry: add a create_subkey method to the backend ops.
Michael Adam [Wed, 25 Feb 2009 20:59:54 +0000 (21:59 +0100)]
s3:registry: add a create_subkey method to the backend ops.

This is to provide a more atomic means of adding a subkey of a key.

Michael

11 years agolibcli/util/werror.h: add macro W_ERROR_NOT_OK_GOTO(x, y)
Michael Adam [Wed, 25 Feb 2009 15:55:28 +0000 (16:55 +0100)]
libcli/util/werror.h: add macro W_ERROR_NOT_OK_GOTO(x, y)

a goto destination can be specified as a second parameter.

Michael

11 years agos3: move definition of W_ERROR_NOT_OK_GOTO_DONE down to libcli/util/werror.h
Michael Adam [Wed, 25 Feb 2009 15:53:05 +0000 (16:53 +0100)]
s3: move definition of W_ERROR_NOT_OK_GOTO_DONE down to libcli/util/werror.h

Michael