Andreas Schneider [Wed, 28 Apr 2010 09:26:08 +0000 (11:26 +0200)]
s3-spoolss: Fixed memory error in winreg_get_driver.
The strings in the structure need to be initialized with an empty
string.
Signed-off-by: Günther Deschner <gd@samba.org>
Andreas Schneider [Tue, 4 May 2010 09:37:42 +0000 (11:37 +0200)]
s3-spoolss: Added a sharename arg to winreg_update_printer.
Signed-off-by: Günther Deschner <gd@samba.org>
Andreas Schneider [Mon, 26 Apr 2010 11:36:19 +0000 (13:36 +0200)]
s3-spoolss: Added missing servername option to winreg_{create,get}_printer.
This is needed to be able to pass the correct servername from
Printer_entry.
Signed-off-by: Günther Deschner <gd@samba.org>
Andreas Schneider [Fri, 23 Apr 2010 19:37:13 +0000 (21:37 +0200)]
s3-spoolss: Added missing Printer Driver in winreg_{update,get}_printer.
Signed-off-by: Günther Deschner <gd@samba.org>
Günther Deschner [Wed, 5 May 2010 15:17:12 +0000 (17:17 +0200)]
s3-net: fix crash in rap_share_add().
Guenther
Günther Deschner [Wed, 5 May 2010 14:58:46 +0000 (16:58 +0200)]
s4-smbtorture: remove unused variable from smbcli_rap_netprintdestgetinfo().
Guenther
Günther Deschner [Wed, 5 May 2010 14:56:52 +0000 (16:56 +0200)]
rap: add IDL for rap_NetShareAdd (undocumented in MS-RAP).
Guenther
Andrew Tridgell [Wed, 5 May 2010 14:12:59 +0000 (16:12 +0200)]
s3-build: don't rebuild/link on every make run
Andrew Tridgell [Wed, 5 May 2010 13:16:26 +0000 (15:16 +0200)]
build: added configure test for inline
Andrew Tridgell [Wed, 5 May 2010 12:12:26 +0000 (14:12 +0200)]
build: update version of waf
this fixes a slow configure problem on HPUX
Andrew Tridgell [Wed, 5 May 2010 12:11:56 +0000 (14:11 +0200)]
build: use the wrapper commands in testwaf.sh
this ensures they are well tested
Andrew Tridgell [Wed, 5 May 2010 12:09:37 +0000 (14:09 +0200)]
build: added a distcheck target
Andrew Tridgell [Wed, 5 May 2010 12:09:26 +0000 (14:09 +0200)]
build: mark cloned task generators as not posted
this solves an incompatibility with a newer version of waf from svn
Andrew Tridgell [Wed, 5 May 2010 10:41:07 +0000 (12:41 +0200)]
build: exit with an error if waf configure fails
We don't want configure in the build farm to show green when it fails
Andreas Schneider [Wed, 5 May 2010 13:33:09 +0000 (15:33 +0200)]
libwbclient: Fixed doxygen errors.
Jeremy Allison [Wed, 5 May 2010 13:09:03 +0000 (06:09 -0700)]
Fixed issue with return in a void function found by Björn JACKE <bj@SerNet.DE>
Jeremy.
Andrew Tridgell [Wed, 5 May 2010 09:41:09 +0000 (11:41 +0200)]
s4-ldb: add msg saying which build system is being used
(this is a gratuituous commit to trigger the build farm to rebuild
ldb on all systems)
Andreas Schneider [Tue, 4 May 2010 21:07:03 +0000 (23:07 +0200)]
tevent: Started a tevent_queue tutorial.
Andreas Schneider [Tue, 4 May 2010 15:18:22 +0000 (17:18 +0200)]
tevent: Document the tevent_queue functions.
Andreas Schneider [Tue, 4 May 2010 14:57:42 +0000 (16:57 +0200)]
tevent: Document the tevent helper functions.
Andreas Schneider [Mon, 3 May 2010 19:04:54 +0000 (21:04 +0200)]
tevent: Document missing callback typedefs.
Andreas Schneider [Mon, 3 May 2010 18:29:54 +0000 (20:29 +0200)]
tevent: Document the missing tevent async request callback functions.
Andreas Schneider [Mon, 8 Feb 2010 20:10:55 +0000 (21:10 +0100)]
tevent: Create a typedef for the debug function callback.
Stephen Gallagher [Fri, 15 Jan 2010 15:38:24 +0000 (10:38 -0500)]
tevent: Added more documentation.
Stephen Gallagher [Fri, 15 Jan 2010 15:33:14 +0000 (10:33 -0500)]
tevent: Remove erroneous comments about TEVENT_FD_AUTOCLOSE
There is no such flag.
Andreas Schneider [Thu, 14 Jan 2010 14:42:26 +0000 (15:42 +0100)]
tevent: Add doxygen tevent config file.
Andreas Schneider [Thu, 14 Jan 2010 13:41:49 +0000 (14:41 +0100)]
tevent: Added basic doxygen documentation.
Andreas Schneider [Tue, 4 May 2010 21:18:26 +0000 (23:18 +0200)]
s3-libsmb: Fixed a recursion in cli_pull_print.
Andreas Schneider [Tue, 4 May 2010 20:38:23 +0000 (22:38 +0200)]
tsocket: Added the warning again to tsocket_address_bsd_sockaddr.
Rusty Russell [Wed, 5 May 2010 06:07:18 +0000 (15:37 +0930)]
tdb: fix short write logic in tdb_new_database
Commit
207a213c/
24fed55d purported to fix the problem of signals during
tdb_new_database (which could cause a spurious short write, hence a failure).
However, the code is wrong: newdb+written is not correct.
Fix this by introducing a general tdb_write_all() and using it here and in
the tracing code.
Cc: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Luca Olivetti [Tue, 4 May 2010 22:07:57 +0000 (15:07 -0700)]
Fix bug #7263 - Unable to print using Samba 3.5.1 and cups-1.1.23-40.46 on SLES10.
Fix cups encryption setting
I had the same problem and it's due to the fact that samba doesn't respect the
"cups encryption" setting since lp_cups_encrypt changes the value: if you set
"cups encryption=no", the first call will change it to HTTP_ENCRYPT_NEVER,
since that is 1 (i.e. true), the next call will change it to
HTTP_ENCRYPT_ALWAYS and after that it'll remain set as HTTP_ENCRYPT_ALWAYS.
This patch fixes this problem.
Don't mix up the HTTP_ENCRYPT_XXX constants up with the
enumeration constants (True, False, Auto) used in the
loadparm code.
Simo Sorce [Tue, 27 Apr 2010 15:15:17 +0000 (11:15 -0400)]
s3-spoolss: Remove duplicate macro.
Signed-off-by: Günther Deschner <gd@samba.org>
Andreas Schneider [Tue, 4 May 2010 08:21:52 +0000 (10:21 +0200)]
s4-torture: Added the printername to the AddPrinter comment.
Signed-off-by: Günther Deschner <gd@samba.org>
Andreas Schneider [Fri, 30 Apr 2010 12:38:07 +0000 (14:38 +0200)]
s4-torture: Fixed spoolss dsspooler printername test.
Signed-off-by: Günther Deschner <gd@samba.org>
Andreas Schneider [Mon, 26 Apr 2010 15:38:56 +0000 (17:38 +0200)]
s3-lib: Create a sec_desc_merge and sec_desc_merge_buf function.
Signed-off-by: Günther Deschner <gd@samba.org>
Anatoliy Atanasov [Tue, 4 May 2010 09:49:52 +0000 (11:49 +0200)]
s4/waf: ABI update for lib/ldb
Anatoliy Atanasov [Tue, 4 May 2010 09:49:18 +0000 (11:49 +0200)]
s4/rodc: Support read-only database
Check on modify if we are RODC and return referral.
On the ldap backend side now we pass context and ldb_modify_default_callback
to propagate the referral error to the client.
Anatoliy Atanasov [Tue, 4 May 2010 09:48:18 +0000 (11:48 +0200)]
s4/rodc: Fix the callbacks up the stack to handle referrals on modify requests
Matthias Dieter Wallnöfer [Tue, 4 May 2010 15:21:30 +0000 (17:21 +0200)]
s4:py_nttime2string - removed unused variable "nt2"
And add some linespaces to look better.
Günther Deschner [Tue, 4 May 2010 15:18:22 +0000 (17:18 +0200)]
s4-smbtorture: fill in test_rap_print().
This tests pauses a printer over RAP, prints a file, enumerates the job, deletes
the job and resumes the print queue.
Guenther
Günther Deschner [Tue, 4 May 2010 14:31:34 +0000 (16:31 +0200)]
s3-libnetjoin: omit admin password in generated ndr_print function.
Guenther
Günther Deschner [Tue, 4 May 2010 13:39:21 +0000 (15:39 +0200)]
s4-smbtorture: add test_netprintdestgetinfo() to RAP-PRINTING.
Guenther
Günther Deschner [Tue, 4 May 2010 13:29:53 +0000 (15:29 +0200)]
s4-smbtorture: add smbcli_rap_netprintdestgetinfo().
Guenther
Günther Deschner [Tue, 4 May 2010 13:24:54 +0000 (15:24 +0200)]
s4-smbtorture: add test_netprintdestenum to RAP-PRINTING.
Guenther
Günther Deschner [Tue, 4 May 2010 13:23:53 +0000 (15:23 +0200)]
rap: add rap_NetPrintDestGetInfo to IDL.
Guenther
Günther Deschner [Tue, 4 May 2010 13:23:08 +0000 (15:23 +0200)]
s4-smbtorture: add smbcli_rap_netprintdestenum.
Guenther
Günther Deschner [Tue, 4 May 2010 13:22:36 +0000 (15:22 +0200)]
rap: add IDL for (undocumented) NetPrintDestEnum.
Guenther
Andrew Tridgell [Tue, 4 May 2010 05:48:54 +0000 (07:48 +0200)]
s3-idl: update the 2nd build_idl.sh script
Andrew Tridgell [Tue, 4 May 2010 05:34:32 +0000 (07:34 +0200)]
s3-idl: rebuild IDL files based on all outputs
Andrew Tridgell [Tue, 4 May 2010 04:59:08 +0000 (06:59 +0200)]
s3-idl: auto-build IDL files in Samba3
Andrew Tridgell [Mon, 3 May 2010 15:28:23 +0000 (17:28 +0200)]
s4-waf: we don't need the symlink hack for gen_ndr any more
we can now generate files into the build directory
Andrew Tridgell [Mon, 3 May 2010 15:25:56 +0000 (17:25 +0200)]
.gitignore: simplify the .gitignore after gen_ndr removal
Andrew Tridgell [Mon, 3 May 2010 15:22:18 +0000 (17:22 +0200)]
s3-idl: removed gen_ndr files from source3/ as well
Andrew Tridgell [Mon, 3 May 2010 15:17:43 +0000 (17:17 +0200)]
idl: removed the generated gen_ndr/ files from pidl
Samba3 will add these to the release tarball instead. See the mail on
samba-technical
Andrew Tridgell [Tue, 4 May 2010 09:58:28 +0000 (11:58 +0200)]
build: enable python 3.0 and 3.1 in testwaf.sh
try to ensure that we don't let support for python 3.x bitrot
Andrew Tridgell [Tue, 4 May 2010 09:57:50 +0000 (11:57 +0200)]
build: fixed wildcard handling for python 3.x
print must take parentheses
Andrew Tridgell [Tue, 4 May 2010 09:57:13 +0000 (11:57 +0200)]
s4-waf: fixed indentation for python 3.1
python 3.x is very fussy about tabs/spaces
Volker Lendecke [Tue, 4 May 2010 11:54:51 +0000 (13:54 +0200)]
s3: Fix a memleak in check_pac_checksum
Andrew Tridgell [Tue, 4 May 2010 08:30:39 +0000 (10:30 +0200)]
s4-script: added a --waf option to minimal_includes.pl
This takes advantage of the new waf target syntax
Andrew Tridgell [Tue, 4 May 2010 08:08:43 +0000 (10:08 +0200)]
build: allow use of target names as commands in waf
This allows for the following types of commands:
waf smbd/samba
waf smbd/server.c
waf ../lib/util/util_file.c
waf ../lib/util/util_file_*.o
this will be used as part of an updated minimal_includes.pl script
Günther Deschner [Mon, 3 May 2010 18:23:45 +0000 (20:23 +0200)]
s4-smbtorture: add extraformat to smbcli_rap_netprintqgetinfo() as well.
Guenther
Günther Deschner [Mon, 3 May 2010 18:02:37 +0000 (20:02 +0200)]
s4-smbtorture: use RAP extraformat for smbcli_rap_netprintqenum().
Although w2k3 happily ignores it, the spec (and s3) enforce the addition of
that.
Guenther
Günther Deschner [Thu, 29 Apr 2010 18:04:12 +0000 (20:04 +0200)]
s4-smbtorture: add rap_cli_expect_extra_format().
Guenther
Günther Deschner [Mon, 3 May 2010 18:53:02 +0000 (20:53 +0200)]
s4-smbtorture: make all smbcli_rap_* failures critical.
Guenther
Anatoliy Atanasov [Mon, 3 May 2010 16:12:45 +0000 (18:12 +0200)]
s4/test: Implement tests for msDS-isRODC constructed attribute
This attribute will be returned for objects with
objectClass=nTDSDSA,server and computer
Anatoliy Atanasov [Wed, 28 Apr 2010 14:02:55 +0000 (17:02 +0300)]
s4/rodc: Implement msDS-isRODC constructed attr
Matthias Dieter Wallnöfer [Mon, 3 May 2010 15:15:25 +0000 (17:15 +0200)]
s4:LogonGetDomainInfo - fix a potential crash source
Matthias Dieter Wallnöfer [Mon, 3 May 2010 14:59:53 +0000 (16:59 +0200)]
s4:LogonGetDomainInfo - fix indentation
Matthias Dieter Wallnöfer [Mon, 3 May 2010 14:47:03 +0000 (16:47 +0200)]
s4:LogonGetDomainInfo - remove singular "dNSHostName" check - this doesn't belong here
I'm not really sure if this check is really done on Windows Server. And if it
is done, then it's on the LDB level (module).
Andrew Tridgell [Mon, 3 May 2010 14:37:33 +0000 (16:37 +0200)]
build: use the waf patterns for RPATH
Use the self.env.RPATH variable to set the RPATH for each target. This
gives consistent ordering of the link command, ensuring that we don't
get rebuilds if we ask for a --targets= build after a normal build.
This also means we are now using the RPATH_ST pattern, which means we
can potentially support compilers that don't use -Wl,xxx as the
command line for rpath support
Andrew Tridgell [Mon, 3 May 2010 14:05:19 +0000 (16:05 +0200)]
s4-waf: fixed target group for SOCKET_WRAPPER
Andrew Tridgell [Mon, 3 May 2010 14:04:56 +0000 (16:04 +0200)]
build: added a check for group ordering within target dependencies
If target A depends on target B, then target B must not be in a later
build group from target A
Pair-Programmed-With: Thomas Nagy
Andrew Tridgell [Mon, 3 May 2010 13:12:29 +0000 (15:12 +0200)]
build: fix for combined configure/build in one command
This is a fix from ita for "waf distclean configure build". Running
it as one command failed with missing config.h
Günther Deschner [Mon, 3 May 2010 15:02:21 +0000 (17:02 +0200)]
s3-lanman: before trying to call spoolss_ClosePrinter make sure we have a connection.
Guenther
Nadezhda Ivanova [Mon, 3 May 2010 14:47:56 +0000 (16:47 +0200)]
Replaced DS_FLAG_ATTR_IS_CRITICAL with SCHEMA_FLAG_ATTR_IS_CRITICAL.
Günther Deschner [Mon, 3 May 2010 13:54:14 +0000 (15:54 +0200)]
s3-rpcclient: Fix Bug #7277. rpcclient was sending invalid data, causing cupsaddsmb to fail.
Guenther
Andreas Schneider [Mon, 3 May 2010 09:25:26 +0000 (11:25 +0200)]
tsocket: Fixed the documentation of tsocket_address_bsd_sockaddr.
Nadezhda Ivanova [Mon, 3 May 2010 13:38:46 +0000 (15:38 +0200)]
Added a couple of systemFlags, needed for determining filtered attributes.
Nadezhda Ivanova [Mon, 3 May 2010 12:50:10 +0000 (14:50 +0200)]
Added a function to check if an attribute can belong to a filtered replica.
Günther Deschner [Mon, 3 May 2010 11:42:32 +0000 (13:42 +0200)]
s3-lanman: fix api_DosPrintQEnum().
This was a subtile bug where the OpenPrinter call (called directly via
dispatcher table) was modifiying r->in.printername in a way that all printers on
a server had the printername stripped off the server unc. Once we switch to full
NDR marshalling in inter RAP<->RPC server communication there is no danger
anymore to have these kind of nasty effects.
Guenther
Günther Deschner [Mon, 3 May 2010 10:51:26 +0000 (12:51 +0200)]
s3: re-run make samba3-idl.
Guenther
Günther Deschner [Mon, 3 May 2010 10:48:55 +0000 (12:48 +0200)]
pidl: indent cosmetics for s3 server stubs.
Guenther
Günther Deschner [Mon, 3 May 2010 09:57:06 +0000 (11:57 +0200)]
s4-smbtorture: add test_netprintjobsetinfo to RAP-PRINTING.
Guenther
Günther Deschner [Mon, 3 May 2010 09:46:57 +0000 (11:46 +0200)]
s4-smbtorture: add smbcli_rap_netprintjobsetinfo().
Guenther
Günther Deschner [Mon, 3 May 2010 09:45:52 +0000 (11:45 +0200)]
s4-smbtorture: add rap_cli_push_param() and rap_cli_push_sendbuf().
Guenther
Günther Deschner [Mon, 3 May 2010 09:58:06 +0000 (11:58 +0200)]
s3-lanman: exit early for unsupported levels in api_PrintJobInfo().
Guenther
Günther Deschner [Fri, 30 Apr 2010 15:37:34 +0000 (17:37 +0200)]
s3: re-run make samba3-idl.
Guenther
Günther Deschner [Fri, 30 Apr 2010 15:37:16 +0000 (17:37 +0200)]
rap: add rap_NetPrintJobSetInfo to IDL.
Guenther
Andrew Tridgell [Mon, 3 May 2010 08:22:22 +0000 (10:22 +0200)]
s4-waf: fixed symlink path for autogen.sh
thanks to Nadya for noticing :-)
Andrew Tridgell [Mon, 3 May 2010 07:12:43 +0000 (09:12 +0200)]
s4-waf: switch Samba4 over to the waf build by default
the old autogen.sh is now calld autogen-autotools.sh
For now autogen.sh is a link to autogen-waf.sh. We can remove
autogen-waf.sh in the future, but for now I'm leaving it in place so
as not to break existing scripts (both build farm, and the scripts for
the standalone libs)
Matthew McGillis [Mon, 3 May 2010 01:08:29 +0000 (18:08 -0700)]
Consolidate all get SEC_DESC into single procedure get_secdesc
Matthew McGillis [Mon, 3 May 2010 01:08:02 +0000 (18:08 -0700)]
always pass filename as const char
Andrew Tridgell [Sun, 2 May 2010 14:12:14 +0000 (16:12 +0200)]
build: uname on opensolaris returns 1 for success
check for -1 as failure, not 0 for success
Andrew Tridgell [Sun, 2 May 2010 13:53:14 +0000 (15:53 +0200)]
s4-ldb: use a parent context in the ldb utils
This avoids a talloc free with references error on exit
Matthieu Patou [Mon, 12 Apr 2010 20:58:50 +0000 (00:58 +0400)]
s4: Fix python binding for drsblobs
This binding needs symbols in drsblobs_c.c otherwise we have unresolved symbols
Matthieu Patou [Wed, 14 Apr 2010 20:18:14 +0000 (00:18 +0400)]
s4 python: fix glues functions manipulating NTTIME
The fix include reverse function (from NTTIME to timestamp) + fix
on the transformation of a NTTIME to a PyLong object
Matthieu Patou [Wed, 14 Apr 2010 20:18:46 +0000 (00:18 +0400)]
pidl: Fix the generation of py helper for 64 bit integer
Up to now the generation of code for python helpers dealing with 64 bits (NTTIME,hyper, ...)
was broken because they were assumed to be Int (PyInt_From ...) as Integer is always 32 bits
in python.
This fix use PyLong and states that the incomming data is a long long as it should be 64 bit at least.
Signed-off-by: Jelmer Vernooij <jelmer@samba.org>
Volker Lendecke [Sat, 1 May 2010 12:51:15 +0000 (14:51 +0200)]
s3: Unify DEBUG_KRB5_TKT_REGAIN and DEBUG_KRB5_TKT_RENEWAL
I don't think it makes sense to #ifdef this one case separately.
Metze, Bo Yang, please check!
Volker Lendecke [Sat, 1 May 2010 12:39:01 +0000 (14:39 +0200)]
s3: Fix a typo
Volker Lendecke [Sun, 25 Apr 2010 13:36:02 +0000 (15:36 +0200)]
s3: Fix the code order in append_auth_data
This is to comply with the comment
"currently, anything from here on potentially overwrites extra_data."
Günther, please check!