Volker Lendecke [Wed, 8 Apr 2009 06:29:23 +0000 (08:29 +0200)]
We have to deny a level 2 oplock if kernel oplocks are enabled
The second r/o opener of a file is supposed to get a level2 oplock. The first
opener due to the protection in process_oplock_break_message() has been forced
to break to no oplock. The second opener according to locking.tdb gets a level2
oplock. Further down in open_file_ntcreate we try to set this level2 oplock in
the kernel, and the non-clustered Linux kernel disallows this. The rules for
the kernel leases are a bit baroque, but the attempt to do the SETLEASE
correctly fails and we end up with no oplock for any client.
In the clustered case however the linux kernel on the second opening node has
not seen the open fd of the first node, it is only the cluster fs that has this
information. If the cluster fs does not have the very same notion of leases as
the local kernel has, we can end up with a WRLCK style kernel lease for the
second opener where locking.tdb only indicates a level2 oplock. Getting a
kernel oplock break signal with just a level2 oplock in locking.tdb is
something smbd is not prepared for. For example after sending out the break in
response to the kernel signal we set a timeout, waiting for a reply.
More work needs to be done to make level2 kernel oplocks real for us. This
patch addresses a real problem we have right now without them.
Volker Lendecke [Sun, 12 Apr 2009 10:52:42 +0000 (12:52 +0200)]
Fix a bug in smbclient not sending the correct called name
Jeremy, I think the ability to say
smbclient //foo/bar -I <ip-address> -p 139
making the called name to "foo" got lost with
3d2d0203. Was this removed
deliberately? If so, please revert this patch. If not, please merge
appropriately.
Thanks,
Volker
Volker Lendecke [Sun, 12 Apr 2009 12:31:53 +0000 (14:31 +0200)]
Add "netbios retarget"
This is fun -- XP still does this :-)
netbios retarget : foo = 192.168.234.10:1139
and if you connect to port 139 name foo, XP will happily do SMB over 1139
Volker Lendecke [Sun, 12 Apr 2009 12:25:02 +0000 (14:25 +0200)]
Reactivate get_socket_port
Volker Lendecke [Sun, 12 Apr 2009 12:05:58 +0000 (14:05 +0200)]
write_data already guarantees everything was written
Volker Lendecke [Sun, 12 Apr 2009 09:59:18 +0000 (11:59 +0200)]
Extract and print the server name type the client connects to
Volker Lendecke [Thu, 9 Apr 2009 13:51:35 +0000 (15:51 +0200)]
Fix some nonempty blank lines
Volker Lendecke [Thu, 9 Apr 2009 09:40:08 +0000 (11:40 +0200)]
Fix a memleak in an unlikely error path in change_notify_create()
Volker Lendecke [Thu, 9 Apr 2009 09:36:45 +0000 (11:36 +0200)]
Use talloc_tos() for a temp convert_string_allocate()
Jeremy Allison [Fri, 10 Apr 2009 21:45:45 +0000 (14:45 -0700)]
Link in the threads functions, not yet used.
Jeremy.
Stefan Metzmacher [Tue, 7 Apr 2009 12:37:05 +0000 (14:37 +0200)]
s4:rpc_server: split out the parsing of the ncacn_packet from analyzing of the content
metze
Stefan Metzmacher [Tue, 7 Apr 2009 19:02:55 +0000 (21:02 +0200)]
s4:rpc_server: report available output for all replies
metze
Stefan Metzmacher [Wed, 8 Apr 2009 17:08:34 +0000 (19:08 +0200)]
socket_wrapper: fix crash bug in swrap_readv/writev
metze
Günther Deschner [Fri, 10 Apr 2009 01:28:49 +0000 (03:28 +0200)]
s3-spoolss: implement dummy _spoolss_AddPort().
Guenther
Günther Deschner [Fri, 10 Apr 2009 01:28:17 +0000 (03:28 +0200)]
s3-spoolss: add support for level 8 in _spoolss_GetPrinter().
Guenther
Günther Deschner [Wed, 8 Apr 2009 16:32:06 +0000 (18:32 +0200)]
s3-eventlog: implement _eventlog_FlushEventLog().
Guenther
Günther Deschner [Wed, 8 Apr 2009 16:31:32 +0000 (18:31 +0200)]
s3-eventlog: implement _eventlog_GetLogInformation().
Guenther
Günther Deschner [Wed, 8 Apr 2009 18:34:24 +0000 (20:34 +0200)]
s3: re-run make samba3-idl.
Guenther
Günther Deschner [Wed, 8 Apr 2009 18:33:58 +0000 (20:33 +0200)]
eventlog: make EVENTLOG_FULL_INFORMATION a public struct.
Guenther
Jeremy Allison [Fri, 10 Apr 2009 05:46:59 +0000 (22:46 -0700)]
Merge branch 'master' of ssh://jra@git.samba.org/data/git/samba
Jeremy Allison [Fri, 10 Apr 2009 05:44:56 +0000 (22:44 -0700)]
Fix bug #6254 - PUT/GET produces an error in IPv6 to a smb-server(3.3) has parameter "msdfs root = yes"
This was broken by the refactoring around create_file().
MSDFS pathname processing must be done FIRST.
MSDFS pathnames containing IPv6 addresses can
be confused with NTFS stream names (they contain
":" characters.
Jeremy.
Günther Deschner [Thu, 9 Apr 2009 22:44:36 +0000 (00:44 +0200)]
s3-selftest: enable the RPC-NTSVCS torture test against Samba3.
Guenther
Günther Deschner [Thu, 9 Apr 2009 22:43:55 +0000 (00:43 +0200)]
s3-ntsvcs: fix _PNP_GetDeviceList and _PNP_GetDeviceListSize.
Guenther
Günther Deschner [Thu, 9 Apr 2009 22:42:35 +0000 (00:42 +0200)]
s4-smbtorture: perform the ntsvcs devicelist tests against the Spooler service.
Guenther
Günther Deschner [Thu, 9 Apr 2009 22:00:44 +0000 (00:00 +0200)]
s3-rpcclient: allow to set flags in cmd_ntsvcs_get_dev_list().
Guenther
Günther Deschner [Thu, 9 Apr 2009 21:44:24 +0000 (23:44 +0200)]
error-codes: add WERR_CM_INVALID_POINTER.
Guenther
Günther Deschner [Thu, 9 Apr 2009 22:01:41 +0000 (00:01 +0200)]
s3: re-run make samba3-idl.
Guenther
Günther Deschner [Thu, 9 Apr 2009 15:53:36 +0000 (17:53 +0200)]
ntsvcs: add PNP_GetIdListFlags flags.
Guenther
Günther Deschner [Thu, 9 Apr 2009 13:39:45 +0000 (15:39 +0200)]
s3-svcctl: minor fix for _svcctl_EnumDependentServicesW().
Guenther
Günther Deschner [Thu, 9 Apr 2009 13:30:18 +0000 (15:30 +0200)]
s4-smbtorture: add test_EnumDependentServicesW() to RPC-SVCCTL.
Guenther
Günther Deschner [Thu, 9 Apr 2009 14:41:32 +0000 (16:41 +0200)]
s3: re-run make samba3-idl.
Guenther
Günther Deschner [Thu, 9 Apr 2009 14:40:13 +0000 (16:40 +0200)]
svcctl: use svcctl_ServiceState type for dependent calls in IDL.
Guenther
Günther Deschner [Thu, 9 Apr 2009 13:08:29 +0000 (15:08 +0200)]
s3-svcctl: Fix invalid buffer memset in _svcctl_QueryServiceObjectSecurity().
Found by torture-test.
Guenther
Günther Deschner [Thu, 9 Apr 2009 08:26:17 +0000 (10:26 +0200)]
s4-smbtorture: add test_QueryServiceObjectSecurity() to RPC-SVCCTL test.
Guenther
Günther Deschner [Thu, 9 Apr 2009 11:27:08 +0000 (13:27 +0200)]
s3-svcctl: Fix _svcctl_Set/GetServiceObjectSecurity after IDL changes.
Guenther
Günther Deschner [Thu, 9 Apr 2009 11:25:21 +0000 (13:25 +0200)]
s3: re-run make samba3-idl.
Guenther
Günther Deschner [Thu, 9 Apr 2009 08:19:03 +0000 (10:19 +0200)]
svcctl: Fix IDL for svcctl_QueryServiceObjectSecurity and Set call.
Guenther
Günther Deschner [Thu, 9 Apr 2009 08:07:07 +0000 (10:07 +0200)]
s4-smbtorture: add test_QueryServiceConfigW() to RPC-SVCCTL.
Guenther
Günther Deschner [Thu, 9 Apr 2009 08:01:02 +0000 (10:01 +0200)]
s4-smbtorture: add test_QueryServiceStatus() to RPC-SVCCTL.
Guenther
Andrew Tridgell [Thu, 9 Apr 2009 04:40:19 +0000 (14:40 +1000)]
Merge branch 'wspp-schema'
Andrew Tridgell [Thu, 9 Apr 2009 04:37:52 +0000 (14:37 +1000)]
enable testing of possibleInferiors generation
Andrew Tridgell [Thu, 9 Apr 2009 04:29:36 +0000 (14:29 +1000)]
make the memory usage of possibleInferiors much more efficient
Andrew Tridgell [Thu, 9 Apr 2009 04:28:38 +0000 (14:28 +1000)]
added _const versions of some of the str_list_*() functions
These const versions don't copy the strings themselves, which
is useful when those strings point at known constant data (into the
schema in this case)
Andrew Tridgell [Thu, 9 Apr 2009 03:46:35 +0000 (13:46 +1000)]
we should not be supplying a generated attribute in our schema
Andrew Tridgell [Thu, 9 Apr 2009 03:46:18 +0000 (13:46 +1000)]
fixed the possibleInferiors calculation so it now passes the test
We are probably still using more memory here than we need to. That
needs to be looked at.
Andrew Tridgell [Thu, 9 Apr 2009 03:45:23 +0000 (13:45 +1000)]
slightly nicer output in our possibleInferiors test code
Andrew Tridgell [Thu, 9 Apr 2009 03:45:04 +0000 (13:45 +1000)]
hook the new possibleInferiors calculation into the schema
We now generate possibleInferiors at startup, and return it when
requested
Andrew Tridgell [Thu, 9 Apr 2009 03:44:27 +0000 (13:44 +1000)]
added str_list_unique() and str_list_show()
I also undid some of the const changes from Andrew, as
they didn't in fact resolve the const warnings.
Jeremy Allison [Wed, 8 Apr 2009 22:46:49 +0000 (15:46 -0700)]
Add the thread functions to top level lib/util.
Not yet used, that's the next step.
Jeremy.
Günther Deschner [Wed, 8 Apr 2009 21:21:41 +0000 (23:21 +0200)]
s3-svcctl: Fix _svcctl_EnumServicesStatusW (again).
The final plan is to use the same macro based code that we have in spoolss to
handle the buffers and calculate the buffer-sizes.
Guenther
Volker Lendecke [Wed, 8 Apr 2009 21:03:59 +0000 (23:03 +0200)]
Remove async_req
Volker Lendecke [Wed, 8 Apr 2009 20:54:28 +0000 (22:54 +0200)]
Convert cli_push to tevent_req
Metze, please check!
Thanks,
Volker
Volker Lendecke [Wed, 8 Apr 2009 20:39:55 +0000 (22:39 +0200)]
Convert cli_pull to tevent_req
Günther Deschner [Wed, 8 Apr 2009 19:45:04 +0000 (21:45 +0200)]
s3-net: Fix Bug #5329: add "net rpc service delete/create".
Patch from Danny Tylman <danny.tylman@insightix.com>.
Guenther
Volker Lendecke [Wed, 8 Apr 2009 19:58:41 +0000 (21:58 +0200)]
Convert rpc_transport_smbd_init to tevent_req
Volker Lendecke [Wed, 8 Apr 2009 19:53:16 +0000 (21:53 +0200)]
Convert rpc_cli_smbd_conn_init to tevent_req
Volker Lendecke [Wed, 8 Apr 2009 19:42:01 +0000 (21:42 +0200)]
Convert get_anon_ipc to tevent_req
Volker Lendecke [Wed, 8 Apr 2009 19:33:01 +0000 (21:33 +0200)]
Convert rpc_transport_np_init to tevent_req
Günther Deschner [Wed, 8 Apr 2009 19:43:57 +0000 (21:43 +0200)]
error-codes: add some service related error codes.
Patch initially from: Danny Tylman <danny.tylman@insightix.com>
Guenther
Günther Deschner [Wed, 8 Apr 2009 17:18:49 +0000 (19:18 +0200)]
s4-smbtorture: fix test_ReportEventLog in RPC-EVENTLOG.
Guenther
Günther Deschner [Wed, 8 Apr 2009 15:15:15 +0000 (17:15 +0200)]
s3-eventlog: split out evlog_convert_tdb_to_evt().
Guenther
Günther Deschner [Wed, 8 Apr 2009 12:29:04 +0000 (14:29 +0200)]
s3-eventlog: move rpc_server/srv_eventlog_lib.c out of rpc_server.
Guenther
Karolin Seeger [Wed, 8 Apr 2009 15:49:21 +0000 (17:49 +0200)]
s3/packaging: Add idmap_hash and idmap_adex to the list of built modules.
Karolin
Andrew Bartlett [Wed, 8 Apr 2009 13:18:49 +0000 (23:18 +1000)]
Make the schema_inferiors generation code to compile
Sadly it still segfaults at this stage
Andrew Bartlett
Andrew Bartlett [Wed, 8 Apr 2009 13:18:13 +0000 (23:18 +1000)]
Rework util_strlist prototypes to use a bit more and less const
Hopefully this produces less warnings, but it might produce more...
Andrew Bartlett
Günther Deschner [Wed, 8 Apr 2009 12:37:40 +0000 (14:37 +0200)]
s3-rpc-server: remove unused rpc_server/srv_util.c file.
Guenther
Günther Deschner [Thu, 19 Mar 2009 22:38:00 +0000 (23:38 +0100)]
s3-selftest: As Samba3 now passes RPC-SPOOLSS-WIN enable it against ourself.
Guenther
Günther Deschner [Wed, 8 Apr 2009 11:49:14 +0000 (13:49 +0200)]
s4-smbtorture: Small fix for RPC-SPOOLSS-WIN to deal with driver-less printers.
The getdriver query failure should only be critical when there is actually a
driver associated to a printer.
Guenther
Günther Deschner [Wed, 8 Apr 2009 11:11:16 +0000 (13:11 +0200)]
s3-selftest: add root for make test as well (not only make selftest).
Guenther
Günther Deschner [Wed, 8 Apr 2009 10:47:10 +0000 (12:47 +0200)]
s3-util-sock: add ismyaddr() check in is_myname_or_ipaddr().
Guenther
Günther Deschner [Wed, 8 Apr 2009 01:00:16 +0000 (03:00 +0200)]
s3-selftest: Samba3 passes RPC-SVCCTL so enable it during make test.
Guenther
Günther Deschner [Wed, 8 Apr 2009 08:15:01 +0000 (10:15 +0200)]
selftest: add a fake root user to nss_wrapper_passwd in s3.
Needed to make some server calls to get_root_nt_token() succeed.
make selftest/make test gurus, please check.
Guenther
Günther Deschner [Wed, 8 Apr 2009 00:11:27 +0000 (02:11 +0200)]
svcctl: use offered/needed for buffer sizes as in spoolss.
Guenther
Günther Deschner [Tue, 7 Apr 2009 23:52:28 +0000 (01:52 +0200)]
s3-svcctl: no need to define SVCCTL_NUM_INTERNAL_SERVICES twice in a file.
Guenther
Andrew Bartlett [Wed, 18 Mar 2009 07:05:17 +0000 (18:05 +1100)]
s3:lib Use push_ucs2_talloc() in ms_fnmatch()
Signed-off-by: Günther Deschner <gd@samba.org>
Günther Deschner [Thu, 2 Apr 2009 14:15:16 +0000 (16:15 +0200)]
s3-spoolss: set servername to global_myname() in set_printer_hnd_name().
This allows spoolss_OpenPrinterEx to open a printer by printername.
Now the Samba3 spoolss server passes the RPC-SPOOLSS-WIN test.
Guenther
Andrew Bartlett [Thu, 19 Mar 2009 08:20:08 +0000 (19:20 +1100)]
s3:charcnv Remove unused unistrcpy() and unistrlen()
Signed-off-by: Günther Deschner <gd@samba.org>
Andrew Bartlett [Thu, 19 Mar 2009 08:18:14 +0000 (19:18 +1100)]
s3:rpc_parse remove unused prs_unistr2()
Signed-off-by: Günther Deschner <gd@samba.org>
Andrew Bartlett [Thu, 19 Mar 2009 08:14:36 +0000 (19:14 +1100)]
s3:charcnv Remove unused unistr2 functions
Natrually, the hard work to make these unsued was done by GD, not me :-)
Andrew Bartlett
Signed-off-by: Günther Deschner <gd@samba.org>
Andrew Bartlett [Thu, 19 Mar 2009 08:11:15 +0000 (19:11 +1100)]
s3:charcnv Remove unused ucs2_to_unistr2()
Signed-off-by: Günther Deschner <gd@samba.org>
Karolin Seeger [Tue, 7 Apr 2009 18:45:45 +0000 (20:45 +0200)]
s3/docs: Raise version number up to 3.5.
Karolin
Karolin Seeger [Tue, 7 Apr 2009 18:01:27 +0000 (20:01 +0200)]
s3/popt.h: Fix typo.
Karolin
Karolin Seeger [Tue, 7 Apr 2009 18:00:47 +0000 (20:00 +0200)]
s3/loadparm: Fiy typos.
Karolin
Karolin Seeger [Tue, 7 Apr 2009 17:58:47 +0000 (19:58 +0200)]
s3/gpo_ldap: Fix typo.
Karolin
Karolin Seeger [Tue, 7 Apr 2009 17:58:14 +0000 (19:58 +0200)]
s3/smbconf_reg: Fix typo.
Karolin
Karolin Seeger [Tue, 7 Apr 2009 17:55:45 +0000 (19:55 +0200)]
s3/docs: Fix typo.
Karolin
Tim Prouty [Tue, 7 Apr 2009 00:56:50 +0000 (00:56 +0000)]
s3 onefs: Fix case-insensitivity for mangled names
onefs_get_real_filename needs to demangle the filename before doing
the case-insensitive estat
Tim Prouty [Tue, 7 Apr 2009 16:49:55 +0000 (09:49 -0700)]
s3 oplocks: Add back procid_str to debug message
Andrew Bartlett [Wed, 18 Mar 2009 07:04:35 +0000 (18:04 +1100)]
s3:smbldap convert the easy cases to push_utf8_talloc()
Signed-off-by: Günther Deschner <gd@samba.org>
Andrew Bartlett [Wed, 18 Mar 2009 05:23:27 +0000 (16:23 +1100)]
s3:kerberos Rework smb_krb5_unparse_name() to take a talloc context
Signed-off-by: Günther Deschner <gd@samba.org>
Andrew Bartlett [Wed, 18 Mar 2009 05:19:19 +0000 (16:19 +1100)]
s3:smbtorture Convert charcnv torture suite to use push_ucs2_talloc()
Signed-off-by: Günther Deschner <gd@samba.org>
Andrew Tridgell [Tue, 7 Apr 2009 06:34:36 +0000 (16:34 +1000)]
first cut at a C version of the possible inferiors code
Andrew Tridgell [Tue, 7 Apr 2009 06:34:18 +0000 (16:34 +1000)]
don't load @ATTRIBUTES if we have an override handler in place
Andrew Tridgell [Tue, 7 Apr 2009 06:33:54 +0000 (16:33 +1000)]
fixed internal handling of attribute deletion
Andrew Tridgell [Tue, 7 Apr 2009 06:33:26 +0000 (16:33 +1000)]
added a str_list_append() function
Günther Deschner [Mon, 6 Apr 2009 22:40:46 +0000 (00:40 +0200)]
s3-libads: avoid NULL talloc context with ads_get_dn().
Guenther
Günther Deschner [Mon, 6 Apr 2009 23:12:34 +0000 (01:12 +0200)]
s3: re-run make samba3-idl.
Guenther
Günther Deschner [Mon, 6 Apr 2009 23:11:44 +0000 (01:11 +0200)]
svcctl: Fix svcctl_ControlsAccepted bitmask.
Never ever have 0 value in a bitmask...
pidl should generate at least a warning about those things.
Guenther
Günther Deschner [Mon, 6 Apr 2009 23:10:41 +0000 (01:10 +0200)]
s3-svcctl: Fix _svcctl_EnumServicesStatusW() crash bug on too small buffer.
Guenther
Tim Prouty [Fri, 3 Apr 2009 01:24:43 +0000 (18:24 -0700)]
s3 onefs: Simplify level 2 oplock self-contention
This removes all oplock dependence on locking.tdb