19 years agoFix up some braindamage in the testsuite.
Andrew Bartlett [Sat, 9 Feb 2002 11:47:55 +0000 (11:47 +0000)]
Fix up some braindamage in the testsuite.

(if you remove the smbpasswd file, you wont be able to change the passwords
contained therein... :-)

Andrew Bartlett
(This used to be commit dd8388330e5ad0ae1a82f876e3a95fba854d1528)

19 years agoBring printing in HEAD inline with 2.2.x and app-head.
Jeremy Allison [Sat, 9 Feb 2002 04:10:24 +0000 (04:10 +0000)]
Bring printing in HEAD inline with 2.2.x and app-head.
(This used to be commit 771ef92fc6e43725b7cc351079998a8acb74abef)

19 years agopreparing for release of 3.0-alpha15
Samba Release Account [Sat, 9 Feb 2002 03:51:35 +0000 (03:51 +0000)]
preparing for release of 3.0-alpha15
(This used to be commit b9c843532508ea5fd4633dd7d82452fd89d63eab)

19 years agoDo the reverse DNS lookup, but only if 'hostname lookups = yes'
Andrew Bartlett [Sat, 9 Feb 2002 03:29:36 +0000 (03:29 +0000)]
Do the reverse DNS lookup, but only if 'hostname lookups = yes'

Andrew Bartlett
(This used to be commit dfecd6a4534743a3e140eafc9836911286793951)

19 years agomerge from APPLIANCE_HEAD
Gerald Carter [Fri, 8 Feb 2002 21:51:40 +0000 (21:51 +0000)]
(This used to be commit e734c1971d2841b2cfe37414fe4893f4a66b22a9)

19 years agoFix up some of the DEBUG lines in winbind_pam.c
Andrew Bartlett [Fri, 8 Feb 2002 06:43:55 +0000 (06:43 +0000)]
Fix up some of the DEBUG lines in winbind_pam.c
(This used to be commit dfc8883305abf7630e6446a0b865bae99ec2f5a4)

19 years agosmbsh need CC not SHLD
Herb Lewis [Thu, 7 Feb 2002 20:20:05 +0000 (20:20 +0000)]
smbsh need CC not SHLD
(This used to be commit 690c1fae9ce0ad6a8adef42ed5a7d8cfedab261d)

19 years agoquite errors about unnecessary const casting - don't build
Herb Lewis [Thu, 7 Feb 2002 20:09:17 +0000 (20:09 +0000)]
quite errors about unnecessary const casting - don't build
(This used to be commit 8ae0abb174aec0c76d6900b08914535d0a2d425c)

19 years agowhen a trusted domain is down an ADS server will return a success on a
Andrew Tridgell [Thu, 7 Feb 2002 02:44:37 +0000 (02:44 +0000)]
when a trusted domain is down an ADS server will return a success on a
get trusted domains query but leave the domain SID blank - we need to
fail the add of the trusted domain in winbindd in that case
(This used to be commit 24c7e7a3849df3a3378f7e7f20099de048f0b7bd)

19 years agoI added two lines of comments regarding the include= parameter. Someone
Christopher R. Hertel [Wed, 6 Feb 2002 22:51:07 +0000 (22:51 +0000)]
I added two lines of comments regarding the include= parameter.  Someone
here at the UofM was burned today because they had left that line in its
default location.
(This used to be commit fd4d3496e142574e2bd25faab5c8f1534a21558f)

19 years agoTry to get this finally working. (Note to self: *always* check build farm...)
Andrew Bartlett [Wed, 6 Feb 2002 20:31:26 +0000 (20:31 +0000)]
Try to get this finally working.  (Note to self: *always* check build farm...)

Andrew Bartlett
(This used to be commit 542e0e37455e6bcd8e0c248b3bb6ede8306d1656)

19 years agoFix ldapmod list overrun check. Also better document and format ldap control for...
Jim McDonough [Wed, 6 Feb 2002 02:28:46 +0000 (02:28 +0000)]
Fix ldapmod list overrun check.  Also better document and format ldap control for permissive modify.
(This used to be commit 01e7f7c3d9006883b71e43d917d32e325cff7a15)

19 years ago0x is the traditional prefix for displaying hex numbers.
Tim Potter [Wed, 6 Feb 2002 02:22:33 +0000 (02:22 +0000)]
0x is the traditional prefix for displaying hex numbers.
(This used to be commit f424b691ea76819e90f10919b0506bb2216ecd0e)

19 years agono longer need separate build o32 smbwrapper
Herb Lewis [Wed, 6 Feb 2002 00:56:43 +0000 (00:56 +0000)]
no longer need separate build o32 smbwrapper
(This used to be commit a9316754c7ef6244e69bec25ca20dad0019f77e1)

19 years agofix for IRIX toolroot builds
Herb Lewis [Wed, 6 Feb 2002 00:53:00 +0000 (00:53 +0000)]
fix for IRIX toolroot builds
(This used to be commit dc3fb2e6dcd92efd7468bd8121fbc49e3dadb8ea)

19 years agoFix use of uninitialsed variable in PAM code
Andrew Bartlett [Tue, 5 Feb 2002 23:45:29 +0000 (23:45 +0000)]
Fix use of uninitialsed variable in PAM code
(This used to be commit 6c08c233e6675056c0ee0bbc4ecdcbc205950f54)

19 years agoSee if we can get slightly valid C for the non-PAM case here.
Andrew Bartlett [Tue, 5 Feb 2002 21:05:04 +0000 (21:05 +0000)]
See if we can get slightly valid C for the non-PAM case here.

Andrew Bartlett
(This used to be commit 59afc3d6daad2770219dba1ca113869967eefc23)

19 years agoDrastic impromvents to pam_winbind.
Andrew Bartlett [Tue, 5 Feb 2002 09:40:36 +0000 (09:40 +0000)]
Drastic impromvents to pam_winbind.

This adds code to do generic PAM -> NTSTATUS and NTSTATUS -> PAM error
conversions, and uses them to make the error handling in pam_winbind sane.

In particular, pam_winbind now uses PAM error codes, not silly '-1, -2 ...'
stuff, and logs the NTSTATUS error that winbind now sends over the pipe.

Added code to wbinfo to display these - makes a big difference in debugging

The main change here is the code to allow pam_winbind password changing to
correctly stack - This code ripped from pam_unix, and the copyright attached.
(Same as for all pam modules, including pam_winbind)

Andrew Bartlett
(This used to be commit dc1a72f896b83bc1ad3c7bf6c12c36ace3967280)

19 years agogot rid of a silly '*' in printout
Andrew Tridgell [Tue, 5 Feb 2002 06:42:35 +0000 (06:42 +0000)]
got rid of a silly '*' in printout
(This used to be commit 22be40b6b8c034c143ce5d804628bc12cb1cc3dd)

19 years ago- only show 1 cleanup msg per client
Andrew Tridgell [Tue, 5 Feb 2002 03:55:20 +0000 (03:55 +0000)]
- only show 1 cleanup msg per client
- show client count in progress
(This used to be commit 10ee1d22e606847d40fb013c694ed5733ef6b87b)

19 years agofixed the directory removal for when the dir doesn't exit
Andrew Tridgell [Tue, 5 Feb 2002 03:02:14 +0000 (03:02 +0000)]
fixed the directory removal for when the dir doesn't exit
(This used to be commit 2c67b266cc4848dff6066fcbc875ab5f91113179)

19 years agoFix stupid typo !
Jeremy Allison [Tue, 5 Feb 2002 02:40:16 +0000 (02:40 +0000)]
Fix stupid typo !
(This used to be commit d1e911afd08971c6cf5429bda929663a5dd8f63d)

19 years agorewrote smbtorture to use the new dbench 2 format and methods
Andrew Tridgell [Tue, 5 Feb 2002 01:31:47 +0000 (01:31 +0000)]
rewrote smbtorture to use the new dbench 2 format and methods
(This used to be commit 36f816a5e12a80f0184f43cbd44ef5fac53fcb81)

19 years agocheck for empty parameters in qpathinfo
Andrew Tridgell [Tue, 5 Feb 2002 01:31:16 +0000 (01:31 +0000)]
check for empty parameters in qpathinfo
(This used to be commit c78b16c1f850562b65acb6143e55b1aefc075753)

19 years agosupport double functions
Andrew Tridgell [Tue, 5 Feb 2002 01:30:50 +0000 (01:30 +0000)]
support double functions
(This used to be commit e72c6fb36ebd3ea8fc6b6d8e1b1a9ff1ccb3ade9)

19 years agofixed a bug in qpathinfo client code
Andrew Tridgell [Tue, 5 Feb 2002 01:30:02 +0000 (01:30 +0000)]
fixed a bug in qpathinfo client code
(This used to be commit 22f348a1f9501cc00d46d6c6064f71198558c0ee)

19 years agoremoved several parameters ("client code page", "valid chars",
Gerald Carter [Mon, 4 Feb 2002 14:15:29 +0000 (14:15 +0000)]
removed several parameters ("client code page", "valid chars",
"code page directory", "character set", et. al.)
(This used to be commit 6ff236249559f8a11381cab9cc1757b26764a39d)

19 years agoAdd the new smbprint shell script, that is supposed to fix some probl...
Richard Sharpe [Mon, 4 Feb 2002 02:24:29 +0000 (02:24 +0000)]
Add the new smbprint shell script, that is supposed to fix some problems under *BSD and etc ...
(This used to be commit 6bd91973bbacc718de5d32a6819cc7e6ae98dd6f)

19 years agobetter debug messages!
Simo Sorce [Mon, 4 Feb 2002 00:59:23 +0000 (00:59 +0000)]
better debug messages!
(This used to be commit e3bb6867454307ae592115e205d32ddd53988678)

19 years agoA new simpiler syntax demands a new simpiler HOWTO. (This can all be reverted
Andrew Bartlett [Sun, 3 Feb 2002 03:51:01 +0000 (03:51 +0000)]
A new simpiler syntax demands a new simpiler HOWTO.  (This can all be reverted
if new simpiler syntax was a bad idea...).

Andrew Bartlett
(This used to be commit 717f45ca3ca85ca47f6d7b9379c17480f0bf82e4)

19 years agoMake smbgroupedit a little easier on the user.
Andrew Bartlett [Sun, 3 Feb 2002 03:25:26 +0000 (03:25 +0000)]
Make smbgroupedit a little easier on the user.

We now have error messages for most of the failure cases, and the
'sid' arguments for delete and change can now take the nt group name
as a string.

Also fix up all the internal functions to be static, keeping the
namespace clean.

Andrew Bartlett
(This used to be commit f1687587010a2390b65bd5efa37cc199b67587f8)

19 years agoChange ADS_ERROR family of macros - removed semicolon from the end, since they were...
Jim McDonough [Sat, 2 Feb 2002 22:09:03 +0000 (22:09 +0000)]
Change ADS_ERROR family of macros - removed semicolon from the end, since they were only being used correctly in one location, and all other assumed the semicolon wasn't there.  Amazing that none of them mattered syntactically, until today.
(This used to be commit 6515c3e8ef546975657e45fce7f147fe4a08e9ca)

19 years agoUpdate for function name changes, plus do some of the optional attributes on printer...
Jim McDonough [Sat, 2 Feb 2002 22:07:22 +0000 (22:07 +0000)]
Update for function name changes, plus do some of the optional attributes on printer modify, now that the ldap control is working.
(This used to be commit 76afc886a89e8c0d5a169435dde42b00db522060)

19 years agomerge in some changes from Alexey Kotovich. Return ADS_STATUS instead of BOOLs....
Jim McDonough [Sat, 2 Feb 2002 22:06:10 +0000 (22:06 +0000)]
merge in some changes from Alexey Kotovich.  Return ADS_STATUS instead of BOOLs.  Add support for bervals in mod lists.  Also put undocumented AD ldap control in to allow modifications when an attribute does not yet exist.
(This used to be commit 1a2d27b21e61be5a314f7d6c4ea0dff06a5307be)

19 years agomerge from 2.2
Gerald Carter [Sat, 2 Feb 2002 15:44:37 +0000 (15:44 +0000)]
merge from 2.2
(This used to be commit 473a89cde2e60c359cb435c714dc98974489a118)

19 years agomerge from 2.2 and regen
Gerald Carter [Sat, 2 Feb 2002 06:08:43 +0000 (06:08 +0000)]
merge from 2.2 and regen
(This used to be commit 7b7e4190739bd7df422e3f239fd89373edb97ee5)

19 years agomerge from 2.2
Gerald Carter [Sat, 2 Feb 2002 04:58:57 +0000 (04:58 +0000)]
merge from 2.2
(This used to be commit a60be0216eb3d0c76f93ec3a3edd861861cb1a4e)

19 years agoAdd support for net ads printer to publish, remove, or display printer info in the...
Jim McDonough [Sat, 2 Feb 2002 02:06:03 +0000 (02:06 +0000)]
Add support for net ads printer to publish, remove, or display printer info in the directory.  Only publishes required fields right now.
(This used to be commit 1d326f8b7e68bcad6c35488f77b05c598ebaad5d)

19 years agoMinor bug fixes, plus support to remove a printer. Commented out optional attributes...
Jim McDonough [Sat, 2 Feb 2002 02:04:01 +0000 (02:04 +0000)]
Minor bug fixes, plus support to remove a printer.  Commented out optional attributes until a method for checking for their existence is done.
(This used to be commit 538c19a6983e0423b94f743184263cd8ef9c701e)

19 years agoupdate from 2.2
Simo Sorce [Fri, 1 Feb 2002 23:20:08 +0000 (23:20 +0000)]
update from 2.2
(This used to be commit 8bb2a7446ed69020086aaedf2889795dd38ef9d4)

19 years agoAdd ads printer information
Jim McDonough [Fri, 1 Feb 2002 17:42:41 +0000 (17:42 +0000)]
Add ads printer information
(This used to be commit a844d9af21d8047629129c5e842db7acbc059932)

19 years agoFix build errors on non-ldap systems...change function parms from LDAPMod ** to void **
Jim McDonough [Fri, 1 Feb 2002 17:13:39 +0000 (17:13 +0000)]
Fix build errors on non-ldap systems...change function parms from LDAPMod ** to void **
(This used to be commit 9467792843fdd9bc55e92bfaa2f2205279074297)

19 years agoFix file header description and copyright (from cut-and-paste laziness)
Jim McDonough [Fri, 1 Feb 2002 16:58:01 +0000 (16:58 +0000)]
Fix file header description and copyright (from cut-and-paste laziness)
(This used to be commit 146c731c35beecd3ae8e093e52d94af0e2efcd69)

19 years agoAdd ldap_printer.c build for ADS printer objects.
Jim McDonough [Fri, 1 Feb 2002 16:17:39 +0000 (16:17 +0000)]
Add ldap_printer.c build for ADS printer objects.
(This used to be commit 085f5ab03e0e4994315b9a0eeb5cb2a625b784f8)

19 years agoModule for ADS operations on a printer object in the directory. Initially it creates...
Jim McDonough [Fri, 1 Feb 2002 16:15:53 +0000 (16:15 +0000)]
Module for ADS operations on a printer object in the directory.  Initially it creates and modifies a printQueue object in the directory
(This used to be commit b14e638aeb80bad80cfd12ed60f5e77f24addfd5)

19 years agoAdd functions for modifying an entry in ADS. Needed for printer publishing.
Jim McDonough [Fri, 1 Feb 2002 16:14:33 +0000 (16:14 +0000)]
Add functions for modifying an entry in ADS.  Needed for printer publishing.
(This used to be commit 3d8d8cef64c674f9f1240759a05766db95bfde4e)

19 years agoFix from Michael Steffens <> to make signal
Jeremy Allison [Thu, 31 Jan 2002 23:26:12 +0000 (23:26 +0000)]
Fix from Michael Steffens <> to make signal
processing work correctly in winbindd. This is a really good patch
that gives full select semantics to the Samba modified select.
(This used to be commit 3af16ade173cac24c1ac5eff4a36b439f16ac036)

19 years agoreduced memory usage in winbindd with a rpc backend by using a
Andrew Tridgell [Thu, 31 Jan 2002 12:47:42 +0000 (12:47 +0000)]
reduced memory usage in winbindd with a rpc backend by using a
separate talloc context for each partial fetch
(This used to be commit 9c8a2fe4df21c29c90dc8493dade2b12314234c3)

19 years agoRemoved unused variables.
Tim Potter [Thu, 31 Jan 2002 11:54:01 +0000 (11:54 +0000)]
Removed unused variables.
(This used to be commit 703d06fee03b6b6a37b9f64cdc313a0d59c41597)

19 years agoadded 'wbinfo --sequence' to show sequence numbers of all domains
Andrew Tridgell [Thu, 31 Jan 2002 11:49:29 +0000 (11:49 +0000)]
added 'wbinfo --sequence' to show sequence numbers of all domains
(This used to be commit bcd234a3dad2cd3d1c57780f4a7a3833ea611764)

19 years agoAdded administrator access check for server side add, delete and setform
Tim Potter [Thu, 31 Jan 2002 11:44:00 +0000 (11:44 +0000)]
Added administrator access check for server side add, delete and setform
rpcs.  The only one I have been able to verify is addform - can't get the
client side routines working properly yet.  )-:
(This used to be commit 3cd97d65dea428382104ebde63eaf660aa3942fb)

19 years agoAdded make functions for SPOOL_Q_{ADD,SET,DELETE}FORM.
Tim Potter [Thu, 31 Jan 2002 11:42:16 +0000 (11:42 +0000)]
Added make functions for SPOOL_Q_{ADD,SET,DELETE}FORM.

I'm pretty sure that the useless_ptr in spoolss_io_q_setform() needs to be
initialised to 1 otherwise the form isn't marshalled at all.  JF, can you
verify this?  If so then this probably applies to the io functions for
setform and deleteform.
(This used to be commit 1803778451a344c6c8d116eac5eaac777e5cf4fe)

19 years agoInitialise some SAM_ACCOUNT structs to NULL, and add some more error checking.
Andrew Bartlett [Thu, 31 Jan 2002 11:38:47 +0000 (11:38 +0000)]
Initialise some SAM_ACCOUNT structs to NULL, and add some more error checking.

Andrew Bartlett
(This used to be commit f3f375dc6b7175d4dd4ce401815e5dfdd9747083)

19 years agoAdded addform, setform and deleteform cli functions.
Tim Potter [Thu, 31 Jan 2002 11:37:48 +0000 (11:37 +0000)]
Added addform, setform and deleteform cli functions.
(This used to be commit a7e67dc00ae1a9a80875f2708def6565af0c6f0e)

19 years agoAdded addform, setform and deleteform commands. The only one I could get
Tim Potter [Thu, 31 Jan 2002 11:36:30 +0000 (11:36 +0000)]
Added addform, setform and deleteform commands.  The only one I could get
to actually work was addform.  )-:

Removed a whole bunch of calls to werror_to_ntstatus() because there isn't
a one-to-one mapping of NTSTATUS values to WERROR values.  This function
silly like that.
(This used to be commit 825b5c8bd6d0f114faf3b0fd91eb374cbfb8c8b7)

19 years agoAdded some constants for the flags field in the FORM_1 structure.
Tim Potter [Thu, 31 Jan 2002 11:30:36 +0000 (11:30 +0000)]
Added some constants for the flags field in the FORM_1 structure.

The level2 field in SPOOL_Q_ADDFORM is probably part of the FORM structure
as a discriminated union.
(This used to be commit 2c906ff77d81bc7097129d3f34be48857ce3a48b)

19 years agoAdded constant for WERR_FILE_EXISTS.
Tim Potter [Thu, 31 Jan 2002 11:28:02 +0000 (11:28 +0000)]
Added constant for WERR_FILE_EXISTS.
(This used to be commit e4c13c51fa559d24da73f57b348cfe7d711b3c7d)

19 years agothis fixes the problem of not being able to add a SD to a file on a
Andrew Tridgell [Thu, 31 Jan 2002 09:37:26 +0000 (09:37 +0000)]
this fixes the problem of not being able to add a SD to a file on a
non-domain Samba server from a NT4 client.

Note that this exactly reverses a change by Jeremy on the 18th of
December 2001, reverting the code back to what JF originally wrote. I
have looked carefully with a sniffer and JFs original NULL sid is
correct (ie. it matches what NT4 does) and also fixes the problem.

Sending a blank sid (which is what jeremy's patch did) causes NT4 to
give a classic "parameter is incorrect error" and prevents the
addition of new ACLs.
(This used to be commit 9930cf97330dd93985c5558cec6b24406e90c228)

19 years agopreparing for release of 3.0-alpha14
Samba Release Account [Wed, 30 Jan 2002 12:12:16 +0000 (12:12 +0000)]
preparing for release of 3.0-alpha14
(This used to be commit 6f977036ad1053cc4c06f801b989afdd8cfca10d)

19 years agoBack out herb's changes (to allow smbpasswd -x to work on accounts outside
Andrew Bartlett [Wed, 30 Jan 2002 12:06:22 +0000 (12:06 +0000)]
Back out herb's changes (to allow smbpasswd -x to work on accounts outside
/etc/passwd) and replace them with a version that works.  Unfortunetly HEAD and
2.2 have different passdb interfaces and different local_password_change

Andrew Bartlett
(This used to be commit 86d5326d0dc6a070dfeb24a5306a2b4404bfc0f1)

19 years agoAn attempt at producing the correct Makefile magic for wrepld_proto.h to be
Andrew Bartlett [Wed, 30 Jan 2002 10:50:07 +0000 (10:50 +0000)]
An attempt at producing the correct Makefile magic for wrepld_proto.h to be
automatically generated on first 'make'.  This wasn't being picked up by the
build farm becouse of the explicit 'make proto'.

The 'make proto' bit isn't somthing our alpha testers know about (its certainly
not clearly documented) and its meant to be automatic.

I hope this works...

Andrew Bartlett
(This used to be commit 3a413ef1eabbb28b589e5238d9c837a8275b54d0)

19 years agoAddd wrepld (what a cool name!)
Tim Potter [Wed, 30 Jan 2002 06:10:09 +0000 (06:10 +0000)]
Addd wrepld (what a cool name!)
(This used to be commit ab049355af965f7d5a9851ddbb7400d3d9986b5a)

19 years agoAdded wrepld_proto.h
Tim Potter [Wed, 30 Jan 2002 06:09:48 +0000 (06:09 +0000)]
Added wrepld_proto.h
(This used to be commit 1b9b4e46d2dec69cc6de67aad93614412ae61379)

19 years agoRemoved version number from file header.
Tim Potter [Wed, 30 Jan 2002 06:08:46 +0000 (06:08 +0000)]
Removed version number from file header.

Changed "SMB/Netbios" to "SMB/CIFS" in file header.
(This used to be commit 6a58c9bd06d0d7502a24bf5ce5a2faf0a146edfa)

19 years agoUnused file.
Tim Potter [Wed, 30 Jan 2002 05:49:20 +0000 (05:49 +0000)]
Unused file.
(This used to be commit 78013c0eccc1fed356781cf2fbba3025fcbb080c)

19 years agomerge from 2.2
Gerald Carter [Wed, 30 Jan 2002 05:45:09 +0000 (05:45 +0000)]
merge from 2.2
(This used to be commit 69a9c005c21833bdf22b72aaa3704bd14f627840)

19 years agomerge change from @_2 to allow smbpasswd -x to delete user even if no
Herb Lewis [Wed, 30 Jan 2002 04:07:42 +0000 (04:07 +0000)]
merge change from @_2 to allow smbpasswd -x to delete user even if no
entry in /etc/passwd.

There are still differences in the local_password_change function. I'm
not sure which was the latest so I didn't change any thing else. Someone
needs to take a look and sync these up.
(This used to be commit 539b025397e569796f2349d33438c2be469c8c69)

19 years agoFix for password change from Samuel Ziegler <>
Tim Potter [Wed, 30 Jan 2002 03:23:40 +0000 (03:23 +0000)]
Fix for password change from Samuel Ziegler <>
(This used to be commit 418bdd5919265bc74844401901d91edc84076314)

19 years agoRemoved silly fprintf(stderr, ...) debug.
Tim Potter [Wed, 30 Jan 2002 03:14:20 +0000 (03:14 +0000)]
Removed silly fprintf(stderr, ...) debug.

Part of Samuel Ziegler's patch to get winbind password changing working
again in HEAD.
(This used to be commit b5540bee7be957d1def62ee85a84488e0250624b)

19 years agoDoc.
Martin Pool [Tue, 29 Jan 2002 05:34:16 +0000 (05:34 +0000)]
(This used to be commit 91e8cb76628e9fcc5dc117d98d464b26db71654e)

19 years agoFix "strict allocate" to write the data out on ftruncate with extend.
Jeremy Allison [Tue, 29 Jan 2002 01:17:44 +0000 (01:17 +0000)]
Fix "strict allocate" to write the data out on ftruncate with extend.
(This used to be commit 48fc42c7104d118bd43c80c801866ebd03be1638)

19 years agoSince we have dynamic initialisation in the group mapping code, make
Tim Potter [Tue, 29 Jan 2002 01:01:14 +0000 (01:01 +0000)]
Since we have dynamic initialisation in the group mapping code, make
init_group_mapping() a static function and don't call it from any client

Not sure whether I've made a bigger mess here or not...
(This used to be commit 3c887d9021269aaa9fc0bc771af8589077e6208e)

19 years agomake all-docs to make sure everything is up-to-date
Gerald Carter [Mon, 28 Jan 2002 17:36:33 +0000 (17:36 +0000)]
make all-docs to make sure everything is up-to-date
(This used to be commit 7235a21ca4f558fbea7e156e891683767dc2cda1)

19 years agoName another talloc.
Andrew Bartlett [Mon, 28 Jan 2002 00:54:37 +0000 (00:54 +0000)]
Name another talloc.
(This used to be commit 9d62f25f5d3c25d71d8b87801084d42ae9b66f8c)

19 years agominor fix and checks
Simo Sorce [Sun, 27 Jan 2002 16:37:12 +0000 (16:37 +0000)]
minor fix and checks
(This used to be commit a034bfb9ef7a4c8a127ac91f4163cc6af98f29b3)

19 years agoSome more 'winbind default domain' support patches from Alexander Bokovoy
Andrew Bartlett [Sun, 27 Jan 2002 12:12:22 +0000 (12:12 +0000)]
Some more 'winbind default domain' support patches from Alexander Bokovoy

This patch is designed to remove the 'special cases' required for this support.

In particular this now kills off winbind_initgroups, as it appears no longer to
be required.

Andrew Bartlett
(This used to be commit f1d8d509766e9169d39332559162cfec249bfc70)

19 years agoYes, dev is an 'input/output' paramater...
Andrew Bartlett [Sun, 27 Jan 2002 12:06:27 +0000 (12:06 +0000)]
Yes, dev is an 'input/output' paramater...

Andrew Bartlett
(This used to be commit 8cac618174365825e8b1824f70cb42afbce5e500)

19 years agoPatch from Kevin Stefanik <> to do some more error checking for
Andrew Bartlett [Sun, 27 Jan 2002 10:53:43 +0000 (10:53 +0000)]
Patch from Kevin Stefanik <> to do some more error checking for
group mapping init failures.
(This used to be commit cd6a2dad4e3092a19f784b6548fce49ecd8bb549)

19 years agomerge from 2.2 and regenerate
Gerald Carter [Sun, 27 Jan 2002 05:37:23 +0000 (05:37 +0000)]
merge from 2.2 and regenerate
(This used to be commit 55c53ef08974947cf10a79882b63d6d8e8baad4c)

19 years agoGive pdbedit a -D paramater for setting the DEBUGLEVEL (makes debugging passdb
Andrew Bartlett [Sun, 27 Jan 2002 03:00:56 +0000 (03:00 +0000)]
Give pdbedit a -D paramater for setting the DEBUGLEVEL (makes debugging passdb
much saner :-).

Change to pdb_init_sam()/pdb_free_sam() loop rather than reset based due to
the talloc basis.

Andrew Bartlett
(This used to be commit e40a0a7f27950bd0484fe7d6b67dce45cd75d25c)

19 years agomerge from APPLIANCE_HEAD
Gerald Carter [Sat, 26 Jan 2002 22:27:12 +0000 (22:27 +0000)]
(This used to be commit e3b87ffc8c26f9fd4c3e8181897b8812b7dc4ab6)

19 years ago - Provide sid->name lookup support for non-unix accounts.
Andrew Bartlett [Sat, 26 Jan 2002 12:24:18 +0000 (12:24 +0000)]
 - Provide sid->name lookup support for non-unix accounts.

 - Rework the name -> sid lookup function to always try local lookup first (for
local domain names) before trying winbind.  This seems to eliminate my winbind
feedback loop problems.  (I don't use winbind for nsswitch, where there are
almost certainly further issues).

Andrew Bartlett
(This used to be commit 25cadce67bc8effd4248ab993ae78e1d8511d994)

19 years agoBack out some of the less well thought out ideas from last weeks work on
Andrew Bartlett [Sat, 26 Jan 2002 11:48:42 +0000 (11:48 +0000)]
Back out some of the less well thought out ideas from last weeks work on
winbind default domains, particulary now I understand whats going on a lot
better.  This ensures that the RPC client code does as little 'magic' as
possible - this is up to the application/user.  (Where - for to name->sid code
- it was all along).  This leaves the change that allows the sid->name code to
return domains and usernames in seperate paramaters.

Andrew Bartlett
(This used to be commit 5dfba2cf536f761b0aee314ed9e30dc53900b691)

19 years agoBring this code into line with new winbind_lookup_name() interface. I think
Andrew Bartlett [Sat, 26 Jan 2002 10:10:25 +0000 (10:10 +0000)]
Bring this code into line with new winbind_lookup_name() interface.  I think
this might need a bit more work - or at least documentation.

This is certainly a worthwile little hack, as it avoids the need to invert the
group database.  I don't think we should allow unqualified domains here - as
that allows us to distinguish between (at least some) usernames and these
'special' groups.
(This used to be commit 151dd7bc6c61e19a993017e5e0b50314801e26de)

19 years agoMake a talloc'ed copy of this strings so we can pass the right kind of pointer
Andrew Bartlett [Sat, 26 Jan 2002 10:06:23 +0000 (10:06 +0000)]
Make a talloc'ed copy of this strings so we can pass the right kind of pointer
to the function.  This fixes a nice little segfault the brute-force-casting
created. :-)

Andrew Bartlett
(This used to be commit c84fa7f5fd62940e397d3353fb688f283349393e)

19 years agoRework lookup_name() to take seperate username/domain args, and to remove
Andrew Bartlett [Sat, 26 Jan 2002 10:05:10 +0000 (10:05 +0000)]
Rework lookup_name() to take seperate username/domain args, and to remove
varioius crazy 'if winbind didn't find it' cases.  This makes winbind default
domain support easier to intergrate with smbd.
(This used to be commit 3e71521957d579f00249679de837490aca5ba92f)

19 years agoAdd the become_root()/unbecome_root() wrapper around the lookup_name() call,
Andrew Bartlett [Sat, 26 Jan 2002 10:03:25 +0000 (10:03 +0000)]
Add the become_root()/unbecome_root() wrapper around the lookup_name() call,
and its new args.
(This used to be commit e7b3d64f6055b5d3b036f525f0ece3c9479d4f7a)

19 years agoMove the lsa code across to the changed args for lookup_name, and surround it
Andrew Bartlett [Sat, 26 Jan 2002 10:02:23 +0000 (10:02 +0000)]
Move the lsa code across to the changed args for lookup_name, and surround it
in become_root()/unbecome_root().

Also only allocate the memory the client reqests - and don't allow the client
to trigger an SMB_ASSERT if they ask for 'more'.

Up the maximum number of sids allowed, and note that this is an arbiary guess,
and can be raised without consequence.

Andrew Bartlett
(This used to be commit 6e7667125d142670db7393ed7a48386f3821d896)

19 years agoWe may as well not use these temporary variables - they are only used once and
Andrew Bartlett [Sat, 26 Jan 2002 09:58:11 +0000 (09:58 +0000)]
We may as well not use these temporary variables - they are only used once and
just make it harder to debug (gcc stips optomises them away).
(This used to be commit 100d2705ddfa1fde73a0bb06e8e097b2b1cbf36a)

19 years agolocal_lookup_name() doens't acutally use its 'domain' argument, so drop it and
Andrew Bartlett [Sat, 26 Jan 2002 09:56:47 +0000 (09:56 +0000)]
local_lookup_name() doens't acutally use its 'domain' argument, so drop it and
make its use clearer.
(This used to be commit d1ea20cc2392f8ba4ac4241f9b5ec14489e49147)

19 years agoChange the winbind interface to use seperate 'domain' and 'username' feilds for
Andrew Bartlett [Sat, 26 Jan 2002 09:55:38 +0000 (09:55 +0000)]
Change the winbind interface to use seperate 'domain' and 'username' feilds for
the sid->uid and uid->sid conversions.

Remove some duplicate arguments from these funcitons, and update the
request/response structures for this and the 'winbind domain name' feature.

As such 'winbindd_lookup_name' now takes both a domain and username.
(This used to be commit ce1b4d4c309e4a60bec5a53224585bd504264672)

19 years agoAllow a winbind client to obtain the server's domain name.
Andrew Bartlett [Sat, 26 Jan 2002 09:52:55 +0000 (09:52 +0000)]
Allow a winbind client to obtain the server's domain name.
(This used to be commit 85018fecfad1f7f6ef44b511bac937881a7bf937)

19 years agoRemove the 'direct to winbind' hacks, as they should (if I understand
Andrew Bartlett [Sat, 26 Jan 2002 09:50:28 +0000 (09:50 +0000)]
Remove the 'direct to winbind' hacks, as they should (if I understand
correctly) be no longer needed.  This is in aid of the 'winbind default domain'
code - which works much better when smbd always goes via the standard unix

Andrew Bartlett
(This used to be commit a41fe2f6c845789c719de1d9a26a1374fb0e7fdb)

19 years agoThis always points at a string literal, so it probably should be 'const'.
Andrew Bartlett [Sat, 26 Jan 2002 06:28:50 +0000 (06:28 +0000)]
This always points at a string literal, so it probably should be 'const'.
(This used to be commit e72e511935ce7f2b658a133bd536833864bc6a92)

19 years agoFix up a security issue with the way we handle domain groups retuned on the
Andrew Bartlett [Sat, 26 Jan 2002 06:24:53 +0000 (06:24 +0000)]
Fix up a security issue with the way we handle domain groups retuned on the
info3.  These are RIDs, and it only makes sense to combine them with the domain
SID returned with them.  This is important for trusted domains, where that sid
might be other than the one we currently reterive from the secrets.tdb.

Also remove the become_root()/unbecome_root() wrapper from around both
remaining TDB users:  Both are now initialised at smbd startup.

Andrew Bartlett
(This used to be commit 554842e0a55155193f25aefca6480b89d5c512ca)

19 years agofix typo
Andrew Bartlett [Sat, 26 Jan 2002 06:18:59 +0000 (06:18 +0000)]
fix typo
(This used to be commit 8ffc024ebc73dee32a9dfc1873e824c996205475)

19 years agoThe new plugable password backend system needs to be initialised after
Andrew Bartlett [Sat, 26 Jan 2002 06:16:36 +0000 (06:16 +0000)]
The new plugable password backend system needs to be initialised after

Andrew Bartlett
(This used to be commit 168c712bf3b8be19e6e72b7bf4563ed3ae87c176)

19 years agoThese changes commited on a 'no less broken' basis.
Andrew Bartlett [Sat, 26 Jan 2002 06:02:28 +0000 (06:02 +0000)]
These changes commited on a 'no less broken' basis.

The previous code attempted to call winbind to find out the domain sid.  This
couldn't work for a number of reasons - not the least of which was that both
the client and server ends would reject any name (in this case domain name)
without a \ in it (or lp_winbind_seperator()).

I think this is what was intended to occour.  If there is still some need to
contact winbind for this information, I suggest a new call be created for this
- as it the server-side code doesn't allow for this information to be extracted
easily in any case.

Finally, it gets in the way of the default domain code a bit - hence why I was
actually looking at it...

Andrew Bartlett
(This used to be commit 5fe1ea7f11a314a42f867a4f159c1c63c516568f)

19 years agoTry to get the compiler not to complain about assignments and truth values...
Andrew Bartlett [Sat, 26 Jan 2002 05:53:07 +0000 (05:53 +0000)]
Try to get the compiler not to complain about assignments and truth values...

Andrew Bartlett
(This used to be commit 6650b21ceabefab037cfd3b135039914fb75e3a9)

19 years agoTry to move towards slightly sane linking for Samba by removing some pdb_...()
Andrew Bartlett [Sat, 26 Jan 2002 05:52:20 +0000 (05:52 +0000)]
Try to move towards slightly sane linking for Samba by removing some pdb_...()
calls from rpc_parse/parse_net.c - instead these values are passed as a

Unfortunetly some there is still some samr work to be done before this is
actually useful.

Andrew Bartlett
(This used to be commit 4fc9e16ad7a77cf2e37b27640c0dec2052e9cda0)