ira/wip.git
14 years agor11577: adding perl interpreter she-bang to top of parselog.pl script
Gerald Carter [Tue, 8 Nov 2005 16:29:15 +0000 (16:29 +0000)]
r11577: adding perl interpreter she-bang to top of parselog.pl script
(This used to be commit db4eb72142a23224ea93d2a2519b6d8cd7dc8643)

14 years agor11573: Adding Andrew Bartlett's patch to make machine account
Jeremy Allison [Tue, 8 Nov 2005 06:19:34 +0000 (06:19 +0000)]
r11573: Adding Andrew Bartlett's patch to make machine account
logons work if the client gives the MSV1_0_ALLOW_SERVER_TRUST_ACCOUNT
or MSV1_0_ALLOW_WORKSTATION_TRUST_ACCOUNT flags. This changes
the auth module interface to 2 (from 1). The effect of this is
that clients can access resources as a machine account if they
set these flags. This is the same as Windows (think of a VPN
where the vpn client authenticates itself to a VPN server
using machine account credentials - the vpn server checks
that the machine password was valid by performing a machine
account check with the PDC in the same was as it would a
user account check. I may add in a restriction (parameter)
to allow this behaviour to be turned off (as it was previously).
That may be on by default.
Andrew Bartlett please review this change carefully.
Jeremy.
(This used to be commit d1caef866326346fb191f8129d13d98379f18cd8)

14 years agor11566: From metze. Use "interpret_addr(lp_socket_address())" for port 138.
Jeremy Allison [Mon, 7 Nov 2005 23:28:42 +0000 (23:28 +0000)]
r11566: From metze. Use "interpret_addr(lp_socket_address())" for port 138.
Jeremy.
(This used to be commit d398a1aeb48422a89cee59d5760a87bbb2d50b03)

14 years agor11560: Fix core dump if setmntent returns NULL.
Jeremy Allison [Mon, 7 Nov 2005 19:18:00 +0000 (19:18 +0000)]
r11560: Fix core dump if setmntent returns NULL.
Pointed out by Jay Fanlason @ Red Hat.
Jeremy.
(This used to be commit e8136ae746b5be51b252d900aa732c8106fefcaf)

14 years agor11556: Fix "make everything"
Volker Lendecke [Mon, 7 Nov 2005 16:00:35 +0000 (16:00 +0000)]
r11556: Fix "make everything"
(This used to be commit bff03f0cd484c04d5ab6d6b66f30191bef368b68)

14 years agor11551: Add a few more initialize_krb5_error_table
Volker Lendecke [Mon, 7 Nov 2005 14:16:50 +0000 (14:16 +0000)]
r11551: Add a few more initialize_krb5_error_table
(This used to be commit d92c83aa42fe64a0e996094d1a983f0279c7c707)

14 years agor11549: fixing GPL notices
Gerald Carter [Mon, 7 Nov 2005 13:45:28 +0000 (13:45 +0000)]
r11549: fixing GPL notices
(This used to be commit 26e9c1c1fae8f2fe402374f7cf1d87de48852fa6)

14 years agor11548: adding simple script to tail syslog and write to eventlog tdb
Gerald Carter [Mon, 7 Nov 2005 13:43:06 +0000 (13:43 +0000)]
r11548: adding simple script to tail syslog and write to eventlog tdb
(This used to be commit 9337a286c9169e1e0247b5923942eeeb4467d95a)

14 years agor11530: Add the "time offset" parameter back in for people who
Jeremy Allison [Sun, 6 Nov 2005 01:55:09 +0000 (01:55 +0000)]
r11530: Add the "time offset" parameter back in for people who
might use it.
Jeremy.
(This used to be commit b745114423a482ea8cd1ea4f80ec3fc2a9caa971)

14 years agor11511: A classic "friday night check-in" :-). This moves much
Jeremy Allison [Sat, 5 Nov 2005 04:21:55 +0000 (04:21 +0000)]
r11511: A classic "friday night check-in" :-). This moves much
of the Samba4 timezone handling code back into Samba3.
Gets rid of "kludge-gmt" and removes the effectiveness
of the parameter "time offset" (I can add this back
in very easily if needed) - it's no longer being
looked at. I'm hoping this will fix the problems people
have been having with DST transitions. I'll start comprehensive
testing tomorrow, but for now all modifications are done.
Splits time get/set functions into srv_XXX and cli_XXX
as they need to look at different timezone offsets.
Get rid of much of the "efficiency" cruft that was
added to Samba back in the day when the C library
timezone handling functions were slow.
Jeremy.
(This used to be commit 414303bc0272f207046b471a0364fa296b67c1f8)

14 years agor11508: Removed incorrect patch hunk. Thanks to Andrew
Jeremy Allison [Sat, 5 Nov 2005 00:02:01 +0000 (00:02 +0000)]
r11508: Removed incorrect patch hunk. Thanks to Andrew
Bartlett for pointing this out.
Jeremy.
(This used to be commit c93a08be4a29854354a16c6e8f984477e19f41c0)

14 years agor11506: Added description of ACL in usage message.
Jeremy Allison [Fri, 4 Nov 2005 17:40:35 +0000 (17:40 +0000)]
r11506: Added description of ACL in usage message.
Jeremy.
(This used to be commit 7795fce24e1e6dfe55360bb62617b922973f5f95)

14 years agor11504: Added Andrew Bartletts removal of another NTLMSSP implementation
Jeremy Allison [Fri, 4 Nov 2005 17:39:42 +0000 (17:39 +0000)]
r11504: Added Andrew Bartletts removal of another NTLMSSP implementation
patch.
Jeremy.
(This used to be commit 4591984176fd32ba25155fbc6889a1c637019a08)

14 years agor11494: Finally fix #3192 - remember iDiskfreeCacheTime is
Jeremy Allison [Fri, 4 Nov 2005 01:21:46 +0000 (01:21 +0000)]
r11494: Finally fix #3192 - remember iDiskfreeCacheTime is
an *integer*, not a pointer. Doh !
Jeremy.
(This used to be commit f1e0c863637f11f5857663d1980ba7f40fce7357)

14 years agor11492: Fix bug #3224 (I hope). Correctly use machine_account_name
Jeremy Allison [Fri, 4 Nov 2005 00:03:55 +0000 (00:03 +0000)]
r11492: Fix bug #3224 (I hope). Correctly use machine_account_name
and client_name when doing netlogon credential setup.
Jeremy.
(This used to be commit 37e6ef9389041f58eada167239fd022f01c5fecb)

14 years agor11491: If we get a reject ensure we're printing out the server/domain/machine
Jeremy Allison [Thu, 3 Nov 2005 20:26:24 +0000 (20:26 +0000)]
r11491: If we get a reject ensure we're printing out the server/domain/machine
a/c we were asking for.
Jeremy.
(This used to be commit 3ba5d02cff61d64dbab1fef28f74ea6509f4f8e9)

14 years agor11482: Arrg. Can't believe this code was in this state. If you
Jeremy Allison [Wed, 2 Nov 2005 20:32:11 +0000 (20:32 +0000)]
r11482: Arrg. Can't believe this code was in this state. If you
don't initialize the mask then setting "special" access
gets set to *random* permissions !
Jeremy.
(This used to be commit f1616911a858886da0a635a2f9b95d471215e84c)

14 years agor11464: Allow smbcacls to modify a SD on W2K3. This may fix several
Jeremy Allison [Wed, 2 Nov 2005 02:35:48 +0000 (02:35 +0000)]
r11464: Allow smbcacls to modify a SD on W2K3. This may fix several
bugzilla bugs - I need to go through and check. I also
need to test against WNT/W2K and WXP.
Jeremy.
(This used to be commit 881dd7dbf6de0e11a3703afd2a1ba286ff0d62ad)

14 years agor11460: Improve error messages in parsing security descriptors.
Jeremy Allison [Wed, 2 Nov 2005 02:13:08 +0000 (02:13 +0000)]
r11460: Improve error messages in parsing security descriptors.
Jeremy.
(This used to be commit 385f128de716b62bdfc82627a403fe6dd69bd39d)

14 years agor11454: Last 2 uninitialized warnings.
Jeremy Allison [Wed, 2 Nov 2005 00:37:35 +0000 (00:37 +0000)]
r11454: Last 2 uninitialized warnings.
Jeremy.
(This used to be commit 5f10368ff0f5eae646533280a444dc091d732c0d)

14 years agor11451: Fix -O1 "might be using uninitialized" errors.
Jeremy Allison [Wed, 2 Nov 2005 00:19:26 +0000 (00:19 +0000)]
r11451: Fix -O1 "might be using uninitialized" errors.
Jeremy.
(This used to be commit cab76c3c33883aad444eefb6562ab1b27d9ca88a)

14 years agor11448: Move decl before code.
Jeremy Allison [Tue, 1 Nov 2005 23:49:40 +0000 (23:49 +0000)]
r11448: Move decl before code.
Jeremy.
(This used to be commit f22822790cdbbe7d5a237421c1eda73a504e488d)

14 years agor11446: Remove unused fn. Remove unneeded strncpy use.
Jeremy Allison [Tue, 1 Nov 2005 23:29:02 +0000 (23:29 +0000)]
r11446: Remove unused fn. Remove unneeded strncpy use.
Jeremy.
(This used to be commit d202aae3c821f3d78ff063d867bac1f84dca3548)

14 years agor11443: Fix error code returns on client spoolss code. Fix them
Jeremy Allison [Tue, 1 Nov 2005 19:24:55 +0000 (19:24 +0000)]
r11443: Fix error code returns on client spoolss code. Fix them
up a *lot*.
Jeremy.
(This used to be commit 762fff4ddb505b90ada1ea54348dba1a8b9af631)

14 years agor11435: Allow the hash size of the tdb open (locking) database
Jeremy Allison [Tue, 1 Nov 2005 02:07:26 +0000 (02:07 +0000)]
r11435: Allow the hash size of the tdb open (locking) database
to be set in local.h. Change from the default (131) to
another prime (1049). Should this be an smb.conf tunable parameter
based on the number of open file descriptors available ?
If so what scaling factor ? More tests to follow.
Jeremy.
(This used to be commit 6a902ec49ffea5d0ca0308d5ff51584cece41043)

14 years agor11433: Fix for bug #3223 - ensure we're root before doing
Jeremy Allison [Mon, 31 Oct 2005 23:47:57 +0000 (23:47 +0000)]
r11433: Fix for bug #3223 - ensure we're root before doing
any potential lib/smbldap.c calls.
Jeremy.
(This used to be commit 915cfb48f08b3748e22e68ed028eaca6d558cbad)

14 years agor11428: Fix bug #3192 by actually hooking up the dfree caching
Jeremy Allison [Mon, 31 Oct 2005 22:30:05 +0000 (22:30 +0000)]
r11428: Fix bug #3192 by actually hooking up the dfree caching
function. Oops.
Jeremy.
(This used to be commit 7edb26e7657fc01710abe563b941779749409ef2)

14 years agor11420: Fix issue pointed out by Dina Fine <dina@exanet.com>. We can
Jeremy Allison [Mon, 31 Oct 2005 20:11:58 +0000 (20:11 +0000)]
r11420: Fix issue pointed out by Dina Fine <dina@exanet.com>. We can
only tell at parse time from the wire if an incoming name
has wildcards or not. If it's a mangled name and we demangle
the demangled name may contain wildcard characters. Ensure
these are ignored.
Jeremy.
(This used to be commit 4cd8e2a96b98ff711905e8c6f416b22440c16062)

14 years agor11398: Keep s3 in sync with trunk
Simo Sorce [Sat, 29 Oct 2005 13:31:57 +0000 (13:31 +0000)]
r11398: Keep s3 in sync with trunk
(This used to be commit 7fc05b79643c93eaf0ef028a7337889ed21c52ba)

14 years agor11395: Update the Debian packaging.
Simo Sorce [Sat, 29 Oct 2005 13:19:27 +0000 (13:19 +0000)]
r11395: Update the Debian packaging.
Move form stable to stable distribution names based hives.
(This used to be commit bb13b3482047b6ab6d84ba9e2839cf8a0fac71aa)

14 years agor11389: Attempt to fix bug #3212 - ignore bogus OS/2 EA set values on
Jeremy Allison [Sat, 29 Oct 2005 00:27:16 +0000 (00:27 +0000)]
r11389: Attempt to fix bug #3212 - ignore bogus OS/2 EA set values on
trans2_mkdir/trans2_open/trans2_setfilepathingo.
Jeremy.
(This used to be commit 71c037dfbb0b51e750f2e14533b03d9932778cb0)

14 years agor11383: Patch from Alex Masterov <alex@infobit.ru> to fix
Jeremy Allison [Fri, 28 Oct 2005 22:22:23 +0000 (22:22 +0000)]
r11383: Patch from Alex Masterov <alex@infobit.ru> to fix
XATTR calls on *BSD systems (bug #3218).
Jeremy.
(This used to be commit 3d8faf42e854a720aca5c2e0a4682c85a3dfd365)

14 years agor11381: Correctly connect to 445 and 139 after a successful getdcname.
Volker Lendecke [Fri, 28 Oct 2005 21:08:31 +0000 (21:08 +0000)]
r11381: Correctly connect to 445 and 139 after a successful getdcname.

Volker
(This used to be commit 440e7b3342e6b7b12208b789853962de72a9cac2)

14 years agor11379: Remove external dependencies from sharemodes library.
Jeremy Allison [Fri, 28 Oct 2005 20:36:21 +0000 (20:36 +0000)]
r11379: Remove external dependencies from sharemodes library.
Jeremy.
(This used to be commit 7fb05872612c9e1816ac24d25a020073e3b41950)

14 years agor11375: Update to the latest config.guess and config.sub files.
Paul Green [Fri, 28 Oct 2005 16:17:46 +0000 (16:17 +0000)]
r11375: Update to the latest config.guess and config.sub files.
(This used to be commit eee397ea15d0804d541be9707158a5240996aeae)

14 years agor11368: Remove a memleak that just cost me half an hour: If we terminate inside a
Volker Lendecke [Fri, 28 Oct 2005 09:15:27 +0000 (09:15 +0000)]
r11368: Remove a memleak that just cost me half an hour: If we terminate inside a
message handler, the list of messages from retrieve_all_messages is not
properly freed. Not important, just confusing :-)

Volker
(This used to be commit d20388750dcfe7e0680246f7e3e6beb3a6d51a4a)

14 years agor11346: Fix for bug found by Dina Fine. If in case sensitive mode then
Jeremy Allison [Fri, 28 Oct 2005 01:42:03 +0000 (01:42 +0000)]
r11346: Fix for bug found by Dina Fine. If in case sensitive mode then
the mangle cache is no good (3 letter extension could be wrong
case - so don't demangle in this case - leave as mangled and
allow the mangling of the directory entry read (which is done
case insensitively) to match instead. This will lead to more
false positive matches but we fail completely without it.
Jeremy.
(This used to be commit 238b35d2e6e21d0e07d500d446f08ec128ea7720)

14 years agor11344: I don't think share mode conflicts occur on deleting
Jeremy Allison [Thu, 27 Oct 2005 23:30:25 +0000 (23:30 +0000)]
r11344: I don't think share mode conflicts occur on deleting
a directory when you've got permissions. Need to write
a smbtorture test for this.
Jeremy.
(This used to be commit e959a5be393eb59b8987eb6967a2ee5d11978f41)

14 years agor11341: Put directory opens into the share mode db so we
Jeremy Allison [Thu, 27 Oct 2005 22:35:08 +0000 (22:35 +0000)]
r11341: Put directory opens into the share mode db so we
can treat them similarly to file opens (delete on
close, share mode violations etc.). This fixes bug
#3216 I will up the default hash size on the locking
db in a later commit as this means more entries.
Jeremy.
(This used to be commit 1134abbbb3fd8e8b88e1a5817aae106476a4c126)

14 years agor11338: Move knowledge of \\ needed into rpc_client/cli_netlogon
Jeremy Allison [Thu, 27 Oct 2005 18:25:41 +0000 (18:25 +0000)]
r11338: Move knowledge of \\ needed into rpc_client/cli_netlogon
(this is the way it's been done in other functions). Instead
of moving this into the IDL, I think the best solution would
be to write a wrapper function around any call that needs
this (this is what we already do for many of the calls).
Jeremy.
(This used to be commit aeca4efa11728be53b81967bb5442b5b09d1a975)

14 years agor11336: Start to get my control back :-). Volker, I think
Jeremy Allison [Thu, 27 Oct 2005 18:06:29 +0000 (18:06 +0000)]
r11336: Start to get my control back :-). Volker, I think
Andrew Bartlett is right - making lsa code do it the
netlogon way, not vica-versa.
Jeremy.
(This used to be commit f313757e36215cb3dd956e4a73de6d30258a6974)

14 years agor11332: eventlog API uses NTSTATUS, not WERROR for return codes
Gerald Carter [Thu, 27 Oct 2005 13:30:23 +0000 (13:30 +0000)]
r11332: eventlog API uses NTSTATUS, not WERROR for return codes
(This used to be commit f5f40633bc3f641a0fef4934375d0d829899b0d7)

14 years agor11328: Actually verify that the bind on a pipe succeeded with a samr_connect or
Volker Lendecke [Thu, 27 Oct 2005 12:51:24 +0000 (12:51 +0000)]
r11328: Actually verify that the bind on a pipe succeeded with a samr_connect or
lsa_openpolicy and fall back appropriately. In particular an ntlmssp bind
failure can not be detected before the first real rpc request, at least
according to abartlet :-)

Works for me against w2k3, w2k and nt4. Sooner or later I should test against
samba4 ... :-)

Volker
(This used to be commit 48a9e35208ae7b6271508085f59833e5def640e8)

14 years agor11327: Make user domain settable by pdbedit
Volker Lendecke [Thu, 27 Oct 2005 12:47:06 +0000 (12:47 +0000)]
r11327: Make user domain settable by pdbedit
(This used to be commit 37267d5ab018bb6df9e297ea68e57deb9a908f28)

14 years agor11326: Fix alignment in getdc response
Volker Lendecke [Thu, 27 Oct 2005 12:45:10 +0000 (12:45 +0000)]
r11326: Fix alignment in getdc response
(This used to be commit 9741818d2c54240ef1f38762396828adceb92b2a)

14 years agor11324: Re-formatting before I can get a very *narrow* focus on the bugs in here...
Volker Lendecke [Thu, 27 Oct 2005 11:16:36 +0000 (11:16 +0000)]
r11324: Re-formatting before I can get a very *narrow* focus on the bugs in here. ;-)

We can only tell if the bind succeeded on the first real RPC call. So we have
to decide according to success of samrconnect whether we have to fall
back. Similarly for lsaopenpolicy.

Volker
(This used to be commit 0603e1c8456ee87b87b051e0303a35fdbfbcf7ca)

14 years agor11323: Fix usage of rpccli_netlogon_getdcname. Add some debug messages.
Volker Lendecke [Thu, 27 Oct 2005 11:01:29 +0000 (11:01 +0000)]
r11323: Fix usage of rpccli_netlogon_getdcname. Add some debug messages.

Volker
(This used to be commit 770ad2a8a72ae7bfcdc1b86b72142e11f662d975)

14 years agor11320: Fix error handling for rpccli_netlogon_getdcname. Jeremy, the other functions
Volker Lendecke [Thu, 27 Oct 2005 08:27:48 +0000 (08:27 +0000)]
r11320: Fix error handling for rpccli_netlogon_getdcname. Jeremy, the other functions
in cli_netlogon look similarly suspicious.

Volker
(This used to be commit 8d7713431efd80bd358daffcbbc4d715611b8b4b)

14 years agor11319: read_buf_len and write_buf_len are no longer used, remove them.
Volker Lendecke [Thu, 27 Oct 2005 07:57:39 +0000 (07:57 +0000)]
r11319: read_buf_len and write_buf_len are no longer used, remove them.

Volker
(This used to be commit 6948f748f689708c396e52097553ff222b1af744)

14 years agor11301: why would you look for printf in -lnsl[_s]? Fixing configure checks
Gerald Carter [Wed, 26 Oct 2005 13:44:46 +0000 (13:44 +0000)]
r11301: why would you look for printf in -lnsl[_s]?  Fixing configure checks
(This used to be commit c495059de1675676fe4d9a87ce516a54f16e9c66)

14 years agor11296: removing unused variable and ifdef'd out code
Gerald Carter [Tue, 25 Oct 2005 14:56:22 +0000 (14:56 +0000)]
r11296: removing unused variable and ifdef'd out code
(This used to be commit 88a33c4cf87ada17637579d9261471c219e88de0)

14 years agor11295: new service hashing code has assumign that the service
Gerald Carter [Tue, 25 Oct 2005 14:54:41 +0000 (14:54 +0000)]
r11295: new service hashing code has assumign that the service
name stored in the array was normalized.  This was causing
records to not be deleted on a reload.  As a result,
I was getting the wrong path for various services.
Seems to be ok after this change.

Also converted canonicalize_servicename() to just
use strupper_m() rather than doing the conversion itself.
Jeremy, i think this should be ok but please check.

also cleaned up some things in the hash service code
and added debug messages for sanity purposes.
(This used to be commit e0bf0581f0aaf1505f653f2101eed61352d03da8)

14 years agor11292: Missed merge from Samba 2.2 many years ago....
Gerald Carter [Tue, 25 Oct 2005 12:49:24 +0000 (12:49 +0000)]
r11292: Missed merge from Samba 2.2 many years ago....

Don't count open pipes in the num_files_open on a connection.
conn_idle_all() handles this by looking for open rpc handles
If there are no open handles, we can close the IPC$ share.
(This used to be commit 747fba4dbf06c42495c430cd78c1cded3445f821)

14 years agor11286: Fix a potential segfault
Volker Lendecke [Tue, 25 Oct 2005 09:42:22 +0000 (09:42 +0000)]
r11286: Fix a potential segfault
(This used to be commit f4c310d55624ab726e3cdc49dcc69f9162c797aa)

14 years agor11283: Move to using sival_int from sival_ptr. Part of bug #2922.
Jeremy Allison [Tue, 25 Oct 2005 05:26:53 +0000 (05:26 +0000)]
r11283: Move to using sival_int from sival_ptr. Part of bug #2922.
Jeremy.
(This used to be commit f68ff32630ee3b06b69bac59674ecc1496880a47)

14 years agor11280: BUG 3201: make sure request structure is cleared prior to sending the request...
Gerald Carter [Mon, 24 Oct 2005 16:55:26 +0000 (16:55 +0000)]
r11280: BUG 3201: make sure request structure is cleared prior to sending the request to winbindd (prevents the WB_RECURSE flags from accidentially getting set
(This used to be commit 8c63d6d8a7f50d9a101117338242a9c8b243b43f)

14 years agor11275: patch from Chris to remove the empty struct in libmsrpc.h (fix build with...
Gerald Carter [Mon, 24 Oct 2005 14:11:16 +0000 (14:11 +0000)]
r11275: patch from Chris to remove the empty struct in libmsrpc.h (fix build with Sun compiler)
(This used to be commit dd28582efbacd02c4134298be000cd2338c822ad)

14 years agor11269: Ensure the new canonicalize_servicename() is mb safe.
Jeremy Allison [Sun, 23 Oct 2005 19:00:40 +0000 (19:00 +0000)]
r11269: Ensure the new canonicalize_servicename() is mb safe.
MB service names may contain embedded ' ' characters.
Jeremy.
(This used to be commit 83d0cda858de5f40ab652e1f438808a3bfac0f81)

14 years agor11266: Speed up loading smb.conf for large numbers of share definitions. The problem
Volker Lendecke [Sun, 23 Oct 2005 16:29:02 +0000 (16:29 +0000)]
r11266: Speed up loading smb.conf for large numbers of share definitions. The problem
was a O(n^2) loop: Whenever a service definition was found, we linearly
searched the already loaded share definitions, the patch adds an internal tdb
for this. For a smb.conf with 2000 shares this speeds up loading by about a
factor of 50.

Might be a fix for bug #1117.

Thanks to Michael Adam <ma@sernet.de>,

Volker
(This used to be commit d07343e0c4022d753f381d368fc0f03972a070f3)

14 years agor11256: Remove use of long long and strtoll in libsmbclient (we
Jeremy Allison [Fri, 21 Oct 2005 22:48:27 +0000 (22:48 +0000)]
r11256: Remove use of long long and strtoll in libsmbclient (we
can't assume long long is always there). Removed unused
var in new a/c rename code.
long long still used in eventlog code but Jerry has promised
to fix that.
Jeremy.
(This used to be commit f46d8470652b8bc5c4b8cac8e96973c6165ab19a)

14 years agor11253: Fix an annoying timeout when no nmbd is around
Volker Lendecke [Fri, 21 Oct 2005 21:46:49 +0000 (21:46 +0000)]
r11253: Fix an annoying timeout when no nmbd is around
(This used to be commit 10fb32ec52b32b72a46a783b73c6dd1f24625d9b)

14 years agor11251: Fix a comment
Volker Lendecke [Fri, 21 Oct 2005 21:25:26 +0000 (21:25 +0000)]
r11251: Fix a comment
(This used to be commit 1ce6d12898c6f24c83e54561862735586b5a41b4)

14 years agor11242: use LDAP bitwise machting rule when searching for groups in ADS.
Günther Deschner [Fri, 21 Oct 2005 12:50:39 +0000 (12:50 +0000)]
r11242: use LDAP bitwise machting rule when searching for groups in ADS.

This avoids that each time a full-group-dump is requested from ADS; the
bitwise match allows to only query those groups we are interested in.

The ADS LDAP server changed to RFC compliant behaviour when decoding the ldap
filter with extensible match in the latest SPs (fixes). From the patch:

/* Workaround ADS LDAP bug present in MS W2K3 SP0 and W2K SP4 w/o
  * rollup-fixes:
  *
  * According to Section 5.1(4) of RFC 2251 if a value of a type is it's
  * default value, it MUST be absent. In case of extensible matching the
  * "dnattr" boolean defaults to FALSE and so it must be only be present
  * when set to TRUE.
  *
  * When it is set to FALSE and the OpenLDAP lib (correctly) encodes a
  * filter using bitwise matching rule then a buggy AD fails to decode
  * the extensible match. As a workaround set it to TRUE and thereby add
  * the dnAttributes "dn" field to cope with those older AD versions.
  * It should not harm and won't put any additional load on the AD since
  * none of the dn components have a bitmask-attribute.
  *
  * Thanks to Ralf Haferkamp for input and testing */

Guenther
(This used to be commit db38ed6be607d08515920d46fb8a12f8cb4ddd6e)

14 years agor11240: * fix invalid read reported by valgrind in the
Gerald Carter [Fri, 21 Oct 2005 02:14:23 +0000 (02:14 +0000)]
r11240: * fix invalid read reported by valgrind in the
  spoolss backchannel connection by rewriting
  spoolss_connect_to_client().  Ensure that we
  save the cli_state* in the rpc_pipe_client struct.

* fix typo in debug message in cli_start_connection"
(This used to be commit 18400f96628ffdd332c2fb2aa52b5e9aee5cb3ce)

14 years agor11237: Fix acl evaluation bug found by Marc Cousin <mcousin@sigma.fr>
Jeremy Allison [Thu, 20 Oct 2005 21:10:05 +0000 (21:10 +0000)]
r11237: Fix acl evaluation bug found by Marc Cousin <mcousin@sigma.fr>
We should only check the S_IWGRP permissions if we haven't already
seen an owning group SMB_ACL_GROUP_OBJ ace entry. If there is an
SMB_ACL_GROUP_OBJ ace entry then the group bits in st_gid are
the same as the SMB_ACL_MASK bits, not the SMB_ACL_GROUP_OBJ
bits. Thanks to Marc Cousin <mcousin@sigma.fr> for pointing
this out.
Jeremy.
(This used to be commit 7e1318e09bd4b155707020142b08776a546a646e)

14 years agor11236: Implement user rename for smbpasswd and ldap backends. Some cleanup on
Jim McDonough [Thu, 20 Oct 2005 20:40:47 +0000 (20:40 +0000)]
r11236: Implement user rename for smbpasswd and ldap backends.  Some cleanup on
tdb as well to make naming consistent.
(This used to be commit ee91eb9a39cc5e3edd9e97eb040e7557930e4e62)

14 years agor11235: fix segfault in addprinter due to mixing talloc() and malloc()'d memory
Gerald Carter [Thu, 20 Oct 2005 20:26:11 +0000 (20:26 +0000)]
r11235: fix segfault in addprinter due to mixing talloc() and malloc()'d memory
(This used to be commit f6f78877b485be5efd5cf1f3147b2e9fee647e52)

14 years agor11233: Forgot to add the statvfs file. Oops.
Jeremy Allison [Thu, 20 Oct 2005 18:15:44 +0000 (18:15 +0000)]
r11233: Forgot to add the statvfs file. Oops.
Jeremy.
(This used to be commit 797b9f47e98bed500dc3dd6ec8de51a0ec3e2bd7)

14 years agor11232: Added ab's POSIX statvfs vfs call. Sorry for the delay ab.
Jeremy Allison [Thu, 20 Oct 2005 17:33:17 +0000 (17:33 +0000)]
r11232: Added ab's POSIX statvfs vfs call. Sorry for the delay ab.
Jeremy.
(This used to be commit af8545806770a7530eecc184bdd230ca14999884)

14 years agor11230: Remove the '//' i was using to test something...oops
Jim McDonough [Thu, 20 Oct 2005 16:07:36 +0000 (16:07 +0000)]
r11230: Remove the '//' i was using to test something...oops
(This used to be commit cda5a81bbe52308a81a79eb0354aea63027a9701)

14 years agor11229: an even bigger speedup spotted by Volker. string_to_sid() is now taking...
Jim McDonough [Thu, 20 Oct 2005 16:05:12 +0000 (16:05 +0000)]
r11229: an even bigger speedup spotted by Volker.  string_to_sid() is now taking 1/5th
the time it used to.  Replace strcasecmp with invididual char checks for
"S-" sid prefix.
(This used to be commit de3d0094b78cb20da7ed958e8d3a428583694309)

14 years agor11228: Speed up string_to_sid by removing next_token calls, thus eliminating
Jim McDonough [Thu, 20 Oct 2005 15:09:41 +0000 (15:09 +0000)]
r11228: Speed up string_to_sid by removing next_token calls, thus eliminating
the need for allocating memory to duplicate the string.
(This used to be commit e5cc94f13ff2dacb219c8a56fa13853d620ecda6)

14 years agor11227: patch from brian moran to fix typo in eventlog message file registry value...
Gerald Carter [Thu, 20 Oct 2005 14:29:24 +0000 (14:29 +0000)]
r11227: patch from brian moran to fix typo in eventlog message file registry value name
(This used to be commit 34c3fd77b320d4fe5e0f1452aa09ea5ec2797494)

14 years agor11224: Add feature to get our configuration from config.log into installman.sh.
Lars Müller [Thu, 20 Oct 2005 12:58:40 +0000 (12:58 +0000)]
r11224: Add feature to get our configuration from config.log into installman.sh.
This allows us to install for example smbsh.1 only if SMBWRAPPER is set.

Removed also one rm call as we copy and do not append to the same file
in the next step.  There is no file permission risk as we chmod 0644 in
any case later.

Replaced one basename call by shell substitution.
(This used to be commit 3944dfbff4f7f951d35e7893f7ab56ed2e9d76b0)

14 years agor11213: Fix the build
Günther Deschner [Thu, 20 Oct 2005 08:13:00 +0000 (08:13 +0000)]
r11213: Fix the build

Guenther
(This used to be commit 908ac0c9eccd1ba368a6305fee9673770fc74a53)

14 years agor11190: Fix enhancement request #3192.
Jeremy Allison [Wed, 19 Oct 2005 20:02:12 +0000 (20:02 +0000)]
r11190: Fix enhancement request #3192.
This does 2 things.
1). Makes dfree command a per-share parameter (it should be anyway IMHO).
2). Adds a "dfree cache time" parameter in seconds that specifies how long a
dfree command output should be cached for. Default is zero (no caching).
Jeremy.
(This used to be commit 49ef8b88a3e12883148eb28d8e86fb07dbc3d12d)

14 years agor11183: add small helper function to return a PAC_LOGON_INFO.
Günther Deschner [Wed, 19 Oct 2005 14:34:17 +0000 (14:34 +0000)]
r11183: add small helper function to return a PAC_LOGON_INFO.

Guenther
(This used to be commit a8d5d6b845efb62e73e281549528376f3ee74211)

14 years agor11170: root free pass on eventlog open access check
Gerald Carter [Wed, 19 Oct 2005 02:50:45 +0000 (02:50 +0000)]
r11170: root free pass on eventlog open access check
(This used to be commit 4e3ff41e1ee2e3c323814fd8c6aa44ecab412257)

14 years agor11169: removing duplicate 'map read only' entry
Gerald Carter [Tue, 18 Oct 2005 22:50:24 +0000 (22:50 +0000)]
r11169: removing duplicate 'map read only' entry
(This used to be commit 0e60813ed0d5c56c44a371d84275d1944bade770)

14 years agor11167: -lsec should be include in $ACL_LIBS and not $LIBS on solaris
Gerald Carter [Tue, 18 Oct 2005 21:24:42 +0000 (21:24 +0000)]
r11167: -lsec should be include in $ACL_LIBS and not $LIBS on solaris
(This used to be commit 056bf816284a473b8419fccf62a54813317043b7)

14 years agor11166: missed a specfile fix for redhat
Gerald Carter [Tue, 18 Oct 2005 21:22:49 +0000 (21:22 +0000)]
r11166: missed a specfile fix for redhat
(This used to be commit 178016e7a7e470406ee4e35dcb53fa8d0a2d1c19)

14 years agor11165: deparate the library install commands from the logic of whether to build...
Gerald Carter [Tue, 18 Oct 2005 19:34:42 +0000 (19:34 +0000)]
r11165: deparate the library install commands from the logic of whether to build the library at all.  Still needs some more cleanup but this works for now
(This used to be commit df998bfa8e00a736250eb5a7b31ed53abd6a4241)

14 years agor11164: solaris packaging fixes
Gerald Carter [Tue, 18 Oct 2005 19:32:19 +0000 (19:32 +0000)]
r11164: solaris packaging fixes
(This used to be commit 6a7b8d0d7d071c8f52f9b24f94d488a9ce191e93)

14 years agor11163: fix installation of libmsrpc
Gerald Carter [Tue, 18 Oct 2005 18:55:29 +0000 (18:55 +0000)]
r11163: fix installation of libmsrpc
(This used to be commit 2f94df322232ace14cddc8e24c8949a5ed1fad32)

14 years agor11161: another regression from merge; make sure to build vfs_full_audit modulebranch...
Gerald Carter [Tue, 18 Oct 2005 18:26:43 +0000 (18:26 +0000)]
r11161: another regression from merge; make sure to build vfs_full_audit modulebranches/SAMBA_3_0_RELEASE/source/configure.in
(This used to be commit 19e0e48ce09eebc21b800b6ecf13c6f42dfe27f3)

14 years agor11159: Added some const to fix warnings.
Jeremy Allison [Tue, 18 Oct 2005 18:17:45 +0000 (18:17 +0000)]
r11159: Added some const to fix warnings.
Jeremy.
(This used to be commit de27b0eef2eb021f28e8bf300c4dd524e30fc7ed)

14 years agor11158: more RedHat spec file fixes; I think this is the last one for 3.0.21pre1
Gerald Carter [Tue, 18 Oct 2005 18:12:42 +0000 (18:12 +0000)]
r11158: more RedHat spec file fixes; I think this is the last one for 3.0.21pre1
(This used to be commit 2a19033c14adc304ff6b63c248841bab340ba19b)

14 years agor11156: Remove valgrind disabling ifdef that got added by mistake.
Jeremy Allison [Tue, 18 Oct 2005 18:08:23 +0000 (18:08 +0000)]
r11156: Remove valgrind disabling ifdef that got added by mistake.
Jeremy.
(This used to be commit fc9eca51e02022ccffbad2a4f2450f85e558e151)

14 years agor11155: Remove warning in torturous logic.
Jeremy Allison [Tue, 18 Oct 2005 18:02:37 +0000 (18:02 +0000)]
r11155: Remove warning in torturous logic.
Jeremy.
(This used to be commit c7373b39bae6dca8281d45d1ff3f2161465838df)

14 years agor11152: fix some regressions caused by the trunk->3.0 merge when install docs with...
Gerald Carter [Tue, 18 Oct 2005 17:20:50 +0000 (17:20 +0000)]
r11152: fix some regressions caused by the trunk->3.0 merge when install docs with SWAT
(This used to be commit e3c68738663701fde21baef03c36de303e7f1636)

14 years agor11150: fix solaris acl linking problem on sunos5.9; not quite sure how this got...
Gerald Carter [Tue, 18 Oct 2005 16:05:34 +0000 (16:05 +0000)]
r11150: fix solaris acl linking problem on sunos5.9; not quite sure how this got broken
(This used to be commit 490dbc64f7ae2006624039da6b450ba4aca56dd4)

14 years agor11147: Fedora packaging fixes for libmsrpc
Gerald Carter [Tue, 18 Oct 2005 15:50:33 +0000 (15:50 +0000)]
r11147: Fedora packaging fixes for libmsrpc
(This used to be commit b4af105b859c0e20c89c3d8a12f1b30f85583312)

14 years agor11137: Compile with only 2 warnings (I'm still working on that code) on a gcc4
Jeremy Allison [Tue, 18 Oct 2005 03:24:00 +0000 (03:24 +0000)]
r11137: Compile with only 2 warnings (I'm still working on that code) on a gcc4
x86_64 box.
Jeremy.
(This used to be commit d720867a788c735e56d53d63265255830ec21208)

14 years agor11136: patches from Brian Moran for eventlogadm utility
Gerald Carter [Tue, 18 Oct 2005 03:21:59 +0000 (03:21 +0000)]
r11136: patches from Brian Moran for eventlogadm utility
(This used to be commit 47b626a8f72629fd1bbabf35b68e24d202df2555)

14 years agor11135: should fix seg fault in addprinter code reported by Marcin. Allocate memory...
Gerald Carter [Tue, 18 Oct 2005 02:37:13 +0000 (02:37 +0000)]
r11135: should fix seg fault in addprinter code reported by Marcin.  Allocate memory in convert_printer_info() if necessary
(This used to be commit 7ada5da8e94a08a9a3e488172fa04ce688882299)

14 years agor11133: updating maintainers file
Gerald Carter [Tue, 18 Oct 2005 02:36:01 +0000 (02:36 +0000)]
r11133: updating maintainers file
(This used to be commit 57b038c630ad2008814ccde917886f30c8a73ac1)

14 years agor11131: updating indent resource file from trunk
Gerald Carter [Tue, 18 Oct 2005 02:33:07 +0000 (02:33 +0000)]
r11131: updating indent resource file from trunk
(This used to be commit 6f32785bcdb99a630e7c94e3f03275c1ca324b11)

14 years agor11130: r10092@cabra: derrell | 2005-10-17 15:29:03 -0400
Derrell Lipman [Mon, 17 Oct 2005 19:29:11 +0000 (19:29 +0000)]
r11130:  r10092@cabra:  derrell | 2005-10-17 15:29:03 -0400
 let's now actually add the new test file
(This used to be commit b58237f98d924752a45f689d7a9fd2e8e447c100)

14 years agor11129: r10090@cabra: derrell | 2005-10-17 15:26:27 -0400
Derrell Lipman [Mon, 17 Oct 2005 19:27:19 +0000 (19:27 +0000)]
r11129:  r10090@cabra:  derrell | 2005-10-17 15:26:27 -0400
 added example to read a file and test download time
(This used to be commit 4fad0c49b5bf7819d0f9782b60369c5d078c5854)

14 years agor11127: patch from S Murthy Kambhampaty <smk_va@yahoo.com> to not start nmbd is ...
Gerald Carter [Mon, 17 Oct 2005 17:10:44 +0000 (17:10 +0000)]
r11127: patch from S Murthy Kambhampaty <smk_va@yahoo.com> to not start nmbd is 'disable netbios = yes'
(This used to be commit decaf8da598b09ea4c5382dc1f6c4be1664e20c7)