21 years agoMove the bang (!) command back to the bottom of the list, allowing smbclient
Andrew Bartlett [Thu, 17 Jan 2002 07:14:21 +0000 (07:14 +0000)]
Move the bang (!) command back to the bottom of the list, allowing smbclient
to function again.

Add comment to warn anybody that wants to 'Alphabetize' the list to read crh's
existing comment on the issue.

Andrew Bartlett
(This used to be commit d123d79060caf3ad084e733dac02aa2f67bda35f)

21 years agoMade a debug look nicer.
Tim Potter [Thu, 17 Jan 2002 05:07:36 +0000 (05:07 +0000)]
Made a debug look nicer.
(This used to be commit aca0edc819e892944c65b3feb60250994a79e88a)

21 years agoAdded some guards.
Tim Potter [Thu, 17 Jan 2002 03:03:58 +0000 (03:03 +0000)]
Added some guards.
(This used to be commit 967c68858001cd620d2524d56180497c4b479c6b)

21 years agoFixed typo.
Tim Potter [Thu, 17 Jan 2002 02:54:23 +0000 (02:54 +0000)]
Fixed typo.
(This used to be commit e675d34dbfe1435150faf5af4bb97f01d311f5b0)

21 years agonew config files for winbindd startup
Herb Lewis [Thu, 17 Jan 2002 01:18:13 +0000 (01:18 +0000)]
new config files for winbindd startup
(This used to be commit 4ab2a775438f4266d270c626a9ad547c97c4eb62)

21 years agofixed a typo in the error map for WRONG_PASSWORD
Andrew Tridgell [Thu, 17 Jan 2002 01:05:34 +0000 (01:05 +0000)]
fixed a typo in the error map for WRONG_PASSWORD
(This used to be commit fb300e411bb385dcba2c3ca166598a71ed693b35)

21 years agodon't use O_NONBLOCK in open(). This was added erroneously for kernel
Andrew Tridgell [Thu, 17 Jan 2002 00:25:13 +0000 (00:25 +0000)]
don't use O_NONBLOCK in open(). This was added erroneously for kernel
oplocks and really shouldn't be used
(This used to be commit c3a83002cfc2e0b5158cae1898eda8bafcb41e48)

21 years agoSeparate out get_user_home_dir() from get_user_home_service_dir().
Jeremy Allison [Wed, 16 Jan 2002 23:53:10 +0000 (23:53 +0000)]
Separate out get_user_home_dir() from get_user_home_service_dir().
(This used to be commit c1b97226db63daf64359e79083a4754e7c7f8054)

21 years agoMerged in %S fixes and XX_NOT_CHANGED fixes from 2.2.
Jeremy Allison [Wed, 16 Jan 2002 23:32:10 +0000 (23:32 +0000)]
Merged in %S fixes and XX_NOT_CHANGED fixes from 2.2.
(This used to be commit 0fcca6c627a5c9c2219ec9714df5e0bc1a44cc29)

21 years agoFixup error mapping so we have only one table containing errno -> dos error -> NT...
Jeremy Allison [Wed, 16 Jan 2002 21:27:57 +0000 (21:27 +0000)]
Fixup error mapping so we have only one table containing errno -> dos error -> NT STATUS
maps. Fixes problem with disk full returning incorrect error.
(This used to be commit 16fcbf3c1ccf1d704765653f68395dd596c0d841)

21 years agoAlphabetize.
Jeremy Allison [Wed, 16 Jan 2002 20:25:23 +0000 (20:25 +0000)]
(This used to be commit 64301bc5f75283c948630d2b78d28e3869db39a2)

21 years agoAdded CIFS UNIX extension code to client.
Jeremy Allison [Wed, 16 Jan 2002 20:13:28 +0000 (20:13 +0000)]
Added CIFS UNIX extension code to client.
(This used to be commit 794c3e2c76aae57d054e46b185def104ca02977c)

21 years agoFix name register bug with non-existent wins server.
Jeremy Allison [Wed, 16 Jan 2002 19:23:05 +0000 (19:23 +0000)]
Fix name register bug with non-existent wins server.
(This used to be commit 4e41780c21d9a6c056104f952e720a79c830c65e)

21 years agoAt leadt don't lose this - I need to re-sync trans2.c between 2.2.x and
Jeremy Allison [Wed, 16 Jan 2002 02:42:47 +0000 (02:42 +0000)]
At leadt don't lose this - I need to re-sync trans2.c between 2.2.x and
HEAD soon.
(This used to be commit 2f57257558b67b4a5106fece269ce55643464683)

21 years agoRoll back PSTRING_SANCTIFY patch; just leave non-controversial type
Martin Pool [Wed, 16 Jan 2002 02:42:07 +0000 (02:42 +0000)]
Roll back PSTRING_SANCTIFY patch; just leave non-controversial type
and constness changes.
(This used to be commit cee0ec72746122c962e6c5278a736266a7f2c424)

21 years agoQuieten some pointer cast warnings.
Tim Potter [Wed, 16 Jan 2002 02:31:53 +0000 (02:31 +0000)]
Quieten some pointer cast warnings.
(This used to be commit 1906903f063de526045be68d19cf39de3c029c6f)

21 years agomuch better support for organisational units in ADS join
Andrew Tridgell [Wed, 16 Jan 2002 02:22:30 +0000 (02:22 +0000)]
much better support for organisational units in ADS join
(This used to be commit 7e876057d5e392f85e6fdb0f2c233b0fe76df688)

21 years agoRoll back PSTR insertion.
Martin Pool [Wed, 16 Jan 2002 02:20:34 +0000 (02:20 +0000)]
Roll back PSTR insertion.

Just leave the fstrcpy/pstrcpy bugfix, and conversion to pstr_sprintf
rather than manual calculation of length.
(This used to be commit e38e7a2bdcf2901359035ac4aa79ebf33599e0c8)

21 years agoMerge of name_status_find() debugs.
Tim Potter [Wed, 16 Jan 2002 01:41:30 +0000 (01:41 +0000)]
Merge of name_status_find() debugs.
(This used to be commit cfac669017afa763100e335d1516fbed18049e00)

21 years agoFix from 2.2. It didn't break on HEAD because it isn't being compiled. Herb?
Jim McDonough [Tue, 15 Jan 2002 17:58:59 +0000 (17:58 +0000)]
Fix from 2.2.  It didn't break on HEAD because it isn't being compiled.  Herb?
(This used to be commit 4fcaec53de18220ff6662f62a1430f67757cdcc5)

21 years agoMissing assign fix from Bernt Nilsson
Jeremy Allison [Tue, 15 Jan 2002 16:20:25 +0000 (16:20 +0000)]
Missing assign fix from Bernt Nilsson
(This used to be commit adf24a90e8b4d970d71fa8a6854edcf6deff9688)

21 years agoFor some reason I wasn't thinking about failure cases this morning...
Andrew Bartlett [Tue, 15 Jan 2002 05:15:22 +0000 (05:15 +0000)]
For some reason I wasn't thinking about failure cases this morning...

Anyway, this makes it slightly sane, but we may decide to smb_panic() here

Andrew Bartlett
(This used to be commit 724109a33bf2f06bcb97cdd31c0442c6035ff6a6)

21 years agoConvert to the new pstring interface. This diff is a pretty good
Martin Pool [Tue, 15 Jan 2002 02:15:58 +0000 (02:15 +0000)]
Convert to the new pstring interface.  This diff is a pretty good
example of the scope of change the new pstrings would entail:
basically inserting PSTR() or FSTR() everywhere you need to coerce one
to a char*.

It's also a good example of the kind of bug we might catch: on about
line 540, we were doing a pstrcpy into an fstring, which might
overflow.  It's not a problem in this particular case, but it is in
(This used to be commit 5a403da4a735a8fb8d118a0a67f3a15127152e18)

21 years agoSplit pstring definitions into their own header.
Martin Pool [Tue, 15 Jan 2002 02:11:55 +0000 (02:11 +0000)]
Split pstring definitions into their own header.
(This used to be commit 04e3082f7d45c1b304adff5a46106136cff0e09e)

21 years agoIntegrate with PSTRING_SANCTIFY.
Martin Pool [Tue, 15 Jan 2002 02:10:50 +0000 (02:10 +0000)]
Integrate with PSTRING_SANCTIFY.
(This used to be commit 20a03facb6acf6329acc1645d4e9ead863a1a57c)

21 years ago#ifdef variable that's not used without dmalloc
Martin Pool [Tue, 15 Jan 2002 01:49:06 +0000 (01:49 +0000)]
#ifdef variable that's not used without dmalloc
(This used to be commit bf513668cb76fd20b04b8142c86c263280b05bb6)

21 years agoAdd constness to parameters
Martin Pool [Tue, 15 Jan 2002 01:45:26 +0000 (01:45 +0000)]
Add constness to parameters
(This used to be commit e0105974c06e210e7565555d4b673c484de32907)

21 years agoadding wins commands to winbindd - will check in the rest of the changes
Herb Lewis [Tue, 15 Jan 2002 01:42:57 +0000 (01:42 +0000)]
adding wins commands to winbindd - will check in the rest of the changes
after further testing in 2.2 branch.
(This used to be commit d5cdbc7e4ff48273bd7616694eef98c61e6f1f33)

21 years agoAdd constness to parameters
Martin Pool [Tue, 15 Jan 2002 01:38:05 +0000 (01:38 +0000)]
Add constness to parameters
(This used to be commit a61abaec063d00afe13ce0baa356245fb6e21bc0)

21 years agoAdd constness to filenames passed to functions.
Martin Pool [Tue, 15 Jan 2002 01:37:12 +0000 (01:37 +0000)]
Add constness to filenames passed to functions.
(This used to be commit 8d106dc1f4a51112516d72ae68747ca6b5b904b7)

21 years agoCommit the auth associated changes I missed from the last commit.
Andrew Bartlett [Tue, 15 Jan 2002 01:14:58 +0000 (01:14 +0000)]
Commit the auth associated changes I missed from the last commit.

Also set the default value of all the allocated strings to "" to avoid changing
the interface (becouse pdb_get...() would point to a null string, rather than a
null pointer and parts of samba rely on that).

Andrew Bartlett
(This used to be commit 5b4079f748e25f21162e21b439063249baf8dca6)

21 years agoChange the passdb interface to use allocated strings.
Andrew Bartlett [Tue, 15 Jan 2002 01:02:13 +0000 (01:02 +0000)]
Change the passdb interface to use allocated strings.

These strings are allocated using talloc(), either using its own memory context
stored on the SAM_ACCOUNT or one supplied by the caller.

The pdb_init_sam() and pdb_free_sam() function have been modifed so that a call
to pdb_free_sam() will either clean up (remove hashes from memory) and destroy
the TALLOC_CTX or just clean up depending on who supplied it.

The pdb_init_sam and pdb_free_sam functions now also return an NTSTATUS, and I
have modified the 3 places that actually checked these returns.

The only nasty thing about this patch is the small measure needed to maintin
interface compatability - strings set to NULL are actually set to "".

This is becouse there are too many places in Samba that do strlen() on these
strings without checking if they are NULL pointers.

A supp patch will follow to set all strings to "" in pdb_default_sam().

Andrew Bartlett
(This used to be commit 144345b41d39a6f68d01f62b7aee64ca0d328085)

21 years agorerun autoconf
Andrew Bartlett [Mon, 14 Jan 2002 22:11:44 +0000 (22:11 +0000)]
rerun autoconf
(This used to be commit d6bd9f1005496753333c3d8dec5e1a8069f1ce7b)

21 years agoI like --enable-developer, but I find it rather usless when all it gets me is a
Andrew Bartlett [Mon, 14 Jan 2002 22:11:01 +0000 (22:11 +0000)]
I like --enable-developer, but I find it rather usless when all it gets me is a
screen-full of kerberos warnings.

This is almost as good, and I can actually see the Samba warnings.

Andrew Bartlett
(This used to be commit 35a6275e186cbd7b1f2190265b47112f1d082c06)

21 years agoInitialise cli variables and try not to do a cli_shutdown() of uninitialsed
Andrew Bartlett [Mon, 14 Jan 2002 22:08:47 +0000 (22:08 +0000)]
Initialise cli variables and try not to do a cli_shutdown() of uninitialsed

The winbind connection caching code isn't exactly a plesent beast, and there is
more work that needs to be done to nail this properly.

Andrew Bartlett
(This used to be commit dd40ce54b7f170854d63e08ac737f1b4306bd95b)

21 years agoFix a segfault in auth/auth_domain.c error cases.
Andrew Bartlett [Mon, 14 Jan 2002 21:52:25 +0000 (21:52 +0000)]
Fix a segfault in auth/auth_domain.c error cases.

This occured when the attempt to contact the PDC failed.  The connection code
has already shut down the connection, and 'free'ed the cli or has never
initialised it in the first place.

Andrew Bartlett
(This used to be commit 37ce7630434c1afae5164c64438f428dd8e1b731)

21 years agoRemoved MAXSTATUS which was set incorrectly - thus causing tdb traversal
Jeremy Allison [Mon, 14 Jan 2002 19:34:28 +0000 (19:34 +0000)]
Removed MAXSTATUS which was set incorrectly - thus causing tdb traversal
of the connections db on smbd startup. This should fix the Solaris large
load bug.... (fingers crossed).
(This used to be commit 5b2b9c25af28543e67762805d1387524cbb6c39d)

21 years agoFIXME We should turn the global list off when using Insure++,
Martin Pool [Mon, 14 Jan 2002 06:51:34 +0000 (06:51 +0000)]
FIXME We should turn the global list off when using Insure++,
otherwise all the memory will be seen as still reachable.
(This used to be commit 682e7cd394c1e1cc9a83f7e8e5e3694e083946c4)

21 years agoMove local variable to avoid warning when compiled without GSSAPI.
Martin Pool [Mon, 14 Jan 2002 06:34:53 +0000 (06:34 +0000)]
Move local variable to avoid warning when compiled without GSSAPI.
(This used to be commit 312c6d906e64d231ff3c2f37e61d752cc948ee7b)

Martin Pool [Mon, 14 Jan 2002 06:15:07 +0000 (06:15 +0000)]

If you define this, pstring and fstring become distinguished types, so
that it's harder to accidentally overflow them by for example passing
an fstring on the lhs of pstrcpy.

The types are defined as one-element union arrays so that with
"fstring f" the name "f" will be a pointer and with a big hammer you
can cast it to (char *).  So code that tries to just use it directly
will get a loud warning, but hopefully nothing worse.

To pass them to non-pstring-aware functions, use PSTR and check that
the function takes a const.  They should almost never be modified
except by special calls.  In those unusual cases, use PSTR_MUTABLE.

This is off by default so as not to produce too many warnings.  As the
code is vetted it can become the default.
(This used to be commit ca233bc8b30d7d0626039b2769c4e1ae92dafd50)

21 years agoRemoved fprintf(stderr, ...); calls which should not be present in library
Tim Potter [Mon, 14 Jan 2002 02:22:31 +0000 (02:22 +0000)]
Removed fprintf(stderr, ...); calls which should not be present in library
(This used to be commit e69a22290e5c923f31223906461df4874e3b2aac)

21 years agoA couple of coding syle updates to follow the re-indent.
Andrew Bartlett [Sun, 13 Jan 2002 12:37:01 +0000 (12:37 +0000)]
A couple of coding syle updates to follow the re-indent.
(This used to be commit 7417d6f9310188d2ad3d8f41d3dcbe55862c72ac)

21 years agoRe-indent these two functions to make it actually possible to understand their
Andrew Bartlett [Sun, 13 Jan 2002 12:33:42 +0000 (12:33 +0000)]
Re-indent these two functions to make it actually possible to understand their

Andrew Bartlett
(This used to be commit e20d69d51862ea3fd5a7317a9592bd4dc6e68bfd)

21 years agodon't try to allocate zero bytes
Andrew Tridgell [Sun, 13 Jan 2002 11:46:04 +0000 (11:46 +0000)]
don't try to allocate zero bytes
(This used to be commit d09616da6823b69a03a8a008987c4eb02ca0061b)

21 years agoI'm doing some things towards the NamedPipes game with lckl and he has asked me
Andrew Bartlett [Sun, 13 Jan 2002 11:13:54 +0000 (11:13 +0000)]
I'm doing some things towards the NamedPipes game with lckl and he has asked me
to move this from being a static to matching its mate in lib/util_sock.c.

In any case, this should discorage anybody from using the 'wrong' version of
this function.  (ie the one from TNG, which needs a bit more error checking
depending on use).

Andrew Bartlett
(This used to be commit e6a3a01f795a85d908180ff19469ce09a2803512)

21 years agoMany thanks to Alexander Bokovoy <>.
Andrew Bartlett [Sat, 12 Jan 2002 23:57:10 +0000 (23:57 +0000)]
Many thanks to Alexander Bokovoy <>.
This work was sponsored by Optifacio Software Services, Inc.

Andrew Bartlett

(various e-mails announcements merged into some form of commit message below:)

This patch which adds basics of universal groups support
into Samba 3. Currently, only Winbind with RPC calls supports this, ADS
support requires additional (possibly huge) work on KRB5 PAC. However,
basic infrastructure is here.

This patch adds:

1. Storing of universal groups for particular user logged into Samba
software (smbd/ two winbind-pam methods) into netlogon_unigrp.tdb as array
of uint32 supplemental group rids keyed as DOMAIN_SID/USER_RID in tdb.

2. Fetching of unversal groups for given user rid and domain sid from

Since this is used in both smbd and winbindd, main code is in
source/lib/netlogon_uingrp.c. Dependencies are added to AUTH_OBJ as

This patch has had a few versions, the final version in particular:

Many thanks to Andrew Bartlett for critics and comments, and partly
rewritten code.

- updated fetching code to changed byte order macros
- moved functions to proper namespace
- optimized memory usage by reusing caller's memory context
- enhanced code to more follow Samba coding rules

- proper universal group expiration after timeout
(This used to be commit 80c2aefbe7c1aa363dd286a47d50c5d8b4595f43)

21 years agoupdates from 2.2
Simo Sorce [Sat, 12 Jan 2002 23:12:13 +0000 (23:12 +0000)]
updates from 2.2
(This used to be commit 398b4ff0d40d89b3e96d481807f85f15b7a7966a)

21 years agoAdded PRINTER_INFO_4/PRINTER_INFO_5, we're seeing level 5 requested on the wire....
Jeremy Allison [Sat, 12 Jan 2002 02:37:54 +0000 (02:37 +0000)]
Added PRINTER_INFO_4/PRINTER_INFO_5, we're seeing level 5 requested on the wire... so.
(This used to be commit b63b76297835ab8227b98925fa8120ffce1a37d9)

21 years agoThanks to vance for spotting the missing commit.
Andrew Bartlett [Sat, 12 Jan 2002 02:06:17 +0000 (02:06 +0000)]
Thanks to vance for spotting the missing commit.

This should make things a little happier...

Andrew Bartlett
(This used to be commit 6ce467a65fdaabbcfac258a1b899c833602b6d92)

21 years agoMove all the pdb_get...() and pdb_set...() functions to a new file.
Andrew Bartlett [Sat, 12 Jan 2002 01:55:09 +0000 (01:55 +0000)]
Move all the pdb_get...() and pdb_set...() functions to a new file.

This brings passdb.c down to a much more manageable ~1100 lines and makes it a
little easier to comprehend whats going on here.

Andrew Bartlett
(This used to be commit 28d5ab269cfba5e8410163edb3e0c222ed7f0be1)

21 years agoAdded the O_NOFOLLOW flag if follow symlinks is set off.
Jeremy Allison [Sat, 12 Jan 2002 00:50:01 +0000 (00:50 +0000)]
Added the O_NOFOLLOW flag if follow symlinks is set off.
(This used to be commit 4f1f5f28b514dda86f6f49465bd5887357e37bc6)

21 years agoRound and round we go....
Jeremy Allison [Fri, 11 Jan 2002 23:33:12 +0000 (23:33 +0000)]
Round and round we go....
(This used to be commit 2603ab3c6870f3697751b887e940910713f08985)

21 years agoLatest attempt at changeid.
Jeremy Allison [Fri, 11 Jan 2002 21:52:46 +0000 (21:52 +0000)]
Latest attempt at changeid.
(This used to be commit 24ee18c77e1b61004d8ed817118a481f3d43e34c)

21 years agoSame fix as went into 2.2 (I'm waiting for jerry to finish some code).
Jeremy Allison [Fri, 11 Jan 2002 19:10:25 +0000 (19:10 +0000)]
Same fix as went into 2.2 (I'm waiting for jerry to finish some code).
(This used to be commit 01ff6ce4963e1daff019f2b936cef218e1c93f67)

21 years agofixed a crash bug in domain auth caused by an uninitialised nt_status
Andrew Tridgell [Fri, 11 Jan 2002 13:14:28 +0000 (13:14 +0000)]
fixed a crash bug in domain auth caused by an uninitialised nt_status
(This used to be commit 0b0b937b58f4bf4e005fb622f0db19175fc46a47)

21 years agofixed a crash in merge_aces()
Andrew Tridgell [Fri, 11 Jan 2002 11:26:31 +0000 (11:26 +0000)]
fixed a crash in merge_aces()
when we free curr_ace_outer we need to not try to use it again :)
(This used to be commit 1c5e19a418136c0ae524e62a4907501212ebac3d)

21 years agoforce the time difference in cache comparisons to be unsigned to cope
Andrew Tridgell [Fri, 11 Jan 2002 10:05:34 +0000 (10:05 +0000)]
force the time difference in cache comparisons to be unsigned to cope
with the local machine time changing
(This used to be commit 116c0a0e3baa6a100a816f1ff2722782941ac3dc)

21 years agomake the winbind sequence number code more robust
Andrew Tridgell [Fri, 11 Jan 2002 10:02:28 +0000 (10:02 +0000)]
make the winbind sequence number code more robust

when switching from rpc to ADS this now should make sense
(This used to be commit ec73d26c7f9a2bbd4b91e9c22850e032b91666e2)

21 years agocope with direct IP addresses in resolve_name()
Andrew Tridgell [Fri, 11 Jan 2002 09:48:27 +0000 (09:48 +0000)]
cope with direct IP addresses in resolve_name()
(This used to be commit 73a59170e6fab3b0f91938a74302750915a04a7a)

21 years agopreparing for release of 3.0-alpha13
Samba Release Account [Fri, 11 Jan 2002 08:48:49 +0000 (08:48 +0000)]
preparing for release of 3.0-alpha13
(This used to be commit 4f4f898348c5719b745ff358463fd7d59e3da495)

21 years agoMake this error match Win2k.
Andrew Bartlett [Fri, 11 Jan 2002 07:48:55 +0000 (07:48 +0000)]
Make this error match Win2k.
(This used to be commit 490d3aaf20f04d04c91c4748896d7a021581a229)

21 years agoThe DC is meant to be sent the *unmapped* username...
Andrew Bartlett [Fri, 11 Jan 2002 06:22:42 +0000 (06:22 +0000)]
The DC is meant to be sent the *unmapped* username...

Andrew Bartlett
(This used to be commit d7fca1806a304cb6eeecfe34d6c5c012c745114f)

21 years agoAlways query the PDC for the list of trusted domains rather than interating
Tim Potter [Fri, 11 Jan 2002 05:33:45 +0000 (05:33 +0000)]
Always query the PDC for the list of trusted domains rather than interating
the list received at startup or we get an out of date list.  I thought
there might be some sequence number that is incremented when a trusted
domain is added or removed - perhaps there is but I just haven't found it

 - Renamed get_domain_info() to init_domain_list()

 - Made an accessor function to return the list of trusted domains rather
   than using a global so we don't have to remember to put a magic init

 - The getent state can not keep a pointer to a winbind_domain structure as
   it may be freed if init_domain_list() is called again so we keep the
   domain name instead
(This used to be commit 37216c649a394b449eaaaa6644709eafb3bf37ff)

21 years agoBack out the crazy notion that the NTLMSSP flags actually mean anything...
Andrew Bartlett [Fri, 11 Jan 2002 05:29:09 +0000 (05:29 +0000)]
Back out the crazy notion that the NTLMSSP flags actually mean anything...

Replace this with some flags that *we* define.  We can do a mapping later
if we actually get some more reliable info about what passwords are actually

Andrew Bartlett
(This used to be commit 7f7a42c3e4d5798ac87ea16a42e4976c3778a76b)

21 years agoCorrect4ed comment.
Tim Potter [Fri, 11 Jan 2002 05:14:52 +0000 (05:14 +0000)]
Correct4ed comment.
(This used to be commit 78814664ef7d41c2f6637b508711ab45647a64f9)

21 years agoFix up 'net ads join' to delete and rejoin if the account already exists.
Andrew Bartlett [Fri, 11 Jan 2002 04:50:45 +0000 (04:50 +0000)]
Fix up 'net ads join' to delete and rejoin if the account already exists.

This fixes up a problem where a machine would join (or downgrade by trust
password change) to NT4 membership and not be able to regain full ADS
membership until a 'net ads leave'.

Andrew Bartlett
(This used to be commit ab8ff85f03b25a0dfe4ab63886a10da81207393c)

21 years agoSome memory leak fixes.
Tim Potter [Fri, 11 Jan 2002 03:49:51 +0000 (03:49 +0000)]
Some memory leak fixes.
(This used to be commit da4db0373b65d975d5129715d6b1fa725b188766)

21 years agocommit some changes for ab, and keep working on the smbgroupedit
Gerald Carter [Fri, 11 Jan 2002 00:41:27 +0000 (00:41 +0000)]
commit some changes for ab, and keep working on the smbgroupedit
(This used to be commit a10cdbfbed4e04609f511cbbf976df4b4d391729)

21 years agomake sure resolve_name() only returns valid IP addresses
Andrew Tridgell [Fri, 11 Jan 2002 00:23:29 +0000 (00:23 +0000)]
make sure resolve_name() only returns valid IP addresses
this is actually a workaround for old broken nmbd daemons, especially
from Samba 2.0
(This used to be commit 12021a8de6a1dc2e43cc62f094a57c57283dfaf4)

21 years agoSince AB has been changing the winbind interface it's time to add the "mock
Tim Potter [Thu, 10 Jan 2002 23:45:29 +0000 (23:45 +0000)]
Since AB has been changing the winbind interface it's time to add the "mock
swedish" test to client calls.  This is putting a length field at the
start of a request so we can disconnect clients talking with an out of date rather than deadlock them.

Misc cleanups:

 - made some int values uint32
 - moved WINBIND_INTERFACE_VERSION to start of cmd list
(This used to be commit a4af65b9b93671f13f277d49279a85042a8fd1d5)

21 years agoadded structure members referred to by recent changes in vfs-wrap.c
Herb Lewis [Thu, 10 Jan 2002 19:40:40 +0000 (19:40 +0000)]
added structure members referred to by recent changes in vfs-wrap.c
(This used to be commit c5e14d73dffee86ef2dabcf7031eea0da9e32f3d)

21 years agomerge tpots name changes into IRIX part of code. When you change the name
Herb Lewis [Thu, 10 Jan 2002 18:49:37 +0000 (18:49 +0000)]
merge tpots name changes into IRIX part of code. When you change the name
of a define you need to grep for the old name and change ALL places.
(This used to be commit 09e3276fb7207dff73f181072851bd542fb64263)

21 years agoTake a stab at keeping the doco current :-)
Andrew Bartlett [Thu, 10 Jan 2002 12:32:59 +0000 (12:32 +0000)]
Take a stab at keeping the doco current :-)
(This used to be commit 88b0e670426c216d754716dc6095b673b9645f1a)

21 years agoReturn the winbind separator over the socket, so programs don't have to parse
Andrew Bartlett [Thu, 10 Jan 2002 11:28:14 +0000 (11:28 +0000)]
Return the winbind separator over the socket, so programs don't have to parse
smb.conf to get it right.

While wb_client needs its lp_load() for samba dependency reasons, it now uses
the new method both to example and test the new code.

Also add an interface version function, and return the winbind's samba version

In preperation for default domains, its now up to winbindd to reject plaintext
auths that don't have a seperator, but NTLM (CRAP) auths now have two feilds,
hence need parsing.

Andrew Bartlett
(This used to be commit 2bd2a092ee3d49a74d896385688d7c7256aa297e)

21 years agoThis changes the winbind protcol a bit:
Andrew Bartlett [Thu, 10 Jan 2002 10:23:54 +0000 (10:23 +0000)]
This changes the winbind protcol a bit:

It adds a 'ping' request, just to check winbind is in fact alive

It also changes winbindd_pam_auth_crap to take usernames and domain seperatly.

(backward incompatible change, needs merge to 2.2, but this is not yet released
code, so no workarounds)

Finally, it adds some debugs and fixes a few memory leaks (uses talloc to do

Andrew Bartlett
(This used to be commit 6df29bfe335144a968f5367f624ef2b4cf9e69b0)

21 years agoQuieten warning about uninitialized variable.
Martin Pool [Thu, 10 Jan 2002 06:32:01 +0000 (06:32 +0000)]
Quieten warning about uninitialized variable.
(This used to be commit 63ea2bb0adf5ae742658f479613de90b1eec3db5)

21 years agoA big tidyup while thinking about getting trusted domains being re-read
Tim Potter [Thu, 10 Jan 2002 06:20:03 +0000 (06:20 +0000)]
A big tidyup while thinking about getting trusted domains being re-read
when they are added or removed on the PDC.

 - renamed GETPWNAM_FROM_{UID,USER} constants and functions to GETPW{NAM,UID}

 - renamed GETGRNAM_FROM_{GID,GROUP} constants and functions to GETGR{NAM,GID}

 - use SIGUSR2 in winbindd for debugging/logging instead of SIGUSR1 in
   preparation for moving to smbcontrol type messages (not sure whether to
   ditch this altogether or not)

 - tidy debugging messages in top level winbind user and group routines

 - convert talloc_init() to talloc_init_named()

 - make enumerations of the domain list use the same local variable names
(This used to be commit eeb8af9c1a66bfcd80823d7b406acbab79857a16)

21 years agoSpelling fix.
Tim Potter [Thu, 10 Jan 2002 06:05:37 +0000 (06:05 +0000)]
Spelling fix.
(This used to be commit 85d3ffb2709258e576191adade9c61b11e83eec5)

21 years agobrowse_fn: FIXME: If the remote machine returns non-ascii characters
Martin Pool [Thu, 10 Jan 2002 03:53:06 +0000 (03:53 +0000)]
browse_fn: FIXME: If the remote machine returns non-ascii characters
   in any of these fields, they can corrupt the output.  We
   should remove them.
(This used to be commit 934aacdb39a0c21c43505dbba696b746f1333df3)

21 years agoFirst part of UNIX extensions (#ifdefed out) more to follow.
Jeremy Allison [Thu, 10 Jan 2002 02:41:15 +0000 (02:41 +0000)]
First part of UNIX extensions (#ifdefed out) more to follow.
(This used to be commit 02b18f2cca6d6d046d2d8fd7375b207d44031ddc)

21 years agoOh joy - the original code didn't do mapping of the perms onto the wire.
Jeremy Allison [Thu, 10 Jan 2002 02:18:08 +0000 (02:18 +0000)]
Oh joy - the original code didn't do mapping of the perms onto the wire.
Make it up as we go along... :-).
(This used to be commit 4289fe3499e49c3ed356eff55ffbcfef4dca72af)

21 years agoEnsure this is committed last.
Jeremy Allison [Thu, 10 Jan 2002 01:49:22 +0000 (01:49 +0000)]
Ensure this is committed last.
(This used to be commit 2591361fa860b3f9480c0c29e433c15d45d9abe4)

21 years agoWe need to test for major/minor macros.
Jeremy Allison [Thu, 10 Jan 2002 01:49:09 +0000 (01:49 +0000)]
We need to test for major/minor macros.
(This used to be commit ee8c8add7f83d7a794546769c59c85ef8bb5b89a)

21 years agoAlthough and configure were checked in at the same time
Tim Potter [Thu, 10 Jan 2002 01:32:57 +0000 (01:32 +0000)]
Although and configure were checked in at the same time
I think just beat it to the repository so the timestamp of is newer than configure.  )-:
(This used to be commit ee0a6f8d26a594bb3d0ee266a0229f3046590270)

21 years agoGetting ready to add UNIX extensions in HEAD also.
Jeremy Allison [Thu, 10 Jan 2002 00:28:09 +0000 (00:28 +0000)]
Getting ready to add UNIX extensions in HEAD also.
(This used to be commit 6210d4aa196c944e47076e316980f76ac9c6b02d)

21 years agoAdded tests for st_blocks in struct stat, and added a (hateful) constant
Jeremy Allison [Wed, 9 Jan 2002 21:30:37 +0000 (21:30 +0000)]
Added tests for st_blocks in struct stat, and added a (hateful) constant
the specifies the units that st_blocks is in. The reason for this is
that HPUX uses 8k, AIX uses a #defined constant and everyone else (tm)
uses 512 byte units.
Needed for the CIFS UNIX extensions - coming to a Samba server near
you soon.... :-).
(This used to be commit 38cfffea5f0d7f5ff676f83204a2923247dce9d5)

21 years agoFixed typo.
Jeremy Allison [Wed, 9 Jan 2002 20:48:18 +0000 (20:48 +0000)]
Fixed typo.
(This used to be commit a99e0cec1e2596c5bc89932e64de301f3fb9ae86)

21 years agoMove SAFE_FREE into tdb.c to stop exporting it into tdb.h namespace.
Jeremy Allison [Wed, 9 Jan 2002 18:26:39 +0000 (18:26 +0000)]
Move SAFE_FREE into tdb.c to stop exporting it into tdb.h namespace.
(This used to be commit 4f703b84cd7f258ae0169d52ca761b9404ccb348)

21 years agoAdd two more memory-debug smbcontrol messages: these ones should
Martin Pool [Wed, 9 Jan 2002 08:27:15 +0000 (08:27 +0000)]
Add two more memory-debug smbcontrol messages: these ones should
prompt dmalloc to log information about what happening, so you can see
in flight why smbd is getting bloated.
(This used to be commit bcb443c5c4bf97fe6b5b0993e42496c2e64f0124)

21 years agoFIXME: At the moment, if the user should happen to give the options
Martin Pool [Wed, 9 Jan 2002 08:17:12 +0000 (08:17 +0000)]
FIXME: At the moment, if the user should happen to give the options
ahead of the service name (in standard Unix fashion) then smbclient
just spits out the usage message with no explanation of what in
particular was wrong.  Is there any reason we can't just parse out the
service name and password after running getopt??
(This used to be commit 5f6feb55d7e7566549141ebb1786b6f2f9f2645b)

21 years agoBetter explanation message for dmalloc.
Martin Pool [Wed, 9 Jan 2002 07:52:51 +0000 (07:52 +0000)]
Better explanation message for dmalloc.

Also more insertion of parenthesis to handle struct members called

You can now get useful dmalloc output, as long as it is compatible
with your C library.  On RH7.1 it looks like you have to rebuild
dmalloc to allow free(0) by default, because something in libcrypt
does that. (sigh)
(This used to be commit 391cbb690196537c8b6292b42c2e27408cc7e249)

21 years agoWith --enable-dmalloc, also use dmalloc's wrappers around routines
Martin Pool [Wed, 9 Jan 2002 06:38:22 +0000 (06:38 +0000)]
With --enable-dmalloc, also use dmalloc's wrappers around routines
like strcat
(This used to be commit fb8ab69b6f638c41d734282488be91d85b4ec057)

21 years agoSample configuration for dmalloc.
Martin Pool [Wed, 9 Jan 2002 06:35:45 +0000 (06:35 +0000)]
Sample configuration for dmalloc.
(This used to be commit 7bbfb29842b27938862a63834eef9b60ac568256)

21 years agoAdd UNUSED(paramname) macro to be used in parameter lists, to quieten
Martin Pool [Wed, 9 Jan 2002 05:27:59 +0000 (05:27 +0000)]
Add UNUSED(paramname) macro to be used in parameter lists, to quieten
gcc warnings about unused parameters.
(This used to be commit b29775d442c36f667a6db5ba9dbe47d1a133525f)

21 years agoAdd UNUSED(paramname) macro to be used in parameter lists, to quieten
Martin Pool [Wed, 9 Jan 2002 05:27:27 +0000 (05:27 +0000)]
Add UNUSED(paramname) macro to be used in parameter lists, to quieten
gcc warnings about unused parameters.

msg_pool_usage: assert msg_type is as expected.
(This used to be commit 3ef135e91aaebf9648c4dd13f59686f57f4cff70)

21 years agoWhen re-writing tdb version numbers as little endian int32, we must
Jeremy Allison [Wed, 9 Jan 2002 05:24:07 +0000 (05:24 +0000)]
When re-writing tdb version numbers as little endian int32, we must
change the version number also.
(This used to be commit 3dec9cf99a82bd15626eb99e7d937ff00183cc05)

21 years agoFix macro name controlling inclusion of DMALLOC.
Martin Pool [Wed, 9 Jan 2002 05:10:47 +0000 (05:10 +0000)]
Fix macro name controlling inclusion of DMALLOC.
(This used to be commit a57e13b8b661dd41e8036f862c708b5d3ced82e6)

21 years agoAdd harmless parentheses so that dmalloc doesn't get confused by a
Martin Pool [Wed, 9 Jan 2002 05:09:44 +0000 (05:09 +0000)]
Add harmless parentheses so that dmalloc doesn't get confused by a
variable called 'free'.
(This used to be commit a823e3f8b2961c3e24205911354a55ffa588233b)

21 years agoMerge from appliance-head:
Tim Potter [Wed, 9 Jan 2002 04:26:41 +0000 (04:26 +0000)]
Merge from appliance-head:

 - put in some level 10 debugs so we can see what internal_resolve_name()
   is doing

 - remove duplicates from returned ip list of internal_resolve_name()
(This used to be commit 08d2bcef1a4fc77d28bc0fa9e4ff5f3131cedea5)

21 years agoFor hysterical raisins you must use string_set() to set the value of a
Tim Potter [Wed, 9 Jan 2002 04:17:24 +0000 (04:17 +0000)]
For hysterical raisins you must use string_set() to set the value of a
string in the loadparam Globals struct.  Using pstrcpy was causing every
NULL string was being set to the name of the winbindd log file.  (-:
(This used to be commit 24bae9f05523a7c85bf1988d349149ebeb5067f0)