13 years agor4029: solaris packaging fixes from Rob
Gerald Carter [Wed, 1 Dec 2004 21:01:27 +0000 (21:01 +0000)]
r4029: solaris packaging fixes from Rob
(This used to be commit 18915f59e4a3ef1cb32c2d119baa8906e1dc5976)

13 years agor4028: * prevent the background LPQ daemon from updating
Gerald Carter [Wed, 1 Dec 2004 20:11:31 +0000 (20:11 +0000)]
r4028: * prevent the background LPQ daemon from updating
  the print queue cache just because multiple smbd
  processes sent a message that it was out of date.

* add some extra debug messages while trying to track down
  down jobs being left in the queue after printing has
(This used to be commit a64505d52fcb23374711e22b3df328c9a7848b84)

13 years agor4023: Code tidyup to fix bug #2098.
Jeremy Allison [Tue, 30 Nov 2004 22:57:41 +0000 (22:57 +0000)]
r4023: Code tidyup to fix bug #2098.
(This used to be commit ebaf21e3e289d3570f20b22e00555eaebe060063)

13 years agor4020: Fix for crash reported by Bård Kalbakk <>.
Jeremy Allison [Tue, 30 Nov 2004 18:58:58 +0000 (18:58 +0000)]
r4020: Fix for crash reported by Bård Kalbakk <>.
Don't go fishing for the authorisation data unless we
know it's there.
(This used to be commit 6f6b4c61e03afb4d35bf6b3ea468fb211d703aa7)

13 years agor4019: better error logging in register_message_flags() from Rob
Gerald Carter [Tue, 30 Nov 2004 15:55:27 +0000 (15:55 +0000)]
r4019: better error logging in register_message_flags() from Rob
(This used to be commit 5fc0f838e7ec8b29d7987caafe9ffbb8724a3176)

13 years agor4018: * move claim_connection from the netbios session request
Gerald Carter [Tue, 30 Nov 2004 15:52:46 +0000 (15:52 +0000)]
r4018: * move claim_connection from the netbios session request
  reply code to the negprot reply code to cope with
  client connections on port 445.  Fixes the spurious
  "register_message_flags: tdb fetch failed" errors.

* don't run the backgroup LPQ daemon when we are running
  in interactive mode.
(This used to be commit 88747a7da351261185222e78e9c8d470ff53a246)

13 years agor4016: Fix for bug found by Steve French client code (cifsfs) on
Jeremy Allison [Tue, 30 Nov 2004 06:41:38 +0000 (06:41 +0000)]
r4016: Fix for bug found by Steve French client code (cifsfs) on
POSIX ACL set. You need to *get* a permset_t pointer from the entry before
any of the permset code will accept it as a valid value
(This used to be commit 7e78059948612fa9f5d179a1e3f5f59e7ad5e456)

13 years agor4009: Fix from Timur Bakeyev <> for bugid #2100,
Jeremy Allison [Tue, 30 Nov 2004 01:01:43 +0000 (01:01 +0000)]
r4009: Fix from Timur Bakeyev <> for bugid #2100,
change the way we check for errors after a dlopen (which
may set internal warnings which get picked up by mistake
in dlsym).
(This used to be commit 6711cb8b02f96d04af82d30b1274f76dc5461dc2)

13 years agor4007: Fix bug #2088 - ensure inherit permissions is only applied on a new file,
Jeremy Allison [Tue, 30 Nov 2004 00:22:04 +0000 (00:22 +0000)]
r4007: Fix bug #2088 - ensure inherit permissions is only applied on a new file,
not an existing one.
(This used to be commit fbbdb72cf1adfe567112556626f26b031747f440)

13 years agor4005: Fix for bug #2071 reported by Jason Mader <>.
Jeremy Allison [Mon, 29 Nov 2004 19:28:12 +0000 (19:28 +0000)]
r4005: Fix for bug #2071 reported by Jason Mader <>.
Use correct enum type for comparisons.
(This used to be commit b926480d053e42205e959b9808a6e3bb90db9ce5)

13 years agor3987: Use sys_readdir() instead of readdir()
Jelmer Vernooij [Sat, 27 Nov 2004 19:02:45 +0000 (19:02 +0000)]
r3987: Use sys_readdir() instead of readdir()
(This used to be commit 7751f46cc77887cd050b44eebb28909a871d4f6b)

13 years agor3985: Fix bug with 64bit fs support
Jelmer Vernooij [Sat, 27 Nov 2004 18:57:44 +0000 (18:57 +0000)]
r3985: Fix bug with 64bit fs support
(This used to be commit 5cee4e94786c6fd63dab1a9805914a9ce6aa7227)

13 years agor3974: - Fix assignment of a couple of fields in pdb_{mysql,pgsql}
Jelmer Vernooij [Thu, 25 Nov 2004 20:55:31 +0000 (20:55 +0000)]
r3974: - Fix assignment of a couple of fields in pdb_{mysql,pgsql}
- Use new DTD URL in pdb_xml
(This used to be commit 99dc2f36d1f637906d47e98dbd4d5eb1f1cc4357)

13 years agor3954: bring Samba3 into line with the Samba4 password change code
Andrew Tridgell [Thu, 25 Nov 2004 04:10:19 +0000 (04:10 +0000)]
r3954: bring Samba3 into line with the Samba4 password change code
(This used to be commit 04a6573f894800b9d939d9b4be48790437352804)

13 years agor3951: Fix for bugid #2081 reported by John Janosik <> - ensure
Jeremy Allison [Thu, 25 Nov 2004 00:59:44 +0000 (00:59 +0000)]
r3951: Fix for bugid #2081 reported by John Janosik <> - ensure
SE_DESC_DACL_PROTECTED is set if "map acl inherit = no".
(This used to be commit 934c41b474c8959310389378bfa7d3332bd5ec79)

13 years agor3948: Fix incorrect declaration. Bug #2083.
Jeremy Allison [Thu, 25 Nov 2004 00:25:53 +0000 (00:25 +0000)]
r3948: Fix incorrect declaration. Bug #2083.
(This used to be commit 05b905a28f349a2741e0963e41ad624a8f0b9fb8)

13 years agor3946: Fix for bugid #2085 reported by Jason Mader <>. Use consistent
Jeremy Allison [Thu, 25 Nov 2004 00:07:01 +0000 (00:07 +0000)]
r3946: Fix for bugid #2085 reported by Jason Mader <>. Use consistent
enum type for Protocol extern.
(This used to be commit 65dfae7ea45d4c9452b2a08efa09b01d870142f3)

13 years agor3944: Fix the problem we get on Linux where sendfile fails, but we've already sent the
Jeremy Allison [Wed, 24 Nov 2004 22:05:59 +0000 (22:05 +0000)]
r3944: Fix the problem we get on Linux where sendfile fails, but we've already sent the
header using send(). As our implementation of sendfile can't return EINTR (it
restarts in that case) use an errno of EINTR to signal the linux sendfile fail
after header case. When that happens send the rest of the data and then turn
off sendfile. Sendfile should be safe to enable on all systems now (even though
it may not help in all performance cases).
(This used to be commit 78236382f7ffe08d7924907be49493779521837f)

13 years agor3940: typo.
Günther Deschner [Wed, 24 Nov 2004 09:44:57 +0000 (09:44 +0000)]
r3940: typo.

(This used to be commit 412ff4a129c5e719aa4d4e4856500ff59c82b939)

13 years agor3936: Ensure LARGE_READX response must fit within reply buffer.
Jeremy Allison [Wed, 24 Nov 2004 05:24:38 +0000 (05:24 +0000)]
r3936: Ensure LARGE_READX response must fit within reply buffer.
(This used to be commit 5541001cf98aa9afb8f98ebeb91561348d3f5d74)

13 years agor3934: Correctly check for the top length bit in LARGE_READX.
Jeremy Allison [Wed, 24 Nov 2004 03:42:01 +0000 (03:42 +0000)]
r3934: Correctly check for the top length bit in LARGE_READX.
(This used to be commit f9effa2af90245c0fe090d730c86a2a60d8570dc)

13 years agor3931: Fix all "may be used uninitialized" and "shadow" warnings.
Jeremy Allison [Wed, 24 Nov 2004 01:03:23 +0000 (01:03 +0000)]
r3931: Fix all "may be used uninitialized" and "shadow" warnings.
(This used to be commit 8e979772a640bb4f00f4d72b6a9c837b8ef14333)

13 years agor3929: Dead code elimination fix for bug #2075 from
Jeremy Allison [Tue, 23 Nov 2004 23:13:48 +0000 (23:13 +0000)]
r3929: Dead code elimination fix for bug #2075 from
(This used to be commit 9d367ac636d7d88cd4756531bd8412f8d6d16d14)

13 years agor3928: Fix duplicate call to pdb_get_acct_desc(). Bugzilla #2080.
Tim Potter [Tue, 23 Nov 2004 20:50:16 +0000 (20:50 +0000)]
r3928: Fix duplicate call to pdb_get_acct_desc().  Bugzilla #2080.
(This used to be commit 3ebfd137b2d8f393874561046ef79f4d9a8cae52)

13 years agor3925: patch from Thomas Bork <> to fix with GNU ld versio...
Gerald Carter [Tue, 23 Nov 2004 16:35:14 +0000 (16:35 +0000)]
r3925: patch from Thomas Bork <> to fix with GNU ld versions that don't output a date string in the --version
(This used to be commit 3bbae21dc9d8147a40cac7962e44fe37630efb40)

13 years agor3924: fix installswat once again after the image target location had changed in...
Gerald Carter [Tue, 23 Nov 2004 15:27:53 +0000 (15:27 +0000)]
r3924: fix installswat once again after the image target location had changed in the docs
(This used to be commit ddb5823ac23b8d61c29d73f4f5bae1c3a319a1f4)

13 years agor3923: BUG 2073: fall back to smb_name if current_user_info is not available in lp_fi...
Gerald Carter [Tue, 23 Nov 2004 14:52:56 +0000 (14:52 +0000)]
r3923: BUG 2073: fall back to smb_name if current_user_info is not available in lp_file_list_changed()
(This used to be commit b0e44b11b36dcd89a8c825911efadbeeac9faab5)

13 years agor3918: Allow to set OWNER- and GROUP-entries while setting security descriptors
Günther Deschner [Tue, 23 Nov 2004 01:05:31 +0000 (01:05 +0000)]
r3918: Allow to set OWNER- and GROUP-entries while setting security descriptors
with smbcacls and using with the -S or -M switch. Fixes #404 and #2076.

(This used to be commit 13d32519e3806d7c080a0ac3c5ba196868ed2581)

13 years agor3912: More fixes to have proper german in swat.
Günther Deschner [Mon, 22 Nov 2004 15:20:38 +0000 (15:20 +0000)]
r3912: More fixes to have proper german in swat.
(The new german orthography is another story...)

Thanks to Reiner Klaproth and Björn Jacke <>.

(This used to be commit 1680446ce2d75c7efc5f49d5157d092eccda4696)

13 years agor3911: typo.
Günther Deschner [Mon, 22 Nov 2004 14:34:45 +0000 (14:34 +0000)]
r3911: typo.

(This used to be commit 52dea588fd0b40a32c56b5634315b149fc088907)

13 years agor3895: Fix for bug #2045. May also fix other timestamp bugs with Excel
Jeremy Allison [Sat, 20 Nov 2004 21:24:52 +0000 (21:24 +0000)]
r3895: Fix for bug #2045. May also fix other timestamp bugs with Excel
(Volker please test). Setting a last write timestamp from Windows
overrides any subsequent write timestamp changes and must be immediately
seen by and findfirst/findnexts. This is a racy solution, but should
work most of the time. This may also fix #1061, not sure.
(This used to be commit 47bab92c0b062f3fefbb4fd4a09852e1c829a7f9)

13 years agor3892: Fix "might be used uninitialized" error.
Jeremy Allison [Sat, 20 Nov 2004 20:10:43 +0000 (20:10 +0000)]
r3892: Fix "might be used uninitialized" error.
(This used to be commit eead77919b05e0a2bed32a4a192dd0d9e6a86008)

13 years agor3889: Only set mtime from pending_modtime if it's not already zero...
Jeremy Allison [Sat, 20 Nov 2004 02:48:34 +0000 (02:48 +0000)]
r3889: Only set mtime from pending_modtime if it's not already zero...
(This used to be commit 984c3506351ba97f74813d678424858508c4197a)

13 years agor3883: Fix error return -- thanks to rsharpe
Volker Lendecke [Fri, 19 Nov 2004 21:01:23 +0000 (21:01 +0000)]
r3883: Fix error return -- thanks to rsharpe
(This used to be commit 2d952c86c7e92fff48b4773ab46987d905b214cc)

13 years agor3882: Fix bug 2069 -- thanks to
Volker Lendecke [Fri, 19 Nov 2004 20:55:54 +0000 (20:55 +0000)]
r3882: Fix bug 2069 -- thanks to
(This used to be commit 5c9fd4d8963130829684469be172e859b3799e27)

13 years agor3880: Tidy up some unused/shadowed variable usage.
Jeremy Allison [Fri, 19 Nov 2004 19:45:03 +0000 (19:45 +0000)]
r3880: Tidy up some unused/shadowed variable usage.
(This used to be commit 1fd1a98782c3ca7171428b62336936aef4c6685b)

13 years agor3877: Final (I hope :-) fix for #2050 from Lars Müller for select maxfd's.
Jeremy Allison [Fri, 19 Nov 2004 19:32:31 +0000 (19:32 +0000)]
r3877: Final (I hope :-) fix for #2050 from Lars Müller for select maxfd's.
(This used to be commit 65fc39fc388244923d1e36076b5a4116aa434be5)

13 years agor3875: Allow to look up at least or own sid in _lsa_lookup_sids.
Günther Deschner [Fri, 19 Nov 2004 13:26:17 +0000 (13:26 +0000)]
r3875: Allow to look up at least or own sid in _lsa_lookup_sids.

This fixes Bugzilla #1076 and Exchange 5.5 SP4 can then be finally
installed on NT4 in a samba-controlled domain.

(This used to be commit bb191c1098dea06bf2cd89276c74e32279fbb3d4)

13 years agor3873: The semantics of the parameter 'printcap name' are a bit tricky. I had seen
Volker Lendecke [Fri, 19 Nov 2004 12:11:13 +0000 (12:11 +0000)]
r3873: The semantics of the parameter 'printcap name' are a bit tricky. I had seen
the effect that I could not list printers with smbclient -L. I have cups
libraries but no running cups server, so remove_stale_printers() removed all
my printer definitions from the share list. So I said 'printing = bsd' but it
still would not work.

This happened because init_globals() would initialize Globals.szPrintcapname
to "cups", and the explicit 'printing = bsd' did not reset it. 'printing=bsd'
can't reset it, as this might overwrite an explicit setting. Thus I separated
the lp_printcapname into a function of its own, looking at
Globals.szPrintcapname and subsequently at sDefault.iPrinting.

Please revisit, there are just too many cases to cover.


(This used to be commit 3cdde7071b6bf83ad05046745ad2a5fa353995bf)

13 years agor3871: Fix memleak
Volker Lendecke [Fri, 19 Nov 2004 11:59:56 +0000 (11:59 +0000)]
r3871: Fix memleak
(This used to be commit dbfdde5f63f34fbe4ba1d794fcfc120178ff039a)

13 years agor3868: Fix reverted logic of detecting HAVE_WRFILE_KEYTAB (Bugzilla 2059)
Günther Deschner [Thu, 18 Nov 2004 23:25:37 +0000 (23:25 +0000)]
r3868: Fix reverted logic of detecting HAVE_WRFILE_KEYTAB (Bugzilla 2059)

(This used to be commit 8d987d2f38005969798fe829f87c3ffc1d1e5edd)

13 years agor3867: Fix from - make a copy of an incoming message
Jeremy Allison [Thu, 18 Nov 2004 22:46:04 +0000 (22:46 +0000)]
r3867: Fix from - make a copy of an incoming message
rather than indirecting into it as a struct (may not be on an
even byte boundary). Bug #2052.
(This used to be commit 8a91a69961622a31851f2394c591ddaa61a36000)

13 years agor3864: Fix from Lars Müller <> for bug #2050.
Jeremy Allison [Thu, 18 Nov 2004 22:11:20 +0000 (22:11 +0000)]
r3864: Fix from Lars Müller <> for bug #2050.
Make nmbd use maxfd+1 in select also.
(This used to be commit e3ca22b80dc1c22f0e5c829d11724c79e317641f)

13 years agor3862: Fix from Lars Müller <>, check for HAVE_WRFILE_KEYTAB
Jeremy Allison [Thu, 18 Nov 2004 21:22:24 +0000 (21:22 +0000)]
r3862: Fix from Lars Müller <>, check for HAVE_WRFILE_KEYTAB
was inverted.
(This used to be commit 6a9799806874619c471548b8ff0b3dc36788f81a)

13 years agor3859: Ensure if num_acls is set to 0xFFFF this field is ignored.
Jeremy Allison [Thu, 18 Nov 2004 19:36:50 +0000 (19:36 +0000)]
r3859: Ensure if num_acls is set to 0xFFFF this field is ignored.
Use def_acl everywhere instead of dir_acl.
(This used to be commit d28611c960f87830aa8449725951984aa155b089)

13 years agor3857: Shut up gcc about erroneous "used uninitialised" warning.
Jeremy Allison [Thu, 18 Nov 2004 19:03:17 +0000 (19:03 +0000)]
r3857: Shut up gcc about erroneous "used uninitialised" warning.
(This used to be commit ac9b91d805c3ee68119d4b25ab05ed043f0ab8f1)

13 years agor3855: Sync up with the one in the main source dir (yes, this should probably
Jeremy Allison [Thu, 18 Nov 2004 18:40:39 +0000 (18:40 +0000)]
r3855: Sync up with the one in the main source dir (yes, this should probably
be a symlink...).
(This used to be commit 5b0da25796337b73d151a3025b7e460222164b3f)

13 years agor3853: Fix an uninitialized variable warning. Jeremy, there are some of these in
Volker Lendecke [Thu, 18 Nov 2004 16:14:13 +0000 (16:14 +0000)]
r3853: Fix an uninitialized variable warning. Jeremy, there are some of these in

(This used to be commit 650d52648dbf67f71d7619ffb8bf32d93a15ae9c)

13 years agor3852: Fix the build...
Volker Lendecke [Thu, 18 Nov 2004 15:52:02 +0000 (15:52 +0000)]
r3852: Fix the build...
(This used to be commit 3bd72b864f18f6fad0357c8aa632121f14e422ab)

13 years agor3850: I get the impression that some developers here are using gcc 3.4. This one
Volker Lendecke [Thu, 18 Nov 2004 15:44:01 +0000 (15:44 +0000)]
r3850: I get the impression that some developers here are using gcc 3.4. This one
only warns you about possibly uninitialized variables if you have at least

(This used to be commit 7cd12794a3cb7c70e75ec4824d9bc88d2d3a0fcd)

13 years agor3848: Fix for bug 2057. Only partially applied the patch, the second part seems not
Volker Lendecke [Thu, 18 Nov 2004 15:13:58 +0000 (15:13 +0000)]
r3848: Fix for bug 2057. Only partially applied the patch, the second part seems not

I'm using gcc 3.4.1, this does not detect the possibly uninitialized
variable. Does anybody know how to get 3.4.1 to warn me?

(This used to be commit 8b6f8f93a0f30be0184e6044a499c1ef8f7b247e)

13 years agor3846: Typo fix. Bug 2055. Lars, I'm available on irc.... :-)
Volker Lendecke [Thu, 18 Nov 2004 13:29:10 +0000 (13:29 +0000)]
r3846: Typo fix. Bug 2055. Lars, I'm available on irc.... :-)

(This used to be commit 78ab68367d437cd5f84d46ac96fcaf9ebb3305b8)

13 years agor3844: Attempt to get the build farm in line. Some systems seem to have defined
Volker Lendecke [Thu, 18 Nov 2004 12:19:16 +0000 (12:19 +0000)]
r3844: Attempt to get the build farm in line. Some systems seem to have defined
rewinddir as a macro and don't like the construct to call a function pointer
called rewinddir. Work around by renaming the function pointer...

(This used to be commit e547308d3ed307a242723076dff9974973fccc97)

13 years agor3843: If a connection to a DC is requested, open connections simultaeneously to all
Volker Lendecke [Thu, 18 Nov 2004 11:57:49 +0000 (11:57 +0000)]
r3843: If a connection to a DC is requested, open connections simultaeneously to all
DCs found. The first one to reply wins.

(This used to be commit 84ac54aef2bd56b5c889d3b05b8828aceb8ae00e)

13 years agor3841: Time out in ads search queries. Even AD servers can hang.
Volker Lendecke [Thu, 18 Nov 2004 11:43:14 +0000 (11:43 +0000)]
r3841: Time out in ads search queries. Even AD servers can hang.

(This used to be commit fc454c8ef6321fba9efa42a704c8e8c707361af3)

13 years agor3839: Some more specific NT security descriptors we've come across. Map them to
Volker Lendecke [Thu, 18 Nov 2004 08:16:59 +0000 (08:16 +0000)]
r3839: Some more specific NT security descriptors we've come across. Map them to
defined AFS acls. Thanks to Horst Birthelmer.

(This used to be commit fea467657d5b4f67040c8fe3e89b3b20e10c6c68)

13 years agor3824: Fix crash in api_RNetShareEnum. ServicePtrs[] may contain invalid
Volker Lendecke [Wed, 17 Nov 2004 21:22:35 +0000 (21:22 +0000)]
r3824: Fix crash in api_RNetShareEnum. ServicePtrs[] may contain invalid
entries. Happened after rev3708 removed non-existing cups printers.

(This used to be commit 60998d9d2f6272e383304da2b1d568a4b65f8787)

13 years agor3823: Fix bug reported by Tom Dickson <> with
Jeremy Allison [Wed, 17 Nov 2004 21:05:47 +0000 (21:05 +0000)]
r3823: Fix bug reported by Tom Dickson <> with
follow symlinks = no reporting an incorrect error when it should
be access denied.
(This used to be commit 5a103f4abff0503740822c8ed75d9102ee51e8f0)

13 years agor3819: Updated config.guess/config.sub from
Jeremy Allison [Wed, 17 Nov 2004 20:05:31 +0000 (20:05 +0000)]
r3819: Updated config.guess/config.sub from
as requested in bugid #2048.
(This used to be commit 2201981d69fba264c79cbff37aa6991f0e69ae4d)

13 years agor3817: Fix from Lars Müller <> for bug #2050, calculate
Jeremy Allison [Wed, 17 Nov 2004 19:52:26 +0000 (19:52 +0000)]
r3817: Fix from Lars Müller <> for bug #2050, calculate
max_fd for select correctly.
(This used to be commit eb0b1f757d814e01980cd9c5fc4918791ce1e54d)

13 years agor3816: Added fn to remove an ACL from a file. Now need client code to test this.
Jeremy Allison [Wed, 17 Nov 2004 18:56:48 +0000 (18:56 +0000)]
r3816: Added fn to remove an ACL from a file. Now need client code to test this.
How do the share mask/modes fit into this code... Need to think about this.
(This used to be commit 1aa1c2f489f5b92c3696e7b9123061d91babc34e)

13 years agor3814: At least use a proper constant name (aRONLY :-) not a number.
Jeremy Allison [Wed, 17 Nov 2004 17:51:27 +0000 (17:51 +0000)]
r3814: At least use a proper constant name (aRONLY :-) not a number.
That way we can at least remember why we did this :-).
(This used to be commit d84f5f8cc10f89d5fbd6cfb694bccfbd1c3d8a3f)

13 years agor3811: Believe it or not, but this patch seems to be necessary. If someone sets a
Volker Lendecke [Wed, 17 Nov 2004 15:56:47 +0000 (15:56 +0000)]
r3811: Believe it or not, but this patch seems to be necessary. If someone sets a
folder icon in the start menu and saves the profile on a samba server, after
logging in again this setting is gone. Why is this? The folder for which the
icon is set must have the read only flag set. If it is not set, the
desktop.ini file (the file containing the icon reference) inside that folder
is ignored.

lp_profile_acls is a hack for such a situation, so overload this parameter
with another profile-related hack.

(This used to be commit b8d888000eb7456c7620e9a783d6f1b3ba4c8985)

13 years agor3796: Patch from Jay Fenlason <>. Don't free static buffers.
Jeremy Allison [Wed, 17 Nov 2004 01:43:36 +0000 (01:43 +0000)]
r3796: Patch from Jay Fenlason <>. Don't free static buffers.
(This used to be commit 53acf222a86a1420abbba08a2cde27a86debe403)

13 years agor3794: Added set posix acl functionality into the UNIX extensions code.
Jeremy Allison [Wed, 17 Nov 2004 01:35:35 +0000 (01:35 +0000)]
r3794: Added set posix acl functionality into the UNIX extensions code.
One part missing - delete file acl (to be added asap). No client
code yet, also needs testing with valgrind.
(This used to be commit 6101ec2247c182fde6ea3e7e1f64a92b353ec4e8)

13 years agor3778: BUG 2023: patch from Buchan Milne <> fix mandrake packagin...
Gerald Carter [Tue, 16 Nov 2004 03:27:19 +0000 (03:27 +0000)]
r3778: BUG 2023: patch from Buchan Milne <> fix mandrake packaging for Samba 3.0.9 -- still need to review this libsmbclient install location
(This used to be commit db4719ed2f5baf05d6c692f039369310bed52dc2)

13 years agor3776: Fix for bug #2038 from Johann Hanne <>. Don't check
Jeremy Allison [Mon, 15 Nov 2004 23:03:37 +0000 (23:03 +0000)]
r3776: Fix for bug #2038 from Johann Hanne <>. Don't check
for no groups after every lookup - move check to the end as we should
only fail if all lookups fail.
(This used to be commit 3b40c1e4365f37b967e14be02c6aa52893a80f51)

13 years agor3772: BUG 2006: patch from Michel Gravey <>; fix build...
Gerald Carter [Mon, 15 Nov 2004 21:21:50 +0000 (21:21 +0000)]
r3772: BUG 2006: patch from Michel Gravey <>; fix build when using gcc 3.0
(This used to be commit 1bc79a28080f2ff783b49e5cf3adfdfc4a4940ee)

13 years agor3771: Fix bug #1952: no comment on XP shutdown
Jim McDonough [Mon, 15 Nov 2004 20:57:27 +0000 (20:57 +0000)]
r3771: Fix bug #1952: no comment on XP shutdown

Try INITSHUTDOWN pipe first, used by newer clients.  If it fails, fall back
(This used to be commit f05858df65d89950c739a739a9b9fa7a04db39c3)

13 years agor3764: Ensure on failure that *res is always NULL.
Jeremy Allison [Mon, 15 Nov 2004 18:57:22 +0000 (18:57 +0000)]
r3764: Ensure on failure that *res is always NULL.
Check for malloc fail. Fixes for bug #2036.
(This used to be commit b815247747214ba413c054746e9732d5f2b10535)

13 years agor3761: Fix bug #1932: crash when non-root invokes net getlocalsid
Jim McDonough [Mon, 15 Nov 2004 17:20:58 +0000 (17:20 +0000)]
r3761: Fix bug #1932: crash when non-root invokes net getlocalsid

First check to see if we can open secrets.tdb.
(This used to be commit 81e3c78d056c0a7499b8f27dcd37a13e725053ee)

13 years agor3758: Increase a debug level. This error condition can actually happen in real life
Volker Lendecke [Mon, 15 Nov 2004 13:18:12 +0000 (13:18 +0000)]
r3758: Increase a debug level. This error condition can actually happen in real life
if you have several competing winbinds that might get a lag due to

(This used to be commit 1c3f194ab7ab63aeb2284d7e5c7e183340740ceb)

13 years agor3727: Update from Rob Foehl (
Jim McDonough [Sun, 14 Nov 2004 03:12:46 +0000 (03:12 +0000)]
r3727: Update from Rob Foehl (
Try modifying printer before adding it,since add logic appends ObjectClass to mods, which caused a contraint violation when modifying an already published printer.

Also cleanup the check_published_printers() logic when verifying published status on startup.
(This used to be commit 82eb168c827b4b7310b42c0f36c504e0fa16dc99)

13 years agor3714: Getfacl now seems to work on files and directories. Next do setfacl
Jeremy Allison [Sat, 13 Nov 2004 00:35:31 +0000 (00:35 +0000)]
r3714: Getfacl now seems to work on files and directories. Next do setfacl
and port to Samba4.
(This used to be commit 4d52bf7c8b3147dd4f0d3081fbf9a1f5ebd246a1)

13 years agor3713: Implementation of get posix acls in UNIX extensions. Passes valgrind.
Jeremy Allison [Fri, 12 Nov 2004 23:42:12 +0000 (23:42 +0000)]
r3713: Implementation of get posix acls in UNIX extensions. Passes valgrind.
Need to add printout functions in client and set posix acl in server.
SteveF - take a look at this for the cifsfs client !
Once this is working and tested the next step is to write this up for
the UNIX extensions spec. documents.
(This used to be commit 1bd3f133442a472b4718b94a636f2fec89a2e0dc)

13 years agor3711: Fix KRB5_SETPW-defines, no change in behaviour.
Günther Deschner [Fri, 12 Nov 2004 23:13:03 +0000 (23:13 +0000)]
r3711: Fix KRB5_SETPW-defines, no change in behaviour.

A value of '2' is due to an expired internet draft, while 0xff80 comes
from RFC3244. See Bugzilla #1661 for details.

Thanks to Luke Mewburn <> for his research.

(This used to be commit 3906c1623fb3823612347a0533ad49d7dfbe1b99)

13 years agor3710: fix another safe_strcpy() warning SPAM with the printer drivcename
Gerald Carter [Fri, 12 Nov 2004 22:15:55 +0000 (22:15 +0000)]
r3710: fix another safe_strcpy() warning SPAM with the printer drivcename
(This used to be commit 5eac16464dfe58ec2c725888993f313fdb609f9b)

13 years agor3709: Allow to build testsuite for libsmbclient when is
Günther Deschner [Fri, 12 Nov 2004 22:05:27 +0000 (22:05 +0000)]
r3709: Allow to build testsuite for libsmbclient when is
located not in -L/root/samba-head-old/source/bin.

Patch from Lars Mueller <>, closes Bugzilla #2013.

(This used to be commit 0a02eac76714ada5192c238416013f68eb4e63d5)

13 years agor3708: BUG 1838: patch from Gavrie Philipson <> to remove stale...
Gerald Carter [Fri, 12 Nov 2004 17:39:32 +0000 (17:39 +0000)]
r3708: BUG 1838: patch from Gavrie Philipson <> to remove stale printers when reloading after a sighup
(This used to be commit bcb9105c5488a97944d2dfee8681d662e9c9b818)

13 years agor3707: 2028: avoid false error messages when copying a long printer name to the devic...
Gerald Carter [Fri, 12 Nov 2004 17:23:01 +0000 (17:23 +0000)]
r3707: 2028: avoid false error messages when copying a long printer name to the device mode
(This used to be commit c9613214a5797adbb62a953bd5e28cf9fe2692ee)

13 years agor3705: Nobody has commented, so I'll take this as an ack...
Volker Lendecke [Fri, 12 Nov 2004 15:49:47 +0000 (15:49 +0000)]
r3705: Nobody has commented, so I'll take this as an ack...

abartlet, I'd like to ask you to take a severe look at this!

We have solved the problem to find the global groups a user is in twice: Once
in auth_util.c and another time for the corresponding samr call. The attached
patch unifies these and sends them through the passdb backend (new function
pdb_enum_group_memberships). Thus it gives pdb_ldap.c the chance to further
optimize the corresponding call if the samba and posix accounts are unified by
issuing a specialized ldap query.

The parameter to activate this ldapsam behaviour is

ldapsam:trusted = yes

(This used to be commit b94838aff1a009f8d8c2c3efd48756a5b8f3f989)

13 years agor3704: Implement a cache get saves the result of a pdb_getsampwnam for later
Volker Lendecke [Fri, 12 Nov 2004 15:30:51 +0000 (15:30 +0000)]
r3704: Implement a cache get saves the result of a pdb_getsampwnam for later
retrieval by pdb_getsampwsid. This solves our problem that we do lots of calls
to LDAP during a typical XP login. XP does a lookupnames, then an openuser and
some queryinfo stuff. Lookupnames triggers the initial getsampwnam, and all
the subsequent ones make us call getsampwsid. This patch gets this down to one
call to LDAP.

Yes, a more "correct" way would be to stick the information to the open user
handle, but this one is simpler and saves the LDAP roundtrip for the openuser

(This used to be commit 3d9758fa3c584bb25eca0b7ed04af4ddfeba315f)

13 years agor3702: This is a getpwnam-cache. It is mainly to speed up Samba with slow nss
Volker Lendecke [Fri, 12 Nov 2004 15:01:40 +0000 (15:01 +0000)]
r3702: This is a getpwnam-cache. It is mainly to speed up Samba with slow nss
backends such as nss_ldap.

(This used to be commit a8bd0b75042f73b753fc1cb8a52e6e90372fd1fe)

13 years agor3697: BUG 2027: fix multiple declaration of MD5_CTX (do we really care about DOS...
Gerald Carter [Fri, 12 Nov 2004 03:36:15 +0000 (03:36 +0000)]
r3697: BUG 2027: fix multiple declaration of MD5_CTX (do we really care about DOS compilers?).  Will watch build farm though.
(This used to be commit b59aeb12c86f3630eb40f033b8c2b70e9a57675c)

13 years agor3693: Correctly detect errno for no acl/ea support.
Jeremy Allison [Fri, 12 Nov 2004 02:16:00 +0000 (02:16 +0000)]
r3693: Correctly detect errno for no acl/ea support.
(This used to be commit 089a76f611187e2ba4c3363b657905d04576109e)

13 years agor3688: fix output of smbstatus to make the man page; fix -L, -p, & -S and the -u...
Gerald Carter [Thu, 11 Nov 2004 23:30:32 +0000 (23:30 +0000)]
r3688: fix output of smbstatus to make the man page; fix -L, -p, & -S and the -u <username> functionality
(This used to be commit 7dd12ed8a5ebbfa791f014b35debcf55d80e6d87)

13 years agor3685: setting the 3.0 branch to 3.0.10pre1-svn
Gerald Carter [Thu, 11 Nov 2004 20:41:28 +0000 (20:41 +0000)]
r3685: setting the 3.0 branch to 3.0.10pre1-svn
(This used to be commit 5dec4cdf5ac8795f723bbd8195df7b84aaf8d594)

13 years agor3683: BUG 2017: fix testparm reporting for the passwd program string
Gerald Carter [Thu, 11 Nov 2004 18:11:40 +0000 (18:11 +0000)]
r3683: BUG 2017: fix testparm reporting for the passwd program string
(This used to be commit 23422aeec04dfb72a0ad5b0a67622cec69ca502d)

13 years agor3682: fix seg fault in lanman printing code caused by uninitialized variable
Gerald Carter [Thu, 11 Nov 2004 17:40:49 +0000 (17:40 +0000)]
r3682: fix seg fault in lanman printing code caused by uninitialized variable
(This used to be commit c52e663c4a32b975796383834b2c04796daf8f29)

13 years agor3681: Fix build of libsmbclient on x86_64.
Günther Deschner [Thu, 11 Nov 2004 15:38:21 +0000 (15:38 +0000)]
r3681: Fix build of libsmbclient on x86_64.
Patch from Lars Mueller <>

(This used to be commit b87abdfd0ee7ba1f8a1fb13d47c76baa538a4c6a)

13 years agor3674: Stefan Esser <> pointed out that the max data
Jeremy Allison [Wed, 10 Nov 2004 23:43:52 +0000 (23:43 +0000)]
r3674: Stefan Esser <> pointed out that the max data
value is only valid on the initial trans/trans2/nttrans request,
so if there are secondary requests we can't read it from them. Read
it from the initial request and pass as a parameter for those functions
that need it.
(This used to be commit e007845e67e0604321fb36b216a98e4fca1c98e1)

13 years agor3673: Do not fail on setting file attributes with acl support enabled.
Günther Deschner [Wed, 10 Nov 2004 23:12:02 +0000 (23:12 +0000)]
r3673: Do not fail on setting file attributes with acl support enabled.
Rolling back r3496 (close #2015).

(This used to be commit e88ac807847bd016f9c921f01f788708b1564b5c)

13 years agor3671: More warning fixes from Rob Foehl <>.
Jeremy Allison [Wed, 10 Nov 2004 23:03:26 +0000 (23:03 +0000)]
r3671: More warning fixes from Rob Foehl <>.
(This used to be commit 3850f142c174034397451de8457564b9604113c5)

13 years agor3670: Warning fixes from Rob Foehl <>.
Jeremy Allison [Wed, 10 Nov 2004 23:02:48 +0000 (23:02 +0000)]
r3670: Warning fixes from Rob Foehl <>.
(This used to be commit 54da75ca4cc27dfb0012fd17047702ec2f39cae9)

13 years agor3668: Fix unresolved symbols in
Günther Deschner [Wed, 10 Nov 2004 21:49:36 +0000 (21:49 +0000)]
r3668: Fix unresolved symbols in
Patch from Lars Müller <> ( Bugzilla #2013 )

(This used to be commit af3ec11f8d6cae9bbad5dc5f3b9ae6e00bf1dd7e)

13 years agor3666: Generalise fix for trans and nttrans multi-fragment requests.
Jeremy Allison [Wed, 10 Nov 2004 20:37:14 +0000 (20:37 +0000)]
r3666: Generalise fix for trans and nttrans multi-fragment requests.
(This used to be commit 10b2489e3b2345a8532098523ebcebb73665a76f)

13 years agor3663: Fix too tight checking of incoming secondary trans2 requests.
Jeremy Allison [Wed, 10 Nov 2004 19:34:50 +0000 (19:34 +0000)]
r3663: Fix too tight checking of incoming secondary trans2 requests.
Found by Stefan Esser <>.
(This used to be commit 44132c39ecbf055b897b1aa7bfca4eb1731badbf)

13 years agor3662: Fix dirent return.
Jeremy Allison [Wed, 10 Nov 2004 19:34:13 +0000 (19:34 +0000)]
r3662: Fix dirent return.
(This used to be commit da4117841db731da8f1b7fe7c2524e9d4d60f09a)

13 years agor3650: Allow to call spoolss-server as "localhost".
Günther Deschner [Wed, 10 Nov 2004 02:13:36 +0000 (02:13 +0000)]
r3650: Allow to call spoolss-server as "localhost".

(This used to be commit 14a0292250ee9975618b68701a48c72195286d85)

13 years agor3649: Fix a couple of rpcclient spoolss commands (setprinter, setprintername,
Günther Deschner [Wed, 10 Nov 2004 02:09:13 +0000 (02:09 +0000)]
r3649: Fix a couple of rpcclient spoolss commands (setprinter, setprintername,
getdriver) w.r.t to printer-naming scheme.

(This used to be commit 968c3fc416e836c3958a068df7b4599682028a99)