12 years agos4: Make the int32 problem more clear - and fix another error
Matthias Dieter Wallnöfer [Mon, 17 Aug 2009 18:29:11 +0000 (20:29 +0200)]
s4: Make the int32 problem more clear - and fix another error

12 years agos4:librpc/rpc: fix DEBUG() message
Stefan Metzmacher [Tue, 11 Aug 2009 17:49:33 +0000 (19:49 +0200)]
s4:librpc/rpc: fix DEBUG() message


12 years agonetlogon: document some more MSVC flags.
Günther Deschner [Mon, 17 Aug 2009 14:49:24 +0000 (16:49 +0200)]
netlogon: document some more MSVC flags.

Some of these were observed during password changing
from win7 using a samba 3.4 PDC.


12 years agos3-spoolss: remove another duplicate copy of print_architecture_table.
Günther Deschner [Wed, 12 Aug 2009 12:59:44 +0000 (14:59 +0200)]
s3-spoolss: remove another duplicate copy of print_architecture_table.


12 years agofixed make test reporting success when provision fails
Andrew Tridgell [Mon, 17 Aug 2009 12:45:51 +0000 (22:45 +1000)]
fixed make test reporting success when provision fails

We were getting build test 'pass' on the build farm when the provision
is failing. The cause was the use of filter pipelines in the selftest
code in the makefile. A bourne shell will by default report the error
status of the last element of the pipeline, which means when provision
failed, make thought everything had passed.

We could use the bash 'pipefail' option to fix this, but it isn't
portable, so instead I've modified the makefile to touch st/st_done
when the first element in the pipeline completes successfully. That
means we now get errors in make test, at the expense of making the
makefile even more horrible than it was.

12 years agos4: Fixed the int32 datatype support
Matthias Dieter Wallnöfer [Mon, 17 Aug 2009 11:10:16 +0000 (13:10 +0200)]
s4: Fixed the int32 datatype support

Should finally fix bug #6136 ("groupType", "sAMAccountType" ... attributes).

12 years agofixed the build
Andrew Tridgell [Mon, 17 Aug 2009 11:40:19 +0000 (21:40 +1000)]
fixed the build

the changes from Matthias didn't take account of url and lp being None
in some ldb python instances in 'make test'

12 years agos4: Major rework of the LDB/SAMDB/IDMAP python bindings
Matthias Dieter Wallnöfer [Sat, 15 Aug 2009 13:20:09 +0000 (15:20 +0200)]
s4: Major rework of the LDB/SAMDB/IDMAP python bindings

- Centralise the lookups for the default domain (root) in the call "domain_dn"
- Reduce the LDB connections attempts ("connect" calls) from three to one
  - tools should load faster
- Make the LDB connection init more like the "ldb_wrap_connection" call
- Load the right UTF8 casefolder which fixes up problems with special characters
  (discovered by me: e.g. small "Umlaute" (ä, ö, ü, ...) in the DN weren't upcased
  - so records "seemed" lost in TDB)

12 years agos4:python tools - Centralise the lookups for the default domain (root) in the call...
Matthias Dieter Wallnöfer [Mon, 17 Aug 2009 09:47:53 +0000 (11:47 +0200)]
s4:python tools - Centralise the lookups for the default domain (root) in the call "domain_dn" from SamDB

12 years agos4:pyglue Add a wrapper for loading the correct UTF8 casefolder
Matthias Dieter Wallnöfer [Mon, 17 Aug 2009 09:46:23 +0000 (11:46 +0200)]
s4:pyglue Add a wrapper for loading the correct UTF8 casefolder

Needed for special characters (e.g. in German "Umlaute")

12 years agos4:ldb python bindings: Handle the parameters of the connect call in the right way
Matthias Dieter Wallnöfer [Sat, 15 Aug 2009 13:18:46 +0000 (15:18 +0200)]
s4:ldb python bindings: Handle the parameters of the connect call in the right way

12 years agoRevert "s4:samdb python bindings - we don't need the attributes here"
Matthias Dieter Wallnöfer [Mon, 17 Aug 2009 09:06:39 +0000 (11:06 +0200)]
Revert "s4:samdb python bindings - we don't need the attributes here"

This reverts commit 53ef426e6f68728763436bd0cd3dd91180c00579.

As abartlet pointed out this causes to load all attributes and therefore gives
us more here than we need (only the check for the DN)!

12 years agosigh - still not right
Andrew Tridgell [Mon, 17 Aug 2009 07:50:26 +0000 (17:50 +1000)]
sigh - still not right

12 years agofixed up add_foreign again
Andrew Tridgell [Mon, 17 Aug 2009 07:48:27 +0000 (17:48 +1000)]
fixed up add_foreign again

my last patch was not even close ...

I'll leave abartlet to work out how to fix the test case

12 years agomore fixups from provision changes
Andrew Tridgell [Mon, 17 Aug 2009 07:34:22 +0000 (17:34 +1000)]
more fixups from provision changes

Andrew, can you please check this? The idmap.setup_name_mapping tests
look totally out of place here. I'm also not sure I captured your
intention with the other changes

12 years agos3:smbd: add support for canceling SMB2 Notify calls.
Stefan Metzmacher [Sat, 15 Aug 2009 08:11:16 +0000 (10:11 +0200)]
s3:smbd: add support for canceling SMB2 Notify calls.


12 years agos3:smbd: add smbd_notify_cancel_by_smbreq()
Stefan Metzmacher [Sat, 15 Aug 2009 08:07:00 +0000 (10:07 +0200)]
s3:smbd: add smbd_notify_cancel_by_smbreq()

This function will be used by the SMB2 notify code.


12 years agos3:smbd: implement SMB2 Cancel correctly.
Stefan Metzmacher [Sat, 15 Aug 2009 08:01:38 +0000 (10:01 +0200)]
s3:smbd: implement SMB2 Cancel correctly.


12 years agos4:build: require tevent 0.9.7 with tevent_req_cancel()
Stefan Metzmacher [Sat, 15 Aug 2009 08:45:21 +0000 (10:45 +0200)]
s4:build: require tevent 0.9.7 with tevent_req_cancel()


12 years agotevent: change version to 0.9.7 after adding tevent_req_cancel infrastructure
Stefan Metzmacher [Sat, 15 Aug 2009 08:44:50 +0000 (10:44 +0200)]
tevent: change version to 0.9.7 after adding tevent_req_cancel infrastructure


12 years agotevent: add tevent_req_cancel() infrastructure
Stefan Metzmacher [Sat, 15 Aug 2009 07:46:23 +0000 (09:46 +0200)]
tevent: add tevent_req_cancel() infrastructure

This offers a generic way for callers to cancel an
async request.


12 years agoskip the autoidl test
Andrew Tridgell [Mon, 17 Aug 2009 03:29:34 +0000 (13:29 +1000)]
skip the autoidl test

The autoidl test is not needed now that we have IDL source
available. It also generates a lot of errors in the logs.

12 years agofixed up some provision errors from the recent changes
Andrew Tridgell [Mon, 17 Aug 2009 03:28:57 +0000 (13:28 +1000)]
fixed up some provision errors from the recent changes

12 years agos4:provision Add comments to the provision script
Andrew Bartlett [Mon, 17 Aug 2009 01:41:58 +0000 (11:41 +1000)]
s4:provision Add comments to the provision script

Hopefully this will explain a bit more whey things are done the way
that they are done.

Andrew Bartlett

12 years agos4:provision Avoid one more call to ltdb_reindex
Andrew Bartlett [Mon, 17 Aug 2009 01:33:25 +0000 (11:33 +1000)]
s4:provision Avoid one more call to ltdb_reindex

The Samba4 schema code (called via
samdb.set_schema_from_ldb(schema.ldb)) manages the @ATTRIBUTES and
@INDEXLIST records, so don't wipe them early.  The chances are that we
will not change them anyway.

Andrew Bartlett

12 years agos4:ldb Remove obsolete comment about ldb_tdb's sequence num
Andrew Bartlett [Mon, 17 Aug 2009 01:20:29 +0000 (11:20 +1000)]
s4:ldb Remove obsolete comment about ldb_tdb's sequence num

12 years agomake sure we update the current schema->prefixes when we add a new prefix
Andrew Tridgell [Mon, 17 Aug 2009 01:13:23 +0000 (11:13 +1000)]
make sure we update the current schema->prefixes when we add a new prefix

This triggered a failure in the updateNow schema test, as the current
global schema was not being updated when a new schema element was

12 years agofixed the updateNow schema test to use a canonical OID
Andrew Tridgell [Mon, 17 Aug 2009 01:12:10 +0000 (11:12 +1000)]
fixed the updateNow schema test to use a canonical OID

The expression time.strftime("%s", time.gmtime())[3:] leads to a
string with a leading 0. When added then read back from the prefix map
this leads to a different string, so it is never found.

Use the simpler str(random.randint(a,b)) expression instead

12 years agos4:selftest Remove the 'subunit filter' from make testenv etc
Andrew Bartlett [Fri, 14 Aug 2009 07:51:14 +0000 (17:51 +1000)]
s4:selftest Remove the 'subunit filter' from make testenv etc

The extra filter is no use for 'testenv', as we are not running tests,
but an xterm.  The filter also breaks running 'GDB_PROVISION=yes make
test', but at least if we can run 'GDB_PROVISION=yes make testenv'
then we can debug provision.

Andrew Bartlett

12 years agos4:libcli/ldap Explain why we set a hostname for ldapi:// connections
Andrew Bartlett [Fri, 14 Aug 2009 07:50:18 +0000 (17:50 +1000)]
s4:libcli/ldap Explain why we set a hostname for ldapi:// connections

It is a pretty odd thing to do, and it's only because of the
restrictions of DIGEST-MD5 in Cyrus SASL that we do it.

Andrew Bartlett

12 years agos4:provision Fix existing ldapi:// backend detection exception
Andrew Bartlett [Sun, 16 Aug 2009 23:52:09 +0000 (09:52 +1000)]
s4:provision Fix existing ldapi:// backend detection exception

Found by Oliver Liebel <>

Andrew Bartlett

12 years agos4:install Remove provision-backend script from 'make install'
Andrew Bartlett [Sun, 16 Aug 2009 23:46:47 +0000 (09:46 +1000)]
s4:install Remove provision-backend script from 'make install'

Spotted by MICHAEL BROWN <>

Andrew Bartlett

12 years agos4:provision Make sure that we don't use Kerberos to our LDAP backend
Andrew Bartlett [Fri, 14 Aug 2009 04:51:44 +0000 (14:51 +1000)]
s4:provision Make sure that we don't use Kerberos to our LDAP backend

This makes no sense, and just causes trouble - we are aiming for

Andrew Bartlett

12 years agos4:provison Print the LDAP backend admin username/password
Andrew Bartlett [Fri, 14 Aug 2009 00:28:56 +0000 (10:28 +1000)]
s4:provison Print the LDAP backend admin username/password

12 years agos4:selftest Confirm that there isn't a listener on the ldapi:// socket
Andrew Bartlett [Fri, 14 Aug 2009 00:21:04 +0000 (10:21 +1000)]
s4:selftest Confirm that there isn't a listener on the ldapi:// socket

This should help debug problems with 'make test' of the LDAP backend,
if a stray listener is still around.

Andrew Bartlett

12 years agos4: Re-add --ldapadminpass as an option to provision
Andrew Bartlett [Thu, 13 Aug 2009 23:37:50 +0000 (09:37 +1000)]
s4: Re-add --ldapadminpass as an option to provision

This should make setting up LDAP servers more predictable.

When not specified, it is random

Andrew Bartlett

12 years agos4:python Allow 'no such object' on the delete of the DN
Andrew Bartlett [Thu, 13 Aug 2009 22:46:13 +0000 (08:46 +1000)]
s4:python Allow 'no such object' on the delete of the DN

This fixes the recursive delete in erase_partitions()

For reasons I cannot understand, it is possible to get 'no such
object' trying to delete a DN I just search for without error.  Oh

Andrew Bartlett

12 years agos4:provision Keep a single transaction for the erase and rebuild
Andrew Bartlett [Thu, 13 Aug 2009 22:29:19 +0000 (08:29 +1000)]
s4:provision Keep a single transaction for the erase and rebuild

Using a single transaction to both erase the bulk of the data and the
rebuild of that data means that the in-memory index list is
maintained, and not written out to disk until it is all compleated.
All the writes then occour at the end.

Andrew Bartlett

12 years agos4:provision A crude update of the OpenLDAP backend HOWTO
Andrew Bartlett [Thu, 13 Aug 2009 09:24:38 +0000 (19:24 +1000)]
s4:provision A crude update of the OpenLDAP backend HOWTO

12 years agos4:provision Fixes for Fedora DS schema mapping with full AD schema
Endi Sukma Dewata [Thu, 13 Aug 2009 09:12:28 +0000 (19:12 +1000)]
s4:provision Fixes for Fedora DS schema mapping with full AD schema

12 years agos4:provision Rework provision-backend into provision
Andrew Bartlett [Thu, 13 Aug 2009 07:01:27 +0000 (17:01 +1000)]
s4:provision Rework provision-backend into provision

This removes a *lot* of duplicated code and the cause of much
administrator frustration.  We now handle starting and stopping the
slapd (at least for the provision), and ensure that there is only one
'right' way to configure the OpenLDAP and Fedora DS backend

We now run OpenLDAP in 'cn=config' mode for online configuration.

To test what was the provision-backend code, a new --ldap-dryrun-mode
option has been added to provision.  It quits the provision just
before it would start the LDAP binaries

Andrew Bartlett

12 years agos4:provision Move helper functions back to provision
Andrew Bartlett [Thu, 13 Aug 2009 06:59:49 +0000 (16:59 +1000)]
s4:provision Move helper functions back to provision

(These will be added back in a future commit)

12 years agos4:setup Don't manually set @ATTRIBUTES any more
Andrew Bartlett [Thu, 13 Aug 2009 06:32:34 +0000 (16:32 +1000)]
s4:setup Don't manually set @ATTRIBUTES any more

We now set these as part of the schema load, and we now load the
schema before the provision loads the DB, so setting them here is

Andrew Bartlett

12 years agos4:python Push some helper functions from SamDB into samba.Ldb
Andrew Bartlett [Thu, 13 Aug 2009 04:37:06 +0000 (14:37 +1000)]
s4:python Push some helper functions from SamDB into samba.Ldb

This makes it possible to do a bit more of the provision with Samba
helpers, but without some of the otherwise useful things (such as
loading in the global schema) that SamDB does.

Rewrite provision_erase to use a recursive search, rather than a
looping subtree search.  This is much more efficient, particularly now
we have one-level indexes enabled.

Delete the @INDEX and similar records *after* deleting all other
visible records, this hopefully also assists performance.

Andrew Bartlett

12 years agos4:schema Allow a schema load on an unconnected database
Andrew Bartlett [Thu, 13 Aug 2009 04:33:57 +0000 (14:33 +1000)]
s4:schema Allow a schema load on an unconnected database

This helps ensure we don't load the schema too often in the provision
(allowing a reference in of the schema before the modules load).

Andrew Bartlett

12 years agos4:provision Remove the ACI element from the provision templates
Andrew Bartlett [Thu, 13 Aug 2009 00:01:00 +0000 (10:01 +1000)]
s4:provision  Remove the ACI element from the provision templates

We need to find a better way to apply this (used in the Fedora DS LDAP
backend), not by trying to tunnel this down the module stack.

Andrew Bartlett

12 years agos4:schema Provide a way to reference a loaded schema between ldbs
Andrew Bartlett [Wed, 12 Aug 2009 23:58:38 +0000 (09:58 +1000)]
s4:schema Provide a way to reference a loaded schema between ldbs

This allows us to load the schema against one ldb context, but apply
it to another.  This will be useful in the provision script, as we
need the schema before we start the LDAP server backend.

Adnrew Bartlett

12 years agos3:winbind: The get[gr|pw]end functions need access to the client state
Volker Lendecke [Sun, 16 Aug 2009 10:46:55 +0000 (12:46 +0200)]
s3:winbind: The get[gr|pw]end functions need access to the client state

12 years agos3:winbind: Convert WINBINDD_GETGRNAM to the new API
Volker Lendecke [Sun, 16 Aug 2009 10:23:31 +0000 (12:23 +0200)]
s3:winbind: Convert WINBINDD_GETGRNAM to the new API

12 years agos3:winbind: Convert WINBINDD_GETGRGID to the new API
Volker Lendecke [Sun, 16 Aug 2009 10:13:00 +0000 (12:13 +0200)]
s3:winbind: Convert WINBINDD_GETGRGID to the new API

12 years agos3:winbind: Add winbindd_print_groupmem
Volker Lendecke [Sun, 16 Aug 2009 10:09:37 +0000 (12:09 +0200)]
s3:winbind: Add winbindd_print_groupmem

This converts a talloc_dict retrieved from wb_group_members to the string
that the pipe protocol expects

12 years agos3:winbind: Make fill_grent publically available
Volker Lendecke [Sun, 16 Aug 2009 10:08:52 +0000 (12:08 +0200)]
s3:winbind: Make fill_grent publically available

12 years agos3:winbind: Add const to normalize_name_map
Volker Lendecke [Sun, 16 Aug 2009 10:07:32 +0000 (12:07 +0200)]
s3:winbind: Add const to normalize_name_map

12 years agos3:winbind: Add async wb_getgrsid
Volker Lendecke [Sun, 16 Aug 2009 09:25:31 +0000 (11:25 +0200)]
s3:winbind: Add async wb_getgrsid

12 years agos3:winbind: Add async wb_group_members
Volker Lendecke [Sun, 16 Aug 2009 08:58:43 +0000 (10:58 +0200)]
s3:winbind: Add async wb_group_members

12 years agos3:winbind: Make wcache_lookup_groupmem available publically
Volker Lendecke [Sat, 8 Aug 2009 14:24:29 +0000 (16:24 +0200)]
s3:winbind: Make wcache_lookup_groupmem available publically

12 years agos3: Add talloc_dict.[ch]
Volker Lendecke [Sun, 16 Aug 2009 08:44:06 +0000 (10:44 +0200)]
s3: Add talloc_dict.[ch]

12 years agos3:winbind: Fix a potential segfault in libwbclient
Volker Lendecke [Sat, 15 Aug 2009 20:04:13 +0000 (22:04 +0200)]
s3:winbind: Fix a potential segfault in libwbclient

12 years agos3:winbind: Convert winbindd_show_sequence to the new API
Volker Lendecke [Sat, 15 Aug 2009 11:23:57 +0000 (13:23 +0200)]
s3:winbind: Convert winbindd_show_sequence to the new API

12 years agos3:winbind: Add async wb_seqnums
Volker Lendecke [Sat, 15 Aug 2009 09:21:16 +0000 (11:21 +0200)]
s3:winbind: Add async wb_seqnums

This is something that would have been very difficult with the old style of
async requests: Send the request to all children simultaneously.

12 years agos3:winbind: Add async wb_seqnum
Volker Lendecke [Sat, 15 Aug 2009 09:16:28 +0000 (11:16 +0200)]
s3:winbind: Add async wb_seqnum

12 years agos3:winbind: WINBIND_USERINFO -> wbint_userinfo
Volker Lendecke [Sun, 9 Aug 2009 11:31:31 +0000 (07:31 -0400)]
s3:winbind: WINBIND_USERINFO -> wbint_userinfo

12 years agos3:winbind: Simplify _wbint_[GU]id2Sid
Volker Lendecke [Sun, 9 Aug 2009 11:17:35 +0000 (07:17 -0400)]
s3:winbind: Simplify _wbint_[GU]id2Sid

12 years agotevent: add some more doxygen comments for tevent_req functions
Stefan Metzmacher [Sat, 15 Aug 2009 07:45:39 +0000 (09:45 +0200)]
tevent: add some more doxygen comments for tevent_req functions


12 years agos3:Makefile: build ../libcli/smb/smb2_create_blob.o as part of smbd
Stefan Metzmacher [Wed, 12 Aug 2009 18:39:11 +0000 (20:39 +0200)]
s3:Makefile: build ../libcli/smb/smb2_create_blob.o as part of smbd


12 years agolibcli/smb: add smb2_create_blob_find()
Stefan Metzmacher [Wed, 12 Aug 2009 18:38:45 +0000 (20:38 +0200)]
libcli/smb: add smb2_create_blob_find()


12 years agoUse defined names rather than numeric constants to make code
Jeremy Allison [Fri, 14 Aug 2009 22:06:11 +0000 (15:06 -0700)]
Use defined names rather than numeric constants to make code

12 years map the file_inherit and dir_inherit flags away for files
Michael Adam [Mon, 10 Aug 2009 16:18:19 +0000 (18:18 +0200)] map the file_inherit and dir_inherit flags away for files

GPFS sets inherits dir_inhert and file_inherit flags
to files, too, which confuses windows, and seems to
be wrong anyways.

So when mapping a nfs4 acl to a windows acl, we map these
flags away for files.


12 years agocifs.upcall: fix IPv6 addrs sent to upcall to have colon delimiters
Jeff Layton [Fri, 14 Aug 2009 11:59:51 +0000 (07:59 -0400)]
cifs.upcall: fix IPv6 addrs sent to upcall to have colon delimiters

Current kernels don't send IPv6 addresses with the colon delimiters, add
a routine to add them when they're not present.

Signed-off-by: Jeff Layton <>
12 years agocifs.upcall: use ip address passed by kernel to get server's hostname
Jeff Layton [Fri, 14 Aug 2009 11:59:50 +0000 (07:59 -0400)]
cifs.upcall: use ip address passed by kernel to get server's hostname

Instead of using the hostname given by the upcall to get the server's
principal, take the IP address given in the upcall and reverse resolve
it to a hostname.

Signed-off-by: Jeff Layton <>
12 years agocifs.upcall: clean up flag handling
Jeff Layton [Fri, 14 Aug 2009 11:59:50 +0000 (07:59 -0400)]
cifs.upcall: clean up flag handling

Add a new stack var to hold the flags returned by the decoder routine
so that we don't need to worry so much about preserving "rc".

With this, we can drop privs before trying to find the location of
the credcache.

Signed-off-by: Jeff Layton <>
12 years agocifs.upcall: try getting a "cifs/" principal and fall back to "host/"
Jeff Layton [Fri, 14 Aug 2009 11:59:50 +0000 (07:59 -0400)]
cifs.upcall: try getting a "cifs/" principal and fall back to "host/"

cifs.upcall takes a "-c" flag that tells the upcall to get a principal
in the form of "cifs/" instead of
"host/". This has turned out to be a source of
great confusion for users.

Instead of requiring this flag, have the upcall try to get a "cifs/"
principal first. If that fails, fall back to getting a "host/"

Signed-off-by: Jeff Layton <>
12 years agocifs.upcall: declare a structure for holding decoded args
Jeff Layton [Fri, 14 Aug 2009 11:59:49 +0000 (07:59 -0400)]
cifs.upcall: declare a structure for holding decoded args

The argument list for the decoder is becoming rather long. Declare an
args structure and use that for holding the args. This also simplifies
pointer handling a bit.

Signed-off-by: Jeff Layton <>
12 years agocifs.upcall: formatting cleanup
Jeff Layton [Fri, 14 Aug 2009 11:59:49 +0000 (07:59 -0400)]
cifs.upcall: formatting cleanup

Clean up some unneeded curly braces, and fix some indentation.

Signed-off-by: Jeff Layton <>
12 years agocifs.upcall: clean up logging and add debug messages
Jeff Layton [Fri, 14 Aug 2009 11:59:49 +0000 (07:59 -0400)]
cifs.upcall: clean up logging and add debug messages

Change the log levels to be more appropriate to the messages being
logged. Error messages should be LOG_ERR and not LOG_WARNING, for

Add some LOG_DEBUG messages that we can use to diagnose problems with
krb5 upcalls. With these, someone can set up syslog to log daemon.debug
and should be able to get more info when things aren't working.

Signed-off-by: Jeff Layton <>
12 years agos3:smbd: allow SMB2 Cancel to have the async flag set
Stefan Metzmacher [Fri, 14 Aug 2009 09:24:30 +0000 (11:24 +0200)]
s3:smbd: allow SMB2 Cancel to have the async flag set


12 years agos3:smbd: fix parsing of the SMB2 body
Stefan Metzmacher [Fri, 14 Aug 2009 09:14:42 +0000 (11:14 +0200)]
s3:smbd: fix parsing of the SMB2 body

Maybe there's no dynamic part on the wire.


12 years agos4:samdb python bindings - we don't need the attributes here
Matthias Dieter Wallnöfer [Thu, 13 Aug 2009 23:42:12 +0000 (01:42 +0200)]
s4:samdb python bindings - we don't need the attributes here

12 years agos4:ldb - Free the asynchronous result
Matthias Dieter Wallnöfer [Thu, 13 Aug 2009 23:39:56 +0000 (01:39 +0200)]
s4:ldb - Free the asynchronous result

12 years agos4: Correct the parameter logic of the "setpassword" script
Matthias Dieter Wallnöfer [Thu, 13 Aug 2009 21:04:34 +0000 (23:04 +0200)]
s4: Correct the parameter logic of the "setpassword" script

Either the username or the filter are allowed. If both are given the filter is
going to be used due to a higher precedence.

12 years agos4: Better way to call "dom_sid_to_rid" from
Matthias Dieter Wallnöfer [Thu, 13 Aug 2009 09:37:38 +0000 (11:37 +0200)]
s4: Better way to call "dom_sid_to_rid" from

12 years agos4: Remove obsolete "samdb_password_quality_ok" function (it's just a one-line wrapper)
Matthias Dieter Wallnöfer [Thu, 13 Aug 2009 08:43:42 +0000 (10:43 +0200)]
s4: Remove obsolete "samdb_password_quality_ok" function (it's just a one-line wrapper)

12 years agos4: cracknames.c: Change the handling of the NT_STATUS_NO_MEMORY status results
Matthias Dieter Wallnöfer [Thu, 13 Aug 2009 07:50:19 +0000 (09:50 +0200)]
s4: cracknames.c: Change the handling of the NT_STATUS_NO_MEMORY status results

With the previous check I got random failures when trying to connect to the
LDAP server.

12 years agos4:ldap_server Correct removal of talloc_steal()
Andrew Bartlett [Fri, 14 Aug 2009 03:10:42 +0000 (13:10 +1000)]
s4:ldap_server Correct removal of talloc_steal()

This corrects commit 7a82aed71b74af8bc2a8a4381541adbb22452d20.  The
steal did not set ent->attributes, so it was incorrect to assign to

Andrew Bartlett

12 years agofixed TESTS= in make test to allow multiple tests
Andrew Tridgell [Fri, 14 Aug 2009 03:04:21 +0000 (13:04 +1000)]
fixed TESTS= in make test to allow multiple tests

Now you can do: make test TESTS="test1 test2" and it will run those
two tests, each matching tests using a case insensitive substring

12 years agos4:ldap_server Remove another talloc_steal (with references)
Andrew Bartlett [Fri, 14 Aug 2009 02:57:46 +0000 (12:57 +1000)]
s4:ldap_server Remove another talloc_steal (with references)

This talloc_steal also conflicts with the ldb_map code, and like the
previous commit, is rudundent given the talloc_steal of the whole msg

Andrew Bartlett

12 years agos4:ldap_server Don't talloc_steal (with references) in ldap_backend
Andrew Bartlett [Fri, 14 Aug 2009 02:48:10 +0000 (12:48 +1000)]
s4:ldap_server Don't talloc_steal (with references) in ldap_backend

There may or may not be a need to take a reference to the 'name' in
the ldb_map code, but given we seal the whole msg just above here, it
makes no senst to steal the name, but not the values.

Andrew Bartlett

12 years agoFix EVERY SINGLE build on the buildfarm that doesn't have
Jeremy Allison [Thu, 13 Aug 2009 00:44:48 +0000 (17:44 -0700)]
Fix EVERY SINGLE build on the buildfarm that doesn't have
bindtextdomain or textdomain. C'mon, this is what
is *FOR*.

12 years agoMove build over to storing DOS attributes in EA's.
Jeremy Allison [Thu, 13 Aug 2009 00:07:13 +0000 (17:07 -0700)]
Move build over to storing DOS attributes in EA's.
Turn off "map to" directives. I've now fixed the
issues with the build tests running this way. I think
this is how most people run these days - please raise this on
the list (or revert) if you disagree.

12 years agoWhen mapping EA's into a TDB, don't remove the EA
Jeremy Allison [Wed, 12 Aug 2009 23:27:17 +0000 (16:27 -0700)]
When mapping EA's into a TDB, don't remove the EA
until the last link to the file is gone (fixes the
build farm RAW-RENAME test with xattr's in tdb's).

12 years agoFix BASE-DELAYWRITE test by removing const from struct smb_filename
Jeremy Allison [Wed, 12 Aug 2009 22:08:23 +0000 (15:08 -0700)]
Fix BASE-DELAYWRITE test by removing const from struct smb_filename
in smbd_do_qfilepathinfo(). update_stat_ex_mtime() modifies the
stat struct inside the smb_fname so don't make a copy of that
stat struct, use it directly - it's meant to be updated and
represent the state of the file we're returning.

12 years agoDocumentation for "store create time".
Jeremy Allison [Wed, 12 Aug 2009 20:54:38 +0000 (13:54 -0700)]
Documentation for "store create time".

12 years agoAdd "store create time" parameter (docs to follow)
Jeremy Allison [Wed, 12 Aug 2009 20:00:54 +0000 (13:00 -0700)]
Add "store create time" parameter (docs to follow)
that stores the create time in the user.DosTimestamps EA.

12 years agoFix some warnings in the AIX ACL code.
Jeremy Allison [Wed, 12 Aug 2009 17:58:00 +0000 (10:58 -0700)]
Fix some warnings in the AIX ACL code.

12 years agolibcli/smb: move smb2_create_blob code to libcli/smb/
Stefan Metzmacher [Wed, 12 Aug 2009 15:43:03 +0000 (17:43 +0200)]
libcli/smb: move smb2_create_blob code to libcli/smb/

I want to use this in source3/smbd/


12 years agolibcli: move some common SMB and SMB2 stuff into libcli/smb/
Stefan Metzmacher [Wed, 12 Aug 2009 15:52:55 +0000 (17:52 +0200)]
libcli: move some common SMB and SMB2 stuff into libcli/smb/

This will hold code that's shared between source3 and source4.


12 years agolibrpc: rerun "make idl_full"
Kai Blin [Wed, 12 Aug 2009 15:59:46 +0000 (17:59 +0200)]
librpc: rerun "make idl_full"

12 years agos3:smbd: as check_path_syntax() changes the string, we need to copy the string before
Stefan Metzmacher [Tue, 11 Aug 2009 16:31:27 +0000 (18:31 +0200)]
s3:smbd: as check_path_syntax() changes the string, we need to copy the string before


12 years agos3:smbd: avoid 'goto out' in smbd_smb2_create_send()
Stefan Metzmacher [Tue, 11 Aug 2009 16:29:06 +0000 (18:29 +0200)]
s3:smbd: avoid 'goto out' in smbd_smb2_create_send()


12 years agos3:smbd: make sure we don't call conn_free() with a NULL pointer for SMB2
Stefan Metzmacher [Tue, 11 Aug 2009 16:09:05 +0000 (18:09 +0200)]
s3:smbd: make sure we don't call conn_free() with a NULL pointer for SMB2