ira/wip.git
13 years agos3: remove unused regval_convert_multi_sz().
Günther Deschner [Thu, 24 Sep 2009 23:00:24 +0000 (01:00 +0200)]
s3: remove unused regval_convert_multi_sz().

Guenther

13 years agos3: remove unused regval_build_multi_sz().
Günther Deschner [Thu, 24 Sep 2009 22:37:02 +0000 (00:37 +0200)]
s3: remove unused regval_build_multi_sz().

Guenther

13 years agos3-rpc_parse: remove unused UNISTR2 struct and init function.
Günther Deschner [Wed, 23 Sep 2009 18:48:25 +0000 (20:48 +0200)]
s3-rpc_parse: remove unused UNISTR2 struct and init function.

Guenther

13 years agos3: use pull_reg_multi_sz in rpcclient and net.
Günther Deschner [Tue, 29 Sep 2009 21:22:46 +0000 (23:22 +0200)]
s3: use pull_reg_multi_sz in rpcclient and net.

Guenther

13 years agos3-util: use pull_reg_multi_sz in reg_pull_multi_sz.
Günther Deschner [Fri, 25 Sep 2009 09:35:46 +0000 (11:35 +0200)]
s3-util: use pull_reg_multi_sz in reg_pull_multi_sz.

Guenther

13 years agos3-registry: use pull_reg_multi_sz().
Günther Deschner [Thu, 24 Sep 2009 22:55:56 +0000 (00:55 +0200)]
s3-registry: use pull_reg_multi_sz().

Guenther

13 years agos3-util: add pull_reg_sz() and pull_reg_multi_sz() convenience functions.
Günther Deschner [Thu, 24 Sep 2009 22:56:17 +0000 (00:56 +0200)]
s3-util: add pull_reg_sz() and pull_reg_multi_sz() convenience functions.

Guenther

13 years agos3: use push_reg_multi_sz().
Günther Deschner [Thu, 24 Sep 2009 22:36:43 +0000 (00:36 +0200)]
s3: use push_reg_multi_sz().

Guenther

13 years agos3-registry: use regval_ctr_addvalue_sz().
Günther Deschner [Thu, 24 Sep 2009 13:01:32 +0000 (15:01 +0200)]
s3-registry: use regval_ctr_addvalue_sz().

Greatly simplifies and cleanes up the code.

Guenther

13 years agos3-registry: add regval_ctr_addvalue_sz.
Günther Deschner [Thu, 24 Sep 2009 09:30:45 +0000 (11:30 +0200)]
s3-registry: add regval_ctr_addvalue_sz.

Guenther

13 years agos3-registry: use push_reg_sz().
Günther Deschner [Wed, 23 Sep 2009 18:46:08 +0000 (20:46 +0200)]
s3-registry: use push_reg_sz().

Guenther

13 years agos3-util: add push_reg_sz() and push_reg_multi_sz() convenience functions.
Günther Deschner [Wed, 23 Sep 2009 18:42:20 +0000 (20:42 +0200)]
s3-util: add push_reg_sz() and push_reg_multi_sz() convenience functions.

Guenther

13 years agos3: re-run make idl_full.
Günther Deschner [Tue, 29 Sep 2009 21:33:48 +0000 (23:33 +0200)]
s3: re-run make idl_full.

Guenther

13 years agowinreg: add winreg_Data union to IDL.
Günther Deschner [Wed, 23 Sep 2009 18:41:44 +0000 (20:41 +0200)]
winreg: add winreg_Data union to IDL.

Guenther

13 years agos3: Document the "share:fake_fscaps" parameter, fix bug 6765
Volker Lendecke [Tue, 29 Sep 2009 12:34:16 +0000 (14:34 +0200)]
s3: Document the "share:fake_fscaps" parameter, fix bug 6765

13 years agos3: Remove the lua interpreter again
Volker Lendecke [Tue, 29 Sep 2009 11:11:20 +0000 (13:11 +0200)]
s3: Remove the lua interpreter again

This was meant to support async winbind. But as the hairy parts of async
winbind (getgrent) are done without it, it can go again.

13 years agopidl: added union padding for NDR64
Andrew Tridgell [Tue, 29 Sep 2009 07:47:54 +0000 (17:47 +1000)]
pidl: added union padding for NDR64

This fixes the problem with samr UserInfo16 when NDR64 is enabled

13 years agoDon't defer a talloc_move'd pointer.
Jeremy Allison [Tue, 29 Sep 2009 04:36:15 +0000 (21:36 -0700)]
Don't defer a talloc_move'd pointer.
Jeremy.

13 years agoSecond part of fix for bug #6235 - domain enumeration breaks if master browser has...
Jeremy Allison [Mon, 28 Sep 2009 18:23:30 +0000 (11:23 -0700)]
Second part of fix for bug #6235 - domain enumeration breaks if master browser has space in name.
Ensure we ask for the #20 name as we're using it as a server.
Jeremy.

13 years agos3:winbind: remove a pointless initialization
Volker Lendecke [Mon, 28 Sep 2009 17:50:24 +0000 (19:50 +0200)]
s3:winbind: remove a pointless initialization

13 years agos3:gencache: Add my copyright
Volker Lendecke [Sun, 20 Sep 2009 16:10:01 +0000 (18:10 +0200)]
s3:gencache: Add my copyright

13 years agos3:winbind: Make check_info3_in_group, sanitize its memory handling
Volker Lendecke [Sun, 27 Sep 2009 10:47:24 +0000 (12:47 +0200)]
s3:winbind: Make check_info3_in_group, sanitize its memory handling

13 years agos3:winbind: Make "check_request_flags" publically available
Volker Lendecke [Sun, 27 Sep 2009 09:51:07 +0000 (11:51 +0200)]
s3:winbind: Make "check_request_flags" publically available

13 years agos3:winbind: Sanitize the args for find_auth_domain: It only needs the flags
Volker Lendecke [Sun, 27 Sep 2009 09:49:11 +0000 (11:49 +0200)]
s3:winbind: Sanitize the args for find_auth_domain: It only needs the flags

13 years agos3:winbind: Make append_data publically available as append_auth_data
Volker Lendecke [Sun, 27 Sep 2009 09:39:38 +0000 (11:39 +0200)]
s3:winbind: Make append_data publically available as append_auth_data

13 years agos3/VERSION: Raise version up to 3.5.0.
Karolin Seeger [Mon, 28 Sep 2009 14:57:29 +0000 (16:57 +0200)]
s3/VERSION: Raise version up to 3.5.0.

Karolin

13 years agochanged debuglevel for two messages in the GPFS module from 0 to 10 they spammed...
Christian Ambach [Sun, 27 Sep 2009 21:34:04 +0000 (23:34 +0200)]
changed debuglevel for two messages in the GPFS module from 0 to 10 they spammed the logs on a test machine and they are just debug messages, so let's move them to the level of the other debug messages in the file

Signed-off-by: Christian Ambach <christian.ambach@de.ibm.com>
13 years agopidl: Avoid using talloc_free as function pointer, since it may be a
Jelmer Vernooij [Mon, 28 Sep 2009 13:03:17 +0000 (15:03 +0200)]
pidl: Avoid using talloc_free as function pointer, since it may be a
macro.

13 years agoMove samba-specific variable to s4 Makefile.
Jelmer Vernooij [Mon, 28 Sep 2009 10:25:13 +0000 (12:25 +0200)]
Move samba-specific variable to s4 Makefile.

13 years agomake: Use $(base_srcdirs) in 'make clean' rather than keeping a separate
Jelmer Vernooij [Mon, 28 Sep 2009 10:21:06 +0000 (12:21 +0200)]
make: Use $(base_srcdirs) in 'make clean' rather than keeping a separate
list.

13 years agos4-kcc: fixed corruption of repsFrom records by kcc
Andrew Tridgell [Mon, 28 Sep 2009 05:16:06 +0000 (15:16 +1000)]
s4-kcc: fixed corruption of repsFrom records by kcc

We were re-using a stack variable outside of the stack scope

13 years agos4-kcc: remove stale repsFrom entries in kcc run
Andrew Tridgell [Mon, 28 Sep 2009 03:10:13 +0000 (13:10 +1000)]
s4-kcc: remove stale repsFrom entries in kcc run

13 years agos4-dsdb: don't return the partition root objects
Andrew Tridgell [Mon, 28 Sep 2009 02:28:59 +0000 (12:28 +1000)]
s4-dsdb: don't return the partition root objects

When searching across partitions, we want to avoid sending duplicate
records caused by the record appearing both as a mount point and as a
partition root in a nested partition. This patch works by intercepting
objects from searches and checking if they match a partition root. If
they do, and the partition is not the one in the partition control
request, then discard the object.

13 years agos4-make: add libds to etags/ctags source list
Andrew Tridgell [Mon, 28 Sep 2009 01:06:35 +0000 (11:06 +1000)]
s4-make: add libds to etags/ctags source list

13 years agos4-libnet: fixed debug formatting
Andrew Tridgell [Sat, 26 Sep 2009 03:47:06 +0000 (20:47 -0700)]
s4-libnet: fixed debug formatting

13 years agos4-dsdb: removed extraneous debug messages
Andrew Tridgell [Sat, 26 Sep 2009 03:46:53 +0000 (20:46 -0700)]
s4-dsdb: removed extraneous debug messages

13 years agos4-dsdb: update replPropertyMetaData on linked attribute source attributes
Andrew Tridgell [Sat, 26 Sep 2009 03:38:20 +0000 (20:38 -0700)]
s4-dsdb: update replPropertyMetaData on linked attribute source attributes

13 years agos4-dsdb: fixed searching for GUID based DNs between partitions
Andrew Tridgell [Sat, 26 Sep 2009 03:37:45 +0000 (20:37 -0700)]
s4-dsdb: fixed searching for GUID based DNs between partitions

13 years agos4-drs: removed debug code that replicated a maximum of 10 objects at a time
Andrew Tridgell [Fri, 25 Sep 2009 22:54:00 +0000 (15:54 -0700)]
s4-drs: removed debug code that replicated a maximum of 10 objects at a time

13 years agos4-drsuapi: state variable for getncchanges
Andrew Tridgell [Fri, 25 Sep 2009 22:18:02 +0000 (15:18 -0700)]
s4-drsuapi: state variable for getncchanges

13 years agos4-dsruapi: plugfest updates
Andrew Tridgell [Fri, 25 Sep 2009 22:17:44 +0000 (15:17 -0700)]
s4-dsruapi: plugfest updates

- always fetch parentGUID from databases, don't rely on parentGUID in
  attributes

- re-fetch nc root mesages to avoid the problem of dual messages for
  roots

- support returning messages a chunk at a time, using max_object_count
  from request

13 years agos4-drsutil: allow NULL filter
Andrew Tridgell [Fri, 25 Sep 2009 22:15:23 +0000 (15:15 -0700)]
s4-drsutil: allow NULL filter

13 years agos4-ldap: fixed spelling
Andrew Tridgell [Fri, 25 Sep 2009 22:14:59 +0000 (15:14 -0700)]
s4-ldap: fixed spelling

13 years agos4-samdb: when UF_SERVER_TRUST_ACCOUNT is set mark object as critical
Andrew Tridgell [Fri, 25 Sep 2009 22:14:43 +0000 (15:14 -0700)]
s4-samdb: when UF_SERVER_TRUST_ACCOUNT is set mark object as critical

We may also need to remove the isCriticalSystemObject when the machine
is demoted

13 years agos4-repl: free the la list on prepare commit failure
Andrew Tridgell [Fri, 25 Sep 2009 22:13:09 +0000 (15:13 -0700)]
s4-repl: free the la list on prepare commit failure

13 years agos4-samdb: free the linked_attributes list on prepare commit failure
Andrew Tridgell [Fri, 25 Sep 2009 22:12:52 +0000 (15:12 -0700)]
s4-samdb: free the linked_attributes list on prepare commit failure

13 years agos4-repl: use GUID to resolve target in linked attributes
Andrew Tridgell [Fri, 25 Sep 2009 03:15:11 +0000 (20:15 -0700)]
s4-repl: use GUID to resolve target in linked attributes

When we vampire from w2k8-r2, the DC sends us a linked attribute for
our machine account which has a target DN with a GUID of the OU=Domain
Controllers objects, but has a DN of CN=Computers. We need to use the
GUID to resolve the real DN.

13 years agos4-dsdb: ask for an extended DN in dsdb_find_dn_by_guid()
Andrew Tridgell [Fri, 25 Sep 2009 03:13:22 +0000 (20:13 -0700)]
s4-dsdb: ask for an extended DN in dsdb_find_dn_by_guid()

13 years agos4-dsdb: make dsdb_search_dn_with_deleted public for repl_meta_data module
Andrew Tridgell [Fri, 25 Sep 2009 00:20:34 +0000 (17:20 -0700)]
s4-dsdb: make dsdb_search_dn_with_deleted public for repl_meta_data module

13 years agos4-acl: fixed SD creation
Andrew Tridgell [Thu, 24 Sep 2009 23:53:06 +0000 (16:53 -0700)]
s4-acl: fixed SD creation

Thanks for Nadya and Metze for this. The SDs were being created with
invalid fields (noticed by w2k8-r2 client when joining our domain)

13 years agolibds: fixed spelling error
Andrew Tridgell [Thu, 24 Sep 2009 23:51:15 +0000 (16:51 -0700)]
libds: fixed spelling error

13 years agos4-drs: fixed sorting of replPropertyMetaData
Andrew Tridgell [Thu, 24 Sep 2009 23:50:59 +0000 (16:50 -0700)]
s4-drs: fixed sorting of replPropertyMetaData

This also ensures we add the SHOW_DELETED control on searches for old
replPropertyMetaData attributes

13 years agoparmlist: Add more tests.
Jelmer Vernooij [Sun, 27 Sep 2009 15:37:53 +0000 (17:37 +0200)]
parmlist: Add more tests.

13 years agorpc_server: Fix warnings.
Jelmer Vernooij [Sun, 27 Sep 2009 14:49:26 +0000 (16:49 +0200)]
rpc_server: Fix warnings.

13 years agolibrpc: Fix path to ndr_standard pc file.
Jelmer Vernooij [Sun, 27 Sep 2009 14:43:01 +0000 (16:43 +0200)]
librpc: Fix path to ndr_standard pc file.

13 years agoselftest: Prefer system tap2subunit if available.
Jelmer Vernooij [Sun, 27 Sep 2009 14:34:59 +0000 (16:34 +0200)]
selftest: Prefer system tap2subunit if available.

13 years agoparmlist: Add basic tests for test_get_int().
Jelmer Vernooij [Sun, 27 Sep 2009 12:39:58 +0000 (14:39 +0200)]
parmlist: Add basic tests for test_get_int().

13 years agoutil/parmlist: Add some more comments.
Jelmer Vernooij [Sun, 27 Sep 2009 12:13:38 +0000 (14:13 +0200)]
util/parmlist: Add some more comments.

13 years agolibutil: Add separate utility code for dealing with settings as a
Jelmer Vernooij [Sat, 26 Sep 2009 21:59:35 +0000 (23:59 +0200)]
libutil: Add separate utility code for dealing with settings as a
collection of key/value pairs.

13 years agogensec: Avoid exposing lp_ctx on the API level.
Jelmer Vernooij [Sat, 26 Sep 2009 18:55:18 +0000 (20:55 +0200)]
gensec: Avoid exposing lp_ctx on the API level.

13 years agopygensec: Add initial work on a gensec Python module.
Jelmer Vernooij [Sat, 26 Sep 2009 17:41:59 +0000 (19:41 +0200)]
pygensec: Add initial work on a gensec Python module.

13 years agoregshell: Add support for 'cd ..' and cd relative to the root.
Wilco Baan Hofman [Sat, 26 Sep 2009 15:05:34 +0000 (17:05 +0200)]
regshell: Add support for 'cd ..' and cd relative to the root.

Signed-off-by: Jelmer Vernooij <jelmer@samba.org>
13 years agoregistry: Fix warning freeing talloc pointer with multiple parents.
Jelmer Vernooij [Sat, 26 Sep 2009 13:41:22 +0000 (15:41 +0200)]
registry: Fix warning freeing talloc pointer with multiple parents.

13 years agoldb: Check for talloc using pkg-config before checking manually, so we
Jelmer Vernooij [Sat, 26 Sep 2009 11:53:27 +0000 (13:53 +0200)]
ldb: Check for talloc using pkg-config before checking manually, so we
find version errors.

13 years agos4/make: Remove object files in ../libds as part of "make clean".
Jelmer Vernooij [Sat, 26 Sep 2009 10:51:49 +0000 (12:51 +0200)]
s4/make: Remove object files in ../libds as part of "make clean".

13 years agoFix the opaque sample module for the new VFS interface.
Jeremy Allison [Sat, 26 Sep 2009 05:19:27 +0000 (22:19 -0700)]
Fix the opaque sample module for the new VFS interface.
Jeremy.

13 years agoUpdate the advice for the new VFS system.
Jeremy Allison [Sat, 26 Sep 2009 05:02:18 +0000 (22:02 -0700)]
Update the advice for the new VFS system.
Jeremy.

13 years agoRemove unused static fn.
Jeremy Allison [Sat, 26 Sep 2009 04:43:13 +0000 (21:43 -0700)]
Remove unused static fn.
Jeremy.

13 years agoRewrite vfs_transparent example for the new VFS changes.
Jeremy Allison [Sat, 26 Sep 2009 04:39:52 +0000 (21:39 -0700)]
Rewrite vfs_transparent example for the new VFS changes.
Jeremy.

13 years agoFix vfs module sample for new interface.
Jeremy Allison [Sat, 26 Sep 2009 03:51:50 +0000 (20:51 -0700)]
Fix vfs module sample for new interface.
Jeremy.

13 years agosamba.tests.provision: Remove broken become_dc test.
Jelmer Vernooij [Sat, 26 Sep 2009 00:38:09 +0000 (02:38 +0200)]
samba.tests.provision: Remove broken become_dc test.

13 years agopidl(s4.python): Fix arguments to PyCObject_FromVoidPtr for string_array's.
Jelmer Vernooij [Fri, 25 Sep 2009 23:34:22 +0000 (01:34 +0200)]
pidl(s4.python): Fix arguments to PyCObject_FromVoidPtr for string_array's.

Caught by Guenther.

13 years agopythonbindings: allow add() to have an array of controls as second parameter
Matthieu Patou [Tue, 22 Sep 2009 20:51:25 +0000 (00:51 +0400)]
pythonbindings: allow add() to have an array of controls as second parameter

Signed-off-by: Jelmer Vernooij <jelmer@samba.org>
13 years agoFixing timeval calculation
Simo Sorce [Fri, 25 Sep 2009 14:59:04 +0000 (10:59 -0400)]
Fixing timeval calculation

The code was always doubling microseconds when attempting to round up.

13 years agolib/util: fix build warning.
Günther Deschner [Fri, 25 Sep 2009 10:17:17 +0000 (12:17 +0200)]
lib/util: fix build warning.

Guenther

13 years agos4:LDIFs - enhance the section comments
Matthias Dieter Wallnöfer [Wed, 23 Sep 2009 17:40:14 +0000 (19:40 +0200)]
s4:LDIFs - enhance the section comments

13 years agos4:auth/gensec/schannel - fix a const warning
Matthias Dieter Wallnöfer [Fri, 25 Sep 2009 08:43:42 +0000 (10:43 +0200)]
s4:auth/gensec/schannel - fix a const warning

13 years agos3:smbd/password - move list pointers into blocks
Matthias Dieter Wallnöfer [Fri, 25 Sep 2009 08:17:17 +0000 (10:17 +0200)]
s3:smbd/password - move list pointers into blocks

13 years agos3-libndr: fix build warning.
Günther Deschner [Thu, 24 Sep 2009 21:39:18 +0000 (23:39 +0200)]
s3-libndr: fix build warning.

Guenther

13 years agos3:winbindd_cm: don't invalidate the whole connection when just samr gave ACCCESS_DENIED
Stefan Metzmacher [Thu, 24 Sep 2009 19:35:38 +0000 (21:35 +0200)]
s3:winbindd_cm: don't invalidate the whole connection when just samr gave ACCCESS_DENIED

metze

13 years agos4:schannel: fix some compiler warnings
Stefan Metzmacher [Thu, 17 Sep 2009 23:54:22 +0000 (01:54 +0200)]
s4:schannel: fix some compiler warnings

If we only do signing we can pass down a const data buffer.

metze

13 years agos3:rpc_client: don't randomly fragment rpc pdu's in developer mode
Stefan Metzmacher [Sun, 20 Sep 2009 21:29:11 +0000 (23:29 +0200)]
s3:rpc_client: don't randomly fragment rpc pdu's in developer mode

This is really confusing and also breaks against windows,
as it doesn't accept fragmented bind requests.

metze

13 years agoMerge branch 'master' of git://git.samba.org/samba
Nadezhda Ivanova [Fri, 25 Sep 2009 01:57:27 +0000 (18:57 -0700)]
Merge branch 'master' of git://git.samba.org/samba

13 years agoFixed a dereferenced null pointer.
Nadezhda Ivanova [Fri, 25 Sep 2009 01:29:57 +0000 (18:29 -0700)]
Fixed a dereferenced null pointer.

13 years agomount.cifs: print output to stderr
Jeff Layton [Fri, 25 Sep 2009 00:55:43 +0000 (20:55 -0400)]
mount.cifs: print output to stderr

When a mount fails, mount.cifs often prints an error message. In most
cases, this error goes to stdout instead of stderr like it should. Fix
it to print errors to stderr instead.

Reported-by: Jan Engelhardt <jengelh@gmx.de>
Signed-off-by: Jeff Layton <jlayton@redhat.com>
13 years agoReduce debug log level from 0 -> 7 on non-critical message.
Jeremy Allison [Fri, 25 Sep 2009 00:44:45 +0000 (17:44 -0700)]
Reduce debug log level from 0 -> 7 on non-critical message.
Jeremy.

13 years agoPatches to fix typos thanks to OPC oota.
John H Terpstra [Fri, 25 Sep 2009 00:26:03 +0000 (19:26 -0500)]
Patches to fix typos thanks to OPC oota.

13 years agoBug fix thanks to vjbangis viray
John H Terpstra [Fri, 25 Sep 2009 00:18:33 +0000 (19:18 -0500)]
Bug fix thanks to vjbangis viray

13 years agoRemove the const from the str_list_XXX functions that
Jeremy Allison [Thu, 24 Sep 2009 22:52:58 +0000 (15:52 -0700)]
Remove the const from the str_list_XXX functions that
allocate both list and containing strings. This fixes
problems that people have tried to cast away and are
not needed.
Jeremy.

13 years agoRevert b39c390280d1f268e2550c731057aec550a3f086 - casts should not
Jeremy Allison [Thu, 24 Sep 2009 22:44:28 +0000 (15:44 -0700)]
Revert b39c390280d1f268e2550c731057aec550a3f086 - casts should not
be here.
Jeremy.

13 years agoRevert 918b5a7e057bd91289ec06b3ef8d95da43a50ede. This code
Jeremy Allison [Thu, 24 Sep 2009 22:42:36 +0000 (15:42 -0700)]
Revert 918b5a7e057bd91289ec06b3ef8d95da43a50ede. This code
should *not* return const.
Jeremy.

13 years agos3: Fix up various string "const" warnings
Matthias Dieter Wallnöfer [Thu, 24 Sep 2009 21:52:19 +0000 (23:52 +0200)]
s3: Fix up various string "const" warnings

My changed introduced some warnings. Fix them.

13 years agos3:util_str "str_list_make_v3" - introduce also here the "const" result
Matthias Dieter Wallnöfer [Thu, 24 Sep 2009 21:50:05 +0000 (23:50 +0200)]
s3:util_str "str_list_make_v3" - introduce also here the "const" result

I did this to match with the default util strlist library.

13 years agos3:vfs_default - correct function parameters
Matthias Dieter Wallnöfer [Thu, 24 Sep 2009 21:49:41 +0000 (23:49 +0200)]
s3:vfs_default - correct function parameters

13 years agos3-winbindd: no reason to call winbindd_can_contact_domain() three times in query_user().
Günther Deschner [Thu, 24 Sep 2009 16:20:50 +0000 (18:20 +0200)]
s3-winbindd: no reason to call winbindd_can_contact_domain() three times in query_user().

Guenther

13 years agos3: remove unused printing macros.
Günther Deschner [Thu, 24 Sep 2009 16:20:13 +0000 (18:20 +0200)]
s3: remove unused printing macros.

Guenther

13 years agos3 onefs: Fix 1 second share mode delay handling
Steven Danneman [Thu, 14 May 2009 23:14:03 +0000 (23:14 +0000)]
s3 onefs: Fix 1 second share mode delay handling

When racing to the open and loosing we may get a share_mode violation.
In this case handle the 1-second delay via a defferred open properly.

This requires us to retrieve the share_mode_lock before deferring
open so we don't dereference a NULL pointer assuming we already had
the lck because we were the first opener.

13 years agos3 onefs: Fix a race condition exists in onefs_open.c between multiple opens to the...
Steven Danneman [Thu, 14 May 2009 23:12:23 +0000 (23:12 +0000)]
s3 onefs: Fix a race condition exists in onefs_open.c between multiple opens to the same file.

Two openers can stat a file at the same time, see that it doesn't exist,
and then both race to open it first.  The loser will enter
onefs_open_file_ntcreate believing that the file doesnt exist, and thus
skip any current state lookups for that file.  This includes setting
the file_id, and having a valid stat buffer.

Normally on first create the file_id will be set during the open, but
the second opener in this scenario may fail the open (oplock/share mode)
and file_id will not be set, nor will the stat buffer be valid.

In the error paths of this patch, we now double check that the file_id
and the stat buffer are valid before doing other operations.

13 years agos3 onefs: Add some debugging/asserts to give more info when there is bad deferred...
Zack Kirsch [Wed, 22 Apr 2009 23:30:55 +0000 (23:30 +0000)]
s3 onefs: Add some debugging/asserts to give more info when there is bad deferred open state.

Signed-off-by: Tim Prouty <tprouty@samba.org>
13 years agos4 torture: Fix RAW-STREAMS to request more specific permissions
Tim Prouty [Fri, 28 Aug 2009 22:53:09 +0000 (22:53 +0000)]
s4 torture: Fix RAW-STREAMS to request more specific permissions

This allows RAW-STREAMS to pass when the user isn't root on some
systems that don't give full access rights to non-root users.