ira/wip.git
13 years agor16998: patch from Paul Griffith <paulg@cs.yorku.ca> to fix compile of the test.c...
Gerald Carter [Wed, 12 Jul 2006 21:05:11 +0000 (21:05 +0000)]
r16998: patch from Paul Griffith <paulg@cs.yorku.ca> to fix compile of the test.c pdb file
(This used to be commit 34ad8e183cf882913c32b4d03c9ab5fc09181ad2)

13 years agor16997: Simo's patch (based on repotr from Seth Elssworth of Quest) to try to be...
Gerald Carter [Wed, 12 Jul 2006 21:02:22 +0000 (21:02 +0000)]
r16997: Simo's patch (based on repotr from Seth Elssworth of Quest) to try to be more robust in the precense of more broken /etc/hosts files when determining our fwdn
(This used to be commit 6413df8348829659807c0c30e6eaef511815e0ed)

13 years agor16994: Fix bug #3923, reported by jason@ncac.gwu.edu. Incorrect type
Jeremy Allison [Wed, 12 Jul 2006 19:33:51 +0000 (19:33 +0000)]
r16994: Fix bug #3923, reported by jason@ncac.gwu.edu. Incorrect type
used.
Jeremy.
(This used to be commit 738b99078c6e0ececa6c0268258510a4e97f84e7)

13 years agor16992: Fix bug #3922 reported by jason@ncac.gwu.edu, correctly
Jeremy Allison [Wed, 12 Jul 2006 19:23:45 +0000 (19:23 +0000)]
r16992: Fix bug #3922 reported by jason@ncac.gwu.edu, correctly
look at the return code.
Jeremy.
(This used to be commit f11933b3ac91c6fbacd6b410f4d2c0d400df23ee)

13 years agor16990: Fix bug #3921 spotted by jason@ncac.gwu.edu. Correctly
Jeremy Allison [Wed, 12 Jul 2006 19:13:00 +0000 (19:13 +0000)]
r16990: Fix bug #3921 spotted by jason@ncac.gwu.edu. Correctly
obey blocking/non-blocking request for POSIX locks.
Jeremy.
(This used to be commit f62c01316ef3ce0351f8b34229307a75d8f9f156)

13 years agor16987: Fix the logic errors in ref-counting Windows locks.
Jeremy Allison [Wed, 12 Jul 2006 16:32:02 +0000 (16:32 +0000)]
r16987: Fix the logic errors in ref-counting Windows locks.
Hopefully will fix the build farm. Still a few errors
in RAW-LOCK to look at though...
Jeremy.
(This used to be commit edd72d37de570fdad09f7ee983b5b22a1613e558)

13 years agor16973: Fix subtle logic error in lock ref counting found by
Jeremy Allison [Wed, 12 Jul 2006 06:56:43 +0000 (06:56 +0000)]
r16973: Fix subtle logic error in lock ref counting found by
cifsfs client code.
Jeremy.
(This used to be commit 53094435d89088124041d57078c21a12e761e2bf)

13 years agor16971: Ensure we use the correct separator for pathnames
Jeremy Allison [Wed, 12 Jul 2006 03:20:53 +0000 (03:20 +0000)]
r16971: Ensure we use the correct separator for pathnames
in POSIX mode (clitar needs fixing too). Add test
posix lock/unlock commands.
Jeremy.
(This used to be commit 596497ccc250896025253be1d67711d6d7f059f0)

13 years agor16968: The function parse_processed_dfs_path() is dependent on the
Jeremy Allison [Wed, 12 Jul 2006 03:02:33 +0000 (03:02 +0000)]
r16968: The function parse_processed_dfs_path() is dependent on the
fact that check_path_syntax() will convert '\\' characters to '/'.
When POSIX pathnames have been selected this doesn't happen, so we
must look for the unaltered separator of '\\' instead of the modified '/'.
Stevef please check this with the CIFSFS MS-DFS code !
Jeremy
(This used to be commit 883bb398e58f54ee79160487b49b79a4774ef939)

13 years agor16962: Add a few utility fns into client. Allow POSIX capabilities
Jeremy Allison [Wed, 12 Jul 2006 00:21:14 +0000 (00:21 +0000)]
r16962: Add a few utility fns into client. Allow POSIX capabilities
to be selected.
Jeremy.
(This used to be commit 2d8d4bd77bac6f5e7865657e12affd8b94aa85c3)

13 years agor16960: Some warnings from host "opi"
Volker Lendecke [Tue, 11 Jul 2006 21:23:44 +0000 (21:23 +0000)]
r16960: Some warnings from host "opi"
(This used to be commit 083ef11cc9be8f1299f233bde194173e092e2c3c)

13 years agor16957: fix cut-n-paste error. The check for 'if (\!salt)' make no sense when fetchi...
Gerald Carter [Tue, 11 Jul 2006 21:09:13 +0000 (21:09 +0000)]
r16957: fix cut-n-paste error.  The check for 'if (\!salt)' make no sense when fetching the DES salting principal
(This used to be commit baf554c7934cbd591635196453c19d402358e073)

13 years agor16955: Fix an uninitialized var -- Jerry, please check.
Volker Lendecke [Tue, 11 Jul 2006 20:50:50 +0000 (20:50 +0000)]
r16955: Fix an uninitialized var -- Jerry, please check.
(This used to be commit bf701f51294dacd0d4077b5304772c40119460eb)

13 years agor16954: Volker reminded me we already have code to do this check.
Gerald Carter [Tue, 11 Jul 2006 20:31:13 +0000 (20:31 +0000)]
r16954: Volker reminded me we already have code to do this check.
Reuse can_create() to prevent renameing a group to
an existing user or group.
(This used to be commit ce7091fda1eb3c7ea0900f455cec48c3b95a17f6)

13 years agor16953: Don't allow groups to be renamed to an existing user or other group
Gerald Carter [Tue, 11 Jul 2006 20:02:22 +0000 (20:02 +0000)]
r16953: Don't allow groups to be renamed to an existing user or other group
(This used to be commit 7d619f127ee70fdd486ffaab4546a53d76a2288c)

13 years agor16952: New derive DES salt code and Krb5 keytab generation
Gerald Carter [Tue, 11 Jul 2006 18:45:22 +0000 (18:45 +0000)]
r16952: New derive DES salt code and Krb5 keytab generation

Major points of interest:

* Figure the DES salt based on the domain functional level
  and UPN (if present and applicable)
* Only deal with the DES-CBC-MD5, DES-CBC-CRC, and RC4-HMAC
  keys
* Remove all the case permutations in the keytab entry
  generation (to be partially re-added only if necessary).
* Generate keytab entries based on the existing SPN values
  in AD

The resulting keytab looks like:

ktutil:  list -e
slot KVNO Principal
---- ---- ---------------------------------------------------------------------
   1    6 host/suse10.plainjoe.org@COLOR.PLAINJOE.ORG (DES cbc mode with CRC-32)
   2    6 host/suse10.plainjoe.org@COLOR.PLAINJOE.ORG (DES cbc mode with RSA-MD5)
   3    6 host/suse10.plainjoe.org@COLOR.PLAINJOE.ORG (ArcFour with HMAC/md5)
   4    6           host/suse10@COLOR.PLAINJOE.ORG (DES cbc mode with CRC-32)
   5    6           host/suse10@COLOR.PLAINJOE.ORG (DES cbc mode with RSA-MD5)
   6    6           host/suse10@COLOR.PLAINJOE.ORG (ArcFour with HMAC/md5)
   7    6               suse10$@COLOR.PLAINJOE.ORG (DES cbc mode with CRC-32)
   8    6               suse10$@COLOR.PLAINJOE.ORG (DES cbc mode with RSA-MD5)
   9    6               suse10$@COLOR.PLAINJOE.ORG (ArcFour with HMAC/md5)

The list entries are the two basic SPN values (host/NetBIOSName & host/dNSHostName)
and the sAMAccountName value.  The UPN will be added as well if the machine has
one. This fixes 'kinit -k'.

Tested keytab using mod_auth_krb and MIT's telnet.  ads_verify_ticket()
continues to work with RC4-HMAC and DES keys.
(This used to be commit 6261dd3c67d10db6cfa2e77a8d304d3dce4050a4)

13 years agor16948: Sync the exmaples code from trunk.
Jeremy Allison [Tue, 11 Jul 2006 18:06:52 +0000 (18:06 +0000)]
r16948: Sync the exmaples code from trunk.
Jeremy.
(This used to be commit 508ba05a8e4a7df8bf7f6ffe3d09a3c461026f78)

13 years agor16947: Fix warning with profile separator when profiles not
Jeremy Allison [Tue, 11 Jul 2006 18:03:25 +0000 (18:03 +0000)]
r16947: Fix warning with profile separator when profiles not
being used.
Jeremy.
(This used to be commit 441c289fd21d00398fb7c4c7c0338b03129a7545)

13 years agor16945: Sync trunk -> 3.0 for 3.0.24 code. Still need
Jeremy Allison [Tue, 11 Jul 2006 18:01:26 +0000 (18:01 +0000)]
r16945: Sync trunk -> 3.0 for 3.0.24 code. Still need
to do the upper layer directories but this is what
everyone is waiting for....

Jeremy.
(This used to be commit 9dafb7f48ca3e7af956b0a7d1720c2546fc4cfb8)

13 years agor16943: Add Jim's code.
Jeremy Allison [Tue, 11 Jul 2006 17:09:38 +0000 (17:09 +0000)]
r16943: Add Jim's code.
Jeremy.
(This used to be commit f131bf8f16fd8b7c49e6065ecbf6f8686b2f4269)

13 years agor16941: Fix crash bug when the pam conversation receives an empty token.
Günther Deschner [Tue, 11 Jul 2006 10:39:32 +0000 (10:39 +0000)]
r16941: Fix crash bug when the pam conversation receives an empty token.
Thanks to Bjoern Jacke for the report and test-case.

Guenther
(This used to be commit f2ebc0e3de396f44f49dabbfe42cb3ad1c1a7ec1)

13 years agor16940: libnscd sets errno, use that to display error message.
Günther Deschner [Tue, 11 Jul 2006 09:59:22 +0000 (09:59 +0000)]
r16940: libnscd sets errno, use that to display error message.

Guenther
(This used to be commit df10448e2c6166d1c129c2d9a9a74c5b4a42555f)

13 years agor16939: Still clear the winbind_cache.tdb when offline logons are not enabled.
Günther Deschner [Tue, 11 Jul 2006 09:22:55 +0000 (09:22 +0000)]
r16939: Still clear the winbind_cache.tdb when offline logons are not enabled.

Guenther
(This used to be commit 4121ccfc3e39001d5b7b8288e3bc27d919f79167)

13 years agor16927: back merge of a packaging fix for release numbers (from 3.0.23)
Gerald Carter [Mon, 10 Jul 2006 20:40:42 +0000 (20:40 +0000)]
r16927: back merge of a packaging fix for release numbers (from 3.0.23)
(This used to be commit 5b4c4928ac63d6872cf13c3cdc4a9a63405bbda4)

13 years agor16866: No idea why I did not see the warning, sorry....
Volker Lendecke [Fri, 7 Jul 2006 19:01:15 +0000 (19:01 +0000)]
r16866: No idea why I did not see the warning, sorry....
(This used to be commit 84913caebdb461fed2c94fadfa0039b32a83cb6d)

13 years agor16865: This is a proposal to fix bug 3915. Before sending patches around, this is
Volker Lendecke [Fri, 7 Jul 2006 18:53:19 +0000 (18:53 +0000)]
r16865: This is a proposal to fix bug 3915. Before sending patches around, this is
what svn is for.

The idea is that we fall back to a pure unix user with S-1-22 SIDs in the
token in case anything weird is going on with the 'force user'.

Volker
(This used to be commit 9ec5ccfe851ac8a1f88b88c8c8461a5cf75b4c57)

13 years agor16864: Intermediate checkin -- swap the sid_check_is_in_unix_users and
Volker Lendecke [Fri, 7 Jul 2006 18:22:26 +0000 (18:22 +0000)]
r16864: Intermediate checkin -- swap the sid_check_is_in_unix_users and
sid_check_is_in_our_domain cases.

Volker
(This used to be commit dc403cec88d91fdeb09cbd04321d88bbdc0f490c)

13 years agor16862: Reverting accidential changes in ads_try_connect() from previous commit.
Günther Deschner [Fri, 7 Jul 2006 11:59:19 +0000 (11:59 +0000)]
r16862: Reverting accidential changes in ads_try_connect() from previous commit.

Guenther
(This used to be commit 6257f9af93f2391940b2c60fe39c0bf106de15dd)

13 years agor16861: Fixing crash bug when passing no domain/realm name to the CLDAP request.
Günther Deschner [Fri, 7 Jul 2006 11:43:47 +0000 (11:43 +0000)]
r16861: Fixing crash bug when passing no domain/realm name to the CLDAP request.

Guenther
(This used to be commit 863aeb621afa7dcec1bfef8e503ef8ed363e3742)

13 years agor16845: Properly report the error during join when the set password fails
Gerald Carter [Fri, 7 Jul 2006 00:20:55 +0000 (00:20 +0000)]
r16845: Properly report the error during join when the set password fails
(This used to be commit ef6e9ca5276586c081fcf18bb178a2326309b539)

13 years agor16836: When receiving a CLDAP reply make sure that we always store the correct
Günther Deschner [Thu, 6 Jul 2006 13:38:41 +0000 (13:38 +0000)]
r16836: When receiving a CLDAP reply make sure that we always store the correct
netbios domain name in server affinity cache.

Guenther
(This used to be commit 08958411eeff430fb523d9b73e0259d060bac17b)

13 years agor16823: Allow to call wbinfo --domain-info="" or --domain-info="." to get domain
Günther Deschner [Wed, 5 Jul 2006 15:29:31 +0000 (15:29 +0000)]
r16823: Allow to call wbinfo --domain-info="" or --domain-info="." to get domain
info for our own domain.

Guenther
(This used to be commit ebd3c547e508e191d5e1b5bb001797666db7b269)

13 years agor16800: correct a probable cut&paste error
Simo Sorce [Tue, 4 Jul 2006 15:49:26 +0000 (15:49 +0000)]
r16800: correct a probable cut&paste error
(This used to be commit c139a2293bfb66554e1be09c6824d04381de58e1)

13 years agor16799: Fix remote smbd crash bug by removing half-implemented info level 4
Günther Deschner [Tue, 4 Jul 2006 15:29:21 +0000 (15:29 +0000)]
r16799: Fix remote smbd crash bug by removing half-implemented info level 4
dfs_Enum.

Guenther
(This used to be commit 4e5ea585c3482c38f2624e45f1268d3864a99faa)

13 years agor16797: Add msdfs proxy junctions in the netdfs rpc enumeration.
Günther Deschner [Tue, 4 Jul 2006 13:49:17 +0000 (13:49 +0000)]
r16797: Add msdfs proxy junctions in the netdfs rpc enumeration.

Guenther
(This used to be commit 6bf350895a648ef9b824c94b894e8d7a8989eb97)

13 years agor16790: Fix memleak.
Günther Deschner [Mon, 3 Jul 2006 22:27:10 +0000 (22:27 +0000)]
r16790: Fix memleak.

Guenther
(This used to be commit 48ab7f46814dfbd777f142cdd8f59e6c1962eb15)

13 years agor16789: Fix bug #3909, when using ea's getting a directory tries to
Jeremy Allison [Mon, 3 Jul 2006 21:07:46 +0000 (21:07 +0000)]
r16789: Fix bug #3909, when using ea's getting a directory tries to
read ea's from an msdfs link. Stop it from doing that.
Jerry please merge to 3.0.23.
Jeremy.
(This used to be commit 95e5ace6b4f348a3244b6a3ea0fd8badf55271f5)

13 years agor16785: BUG 3908: Fix rpc bin authentication failure which broke user password changes
Gerald Carter [Mon, 3 Jul 2006 16:12:16 +0000 (16:12 +0000)]
r16785: BUG 3908: Fix rpc bin authentication failure which broke user password changes

Jeremy, please review.
(This used to be commit 154e4a281503f0cbc2e654640f1dfa4b4d35a3cd)

13 years agor16766: A warning found by RHEL3. This might actually be 3.0.23 code, maybe there are
Volker Lendecke [Sun, 2 Jul 2006 22:04:29 +0000 (22:04 +0000)]
r16766: A warning found by RHEL3. This might actually be 3.0.23 code, maybe there are
vasprintf implementations that don't like a NULL format.

Volker
(This used to be commit 03c665c307e518c9ff66096904873266b145637c)

13 years agor16755: Hunting warning has some benefits....
Volker Lendecke [Sat, 1 Jul 2006 23:59:32 +0000 (23:59 +0000)]
r16755: Hunting warning has some benefits....

Solaris found this one that needs to go into 3.0.23, actually munlock the
password memory.

Volker
(This used to be commit 6fa928f96a70b7b063dd1bdbb08c6a3f5d942229)

13 years agor16752: remove the 'socket options' setting from the shipped default smb.conf
Gerald Carter [Sat, 1 Jul 2006 20:06:15 +0000 (20:06 +0000)]
r16752: remove the 'socket options' setting from the shipped default smb.conf
(This used to be commit eac00a45efe96411ab8574b3a3d436a285b7e88a)

13 years agor16751: The precompiled header should really be in the $(buildir) and
Gerald Carter [Sat, 1 Jul 2006 18:26:31 +0000 (18:26 +0000)]
r16751: The precompiled header should really be in the $(buildir) and
not the $(srcdir) to allow multiple concurrent compiles when the
source tree is shared via nfs.
(This used to be commit b79e1c011d577581eebb90b95dbdee11f8a96c3b)

13 years agor16749: BUG 3905: don't fail in create_local_nt_token() when a
Gerald Carter [Sat, 1 Jul 2006 17:55:07 +0000 (17:55 +0000)]
r16749: BUG 3905: don't fail in create_local_nt_token() when a
checking for the builtin Administrators group membership.
security = server has no domain info in secrets.tdb
(This used to be commit fa477969fbbcd9f707461a2d9015bebf719ddfbb)

13 years agor16720: Fix bug #3874 (warning) reported by Jason Mader.
Jeremy Allison [Sat, 1 Jul 2006 01:03:01 +0000 (01:03 +0000)]
r16720: Fix bug #3874 (warning) reported by Jason Mader.
Jeremy.
(This used to be commit 0606c954668a7bbc08e2338e268405981aa0ad04)

13 years agor16719: Automatically chase referrals, support LDAP fast bind exended operation
Günther Deschner [Fri, 30 Jun 2006 23:07:17 +0000 (23:07 +0000)]
r16719: Automatically chase referrals, support LDAP fast bind exended operation
and LDAP domain scope control.

Guenther
(This used to be commit 6df2a39110a3ae9d2729907472bad30f48896c86)

13 years agor16717: patch from Bjoern Jacke to fix compiler warnings on AIX
Stefan Metzmacher [Fri, 30 Jun 2006 21:52:16 +0000 (21:52 +0000)]
r16717: patch from Bjoern Jacke to fix compiler warnings on AIX

metze
(This used to be commit a558abb40d9a0bcce568a336ce7e9f4ae5e066db)

13 years agor16713: BUG 3904: fix broken smbwrapper compile
Gerald Carter [Fri, 30 Jun 2006 15:57:35 +0000 (15:57 +0000)]
r16713: BUG 3904: fix broken smbwrapper compile
(This used to be commit 9ae1d016d44492327d180fe5e629f3a81ddfe6e4)

13 years agor16701: Fix segv when adding a printer caused by not initializing the
Gerald Carter [Thu, 29 Jun 2006 22:37:32 +0000 (22:37 +0000)]
r16701: Fix segv when adding a printer caused by not initializing the
realm name in ads_init() in nt_printer_publish().
(This used to be commit a25e75e78db092b3992dfc6f7e2737023d43e2c3)

13 years agor16696: Fix the multiple-outstanding write and trans client
Jeremy Allison [Thu, 29 Jun 2006 21:30:58 +0000 (21:30 +0000)]
r16696: Fix the multiple-outstanding write and trans client
signing bug.
Jeremy.
(This used to be commit 3b7fbe856cea7cbb5bf91844f94f221be0a2c627)

13 years agor16687: Fix bugs #3901, #3902, #3903 reported by jason@ncac.gwu.edu.
Jeremy Allison [Thu, 29 Jun 2006 18:01:25 +0000 (18:01 +0000)]
r16687: Fix bugs #3901, #3902, #3903 reported by jason@ncac.gwu.edu.
Jeremy
(This used to be commit c4896b17faa6802f18cc1cec7fcc6168bde2eef0)

13 years agor16685: Fix bug #3901 reported by jason@ncac.gwu.edu.
Jeremy Allison [Thu, 29 Jun 2006 17:11:14 +0000 (17:11 +0000)]
r16685: Fix bug #3901 reported by jason@ncac.gwu.edu.
Jeremy.
(This used to be commit d48655d9c0b31d15327655140c021de29873d2c5)

13 years agor16683: Fix bug #3900 reported by jason@ncac.gwu.edu.
Jeremy Allison [Thu, 29 Jun 2006 17:07:21 +0000 (17:07 +0000)]
r16683: Fix bug #3900 reported by jason@ncac.gwu.edu.
Jeremy.
(This used to be commit 8c7e40f2a469df34aff0e63270a78e669d240b59)

13 years agor16681: Fix bug #3899 reported by jason@ncac.gwu.edu.
Jeremy Allison [Thu, 29 Jun 2006 17:05:18 +0000 (17:05 +0000)]
r16681: Fix bug #3899 reported by jason@ncac.gwu.edu.
Jeremy.
(This used to be commit 1cd9a0ef834f8062500d1aea6183e147fc5e42f4)

13 years agor16678: Fix bug #3898 reported by jason@ncac.gwu.edu.
Jeremy Allison [Thu, 29 Jun 2006 17:03:19 +0000 (17:03 +0000)]
r16678: Fix bug #3898 reported by jason@ncac.gwu.edu.
Jeremy.
(This used to be commit 5c5ea3152f8dbdfd7717b65e035191ffed3ec548)

13 years agor16676: .o generates other warnings, use the Solaris trick with .po.o also for AIX.
Volker Lendecke [Thu, 29 Jun 2006 16:34:15 +0000 (16:34 +0000)]
r16676: .o generates other warnings, use the Solaris trick with .po.o also for AIX.

Fix a configure.in output line

Volker
(This used to be commit 1a80266d77bb95edaa221c14652b2c6fa9932ab6)

13 years agor16665: Fix a couple of bugs I discovered now I've looked
Jeremy Allison [Thu, 29 Jun 2006 00:48:44 +0000 (00:48 +0000)]
r16665: Fix a couple of bugs I discovered now I've looked
closer at the wins server code. Firstly, it needs
to do the searches on the SELF_NAMES correctly,
secondly it needs to flush the in-memory cache
out before returning the 1b names - else it might
get duplicates returned if many 1b queries are
done in quick succession. Jerry, I hate to say
this but you might want to consider this for 3.0.23....
Jeremy.
(This used to be commit b36b9befbbc4ac318168b7788d3722710ecbf10f)

13 years agor16663: Fix coverity #301, memleak in error path.
Jeremy Allison [Thu, 29 Jun 2006 00:04:47 +0000 (00:04 +0000)]
r16663: Fix coverity #301, memleak in error path.
Jeremy.
(This used to be commit dfdb4ce89155dc1528b455252751616cc2c6708c)

13 years agor16661: Fix from jason@ncac.gwu.edu for bug #3875,
Jeremy Allison [Wed, 28 Jun 2006 22:33:10 +0000 (22:33 +0000)]
r16661: Fix from jason@ncac.gwu.edu for bug #3875,
bad cast warning.
Jeremy.
(This used to be commit d60e6e0abc17361fe180d6723b970552dc377741)

13 years agor16656: Fix #3894 and #3895 reported by jason@ncac.gwu.edu.
Jeremy Allison [Wed, 28 Jun 2006 21:56:03 +0000 (21:56 +0000)]
r16656: Fix #3894 and #3895 reported by jason@ncac.gwu.edu.
Jeremy.
(This used to be commit ddf35ad69201cf9a0aa45ff25e17eddef60d75ad)

13 years agor16654: Fix bug #3893 reported by jason@ncac.gwu.edu.
Jeremy Allison [Wed, 28 Jun 2006 21:52:56 +0000 (21:52 +0000)]
r16654: Fix bug #3893 reported by jason@ncac.gwu.edu.
Jeremy.
(This used to be commit 787539489897e79d43eb1833db6f5969b130c934)

13 years agor16652: Fix bug #3891 reported by jason@ncac.gwu.edu.
Jeremy Allison [Wed, 28 Jun 2006 21:42:20 +0000 (21:42 +0000)]
r16652: Fix bug #3891 reported by jason@ncac.gwu.edu.
Jeremy.
(This used to be commit 9b0df8d008bc5574526d68628f351eb4dbf98e8a)

13 years agor16650: Fix bug #3890 reported by jason@ncac.gwu.edu.
Jeremy Allison [Wed, 28 Jun 2006 21:38:43 +0000 (21:38 +0000)]
r16650: Fix bug #3890 reported by jason@ncac.gwu.edu.
Jeremy.
(This used to be commit 590b58cb507e5a6e459ff0c975beb9056336f233)

13 years agor16648: Fix bug #3889 reported by jason@ncac.gwu.edu.
Jeremy Allison [Wed, 28 Jun 2006 21:35:46 +0000 (21:35 +0000)]
r16648: Fix bug #3889 reported by jason@ncac.gwu.edu.
Jeremy.
(This used to be commit 2eefe9b6f52e64927c0ae23adce111a42d821206)

13 years agor16646: Fix bug #3888 reported by Jason Mader <jason@ncac.gwu.edu>.
Jeremy Allison [Wed, 28 Jun 2006 21:33:52 +0000 (21:33 +0000)]
r16646: Fix bug #3888 reported by Jason Mader <jason@ncac.gwu.edu>.
Jeremy.
(This used to be commit 433d7a1bc91ff479934a256ff84e6866e16d1f85)

13 years agor16644: Fix bug #3887 reported by jason@ncac.gwu.edu
Jeremy Allison [Wed, 28 Jun 2006 21:30:21 +0000 (21:30 +0000)]
r16644: Fix bug #3887 reported by jason@ncac.gwu.edu
by converting the lookup_XX functions to correctly
return SID_NAME_TYPE enums.
Jeremy.
(This used to be commit ee2b2d96b60c668e37592c79e86c2fd851e15f69)

13 years agor16642: Fix show-stopper bug #3876. Double-free in wins
Jeremy Allison [Wed, 28 Jun 2006 20:39:07 +0000 (20:39 +0000)]
r16642: Fix show-stopper bug #3876. Double-free in wins
server code. Jerry please merge for 3.0.23.
Jeremy.
(This used to be commit d354b430ff0473764db8ea492a68d10946dadc23)

13 years agor16640: Fix bug #3886 reported by jason@ncac.gwu.edu.
Jeremy Allison [Wed, 28 Jun 2006 18:56:45 +0000 (18:56 +0000)]
r16640: Fix bug #3886 reported by jason@ncac.gwu.edu.
Jeremy.
(This used to be commit 76cc25a37e145fb48a8a81df37e790690b5dceac)

13 years agor16638: Fix bug #3885, reported by jason@ncac.gwu.edu. Use
Jeremy Allison [Wed, 28 Jun 2006 18:46:47 +0000 (18:46 +0000)]
r16638: Fix bug #3885, reported by jason@ncac.gwu.edu. Use
the correct enumerated type in the macro.
Jeremy.
(This used to be commit 63ad19f71c6b9474042f4ea9d5859e2849a73da8)

13 years agor16636: Fix bug #3884 reported by jason@ncac.gwu.edu
Jeremy Allison [Wed, 28 Jun 2006 18:22:21 +0000 (18:22 +0000)]
r16636: Fix bug #3884 reported by jason@ncac.gwu.edu
Jeremy.
(This used to be commit 7580eb947cdeb786be00efa5da727e32b28c99d6)

13 years agor16634: Fix bug #3883 reported by jason@ncac.gwu.edu.
Jeremy Allison [Wed, 28 Jun 2006 18:18:23 +0000 (18:18 +0000)]
r16634: Fix bug #3883 reported by jason@ncac.gwu.edu.
Jeremy.
(This used to be commit d04462f1d8cf009985b9112f093306a64689af64)

13 years agor16632: Fix bug #3882 reported by jason@ncac.gwu.edu.
Jeremy Allison [Wed, 28 Jun 2006 18:16:33 +0000 (18:16 +0000)]
r16632: Fix bug #3882 reported by jason@ncac.gwu.edu.
Jeremy.
(This used to be commit 6b39f53e43572fe29fc037a36328387a0b1bb423)

13 years agor16630: Fix bug #3881, reported by jason@ncac.gwu.edu.
Jeremy Allison [Wed, 28 Jun 2006 17:58:47 +0000 (17:58 +0000)]
r16630: Fix bug #3881, reported by jason@ncac.gwu.edu.
Jeremy.
(This used to be commit ec0a47b94c12b64d351ca8e6bdd467578528f3da)

13 years agor16628: Fix bug #3880, reported by jason@ncac.gwu.edu
Jeremy Allison [Wed, 28 Jun 2006 17:56:10 +0000 (17:56 +0000)]
r16628: Fix bug #3880, reported by jason@ncac.gwu.edu
by ensuring we return the correct enum for sid
type, not a uint32.
Jeremy.
(This used to be commit 98a5e20ff4ceacda65dcc0ce5498ed4ffde520f8)

13 years agor16626: Fix bug #3878. Reported by jason@ncac.gwu.edu.
Jeremy Allison [Wed, 28 Jun 2006 17:26:48 +0000 (17:26 +0000)]
r16626: Fix bug #3878. Reported by jason@ncac.gwu.edu.
Jeremy.
(This used to be commit 4c3019eb99d0a18a33ef1fa90d01b9c99c0b25c3)

13 years agor16624: Fix bug #3877, reported by jason@ncac.gwu.edu
Jeremy Allison [Wed, 28 Jun 2006 17:11:06 +0000 (17:11 +0000)]
r16624: Fix bug #3877, reported by jason@ncac.gwu.edu
Jeremy.
(This used to be commit 1f52b8b40619679242da663f5e5e7836d547f0a2)

13 years agor16616: Klocwork #2025. Stop null deref. I actually don't
Jeremy Allison [Wed, 28 Jun 2006 05:00:09 +0000 (05:00 +0000)]
r16616: Klocwork #2025. Stop null deref. I actually don't
think this can happen in real life but the code is
too complicated to be sure....
Jerry please merge this for 3.0.23.
Jeremy.
(This used to be commit 1e5042d4c0d1a0d0a5cfbcb0d47815e1510ee52a)

13 years agor16614: Klocwork #2012. memleak on error path.
Jeremy Allison [Wed, 28 Jun 2006 04:56:23 +0000 (04:56 +0000)]
r16614: Klocwork #2012. memleak on error path.
Jeremy.
(This used to be commit 58b9adb849854610e7167e8aa02a02bd15b0bf00)

13 years agor16612: Klocwork fix #2011. memleak on error path.
Jeremy Allison [Wed, 28 Jun 2006 04:51:23 +0000 (04:51 +0000)]
r16612: Klocwork fix #2011. memleak on error path.
Jeremy.
(This used to be commit b4e9475d2ac65f72cab0d5c8276da27cf1aeb791)

13 years agor16610: Subtle one from Klocwork #2076. If multiple flags
Jeremy Allison [Wed, 28 Jun 2006 04:43:19 +0000 (04:43 +0000)]
r16610: Subtle one from Klocwork #2076. If multiple flags
are set in a winbindd request it might overwrite existing
state->response.extra_data.data values without freeing.
Jeremy.
(This used to be commit 4e7262c81ad2945048cb8d0789af032a05008988)

13 years agor16608: Klocwork #2035. Null deref (bit of a stretch... :-).
Jeremy Allison [Wed, 28 Jun 2006 04:30:51 +0000 (04:30 +0000)]
r16608: Klocwork #2035. Null deref (bit of a stretch... :-).
Jeremy.
(This used to be commit 7d7a98208b1b514da60486fcbbb7b6d04df4ffac)

13 years agor16606: Klocwork #1990. Malloc the correct size.
Jeremy Allison [Wed, 28 Jun 2006 04:27:43 +0000 (04:27 +0000)]
r16606: Klocwork #1990. Malloc the correct size.
Jeremy.
(This used to be commit d1a1c4e092877a6ea0f98eed2a37a96d42c36323)

13 years agor16603: Klockwork #2028. Fix null deref on error path.
Jeremy Allison [Wed, 28 Jun 2006 02:22:28 +0000 (02:22 +0000)]
r16603: Klockwork #2028. Fix null deref on error path.
Jeremy.
(This used to be commit 067feef34388e93ded8db7fd3b4a6a4b752a3059)

13 years agor16601: Klocwork #2038. Fix memleak on error path.
Jeremy Allison [Wed, 28 Jun 2006 02:12:53 +0000 (02:12 +0000)]
r16601: Klocwork #2038. Fix memleak on error path.
Jeremy.
(This used to be commit 934dddb2fa9fb60a87c0b0be81db97f2b59c7cb0)

13 years agor16599: Make it clear to Klocwork we're not dereferencing. Issue #2026.
Jeremy Allison [Wed, 28 Jun 2006 02:02:26 +0000 (02:02 +0000)]
r16599: Make it clear to Klocwork we're not dereferencing. Issue #2026.
Jeremy.
(This used to be commit 9402bf0d4cc6d04283ed69a6dedac7767df84626)

13 years agor16597: Klocwork #2006. Fix possible null deref.
Jeremy Allison [Wed, 28 Jun 2006 01:59:04 +0000 (01:59 +0000)]
r16597: Klocwork #2006. Fix possible null deref.
Jeremy.
(This used to be commit 9b73385d6b90c7806d8ccfc1f2354ede761fad61)

13 years agor16595: Klocwork #2067. Fix possible memleak on error exit.
Jeremy Allison [Wed, 28 Jun 2006 01:56:41 +0000 (01:56 +0000)]
r16595: Klocwork #2067. Fix possible memleak on error exit.
Jeremy.
(This used to be commit 1d21a3dec9ea061ce900ad1223f7c2a43c064600)

13 years agor16593: Make the invarient explicit to Klocwork. Bug #2023.
Jeremy Allison [Wed, 28 Jun 2006 01:52:01 +0000 (01:52 +0000)]
r16593: Make the invarient explicit to Klocwork. Bug #2023.
Jeremy.
(This used to be commit 720a9172050beb158a25fbb826676ba19cdcef20)

13 years agor16591: Belt and braces approach to shut Klocwork up - bug #2001.
Jeremy Allison [Wed, 28 Jun 2006 01:25:29 +0000 (01:25 +0000)]
r16591: Belt and braces approach to shut Klocwork up - bug #2001.
Jeremy.
(This used to be commit d5c1028498de0346b7a35cc132b8081e04e639cc)

13 years agor16589: Fix Klocwork #1999. Although it should be impossible to
Jeremy Allison [Wed, 28 Jun 2006 01:21:54 +0000 (01:21 +0000)]
r16589: Fix Klocwork #1999. Although it should be impossible to
get duplicate OID's returned in the oids_out list it is
still good programming practice to clear out a malloc'ed
string before re-writing it (especially in a loop).
Jeremy
(This used to be commit ae02c05bfca46eb6a8ba25b124c18a358a759cb5)

13 years agor16587: Fix Klocwork #1987. Memleak on reusing x_dbf.
Jeremy Allison [Wed, 28 Jun 2006 01:11:17 +0000 (01:11 +0000)]
r16587: Fix Klocwork #1987. Memleak on reusing x_dbf.
Jeremy.
(This used to be commit 16b0617cb0f91fbe1ce53dcb601fe5ed9e51bddf)

13 years agor16585: Fix Klocwork #1976. Possible null deref.
Jeremy Allison [Wed, 28 Jun 2006 01:00:48 +0000 (01:00 +0000)]
r16585: Fix Klocwork #1976. Possible null deref.
Jeremy.
(This used to be commit a912ef0d9724373966e77f9e8928be462de8df4a)

13 years agor16582: Fix Klocwork #1997 and all generic class of problems
Jeremy Allison [Wed, 28 Jun 2006 00:50:14 +0000 (00:50 +0000)]
r16582: Fix Klocwork #1997 and all generic class of problems
where we don't correctly check the return from memdup.
Jeremy.
(This used to be commit ce14daf51c7ee2f9c68c77f7f4674e6f0e35c9ca)

13 years agor16581: Fix Klocwork #2017. Possible null deref.
Jeremy Allison [Wed, 28 Jun 2006 00:07:53 +0000 (00:07 +0000)]
r16581: Fix Klocwork #2017. Possible null deref.
Jeremy.
(This used to be commit 6967fd4cefa84a7b7b5e14467bfa8152907d55c9)

13 years agor16579: Fix Klocwork #2016. Possible null deref.
Jeremy Allison [Wed, 28 Jun 2006 00:05:53 +0000 (00:05 +0000)]
r16579: Fix Klocwork #2016. Possible null deref.
Jeremy.
(This used to be commit f6d5bae4a105eee1b1d5b1aaa70a675705345d9e)

13 years agor16576: Fix Klocwork #2015. Possible null deref.
Jeremy Allison [Wed, 28 Jun 2006 00:01:28 +0000 (00:01 +0000)]
r16576: Fix Klocwork #2015. Possible null deref.
Jeremy.
(This used to be commit 9cbfaf62a3c4bb7d2e594e412449506ab0af4063)

13 years agor16570: Corrected the copyright notice. I had requested and received permission
Christopher R. Hertel [Tue, 27 Jun 2006 17:58:55 +0000 (17:58 +0000)]
r16570: Corrected the copyright notice.  I had requested and received permission
from my management at the University to release under my own copyright.
My mistake for entering the wrong info.
(This used to be commit c65ebeb02810fb4039555c55779ec62a4a8de564)

13 years agor16554: Sorry, just had to change this. Don't use int when
Jeremy Allison [Tue, 27 Jun 2006 03:59:34 +0000 (03:59 +0000)]
r16554: Sorry, just had to change this. Don't use int when
you're passing a BOOL parameter, don't use "clever"
code in while statement - make things easier and
clearer to understand when triggering something
with an if.
Jeremy.
(This used to be commit b1fc2d8b99e0402c0e8fe954d9f9563dc4dc2812)

13 years agor16552: Fix bug 3849.
Derrell Lipman [Tue, 27 Jun 2006 03:07:02 +0000 (03:07 +0000)]
r16552: Fix bug 3849.

Added a next_token_no_ltrim() function which does not strip leading separator
characters.  The new function is used only where really necessary, even though
it could reasonably be used in many more places, to avoid superfluous code
changes.

Derrell
(This used to be commit d90061aa933f7d8c81973918657dd72cbc88bab5)

13 years agor16550: Fix bug 3866. Thanks for the report!
Derrell Lipman [Tue, 27 Jun 2006 02:30:58 +0000 (02:30 +0000)]
r16550: Fix bug 3866.  Thanks for the report!

Although I've never met a computer or compiler that produced pointers to
functions which are a different size than pointers to data, I suppose they
probably exist.  Assigning a pointer to a function is technically illegal in C
anyway.

Change casts of the option_value based on the option_name to use of variable
argument lists.

For binary compatibility, I've maintained but deprecated the old behavior of
debug_stderr (which expected to be passed a NULL or non-NULL pointer) and
added a new option debug_to_stderr which properly expects a boolean (int)
parameter.

Derrell
(This used to be commit c1b4c510530ca3118d1eccb9615a8cad732c7373)

13 years agor16548: Fix bug #3867 reported by jason@ncac.gwu.edu.
Jeremy Allison [Tue, 27 Jun 2006 01:03:58 +0000 (01:03 +0000)]
r16548: Fix bug #3867 reported by jason@ncac.gwu.edu.
Jeremy.
(This used to be commit 2b8d72f09c6d79d5d41421545b538da573adcd9d)