Stefan Metzmacher [Fri, 20 Mar 2009 13:25:15 +0000 (14:25 +0100)]
selftest/Samba3: use the same sequence of signals to shutdown samba3 as with the shell scripts
When we kill the timelimit process with SIGKILL, it can't kill its
children...
metze
Günther Deschner [Fri, 20 Mar 2009 10:21:36 +0000 (11:21 +0100)]
s3-netapi: Fix Coverity #774 (REVERSE_INULL).
Guenther
Günther Deschner [Fri, 20 Mar 2009 10:19:59 +0000 (11:19 +0100)]
s3-netapi: Fix Coverity #775 (REVERSE_INULL).
Guenther
Günther Deschner [Fri, 20 Mar 2009 10:17:50 +0000 (11:17 +0100)]
s3-netapi: Fix Coverity #776 (REVERSE_INULL).
Guenther
Günther Deschner [Fri, 20 Mar 2009 10:11:04 +0000 (11:11 +0100)]
s3-krb5: Fix Coverity #762 (REVERSE_INULL).
Guenther
Günther Deschner [Fri, 20 Mar 2009 10:07:21 +0000 (11:07 +0100)]
s3-net: Fix Coverity #861 (UNINIT).
Guenther
Günther Deschner [Fri, 20 Mar 2009 10:04:59 +0000 (11:04 +0100)]
s3-net: Fix Coverity #898 (UNINIT).
Guenther
Günther Deschner [Thu, 19 Mar 2009 11:53:01 +0000 (12:53 +0100)]
s3-spoolss: pure comsetics.
sorry, I just need to do that.
Guenther
Günther Deschner [Thu, 19 Mar 2009 15:42:54 +0000 (16:42 +0100)]
s3-krb5: Fix Coverity #722 (RESOURCE_LEAK).
Guenther
Günther Deschner [Thu, 19 Mar 2009 15:18:29 +0000 (16:18 +0100)]
s3-net: Fix Coverity #886 (FORWARD_NULL).
Guenther
Günther Deschner [Thu, 27 Nov 2008 16:49:25 +0000 (17:49 +0100)]
s3-samr: try to to fix password_expired flag handling.
Guenther
Stefan Metzmacher [Fri, 20 Mar 2009 09:14:35 +0000 (10:14 +0100)]
s4:build: include ../libcli/cldap/config.mk
This fixes commit
84a140f18722518eb0f40737085dd3b3958a3a02,
sorry!
metze
Bo Yang [Wed, 4 Mar 2009 10:10:20 +0000 (18:10 +0800)]
Fix crash in async_smb.c
Andrew Bartlett [Fri, 20 Mar 2009 05:47:34 +0000 (16:47 +1100)]
s4:fullschema Use server-side sort to make the output deterministic
Andrew Bartlett [Fri, 20 Mar 2009 05:45:52 +0000 (16:45 +1100)]
s4:ldb Allow paged_searches to be mixed with other controls
I want to mix this with the server-side sort in particular.
Andrew Bartlett
Andrew Bartlett [Fri, 20 Mar 2009 05:18:40 +0000 (16:18 +1100)]
s4: Remove autogenerated attributes from minschema and fullschema output
These attributes will be generated by Samba on import, and do not need
to be in the schema file.
Andrew Bartlett
Andrew Bartlett [Fri, 20 Mar 2009 05:07:49 +0000 (16:07 +1100)]
Add minschema like tool to extract and dump the full schema from AD
Andrew Bartlett [Fri, 20 Mar 2009 02:55:43 +0000 (13:55 +1100)]
s4:minschma Fix aggregate schema generation in minschema
The conversion from EJS to python I did with Jelmer this morning was
not quite complete, due mostly to the difference between print in EJS
and python (python implies a newline).
Andrew Bartlett
Andrew Bartlett [Fri, 20 Mar 2009 05:25:01 +0000 (16:25 +1100)]
s4:ldb Ensure to pass down options to LDB from python
This is needed for things such as to load modules, like the
paged_searches module.
Andrew Bartlett
Andrew Bartlett [Fri, 20 Mar 2009 05:26:42 +0000 (16:26 +1100)]
s4:ldb Fix the paged_searches module
This simplifies the code, removes presumptions about being the only
control in the reply, and allows it to function against Windows 2008.
For searches which did not require a paged result, the module was
simply returning a failure when the compleated search did not include
a paged result control.
Andrew Bartlett
Jelmer Vernooij [Fri, 20 Mar 2009 00:30:36 +0000 (01:30 +0100)]
Merge branch 'master' of git://git.samba.org/samba into minschema
Jelmer Vernooij [Fri, 20 Mar 2009 00:29:31 +0000 (01:29 +0100)]
Fix up minschema after the conversion from JavaScript.
Pair programmed over the phone with Andrew :-)
Jelmer Vernooij [Thu, 19 Mar 2009 23:33:43 +0000 (00:33 +0100)]
pyldb: Improve exception message when a list is expected.
Michael Adam [Thu, 19 Mar 2009 22:56:12 +0000 (23:56 +0100)]
add a versiontest program to print samba_version_string().
This is to allow for testing samba_version_string() without
the need to compile any of the larger binaries like smbd or net...
Michael
Michael Adam [Thu, 19 Mar 2009 22:55:21 +0000 (23:55 +0100)]
version: fix handling of SAMBA_VERSION_VENDOR_PATCH.
We need a string version of this, or else version.c does not compile.
Michael
Dan Sledz [Thu, 19 Mar 2009 21:53:34 +0000 (21:53 +0000)]
s3: Fix a free of an uninitialized variable in winbind_get_sid_aliases
Stefan Metzmacher [Tue, 24 Feb 2009 18:05:33 +0000 (19:05 +0100)]
s3:libads: use libcli/cldap code
metze
Stefan Metzmacher [Tue, 24 Feb 2009 17:27:45 +0000 (18:27 +0100)]
s3:build: compile lib/tsocket and libcli/cldap
metze
Stefan Metzmacher [Wed, 18 Mar 2009 16:43:11 +0000 (17:43 +0100)]
move source4/libcli/cldap => libcli/cldap
metze
Stefan Metzmacher [Fri, 13 Feb 2009 12:13:54 +0000 (13:13 +0100)]
s4:cldap: rewrite the cldap library based on tsocket
metze
Stefan Metzmacher [Thu, 26 Feb 2009 13:33:52 +0000 (14:33 +0100)]
lib/util: build tevent_unix.o and tevent_ntstatus.o as UTIL_TEVENT subsystem
metze
Stefan Metzmacher [Wed, 18 Mar 2009 14:59:36 +0000 (15:59 +0100)]
lib/tsocket: add tsocket_guide.txt section with specific details about bsd style sockets
metze
Stefan Metzmacher [Wed, 11 Mar 2009 16:27:03 +0000 (17:27 +0100)]
lib/tsocket: add a fast path to tsocket_writev_send/recv()
This is similar to the tsocket_sendto_send/recv() fast path.
metze
Stefan Metzmacher [Wed, 11 Mar 2009 16:11:22 +0000 (17:11 +0100)]
lib/tsocket: add a fast path to tsocket_sendto_send/recv()
By first trying to send data without waiting for the socket
to become writeable we gain about 10-20% performance in the
LDAP-BENCH-CLDAP test.
metze
Stefan Metzmacher [Wed, 18 Mar 2009 10:14:38 +0000 (11:14 +0100)]
lib/tsocket: add tsocket_guide.txt section about the async _send/recv() helper functions
metze
Stefan Metzmacher [Wed, 11 Mar 2009 14:51:07 +0000 (15:51 +0100)]
lib/tsocket: add tsocket_readv_send/recv()
metze
Stefan Metzmacher [Wed, 11 Mar 2009 13:26:15 +0000 (14:26 +0100)]
lib/tsocket: add tsocket_writev_queue_send/recv()
metze
Stefan Metzmacher [Wed, 11 Mar 2009 13:10:47 +0000 (14:10 +0100)]
lib/tsocket: add tsocket_writev_send/recv()
metze
Stefan Metzmacher [Wed, 18 Feb 2009 08:19:09 +0000 (09:19 +0100)]
lib/tsocket: add tsocket_connect_send/recv()
metze
Stefan Metzmacher [Wed, 18 Feb 2009 09:00:50 +0000 (10:00 +0100)]
lib/tsocket: add tsocket_sendto_queue_send/recv()
metze
Stefan Metzmacher [Tue, 10 Mar 2009 20:12:31 +0000 (21:12 +0100)]
lib/tsocket: add tsocket_sendto_send/recv()
metze
Stefan Metzmacher [Wed, 18 Feb 2009 08:23:32 +0000 (09:23 +0100)]
lib/tsocket: add tsocket_recvfrom_send/recv()
metze
Stefan Metzmacher [Thu, 26 Feb 2009 14:37:44 +0000 (15:37 +0100)]
lib/tsocket: add an implementation for bsd style sockets.
metze
Stefan Metzmacher [Wed, 11 Mar 2009 09:25:07 +0000 (10:25 +0100)]
lib/tsocket: add a tsocket_guide.txt with a description of the design
metze
Stefan Metzmacher [Wed, 18 Feb 2009 08:14:26 +0000 (09:14 +0100)]
lib/tsocket: add some useful helper functions
metze
Stefan Metzmacher [Wed, 18 Feb 2009 08:10:54 +0000 (09:10 +0100)]
lib/tsocket: add generic socket abstraction layer
This will replace source4/lib/socket/.
metze
Björn Jacke [Mon, 16 Mar 2009 00:51:09 +0000 (01:51 +0100)]
fix build on old Heimdal based systems
Signed-off-by: Günther Deschner <gd@samba.org>
Stefan Metzmacher [Thu, 19 Mar 2009 13:31:43 +0000 (14:31 +0100)]
tevent: fix the nesting logic
Only tevent_loop_once and tevent_loop_until() should care
about the nesting level.
This fixes the samba3 printing code where we use tevent_loop_wait()
and don't allow nested events.
We still call the nesting hook for all levels, we need to decide
if we really want this...
metze
Stefan Metzmacher [Wed, 18 Mar 2009 07:46:38 +0000 (08:46 +0100)]
s3:libsmb: always create bytes array in cli_trans code
Otherwise we return NO_MEMORY without a reason for fragmented trans
requests, as talloc_append_blob() returns buf if we append a 0 length
blob. When we pass buf = NULL we'll get back NULL and then assume
NO_MEMORY...
metze
Stefan Metzmacher [Wed, 18 Mar 2009 06:56:51 +0000 (07:56 +0100)]
s3:libsmb: fix smb signing for fragmented trans/trans2/nttrans requests
Before we send the secondary requests we need to remove the
old mid=>seqnum mapping and reset cli->mid and make the new
mid=>seqnum mapping "persistent".
The bug we had in cli_send_trans was this:
The first cli_send_smb() incremented cli->mid
and the secondary requests used the incremented mid,
but as cli->outbuf still had the correct mid,
we send the correct mid to the server. The real problem
was that the cli_send_smb() function stored the seqnum
under the wrong mid.
cli_send_nttrans() was totally broken and now follows the
same logic as cli_send_trans().
The good thing is that in practice the problem is unlikely to happen,
because max_xmit is large enough to avoid secondary requests.
metze
Stefan Metzmacher [Thu, 19 Mar 2009 08:06:38 +0000 (09:06 +0100)]
s3:lib/util_sock: use sys_recv() instead of sys_read() on sockets
This ways the pcap support in socket wrapper sees the received data.
metze
Björn Jacke [Wed, 18 Mar 2009 18:05:52 +0000 (19:05 +0100)]
fix some typos
Signed-off-by: Michael Adam <obnox@samba.org>
Jeremy Allison [Thu, 19 Mar 2009 04:49:32 +0000 (21:49 -0700)]
Modify simple POSIX open test to use filenames containing a ':'
character. Should stop regressions of bug #6196.
Jeremy.
Jeremy Allison [Thu, 19 Mar 2009 03:56:48 +0000 (20:56 -0700)]
Allow DFS client paths to work when POSIX pathnames have been
selected (we need to path in pathname /that/look/like/this).
Jeremy.
Jeremy Allison [Thu, 19 Mar 2009 03:02:26 +0000 (20:02 -0700)]
Merge branch 'master' of ssh://jra@git.samba.org/data/git/samba
Jeremy Allison [Thu, 19 Mar 2009 03:00:28 +0000 (20:00 -0700)]
Fix bug #6196 - Unable to serve files with colons to Linux CIFS/VFS client
Looks like the pathname parsing for POSIX paths got
broken when the code for doing Windows streams parsing got added.
Jeremy.
Andrew Tridgell [Thu, 19 Mar 2009 00:23:49 +0000 (11:23 +1100)]
use the tevent nesting code to avoid the uid problem in the VFS
backend
The vfs_unixuid module changes the uid of the process when executing
operations on behalf of the user. Within the VFS backend we may rely
on semi-async calls, such as winbind calls, which will call the event
loop again. To cope with this we need to ensure that while inside
those calls we revert the uid to root, then revert back to the
connected user when we have finished with the semi-async calls.
Andrew Tridgell [Thu, 19 Mar 2009 00:21:36 +0000 (11:21 +1100)]
fixed a logic bug in the tevent nesting code
The event nesting code never triggered as nesting.level was never
greater than 1. The main event loop needs to increase the nesting
level by 1.
I also added a paranoia check to the nesting setup call. The API as
currently written cannot support multiple nesting hooks, so we need to
abort if multiple hooks are tried.
Tim Prouty [Wed, 18 Mar 2009 21:49:50 +0000 (21:49 +0000)]
s3 onefs: Correctly error out when the read returns EOF
Also add some more debugging.
Jeremy Allison [Wed, 18 Mar 2009 22:44:13 +0000 (15:44 -0700)]
Fix bug #6195 - Migrating from 3.0.x to 3.3.x can fail to update passdb.tdb correctly.
This is a really nasty one to fix as in order to successfully update the
passdb.tdb we must do the equivalent of a tdbbackup to move to the new hash
values before we do the upgrade.
Jeremy.
Günther Deschner [Wed, 18 Mar 2009 21:49:41 +0000 (22:49 +0100)]
s3: remove POLICY_HND.
Guenther
Günther Deschner [Wed, 18 Mar 2009 14:09:57 +0000 (15:09 +0100)]
s3-rpc_parse: remove some unused parsing code.
Guenther
Günther Deschner [Wed, 18 Mar 2009 20:54:26 +0000 (21:54 +0100)]
s3-spoolss: fix _spoolss_GetPrinterData printerserver handle query error code.
When _spoolss_GetPrinterData receives a query on a printserver handle for a
value that we have not stored or do not provide, we need to return
WERR_INVALID_PARAM, not WERR_BADFILE. Tested with w2k and w2k3 servers.
Found by torture test.
Guenther
Günther Deschner [Wed, 18 Mar 2009 20:36:40 +0000 (21:36 +0100)]
s3-spoolss: fix _spoolss_EnumPrinterDataEx error path.
When a windows clients queries the "" key, we need to make sure to return with
the appropriate error (WERR_INVALID_PARAM in that case), and not fall through
to the buffer size handling macros. Found by torture test.
Guenther
Günther Deschner [Wed, 18 Mar 2009 11:22:22 +0000 (12:22 +0100)]
s3-rpc_parse: remove unused BUFFER5 and UNISTR3.
Guenther
Günther Deschner [Wed, 18 Mar 2009 17:10:01 +0000 (18:10 +0100)]
s3-rpc_client: remove unused CLI_DO_RPC_WERR macro.
Guenther
Zach Loafman [Wed, 18 Mar 2009 17:36:59 +0000 (10:36 -0700)]
s4 libcli: Add back Longhorn beta dialect as a constant
Also tweak how the dialect array and count is initialized.
Günther Deschner [Wed, 18 Mar 2009 16:45:30 +0000 (17:45 +0100)]
s3-smbcontrol: use correct PRINTER_NOTIFY flags.
Guenther
Günther Deschner [Wed, 25 Feb 2009 13:33:59 +0000 (14:33 +0100)]
spoolss: add my copyright.
Guenther
Günther Deschner [Wed, 18 Mar 2009 15:38:36 +0000 (16:38 +0100)]
s3-spoolss: remove include/rpc_spoolss.h.
Guenther
Günther Deschner [Tue, 17 Mar 2009 23:45:35 +0000 (00:45 +0100)]
s3-spoolss: remove rpc_server/srv_spoolss.c alltogether.
Guenther
Günther Deschner [Tue, 17 Mar 2009 23:43:31 +0000 (00:43 +0100)]
s3-spoolss: remove rpc_parse/parse_spoolss.c alltogether.
Good-Bye, last hand-marshalled rpc functions, rest in peace.
Guenther
Günther Deschner [Tue, 17 Mar 2009 23:41:47 +0000 (00:41 +0100)]
s3-spoolss: remove old spoolss_EnumPrinterDataEx.
Guenther
Günther Deschner [Tue, 17 Mar 2009 23:38:40 +0000 (00:38 +0100)]
s3-spoolss: use pidl for _spoolss_EnumPrinterDataEx.
Please note that this has been the last call in samba3 that was
using hand-marshalled rpc. With this commit all named pipe rpc services
in samba3 have now fully moved to pidl generated code :-)
Guenther
Günther Deschner [Wed, 18 Mar 2009 15:37:33 +0000 (16:37 +0100)]
s3-spoolss: use printer and job notify enums provided by idl.
Guenther
Günther Deschner [Wed, 18 Mar 2009 15:16:25 +0000 (16:16 +0100)]
s3-spoolss: fix spoolss server after spoolss_Field changes.
Guenther
Günther Deschner [Wed, 18 Mar 2009 15:10:52 +0000 (16:10 +0100)]
s3-rpcclient: fix spoolss notify test after spoolss_Field changes.
Guenther
Günther Deschner [Wed, 18 Mar 2009 15:10:11 +0000 (16:10 +0100)]
s4-smbtorture: fix spoolss notify test after spoolss_Field changes.
Guenther
Günther Deschner [Wed, 18 Mar 2009 15:06:40 +0000 (16:06 +0100)]
spoolss: add custom ndr_print_spoolss_Field.
Guenther
Günther Deschner [Wed, 18 Mar 2009 14:48:48 +0000 (15:48 +0100)]
s3: re-run make samba3-idl.
Guenther
Günther Deschner [Wed, 18 Mar 2009 14:48:06 +0000 (15:48 +0100)]
spoolss: make spoolss_Field a nodiscriminant union of 2 sets of notify flag enums.
Guenther
Günther Deschner [Wed, 18 Mar 2009 14:05:44 +0000 (15:05 +0100)]
s3-rpc_parse: move prs_uint64 to rpc_parse/parse_prs.c.
Guenther
Günther Deschner [Wed, 18 Mar 2009 12:22:51 +0000 (13:22 +0100)]
s3-spoolss: remove custom syntax_spoolss and use the syntax defined in IDL.
Guenther
Günther Deschner [Wed, 18 Mar 2009 11:46:40 +0000 (12:46 +0100)]
s3-printing: use marshall/unmarshall_sec_desc_buf in sec_desc_upg_fn().
Guenther
Günther Deschner [Wed, 18 Mar 2009 10:25:15 +0000 (11:25 +0100)]
s3-spoolss: add registry_value_to_printer_enum_value.
Guenther
Günther Deschner [Wed, 18 Mar 2009 10:22:11 +0000 (11:22 +0100)]
s3-spoolss: add SPOOLSS_BUFFER_ARRAY macro.
Guenther
Günther Deschner [Wed, 18 Mar 2009 10:11:05 +0000 (11:11 +0100)]
spoolss: add ndr_size_spoolss_EnumPrinterDataEx_info in spoolss helper.
Guenther
Günther Deschner [Wed, 18 Mar 2009 10:10:25 +0000 (11:10 +0100)]
spoolss: rename NDR_SPOOLSS_SIZE_ENUM macro to NDR_SPOOLSS_SIZE_ENUM_LEVEL in
spoolss helper.
Guenther
Günther Deschner [Wed, 18 Mar 2009 02:00:37 +0000 (03:00 +0100)]
s4-smbtorture: fix spoolss_EnumPrinterKey callers in RPC-SPOOLSS-WIN test.
Kai, please check.
Guenther
Günther Deschner [Wed, 18 Mar 2009 02:11:37 +0000 (03:11 +0100)]
spoolss: fix ndr_push_spoolss_EnumPrinterDataEx.
Guenther
Stefan Metzmacher [Mon, 16 Mar 2009 16:27:30 +0000 (17:27 +0100)]
s3:winbindd: accept new connections via fd events
metze
Stefan Metzmacher [Mon, 16 Mar 2009 15:14:20 +0000 (16:14 +0100)]
s3:winbindd: move non event related code out of process_loop() in the the caller
metze
Stefan Metzmacher [Mon, 16 Mar 2009 15:06:12 +0000 (16:06 +0100)]
s3:winbindd: remove unused close_winbindd_socket() function
metze
Stefan Metzmacher [Mon, 16 Mar 2009 14:55:39 +0000 (15:55 +0100)]
s3:smbd: use tevent_loop_once() in the parent event loop
metze
Stefan Metzmacher [Mon, 16 Mar 2009 14:47:57 +0000 (15:47 +0100)]
s3:printing: use tevent_loop_wait() instead of manual looping
metze
Stefan Metzmacher [Mon, 16 Mar 2009 13:56:11 +0000 (14:56 +0100)]
s3:printing: use a fd event to monitor the pipe to the parent
metze
Stefan Metzmacher [Mon, 16 Mar 2009 13:48:40 +0000 (14:48 +0100)]
s3:smbd: don't exit the parent when we have no connections
This code path can't really happen anymore, because
launchd support was removed with commit
e5a951325a6cac8567af3a66de6d2df577508ae4.
But it's confusing to have that code there...
metze
Günther Deschner [Wed, 18 Mar 2009 01:33:18 +0000 (02:33 +0100)]
s3-spoolss: use rpccli_spoolss_enumprinterdataex in ldap_printer.c.
Guenther
Günther Deschner [Wed, 18 Mar 2009 00:39:49 +0000 (01:39 +0100)]
s4-smbtorture: fix spoolss_EnumPrinterDataEx tests.
sorry, I could swear this did compile...
Guenther
Günther Deschner [Tue, 17 Mar 2009 23:38:01 +0000 (00:38 +0100)]
s3-spoolss: remove old rpccli_spoolss_enumprinterdataex.
Guenther