15 years agor23645: add examples and try to answer some common questions in the coding style...
Gerald Carter [Thu, 28 Jun 2007 19:27:30 +0000 (19:27 +0000)]
r23645: add examples and try to answer some common questions in the coding style guide
(This used to be commit c955151bb384c3edba3f2f17f1ebb7029b61d36c)

15 years agor23641: Put check for forbidden values in smbconf into a function.
Michael Adam [Thu, 28 Jun 2007 10:32:52 +0000 (10:32 +0000)]
r23641: Put check for forbidden values in smbconf into a function.
(This will be used in a next step to prevent storing these
values in reg_smbconf.c.)

(This used to be commit 00be68a8416405e12a27186506f9eb15bca055b3)

15 years agor23640: When we support the SeSecurity privilage, this is where
Jeremy Allison [Wed, 27 Jun 2007 22:45:08 +0000 (22:45 +0000)]
r23640: When we support the SeSecurity privilage, this is where
we'll check it.
(This used to be commit 1b73bf79f4f8a2bc408d52a1ce9df47f33fb3a87)

15 years agor23639: Eliminate trailing whitespaces in the new tdb_validate functions...
Michael Adam [Wed, 27 Jun 2007 22:10:25 +0000 (22:10 +0000)]
r23639: Eliminate trailing whitespaces in the new tdb_validate functions...

(This used to be commit d4accdbb5285216d532f57f545a846734a2fe774)

15 years agor23636: Adding coding style guide for Samba 3.0 branches (no differences from Tridge...
Gerald Carter [Wed, 27 Jun 2007 18:28:18 +0000 (18:28 +0000)]
r23636: Adding coding style guide for Samba 3.0 branches (no differences from Tridge's prog_guide.txt so we should have a similar style throughout the project)
(This used to be commit ff1c2fdc08f6198bad1bf9f5bae8dc6bc5fb534a)

15 years agor23633: Fix a couple of crash bugs pointed out by Volker caused by an old
Gerald Carter [Wed, 27 Jun 2007 16:52:36 +0000 (16:52 +0000)]
r23633: Fix a couple of crash bugs pointed out by Volker caused by an old
change from a pstring to a char* and still trying use pstrcpy().
(This used to be commit 21dc46a2bad6fee720f0f591e1051aa7675c77c8)

15 years agor23632: Correctly return the new_group list pointer from expand_groups
Gerald Carter [Wed, 27 Jun 2007 16:52:34 +0000 (16:52 +0000)]
r23632: Correctly return the new_group list pointer from expand_groups
or else getgrnam() always  acts like 'winbind expand groups = 1'
(This used to be commit 04ae193ec44c0ecefa64ca44ad0cdb5968087319)

15 years agor23630: Found out what LSA_LOOKUP_NAMES level 5 means:
Günther Deschner [Wed, 27 Jun 2007 12:35:12 +0000 (12:35 +0000)]
r23630: Found out what LSA_LOOKUP_NAMES level 5 means:
only query transitive forest trusts.

(This used to be commit e744efa1ee33fb150132f0b7f46ee1711681afc6)

15 years agor23628: Add LSA lookupnames_level to rpcclient.
Günther Deschner [Wed, 27 Jun 2007 12:27:00 +0000 (12:27 +0000)]
r23628: Add LSA lookupnames_level to rpcclient.

(This used to be commit dee99e40454b00da70343047c57e0cb0f2c489bd)

15 years agor23627: Allow to pass down the lookup-level to rpccli_lsa_lookup_names().
Günther Deschner [Wed, 27 Jun 2007 11:42:17 +0000 (11:42 +0000)]
r23627: Allow to pass down the lookup-level to rpccli_lsa_lookup_names().

(This used to be commit e9a7512a9f630340004913f1379452eea8a9b6ae)

15 years agor23625: Reformating WBFLAGs, just a cosmetic change.
Günther Deschner [Wed, 27 Jun 2007 09:38:07 +0000 (09:38 +0000)]
r23625: Reformating WBFLAGs, just a cosmetic change.

(This used to be commit 555ae4a19b35b0672033798e00e3d1e153d2a9b3)

15 years agor23624: Merge dos error code from samba4 (returned from dfs_Enum against w2k3 as...
Günther Deschner [Wed, 27 Jun 2007 09:36:00 +0000 (09:36 +0000)]
r23624: Merge dos error code from samba4 (returned from dfs_Enum against w2k3 as soon
as a one DFS_VOLUME_FLAVOR_AD_BLOB dfsroot exists).

(This used to be commit 837b0a14c430faa4e4cada03a1efe2823a7b2e2e)

15 years agor23623: Fix rpcclient and rpc_server with new DFS idl.
Günther Deschner [Wed, 27 Jun 2007 09:23:50 +0000 (09:23 +0000)]
r23623: Fix rpcclient and rpc_server with new DFS idl.

(This used to be commit bffe33dd261fdcf9ef8f9f232c15559661843c7c)

15 years agor23622: regenerate dfs rpc gen_ndr.
Günther Deschner [Wed, 27 Jun 2007 09:17:52 +0000 (09:17 +0000)]
r23622: regenerate dfs rpc gen_ndr.

(This used to be commit 71b3259962004c278ca2e859d5460ad47c2468d6)

15 years agor23621: Merge samba4 dfs rpc idl.
Günther Deschner [Wed, 27 Jun 2007 09:13:28 +0000 (09:13 +0000)]
r23621: Merge samba4 dfs rpc idl.

(This used to be commit bb43d56e92f4ea08fbf2ae4fa90570a101efd4e2)

15 years agor23620: Convert set_nt_acl to return NTSTATUS. Also fix the chown
Jeremy Allison [Tue, 26 Jun 2007 22:49:10 +0000 (22:49 +0000)]
r23620: Convert set_nt_acl to return NTSTATUS. Also fix the chown
return to correctly return NT_STATUS_INVALID_OWNER if it
should be disallowed. Matches better what W2K3R3 does.

NFSv4 ACL module owners, please examine these changes.

(This used to be commit fc6899a5506b272f8cd5f5837ca13300b4e69a5f)

15 years agor23619: Fix compile warning in fill_grent_mem() caused by mismatched counter size.
Gerald Carter [Tue, 26 Jun 2007 21:22:01 +0000 (21:22 +0000)]
r23619: Fix compile warning in fill_grent_mem() caused by mismatched counter size.
(This used to be commit 05520d6b0a86c1cd5abbf6252c4a32629cdf8619)

15 years agor23616: Fix bugzilla #4719: must change password is not set from usrmgr.exe.
Jim McDonough [Tue, 26 Jun 2007 20:09:41 +0000 (20:09 +0000)]
r23616: Fix bugzilla #4719: must change password is not set from usrmgr.exe.

This was only affecting the newer versions of usrmgr.exe, because they
use a user_info_25 struct.  The password is getting set separately
inside that code, so the password last set time was getting set from the
password change logic.

We also were not parsing a number of fields (like logon hours) from the
user_info_25.  That should also be fixed.
(This used to be commit afabd68b6ae874aceba708dc36808ed007ad496c)

15 years agor23612: Revert 'net idmap dump' to the 3.0.24 behaviour.
Volker Lendecke [Tue, 26 Jun 2007 19:15:26 +0000 (19:15 +0000)]
r23612: Revert 'net idmap dump' to the 3.0.24 behaviour.
(This used to be commit 56a32f217a183f956ad1c57a62d61a43646aa391)

15 years agor23611: Fix typo in error message.
James Peach [Tue, 26 Jun 2007 18:18:44 +0000 (18:18 +0000)]
r23611: Fix typo in error message.
(This used to be commit 8ee76e43843c56869b23f58615635f986c162d01)

15 years agor23610: Move some winbindd_cache specific flags and actions
Michael Adam [Tue, 26 Jun 2007 13:45:07 +0000 (13:45 +0000)]
r23610: Move some winbindd_cache specific flags and actions
back to winbindd_cache.c. The generic mechanism
should open the cache tdb readonly and with default

(This used to be commit 062d8c61294a1e9f8588fa8af31954dd286c7bde)

15 years agor23609: Removing more redundant codepaths out of smb_krb5_renew_ticket().
Günther Deschner [Tue, 26 Jun 2007 10:19:06 +0000 (10:19 +0000)]
r23609: Removing more redundant codepaths out of smb_krb5_renew_ticket().

Thanks Volker for the pointer hint :)

(This used to be commit eb1ec508ace3a5eeb53cf47be44047bd9228cd19)

15 years agor23608: Just inline comment cosmetics.
Günther Deschner [Tue, 26 Jun 2007 09:41:14 +0000 (09:41 +0000)]
r23608: Just inline comment cosmetics.

(This used to be commit 90c810674dff17b2d08d49cb8d945a86204598a6)

15 years agor23607: Add legacy support for Services for Unix (SFU) 2.0.
Günther Deschner [Tue, 26 Jun 2007 09:15:37 +0000 (09:15 +0000)]
r23607: Add legacy support for Services for Unix (SFU) 2.0.

(This used to be commit 11b390309b9677805e5b68f3a1b780658ae85137)

15 years agor23606: Merge Samba4 to Samba3.
Kai Blin [Tue, 26 Jun 2007 09:10:30 +0000 (09:10 +0000)]
r23606: Merge Samba4 to Samba3.
(This used to be commit 6566e24c13aaf974b756c230d4890357e7adf73d)

15 years agor23601: BUG 4579: Don't mark the SAM domain on a Samba DC as an internal domain or...
Gerald Carter [Tue, 26 Jun 2007 00:52:19 +0000 (00:52 +0000)]
r23601: BUG 4579: Don't mark the SAM domain on a Samba DC as an internal domain or else all network connections from the local winbindd will fail
(This used to be commit 5e0f8b114b964d08cfb22a7452c617b8512545dc)

15 years agor23600: First step in abstracting the winbindd cache validation
Michael Adam [Mon, 25 Jun 2007 20:17:04 +0000 (20:17 +0000)]
r23600: First step in abstracting the winbindd cache validation
code into a generic tdb validation code.
In lib/util_tdb.c for a start.

(This used to be commit 527edfa0cbcb233218ebabc395666d1d7228ee37)

15 years agor23599: Add new version of indent script copied from the the Linux
Gerald Carter [Mon, 25 Jun 2007 15:23:19 +0000 (15:23 +0000)]
r23599: Add new version of indent script copied from the the Linux
kernel tree.
(This used to be commit bc422ab5f152c3d7ff730a2e0a80ad3a196a797a)

15 years agor23598: Add script for running indent and remove file
Gerald Carter [Mon, 25 Jun 2007 15:18:41 +0000 (15:18 +0000)]
r23598: Add script for running indent and remove file
(This used to be commit 58a68daef0e4b34606c63670982e95298804a99b)

15 years agor23597: add a few utility scripts for code formatting
Gerald Carter [Mon, 25 Jun 2007 14:40:59 +0000 (14:40 +0000)]
r23597: add a few utility scripts for code formatting
(This used to be commit 3fc0bd3e540652742f5bdd7afa88d80b893e50cd)

15 years agor23596: Add notes about smbfs/cifs to usage() in smb[u]mount
Volker Lendecke [Mon, 25 Jun 2007 11:45:54 +0000 (11:45 +0000)]
r23596: Add notes about smbfs/cifs to usage() in smb[u]mount
(This used to be commit 4896b4ee55b3c8213754ebe6a8edafd82a40c014)

15 years agor23595: One pstring a day...
Volker Lendecke [Sun, 24 Jun 2007 13:40:58 +0000 (13:40 +0000)]
r23595: One pstring a day...
(This used to be commit 669eff902a20f3023360918ede6672d37b1f7d44)

15 years agor23594: Fix parsing of local pids if cluster support is compiled in but no
Volker Lendecke [Sun, 24 Jun 2007 13:24:20 +0000 (13:24 +0000)]
r23594: Fix parsing of local pids if cluster support is compiled in but no
cluster is used
(This used to be commit 6beaa87da938f2a530939714b732fa769a28a008)

15 years agor23593: Mention "net conf" in top level net usage.
Michael Adam [Fri, 22 Jun 2007 22:37:07 +0000 (22:37 +0000)]
r23593: Mention "net conf" in top level net usage.

(This used to be commit ae7e3c9708a16fe70acf609d9a9370a9e3f2ab37)

15 years agor23592: Change a debuglevel to not clutter output when calling
Michael Adam [Fri, 22 Jun 2007 22:30:01 +0000 (22:30 +0000)]
r23592: Change a debuglevel to not clutter output when calling
net as a non-root user, e.g.

(This used to be commit bbbfd7f41ab85f269d115f19601729f16079b552)

15 years agor23591: Fix bug #4725. Don't crash when no eventlogs specified. Needs
Jeremy Allison [Fri, 22 Jun 2007 19:33:46 +0000 (19:33 +0000)]
r23591: Fix bug #4725. Don't crash when no eventlogs specified. Needs
merging for 3.0.25b.
(This used to be commit ae239fec6faa79018c818506b391b829ccd685f8)

15 years agor23590: Fix realloc leak on failure case from Jim Meyering <>.
Jeremy Allison [Fri, 22 Jun 2007 17:36:10 +0000 (17:36 +0000)]
r23590: Fix realloc leak on failure case from Jim Meyering  <>.
(This used to be commit d7b39e4534d85c84e8b24668ab7d7a93d5647c23)

15 years agor23589: Ensure we will always release any timeout handler
Jeremy Allison [Fri, 22 Jun 2007 17:19:08 +0000 (17:19 +0000)]
r23589: Ensure we will always release any timeout handler
on fsp close or removal of oplock. Mulitple removals
are safe.
(This used to be commit 6de0970704b3eff2b71e6bf499c6dda45d4d5e2d)

15 years agor23588: Some more cleanups and error checks in the krb5 renew function.
Günther Deschner [Fri, 22 Jun 2007 14:54:39 +0000 (14:54 +0000)]
r23588: Some more cleanups and error checks in the krb5 renew function.

(This used to be commit 277e07c8553e2ed20bc95493cdc996be43feb6bd)

15 years agor23587: Cleanup redundant code in the krb5 renew function.
Günther Deschner [Fri, 22 Jun 2007 14:50:15 +0000 (14:50 +0000)]
r23587: Cleanup redundant code in the krb5 renew function.

(This used to be commit 0b9acc8610ae2ba9c42168e9ceb2e9ea8bc2f5bd)

15 years agor23586: Fix heimdal path in the krb5 renew routine when we need to compose the tgt
Günther Deschner [Fri, 22 Jun 2007 14:43:42 +0000 (14:43 +0000)]
r23586: Fix heimdal path in the krb5 renew routine when we need to compose the tgt
string ourselves.

(This used to be commit 1e4a7af99303fb17ebca499ff7e0a017a2017754)

15 years agor23585: Add a "drop" function to "net conf" that clears the
Michael Adam [Fri, 22 Jun 2007 11:43:50 +0000 (11:43 +0000)]
r23585: Add a "drop" function to "net conf" that clears the
whole configuration stored in registry.

(This used to be commit 6d8973762ef2773ec64ed790f900253120e00d38)

15 years agor23584: Use a while loop instead of a for loop without increment... :-)
Michael Adam [Fri, 22 Jun 2007 11:42:17 +0000 (11:42 +0000)]
r23584: Use a while loop instead of a for loop without increment... :-)

(This used to be commit fb4ade3b4d203eead7798b8d98938cff2abb9c29)

15 years agor23583: Add a utility function to recursively delete a Registry
Michael Adam [Fri, 22 Jun 2007 11:21:59 +0000 (11:21 +0000)]
r23583: Add a utility function to recursively delete a Registry
key with all its subkeys. (reg_deletekey will refuse to
delete a key with subkeys with WERR_ACCESS_DENIED).

(This used to be commit 41c3ff6e277601a9c7ac29009fd89ff9c961ca46)

15 years agor23582: Fix event based krb5 ticket refreshing in winbindd.
Günther Deschner [Fri, 22 Jun 2007 11:20:37 +0000 (11:20 +0000)]
r23582: Fix event based krb5 ticket refreshing in winbindd.

We were incorrectly using the renew_till timestamp instead of the renewed
ticket's endtime to calculate the next refreshing date.

(This used to be commit aa3511a5b5e6a96a02110a7ad0ab1d43e6d25766)

15 years agor23581: Move regkey_open_onelevel from reg_frontend to reg_api,
Michael Adam [Fri, 22 Jun 2007 11:03:48 +0000 (11:03 +0000)]
r23581: Move regkey_open_onelevel from reg_frontend to reg_api,
where it actually belongs, and make it static.

(This used to be commit aa702e53a7416b5599ed114089327aef8a4e35b8)

15 years agor23579: Up to now, the "allparameters" argument to lp_next_parameter was
Michael Adam [Thu, 21 Jun 2007 23:11:21 +0000 (23:11 +0000)]
r23579: Up to now, the "allparameters" argument to lp_next_parameter was
not effective for the global section (snum < 0). This checkin
makes it effective for the global section, too.

This does not produce changes in the results of the present calls of
lp_next_parameter: Beside the new use in utils/net_conf.c (which is
hereby fixed), the only calls of lp_next_parameter are in web/swat.c,
where it is effectively always called with allparameters == 1.

(This used to be commit 56f82485ec3b14ddcbcf7f5823926a94b17683f3)

15 years agor23578: When calling DeleteKey for a key that has subkey(s), Windows
Michael Adam [Thu, 21 Jun 2007 22:18:42 +0000 (22:18 +0000)]
r23578: When calling DeleteKey for a key that has subkey(s), Windows
returns WERR_ACCESS_DENIED. This adapts reg_deletekey to behave
the same way.

(This used to be commit 0c9cb69b45e8c51b8c3fa0b0d034a6cad2374055)

15 years agor23577: Fix winbindd (sorry). Ensure I set the new child_pid
Jeremy Allison [Thu, 21 Jun 2007 22:10:41 +0000 (22:10 +0000)]
r23577: Fix winbindd (sorry). Ensure I set the new child_pid
variable at the correct point just before the write
call is scheduled.
(This used to be commit e076dc16462a3ce11105bf9a729ec59ddd9bdc75)

15 years agor23576: Fix some confusion between HAVE_BROKEN_GETGROUPS and USE_BSD_SETGROUPS.
James Peach [Thu, 21 Jun 2007 21:17:06 +0000 (21:17 +0000)]
r23576: Fix some confusion between HAVE_BROKEN_GETGROUPS and USE_BSD_SETGROUPS.
(This used to be commit 8f6cf4b8c2568c737fa31494b844ae021a42a4fc)

15 years agor23575: Fix a segfault when lp_load is called before init_registry.
Michael Adam [Thu, 21 Jun 2007 20:56:56 +0000 (20:56 +0000)]
r23575: Fix a segfault when lp_load is called before init_registry.

(This used to be commit 235a5ae4cdf3ea238728c2e89a4318c18257426a)

15 years agor23574: Remove double-null check (I hate people bitching at me
Jeremy Allison [Thu, 21 Jun 2007 19:40:51 +0000 (19:40 +0000)]
r23574: Remove double-null check (I hate people bitching at me
on the lists :-).
(This used to be commit f075620d2071aaecb72e93cbda32c4f624f23d86)

15 years agor23573: Cope with terminating winbindd children on read/write/timeout
Jeremy Allison [Thu, 21 Jun 2007 18:44:14 +0000 (18:44 +0000)]
r23573: Cope with terminating winbindd children on read/write/timeout
communication failures. Set timeout to 5 mins. Ensure that
we're terminating the correct child (the one we thought we
were talking to). Still setting up my testing environment
but I have high hopes for this being the fix for the 3.0.25b
(This used to be commit c366df2fe7f1aa1e8fd9bca35bc3b029d76b3abc)

15 years agor23572: Ensure we obey Unicode consortium restrictions. Code
Jeremy Allison [Thu, 21 Jun 2007 17:25:13 +0000 (17:25 +0000)]
r23572: Ensure we obey Unicode consortium restrictions. Code
based on patch from MORIYAMA Masayuki <>.
(This used to be commit 0f10d2ed312115998d5ce1dc88a8d9207c9e4959)

15 years agor23571: Fix, parsing of multi byte share names.
Simo Sorce [Thu, 21 Jun 2007 17:05:59 +0000 (17:05 +0000)]
r23571: Fix, parsing of multi byte share names.
Thanks to SATOH Fumiyasu
Fixes 4720

this is a showstopper for 3.0.25b, please grab it into
SAMBA_3_0_RELEASE before cuting the tarballs.

(This used to be commit d2846e6b90e8774a729e6cf3a0c809aa8ff4a93a)

15 years agor23569: Also dump fd_event in dump_event_list().
Günther Deschner [Thu, 21 Jun 2007 15:12:51 +0000 (15:12 +0000)]
r23569: Also dump fd_event in dump_event_list().

(This used to be commit 27fdf995d13611ebc9e57895f886c184e9027c4d)

15 years agor23568: Remove last traces of Heimdal KCM support (and don't misuse wbinfo where a
Günther Deschner [Thu, 21 Jun 2007 14:32:09 +0000 (14:32 +0000)]
r23568: Remove last traces of Heimdal KCM support (and don't misuse wbinfo where a
torture test would be much more appropriate). Fix #4408.

(This used to be commit 7514a370cae9c6fdacffd2b885fd93cb1230ce96)

15 years agor23567: Fix bug 4721
Volker Lendecke [Thu, 21 Jun 2007 14:30:40 +0000 (14:30 +0000)]
r23567: Fix bug 4721
(This used to be commit f2050f5a3af382ad88071a5d5f6b172af4143e0f)

15 years agor23566: Fix the sys_bsd_setgroups function. The actual workaround was inactive.
Michael Adam [Thu, 21 Jun 2007 14:23:06 +0000 (14:23 +0000)]
r23566: Fix the sys_bsd_setgroups function. The actual workaround was inactive.

(This used to be commit 4b5d9b2ba773e6ce57c38e3c0d5af72ad5a98b51)

15 years agor23565: Avoid double NULL pointer checks.
Günther Deschner [Thu, 21 Jun 2007 14:04:55 +0000 (14:04 +0000)]
r23565: Avoid double NULL pointer checks.

(This used to be commit 5456ea59ba12593b0aac9745b41cdd0f5ec0a559)

15 years agor23564: Handle MSG_DUMP_EVENT_LIST only in winbindd for now.
Günther Deschner [Thu, 21 Jun 2007 13:05:56 +0000 (13:05 +0000)]
r23564: Handle MSG_DUMP_EVENT_LIST only in winbindd for now.

(This used to be commit 2592e68a43a73474e1bb53f83642c864fd159b45)

15 years agor23563: Add dump-event-list command to smbcontrol.
Günther Deschner [Thu, 21 Jun 2007 13:04:28 +0000 (13:04 +0000)]
r23563: Add dump-event-list command to smbcontrol.

(This used to be commit 0d956a8e45cd4421cddb8e077e1960dafac3a4d0)

15 years agor23562: Add dump_event_list() for debugging the event list.
Günther Deschner [Thu, 21 Jun 2007 13:03:27 +0000 (13:03 +0000)]
r23562: Add dump_event_list() for debugging the event list.

(This used to be commit 4e1e697ac48513719bd3a2152f17871bc00df796)

15 years agor23556: Fix for error path from Atsushi Nakabayashi <>.
Jeremy Allison [Wed, 20 Jun 2007 23:24:18 +0000 (23:24 +0000)]
r23556: Fix for error path from Atsushi Nakabayashi <>.
(This used to be commit 3f70c1b10589965ee95ef7497ff6fb7c39475569)

15 years agor23555: Fix some uninitialiazed variable uses.
Jeremy Allison [Wed, 20 Jun 2007 18:05:48 +0000 (18:05 +0000)]
r23555: Fix some uninitialiazed variable uses.
(This used to be commit dc287adff249e45a5584ec5fb9177e62152a7403)

15 years agor23554: Fix bug #4711 by makeing cli_connect return an NTSTATUS.
Jeremy Allison [Wed, 20 Jun 2007 17:38:42 +0000 (17:38 +0000)]
r23554: Fix bug #4711 by makeing cli_connect return an NTSTATUS.
Long overdue fix....
(This used to be commit 073fdc5a58139796dbaa7ea9833dca5308f11282)

15 years agor23553: Also ignore "lock directory" in registry global options.
Michael Adam [Wed, 20 Jun 2007 10:08:31 +0000 (10:08 +0000)]
r23553: Also ignore "lock directory" in registry global options.

(This used to be commit 3695a66166c6aa88051b21ad40a19f1cc8b87c7b)

15 years agor23552: Use proper comparison function an fix logic.
Michael Adam [Wed, 20 Jun 2007 08:47:13 +0000 (08:47 +0000)]
r23552: Use proper comparison function an fix logic.

(This used to be commit a4714b34284f9e205556166166f41ce9dad4d3da)

15 years agor23550: Add more UNIX error -> NT status mappings.
Jeremy Allison [Wed, 20 Jun 2007 01:26:18 +0000 (01:26 +0000)]
r23550: Add more UNIX error -> NT status mappings.
(This used to be commit 1e66a8340e7db9c42507d93d67ad33abadabd2a1)

15 years agor23549: Make "net conf setparm" always use registry data type "sz".
Michael Adam [Tue, 19 Jun 2007 21:40:27 +0000 (21:40 +0000)]
r23549: Make "net conf setparm" always use registry data type "sz".
This simplifies the usage of this command from
"net conf setparm <section> <param> <type> <value>"
"net conf setparm <section> <param> <value>".

(This used to be commit 41a8f8ec5f5361f536d047c4ca5d90203b16ff06)

15 years agor23548: Fix comments.
Michael Adam [Tue, 19 Jun 2007 21:08:46 +0000 (21:08 +0000)]
r23548: Fix comments.

(This used to be commit 73e41c1d0a7af7488b35b54182ea532103b51fd4)

15 years agor23547: Ignore parameter "include" in regsitry globals.
Michael Adam [Tue, 19 Jun 2007 21:06:31 +0000 (21:06 +0000)]
r23547: Ignore parameter "include" in regsitry globals.

(This used to be commit f0992c0d79bb6a5810c84a9eac208d83390bb047)

15 years agor23543: Adjust comments.
Michael Adam [Tue, 19 Jun 2007 11:11:01 +0000 (11:11 +0000)]
r23543: Adjust comments.
(This used to be commit ec22c30581f0809b6a008982abceb97b4f9cd12e)

15 years agor23541: Linking the LSA pipe module only once is probably enough.
James Peach [Mon, 18 Jun 2007 16:10:00 +0000 (16:10 +0000)]
r23541: Linking the LSA pipe module only once is probably enough.
(This used to be commit 1d941961e0739c22d32720bac4ecd6beef6d74c5)

15 years agor23539: Remove code duplication and unify behaviour of winbind_nss_*.h files
Kai Blin [Mon, 18 Jun 2007 13:59:09 +0000 (13:59 +0000)]
r23539: Remove code duplication and unify behaviour of winbind_nss_*.h files
(This used to be commit 13c6eacff02b55b9fd6201406802f271dcf13e8e)

15 years agor23538: Fix for wild-card rename: We can't return directly on error, we need to
Volker Lendecke [Mon, 18 Jun 2007 12:22:42 +0000 (12:22 +0000)]
r23538: Fix for wild-card rename: We can't return directly on error, we need to
(This used to be commit 48cdafc10a0eb615d79057ec9e235ffe9a85e016)

15 years agor23537: Revert the inbuf/outbuf part of r23528: This caused the Solaris CC make test
Volker Lendecke [Mon, 18 Jun 2007 09:25:31 +0000 (09:25 +0000)]
r23537: Revert the inbuf/outbuf part of r23528: This caused the Solaris CC make test
to break. The Solaris CC put the static char InBuffer[TOTAL_BUFFER_SIZE] on an
odd address, the malloc'ed one is always aligned. The problem showed up in
pull_ucs2, ucs2_align uses the address of InBuffer as an indication whether to
bump up the src of the string by one. Unfortunately in the trans calls the
data portion is malloced and thus has different alignment guarantees than a
static variable. This one is bigger....

(This used to be commit 6affd7818f6981be2a9f44fcf302e7fddb468347)

15 years agor23536: Fix a typo. James: Please check!
Michael Adam [Sun, 17 Jun 2007 23:13:32 +0000 (23:13 +0000)]
r23536: Fix a typo. James: Please check!

(This used to be commit d90aa8368af624761a19cd1e55ed9f18bc64f45d)

15 years agor23530: Fix bugs #4678 and #4697 which had the same root cause.
Jeremy Allison [Sun, 17 Jun 2007 19:23:32 +0000 (19:23 +0000)]
r23530: Fix bugs #4678 and #4697 which had the same root cause.
In make_server_info_pw() we assign a user SID in our
authoritative SAM, even though this may be from a
pure "Unix User" that doesn't exist in the SAM.
This causes lookups on "[in]valid users" to fail as they
will lookup this name as a "Unix User" SID to check against
the user token. Fix this by adding the "Unix User"\unix_username
SID to the sid array. The correct fix should probably be
changing the server_info->sam_account user SID to be a
S-1-22 Unix SID, but this might break old configs where
plaintext passwords were used with no SAM backend.
(This used to be commit 80d1da7e6cce451d3934751feaa6ad60a337e3db)

15 years agor23528: Two changes to make the valgrind massif (heap profiler) output readable:
Volker Lendecke [Sun, 17 Jun 2007 05:19:30 +0000 (05:19 +0000)]
r23528: Two changes to make the valgrind massif (heap profiler) output readable:

Remove the allocated inbuf/output. In async I/O we copy the buffers
explicitly now, so NewInBuffer is called exactly once. This does not
reduce memory footprint, but removes one of the larger chunks that
clobber the rest of the massif output

In getgroups_unix_user on Linux 2.6 we allocated 64k groups x 4 bytes
per group x 2 (once in the routine itself and once in libc) = 512k just
to throw it away directly again. This reduces it do a more typical limit
of 32 groups per user. We certainly cope with overflow fine if 32 is not
enough. Not 100% sure about this one, a DEVELOPER only thing?
(This used to be commit 009af0909944e0f303c5d496b56fb65ca40a41d5)

15 years agor23527: Use existing escaping function pointed by James
Simo Sorce [Sat, 16 Jun 2007 22:52:51 +0000 (22:52 +0000)]
r23527: Use existing escaping function pointed by James
(This used to be commit 9dcbef9615aec7cfe8f72e6f21f01af4e4fcc90e)

15 years agor23525: I believe this patch is ok, got no reply of it being not ok.
Simo Sorce [Sat, 16 Jun 2007 18:59:02 +0000 (18:59 +0000)]
r23525: I believe this patch is ok, got no reply of it being not ok.
This closes #4624 for me.
(This used to be commit 3635b304155299ac93fda57e5e9ece0acd605e77)

15 years agor23524: Fix bug 2319.
Simo Sorce [Sat, 16 Jun 2007 18:54:13 +0000 (18:54 +0000)]
r23524: Fix bug 2319.
Got report this is all ok form a tester. Close a loong
standing bug preventing people to freely use any character
in their password when printing via cups were involved.
(This used to be commit 54ca011212982cf1d94a76ca9d39c391783da04f)

15 years agor23523: Gaa -- had renamed "name" to "path" and apparently not compiled after
Volker Lendecke [Sat, 16 Jun 2007 18:19:42 +0000 (18:19 +0000)]
r23523: Gaa -- had renamed "name" to "path" and apparently not compiled after

(This used to be commit 1a45ea28ced3775acd6127e05e844873ed23d40b)

15 years agor23522: Save us a kilobyte stack space in a hot code path: I can't see a reason
Volker Lendecke [Sat, 16 Jun 2007 18:07:44 +0000 (18:07 +0000)]
r23522: Save us a kilobyte stack space in a hot code path: I can't see a reason
why check_path_syntax should not be able to run in-line. The destination
pointer either walks side by side with the source pointer or is
decremented. So as far as I can see s>=d is true throughout the whole

Jeremy, I'm checking this only into 3_0 for now. Please review and ack
or directly merge this to 3_0_26.


(This used to be commit 34a13c82a3b72d6900614b57c58fbaefeeca8fa7)

15 years agor23518: Remove the silly assumption that string_replace requires a pstring.
Volker Lendecke [Sat, 16 Jun 2007 11:48:11 +0000 (11:48 +0000)]
r23518: Remove the silly assumption that string_replace requires a pstring.

Jeremy, I am always very confused about the different length arguments
in convert_string and friends. Can you take a look at the change in
string_replace and verify it's ok? Thanks!

While at it, remove the pstring limit for strhasupper and strhaslower.
(This used to be commit e6e5703658aeaeb0cca5d7281095e17553001d4b)

15 years agor23517: After Jeremy has given is ack on irc:
Volker Lendecke [Sat, 16 Jun 2007 10:02:51 +0000 (10:02 +0000)]
r23517: After Jeremy has given is ack on irc:

Change rename_internals to open the file/directory and then call
rename_internals_fsp. Two reasons: Remove code duplication and remove a
race condition. The race condition was due to the fact that in
can_rename the share mode check closed the file and then after that did
the rename.
(This used to be commit aa16d8a649d1a38593edd5ca94ed2c7d4291911b)

15 years agor23516: Fix bug found & fixed by Doug Rudoff (
Jeremy Allison [Sat, 16 Jun 2007 01:04:22 +0000 (01:04 +0000)]
r23516: Fix bug found & fixed by Doug Rudoff (
- when cleaning up invalid locks make sure we mark the lck
struct as modified so it'll get saved back correctly (that
was the original intent).
(This used to be commit cbf0829abcc3689edd7ab225054dfc79d43c6309)

15 years agor23515: Ensure status isn't used uninitialized.
Jeremy Allison [Sat, 16 Jun 2007 00:54:58 +0000 (00:54 +0000)]
r23515: Ensure status isn't used uninitialized.
(This used to be commit 5b2836e2d5f9081b5e39637538d8f2d19e1115c4)

15 years agor23514: Remove unused function ads_get_dn_from_extended_dn().
Jeremy Allison [Sat, 16 Jun 2007 00:39:52 +0000 (00:39 +0000)]
r23514: Remove unused function ads_get_dn_from_extended_dn().
(This used to be commit 03763bc5287fef5f100c911041668e23d4305f8d)

15 years agor23513: Fix one more use of VALUE_PREFIX.
Jeremy Allison [Fri, 15 Jun 2007 23:52:01 +0000 (23:52 +0000)]
r23513: Fix one more use of VALUE_PREFIX.
(This used to be commit fca5637dc6c91a57c4e087670068688557e5bf32)

15 years agor23512: Fix conflict in #define for SECDESC_PREFIX. Ensure all
Jeremy Allison [Fri, 15 Jun 2007 23:47:40 +0000 (23:47 +0000)]
r23512: Fix conflict in #define for SECDESC_PREFIX. Ensure all
reg #defines use "REG_" prefix. Michael - please check
gcc warnings on compiles.
(This used to be commit 7885b68bb5df0ebe290feca0e74b4a20ef59e718)

15 years agor23510: Tidy calls to smb_panic by removing trailing newlines. Print the
James Peach [Fri, 15 Jun 2007 21:58:49 +0000 (21:58 +0000)]
r23510: Tidy calls to smb_panic by removing trailing newlines. Print the
failed expression in SMB_ASSERT.
(This used to be commit 171dc060e2a576d724eed1ca65636bdafffd7713)

15 years agor23509: This activates the global options from the registry in loadparm.
Michael Adam [Fri, 15 Jun 2007 21:38:10 +0000 (21:38 +0000)]
r23509: This activates the global options from the registry in loadparm.
The global options are stored as values in the subkey "global"
of the SMBCONF registry key.

The activation is accomplished in smb.conf though a new special
semantic of the "include" parameter: "include = registry" triggers
the processing of the registry global options exactly at the
position of the include statement. Options read from the registry
take the same precedence as parameters loaded from a file via
include. Need to reload the registry globals is detected by
watching the tdb sequence number.

Registry shares are automatically activated when the registry
globals are processed.

So a "registry only" configuration can be realized by an
smb.conf that looks as follows:

include = registry

The global options and registry shares can be conveniently
edited with the "net conf" utility.


A possible pitfall consists in using "include = registry"
together with the "lock directory" directive in the registry.
This problem will be addressed in the next time.

Note on the code:

Processing of the registry options is accomplished by a function
process_registry_globals() in loadparm.c The current version is
only an interim solution: It is handcoded instead of using the
infrastructure of reg_api.c. The reason for this is that using
reg_api still has too large linker dependencies, bloating virtually
all targets by PASSDB_OBJ, SMBLDAP_OBJ, GROUPDB_OBJ and LDB stuff.
A version of process_registry_globals that uses reg_api is
included but commented out. The goal is to eventually refactor
and restructure the registry code so that one can use the reg_api
to access only the registry tdb and not link all the dynamic
backends with all their linking implications.
(This used to be commit 24b0cbcb3741dd14b04728448a85cc04a057e7d0)

15 years agor23508: Fix sync_file() to return NTSTATUS and return this
Jeremy Allison [Fri, 15 Jun 2007 19:24:04 +0000 (19:24 +0000)]
r23508: Fix sync_file() to return NTSTATUS and return this
on failure in the write path.
(This used to be commit cd3f7dbee809fb40194af0e7509142166e02b252)

15 years agor23507: Split one general function normalize_dbkey from reg_db.c into util_reg.c
Michael Adam [Fri, 15 Jun 2007 15:51:45 +0000 (15:51 +0000)]
r23507: Split one general function normalize_dbkey from reg_db.c into util_reg.c
(To be used in other place in subsequent commit.)

(This used to be commit 6fd71140499e30b8fd0f083301512db7b8c2f236)

15 years agor23504: Use tdb_wrap_open (instead of usual tdb_open) in reg_db.
Michael Adam [Fri, 15 Jun 2007 10:40:36 +0000 (10:40 +0000)]
r23504: Use tdb_wrap_open (instead of usual tdb_open) in reg_db.
This eliminates the need of maintaining reg_db's own
reference counter for the tdb. Maybe as a next step...

(This used to be commit 31d64767fc8a73be1f6b81e2712d687897f812a0)

15 years agor23502: Restore exit-on-idle. Small refactoring for clarity. Exit if
James Peach [Thu, 14 Jun 2007 18:48:51 +0000 (18:48 +0000)]
r23502:     Restore exit-on-idle.  Small refactoring for clarity. Exit if
    we are idle and we timed out waiting for something to do.
(This used to be commit b4ab1a0cd992cf9e966b8edb9796d1eae53db744)

15 years agor23501: Move notify_rename before rename_internals_fsp and call it from there.
Volker Lendecke [Thu, 14 Jun 2007 15:50:47 +0000 (15:50 +0000)]
r23501: Move notify_rename before rename_internals_fsp and call it from there.
(This used to be commit 8d3828871c561cd05e6461e157db4c0ccddd5f22)

15 years agor23500: Two changes to survive the now activated test for rename_internals_fsp:
Volker Lendecke [Thu, 14 Jun 2007 14:45:37 +0000 (14:45 +0000)]
r23500: Two changes to survive the now activated test for rename_internals_fsp:
With the target being open we have to return NT_STATUS_ACCESS_DENIED and
root_fid != 0 leads to NT_STATUS_INVALID_PARAMETER
(This used to be commit b599e5b1e10bdf825b2ce53de4a6ec35726d00f6)