Jelmer Vernooij [Tue, 18 Feb 2003 22:14:04 +0000 (22:14 +0000)]
Regenerate
Jelmer Vernooij [Tue, 18 Feb 2003 21:50:31 +0000 (21:50 +0000)]
Update to current status
Jelmer Vernooij [Tue, 18 Feb 2003 21:49:00 +0000 (21:49 +0000)]
Document -k
Jelmer Vernooij [Tue, 18 Feb 2003 21:44:34 +0000 (21:44 +0000)]
Few small cosmetic changes
Jelmer Vernooij [Tue, 18 Feb 2003 21:32:26 +0000 (21:32 +0000)]
Use sgml syntax for warnings
Jelmer Vernooij [Tue, 18 Feb 2003 21:12:28 +0000 (21:12 +0000)]
Move all password database stuff to one document - hope this makes it somewhat
more understandable for the user. Comments are welcome!
Jelmer Vernooij [Tue, 18 Feb 2003 20:12:20 +0000 (20:12 +0000)]
Update introduction
Jelmer Vernooij [Tue, 18 Feb 2003 18:43:59 +0000 (18:43 +0000)]
Add -V option (to print out version) to utilities where possible
(pdbedit already has a -V option..)
Jelmer Vernooij [Tue, 18 Feb 2003 18:34:48 +0000 (18:34 +0000)]
Use the new modules stuff to load dynrpc modules. Basically this means:
- calling the initialization function in the module init_module() instead of rpc_pipe_init()
- calling smb_load_module() to do the dlopen(), dlsym() and init_module() calls
I'll merge this to 3.0, together with the smb_load_module() function.
Discussed with Anthony.
Rafal Szczesniak [Tue, 18 Feb 2003 14:59:21 +0000 (14:59 +0000)]
Fix of two warnings.
pull_ucs2_talloc function takes char** pointer, not (here
explicitly casted) void** one.
Rafal
Tim Potter [Tue, 18 Feb 2003 05:08:09 +0000 (05:08 +0000)]
We don't use mkproto stuff for the python extensions anymore.
Tim Potter [Tue, 18 Feb 2003 05:05:15 +0000 (05:05 +0000)]
Cleanup of header files for python extensions.
- combine py_foo_proto.h and py_foo.h
- move #include of Python.h into one place so we can get rid of that
annoying compiler warning about HAVE_FSTAT being redefined
Jeremy Allison [Tue, 18 Feb 2003 04:49:31 +0000 (04:49 +0000)]
Ensure we use getgrnam() unless BROKEN_GETGRNAM is defined. I now need
to set this for Tru64.
Jeremy.
Gerald Carter [Tue, 18 Feb 2003 03:43:08 +0000 (03:43 +0000)]
set the various DsSpooler keys that are linked to PRINTER_INFO_2 fields; CR 985
Martin Pool [Tue, 18 Feb 2003 02:01:38 +0000 (02:01 +0000)]
Remove obsolete comment.
Martin Pool [Tue, 18 Feb 2003 01:55:50 +0000 (01:55 +0000)]
Doxygen janitor. No other changes.
Martin Pool [Tue, 18 Feb 2003 01:35:19 +0000 (01:35 +0000)]
cmd_lsa_lookup_sids: Check return code from string_to_sid; skip SIDs
which are not valid.
Martin Pool [Tue, 18 Feb 2003 01:30:22 +0000 (01:30 +0000)]
init_dom_sid2s: Check return code from string_to_sid. Skip tokens
that are not valid SIDs.
Martin Pool [Tue, 18 Feb 2003 01:09:19 +0000 (01:09 +0000)]
Check return code from string_to_sid.
Martin Pool [Tue, 18 Feb 2003 01:05:56 +0000 (01:05 +0000)]
add_initial_entry should fail if string_to_sid fails.
Andrew Bartlett [Tue, 18 Feb 2003 00:54:22 +0000 (00:54 +0000)]
Patch from vorlon@debian.org to split out our -lacl dependency to only smbd
and vfstest.
Martin Pool [Tue, 18 Feb 2003 00:52:42 +0000 (00:52 +0000)]
Doxygen janitor and some doc typo fixes.
Martin Pool [Tue, 18 Feb 2003 00:41:13 +0000 (00:41 +0000)]
Doxygen janitor. No other changes.
Andrew Bartlett [Tue, 18 Feb 2003 00:36:37 +0000 (00:36 +0000)]
The cli_send_tconX code already determines to send \\server\share to port 139
and share to 445, so doing this only confuses the issue (sending
\\server\\server\share to 139) and makes debugging specific error codes more
difficult.
Andrew Bartlett
Martin Pool [Mon, 17 Feb 2003 23:49:01 +0000 (23:49 +0000)]
Update config.guess, config.sub to the versions from the GNU autotools
2003-01-10 release. This adds or improves detection for many host
platforms.
Martin Pool [Mon, 17 Feb 2003 23:33:55 +0000 (23:33 +0000)]
Add comment explaining the -DDEVELOPER safe_strcpy overflow hack.
Jeremy Allison [Mon, 17 Feb 2003 21:19:09 +0000 (21:19 +0000)]
Correctly check for inet_addr fail. Patch from gregor.7@osu.edu.
Jeremy.
Volker Lendecke [Mon, 17 Feb 2003 21:12:21 +0000 (21:12 +0000)]
Dummy commit, I can't get through to samba-cvs@samba.org. It can't really
remember under what mail address I have to post.
My last commit to this file made it compile again, my fingers were a bit
too fast to really type this message.
Sorry for this confusion,
Volker
Volker Lendecke [Mon, 17 Feb 2003 21:04:09 +0000 (21:04 +0000)]
cmd_srvsvc.c
Andrew Bartlett [Mon, 17 Feb 2003 12:33:24 +0000 (12:33 +0000)]
This is a very nice way to detect pstrcpy() into a malloc()ed string, but
it really is a developer hack...
Andrew Bartlett
Andrew Bartlett [Mon, 17 Feb 2003 12:27:34 +0000 (12:27 +0000)]
This patch fixes one of my longest-standing pet hates with Samba :-).
When we look see if a user is in a list, and we try to 'expand' an @group, we
should lookup the user's own list of groups, rather than looking for all the
members of a group.
I'm sure this will fix some nasty performance issues, particularly on large
domains etc. In particular, this avoids contacting winbind at all, if the
group is not a winbind group.
(This caused a deadlock on my winbind-on-PDC setup).
The groups list always includes the user's primary group, as per the
getgrouplist manpage, and my recent changes to our implementation.
Andrew Bartlett
Andrew Bartlett [Mon, 17 Feb 2003 12:20:20 +0000 (12:20 +0000)]
Don't leak a session_key worth of memory at the end of the NTLMSSP auth.
Andrew Bartlett [Mon, 17 Feb 2003 12:19:12 +0000 (12:19 +0000)]
Set the length back to zero when we free the data_blob.
Andrew Bartlett [Mon, 17 Feb 2003 12:04:09 +0000 (12:04 +0000)]
Try to make our getgrouplist replacement better match the 'real' implemenations.
In particular, make sure we include the primary gid in the list.
Andrew Bartlett
Martin Pool [Mon, 17 Feb 2003 06:54:43 +0000 (06:54 +0000)]
Typo: /mized/mixed/
Martin Pool [Mon, 17 Feb 2003 06:28:58 +0000 (06:28 +0000)]
Don't pstrcpy into an fstring. (Harmless in this case since it comes
from an environment variable.)
Martin Pool [Mon, 17 Feb 2003 05:42:36 +0000 (05:42 +0000)]
Start reworking rpcclient to use popt rather than next_token to parse
command lines. This makes the code much simpler and also stops
trivial syntax errors from causing a crash.
Also fix support for semicolon-separated commands in -c, which is
promised by the manual but apparently never working due to an
off-by-one error.
Tim Potter [Mon, 17 Feb 2003 04:43:09 +0000 (04:43 +0000)]
Added SRVSVC pipe support. I've started implementing NetServerGetInfo()
Tim Potter [Mon, 17 Feb 2003 04:41:08 +0000 (04:41 +0000)]
Add KRBCLIENT_OBJ to PYTHON_OBJ list.
Tim Potter [Mon, 17 Feb 2003 04:35:32 +0000 (04:35 +0000)]
Return a WERROR instead of a NTSTATUS like the rest of the srvsvc
rpc calls.
Andrew Bartlett [Mon, 17 Feb 2003 00:58:47 +0000 (00:58 +0000)]
If we didn't make the server_info correctly, then don't segfault trying to
set the 'guest' bit.
Andrew Bartlett
Andrew Bartlett [Mon, 17 Feb 2003 00:07:38 +0000 (00:07 +0000)]
People were being tripped up by the fact that we havn't updated acconfig.h
as we don't need it for autoconf 2.53. Remove it from CVS, and assert the
newer autotools in configure.in
Andrew Bartlett
Andrew Bartlett [Sun, 16 Feb 2003 22:10:48 +0000 (22:10 +0000)]
Add the 'session key' output of the NTLMSSP exchange to the cli struct, so
it can be used for 'net rpc join'.
Also fix a bug in our server-side NTLMSSP code - a client without any domain
trust links to us may calculate the NTLMv2 response with "" as the domain.
Andrew Bartlett
Richard Sharpe [Sun, 16 Feb 2003 17:16:06 +0000 (17:16 +0000)]
Recover much of my changes to editreg.c. Add some const and start coding
the regedit file parser etc.
Gerald Carter [Sat, 15 Feb 2003 23:36:18 +0000 (23:36 +0000)]
* set PRINTER_ATTRIBUTE_RAW_ONLY; CR 1736
* never save a pointer to an automatic variable (they go away)
implement a deep copy for SPOOLSS_NOTIFY_MSG to correct
messages being sent that have junk for strings;
fix in response to changes for CR 1504
Alexander Bokovoy [Sat, 15 Feb 2003 22:51:15 +0000 (22:51 +0000)]
Third-party configuration scripts may produce undesirable additions to CFLAGS/CPPFLAGS
and LIBS/LDFALGS. In particular, they often don't check where the appropriate libraries
were installed and pass -I/usr/include and -L/usr/lib as part of CFLAGS/LDFLAGS.
While the latter isn't dangerous, passing system include directory through -I lead
to change of its status in CPP from system to user-defined in many cases.
This patch cleans up CFLAGS/CPPFLAGS from errorenous -I/usr/include and LIBS/LDFLAGS
from -L/usr/lib. This is done as two m4 macros which are called before AC_OUTPUT.
Andrew Bartlett [Sat, 15 Feb 2003 21:41:01 +0000 (21:41 +0000)]
Don't return NULL pointers for now.
We should look into how to deal with NULL v "" strings, and the NTLMSSP code
underneath properly at some stage.
Andrew Bartlett
Simo Sorce [Sat, 15 Feb 2003 21:36:28 +0000 (21:36 +0000)]
fix dumb perror used without errno beeing set.
thanks to RedHat developers for the report
Jelmer Vernooij [Sat, 15 Feb 2003 16:35:20 +0000 (16:35 +0000)]
Some small updates
Alexander Bokovoy [Sat, 15 Feb 2003 15:50:24 +0000 (15:50 +0000)]
When checking for tgetent, include libtinfo from recent Ncurses as well
Alexander Bokovoy [Sat, 15 Feb 2003 15:47:32 +0000 (15:47 +0000)]
Add support for krb5-config from recent MIT and Heimdal. And fallback to traditional guessing only if krb5-config was not found.
Jelmer Vernooij [Sat, 15 Feb 2003 14:44:25 +0000 (14:44 +0000)]
Add draft of universal passdb document that combines ENCRYPTION.sgml,
Samba-LDAP-HOWTO.sgml, pdb_mysql.sgml and pdb_xml.sgml
Jelmer Vernooij [Sat, 15 Feb 2003 14:17:03 +0000 (14:17 +0000)]
Remove obsolete textdocs - they have been migrated to SGML
Jelmer Vernooij [Sat, 15 Feb 2003 14:13:55 +0000 (14:13 +0000)]
Fix *a lot* of syntax errors
Andrew Bartlett [Sat, 15 Feb 2003 12:20:22 +0000 (12:20 +0000)]
Move our NTLMSSP client code into ntlmssp.c. The intention is to provide a
relitivly useful external lib from this code, and to remove the dupicate
NTLMSSP code elsewhere in samba (RPC pipes, LDAP client).
The code I've replaced this with in cliconnect.c is relitivly ugly, and
I hope to replace it with a more general SPENGO layer at some later date.
Andrew Bartlett
Jelmer Vernooij [Sat, 15 Feb 2003 02:04:41 +0000 (02:04 +0000)]
Use more portable @SHLIBEXT@ instead of .so
Jelmer Vernooij [Sat, 15 Feb 2003 02:02:51 +0000 (02:02 +0000)]
Remove obsolete file lib/netatalk.c - We have a VFS module now
Jeremy Allison [Sat, 15 Feb 2003 01:34:34 +0000 (01:34 +0000)]
Patch based on work by Michael Steffens <michael_steffens@hp.com> to wrap
all cm_get_XX calls and their subsequent requests in a retry loop in case
we've temporarily lost connection to the DC. Makes winbindd more reliable.
Jeremy.
Jelmer Vernooij [Sat, 15 Feb 2003 01:08:08 +0000 (01:08 +0000)]
Add reference to example mysql.dump file
Andrew Bartlett [Sat, 15 Feb 2003 00:29:21 +0000 (00:29 +0000)]
Antti Andreimann <Antti.Andreimann@mail.ee> has done some changes to enable
users w/o full administrative access on computer accounts to join a
computer into AD domain.
The patch and detailed changelog is available at:
http://www.itcollege.ee/~aandreim/samba
This is a list of changes in general:
1. When creating machine account do not fail if SD cannot be changed.
setting SD is not mandatory and join will work perfectly without it.
2. Implement KPASSWD CHANGEPW protocol for changing trust password so
machine account does not need to have reset password right for itself.
3. Command line utilities no longer interfere with user's existing
kerberos ticket cache.
4. Command line utilities can do kerberos authentication even if
username is specified (-U). Initial TGT will be requested in this case.
I've modified the patch to share the kinit code, rather than copying it,
and updated it to current CVS. The other change included in the original patch
(local realms) has been left out for now.
Andrew Bartlett
Andrew Bartlett [Sat, 15 Feb 2003 00:10:09 +0000 (00:10 +0000)]
Move our NTLMSSP code into easily seperated peices, not relying on the whole
of libsmb.
Andrew Bartlett
Andrew Bartlett [Fri, 14 Feb 2003 23:34:32 +0000 (23:34 +0000)]
Oops, forgot the header file changes.
Andrew Bartlett [Fri, 14 Feb 2003 23:13:05 +0000 (23:13 +0000)]
NTLMSSP parinoia - we really don't want to run over the end of our blob,
and make sure we can never get an 'authenticate' packet without a challenge.
Andrew Bartlett
Jeremy Allison [Fri, 14 Feb 2003 23:04:03 +0000 (23:04 +0000)]
Ensure that only parse_prs.c access internal members of the prs_struct.
Needed to move to disk based i/o later.
Jeremy.
Gerald Carter [Fri, 14 Feb 2003 22:24:49 +0000 (22:24 +0000)]
off by one bug in string length; CR 1159
Jim McDonough [Fri, 14 Feb 2003 20:10:43 +0000 (20:10 +0000)]
Put dynrpc modules as part of make all, when specified in configure.
Andrew Bartlett [Fri, 14 Feb 2003 10:47:07 +0000 (10:47 +0000)]
Further extract our NTLMv2 code into smbencrypt.c, prior to merge into our
NTLMSSP client code.
Andrew Bartlett
Martin Pool [Fri, 14 Feb 2003 06:34:59 +0000 (06:34 +0000)]
Doc
Tim Potter [Fri, 14 Feb 2003 05:07:05 +0000 (05:07 +0000)]
Simplify some return values in gencache functions:
- return ret == 0 ? True : False;
+ return ret == 0;
and
- return tdb_close(cache) ? False : True;
+ return tdb_close(cache) != -1;
Tim Potter [Fri, 14 Feb 2003 00:23:31 +0000 (00:23 +0000)]
Fix for trusted domains scan not working inspired by Ken Cross.
(Sorry - I should have checked this in yesterday but forgot)
Rafal Szczesniak [Thu, 13 Feb 2003 21:40:35 +0000 (21:40 +0000)]
A few typo fixes Andrew eventually let off to me.
Rafal
Jeremy Allison [Thu, 13 Feb 2003 19:42:50 +0000 (19:42 +0000)]
Removed unused variable.
Jeremy.
Alexander Bokovoy [Thu, 13 Feb 2003 16:29:12 +0000 (16:29 +0000)]
Fix typo in WIFSIGNALED (as per Waider's report)
Jeremy Allison [Thu, 13 Feb 2003 06:52:45 +0000 (06:52 +0000)]
Merge JohnR's patch.
Removed extra copy of server name in the printername field (it was
mangling the the name to be \\server\\\server\printer ... yes, there
were 3 backslashes) reported by get & enum jobs level 2.
Jeremy.
Martin Pool [Thu, 13 Feb 2003 04:46:55 +0000 (04:46 +0000)]
Add FIXME about checking exit code for popen'd commands.
Fix typo.
Martin Pool [Thu, 13 Feb 2003 04:45:40 +0000 (04:45 +0000)]
waitstatus audit: Correctly handle case where smbmnt is killed by a
signal. Previously this was incorrectly treated as success.
Martin Pool [Thu, 13 Feb 2003 01:05:56 +0000 (01:05 +0000)]
Doc
Set HTML output directory
Martin Pool [Thu, 13 Feb 2003 00:37:35 +0000 (00:37 +0000)]
Update towards automatic building on dp.samba.org:
Remove features not supported by Doxygen 1.2.14 on RH7.3.
Remove dependence on dot tool, which is apparently not in Redhat, and
doesn't produce very interesting results for C code anyhow.
Make Doxygen --quiet to support running from cron.
Remove references to files which are gone from Samba
(CodingSuggestions).
Put HTML output in the right directory.
Jeremy Allison [Wed, 12 Feb 2003 23:51:05 +0000 (23:51 +0000)]
Added code based on Michael Steffens <michael.steffens@hp.com> uid/gid
caching code. Reduces load on winbindd. Probably should be moved to
use gencache at some future date.
Jeremy.
Jeremy Allison [Wed, 12 Feb 2003 20:38:02 +0000 (20:38 +0000)]
Fixes for HPUX only having limited POSIX lock range from Michael Steffens <michael.steffens@hp.com>
Jeremy.
Gerald Carter [Wed, 12 Feb 2003 16:43:47 +0000 (16:43 +0000)]
adding more descriptions for nt status codes
Andrew Bartlett [Wed, 12 Feb 2003 11:17:35 +0000 (11:17 +0000)]
Match Samba 2.2 by chosing the correct desired access, and getting cupsaddsmb
back working again.
Andrew Bartlett
Andrew Tridgell [Wed, 12 Feb 2003 09:14:35 +0000 (09:14 +0000)]
initial server side privileges implementation, using a tdb. This needs to be hooked into pdb, and we need some access control on changing privileges. That's next
Andrew Bartlett [Wed, 12 Feb 2003 06:38:18 +0000 (06:38 +0000)]
Prevent NULL-pointer induced segfaults.
Is tdb_pack in appliance_head different for some reason?
Andrew Bartlett
Jeremy Allison [Wed, 12 Feb 2003 01:12:33 +0000 (01:12 +0000)]
Correctly return access denied on share mode deny when we can't open the
file. This is a regression that was damaged by other code.
Jeremy.
Andrew Tridgell [Wed, 12 Feb 2003 00:56:14 +0000 (00:56 +0000)]
setup the %U substitution in winbindd for the homedir template
Andrew Tridgell [Wed, 12 Feb 2003 00:41:35 +0000 (00:41 +0000)]
add a note about relative opens with blank paths - its a re-open!
(not implemented yet)
Andrew Tridgell [Wed, 12 Feb 2003 00:40:41 +0000 (00:40 +0000)]
add a note about a better method for finding netbios name of workgroup
(not implemented yet)
Andrew Tridgell [Wed, 12 Feb 2003 00:39:36 +0000 (00:39 +0000)]
pull_ucs2_talloc() should pull to a char**, not a void**
Andrew Tridgell [Tue, 11 Feb 2003 22:53:57 +0000 (22:53 +0000)]
removed a duplicate copy of smb_io_sid_array()
Andrew Tridgell [Tue, 11 Feb 2003 21:55:48 +0000 (21:55 +0000)]
added server stubs for lsa_enum_acct_with_right
Andrew Bartlett [Tue, 11 Feb 2003 21:54:36 +0000 (21:54 +0000)]
Patch from Anthony Liguori <aliguor@us.ibm.com> to remove scandir() portability
madness.
Andrew Bartlett
Jim McDonough [Tue, 11 Feb 2003 19:57:17 +0000 (19:57 +0000)]
remove trailing 'a' from VFS_MODULES targets...fix build
Jeremy Allison [Tue, 11 Feb 2003 02:29:04 +0000 (02:29 +0000)]
Fixup delete on close torture.
Jeremy.
Jeremy Allison [Tue, 11 Feb 2003 02:24:45 +0000 (02:24 +0000)]
Fix delete on close semantics to match W2K. I (think:-) I understand it now :-).
Thanks to Nir Livni <nirl@cyber-ark.com> for giving me the test case to
track it down.
Jeremy.
Shirish Kalele [Tue, 11 Feb 2003 01:45:15 +0000 (01:45 +0000)]
Fix the msdfs proxy handling code in dfsenum to return the cumulative number of
dfs links encountered. Previously the number was being mistakenly reset to 1.
Thanks to Guenther Deschner <gd@suse.de> for pointing this out and a fix.
[Check into HEAD]
Gerald Carter [Mon, 10 Feb 2003 17:30:20 +0000 (17:30 +0000)]
autogen - cope with autoconf-2.53/2.13 systems (like RH 7.3)
findsmb - use @PERL@
Richard Sharpe [Mon, 10 Feb 2003 16:42:24 +0000 (16:42 +0000)]
Fix a mistake spotted by Metze
Andrew Bartlett [Mon, 10 Feb 2003 12:22:57 +0000 (12:22 +0000)]
Clean up our NTLMv2 code by moving the grunt work into a helper function.
Andrew Bartlett
Andrew Tridgell [Mon, 10 Feb 2003 11:31:23 +0000 (11:31 +0000)]
added the 'lsaenumacctwithright' command to rpcclient. This allows you
to lookup what SIDs have a particular privilege (that is how
privileges are stored).