ira/wip.git
10 years agos4:winbind/wb_cmd_getgroups.c - fix up warnings
Matthias Dieter Wallnöfer [Tue, 9 Mar 2010 16:52:10 +0000 (17:52 +0100)]
s4:winbind/wb_cmd_getgroups.c - fix up warnings

Also fix some indentations.

10 years agos4:unittest Fix unittest to reflect that wbinfo -r no longer fail
Matthieu Patou [Tue, 9 Mar 2010 12:35:54 +0000 (15:35 +0300)]
s4:unittest Fix unittest to reflect that wbinfo -r no longer fail

Signed-off-by: Matthias Dieter Wallnöfer <mwallnoefer@yahoo.de>
10 years agos4:winbind: stub implementation of WINBINDD_PAM_LOGOFF
Matthieu Patou [Wed, 3 Mar 2010 20:29:15 +0000 (23:29 +0300)]
s4:winbind: stub implementation of WINBINDD_PAM_LOGOFF

Signed-off-by: Matthias Dieter Wallnöfer <mwallnoefer@yahoo.de>
10 years agos4:winbind: Fix a misplaced returned info
Matthieu Patou [Wed, 3 Mar 2010 20:29:32 +0000 (23:29 +0300)]
s4:winbind: Fix a misplaced returned info

libwbclient expect to have in auth.exra_data the INFO3_TXT and in auth.unix_username the username

Signed-off-by: Matthias Dieter Wallnöfer <mwallnoefer@yahoo.de>
10 years agos4:winbind Implement logic for getgroups to work
Matthieu Patou [Thu, 4 Mar 2010 00:05:06 +0000 (03:05 +0300)]
s4:winbind Implement logic for getgroups to work

This function is called by the system everytime we do a id user or when we do wbinfo -r

Signed-off-by: Matthias Dieter Wallnöfer <mwallnoefer@yahoo.de>
10 years agos4:winbind: implement calls for allowing getent groups
Matthieu Patou [Wed, 3 Mar 2010 23:46:36 +0000 (02:46 +0300)]
s4:winbind: implement calls for allowing getent groups

This is to say getgrent and setgrent, and the associated technical objects (states, build directives,...) needed.

Signed-off-by: Matthias Dieter Wallnöfer <mwallnoefer@yahoo.de>
10 years agos4:torture/rpc/netlogon.c - "LogonGetDomainInfo" test - make it compatible against...
Matthias Dieter Wallnöfer [Wed, 17 Feb 2010 08:51:41 +0000 (09:51 +0100)]
s4:torture/rpc/netlogon.c - "LogonGetDomainInfo" test - make it compatible against Windows Server 2008

This is a reworked version of the mentioned test which passes against Windows
Server 2008. The previous version, also mainly written by me passed only against
Windows Server <= 2003.

10 years agos4:netlogon RPC - "LogonGetDomainInfo" - make the call compatible with >= Windows...
Matthias Dieter Wallnöfer [Fri, 5 Mar 2010 10:09:57 +0000 (11:09 +0100)]
s4:netlogon RPC - "LogonGetDomainInfo" - make the call compatible with >= Windows 2008

Add more security checks and other corrections to imitate Windows Server >= 2008.

10 years agolibcli/auth/schannel_state_tdb.c - fix an obviously wrong error handling
Matthias Dieter Wallnöfer [Tue, 9 Mar 2010 16:12:02 +0000 (17:12 +0100)]
libcli/auth/schannel_state_tdb.c - fix an obviously wrong error handling

10 years agos4-smbtorture: fix uninitialized variable in winreg QueryValue call.
Günther Deschner [Tue, 9 Mar 2010 15:10:40 +0000 (16:10 +0100)]
s4-smbtorture: fix uninitialized variable in winreg QueryValue call.

Guenther

10 years agos3: Fix a typo. Thanks to Christian Ambach for pointing me at it :-)
Volker Lendecke [Tue, 9 Mar 2010 14:36:08 +0000 (15:36 +0100)]
s3: Fix a typo. Thanks to Christian Ambach for pointing me at it :-)

10 years agoA helper function to get the Infrastructure DN.
Nadezhda Ivanova [Tue, 9 Mar 2010 12:56:46 +0000 (14:56 +0200)]
A helper function to get the Infrastructure DN.

10 years agoFixed a bug in acl tests - python error when we create user/group/ou with a descriptor.
Nadezhda Ivanova [Tue, 9 Mar 2010 11:53:41 +0000 (13:53 +0200)]
Fixed a bug in acl tests - python error when we create user/group/ou with a descriptor.

10 years agoAdded a check for permissions to modify the RDN attribute on rename.
Nadezhda Ivanova [Sun, 7 Mar 2010 19:42:53 +0000 (21:42 +0200)]
Added a check for permissions to modify the RDN attribute on rename.

Necessary because rdn module will be moved lower than acl in the stack.

10 years agos4:dsdb/dns: change callers of samba_runcmd()
Stefan Metzmacher [Thu, 25 Feb 2010 15:01:15 +0000 (16:01 +0100)]
s4:dsdb/dns: change callers of samba_runcmd()

metze

10 years agolib/util: change samba_runcmd() to use tevent_req _send/_recv
Stefan Metzmacher [Wed, 24 Feb 2010 11:43:45 +0000 (12:43 +0100)]
lib/util: change samba_runcmd() to use tevent_req _send/_recv

metze

10 years agoRevert "Fix bug #7067 - Linux asynchronous IO (aio) can cause smbd to fail to respond...
Karolin Seeger [Mon, 8 Mar 2010 19:34:39 +0000 (20:34 +0100)]
Revert "Fix bug #7067 - Linux asynchronous IO (aio) can cause smbd to fail to respond to a read or write."

This reverts commit a6ae7a552f851a399991262377cc0e062e40ac20.

This fixes bug #7222 (All users have full rigths on all shares) (CVE-2010-0728).
(cherry picked from commit 1c9494c76cc9686c61e0966f38528d3318f3176f)

10 years agos3:build: Fix automatic building of vfs_tsmsm if gpfs and dmapi are present.
Michael Adam [Mon, 8 Mar 2010 21:32:41 +0000 (22:32 +0100)]
s3:build: Fix automatic building of vfs_tsmsm if gpfs and dmapi are present.

Michael

10 years agos3:release-scripts: fix create-tarball to treat vendor patch level correctly
Michael Adam [Mon, 8 Mar 2010 22:37:21 +0000 (23:37 +0100)]
s3:release-scripts: fix create-tarball to treat vendor patch level correctly

10 years agosamba: remove Linux cifs-utils files from samba master branch
Jeff Layton [Mon, 8 Mar 2010 20:05:05 +0000 (15:05 -0500)]
samba: remove Linux cifs-utils files from samba master branch

This patch removes all of the files from the samba tree that should now
be provided by the cifs-utils package. It also drops a
"README.cifs-utils" into the topdir with a URL to the main cifs-utils
webpage. This is for people who don't want the lists and might be taken
by surprise by the change. That's optional, but I think it's a good idea
for a least a release or two.

Signed-off-by: Jeff Layton <jlayton@samba.org>
10 years agos4:"dns_update_list" file: install it properly into the private directory
Matthias Dieter Wallnöfer [Mon, 8 Mar 2010 19:36:16 +0000 (20:36 +0100)]
s4:"dns_update_list" file: install it properly into the private directory

This is what the "samba_dnsupdate" script requests (line 220).

10 years agoRevert "s4:script/installmisc.sh - install "dns_update_list" to target setup folder"
Matthias Dieter Wallnöfer [Mon, 8 Mar 2010 19:30:06 +0000 (20:30 +0100)]
Revert "s4:script/installmisc.sh - install "dns_update_list" to target setup folder"

This reverts commit b49276e291274652d46eed39249c07531e32b591.

10 years agoLDB:asq module - change counters to "unsigned" where appropriate
Matthias Dieter Wallnöfer [Mon, 8 Mar 2010 17:01:32 +0000 (18:01 +0100)]
LDB:asq module - change counters to "unsigned" where appropriate

10 years agoLDB:sort module - change counters to "unsigned" where appropriate
Matthias Dieter Wallnöfer [Mon, 8 Mar 2010 17:01:32 +0000 (18:01 +0100)]
LDB:sort module - change counters to "unsigned" where appropriate

10 years agoLDB:rdn name module - change counters to "unsigned" where appropriate
Matthias Dieter Wallnöfer [Mon, 8 Mar 2010 17:01:32 +0000 (18:01 +0100)]
LDB:rdn name module - change counters to "unsigned" where appropriate

10 years agoLDB:paged searches module - change counters to "unsigned" where appropriate
Matthias Dieter Wallnöfer [Mon, 8 Mar 2010 17:01:32 +0000 (18:01 +0100)]
LDB:paged searches module - change counters to "unsigned" where appropriate

10 years agoLDB:paged results module - change counters to "unsigned" where appropriate
Matthias Dieter Wallnöfer [Mon, 8 Mar 2010 17:01:32 +0000 (18:01 +0100)]
LDB:paged results module - change counters to "unsigned" where appropriate

10 years agos3: add missing Makefile.in changes for vfs_crossrename
Björn Jacke [Mon, 8 Mar 2010 16:53:18 +0000 (17:53 +0100)]
s3: add missing Makefile.in changes for vfs_crossrename

10 years agos3: add man page for vfs_crossrename
Björn Jacke [Mon, 8 Mar 2010 11:38:38 +0000 (12:38 +0100)]
s3: add man page for vfs_crossrename

10 years agos3: add vfs_crossrename
Björn Jacke [Mon, 8 Mar 2010 11:59:40 +0000 (12:59 +0100)]
s3: add vfs_crossrename

this module adds optional server-side support for limited rename operations
beyond filesystem boundaries, which was the previously the default.

10 years agos3: remove cross-device rename support from vfs_default
Björn Jacke [Mon, 8 Mar 2010 11:52:13 +0000 (12:52 +0100)]
s3: remove cross-device rename support from vfs_default

cross-device rename support has some major limitations:

- on huge files clients will timeout or hang
- ACLs and EA information is not retained

Usually a client will have to handle this. A Windows Server with a reparse
point will also just return NT_STATUS_NOT_SAME_DEVICE. We will now by default
do the same.

I will add a vfs module which will restore the old cross-device renames.

10 years agosamba: remove cifs-utils tools from build systems
Jeff Layton [Mon, 8 Mar 2010 14:06:40 +0000 (09:06 -0500)]
samba: remove cifs-utils tools from build systems

Now that cifs-utils are their own project, we need to go ahead and pull
them out of the samba tree. This patch represents the first step toward
that end.

Remove the cifs-utilities from the source3 and source4 builds. Please
pay particular attention to the source4 piece. I'm not at all familiar
with the build system there, and would appreciate someone sanity
checking my changes.

It also adds a small README.cifs-utils file in the topdir. This is
optional, but I think it's a good idea to carry this for a release or
two.

Once this patch looks ok, I'll plan to do another patch to actually
remove the client dir and the relevant docs-xml files from the tree
altogether.

Signed-off-by: Jeff Layton <jlayton@redhat.com>
10 years agoLDB:common - Change counters to "unsigned" where appropriate
Matthias Dieter Wallnöfer [Fri, 6 Nov 2009 17:35:17 +0000 (18:35 +0100)]
LDB:common - Change counters to "unsigned" where appropriate

To count LDB objects use variables of type "unsigned (int)" or "long long int"
on binary or downto searches.

To count characters in strings use "size_t".

To calculate differences between pointers use "ptrdiff_t".

10 years agos4:LDB TDB index code - reintroduce accidentally removed code part
Matthias Dieter Wallnöfer [Mon, 8 Mar 2010 10:43:40 +0000 (11:43 +0100)]
s4:LDB TDB index code - reintroduce accidentally removed code part

This was removed by 95d726f3018ef5d249f89d56bde24b7ee0c24ecf. Sorry.

10 years agos4:ldb_ldap.c - fix indentation
Matthias Dieter Wallnöfer [Mon, 8 Mar 2010 08:58:28 +0000 (09:58 +0100)]
s4:ldb_ldap.c - fix indentation

10 years agoLDB:TDB backend - change counter variables to "unsigned" where appropriate
Matthias Dieter Wallnöfer [Fri, 6 Nov 2009 17:35:17 +0000 (18:35 +0100)]
LDB:TDB backend - change counter variables to "unsigned" where appropriate

10 years agoLDB:SQLITE3 backend - change counter variables to "unsigned" where appropriate
Matthias Dieter Wallnöfer [Fri, 6 Nov 2009 17:35:17 +0000 (18:35 +0100)]
LDB:SQLITE3 backend - change counter variables to "unsigned" where appropriate

10 years agoLDB:LDAP backend - change a counter variable to "unsigned"
Matthias Dieter Wallnöfer [Fri, 6 Nov 2009 17:35:17 +0000 (18:35 +0100)]
LDB:LDAP backend - change a counter variable to "unsigned"

10 years agoLDB:map - make LDB "signed-safe" on counter variables where appropriate
Matthias Dieter Wallnöfer [Fri, 6 Nov 2009 17:35:17 +0000 (18:35 +0100)]
LDB:map - make LDB "signed-safe" on counter variables where appropriate

10 years agos4:ldif_handlers - Change "unsigned int" to "uint32_t" which fits better here
Matthias Dieter Wallnöfer [Mon, 8 Mar 2010 07:02:32 +0000 (08:02 +0100)]
s4:ldif_handlers - Change "unsigned int" to "uint32_t" which fits better here

10 years agos4-gensec: Fixed wrong usage of error_string.
Andreas Schneider [Wed, 3 Mar 2010 14:15:03 +0000 (15:15 +0100)]
s4-gensec: Fixed wrong usage of error_string.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
10 years agos4:extended_dn_out LDB module - change counter variables to "unsigned" where appropriate
Matthias Dieter Wallnöfer [Sun, 7 Mar 2010 18:03:21 +0000 (19:03 +0100)]
s4:extended_dn_out LDB module - change counter variables to "unsigned" where appropriate

10 years agos4:repl_meta_data LDB module - change counter variables to "unsigned" where appropriate
Matthias Dieter Wallnöfer [Sun, 7 Mar 2010 18:02:47 +0000 (19:02 +0100)]
s4:repl_meta_data LDB module - change counter variables to "unsigned" where appropriate

I used "unsigned int" counters where we count LDB objects (LDB specification
prescribes to use "unsigned" index variables).
But on DSDB replication object counters I used "uint32_t" typed variables as it
is suggested.
If a counter variable counts both types of objects I used "unsigned int" since
size(unsigned int) >= size(uint32_t), but on most platforms equal.

10 years agos4:local_password LDB module - change counter variables to "unsigned" where appropriate
Matthias Dieter Wallnöfer [Sun, 7 Mar 2010 18:04:11 +0000 (19:04 +0100)]
s4:local_password LDB module - change counter variables to "unsigned" where appropriate

10 years agos4:ranged_results LDB module - change counter variables to "unsigned" where appropriate
Matthias Dieter Wallnöfer [Sun, 7 Mar 2010 18:18:39 +0000 (19:18 +0100)]
s4:ranged_results LDB module - change counter variables to "unsigned" where appropriate

10 years agos4:objectguid LDB module - change counter variables to "unsigned" where appropriate
Matthias Dieter Wallnöfer [Sun, 7 Mar 2010 18:18:02 +0000 (19:18 +0100)]
s4:objectguid LDB module - change counter variables to "unsigned" where appropriate

10 years agos4:objectclass LDB module - change counter variabls to "unsigned" where appropriate
Matthias Dieter Wallnöfer [Sun, 7 Mar 2010 18:17:28 +0000 (19:17 +0100)]
s4:objectclass LDB module - change counter variabls to "unsigned" where appropriate

10 years agos4:anr LDB module - change counter variable to "unsigned"
Matthias Dieter Wallnöfer [Sun, 7 Mar 2010 18:16:55 +0000 (19:16 +0100)]
s4:anr LDB module - change counter variable to "unsigned"

10 years agos4:acl LDB module - change counter variable to "unsigned"
Matthias Dieter Wallnöfer [Sun, 7 Mar 2010 18:16:24 +0000 (19:16 +0100)]
s4:acl LDB module - change counter variable to "unsigned"

10 years agos4:linked_attributes LDB module - change counter variables to "unsigned" where approp...
Matthias Dieter Wallnöfer [Sun, 7 Mar 2010 18:15:37 +0000 (19:15 +0100)]
s4:linked_attributes LDB module - change counter variables to "unsigned" where appropriate

10 years agos4:kludge_acl LDB module - change counter variables to "unsigned" where appropriate
Matthias Dieter Wallnöfer [Sun, 7 Mar 2010 18:14:16 +0000 (19:14 +0100)]
s4:kludge_acl LDB module - change counter variables to "unsigned" where appropriate

10 years agos4:proxy LDB module - Change counter variables to "unsigned" where appropriate
Matthias Dieter Wallnöfer [Sun, 7 Mar 2010 18:13:11 +0000 (19:13 +0100)]
s4:proxy LDB module - Change counter variables to "unsigned" where appropriate

Use "size_t" when counting string index positions.

10 years agos4:schema_data LDB module - change counter variables to "unsigned" where appropriate
Matthias Dieter Wallnöfer [Sun, 7 Mar 2010 18:12:30 +0000 (19:12 +0100)]
s4:schema_data LDB module - change counter variables to "unsigned" where appropriate

10 years agos4:resolve_oids LDB module - change counter variables to "unsigned" where appropriate
Matthias Dieter Wallnöfer [Sun, 7 Mar 2010 18:11:48 +0000 (19:11 +0100)]
s4:resolve_oids LDB module - change counter variables to "unsigned" where appropriate

10 years agos4:rootdse LDB module - change counter variables to "unsigned" where appropriate
Matthias Dieter Wallnöfer [Sun, 7 Mar 2010 18:11:03 +0000 (19:11 +0100)]
s4:rootdse LDB module - change counter variables to "unsigned" where appropriate

10 years agos4:partition LDB module - change counter variables to "unsigned" where appropriate
Matthias Dieter Wallnöfer [Sun, 7 Mar 2010 18:10:00 +0000 (19:10 +0100)]
s4:partition LDB module - change counter variables to "unsigned" where appropriate

10 years agos4:schema - Change also here counters to "unsigned" where needed
Matthias Dieter Wallnöfer [Fri, 6 Nov 2009 19:14:41 +0000 (20:14 +0100)]
s4:schema - Change also here counters to "unsigned" where needed

Counters which are used in the way  "for (i = 0; array[i] != NULL; i++)" I
modified to "unsigned" since for sure we don't want to have negative array
indexes there.

10 years agos4:schema_syntax.c - Change also here counters to "unsigned" where needed
Matthias Dieter Wallnöfer [Fri, 6 Nov 2009 19:14:41 +0000 (20:14 +0100)]
s4:schema_syntax.c - Change also here counters to "unsigned" where needed

Counters which are used in the way  "for (i = 0; array[i] != NULL; i++)" I
modified to "unsigned" since for sure we don't want to have negative array
indexes there.

There were many counter variables typed "uint32_t". This isn't fully correct
since those count LDB objects. The amount is saved in a "num_*" variable which
is "unsigned" without a bitlength specification. Therefore change also these
counters to be plain "unsigned".

10 years agos4:libcli/wrepl: rewrite the low level request handling to use tevent_queue and tstre...
Stefan Metzmacher [Fri, 5 Mar 2010 17:30:10 +0000 (18:30 +0100)]
s4:libcli/wrepl: rewrite the low level request handling to use tevent_queue and tstream_context

metze

10 years agos4:wrepl_out_helpers: add a WREPLSRV_PUSH_NOTIFY_STAGE_WAIT_UPDATE stage
Stefan Metzmacher [Sun, 7 Mar 2010 15:59:12 +0000 (16:59 +0100)]
s4:wrepl_out_helpers: add a WREPLSRV_PUSH_NOTIFY_STAGE_WAIT_UPDATE stage

This makes the logic more consistent.

metze

10 years agos4:libcli/wrepl: add wrepl_socket_is_connected()
Stefan Metzmacher [Fri, 5 Mar 2010 15:03:23 +0000 (16:03 +0100)]
s4:libcli/wrepl: add wrepl_socket_is_connected()

metze

10 years agos4:libcli/wrepl: make struct wrepl_request private to winsrepl.c
Stefan Metzmacher [Fri, 5 Mar 2010 14:49:27 +0000 (15:49 +0100)]
s4:libcli/wrepl: make struct wrepl_request private to winsrepl.c

metze

10 years agos4:libcli/wrepl: implement wrepl_request_send as a tevent_req based wrapper
Stefan Metzmacher [Fri, 5 Mar 2010 14:22:10 +0000 (15:22 +0100)]
s4:libcli/wrepl: implement wrepl_request_send as a tevent_req based wrapper

metze

10 years agos4:libcli/wrepl: rename enum wrepl_request_state => enum wrepl_request_internal_state
Stefan Metzmacher [Fri, 5 Mar 2010 14:03:29 +0000 (15:03 +0100)]
s4:libcli/wrepl: rename enum wrepl_request_state => enum wrepl_request_internal_state

metze

10 years agos4:libcli/wrepl: move wrepl_request_send/recv => wrepl_request_internal_send/recv
Stefan Metzmacher [Fri, 5 Mar 2010 13:44:23 +0000 (14:44 +0100)]
s4:libcli/wrepl: move wrepl_request_send/recv => wrepl_request_internal_send/recv

metze

10 years agos4:torture/nbt: use wrepl_associate_stop() instead of build the request by hand
Stefan Metzmacher [Fri, 5 Mar 2010 13:34:36 +0000 (14:34 +0100)]
s4:torture/nbt: use wrepl_associate_stop() instead of build the request by hand

metze

10 years agos4:torture/nbt: use wrepl_request() instead of wrepl_request_send() followed by wrepl...
Stefan Metzmacher [Fri, 5 Mar 2010 13:29:36 +0000 (14:29 +0100)]
s4:torture/nbt: use wrepl_request() instead of wrepl_request_send() followed by wrepl_request_recv()

metze

10 years agos4:libcli/wrepl: add my copyright
Stefan Metzmacher [Fri, 5 Mar 2010 13:17:08 +0000 (14:17 +0100)]
s4:libcli/wrepl: add my copyright

metze

10 years agos4:lib/registry/ldb.c - fix trailing whitespaces
Matthias Dieter Wallnöfer [Sat, 6 Mar 2010 18:39:45 +0000 (19:39 +0100)]
s4:lib/registry/ldb.c - fix trailing whitespaces

10 years agos4:registry library - fix up "reg_ldb_set_value"
Matthias Dieter Wallnöfer [Sat, 6 Mar 2010 18:36:01 +0000 (19:36 +0100)]
s4:registry library - fix up "reg_ldb_set_value"

The previous logic was wrong since it tried to add empty data in some cases
which always ended in an error. This problem should be fixed with the new logic.

10 years agos4:registry library - make "reg_ldb_pack/unpack_value" more robust
Matthias Dieter Wallnöfer [Sat, 6 Mar 2010 18:20:48 +0000 (19:20 +0100)]
s4:registry library - make "reg_ldb_pack/unpack_value" more robust

This to prevent segmentation faults, wrong server inputs ecc.

10 years agos4:provision.reg - call us Windows 2008 from the current version point of view
Matthias Dieter Wallnöfer [Sat, 6 Mar 2010 17:51:41 +0000 (18:51 +0100)]
s4:provision.reg - call us Windows 2008 from the current version point of view

10 years agos4:libregistry - change counters to be "unsigned"
Matthias Dieter Wallnöfer [Sat, 7 Nov 2009 20:07:20 +0000 (21:07 +0100)]
s4:libregistry - change counters to be "unsigned"

Also the s4 registry library has to have "unsigned" counters like the Windows
one.

10 years agos3: Fix the build of net_afs.c with --fake-kaserver=yes, bug 7216
Volker Lendecke [Sat, 6 Mar 2010 11:57:35 +0000 (12:57 +0100)]
s3: Fix the build of net_afs.c with --fake-kaserver=yes, bug 7216

Thanks to Geza Gemes <geza@kzsdabas.hu> for filing this bug

10 years agoLDB:tools - change counters to be unsigned
Matthias Dieter Wallnöfer [Fri, 6 Nov 2009 17:35:17 +0000 (18:35 +0100)]
LDB:tools - change counters to be unsigned

In most cases we do count LDB objects which are enumerated within the "unsigned"
type. Therefore no need to use "signed" counters.

10 years agos4:lsa RPC - fix up "gendb_*" result codes
Matthias Dieter Wallnöfer [Sat, 6 Mar 2010 10:19:04 +0000 (11:19 +0100)]
s4:lsa RPC - fix up "gendb_*" result codes

Make the resultcodes consistent: that means:
result < 0  -> NT_STATUS_INTERNAL_DB_CORRUPTION since our DB had a critical
               error
result >= 0 -> depends on the function usage. I tried to let the logic always as
               it was before.

10 years agos4:lsa RPC - Change some counters to be "unsigned" where needed
Matthias Dieter Wallnöfer [Sat, 21 Nov 2009 18:26:02 +0000 (19:26 +0100)]
s4:lsa RPC - Change some counters to be "unsigned" where needed

The "count" size specifiers I typed "uint32_t" since they're often returned as
an "uint32_t" (consider the IDL file). LDB counters need to be "signed" if they
count till a limit of a "gendb*" call or "unsigned" if they count directly the
number of objects.

10 years agos4:samr RPC - Change some counters to be "unsigned" where needed
Matthias Dieter Wallnöfer [Sat, 21 Nov 2009 18:26:02 +0000 (19:26 +0100)]
s4:samr RPC - Change some counters to be "unsigned" where needed

The "count" size specifiers I typed "uint32_t" since they're often returned as
an "uint32_t" (consider the IDL file). LDB counters need to be "signed" if they
count till a limit of a "gendb*" call or "unsigned" if they count directly the
number of objects.

10 years agoFix for bug #7189 - Open txt files with notepad on samba shares creates problem.
Jeremy Allison [Fri, 5 Mar 2010 23:10:30 +0000 (15:10 -0800)]
Fix for bug #7189 - Open txt files with notepad on samba shares creates problem.

Ensure we don't use any of the create_options for Samba private
use. Add a new parameter to the VFS_CREATE call (private_flags)
which is only used internally. Renumber NTCREATEX_OPTIONS_PRIVATE_DENY_DOS
and NTCREATEX_OPTIONS_PRIVATE_DENY_FCB to match the S4 code).
Rev. the VFS interface to version 28.

Jeremy.

10 years agos4/tort: fix annoying "union spoolss_PrinterInfo" undefined warnings
Kamen Mazdrashki [Thu, 4 Mar 2010 16:00:15 +0000 (18:00 +0200)]
s4/tort: fix annoying "union spoolss_PrinterInfo" undefined warnings

Signed-off-by: Günther Deschner <gd@samba.org>
10 years agos3: re-run make samba3-idl.
Günther Deschner [Fri, 5 Mar 2010 21:03:26 +0000 (22:03 +0100)]
s3: re-run make samba3-idl.

Guenther

10 years agowinreg: fix winreg_QueryValue IDL.
Günther Deschner [Fri, 5 Mar 2010 20:56:50 +0000 (21:56 +0100)]
winreg: fix winreg_QueryValue IDL.

Note that before this change pidl generated code that just dereferenced size_is
and length_is values from unique pointers without checking whether these
pointers were actually NULL.

With this change, pidl now throws a warning like:

warning: Got pointer for `data_size', expected fully derefenced variable

which is not correct, probably because pidl does not evaluate the C expression.

Guenther

10 years agos3-rpcclient: Leave setprinterdata directly if not enough args were passed.
Andreas Schneider [Fri, 5 Mar 2010 10:15:35 +0000 (11:15 +0100)]
s3-rpcclient: Leave setprinterdata directly if not enough args were passed.

If we don't pass enough arguments we don't have to close the connection.

Signed-off-by: Günther Deschner <gd@samba.org>
10 years agos3-rpc_server: Document rpc_pipe_open_internal.
Andreas Schneider [Fri, 5 Mar 2010 14:54:31 +0000 (15:54 +0100)]
s3-rpc_server: Document rpc_pipe_open_internal.

Signed-off-by: Günther Deschner <gd@samba.org>
10 years agos4-smbtorture: fix RPC-SPOOLSS-WIN after PrinterData IDL changes.
Günther Deschner [Fri, 5 Mar 2010 19:32:16 +0000 (20:32 +0100)]
s4-smbtorture: fix RPC-SPOOLSS-WIN after PrinterData IDL changes.

Guenther

10 years agos4:drsuapi RPC - Change also here counters to "unsigned"
Matthias Dieter Wallnöfer [Sat, 21 Nov 2009 17:57:24 +0000 (18:57 +0100)]
s4:drsuapi RPC - Change also here counters to "unsigned"

No need to have "signed" counters at those places.

10 years agos4:dsdb/util - Change also here counters to "unsigned"
Matthias Dieter Wallnöfer [Fri, 6 Nov 2009 19:14:41 +0000 (20:14 +0100)]
s4:dsdb/util - Change also here counters to "unsigned"

No need to have "signed" counters at those places.

10 years agos4:repl - change also here the counter variables to "unsigned"
Matthias Dieter Wallnöfer [Fri, 6 Nov 2009 19:14:41 +0000 (20:14 +0100)]
s4:repl - change also here the counter variables to "unsigned"

I changed also some "uint32_t" to "unsigned" since the LDB interface doesn't
specify the bitlength of the unsigned type.

10 years agos4:wrepl_server - change also here the counter variables to "unsigned"
Matthias Dieter Wallnöfer [Sat, 7 Nov 2009 20:15:17 +0000 (21:15 +0100)]
s4:wrepl_server - change also here the counter variables to "unsigned"

I changed also some "uint32_t" to "unsigned" since the LDB interface doesn't
specify the bitlength of the unsigned type.

10 years agos3: Make "smbcontrol xx debuglevel" print the correct cluster pid
Volker Lendecke [Fri, 5 Mar 2010 16:06:08 +0000 (17:06 +0100)]
s3: Make "smbcontrol xx debuglevel" print the correct cluster pid

10 years agos4-spoolss: fix dcesrv_spoolss_GetPrinterData build.
Günther Deschner [Fri, 5 Mar 2010 15:34:17 +0000 (16:34 +0100)]
s4-spoolss: fix dcesrv_spoolss_GetPrinterData build.

really not my day today...

Guenther

10 years agos4-smbtorture: fix test_SetPrinterDataEx_matrix() call. sorry...
Günther Deschner [Fri, 5 Mar 2010 15:00:14 +0000 (16:00 +0100)]
s4-smbtorture: fix test_SetPrinterDataEx_matrix() call. sorry...

Guenther

10 years agos3: Remove the unused parameter "persistent" from fetch_locked_internal
Volker Lendecke [Fri, 5 Mar 2010 14:30:22 +0000 (15:30 +0100)]
s3: Remove the unused parameter "persistent" from fetch_locked_internal

10 years agos3: db->persistent==true was handled earlier, make this more obvious
Volker Lendecke [Fri, 5 Mar 2010 14:28:39 +0000 (15:28 +0100)]
s3: db->persistent==true was handled earlier, make this more obvious

10 years agos4-smbtorture: when checking PrinterData matrix, include winreg cross reference checks.
Günther Deschner [Fri, 5 Mar 2010 13:42:10 +0000 (14:42 +0100)]
s4-smbtorture: when checking PrinterData matrix, include winreg cross reference checks.

Guenther

10 years agos4-smbtorture: hand down printername to test_SetPrinterDataEx_matrix.
Günther Deschner [Fri, 5 Mar 2010 13:03:03 +0000 (14:03 +0100)]
s4-smbtorture: hand down printername to test_SetPrinterDataEx_matrix.

Guenther

10 years agos4-smbtorture: add more paranoid checks for REG_DWORD SetPrinterDataEx tests.
Günther Deschner [Thu, 4 Mar 2010 23:56:52 +0000 (00:56 +0100)]
s4-smbtorture: add more paranoid checks for REG_DWORD SetPrinterDataEx tests.

Guenther

10 years agos4-smbtorture: remove check for selfmade parsing artefact.
Günther Deschner [Thu, 4 Mar 2010 22:13:10 +0000 (23:13 +0100)]
s4-smbtorture: remove check for selfmade parsing artefact.

We were checking against a phenomenon that we created ourselves at the pidl
layer...

Guenther

10 years agos3-libads: fix get_remote_printer_publishing_data after spoolss_EnumPrinterDataEx...
Günther Deschner [Thu, 4 Mar 2010 16:58:49 +0000 (17:58 +0100)]
s3-libads: fix get_remote_printer_publishing_data after spoolss_EnumPrinterDataEx IDL change.

Guenther

10 years agos3-spoolss: fix _spoolss_EnumPrinterDataEx after idl
Günther Deschner [Thu, 4 Mar 2010 15:47:33 +0000 (16:47 +0100)]
s3-spoolss: fix _spoolss_EnumPrinterDataEx after idl

Guenther