15 years agor22170: To get the smbclient blackbox test to pass again, we need to get the
Andrew Bartlett [Wed, 11 Apr 2007 12:10:40 +0000 (12:10 +0000)]
r22170: To get the smbclient blackbox test to pass again, we need to get the
private dir to contain a valid machine account.

It isn't really valid it use the DC's account any more, so extend this
script to also join the domain.  This nicely tests out some previously
untested code too!

Andrew Bartlett

15 years agor22168: Ensure we actually run all the transports for the slow tests
Andrew Bartlett [Wed, 11 Apr 2007 11:17:09 +0000 (11:17 +0000)]
r22168: Ensure we actually run all the transports for the slow tests
(otherwise we miss tests).

Andrew Bartlett

15 years agor22167: This seems to get Fedora DS to run the tests again.
Andrew Bartlett [Wed, 11 Apr 2007 10:25:02 +0000 (10:25 +0000)]
r22167: This seems to get Fedora DS to run the tests again.

Andrew Bartlett

15 years agor22166: Stop heimdal from trying to prototype innetgr in roken, now we don't
Andrew Bartlett [Wed, 11 Apr 2007 06:43:06 +0000 (06:43 +0000)]
r22166: Stop heimdal from trying to prototype innetgr in roken, now we don't
do it in libreplace.

Andrew Bartlett

15 years agor22165: merge transaction fix from samba3
Andrew Tridgell [Wed, 11 Apr 2007 05:45:02 +0000 (05:45 +0000)]
r22165: merge transaction fix from samba3

15 years agor22162: get the TEST_LDAP mode working again
Andrew Bartlett [Wed, 11 Apr 2007 05:01:02 +0000 (05:01 +0000)]
r22162: get the TEST_LDAP mode working again

Andrew Bartlett

15 years agor22161: Clarify exactly where the socket_wrapper should be handled (early),
Andrew Bartlett [Wed, 11 Apr 2007 03:45:39 +0000 (03:45 +0000)]
r22161: Clarify exactly where the socket_wrapper should be handled (early),
and ensure that $prefix exists before it tries to create $prefix/w.

This should fix the build farm.  Perhaps we should have a rm -rf
$prefix at the start of this script, as that would have found the
problem, but I want to be careful about that...

Andrew Bartlett

15 years agor22160: Only use test environment names that actually exist (get make
Andrew Bartlett [Wed, 11 Apr 2007 01:32:38 +0000 (01:32 +0000)]
r22160: Only use test environment names that actually exist (get make
quicktest to pass).

Ensure that when we fail on the build farm, this ends up in the total

I think having the 2 different functions for running the tests is just
asking for this kind of failure.  The build farm should be a
presentation detail, and not alter the test behaviour.

There is still a gremlin in there, we will fail horribly on the farm,
but not on local tests...

Andrew Bartlett

15 years agor22156: - Lazy evaluate variable names.
Jelmer Vernooij [Tue, 10 Apr 2007 20:19:31 +0000 (20:19 +0000)]
r22156: - Lazy evaluate variable names.

- Don't set up environments until necessary

- Add --resetup-environment option

- Add 'none' environment

15 years agor22152: merge from samba3:
Stefan Metzmacher [Tue, 10 Apr 2007 16:00:13 +0000 (16:00 +0000)]
r22152: merge from samba3:

remove netgr functions from libreplace they're not used
in samba4 currently and samba3 has explicit configure checks for them.

should fix bug #4496


15 years agor22137: Actually use client.conf, defer more code as far as possible.
Jelmer Vernooij [Mon, 9 Apr 2007 12:15:56 +0000 (12:15 +0000)]
r22137: Actually use client.conf, defer more code as far as possible.

15 years agor22136: Fix incorrect event handling.
Rafal Szczesniak [Mon, 9 Apr 2007 12:06:42 +0000 (12:06 +0000)]
r22136: Fix incorrect event handling.
Submitted by John Jorgensen <>


15 years agor22134: Create different smb.conf file for the client side. This should make use...
Jelmer Vernooij [Mon, 9 Apr 2007 00:53:05 +0000 (00:53 +0000)]
r22134: Create different smb.conf file for the client side. This should make use with Samba 3 or windows easier as well as environments.

15 years agor22133: Don't push parameters into environment until necessary.
Jelmer Vernooij [Sun, 8 Apr 2007 23:55:01 +0000 (23:55 +0000)]
r22133: Don't push parameters into environment until necessary.

15 years agor22121: The RPC-CRACKNAMES test now passes against Samba4. This should help
Andrew Bartlett [Sat, 7 Apr 2007 05:19:24 +0000 (05:19 +0000)]
r22121: The RPC-CRACKNAMES test now passes against Samba4.  This should help
the code coverage...

Andrew Bartlett

15 years agor22120: Expand the RPC-CRACKNAMES test, to test more values and expose patterns.
Andrew Bartlett [Sat, 7 Apr 2007 05:14:23 +0000 (05:14 +0000)]
r22120: Expand the RPC-CRACKNAMES test, to test more values and expose patterns.

Fix up our server side implementation to pass almost all the tests (a
couple are skipped).

Don't require the DsGetDomainControllerInfo calls to pass, just get
some info from them.

Andrew Bartlett

15 years agor22119: Where we get a request to 'crack' a user principal name from a
Andrew Bartlett [Sat, 7 Apr 2007 03:04:33 +0000 (03:04 +0000)]
r22119: Where we get a request to 'crack' a user principal name from a
compleatly unknown domain, return the correct error code.

Andrew Bartlett

15 years agor22118: Add another RPC-CRACKNAMES test, but allow a way to skip sub-parts of
Andrew Bartlett [Sat, 7 Apr 2007 03:03:01 +0000 (03:03 +0000)]
r22118: Add another RPC-CRACKNAMES test, but allow a way to skip sub-parts of
this test we don't yet support in Samba4.  I want to at least try and
test this parts of this codebase...

Andrew Bartlett

15 years agor22117: merged from bzr
Andrew Tridgell [Sat, 7 Apr 2007 01:00:11 +0000 (01:00 +0000)]
r22117: merged from bzr

15 years agor22116: Only query by SID if we have a SID
Andrew Bartlett [Sat, 7 Apr 2007 00:57:26 +0000 (00:57 +0000)]
r22116: Only query by SID if we have a SID

Andrew Bartlett

15 years agor22115: I don't like the DOMAIN environment variable. It really isn't a good
Andrew Bartlett [Sat, 7 Apr 2007 00:47:39 +0000 (00:47 +0000)]
r22115: I don't like the DOMAIN environment variable.  It really isn't a good
match for what we are using it for here.

Andrew Bartlett

15 years agor22114: merge from bzr tree
Andrew Tridgell [Sat, 7 Apr 2007 00:03:09 +0000 (00:03 +0000)]
r22114: merge from bzr tree

15 years agor22098: merged from bzr tree
Andrew Tridgell [Fri, 6 Apr 2007 04:43:54 +0000 (04:43 +0000)]
r22098: merged from bzr tree

15 years agor22090: fix error handling in cldap client library to cope with bad host names
Andrew Tridgell [Thu, 5 Apr 2007 07:37:21 +0000 (07:37 +0000)]
r22090: fix error handling in cldap client library to cope with bad host names

15 years agor22089: check the return value of interpret_addr2()
Andrew Tridgell [Thu, 5 Apr 2007 07:36:46 +0000 (07:36 +0000)]
r22089: check the return value of interpret_addr2()

15 years agor22088: export PIDDIR to make the smbd pid show in 'make testenv' again.
Andrew Bartlett [Thu, 5 Apr 2007 06:33:37 +0000 (06:33 +0000)]
r22088: export PIDDIR to make the smbd pid show in 'make testenv' again.

15 years agor22087: added a RAW-BENCH-OPEN test that can be used to stress out a clustered
Andrew Tridgell [Thu, 5 Apr 2007 06:23:06 +0000 (06:23 +0000)]
r22087: added a RAW-BENCH-OPEN test that can be used to stress out a clustered
implementation of a opendb backend. Use it in combination with
--unclist to tell smbtorture to connect to multiple nodes in the

15 years agor22086: Bail out early on some of these failures.
Andrew Bartlett [Thu, 5 Apr 2007 06:00:44 +0000 (06:00 +0000)]
r22086: Bail out early on some of these failures.

15 years agor22085: correct copyright on opendb_ctdb.c
Andrew Tridgell [Thu, 5 Apr 2007 04:23:57 +0000 (04:23 +0000)]
r22085: correct copyright on opendb_ctdb.c

15 years agor22084: use a TDB_INTERNAL tdb for the local ctdb tdb for now
Andrew Tridgell [Thu, 5 Apr 2007 04:20:55 +0000 (04:20 +0000)]
r22084: use a TDB_INTERNAL tdb for the local ctdb tdb for now

15 years agor22083: opendb backend to ctdb now passes simple tests
Andrew Tridgell [Thu, 5 Apr 2007 04:08:00 +0000 (04:08 +0000)]
r22083: opendb backend to ctdb now passes simple tests

15 years agor22082: merged the ctdb changes from bzr
Andrew Tridgell [Thu, 5 Apr 2007 03:51:49 +0000 (03:51 +0000)]
r22082: merged the ctdb changes from bzr

added opendb ctdb backend from ronnie

15 years agor22081: transaction_brlock() should be static
Andrew Tridgell [Thu, 5 Apr 2007 03:22:08 +0000 (03:22 +0000)]
r22081: transaction_brlock() should be static

thanks to Ted T'so for pointing this out

15 years agor22077: Import only necessary test variables, more refactoring.
Jelmer Vernooij [Wed, 4 Apr 2007 14:24:44 +0000 (14:24 +0000)]
r22077: Import only necessary test variables, more refactoring.

15 years agor22076: Fill in short and long domain names into the generated krb5.conf
Andrew Bartlett [Wed, 4 Apr 2007 12:40:19 +0000 (12:40 +0000)]
r22076: Fill in short and long domain names into the generated krb5.conf

15 years agor22075: Configure the bitwise match plugin, until it becomes accepted upstream.
Andrew Bartlett [Wed, 4 Apr 2007 12:39:44 +0000 (12:39 +0000)]
r22075: Configure the bitwise match plugin, until it becomes accepted upstream.

Andrew Bartlett

15 years agor22074: More refactoring.
Jelmer Vernooij [Wed, 4 Apr 2007 12:23:10 +0000 (12:23 +0000)]
r22074: More refactoring.

15 years agor22072: in order to implement the opendb ctdb backend, I've found that the
Andrew Tridgell [Wed, 4 Apr 2007 06:06:52 +0000 (06:06 +0000)]
r22072: in order to implement the opendb ctdb backend, I've found that the
existing ctdb_call() mechanism isn't sufficient. The main problem is
that the operations on the record need to be done with a lock held
while a local posix file operation is happening. We can't use a
ctdb_call callback function to do the actual file opens, renames,
unlinks etc as the callback would run on the wrong node.

So this commit adds the prototypes for two new ctdb API functions
which will make a opendb backend easier. Volker will probably
recognise these functions as they are basically the same as what he
did in his earlier Samba clustering code :-)

15 years agor22070: merge in the changes from the bzr ctdb tree, and convert the brlock
Andrew Tridgell [Wed, 4 Apr 2007 04:57:30 +0000 (04:57 +0000)]
r22070: merge in the changes from the bzr ctdb tree, and convert the brlock
ctdb backend to use the updated multi-database API

15 years agor22063: Fix the RPC-EPMAPPER test.
Jelmer Vernooij [Tue, 3 Apr 2007 22:43:35 +0000 (22:43 +0000)]
r22063: Fix the RPC-EPMAPPER test.

15 years agor22053: remove samba3 specific stuff from tdbtool
Stefan Metzmacher [Tue, 3 Apr 2007 09:08:18 +0000 (09:08 +0000)]
r22053: remove samba3 specific stuff from tdbtool

should I merge this to SAMBA_3_0? as it's also totally
broken there, as the connection_struct definition is completely


15 years agor22052: merge tdbtool from samba3 and build it
Stefan Metzmacher [Tue, 3 Apr 2007 07:04:37 +0000 (07:04 +0000)]
r22052: merge tdbtool from samba3 and build it


15 years agor22048: Sigh. Commit the other half of r22047.
James Peach [Mon, 2 Apr 2007 21:26:32 +0000 (21:26 +0000)]
r22048: Sigh. Commit the other half of r22047.

15 years agor22047: Move suffix rules into smb_build. Enable $< if we are building with
James Peach [Mon, 2 Apr 2007 21:21:56 +0000 (21:21 +0000)]
r22047: Move suffix rules into smb_build. Enable $< if we are building with
GNU Make. This lets GNU Make users bild with $srcdir != $builddir.

15 years agor22046: Rever r22040, which breaks the build on FreeBSD 5.4 (BSD make).
James Peach [Mon, 2 Apr 2007 20:19:00 +0000 (20:19 +0000)]
r22046: Rever r22040, which breaks the build on FreeBSD 5.4 (BSD make).

15 years agor22041: merge trivial changes from samba3
Stefan Metzmacher [Mon, 2 Apr 2007 18:56:25 +0000 (18:56 +0000)]
r22041: merge trivial changes from samba3


15 years agor22040: Use $< to specify the immediate prerequisit instead of $*. This is
James Peach [Mon, 2 Apr 2007 18:43:31 +0000 (18:43 +0000)]
r22040: Use $< to specify the immediate prerequisit instead of $*. This is
needed for VPATH to find the correct files when srcdir != builddir.

This checkin is a test to see which platforms this change will break.

15 years agor22038: - fix perl warning
Stefan Metzmacher [Mon, 2 Apr 2007 18:14:27 +0000 (18:14 +0000)]
r22038: - fix perl warning
- use the same if statement as in


15 years agor22037: Make sure STATICDIR exists before linking a static archive.
James Peach [Mon, 2 Apr 2007 17:29:03 +0000 (17:29 +0000)]
r22037: Make sure STATICDIR exists before linking a static archive.

15 years agor22036: Make sure both srcdir and builddir are in VPATH.
James Peach [Mon, 2 Apr 2007 17:26:18 +0000 (17:26 +0000)]
r22036: Make sure both srcdir and builddir are in VPATH.

15 years agor22035: Introduce HOSTLD which is needed to link the asn1 compiler when cross
James Peach [Mon, 2 Apr 2007 17:23:23 +0000 (17:23 +0000)]
r22035: Introduce HOSTLD which is needed to link the asn1 compiler when cross

15 years agor22034: Use builddir and srcdir instead on samba_builddir and samba_srcdir.
James Peach [Mon, 2 Apr 2007 17:17:40 +0000 (17:17 +0000)]
r22034: Use builddir and srcdir instead on samba_builddir and samba_srcdir.

15 years agor22032: Make sure static libraries end up in bin/static.
James Peach [Mon, 2 Apr 2007 17:14:43 +0000 (17:14 +0000)]
r22032: Make sure static libraries end up in bin/static.

15 years agor22031: Make sure we rewrite the include directives in CFLAGS to contain
James Peach [Mon, 2 Apr 2007 17:11:36 +0000 (17:11 +0000)]
r22031: Make sure we rewrite the include directives in CFLAGS to contain
paths from builddir and srcdir. builddir has precedence.

15 years agor22030: Simplify include parsing for files, making sure we get
James Peach [Mon, 2 Apr 2007 17:08:21 +0000 (17:08 +0000)]
r22030: Simplify include parsing for files, making sure we get
it right for the srcdir != builddir case. Emit some comment lines
that can be used to figure out which parts of the Makefile output
is generated from which config files.

15 years agor22029: Make sure we respect $srcdir correctly for the srcdir != builddir case.
James Peach [Mon, 2 Apr 2007 17:06:14 +0000 (17:06 +0000)]
r22029: Make sure we respect $srcdir correctly for the srcdir != builddir case.

15 years agor22028: Fix include path for the srcidr != builddir case.
James Peach [Mon, 2 Apr 2007 17:03:30 +0000 (17:03 +0000)]
r22028: Fix include path for the srcidr != builddir case.

15 years agor22027: Allow separate build and source directories. Don't follow symlinks
James Peach [Mon, 2 Apr 2007 17:02:52 +0000 (17:02 +0000)]
r22027: Allow separate build and source directories. Don't follow symlinks
when copying hemidal_build since this leads to traversal loops.

15 years agor22025: patch from Ronnie to make locktest also test the behaviour of pid
Andrew Tridgell [Mon, 2 Apr 2007 07:06:49 +0000 (07:06 +0000)]
r22025: patch from Ronnie to make locktest also test the behaviour of pid
changes in the locks

15 years agor22021: use the pid specified in the individual locks, not the request pid, in
Andrew Tridgell [Mon, 2 Apr 2007 04:47:19 +0000 (04:47 +0000)]
r22021: use the pid specified in the individual locks, not the request pid, in
locking requests.

This fixes a bug noticed by Ronnie Sahlberg (thanks!)

15 years agor22005: Add more code (doesn't work at the moment) preparing a place for
Rafal Szczesniak [Wed, 28 Mar 2007 23:01:35 +0000 (23:01 +0000)]
r22005: Add more code (doesn't work at the moment) preparing a place for
listing user accounts.


15 years agor22004: Check for dereferencing null pointers.
Jelmer Vernooij [Wed, 28 Mar 2007 22:52:37 +0000 (22:52 +0000)]
r22004: Check for dereferencing null pointers.

Patch by Ronnie Sahlberg.

15 years agor21996: Fix a bug for invalid casts of pointers.
Jelmer Vernooij [Tue, 27 Mar 2007 23:22:41 +0000 (23:22 +0000)]
r21996: Fix a bug for invalid casts of pointers.

Patch by Ronnie Sahlberg.

15 years agor21995: Patch from Ronnie Sahlberg.
Jelmer Vernooij [Tue, 27 Mar 2007 23:04:08 +0000 (23:04 +0000)]
r21995: Patch from Ronnie Sahlberg.

Change the signatures for all functions it generates to specify
_U_ so that GCC "parameter not used" warnings are suppressed.

15 years agor21971: Fill in some more values in config files from variables, so we can
Andrew Bartlett [Tue, 27 Mar 2007 08:06:05 +0000 (08:06 +0000)]
r21971: Fill in some more values in config files from variables, so we can
better setup multiple environments.

Run the mk-keyblobs script before we need variables it defines.

Andrew Bartlett

15 years agor21970: Ensure that Fedora DS can be shut down correctly with the stop script:
Andrew Bartlett [Tue, 27 Mar 2007 04:21:16 +0000 (04:21 +0000)]
r21970: Ensure that Fedora DS can be shut down correctly with the stop script:
This needs the pid file to be in the right spot.

Andrew Bartlett

15 years agor21951: Hopefully fix valgrind warning.
James Peach [Fri, 23 Mar 2007 20:28:45 +0000 (20:28 +0000)]
r21951: Hopefully fix valgrind warning.

15 years agor21949: After discussion with the Apple and Linux client maintainers,
James Peach [Fri, 23 Mar 2007 19:24:21 +0000 (19:24 +0000)]
r21949: After discussion with the Apple and Linux client maintainers,
changing the FindFirst response for the UNIX_INFO2 level to include
a length field before the name. The name is not required to be null
terminated. the lenght field does not count any null.

15 years agor21943: don't send unitialized data
Stefan Metzmacher [Fri, 23 Mar 2007 09:11:53 +0000 (09:11 +0000)]
r21943: don't send unitialized data


15 years agor21928: fix the interface uuid of wzcsvc.
Stefan Metzmacher [Thu, 22 Mar 2007 08:17:30 +0000 (08:17 +0000)]
r21928: fix the interface uuid of wzcsvc.


thanks to jbm for the report!


15 years agor21911: Some more work on making the ncacn_np handling in smbd be less special.
Jelmer Vernooij [Wed, 21 Mar 2007 17:05:39 +0000 (17:05 +0000)]
r21911: Some more work on making the ncacn_np handling in smbd be less special.

15 years agor21910: Clean up some unused functions.
Jelmer Vernooij [Wed, 21 Mar 2007 16:26:25 +0000 (16:26 +0000)]
r21910: Clean up some unused functions.

15 years agor21909: Merge some of my recent improvements to the test infrastructure:
Jelmer Vernooij [Wed, 21 Mar 2007 15:57:07 +0000 (15:57 +0000)]
r21909: Merge some of my recent improvements to the test infrastructure:
- Allow tests to specify what environment they need to run in (dc and none are thecurrent supported ones).

- Move more Samba4-specific code out of the common code

15 years agor21896: - Enable creating default NetContext when no explicit credentials are
Rafal Szczesniak [Tue, 20 Mar 2007 22:44:22 +0000 (22:44 +0000)]
r21896: - Enable creating default NetContext when no explicit credentials are
  passed. In such case use what's been provided on swat session logon.
- Create a proper NetContext object only once and add it to the resources
  for later use.


15 years agor21859: add a comment why we remove the rid_crypt obfuscation
Stefan Metzmacher [Fri, 16 Mar 2007 16:35:44 +0000 (16:35 +0000)]
r21859: add a comment why we remove the rid_crypt obfuscation


15 years agor21852: Further work on initialising libnet context from netmgr.
Rafal Szczesniak [Fri, 16 Mar 2007 00:19:40 +0000 (00:19 +0000)]
r21852: Further work on initialising libnet context from netmgr.


15 years agor21843: the computer_dn isn't needed anymore because we don't manually reset the...
Stefan Metzmacher [Thu, 15 Mar 2007 13:21:54 +0000 (13:21 +0000)]
r21843: the computer_dn isn't needed anymore because we don't manually reset the password


15 years agor21842: fix typo in comment
Stefan Metzmacher [Thu, 15 Mar 2007 07:22:49 +0000 (07:22 +0000)]
r21842: fix typo in comment


15 years agor21841: Rename the method and check parameters more strictly.
Rafal Szczesniak [Wed, 14 Mar 2007 23:25:54 +0000 (23:25 +0000)]
r21841: Rename the method and check parameters more strictly.


15 years agor21839: add my email address
Stefan Metzmacher [Wed, 14 Mar 2007 19:10:21 +0000 (19:10 +0000)]
r21839: add my email address


15 years agor21838: generate no metadata for constructed attributes
Stefan Metzmacher [Wed, 14 Mar 2007 12:07:56 +0000 (12:07 +0000)]
r21838: generate no metadata for constructed attributes


15 years agor21837: Make dcerpc_mgmt a separate library again, as the linker leaves it out when...
Jelmer Vernooij [Wed, 14 Mar 2007 00:44:29 +0000 (00:44 +0000)]
r21837: Make dcerpc_mgmt a separate library again, as the linker leaves it out when it's part of dcerpc.

15 years agor21836: Assume that if an OpenLDAP system is 'modular' then everything is a
Andrew Bartlett [Tue, 13 Mar 2007 23:16:09 +0000 (23:16 +0000)]
r21836: Assume that if an OpenLDAP system is 'modular' then everything is a
module, so we have to bring in syncprov too.

Andrew Bartlett

15 years agor21835: fixed a rpc server bug where we failed to remove a call from one
Andrew Tridgell [Tue, 13 Mar 2007 22:58:23 +0000 (22:58 +0000)]
r21835: fixed a rpc server bug where we failed to remove a call from one
linked list when moving it to another. This could cause a valgrind
error under the RPC-SCANNER test.

15 years agor21834: Remove unnecessary includes
Jelmer Vernooij [Tue, 13 Mar 2007 22:03:04 +0000 (22:03 +0000)]
r21834: Remove unnecessary includes

15 years agor21833: Don't install static libs, they can't be used anyway.
Jelmer Vernooij [Tue, 13 Mar 2007 21:47:57 +0000 (21:47 +0000)]
r21833: Don't install static libs, they can't be used anyway.

15 years agor21832: Ignore some more autogenerated files.
Jelmer Vernooij [Tue, 13 Mar 2007 21:00:27 +0000 (21:00 +0000)]
r21832: Ignore some more autogenerated files.

15 years agor21830: Fix header installation, remove proto header with a single prototype.
Jelmer Vernooij [Tue, 13 Mar 2007 20:44:14 +0000 (20:44 +0000)]
r21830: Fix header installation, remove proto header with a single prototype.

15 years agor21829: Integrate mgmt in libdcerpc. We have enough libraries as it is and mgmt...
Jelmer Vernooij [Tue, 13 Mar 2007 20:26:35 +0000 (20:26 +0000)]
r21829:  Integrate mgmt in libdcerpc. We have enough libraries as it is and mgmt is part of the DCE/RPC standard.

15 years agor21828: Hardcode prototypes, as they're a public API.
Jelmer Vernooij [Tue, 13 Mar 2007 20:08:44 +0000 (20:08 +0000)]
r21828: Hardcode prototypes, as they're a public API.

15 years agor21827: move comments to the place where the functionality is implemented
Stefan Metzmacher [Tue, 13 Mar 2007 18:17:31 +0000 (18:17 +0000)]
r21827: move comments to the place where the functionality is implemented


15 years agor21826: reorder functions
Stefan Metzmacher [Tue, 13 Mar 2007 18:12:21 +0000 (18:12 +0000)]
r21826: reorder functions


15 years agor21821: move comment about the becoming a dc to the code which implements it
Stefan Metzmacher [Tue, 13 Mar 2007 15:41:25 +0000 (15:41 +0000)]
r21821: move comment about the becoming a dc to the code which implements it
and extent the comments a bit


15 years agor21820: move function, so that all are in top-down order as they get called
Stefan Metzmacher [Tue, 13 Mar 2007 14:32:20 +0000 (14:32 +0000)]
r21820: move function, so that all are in top-down order as they get called


15 years agor21817: give fields a meaning
Stefan Metzmacher [Tue, 13 Mar 2007 11:10:48 +0000 (11:10 +0000)]
r21817: give fields a meaning


15 years agor21814: use ndr_push_error in the ndr layer, not just a NTSTATUS failure
Andrew Tridgell [Tue, 13 Mar 2007 04:42:49 +0000 (04:42 +0000)]
r21814: use ndr_push_error in the ndr layer, not just a NTSTATUS failure

15 years agor21812: fixed an integer overflow error in the ndr push code.
Andrew Tridgell [Tue, 13 Mar 2007 04:18:07 +0000 (04:18 +0000)]
r21812: fixed an integer overflow error in the ndr push code.

This needs to be fixed in Samba3 as well. It might be exploitable (I
haven't confirmed one way or the other), so I think this should be
fixed for 3.0.25

15 years agor21811: fixed a queueing error in the dcerpc client code. WHen the
Andrew Tridgell [Tue, 13 Mar 2007 03:43:16 +0000 (03:43 +0000)]
r21811: fixed a queueing error in the dcerpc client code. WHen the
dcerpc_ship_next_request() logic was added the penidng queue was split
in two, but we also needed to update the code which removes requests
from the queue to know about the two queues. Following the pattern
used in other client libs, I based which queue to remove from on
req->state, and added a new state RPC_REQUEST_QUEUED. This fixes a
crash that happens when rpc requests time out.

This patch also fixes the handling of timed out bind requests, and the
talloc_reference handling in dcerpc_ndr_request_recv().

15 years agor21810: - The height of a widget is in relation to its enclosing widget. Specifying a
Derrell Lipman [Tue, 13 Mar 2007 02:58:05 +0000 (02:58 +0000)]
r21810: - The height of a widget is in relation to its enclosing widget.  Specifying a
  height of 100% means that if the enclosing widget is 100 pixels high, this
  widget should be 100 pixels high.  If this widget is then placed someplace
  other than at the top of the enclosing widget, e.g. with top:20, the bottom
  of this widget will fall off the bottom of the enclosing widget.

  The normal way to solve this is to specify top and bottom attributes rather
  than top and height attributes.  Also, since widgets often look better if
  they don't extend all the way to the very bottom, specifying a bottom
  attribute equal to the top attribute typically has an appealing appearance.

  I've fixed the tree widget so it no longer falls off the bottom of the page.

15 years agor21809: - If the canvas is never initialized with the tree, the tree will never
Derrell Lipman [Tue, 13 Mar 2007 02:54:06 +0000 (02:54 +0000)]
r21809: - If the canvas is never initialized with the tree, the tree will never
  appear.  Now that the finite state machine properly ignores events from
  widgets which are not handled, the initialization of the tree should be done
  when the module's canvas appears (i.e. just after the canvas has had the
  module's gui applied to it).