Günther Deschner [Fri, 3 Jul 2009 16:39:58 +0000 (18:39 +0200)]
s3-spoolss: add rpccli_spoolss_getprinterdriver convenience wrapper.
Guenther
Günther Deschner [Fri, 3 Jul 2009 16:39:38 +0000 (18:39 +0200)]
spoolss: fill in spoolss_GetPrinterDriver IDL.
Guenther
Günther Deschner [Fri, 3 Jul 2009 12:08:05 +0000 (14:08 +0200)]
spoolss: the flags in spoolss_SetPrinterInfo1 are in fact spoolss_PrinterAttributes.
Guenther
Günther Deschner [Fri, 3 Jul 2009 09:05:38 +0000 (11:05 +0200)]
s3-spoolss: implement _spoolss_AddPrinter.
Guenther
Günther Deschner [Fri, 3 Jul 2009 08:10:53 +0000 (10:10 +0200)]
spoolss: fill in spoolss_AddPrinter IDL.
Guenther
Björn Jacke [Fri, 3 Jul 2009 17:13:08 +0000 (19:13 +0200)]
heimdal: don't include <ifaddrs.h> without knowing it's there
this is
73dbbe0d54 re-added. abartlet, please pick this to lorikeet.
Björn Jacke [Fri, 3 Jul 2009 16:22:16 +0000 (18:22 +0200)]
tdb: fix define of tdbdir when srcdir != "."
Simo Sorce [Fri, 3 Jul 2009 12:42:23 +0000 (08:42 -0400)]
Sort the signature files
Simo Sorce [Fri, 19 Jun 2009 00:06:00 +0000 (20:06 -0400)]
Expose functions need by backend writers
move publicly needed structures and functions in the public header.
Stop installing internal headers.
Update the signature and exports files with the new exposed
function.
Simo Sorce [Thu, 2 Jul 2009 13:29:20 +0000 (09:29 -0400)]
Restore ABI compatibility for talloc.
Björn Jacke [Fri, 3 Jul 2009 12:25:06 +0000 (14:25 +0200)]
s3:configure: fix syntax error in avahi configure test
Jelmer Vernooij [Fri, 3 Jul 2009 00:59:40 +0000 (02:59 +0200)]
s4: Don't install epdump, since it no longer exists.
Michael Adam [Fri, 3 Jul 2009 09:35:11 +0000 (11:35 +0200)]
Revert "[s3]pidfile_create: use check is_default_dyn_CONFIGFILE() since we have it."
This reverts commit
1d3dcd1e420104c23769b691d0b8b7958d5c58a7.
This fixes Bug #6531 (Pid File creation.)
Usually, I would extend is_default_dyn_XYZ() so that it returns true
when dyn_XYZ has not been set yet or when its value is equal to the
compiled in default value XZY. But this would have a change in effect
in popt_common and torture.c: is_default_dyn_CONFIGFILE() is used
there to check whether the config file should be overwritten by the
contents of the environment variable SMB_CONF_PATH. Currently this
is only done when set_dyn_CONFIGFILE() had _not_ previously been called
at all, not even with the same value as the compiled in default.
Michael
Matt Kraai [Wed, 1 Jul 2009 17:49:35 +0000 (10:49 -0700)]
do not redefine _INT32
Matt Kraai [Wed, 1 Jul 2009 19:44:03 +0000 (12:44 -0700)]
s3:configure: define _LARGEFILE64_SOURCE on QNX
Björn Jacke [Wed, 10 Jun 2009 10:31:07 +0000 (12:31 +0200)]
s3:pam_smbpass: fix build error on some Linux distros
This addresses bug #6459.
Jelmer Vernooij [Wed, 1 Jul 2009 12:49:18 +0000 (14:49 +0200)]
s4 docs: Git has revision SHA's, not numbers.
Jelmer Vernooij [Wed, 1 Jul 2009 14:54:02 +0000 (16:54 +0200)]
s4: Remove stub endpoint mapper script.
Jelmer Vernooij [Fri, 19 Jun 2009 14:48:19 +0000 (16:48 +0200)]
TOSHARG: Fix typo: s/aquire/acquire/
Jelmer Vernooij [Fri, 19 Jun 2009 14:17:08 +0000 (16:17 +0200)]
pidl: Don't run compile tests inside the tree, won't work yet.
Stefan Metzmacher [Thu, 2 Jul 2009 17:26:05 +0000 (19:26 +0200)]
s3:smbd: add marshalling layer for SMB2 Lock support
metze
Stefan Metzmacher [Thu, 2 Jul 2009 15:47:33 +0000 (17:47 +0200)]
s4:libcli: move SMB2 lock flags to smb2_constants.h
metze
Stefan Metzmacher [Thu, 2 Jul 2009 10:28:58 +0000 (12:28 +0200)]
s3:smbd: add marshalling layer for SMB2 Find (QueryDirectory) support
metze
Stefan Metzmacher [Thu, 2 Jul 2009 09:56:23 +0000 (11:56 +0200)]
s3:smbd: add marshalling layer for SMB2 Break support (SMB 2.002 only)
metze
Stefan Metzmacher [Thu, 2 Jul 2009 09:40:07 +0000 (11:40 +0200)]
s3:smbd: add marshalling layer for SMB2 SetInfo support
metze
Stefan Metzmacher [Thu, 2 Jul 2009 08:17:30 +0000 (10:17 +0200)]
s3:smbd: add marshalling layer for SMB2 GetInfo support
metze
Günther Deschner [Thu, 2 Jul 2009 17:39:36 +0000 (19:39 +0200)]
spoolss: the flags in spoolss_PrinterInfo1 are in fact spoolss_PrinterAttributes.
Guenther
Günther Deschner [Wed, 1 Jul 2009 20:52:49 +0000 (22:52 +0200)]
s4-smbtorture: fix getjob test in RPC-SPOOLSS.
Guenther
Günther Deschner [Wed, 1 Jul 2009 20:52:05 +0000 (22:52 +0200)]
doserrors: print out some more werrors.
Guenther
Stefan Metzmacher [Thu, 2 Jul 2009 08:48:24 +0000 (10:48 +0200)]
talloc: change TALLOC_MAGIC for version 2.0.0
metze
Andrew Tridgell [Thu, 2 Jul 2009 06:19:37 +0000 (16:19 +1000)]
show attribute values in sorted order to make comparison easier
Stefan Metzmacher [Mon, 29 Jun 2009 20:31:13 +0000 (22:31 +0200)]
s3:smbd: add support for SMB2 Notify
metze
Stefan Metzmacher [Tue, 30 Jun 2009 13:01:00 +0000 (15:01 +0200)]
s3:smbd: make change_notify_reply() more generic and hide send_nt_replies() behind a callback
This prepares change notify support for SMB2.
metze
Stefan Metzmacher [Mon, 29 Jun 2009 20:17:17 +0000 (22:17 +0200)]
s3:smbd: simplify the notify code a bit and always reply via change_notify_reply() -> send_nt_replies()
metze
Stefan Metzmacher [Mon, 29 Jun 2009 13:38:48 +0000 (15:38 +0200)]
s3:smbd: push nttrans and trans2 responses with no data to the client
For sync replies it's not a problem, as construct_reply() will send
the response, but for async replies we would not send the reply to the client.
Currently the notify code works arround this manually, so I assume
we didn't have a bug here. But the next commits will simplify
the notify code.
metze
Stefan Metzmacher [Wed, 1 Jul 2009 10:56:30 +0000 (12:56 +0200)]
s3:smbd: restore the 3.0.x bahavior of send_nt_replies()
We should also set the error code, when we return no parameters or data.
metze
Stefan Metzmacher [Tue, 30 Jun 2009 08:17:38 +0000 (10:17 +0200)]
s3:smbd: move global notify_changes_by_mid to smbd_server_connection
metze
Stefan Metzmacher [Tue, 30 Jun 2009 11:25:21 +0000 (13:25 +0200)]
s3:smbd: allow the offset to the path being 0 in SMB2 create
metze
Andrew Tridgell [Thu, 2 Jul 2009 05:57:30 +0000 (15:57 +1000)]
we can't use the unique index code for samAccountName
Using ldb unique indexes for samAccountName doesn't work with DRS as
the other DC may send us a deleted record (tombstone record), which
has the same samAccountName as an existing record. That would then
create two records in the same partition with the same samAccountName.
So we needed to put back the logic in samldb.c which explicitly
checked whether a samAccountName already exists on add
Andrew Tridgell [Thu, 2 Jul 2009 05:33:01 +0000 (15:33 +1000)]
decrypt all objects in a DRS record, not just the first one
We found this as an object came across from w2k3 with zero values,
which caused a segv when we tried to decrypt the first value
Andrew Tridgell [Thu, 2 Jul 2009 05:19:40 +0000 (15:19 +1000)]
change talloc to 2.0.0
This is needed to prevent samba3 and samba4 from using an ABI
incompatible system version of talloc
See ongoing discussion on the samba-technical mailing list
Andrew Tridgell [Thu, 2 Jul 2009 04:52:25 +0000 (14:52 +1000)]
Changed ldb.ERR_NO_SUCH_OBJECT to LDB_ERR_NO_SUCH_OBJECT.
The LDB_ERR_NO_SUCH_OBJECT varient is not a defined variable. This
should improve error handling in our python code on some
systems. Unfortunately it still doesn't work on mine. I need to trap
Jelmer somewhere where he can't escape some day and force him to
divulge the deep druid secrets of python exception handling ....
Andrew Tridgell [Thu, 2 Jul 2009 04:49:40 +0000 (14:49 +1000)]
fixed the pull of drs schema elements
The previous code incorrectly assumed that attributes such as
subClassOf come over the wire as strings. In fact they come over as 32
bit integers which refer to goversIDs. We have to post-process these
as it sometimes happens that a governsID comes over the wire before
the record that defines what it means.
Andrew Tridgell [Thu, 2 Jul 2009 04:47:06 +0000 (14:47 +1000)]
the settings structure needs to be initialised
Andrew Tridgell [Thu, 2 Jul 2009 04:44:48 +0000 (14:44 +1000)]
LDB_ERR_INVALID_DN_SYNTAX doesn't exist ...
The correct name is ldb.ERR_INVALID_DN_SYNTAX
Andrew Bartlett [Thu, 2 Jul 2009 04:34:07 +0000 (14:34 +1000)]
s4:param use talloc_unlink() to free iconv context holding references
Matthias Dieter Wallnöfer [Tue, 30 Jun 2009 11:44:45 +0000 (13:44 +0200)]
[SAMBA 4 directory] Changes "forceLogoff" and corrects the "subRefs"
- This changes the attribute "forceLogoff" to its' default
values according to Windows Server 2003 R2
- Also this corrects the "subRefs" attribute of the base-DN which only refers
to direct child partitions (and therefore not to the complete transitive closure)
Jeremy Allison [Thu, 2 Jul 2009 00:39:10 +0000 (17:39 -0700)]
Ensure we don't use delayed writes on POSIX opened files.
Don't remove pending writetime changes if no time changes
are sent in UNIX_BASIC infolevel.
Jeremy
Jeremy Allison [Wed, 1 Jul 2009 23:58:14 +0000 (16:58 -0700)]
Fix bug #6520 time stamps - e.g. last mod time is not preserved when "unix extensions=yes" are set - and using latest cifs vfs client
Cancel out any pending "sticky" writes or "last write" changes when
doing a UNIX info level set.
Jeremy.
Stefan Metzmacher [Tue, 30 Jun 2009 14:03:11 +0000 (16:03 +0200)]
s3:util: let parent_dirname() correctly return toplevel filenames
metze
Stefan Metzmacher [Wed, 1 Jul 2009 10:50:00 +0000 (12:50 +0200)]
s3:onefs_open: remove unused variable passed to parent_dirname()
metze
Stefan Metzmacher [Wed, 1 Jul 2009 10:49:06 +0000 (12:49 +0200)]
s3:smbd: remove unused variables passed to parent_dirname()
metze
Michael Adam [Wed, 1 Jul 2009 09:29:00 +0000 (11:29 +0200)]
s3:build: remove the libgpo objects upon "make clean"
Michael
Michael Adam [Wed, 1 Jul 2009 09:19:58 +0000 (11:19 +0200)]
s3:build: remove ../libcli/nbt/tools/nmblookup.o and friends in make clean
Michael
Michael Adam [Wed, 1 Jul 2009 08:51:17 +0000 (10:51 +0200)]
lib/util: fix order of includes in tevent_ntstatus.c
replace.h needs to be included first.
Michael
Andrew Tridgell [Wed, 1 Jul 2009 06:36:29 +0000 (16:36 +1000)]
fixed the talloc testsuite for the recent changes
Andrew Tridgell [Wed, 1 Jul 2009 06:36:10 +0000 (16:36 +1000)]
a talloc_realloc() to zero size needs to use an unambiguous free
Matt Kraai [Wed, 1 Jul 2009 06:18:11 +0000 (08:18 +0200)]
s3/docs: Fix typo.
This fixes bug #6519.
Andrew Tridgell [Wed, 1 Jul 2009 05:15:13 +0000 (15:15 +1000)]
removed a generated file
Andrew Tridgell [Wed, 1 Jul 2009 05:13:49 +0000 (15:13 +1000)]
use a talloc_reparent in a very ugly way
this works around some terrible use of talloc in the libnet code
Andrew Tridgell [Wed, 1 Jul 2009 04:53:32 +0000 (14:53 +1000)]
use the new talloc_reparent in two places
Andrew Tridgell [Wed, 1 Jul 2009 04:53:01 +0000 (14:53 +1000)]
changes to remove the ambiguity in talloc_free() and talloc_steal()
These changes follow from the discussions on samba-technical. The
changes are in several parts, and stem from the inherent ambiguity
that was in talloc_free() and talloc_steal() when the pointer that is
being changes has more than one parent, via references.
The changes are:
1) when you call talloc_free() on a pointer with more than one parent
the free will fail, and talloc will log an error to stderr like this:
ERROR: talloc_free with references at some/foo.c:123
reference at other/bar.c:201
reference at other/foobar.c:641
2) Similarly, when you call talloc_steal() on a pointer with more
than one parent, the steal will fail and talloc will log an error to
stderr like this:
ERROR: talloc_steal with references at some/foo.c:123
reference at other/bar.c:201
3) A new function talloc_reparent() has been added to change a parent
in a controlled fashion. You need to supply both the old parent and
the new parent. It handles the case whether either the old parent was
a normal parent or a reference
The use of stderr in the logging is ugly (and potentially dangerous),
and will be removed in a future patch. We'll need to add a debug
registration function to talloc.
Andrew Tridgell [Wed, 1 Jul 2009 04:08:43 +0000 (14:08 +1000)]
gensec_start now steals the auth_context
Andrew Tridgell [Wed, 1 Jul 2009 04:08:13 +0000 (14:08 +1000)]
A rather strange varient of talloc_unlink
A dcerpc request may have a reference from a still completing async
callback, but we now consider the request to be complete. We want to
lose the main parent, leaving just the reference, if any.
Andrew Tridgell [Wed, 1 Jul 2009 04:06:56 +0000 (14:06 +1000)]
another case that should use py_talloc_reference
Andrew Tridgell [Wed, 1 Jul 2009 04:06:38 +0000 (14:06 +1000)]
use py_talloc_reference instead of py_talloc_import
This is one of the few cases where we want the object to be owned by
both the python object and C code
Andrew Tridgell [Wed, 1 Jul 2009 04:05:53 +0000 (14:05 +1000)]
py_talloc_import now uses a steal, so this free is incorrect
Andrew Tridgell [Wed, 1 Jul 2009 04:05:17 +0000 (14:05 +1000)]
fixed use of reference in pytalloc
The previous code caused memory leaks, and also caused situations
where talloc_free could be called on pointers with multiple parents
The new approach is to have two functions:
py_talloc_import : steals the pointer, so it becomes wholly owned by
the python object
py_talloc_reference: uses a reference, so it is owned by both python
and C
Andrew Tridgell [Wed, 1 Jul 2009 04:02:37 +0000 (14:02 +1000)]
use a talloc_unlink() as ops may have a reference
Andrew Tridgell [Wed, 1 Jul 2009 04:02:12 +0000 (14:02 +1000)]
fixed the reference to the global_schema
Andrew Tridgell [Wed, 1 Jul 2009 04:01:44 +0000 (14:01 +1000)]
removed a redundent talloc_steal
Andrew Tridgell [Wed, 1 Jul 2009 04:01:24 +0000 (14:01 +1000)]
fixed the use of talloc_steal in ntlmssp_server
The previous use of talloc_steal could cause a steal of a pointer that
had references. This ensures that doesn't happen
Andrew Tridgell [Wed, 1 Jul 2009 03:59:52 +0000 (13:59 +1000)]
fixed rpc smb code to not reply on talloc_free being a function pointer
The upcoming talloc_free/talloc_reference changes change talloc_free
to be a macro. These two bits of code relied on it being a function
pointer
Matthias Dieter Wallnöfer [Tue, 30 Jun 2009 11:54:45 +0000 (13:54 +0200)]
[SAMBA 4 directory] Corrects the "systemFlags" attributes
Set the values like Windows Server 2003 R2.
Matthias Dieter Wallnöfer [Tue, 30 Jun 2009 11:52:39 +0000 (13:52 +0200)]
[SAMBA 4 directory] Adds the complete "objectclass path" to our self-created DC object
Found after some comparisons against Windows Server 2003 R2.
Matthias Dieter Wallnöfer [Tue, 30 Jun 2009 11:34:09 +0000 (13:34 +0200)]
[SAMBA 4 directory] Adds the object version and "systemFlags" attribute to the display specifiers
The object version showed up in the Windows 2003 Server R2 AD.
The "systemFlags" attribute has been set to the right value.
Tim Prouty [Tue, 30 Jun 2009 23:59:57 +0000 (16:59 -0700)]
s3 docs: Add documentation for 'kerberos method' and 'dedicated keytab file' parameters
SATOH Fumiyasu [Tue, 30 Jun 2009 22:29:08 +0000 (15:29 -0700)]
Fix bug #6496 - MS-DFS: cannot follow multibyte char link name.
consumed_ucs is the number of bytes
of the UCS2 path consumed not counting any
terminating null. We need to convert
back to unix charset and count again
to get the number of bytes consumed from
the incoming path.
Günther Deschner [Tue, 30 Jun 2009 15:18:47 +0000 (17:18 +0200)]
s3-netlogon: remove unneeded fstrings from netlogon server.
Guenther
Jeff Layton [Tue, 30 Jun 2009 19:03:13 +0000 (15:03 -0400)]
umount.cifs: don't build it by default
Now that the sanity checks for mount.cifs default to matching the
behavior of /bin/mount, then there is virtually no need for umount.cifs.
The only exception is when someone enables the loose setuid behavior in
mount.cifs.
If an unprivileged user mounts a share that isn't in /etc/fstab, then
/bin/mount won't allow that user to unmount it. In that situation,
umount.cifs will be necessary to allow unmounting the share.
Signed-off-by: Jeff Layton <jlayton@samba.org>
Acked-by: Steve French <smfrench@us.ibm.com>
Volker Lendecke [Tue, 30 Jun 2009 18:42:15 +0000 (11:42 -0700)]
Fix bug #6431 - local groups from 3.0 setups no longer found.
Search for groups without group suffix, group suffix is only used for new entries.
Günther Deschner [Tue, 30 Jun 2009 11:12:01 +0000 (13:12 +0200)]
s3-spoolss: Bug #6512. Fix support for enumerating user forms.
Found while testing Xerox WorkCentre 133 PCL driver, now also tested with
torture test.
Guenther
Günther Deschner [Tue, 30 Jun 2009 11:11:16 +0000 (13:11 +0200)]
s4-smbtorture: Test for newly added form with enum call in RPC-SPOOLSS.
Guenther
Günther Deschner [Tue, 30 Jun 2009 09:38:41 +0000 (11:38 +0200)]
s4-smbtorture: remove trailing whitespace from RPC-SPOOLSS.
Guenther
Don Davis [Tue, 30 Jun 2009 08:12:02 +0000 (18:12 +1000)]
Rework the kerberos-notes.txt in order and format
This reworks the notes file to be less stream-of-consciousness and more
task for porting, with a very particular focus on a potential port of
Samba4 to use MIT Kerberos.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Andrew Bartlett [Tue, 30 Jun 2009 05:30:13 +0000 (15:30 +1000)]
s4:ldb Allow rootdse module to build without ldb_private.h
It seems quite reasonable to allow modules to re-initialise the set of
cached DNs on the ldb context.
Andrew Bartlett
Andrew Bartlett [Tue, 30 Jun 2009 05:12:29 +0000 (15:12 +1000)]
s4: dsdb Avoid using the internal ldb_private.h header
This job is not complete (the partition module remains a unfinished
task), but now we do use the private ldb headers much less.
Andrew Bartlett
Andrew Bartlett [Tue, 30 Jun 2009 02:11:14 +0000 (12:11 +1000)]
s4:heimdal Allow KRB5_NT_ENTERPRISE names in all DB lookups
The previous code only allowed an KRB5_NT_ENTERPRISE name (an e-mail
list user principal name) in an AS-REQ. Evidence from the wild
(Win2k8 reportadely) indicates that this is instead valid for all
types of requests.
While this is now handled in heimdal/kdc/misc.c, a flag is now defined
in Heimdal's hdb so that we can take over this handling in future (once we start
using a system Heimdal, and if we find out there is more to be done
here).
Andrew Bartlett
Andrew Bartlett [Tue, 30 Jun 2009 02:06:38 +0000 (12:06 +1000)]
s4:kdc Only get the lp_ctx once for a LDB_fetch()
Andrew Bartlett [Tue, 30 Jun 2009 00:29:30 +0000 (10:29 +1000)]
Rework hdb-samba4 to remove useless abstractions.
The function LDB_lookup_principal() has been eliminated, and it's
contents spread back to it's callers. Removing the abstraction makes
the code clearer.
Also ensure we never pass unescaped user input to a LDB search
function.
Andrew Bartlett
Andrew Bartlett [Tue, 30 Jun 2009 00:19:19 +0000 (10:19 +1000)]
s4:dsdb Explain the parsing steps for userPrincipalName cracknames calls
Günther Deschner [Mon, 29 Jun 2009 21:42:58 +0000 (23:42 +0200)]
s4-smbtorture: use torture_comment & torture_warning in RPC samr tests.
Guenther
Michael Adam [Mon, 29 Jun 2009 21:23:07 +0000 (23:23 +0200)]
s3:build: check for external liblua, link lua statically if using internal lib
So liblua is treated the same way as libtalloc and libtdb.
Michael
Günther Deschner [Tue, 23 Jun 2009 22:24:03 +0000 (00:24 +0200)]
s4-smbtorture: correctly test comment behaviour in RPC-SAMR-USERS against s3.
Guenther
Günther Deschner [Tue, 23 Jun 2009 22:23:09 +0000 (00:23 +0200)]
s3-pdb_tdb: give 'unknown_str' the proper name 'comment' and set comment in passdb.
pdb_{get,set}_comment were already existing in the API but were never used.
Guenther
Stefan Metzmacher [Mon, 29 Jun 2009 14:31:31 +0000 (16:31 +0200)]
s3:pdb_ads: we need to make the fd for tldap/tsocket non-blocking
metze
Michael Adam [Mon, 29 Jun 2009 14:26:42 +0000 (16:26 +0200)]
s3:fix build of old linux quota system and other unixes' quota implementation
By fixing the use of struct stat_ex.
Michael
Michael Adam [Mon, 29 Jun 2009 14:11:13 +0000 (16:11 +0200)]
s3:lib/sysquotas: fix usage of SMB_STRUCT_STAT (struct stat_ex).
This fixes the build with quotas / configure time detection
of sys_quota interface.
Michael
Michael Adam [Mon, 29 Jun 2009 13:39:46 +0000 (15:39 +0200)]
lib/util: fix building tevent_ntstatus without config.h
(when called from places with "#define NO_CONFIG_H" set, such as configure)
Michael
Stefan Metzmacher [Mon, 29 Jun 2009 11:13:05 +0000 (13:13 +0200)]
tsocket/bsd: also ask for TEVENT_FD_READ when we want to write into a stream socket
Otherwise we would not notice a broken connection.
metze