ira/wip.git
14 years agoMove talloc-appending a string to an array to its own helper function
Michael Adam [Sat, 29 Dec 2007 13:32:13 +0000 (14:32 +0100)]
Move talloc-appending a string to an array to its own helper function

libnet_smbconf_add_string_to_array().

Michael
(This used to be commit f4a4c1b26a03cd0f334e00912d32f15c73474ff1)

14 years agoFix uninitalized variables
Volker Lendecke [Sat, 29 Dec 2007 15:35:51 +0000 (16:35 +0100)]
Fix uninitalized variables
(This used to be commit 2322fe718728178990fdc3696b84f5de7ae7701b)

14 years agoAttempt to fix the AIX make test failures
Volker Lendecke [Sat, 29 Dec 2007 12:10:25 +0000 (13:10 +0100)]
Attempt to fix the AIX make test failures

For some reason AIX does not return the sender address in the AF_UNIX recvfrom.
So the faked netbios name lookup does not work with socket wrapper, nmbd can't
know where to send the reply. This patch works around this by telling smbclient
explicitly where to connect.

If there's any AIX experts listening -- how do I get the sender address from
AF_UNIX recvfrom?

Volker
(This used to be commit 8ba3b8cf7aca657ad8426981d810c36ee6a34a2f)

14 years agoFix a const warning.
Michael Adam [Sat, 29 Dec 2007 12:02:22 +0000 (13:02 +0100)]
Fix a const warning.

Michael
(This used to be commit e276e48177f890531ee8b4024c90352f284d4608)

14 years agoRename libnet_smbconf_getshares() to libnet_smbconf_get_share_names().
Michael Adam [Sat, 29 Dec 2007 11:55:42 +0000 (12:55 +0100)]
Rename libnet_smbconf_getshares() to libnet_smbconf_get_share_names().

Michael
(This used to be commit 9b3b9aa7e1044719a5112b9e5446e6fbdd7cecf9)

14 years agoAdd a comment header for libnet_smbconf_getshares().
Michael Adam [Sat, 29 Dec 2007 11:53:19 +0000 (12:53 +0100)]
Add a comment header for libnet_smbconf_getshares().

Michael
(This used to be commit 7b51535f2f76b5c3c18620ffd9ac64505357e6db)

14 years agoMove functionality of net_conf_listshares() to libnet_conf.c
Michael Adam [Sat, 29 Dec 2007 11:52:09 +0000 (12:52 +0100)]
Move functionality of net_conf_listshares() to libnet_conf.c

into new function libnet_smbconf_getshares().

Michael
(This used to be commit 306c7e4d9cecac4c2c0ea1172bd585c3c17d4541)

14 years agoMove functionality of net_conf_showshare() to libnet_conf.c
Michael Adam [Sat, 29 Dec 2007 02:38:13 +0000 (03:38 +0100)]
Move functionality of net_conf_showshare() to libnet_conf.c

The functionality is moved to a new function libnet_smbconf_getshare().
This returns the parameters of the given share as two lists: the list
of parameter names and the list of matching (formatted) parameter values.

The retrieval and formatting is done in a new internal helper function
libnet_smbconf_reg_get_values() that is to become the replacement for
list_values() from net_conf.c once functionality of net_conf_list() has
been moved to libnet_conf, too.

Michael
(This used to be commit 198232bd525cfac933b4885e6b330ebf4ac2c8ae)

14 years agopassdb.tdb is located in the private directory
Volker Lendecke [Mon, 24 Dec 2007 13:12:54 +0000 (14:12 +0100)]
passdb.tdb is located in the private directory

Jerry, as part of d6cdbfd87 the default location of passdb.tdb has changed from
the private directory to the state directory. I think because passdb.tdb holds
the password hashes, it is reasonable to keep this next to the smbpasswd file.

Please review and potentially push.

Thanks,

Volker
(This used to be commit c9c7607c402c0a9df9796c767b689d207d67d8e4)

14 years agoMake the main net_conf functions static in net_conf.c
Michael Adam [Sat, 29 Dec 2007 01:27:20 +0000 (02:27 +0100)]
Make the main net_conf functions static in net_conf.c

Michael
(This used to be commit dd6e09a65e67a9a16b35b078ebfb41da09926029)

14 years agoAdd a couple of comment headers to the main libnet_conf functions.
Michael Adam [Sat, 29 Dec 2007 01:26:33 +0000 (02:26 +0100)]
Add a couple of comment headers to the main libnet_conf functions.

Michael
(This used to be commit e9694ae20e1da1d8c1cbb252e630815b561647dd)

14 years agoAdd a comment header for libnet_smbconf_format_registry_value().
Michael Adam [Sat, 29 Dec 2007 01:18:44 +0000 (02:18 +0100)]
Add a comment header for libnet_smbconf_format_registry_value().

Michael
(This used to be commit 80e73407ea326cc68cd8728845c7a1c0907e2201)

14 years agoHandle NULL talloc context in libnet_smbconf_format_registry_value().
Michael Adam [Sat, 29 Dec 2007 01:16:38 +0000 (02:16 +0100)]
Handle NULL talloc context in libnet_smbconf_format_registry_value().

Maybe we should generate a new context instead of returning NULL?

Michael
(This used to be commit d7aaec713e17f93eed5177f0c3468deb625402a8)

14 years agoHide the registry backend from libnet_smbconf_getparm().
Michael Adam [Sat, 29 Dec 2007 01:12:33 +0000 (02:12 +0100)]
Hide the registry backend from libnet_smbconf_getparm().

Return a formatted string of the value instead.

Michael
(This used to be commit 7d0ec5bae155cda6620db04dcb7bd43db59241aa)

14 years agoRename format_value() to libnet_smbconf_format_registry_value().
Michael Adam [Sat, 29 Dec 2007 00:17:39 +0000 (01:17 +0100)]
Rename format_value() to libnet_smbconf_format_registry_value().

Michael
(This used to be commit 95d5dd9bb0546181cd499e6deabff562166412e3)

14 years agoMove format_value() to libnet_conf.c.
Michael Adam [Fri, 28 Dec 2007 23:05:23 +0000 (00:05 +0100)]
Move format_value() to libnet_conf.c.

Michael
(This used to be commit 3422a5048ad4b7f789ec233356885d78dbdacf9a)

14 years agoConvert get_root_nt_token to memcache
Volker Lendecke [Fri, 28 Dec 2007 16:24:39 +0000 (17:24 +0100)]
Convert get_root_nt_token to memcache
(This used to be commit fada689893314bed2fc78588b3fd9b144f4c808a)

14 years agoRemove a global
Volker Lendecke [Fri, 28 Dec 2007 16:16:35 +0000 (17:16 +0100)]
Remove a global
(This used to be commit 515f6a8cff7e28b0e98136f3214ef52512cfaf37)

14 years agodon't store cache_readonly in gencache
Volker Lendecke [Fri, 28 Dec 2007 16:09:57 +0000 (17:09 +0100)]
don't store cache_readonly in gencache

tdb won't allow us to write anyway
(This used to be commit 069cd6d63a61065be7926230235e198c456d38ae)

14 years agoRemove static zeros
Volker Lendecke [Fri, 28 Dec 2007 16:02:34 +0000 (17:02 +0100)]
Remove static zeros
(This used to be commit dbcc213710a9af31b6094d4741a6f68f573dcdad)

14 years agoRemove a static array
Volker Lendecke [Fri, 28 Dec 2007 16:02:07 +0000 (17:02 +0100)]
Remove a static array

This might be worth it, mangle_hash is hardly used these days
(This used to be commit 44775ea38bc320ac8e2208769a8cde2c6f44f640)

14 years agoConvert csamuser to memcache
Volker Lendecke [Fri, 28 Dec 2007 12:13:29 +0000 (13:13 +0100)]
Convert csamuser to memcache
(This used to be commit 476d3abf9c6142d99822212141fc3d843aca4798)

14 years agobin/vlp needs a dependency on @LIBWBCLIENT_SHARED@
Volker Lendecke [Sat, 22 Dec 2007 11:02:33 +0000 (12:02 +0100)]
bin/vlp needs a dependency on @LIBWBCLIENT_SHARED@

This failed to link if you compile with -j.
(This used to be commit fed8f2abd704d1993146ad462d81f69367537cfb)

14 years agoImprove error messages of 'net rpc user [add|delete]' commands.
Karolin Seeger [Thu, 27 Dec 2007 13:08:40 +0000 (14:08 +0100)]
Improve error messages of 'net rpc user [add|delete]' commands.

Karolin
(This used to be commit 4260c79bf7687bd2ebcc4ca5e0a5f020a759c1fb)

14 years agoEnsure we turn off POSIX large read/write if encryption
Jeremy Allison [Fri, 28 Dec 2007 08:02:13 +0000 (00:02 -0800)]
Ensure we turn off POSIX large read/write if encryption
is mandatory or signing is on.
Jeremy.
(This used to be commit 5088b704791be2f36641fa0ec59dff7f289ae868)

14 years agoAdd the capability to set "smb encrypt = required"
Jeremy Allison [Fri, 28 Dec 2007 07:51:03 +0000 (23:51 -0800)]
Add the capability to set "smb encrypt = required"
on a share (or global) and have the server reply with
ACCESS_DENIED for all non-encrypted traffic (except
that used to query encryption requirements and set
encryption state).
Jeremy.
(This used to be commit d241bfa57729bb934ada6beabf842a2ca7b4f8a2)

14 years agoFix setting the initial permission bits
Volker Lendecke [Thu, 27 Dec 2007 20:31:08 +0000 (21:31 +0100)]
Fix setting the initial permission bits

This fixes a make test failure on Solaris. When creating a new file,
file_set_dosmode() called from open_file_ntcreate calculates a new permission
mask, very likely different from what had been calculated in
open_file_ntcreate. Further down we overwrote the newly calculated value with
SMB_FCHMOD_ACL, ignoring what file_set_dosmode had calculated.

Why did Linux not see this? fchmod_acl on a newly created file without acls
would not retrieve an acl at all, whereas under Solaris acl(2) returns
something even for files with just posix permissions returns something.

Jeremy, given that we have very similar code in 3.0.28 this might also explain
some of the bug reports that people have concerning ACLs on new files.

Volker

P.S: This one took a while to find...
(This used to be commit 2135dfe91bf1ae114a18c15286b535662200677d)

14 years agoAdd "smb encrypt" parameter. Can be set to "no, yes, required".
Jeremy Allison [Fri, 28 Dec 2007 00:54:07 +0000 (16:54 -0800)]
Add "smb encrypt" parameter. Can be set to "no, yes, required".
Currently if set required this is not enforced. I'll be adding
that soon.
Jeremy.
(This used to be commit df7e447623ac03d81bec384f5cfe83c3976cf7b2)

14 years agoFix the non-gcc branch of "likely"
Volker Lendecke [Thu, 27 Dec 2007 23:12:14 +0000 (00:12 +0100)]
Fix the non-gcc branch of "likely"
(This used to be commit 1e07368b5f96e4ada622682e38d260eb0c6185f2)

14 years agoRemove a silly static
Volker Lendecke [Thu, 27 Dec 2007 20:30:15 +0000 (21:30 +0100)]
Remove a silly static
(This used to be commit ef75dcc9ffda85d77c8f22d0db702efbf8e642ed)

14 years agoFix the build
Volker Lendecke [Thu, 27 Dec 2007 18:56:44 +0000 (19:56 +0100)]
Fix the build
(This used to be commit 7fb858b350856d626fed6f062029fcf09b8251e2)

14 years agoWrap the DEBUG checks in a "unlikely"
Volker Lendecke [Thu, 27 Dec 2007 16:41:19 +0000 (17:41 +0100)]
Wrap the DEBUG checks in a "unlikely"

On my Laptop with some limited netbench runs this gains about 1.5% of
performance. When looking at the assembler output I would suspect the biggest
gain is by the fact that with this in place the calls to the debug functions is
moved to the function end, out of the way of the normal code paths. valgrind
tests pending I would suspect this to be much more cache friendly.

Comments?

Volker
(This used to be commit 51448a9dca95de9d35dd8eea68fde2554cb69921)

14 years agoAdd CIFS_UNIX_TRANSPORT_ENCRYPTION_CAP capability to
Jeremy Allison [Thu, 27 Dec 2007 18:18:22 +0000 (10:18 -0800)]
Add CIFS_UNIX_TRANSPORT_ENCRYPTION_CAP capability to
our reported caps.
Jeremy.
(This used to be commit e86d027823c85173c64e7b85406e98f6f7345b10)

14 years agoEncryption works better when you add the client decrypt code :-).
Jeremy Allison [Thu, 27 Dec 2007 01:17:36 +0000 (17:17 -0800)]
Encryption works better when you add the client decrypt code :-).
Jeremy.
(This used to be commit d67b2634068be9c69082a2b8c22c831aba371cd9)

14 years agoAdd SMB encryption. Still fixing client decrypt but
Jeremy Allison [Thu, 27 Dec 2007 01:12:36 +0000 (17:12 -0800)]
Add SMB encryption. Still fixing client decrypt but
negotiation works.
Jeremy.
(This used to be commit d78045601af787731f0737b8627450018902b104)

14 years agotypos
Volker Lendecke [Wed, 26 Dec 2007 23:22:07 +0000 (00:22 +0100)]
typos
(This used to be commit 30fa3477c8f810d8f2b4c4be218509544735274c)

14 years agoFix some memleaks
Volker Lendecke [Wed, 26 Dec 2007 22:44:24 +0000 (23:44 +0100)]
Fix some memleaks
(This used to be commit 78b0b66cbac349625257260d2e45d918e0c93617)

14 years agoRemove the sampwent interface
Volker Lendecke [Wed, 26 Dec 2007 16:58:55 +0000 (17:58 +0100)]
Remove the sampwent interface
(This used to be commit 9e80b969fb40766de2c9b1a05d16bf4d4c6e46f7)

14 years agoConvert pdbedit to use pdb_search_users
Volker Lendecke [Wed, 26 Dec 2007 16:45:49 +0000 (17:45 +0100)]
Convert pdbedit to use pdb_search_users
(This used to be commit 8a8f2583b8bda22f65c7483dea54ac823ed1c0c3)

14 years agoProperly destroy the pdb search object
Volker Lendecke [Wed, 26 Dec 2007 16:06:06 +0000 (17:06 +0100)]
Properly destroy the pdb search object
(This used to be commit 514cf532248723e7f775dc5f8f2e6936e02b7a1c)

14 years agosmbpasswd_search_users
Volker Lendecke [Mon, 24 Dec 2007 23:04:39 +0000 (00:04 +0100)]
smbpasswd_search_users
(This used to be commit 84af4fb65677cf137f14f57c8820c77c9d006d89)

14 years agoAdd tdbsam_search_users
Volker Lendecke [Mon, 24 Dec 2007 11:58:40 +0000 (12:58 +0100)]
Add tdbsam_search_users
(This used to be commit 02f0b0bd393bd942fc934f251bd6afed8e5424b0)

14 years agoWe need to return the correct atime
Volker Lendecke [Wed, 26 Dec 2007 13:18:11 +0000 (14:18 +0100)]
We need to return the correct atime

On systems with nanosecond atime we need to re-stat after messing with the fd,
at least Solaris 10 updates atime after we stat(2)ed the file.
(This used to be commit 6e6ec0a563f8b7e3d4618ce60e776bcce53f40c4)

14 years agoMove libnet_smbconf_reg_open_basepath() in source file
Michael Adam [Wed, 26 Dec 2007 00:03:28 +0000 (01:03 +0100)]
Move libnet_smbconf_reg_open_basepath() in source file

to group helper functions more logically.

Michael
(This used to be commit 3fa3891f8721e9f02594cd1be2dc6b9b88692416)

14 years agoRename libnet_smbconf_open_basepath() to libnet_smbconf_reg_open_basepath().
Michael Adam [Wed, 26 Dec 2007 00:01:14 +0000 (01:01 +0100)]
Rename libnet_smbconf_open_basepath() to libnet_smbconf_reg_open_basepath().

Michael
(This used to be commit 4c0e7270c42788e7f77c402032ae74cf0f8a7106)

14 years agoRename libnet_smbconf_open_path() to libnet_smbconf_reg_open_path().
Michael Adam [Tue, 25 Dec 2007 23:58:11 +0000 (00:58 +0100)]
Rename libnet_smbconf_open_path() to libnet_smbconf_reg_open_path().

Michael
(This used to be commit 4b0e636965bd37e7c0deecb7b5eff0cc4487408b)

14 years agoRename libnet_smbconf_open_path_q() to libnet_smbconf_open_path()
Michael Adam [Tue, 25 Dec 2007 23:53:19 +0000 (00:53 +0100)]
Rename libnet_smbconf_open_path_q() to libnet_smbconf_open_path()

removing previouse libnet_smbconf_open_path() and adding
DEBUG output (instead of d_fprintf error output) to new
libnet_smbconf_open_path().

Michael
(This used to be commit e63cc54fab8a0b03573f76305eab366a3ee4eda1)

14 years agoHost SerNet-AIX has __ss_family instead of ss_family in sockaddr_storage
Volker Lendecke [Tue, 25 Dec 2007 17:37:42 +0000 (18:37 +0100)]
Host SerNet-AIX has __ss_family instead of ss_family in sockaddr_storage
(This used to be commit e33286f4a68352e55df081d06307f64f190773b3)

14 years agoAIX iface test needs rep_vasprintf
Volker Lendecke [Tue, 25 Dec 2007 17:36:49 +0000 (18:36 +0100)]
AIX iface test needs rep_vasprintf
(This used to be commit 3e5788cc9665acb450be793fb88db8e2a871aaa5)

14 years agoifreq needs more from lib/replace
Volker Lendecke [Tue, 25 Dec 2007 13:19:50 +0000 (14:19 +0100)]
ifreq needs more from lib/replace
(This used to be commit e85290550ad33433f584009ffce34c81bea5b164)

14 years agoNext try to fix get_interfaces detection
Volker Lendecke [Tue, 25 Dec 2007 12:49:17 +0000 (13:49 +0100)]
Next try to fix get_interfaces detection
(This used to be commit 2dc0282f245c62b83b80f8da0394201e1c00f284)

14 years agomake clean should remove everything in bin/
Volker Lendecke [Tue, 25 Dec 2007 12:34:14 +0000 (13:34 +0100)]
make clean should remove everything in bin/

Jerry, you might want to review/change removing libwbclient.so.0
(This used to be commit 768e0439507caeff430358eb24dc9288a21c8a03)

14 years agoInterface detection should not go through the socket wrapper
Volker Lendecke [Tue, 25 Dec 2007 11:00:53 +0000 (12:00 +0100)]
Interface detection should not go through the socket wrapper

Next try to get the build farm more in line again than it is now
(This used to be commit 38e178df12d30672f74bf272338954c7917b59e3)

14 years agoRevert "Attempt to fix the ifreq detection"
Volker Lendecke [Tue, 25 Dec 2007 10:59:34 +0000 (11:59 +0100)]
Revert "Attempt to fix the ifreq detection"

This reverts commit 2d08959685b495caf1884babbece27775d8bcb4f.
(This used to be commit acb560900be29c407e7da955d16c2de7898e49b8)

14 years agoFix the build
Volker Lendecke [Tue, 25 Dec 2007 10:34:10 +0000 (11:34 +0100)]
Fix the build
(This used to be commit 72dc71710813ea9f1d8864c4401fef25a25577bd)

14 years agoRemove now unneeded talloc ctx parameter from do_JoinConfig().
Michael Adam [Tue, 25 Dec 2007 02:41:34 +0000 (03:41 +0100)]
Remove now unneeded talloc ctx parameter from do_JoinConfig().

Michael
(This used to be commit be985d8d0ce80d12aa7f0b447b16b14aa0362826)

14 years agoRemove now unneeded talloc ctx parameter from do_join_modify_vals_config().
Michael Adam [Tue, 25 Dec 2007 02:40:35 +0000 (03:40 +0100)]
Remove now unneeded talloc ctx parameter from do_join_modify_vals_config().

Michael
(This used to be commit f8823ae1232022ed3f7f9be6b8959d413e8aed19)

14 years agoRemove now unneeded talloc ctx parameter from do_UnjoinConfig().
Michael Adam [Tue, 25 Dec 2007 02:39:31 +0000 (03:39 +0100)]
Remove now unneeded talloc ctx parameter from do_UnjoinConfig().

Michael
(This used to be commit 92b8e5ea4ba26d663ea4e6fb65e4225d8259ea60)

14 years agoRemove now unneeded talloc ctx parameter from do_unjoin_modify_vals_config().
Michael Adam [Tue, 25 Dec 2007 02:38:06 +0000 (03:38 +0100)]
Remove now unneeded talloc ctx parameter from do_unjoin_modify_vals_config().

Michael
(This used to be commit 4f7375a110a69530d6ef9781573f45a5bf8391a5)

14 years agoAdd two missing free-s.
Michael Adam [Tue, 25 Dec 2007 02:35:00 +0000 (03:35 +0100)]
Add two missing free-s.

Michael
(This used to be commit 4efac39c363d565c2c7211da73d5e1cf2ac3d0b2)

14 years agoRemove talloc context parameter from libnet_smbconf_delparm().
Michael Adam [Tue, 25 Dec 2007 02:34:04 +0000 (03:34 +0100)]
Remove talloc context parameter from libnet_smbconf_delparm().

Make use of talloc stackframe internally.
This removes talloc contxt from net_conf_delparm.

Michael
(This used to be commit 16f137393881edc78c9322f038ba38e53e3ee07d)

14 years agoAdd a missing free.
Michael Adam [Tue, 25 Dec 2007 02:29:41 +0000 (03:29 +0100)]
Add a missing free.

Michael
(This used to be commit bf6031287f75a0e17092f60f9885e7e55cd0f93c)

14 years agoRemove talloc context parameter from libnet_smbconf_setparm().
Michael Adam [Tue, 25 Dec 2007 02:29:05 +0000 (03:29 +0100)]
Remove talloc context parameter from libnet_smbconf_setparm().

Make use of talloc stackframe internally.
This removes talloc contxt from net_conf_setparm.

Michael
(This used to be commit efaffefc438f8375a083b194ac7a09e563000d3c)

14 years agoTypofix in comment.
Michael Adam [Tue, 25 Dec 2007 02:16:25 +0000 (03:16 +0100)]
Typofix in comment.

Michael
(This used to be commit 5039a70246a475176fa8212ad78b430f2211951f)

14 years agoAdd comment header to function libnet_smbconf_drop().
Michael Adam [Tue, 25 Dec 2007 02:08:00 +0000 (03:08 +0100)]
Add comment header to function libnet_smbconf_drop().

Michael
(This used to be commit e94edb6bdbc9379b48679d7c72618acfe862fe52)

14 years agoRemove a d_fprintf() from libnet_smbconf_drop().
Michael Adam [Tue, 25 Dec 2007 02:06:48 +0000 (03:06 +0100)]
Remove a d_fprintf() from libnet_smbconf_drop().

Michael
(This used to be commit 078e5e98b3589cec78893d44146a653dad9a7460)

14 years agoRemove talloc context parameter from libnet_smbconf_drop().
Michael Adam [Tue, 25 Dec 2007 02:05:06 +0000 (03:05 +0100)]
Remove talloc context parameter from libnet_smbconf_drop().

Make use of talloc_stackframe.

Michael
(This used to be commit aaceab1153f6c2a2adde83681913c771a16ca81f)

14 years agoRename drop_smbconf_internal() to libnet_smbconf_drop().
Michael Adam [Tue, 25 Dec 2007 02:01:59 +0000 (03:01 +0100)]
Rename drop_smbconf_internal() to libnet_smbconf_drop().

Michael
(This used to be commit 5873e6a1f8242e07b1699366a536350a7199c28c)

14 years agoMove drop_smbconf_internal() to libnet_conf.c
Michael Adam [Tue, 25 Dec 2007 01:55:07 +0000 (02:55 +0100)]
Move drop_smbconf_internal() to libnet_conf.c

Michael
(This used to be commit 4c2a3396bb687703f6b74655fda2014d1f75200b)

14 years agoUse the proper boolean constants in net_conf.c
Michael Adam [Tue, 25 Dec 2007 01:48:45 +0000 (02:48 +0100)]
Use the proper boolean constants in net_conf.c

Michael
(This used to be commit 1fe4ea63b197cb7ebc054909d888d74b5ad6523c)

14 years agoAdd error reporting to net_conf_delshare().
Michael Adam [Tue, 25 Dec 2007 01:42:33 +0000 (02:42 +0100)]
Add error reporting to net_conf_delshare().

Michael
(This used to be commit 8d02a2de61eb6b62fef1fbe57194c9d286423ba0)

14 years agoSimplify libnet_smbconf_delshare().
Michael Adam [Tue, 25 Dec 2007 01:31:41 +0000 (02:31 +0100)]
Simplify libnet_smbconf_delshare().

Remove talloc context parameter.
Remove d_printf error message.

Michael
(This used to be commit 870d35c04889603843bae989fb9c01396b4c6ed1)

14 years agoRename reg_delkey_internal() to libnet_smbconf_delshare().
Michael Adam [Tue, 25 Dec 2007 01:24:39 +0000 (02:24 +0100)]
Rename reg_delkey_internal() to libnet_smbconf_delshare().

Michael
(This used to be commit 7d501f0d78ec57509d0bc5ef0dc16fcd24ee27e7)

14 years agoMove reg_delkey_internal() to libnet/libnet_conf.c
Michael Adam [Tue, 25 Dec 2007 01:21:30 +0000 (02:21 +0100)]
Move reg_delkey_internal() to libnet/libnet_conf.c

Michael
(This used to be commit c1b863fd0520ce64a1bad5e2fa3f69afcc2c78d5)

14 years agoAttempt to fix the ifreq detection
Volker Lendecke [Mon, 24 Dec 2007 23:12:18 +0000 (00:12 +0100)]
Attempt to fix the ifreq detection
(This used to be commit 2d08959685b495caf1884babbece27775d8bcb4f)

14 years agoDo not leak memory in libnet_smbconf_delparm().
Michael Adam [Mon, 24 Dec 2007 00:03:14 +0000 (01:03 +0100)]
Do not leak memory in libnet_smbconf_delparm().

Michael
(This used to be commit 49cfe2b9ebe03d5985187890445b775047f8a2f4)

14 years agoDo not leak memory in libnet_smbconf_setparm().
Michael Adam [Mon, 24 Dec 2007 00:00:46 +0000 (01:00 +0100)]
Do not leak memory in libnet_smbconf_setparm().

Michael
(This used to be commit a657b1c9f17d3cebc86b596f1f2d244750d70a6d)

14 years agoUse the appropriate boolean constants.
Michael Adam [Sun, 23 Dec 2007 23:57:04 +0000 (00:57 +0100)]
Use the appropriate boolean constants.

Michael
(This used to be commit 45e3e2451adc1490b62d39d486c169ad53e1d3f3)

14 years agoMake libnet_smbconf_value_exists() use talloc_stackframe().
Michael Adam [Sun, 23 Dec 2007 23:56:24 +0000 (00:56 +0100)]
Make libnet_smbconf_value_exists() use talloc_stackframe().

And not pass a talloc context.

Michael
(This used to be commit 2983aba9d092e6ede43f6eb521c17fe3f304d041)

14 years agoMake libnet_smbconf_key_exists() use talloc_stackframe().
Michael Adam [Sun, 23 Dec 2007 23:53:22 +0000 (00:53 +0100)]
Make libnet_smbconf_key_exists() use talloc_stackframe().

And not pass a talloc context.

Michael
(This used to be commit 7e8451f2f03b246801783aaf4b3d54465292f8f7)

14 years agoDon't leak memory in libnet_smbconf_getparm().
Michael Adam [Sun, 23 Dec 2007 23:47:43 +0000 (00:47 +0100)]
Don't leak memory in libnet_smbconf_getparm().

Michael
(This used to be commit 09e62c765401102480d39a483bfffaf5a054babc)

14 years agoFix rights error in libnet_smbconf_delparm().
Michael Adam [Sun, 23 Dec 2007 22:58:58 +0000 (23:58 +0100)]
Fix rights error in libnet_smbconf_delparm().

Introduced by additional test for existence of given parameter.

Michael
(This used to be commit 0fe095e85ca981e5660a67f3fb7d7965ae62c667)

14 years agoRemove redundant check of return value.
Michael Adam [Sun, 23 Dec 2007 22:02:47 +0000 (23:02 +0100)]
Remove redundant check of return value.

Michael
(This used to be commit 29f46c2d45e7ad7f8a9a525f9ac82c050a510967)

14 years agoMove logic of net_conf_getparm() to libnet_conf.c.
Michael Adam [Sun, 23 Dec 2007 14:07:20 +0000 (15:07 +0100)]
Move logic of net_conf_getparm() to libnet_conf.c.

Michael
(This used to be commit d3a20c4d5a8109334cd3ed665ba60cfcc4425059)

14 years agoselftest: also export LD_LIBRARY_PATH for samba4's smbtorture
Stefan Metzmacher [Sun, 23 Dec 2007 19:09:16 +0000 (20:09 +0100)]
selftest: also export LD_LIBRARY_PATH for samba4's smbtorture

metze
(This used to be commit f5570dcf503a4b28ebf624d06fd090f3b6b0a560)

14 years agoAttempt to make the build farm run s4torture again
Volker Lendecke [Sun, 23 Dec 2007 15:38:28 +0000 (16:38 +0100)]
Attempt to make the build farm run s4torture again
(This used to be commit 04710626e174d7237521f33a351b4425add063b8)

14 years agoAttempt to fix the Solaris build
Volker Lendecke [Sun, 23 Dec 2007 14:53:09 +0000 (15:53 +0100)]
Attempt to fix the Solaris build

Lets see what the others in the build farm think about this
(This used to be commit c2a988d8427b7598291ae6999b5258e2b6a2e7cb)

14 years agoConvert the [gu]id_sid cache to memcache
Volker Lendecke [Sat, 22 Dec 2007 13:52:34 +0000 (14:52 +0100)]
Convert the [gu]id_sid cache to memcache
(This used to be commit 4baf36784f6496121a6863af0283821785eb0cf1)

14 years agoRename libnet_reg_createkey_internal() to libnet_smbconf_reg_createkey_internal().
Michael Adam [Sun, 23 Dec 2007 03:10:15 +0000 (04:10 +0100)]
Rename libnet_reg_createkey_internal() to libnet_smbconf_reg_createkey_internal().

Michael
(This used to be commit 0e7f215f54c68b2d40f65f90ed11c41e1a7ef5ed)

14 years agoMake libnet_smbconf_set_global_param() call libnet_smbconf_setparm().
Michael Adam [Sun, 23 Dec 2007 02:52:00 +0000 (03:52 +0100)]
Make libnet_smbconf_set_global_param() call libnet_smbconf_setparm().

This not only removes duplicate logic, but also the use of
libnet_smbconf_reg_setvalue_internal() instead of do_modify_val_config()
which is removed, does add important tests and canonicalizations.

Michael
(This used to be commit fa844866493ee270f31faa3eca77cdff16b26301)

14 years agoReorder libnet_conf.c some, adding "section" comments.
Michael Adam [Sun, 23 Dec 2007 02:47:16 +0000 (03:47 +0100)]
Reorder libnet_conf.c some, adding "section" comments.

Michael
(This used to be commit b9f22adfd3e67046b7d786b5b338e078b4cdc6df)

14 years agoMove net_conf_setparm() to libnet_conf.c
Michael Adam [Sun, 23 Dec 2007 02:41:55 +0000 (03:41 +0100)]
Move net_conf_setparm() to libnet_conf.c

renaming it to libnet_smbconf_setparm()

Michael
(This used to be commit 60f49b22b5aa125ff6cb358a258a1be99c378d7a)

14 years agoMove reg_setvalue_internal() to libnet_conf.c
Michael Adam [Sun, 23 Dec 2007 02:34:36 +0000 (03:34 +0100)]
Move reg_setvalue_internal() to libnet_conf.c

renaming it to libnet_smbconf_setvalue_internal()

Michael
(This used to be commit 7cb51a1d6d95704225d9ab22e88cc76fa910d38c)

14 years agoRemove occurrences of registry_key from libnet_join.c
Michael Adam [Sun, 23 Dec 2007 02:13:30 +0000 (03:13 +0100)]
Remove occurrences of registry_key from libnet_join.c

Replace duplicated logic by calls of libnet_smbconf_set_global_param()
from libnet_conf.c, pushing logic from do_JoinConfig() and do_UnjoinConfig()
to do_join_modify_vals_config() and do_unjoin_modify_vals_config()
respectively.

Only the net_conf api functions should be exported by libnet_conf.c, not
the lower level registry access functions.

Michael
(This used to be commit 81b9f1301d61f05f9153be61d62c13e82cecf7e2)

14 years agoReplace direct deletion of registry value by use of libnet_smbconf_delparm().
Michael Adam [Sun, 23 Dec 2007 02:02:19 +0000 (03:02 +0100)]
Replace direct deletion of registry value by use of libnet_smbconf_delparm().

Michael
(This used to be commit 415fc0a5261f4d941027e5d5305fcea882724aef)

14 years agoMove logic of net_smbconf_delparm() to libnet/libnet_conf.c
Michael Adam [Sun, 23 Dec 2007 01:55:25 +0000 (02:55 +0100)]
Move logic of net_smbconf_delparm() to libnet/libnet_conf.c

Logic in new function libnet_smbconf_delparm().

Michael
(This used to be commit 0cff79e3552e91ba0b6bc054802d28afcf4e8da4)

14 years agoMove smbconf_value_exists() to libnet/net_conf.c
Michael Adam [Sun, 23 Dec 2007 01:44:29 +0000 (02:44 +0100)]
Move smbconf_value_exists() to libnet/net_conf.c

renaming it to libnet_smbconf_value_exists().

Michael
(This used to be commit ba71c6844588f0342589163f514385911e7331e7)

14 years agoMake libnet_smbconf_open_path_q() static.
Michael Adam [Sun, 23 Dec 2007 00:43:13 +0000 (01:43 +0100)]
Make libnet_smbconf_open_path_q() static.

Michael
(This used to be commit 8cf8ed9de8c3f41588fa93bd102f61f5b8b493c4)

14 years agoIf we detect a case insensitive filesystem make
Jeremy Allison [Sun, 23 Dec 2007 01:38:18 +0000 (17:38 -0800)]
If we detect a case insensitive filesystem make
sure we don't search directories on name misses
for non-mangled names.
Jeremy
(This used to be commit 120048d2f40cf1a0ace2ecde205cbc694d263d69)

14 years agoFix typo in output.
Michael Adam [Sun, 23 Dec 2007 00:34:20 +0000 (01:34 +0100)]
Fix typo in output.

Michael
(This used to be commit 2fe111c19bc827ec132365e718a2136bda57e568)