Volker Lendecke [Fri, 21 Mar 2008 10:48:09 +0000 (11:48 +0100)]
Fix Coverity ID 506
Volker Lendecke [Fri, 21 Mar 2008 10:45:57 +0000 (11:45 +0100)]
Fix Coverity ID 507
Volker Lendecke [Fri, 21 Mar 2008 10:42:42 +0000 (11:42 +0100)]
Fix Coverity ID 537
Volker Lendecke [Fri, 21 Mar 2008 10:41:15 +0000 (11:41 +0100)]
Fix Coverity ID 538
Volker Lendecke [Fri, 21 Mar 2008 09:40:40 +0000 (10:40 +0100)]
Fix Coverity ID 547
Günther, please check. If r->in.ads==NULL, we can't call ads_leave_realm at
all.
Thanks,
Volker
Volker Lendecke [Fri, 21 Mar 2008 09:28:33 +0000 (10:28 +0100)]
Fix Coverity ID 548
Günther, please check -- in all infolevels we do a comment=talloc_strdup
Thanks,
Volker
Volker Lendecke [Fri, 21 Mar 2008 09:20:53 +0000 (10:20 +0100)]
Fix Coverity IDs 553, 552
Günther Deschner [Fri, 21 Mar 2008 03:13:49 +0000 (04:13 +0100)]
Add my copyright.
Guenther
Günther Deschner [Fri, 21 Mar 2008 03:12:52 +0000 (04:12 +0100)]
Remove remaining old srvsvc client and server rpc code entirely.
Guenther
Günther Deschner [Fri, 21 Mar 2008 02:59:02 +0000 (03:59 +0100)]
Remove double RPC_PARSE_OBJ2 from Makefile.
Guenther
Günther Deschner [Fri, 21 Mar 2008 02:56:54 +0000 (03:56 +0100)]
Move MAX.*ENTRY definitions out of old rpc srvsvc parsing code.
Guenther
Günther Deschner [Fri, 21 Mar 2008 02:53:18 +0000 (03:53 +0100)]
Remove unused marshalling for SRV_NET_SESS_ENUM.
Guenther
Günther Deschner [Fri, 21 Mar 2008 02:51:37 +0000 (03:51 +0100)]
Use pidl for _srvsvc_NetSessEnum().
Guenther
Günther Deschner [Fri, 21 Mar 2008 02:50:49 +0000 (03:50 +0100)]
Add support for setting resume handle in netsessenum rpcclient command.
Guenther
Günther Deschner [Fri, 21 Mar 2008 01:01:58 +0000 (02:01 +0100)]
Remove unused marshalling for SRV_NET_CONN_ENUM.
Guenther
Günther Deschner [Fri, 21 Mar 2008 00:58:43 +0000 (01:58 +0100)]
Use pidl for _srvsvc_NetConnEnum().
Guenther
Günther Deschner [Fri, 21 Mar 2008 00:14:23 +0000 (01:14 +0100)]
Allow to set or unset resume_handle in netconnenum in rpcclient.
Guenther
Michael Adam [Fri, 21 Mar 2008 01:29:09 +0000 (02:29 +0100)]
libsmbconf: reformaat - fix some whispacing/tabs
Michael
Michael Adam [Fri, 21 Mar 2008 01:20:16 +0000 (02:20 +0100)]
libsmbconf: add backend specific init function.
Hide generic init function taking smbconf_ops argument
from public api.
Michael
Michael Adam [Fri, 21 Mar 2008 01:01:55 +0000 (02:01 +0100)]
libsmbconf: add shutdown handler to smbconf_ops.
Michael
Michael Adam [Fri, 21 Mar 2008 00:15:20 +0000 (01:15 +0100)]
libsmbconf: fix comments
Michael
Michael Adam [Fri, 21 Mar 2008 00:04:57 +0000 (01:04 +0100)]
libsmbconf: rename smbconf_close() to smbconf_shutdown().
Michael
Michael Adam [Thu, 20 Mar 2008 22:41:39 +0000 (23:41 +0100)]
libsmbconf: rename smbconf_open() to smbconf_init().
That's more appropriate.
Michael
Michael Adam [Thu, 20 Mar 2008 17:40:09 +0000 (18:40 +0100)]
libsmbconf: add open and close operations to the smbconf_ops.
Note: currently, reg_init_smbconf opens the registry, but does
not close it. This has to be changed. so that it is closed.
And then libsmbconf will need these open/close functions
Michael
Michael Adam [Thu, 20 Mar 2008 11:28:41 +0000 (12:28 +0100)]
libsmbconf: introduce a smbconf_ops layer to allow interchangeable backends.
Michael
Michael Adam [Thu, 20 Mar 2008 11:25:44 +0000 (12:25 +0100)]
libsmbconf: move smbconf_reg_initialize() down to the smbconf operations.
Michael
Michael Adam [Thu, 20 Mar 2008 10:54:30 +0000 (11:54 +0100)]
libsmbconf: add existence check for service to smbconf_delete_share().
Michael
Michael Adam [Thu, 20 Mar 2008 10:53:40 +0000 (11:53 +0100)]
libsmbconf: add existence check for service to smbconf_get_share().
Michael
Michael Adam [Thu, 20 Mar 2008 10:52:13 +0000 (11:52 +0100)]
libsmbconf: add check for NULL servicename to smbconf_share_exists().
Michael
Michael Adam [Thu, 20 Mar 2008 10:50:06 +0000 (11:50 +0100)]
libsmbconf: fix a comment
Michael Adam [Thu, 20 Mar 2008 10:49:26 +0000 (11:49 +0100)]
libsmbconf: refactor out registry implementation of smbconf operations.
This leaves most of the api functions mere wrappers except for some
common initial checks.
Michael
Michael Adam [Thu, 20 Mar 2008 09:43:17 +0000 (10:43 +0100)]
libsmbconf: refactor autocreation of [global] into a helper function.
Michael
Michael Adam [Wed, 19 Mar 2008 11:37:17 +0000 (12:37 +0100)]
libsmbconf: put the smbconf context struct into a private header.
Michael
Michael Adam [Wed, 19 Mar 2008 09:47:23 +0000 (10:47 +0100)]
libsmbconf: change the API to always take the smbconf_ctx parameter first.
..for consistency. Exception: the open/init function, where the smbconf_ctx
is created from the given talloc context.
Michael
Michael Adam [Wed, 19 Mar 2008 09:15:16 +0000 (10:15 +0100)]
libsmbconf: fix indentation.
Michael
Michael Adam [Tue, 18 Mar 2008 22:29:11 +0000 (23:29 +0100)]
libsmbconf: change smbconf_get_seqnum() to smbconf_changed().
The former seqnum is hidden inside a struct smbconf_csn.
And the get_seqnum is united with a changed function that
stores the seqnum inside the given csn.
Michael
Michael Adam [Mon, 17 Mar 2008 23:51:15 +0000 (00:51 +0100)]
libsmbconf: fix a comment
Michael
Volker Lendecke [Thu, 20 Mar 2008 20:58:39 +0000 (21:58 +0100)]
A level 25 setuserinfo does change the pwdlastset
Michael Adam [Thu, 20 Mar 2008 15:50:52 +0000 (16:50 +0100)]
smbd: fix session setup with security = share.
Broken by pstring removal in
9ed12bfc48fe7f9b1863a9dd88e881974083053c.
Jeremy, please check.
Thanks to Yannick Bergeron <yaberger@ca.ibm.com> for noting this.
Michael
Volker Lendecke [Thu, 20 Mar 2008 15:15:38 +0000 (16:15 +0100)]
Fix an uninitialized variable warning
root [Thu, 20 Mar 2008 14:59:37 +0000 (15:59 +0100)]
Port
3c1f1f0797e from 3-0-ctdb
We need to inform ctdb about the client's TCP connection so that after a fail
over ctdbd can trigger the client to reconnect very quickly
Volker Lendecke [Thu, 20 Mar 2008 11:49:13 +0000 (12:49 +0100)]
Fix some warnings in the tsmsm module
Alexander, please check!
Michael Adam [Wed, 19 Mar 2008 14:18:06 +0000 (15:18 +0100)]
loadparm: reenable checking files for updates while in registry configuration.
This is necessary now that includes (to files) are enabled from registry.
Michael
Michael Adam [Wed, 19 Mar 2008 10:00:29 +0000 (11:00 +0100)]
loadparm: remove unneeded include.
libnet.h unneeded after separation of libsmbconf from libnet.
Michael
Michael Adam [Thu, 20 Mar 2008 13:35:41 +0000 (14:35 +0100)]
registry: use available string constant in debug statement.
Michael
Michael Adam [Thu, 20 Mar 2008 13:33:43 +0000 (14:33 +0100)]
registry: in regdb_init, not only complain about INFO/version, store it...
Michael
Michael Adam [Thu, 20 Mar 2008 13:26:42 +0000 (14:26 +0100)]
registry: reformat regdb_init() slightly, breaking long lines.
Michael
Michael Adam [Thu, 20 Mar 2008 13:24:12 +0000 (14:24 +0100)]
registry: untangle assignment and if-statement in regdb_init().
Michael
Michael Adam [Thu, 20 Mar 2008 13:08:29 +0000 (14:08 +0100)]
registry: separate initialization of registry data from regdb_init().
Leave this to the users (currently registry_init_smbconf() and
init_registry()) to initialize as much of preliminary registry data
as needed.
Michael
Michael Adam [Thu, 20 Mar 2008 13:01:13 +0000 (14:01 +0100)]
registry: add a transaction wrapper to init_registry_key_internal().
Michael
Michael Adam [Thu, 20 Mar 2008 12:59:09 +0000 (13:59 +0100)]
registry: refactor creation of subkeys out of init_registry_data().
Michael
Karolin Seeger [Thu, 20 Mar 2008 13:15:29 +0000 (14:15 +0100)]
Start to prepare WHATSNEW for 3.2.0pre3.
Karolin
Günther Deschner [Thu, 20 Mar 2008 00:40:04 +0000 (01:40 +0100)]
Remove unused marshalling for SVCCTL_ENUM_DEPENDENT_SERVICES.
Guenther
Günther Deschner [Thu, 20 Mar 2008 00:38:23 +0000 (01:38 +0100)]
Use pidl for _svcctl_EnumDependentServicesW().
Guenther
Günther Deschner [Thu, 20 Mar 2008 00:35:58 +0000 (01:35 +0100)]
Re-run make idl.
Guenther
Günther Deschner [Thu, 20 Mar 2008 00:32:20 +0000 (01:32 +0100)]
Fix IDL for svcctl_EnumDependentServicesW().
Guenther
Günther Deschner [Thu, 20 Mar 2008 00:26:37 +0000 (01:26 +0100)]
Move svc_status_string() out of rpc_client/cli_svcctl.c
Guenther
Günther Deschner [Thu, 20 Mar 2008 00:24:55 +0000 (01:24 +0100)]
No need to compose CLI_SERVER_NAME_SLASH in "net rpc service" anymore.
Guenther
Günther Deschner [Wed, 19 Mar 2008 23:31:26 +0000 (00:31 +0100)]
Add error mapping for WERR_SERVICE_NEVER_STARTED.
Guenther
Günther Deschner [Wed, 19 Mar 2008 23:30:01 +0000 (00:30 +0100)]
Fix crash bug in check_sam_security() when make_server_info_sam() did a
talloc_steal and talloc_free on the sam account already.
Guenther
Kai Blin [Wed, 19 Mar 2008 22:32:38 +0000 (23:32 +0100)]
ntlm_auth: Improve compliance to the Squid helper protocol
This fixes bug #4235.
Patch from Pawel Worach <pawel.worach@gmail.com> with some linebreaks
added by me.
Also fix one BH message that the original patch didn't fix.
Michael Adam [Tue, 18 Mar 2008 16:50:23 +0000 (17:50 +0100)]
libreplace: replace.c does not need system/network.h anymore.
Michael
(cherry picked from commit
2d3c2f34f33338ff422047dae9cc262522689328)
Michael Adam [Tue, 18 Mar 2008 16:20:47 +0000 (17:20 +0100)]
libreplace: move rep_socketpair() to its own module.
Prototype is now in system/network.h,
implementation in socketpair.c, and
check in socketpair.m4.
Now the last networking function has vanished from replace.c.
Michael
(cherry picked from commit
94ac8a25be15b55f66eff96fdddc2fdc71a43b1e)
Volker Lendecke [Wed, 19 Mar 2008 21:37:24 +0000 (22:37 +0100)]
!NT_STATUS_IS_OK != NT_STATUS_IS_ERR
When reading from a pipe, Windows return STATUS_BUFFER_OVERFLOW which is *not*
an error.
Volker Lendecke [Wed, 19 Mar 2008 16:04:50 +0000 (17:04 +0100)]
Fix a warning
Volker Lendecke [Wed, 19 Mar 2008 15:09:37 +0000 (16:09 +0100)]
Merge
dd9e0bea31751 from 3-0-ctdb -- use NetSamLogonEx when possible
NetSamLogonEx has the advantage that it does not use the credential chain
Volker Lendecke [Wed, 19 Mar 2008 15:08:24 +0000 (16:08 +0100)]
Fix some "nexted extern" warnins
Volker Lendecke [Wed, 19 Mar 2008 14:01:30 +0000 (15:01 +0100)]
Fix bug 5338 -- thanks to Yuya Katayama <yuya999@gmail.com>
Günther Deschner [Wed, 19 Mar 2008 01:47:22 +0000 (02:47 +0100)]
Fix the build (by calling NDR_SRVSVC_NETFILEENUM).
Guenther
Günther Deschner [Wed, 19 Mar 2008 00:31:09 +0000 (01:31 +0100)]
Remove unused marshalling for SRV_NET_FILE_ENUM.
Guenther
Günther Deschner [Wed, 19 Mar 2008 00:25:59 +0000 (01:25 +0100)]
Use pidl for _srvsvc_NetFileEnum.
Guenther
Günther Deschner [Tue, 18 Mar 2008 20:30:34 +0000 (21:30 +0100)]
Bind Group Policy processing closer to the samba registry.
Guenther
Andrew Tridgell [Sat, 2 Jun 2007 05:38:09 +0000 (15:38 +1000)]
[samba-3-0-ctdb.tridge @ tridge@samba.org-
20070602053809-kpw5kjkcyjs8yjbl]
suppress that darn message
(cherry picked from commit
542e46a21898f6fcc8a0aeb63925607a60e0b99f)
Michael Adam [Tue, 18 Mar 2008 15:31:15 +0000 (16:31 +0100)]
libreplace: remove duplicate entry of inet_ntoa from README.
Michael
(cherry picked from commit
98ee8c84300757d778733a458c6ca3e6022b40ea)
Michael Adam [Tue, 18 Mar 2008 12:10:22 +0000 (13:10 +0100)]
libreplace: remove trailing white spaces.
Michael
(cherry picked from commit
1f9ca7eed965904f67cf78fbac007432b8a057fd)
Michael Adam [Tue, 18 Mar 2008 11:16:47 +0000 (12:16 +0100)]
libreplace: replace inet_ntoa() when it is missing
...not only replace it when it is broken.
This moves the defintion of rep_inet_ntoa from replace.c
to inet_ntoa.c and adds configure checks for existence
of inet_ntoa(). Checks are moved to an include file of its own.
NOTE: The original rep_inet_ntoa in replace.c was wrapped
into a "#ifndef WITH_PTHREADS" but the prototype in replace.h
and the define in system/network.h were not. I removed that
ifndef since the inet_ntoa() function is usually not thread safe
anyways, since it returns a pointer to a static buffer.
So whoever calls inet_ntoa() should be aware that it is not
thread safe anyways.
Michael
(cherry picked from commit
974c0c45ad42644348e0b55454715b12158f1028)
Michael Adam [Fri, 14 Mar 2008 14:53:38 +0000 (15:53 +0100)]
libreplace: put inet_aton.c under LGPL instead of GPL.
Michael
(cherry picked from commit
cca5d6626fe395f08fd4c8b2344e4e43646cb987)
Stefan Metzmacher [Tue, 18 Mar 2008 14:01:34 +0000 (15:01 +0100)]
libreplace: remove unused SOCKET_LIBS and NSL_LIBS
metze
(cherry picked from commit
62bb177a6e4a3e1f949b78c7cd7583f2e1271739)
Stefan Metzmacher [Tue, 18 Mar 2008 13:55:05 +0000 (14:55 +0100)]
libreplace: for samba4 create LIBREPLACE_NETWORK as EXT_LIB
metze
(cherry picked from commit
79037c31334e271a718fcac234148038814b591e)
Stefan Metzmacher [Tue, 18 Mar 2008 13:53:59 +0000 (14:53 +0100)]
libreplace: use LIBREPLACE_NETWORK_LIBS within some configure checks
...instead of using SOCKET_LIBS and NSL_LIBS.
metze
(cherry picked from commit
cef2e8d748756f61c248ad6660e85dd1ac36308a)
Stefan Metzmacher [Tue, 18 Mar 2008 13:52:36 +0000 (14:52 +0100)]
libreplace: combine SOCKET_LIBS and NSL_LIBS to LIBREPLACE_NETWORK_LIBS
But keep the old ones untill the callers are fixed.
metze
(cherry picked from commit
e7115dcc8a0a4f420de7a901e3a21d4f35a6fcf9)
Michael Adam [Tue, 18 Mar 2008 14:50:27 +0000 (15:50 +0100)]
testparm: only check for %u und passwd program when passwd program is given.
Michael
Michael Adam [Tue, 18 Mar 2008 14:49:31 +0000 (15:49 +0100)]
testparm: correctly check for empty lp_passwd_prog().
Michael
Michael Adam [Tue, 18 Mar 2008 14:33:25 +0000 (15:33 +0100)]
testparm: fix irritating indentation.
Michael
Michael Adam [Tue, 18 Mar 2008 14:30:17 +0000 (15:30 +0100)]
testparm: fix a segfault triggered by setting "unix password sync = yes".
(introduced by pstring removal
041163551194102ca67fef52c57d87020a1d09bc)
Michael
Volker Lendecke [Tue, 18 Mar 2008 12:20:10 +0000 (13:20 +0100)]
Fix bug 5334
I did not test with a zero length file :-)
Volker Lendecke [Mon, 17 Mar 2008 20:00:16 +0000 (21:00 +0100)]
Some simplifications
Marc VanHeyningen [Fri, 14 Mar 2008 22:26:28 +0000 (14:26 -0800)]
Coverity fixes
Michael Adam [Mon, 17 Mar 2008 17:01:33 +0000 (18:01 +0100)]
libsmbconf: rename all occurrences of libnet_conf_ to smbconf_ .
Michael
Michael Adam [Mon, 17 Mar 2008 16:29:44 +0000 (17:29 +0100)]
Move libnet_conf to a library lib/smbconf/ of its own, fixing the api.
The libnet_conf code to access the registry based configuration has
become more of a library used in several places in samba (e.g. loadparm)
than an abstraction of "net conf". So I move it to a location lib/smbconf/.
In the same breath, the api is fixed (not generated by make proto anymore).
Michael
Stefan Metzmacher [Mon, 17 Mar 2008 13:08:57 +0000 (14:08 +0100)]
socket_wrapper: make pcap code more portable
Now the pcap support works on x86_64.
metze
(cherry picked from commit
61a87bed61ef661d98131239976be95c6a8b4d96)
Derrell Lipman [Mon, 17 Mar 2008 15:34:25 +0000 (11:34 -0400)]
Fix use of AuthDataWithContext capability
During my initial plans for, and the subsequent discussion of a more
significant change to the API for libsmbclient, I had removed the
AuthDataWithContext usage, in favor of a more generalized planned interface.
When the API returned to its original state, I neglected to reinsert this
code.
Use of an authentication function with the context can be tested using
examples/libsmbclient/testbrowse -C
Derrell
Volker Lendecke [Mon, 17 Mar 2008 13:45:59 +0000 (14:45 +0100)]
In smbstatus, mark locking.tdb and sessionid.tdb as CLEAR_IF_FIRST
This is needed to inform ctdb that it's not a persistent database, with the
O_RDONLY the tdb backend ignores this.
Merge from
491f902098d33f in 3-0-ctdb
Volker Lendecke [Mon, 17 Mar 2008 13:40:07 +0000 (14:40 +0100)]
Merge leftovers of
0e1a86bc845 in 3-0-ctdb
Volker Lendecke [Mon, 17 Mar 2008 13:12:10 +0000 (14:12 +0100)]
Use right control to attach to persistent databases
This is a merge of
2a8f8b26f08ab09c34dff82417e541d8eb1ec91c and
4e6508dfee0d872a7fa42c9e58ba565137a27b3f from 3-0-ctdb
Volker Lendecke [Mon, 17 Mar 2008 12:51:50 +0000 (13:51 +0100)]
Add "net idmap aclmapset"
This is a merge from 3-0-ctdb that goes along with
1daad835, the option
nfs4:sidmap option
Michael Adam [Mon, 17 Mar 2008 11:21:32 +0000 (12:21 +0100)]
registry: untangle assignment and if-clause in init_registry_data().
Michael
Volker Lendecke [Fri, 14 Mar 2008 19:35:38 +0000 (20:35 +0100)]
Convert pdb_tdb to use dbwrap
Michael Adam [Mon, 17 Mar 2008 00:44:26 +0000 (01:44 +0100)]
registry: convert regdb REGISTRY_OPS to named struct initializers.
Michael
Michael Adam [Mon, 17 Mar 2008 00:39:16 +0000 (01:39 +0100)]
registry: use talloc instead of malloc and provide common exit point
in regdb_get_secdesc().
Michael