ira/wip.git
14 years agoFix wbinfo -a trusted\\user%password on a Samba DC with trusts
Volker Lendecke [Thu, 27 Mar 2008 12:00:23 +0000 (13:00 +0100)]
Fix wbinfo -a trusted\\user%password on a Samba DC with trusts

Winbind can't be allowed to connect to the local smbd.

14 years agoRemove unused DS_DOMAIN_CONTROLLER_INFO struct.
Günther Deschner [Thu, 27 Mar 2008 11:05:01 +0000 (12:05 +0100)]
Remove unused DS_DOMAIN_CONTROLLER_INFO struct.

Guenther

14 years agoFix samlogon rpc client & server.
Günther Deschner [Thu, 27 Mar 2008 12:03:12 +0000 (13:03 +0100)]
Fix samlogon rpc client & server.

Guenther

14 years agoRe-run make idl.
Günther Deschner [Thu, 27 Mar 2008 11:57:03 +0000 (12:57 +0100)]
Re-run make idl.

Guenther

14 years agoMove netr_LogonLevel flags to IDL, rename old one to netr_LogonInfo.
Günther Deschner [Thu, 27 Mar 2008 11:03:20 +0000 (12:03 +0100)]
Move netr_LogonLevel flags to IDL, rename old one to netr_LogonInfo.

Guenther

14 years agoMove DSGETDC_VALID_FLAGS to IDL.
Günther Deschner [Thu, 27 Mar 2008 11:04:22 +0000 (12:04 +0100)]
Move DSGETDC_VALID_FLAGS to IDL.

Guenther

14 years agoMove LOGON_KRB5_FAIL_CLOCK_SKEW to winbindd_pam.
Günther Deschner [Thu, 27 Mar 2008 11:02:18 +0000 (12:02 +0100)]
Move LOGON_KRB5_FAIL_CLOCK_SKEW to winbindd_pam.

Guenther

14 years agoMove the known NETLOGON_CONTROL reply flags to IDL.
Günther Deschner [Thu, 27 Mar 2008 11:01:13 +0000 (12:01 +0100)]
Move the known NETLOGON_CONTROL reply flags to IDL.

Guenther

14 years agoMove inline comment about MSV1_0 flags to IDL.
Günther Deschner [Thu, 27 Mar 2008 10:58:19 +0000 (11:58 +0100)]
Move inline comment about MSV1_0 flags to IDL.

Guenther

14 years agolibwbclient: fix Coverity ID 536 remove duplicate error path (dead code).
Michael Adam [Thu, 27 Mar 2008 10:51:31 +0000 (11:51 +0100)]
libwbclient: fix Coverity ID 536 remove duplicate error path (dead code).

I leave the more explicit error path in the "if (cmd == 0)" block.

Michael

14 years agolibreplace: fix coverity ID 517 - untangle close from open in test/os2_delete.c
Michael Adam [Thu, 27 Mar 2008 10:26:33 +0000 (11:26 +0100)]
libreplace: fix coverity ID 517 - untangle close from open in test/os2_delete.c

This is not a proper bug but the code is clearer now
and we are tracking failure of open separate from that of close.

Michael

14 years agoRe-run make idl.
Günther Deschner [Thu, 27 Mar 2008 10:04:01 +0000 (11:04 +0100)]
Re-run make idl.

Guenther

14 years agoUse netr_LogonControlCode in netr_LogonControl2().
Günther Deschner [Thu, 27 Mar 2008 10:01:55 +0000 (11:01 +0100)]
Use netr_LogonControlCode in netr_LogonControl2().

Guenther

14 years agoposix_acls: clarify loop condition code, removing unneeded counter variable.
Michael Adam [Thu, 27 Mar 2008 09:09:24 +0000 (10:09 +0100)]
posix_acls: clarify loop condition code, removing unneeded counter variable.

Coverity ID 545 falsely classified this as a NULL dereferencing bug.
By putting the loop of walking the list of aces more naturely not using
additional counters, it becomes much more obvious that it is not entered
when dir_ace == NULL.

The same modifications are done for the file_ace loop.

Michael

14 years agoFix typo.
Günther Deschner [Wed, 26 Mar 2008 21:25:51 +0000 (22:25 +0100)]
Fix typo.

Guenther

14 years agonet_conf: fix non-testmode import function.
Michael Adam [Wed, 26 Mar 2008 23:32:00 +0000 (00:32 +0100)]
net_conf: fix non-testmode import function.

Michael

14 years agolibsmbconf: text - pass the cache instead of all private data to pm_process.
Michael Adam [Wed, 26 Mar 2008 22:58:52 +0000 (23:58 +0100)]
libsmbconf: text - pass the cache instead of all private data to pm_process.

Michael

14 years agolibsmbconf: text - change the cache to be talloced
Michael Adam [Wed, 26 Mar 2008 22:58:01 +0000 (23:58 +0100)]
libsmbconf: text - change the cache to be talloced

instead of having it directly as a member in the private data struct.
This makes it easier to flush and initialize the cache.

Michael

14 years agolibsmbconf: in text backend, put flushing of the cache into a helper function.
Michael Adam [Wed, 26 Mar 2008 22:11:04 +0000 (23:11 +0100)]
libsmbconf: in text backend, put flushing of the cache into a helper function.

And use it also in the close operation.

Michael

14 years agoFix a bug in the output from print_canonical_sockaddr() fix from 36f8bafbd3dee66a8....
Gerald W. Carter [Wed, 26 Mar 2008 21:58:27 +0000 (16:58 -0500)]
Fix a bug in the output from print_canonical_sockaddr() fix from 36f8bafbd3dee66a8....

Make sure that IPv4 addresses are not enclised in []'s.

14 years agoFix winbind NETLOGON cred chain on a samba dc for w2k8 trusts.
Günther Deschner [Wed, 26 Mar 2008 20:08:53 +0000 (21:08 +0100)]
Fix winbind NETLOGON cred chain on a samba dc for w2k8 trusts.

Guenther

14 years agoRe-run make idl.
Günther Deschner [Wed, 26 Mar 2008 18:27:18 +0000 (19:27 +0100)]
Re-run make idl.

Guenther

14 years agoFix IDL for netr_NETLOGON_INFO_2.
Günther Deschner [Wed, 26 Mar 2008 18:25:54 +0000 (19:25 +0100)]
Fix IDL for netr_NETLOGON_INFO_2.

W2k8 generated NT_STATUS_ARRAY_BOUNDS_EXCEEDED errors while validating trusts.

Guenther

14 years agoFix _netr_LogonControl2(). Return talloced dcname.
Günther Deschner [Wed, 26 Mar 2008 18:18:08 +0000 (19:18 +0100)]
Fix _netr_LogonControl2(). Return talloced dcname.

Guenther

14 years agoAdd ntsvcs_getdevregprop command to rpcclient.
Günther Deschner [Mon, 18 Feb 2008 01:40:55 +0000 (02:40 +0100)]
Add ntsvcs_getdevregprop command to rpcclient.

Guenther

14 years agonet_conf: reformat - re-indent one function call.
Michael Adam [Wed, 26 Mar 2008 13:46:43 +0000 (14:46 +0100)]
net_conf: reformat - re-indent one function call.

Michael

14 years agonet_conf: add casts to avoid compiler warnings.
Michael Adam [Wed, 26 Mar 2008 13:45:34 +0000 (14:45 +0100)]
net_conf: add casts to avoid compiler warnings.

Michael

14 years agonet_conf: rename "ctx" to "mem_ctx" for clarity.
Michael Adam [Wed, 26 Mar 2008 13:39:02 +0000 (14:39 +0100)]
net_conf: rename "ctx" to "mem_ctx" for clarity.

There are also smbconf contexts arount...

Michael

14 years agonet_conf: use talloc_stackframe() instead of talloc_init().
Michael Adam [Wed, 26 Mar 2008 13:34:21 +0000 (14:34 +0100)]
net_conf: use talloc_stackframe() instead of talloc_init().

Michael

14 years agonet_conf: fix import function by using the new text backend of smbconf.
Michael Adam [Wed, 26 Mar 2008 13:33:22 +0000 (14:33 +0100)]
net_conf: fix import function by using the new text backend of smbconf.

Originally, lp_load() was used to import files to registry.
This had several bugs. Most notably, options explicitly set to
default values were silently dropped, and all parametric options
were ignored.

This new implementation reads config from the text backend and
stuffs everything verbatim in to the registry backend.

Michael

14 years agolibsmbconf: add a text backend to libsmbconf based on the params.c parser.
Michael Adam [Wed, 26 Mar 2008 13:30:36 +0000 (14:30 +0100)]
libsmbconf: add a text backend to libsmbconf based on the params.c parser.

This is a simple implementation of text backend for libsmbconf.
It is read only. It uses the parser from params.c. It loads the
given config file and holds the parsed lists of strings in memory.
Config is only re-read if the time stamp of the config file has changed.
Brilliant performance on large files is not to be expected since the
string lists are not hashed. This might be added in the future.

Michael

14 years agoloadparm: add userdata parameter to do_section() and do_parameter().
Michael Adam [Tue, 25 Mar 2008 21:53:47 +0000 (22:53 +0100)]
loadparm: add userdata parameter to do_section() and do_parameter().

The userdata is currently unused. It can be used in the future for
passing a context like in samba4 code.

Michael

14 years agoWHATSNEW: Start to add changes since 3.2.0pre2.
Karolin Seeger [Wed, 26 Mar 2008 13:02:48 +0000 (14:02 +0100)]
WHATSNEW: Start to add changes since 3.2.0pre2.

Karolin

14 years agoStrip whitespace in ntsvcs rpc server.
Günther Deschner [Wed, 26 Mar 2008 10:45:28 +0000 (11:45 +0100)]
Strip whitespace in ntsvcs rpc server.

Guenther

14 years agoRe-run make idl.
Günther Deschner [Wed, 26 Mar 2008 10:35:44 +0000 (11:35 +0100)]
Re-run make idl.

Guenther

14 years agoFill in IDL for PNP_GetDeviceRegProp.
Günther Deschner [Mon, 18 Feb 2008 01:37:26 +0000 (02:37 +0100)]
Fill in IDL for PNP_GetDeviceRegProp.

Guenther

14 years agoComment out some svcctl headers which are now defined in IDL.
Günther Deschner [Wed, 26 Mar 2008 10:32:12 +0000 (11:32 +0100)]
Comment out some svcctl headers which are now defined in IDL.

Guenther

14 years agoRe-run make idl.
Günther Deschner [Wed, 26 Mar 2008 10:36:41 +0000 (11:36 +0100)]
Re-run make idl.

Guenther

14 years agoAdd svcctl_MgrAccessMask and svcctl_ServiceAccessMask.
Günther Deschner [Tue, 25 Mar 2008 18:07:48 +0000 (19:07 +0100)]
Add svcctl_MgrAccessMask and svcctl_ServiceAccessMask.

Guenther

14 years agosmbconf: reformat - fix intentation.
Michael Adam [Wed, 26 Mar 2008 09:55:26 +0000 (10:55 +0100)]
smbconf: reformat - fix intentation.

This time this won't make me stumble, since there is no
magic in indented function headers here - no automatic
prototype generation... :-)

Michael

14 years agoutil_tdb: remove trivial and unused tdb_wipe().
Michael Adam [Wed, 26 Mar 2008 10:13:47 +0000 (11:13 +0100)]
util_tdb: remove trivial and unused tdb_wipe().

It has been replaced by tdb_wipe_all().

Michael

14 years agouse tdb_wipe_all() instead of tdb_wipe() - it is faster...
Michael Adam [Wed, 26 Mar 2008 09:50:08 +0000 (10:50 +0100)]
use tdb_wipe_all() instead of tdb_wipe() - it is faster...

Michael

14 years agoutil_tdb: make the _byblob fetch/store functions public again.
Michael Adam [Wed, 26 Mar 2008 09:45:53 +0000 (10:45 +0100)]
util_tdb: make the _byblob fetch/store functions public again.

Users of these are currently being written...

Michael

14 years agoFix wbcAuthenticateUserEx().
Günther Deschner [Wed, 26 Mar 2008 00:27:36 +0000 (01:27 +0100)]
Fix wbcAuthenticateUserEx().

Guenther

14 years agoAdd debug statement in auth_winbind to display wbcAuthenticateUserEx error code.
Günther Deschner [Wed, 26 Mar 2008 00:25:57 +0000 (01:25 +0100)]
Add debug statement in auth_winbind to display wbcAuthenticateUserEx error code.

Guenther

14 years agoFix a valgrind error
Volker Lendecke [Tue, 25 Mar 2008 21:35:20 +0000 (22:35 +0100)]
Fix a valgrind error

In winbind, we're using the info3 struct to send it to the winbind client after
netsamlogon_cache_store. Without this info3->base.account_name.string was
prematurely freed.

14 years agoFix a segfault
Volker Lendecke [Tue, 25 Mar 2008 21:21:50 +0000 (22:21 +0100)]
Fix a segfault

When we get a NT_STATUS_WRONG_PASSWORD for example, my_info3 is not initialized
at all. So first check that we have NT_STATUS_IS_OK(status) before we
dereference my_info3.

14 years agoFix typo
Volker Lendecke [Tue, 25 Mar 2008 20:35:41 +0000 (21:35 +0100)]
Fix typo

14 years agoRe-run make idl (after pidl change for adding header info to cli_ functions).
Günther Deschner [Tue, 25 Mar 2008 16:52:33 +0000 (17:52 +0100)]
Re-run make idl (after pidl change for adding header info to cli_ functions).

Guenther

14 years agoutil_tdb: add my (C) for the tdb validation code
Michael Adam [Tue, 25 Mar 2008 14:55:03 +0000 (15:55 +0100)]
util_tdb: add my (C) for the tdb validation code

Michael

14 years agoutil_tdb: add a wrapper tdb_wipe() for traverse with tdb_traverse_delete_fn().
Michael Adam [Tue, 25 Mar 2008 13:18:08 +0000 (14:18 +0100)]
util_tdb: add a wrapper tdb_wipe() for traverse with tdb_traverse_delete_fn().

Replace all callers of traverse with this tdb_traverse_delete_fn() and
don't export tdb_traverse_delete_fn() anymore.

Michael

14 years agoutil_tdb: add the tdb_pack_append() prototype to util_tdb.h
Michael Adam [Tue, 25 Mar 2008 12:53:31 +0000 (13:53 +0100)]
util_tdb: add the tdb_pack_append() prototype to util_tdb.h

This function is currently not used but seems useful.

Michael

14 years agoutil_tdb: make the _byblob functions static - not currently used elsewhere.
Michael Adam [Tue, 25 Mar 2008 12:52:32 +0000 (13:52 +0100)]
util_tdb: make the _byblob functions static - not currently used elsewhere.

Michael

14 years agoutil_tdb: group prototypes in util_tdb.h thematically
Michael Adam [Tue, 25 Mar 2008 12:41:51 +0000 (13:41 +0100)]
util_tdb: group prototypes in util_tdb.h thematically

Michael

14 years agobuild: don't autogenerate prototypes for util_tdb and dbwrap anymore.
Michael Adam [Tue, 25 Mar 2008 11:54:14 +0000 (12:54 +0100)]
build: don't autogenerate prototypes for util_tdb and dbwrap anymore.

Stick to hand-written headers (that are there anyways).
Add some missing prototypes to util_tdb.h and dbwrap.h.

I did not bother to add a header for each single dbwrap backend
open function but put the prototypes for the open functions into
the central dbwrap.h.

Michael

14 years agoFix usage message for 'net idmap dump'.
Karolin Seeger [Tue, 25 Mar 2008 11:00:42 +0000 (12:00 +0100)]
Fix usage message for 'net idmap dump'.

Karolin

14 years agoFix _winreg_QueryValue().
Günther Deschner [Tue, 25 Mar 2008 09:11:47 +0000 (10:11 +0100)]
Fix _winreg_QueryValue().

Guenther

14 years agoRe-run make idl.
Günther Deschner [Mon, 24 Mar 2008 10:48:16 +0000 (11:48 +0100)]
Re-run make idl.

Guenther

14 years agoFix IDL for winreg_QueryValue.
Günther Deschner [Mon, 24 Mar 2008 10:46:51 +0000 (11:46 +0100)]
Fix IDL for winreg_QueryValue.

Guenther

14 years agoIgnore port when pulling IP addr from struct sockaddr_storage.
Gerald (Jerry) Carter [Mon, 24 Mar 2008 19:48:29 +0000 (14:48 -0500)]
Ignore port when pulling IP addr from struct sockaddr_storage.

Linux man page states that getaddinfo() will leave the port
uninitialized when passing in NULL for the service name.  So we
can't really trust that anymore.  I doubt non-default KDC ports
are an issues so just drop the port from the generated krb5.conf.
AIX exhibits this bug the most.

14 years agoFix libtdb some to move back towards allowing out of tree builds
Gerald (Jerry) Carter [Mon, 24 Mar 2008 19:27:01 +0000 (14:27 -0500)]
Fix libtdb some to move back towards allowing out of tree builds

Remaining problem is that not all *.syms linker scripts are generated
so the LD command needs to look in a single place.  Out of tree
builds now work but report write access to the source tree in order
to create the $(srcdir)/expotrs/libtdb.sysms file.

14 years agoMissing HAVE_UPDWTMPX check before using updwtmpx().
Eric Cronin [Mon, 24 Mar 2008 19:33:04 +0000 (12:33 -0700)]
Missing HAVE_UPDWTMPX check before using updwtmpx().

In 10.5 Mac OS X added enough utmpx support to make it past the
first two preprocessor checks around line 390 of src/smbd/utmp.c
and on to the utmpx block which uses updwtmpx().  Unfortunately,
as ./configure correctly surmised, 10.5 doesn't have that.

https://bugzilla.samba.org/show_bug.cgi?id=5184

14 years agoFix Coverity ID 514
Volker Lendecke [Sun, 23 Mar 2008 18:43:36 +0000 (19:43 +0100)]
Fix Coverity ID 514

Not exactly an uninitialized variable, but having Coverity figure out that
we're only UNMARSHALLING here is probably asking for a bit too much.

14 years agoFix Coverity ID 504
Volker Lendecke [Sun, 23 Mar 2008 18:38:50 +0000 (19:38 +0100)]
Fix Coverity ID 504

14 years agoFix Coverity ID 503
Volker Lendecke [Sun, 23 Mar 2008 18:38:02 +0000 (19:38 +0100)]
Fix Coverity ID 503

14 years agoFix Coverity ID 488
Volker Lendecke [Sun, 23 Mar 2008 18:30:47 +0000 (19:30 +0100)]
Fix Coverity ID 488

"status" was used uninitialized on success -- metze, please check

14 years agoFix Coverity ID 487
Volker Lendecke [Sun, 23 Mar 2008 18:26:35 +0000 (19:26 +0100)]
Fix Coverity ID 487

14 years agoFix Coverity ID 471
Volker Lendecke [Sun, 23 Mar 2008 17:10:28 +0000 (18:10 +0100)]
Fix Coverity ID 471

14 years agoFix Coverity ID 472
Volker Lendecke [Sun, 23 Mar 2008 17:08:13 +0000 (18:08 +0100)]
Fix Coverity ID 472

Simo, S4 also has this code. You might want to cherry-pick.

Volker

14 years agoFix Coverity ID 477
Volker Lendecke [Sun, 23 Mar 2008 16:58:26 +0000 (17:58 +0100)]
Fix Coverity ID 477

14 years agoFix Coverity ID 478
Volker Lendecke [Sun, 23 Mar 2008 16:57:01 +0000 (17:57 +0100)]
Fix Coverity ID 478

14 years agoFix Coverity ID 479
Volker Lendecke [Sun, 23 Mar 2008 16:54:48 +0000 (17:54 +0100)]
Fix Coverity ID 479

14 years agoFix Coverity ID 480
Volker Lendecke [Sun, 23 Mar 2008 16:53:05 +0000 (17:53 +0100)]
Fix Coverity ID 480

14 years agoFix Coverity ID 450
Volker Lendecke [Sun, 23 Mar 2008 16:50:55 +0000 (17:50 +0100)]
Fix Coverity ID 450

14 years agoFix Coverity ID 453
Volker Lendecke [Sun, 23 Mar 2008 16:49:04 +0000 (17:49 +0100)]
Fix Coverity ID 453

14 years agoFix Coverity ID 462
Volker Lendecke [Sun, 23 Mar 2008 16:32:46 +0000 (17:32 +0100)]
Fix Coverity ID 462

14 years agoFix Coverity ID 432
Volker Lendecke [Sun, 23 Mar 2008 14:58:09 +0000 (15:58 +0100)]
Fix Coverity ID 432

14 years agoFix Coverity ID 436
Volker Lendecke [Sun, 23 Mar 2008 14:56:41 +0000 (15:56 +0100)]
Fix Coverity ID 436

14 years agoFix Coverity warnings
Volker Lendecke [Sun, 23 Mar 2008 14:51:52 +0000 (15:51 +0100)]
Fix Coverity warnings

ID 449, 448, 447, 446, 445, 444, 443, 442, 441, 440, 439, 438, 437

14 years agoVERSION: Update pre release number.
Karolin Seeger [Sun, 23 Mar 2008 06:28:13 +0000 (07:28 +0100)]
VERSION: Update pre release number.

Karolin

14 years agolibgpo: open the registry in gp_init_reg_ctx().
Michael Adam [Sat, 22 Mar 2008 01:45:04 +0000 (02:45 +0100)]
libgpo: open the registry in gp_init_reg_ctx().

I forgot the regdb_open() call: registry_init_basic() closes
the registry in the end... sorry.

Michael

14 years agolibgpo: replace hand-crafted registry initialization by registry_init_basic.
Michael Adam [Sat, 22 Mar 2008 01:29:02 +0000 (02:29 +0100)]
libgpo: replace hand-crafted registry initialization by registry_init_basic.

IMO there is no need to imitate a custom registry backend.
Only default regdb hooks are used here, so a plain initialization
of regdb should suffice.

This way, only reg_api is used in libgpo, and no registry
backend code is visible.

Michael

14 years agolibgpo: use reg_setkeysecurity() instead of regdb_set_secdesc().
Michael Adam [Sat, 22 Mar 2008 01:22:54 +0000 (02:22 +0100)]
libgpo: use reg_setkeysecurity() instead of regdb_set_secdesc().

That is, use the reg_api function instead of the backend function.
For this, code had to be changed, to take a "struct registry_key"
instead of a char *.

Michael

14 years agoregistry: add reg_init_basic() - init registry with only the db backend.
Michael Adam [Sat, 22 Mar 2008 01:05:53 +0000 (02:05 +0100)]
registry: add reg_init_basic() - init registry with only the db backend.

Michael

14 years agoregistry: close registry in exit path in registry_init_smbconf().
Michael Adam [Sat, 22 Mar 2008 00:54:18 +0000 (01:54 +0100)]
registry: close registry in exit path in registry_init_smbconf().

Michael

14 years agoregistry: some whitespace cleanup in init_registry().
Michael Adam [Sat, 22 Mar 2008 00:53:44 +0000 (01:53 +0100)]
registry: some whitespace cleanup in init_registry().

Michael

14 years agoregistry: remove unneeded talloc stackframe variable.
Michael Adam [Sat, 22 Mar 2008 00:52:03 +0000 (01:52 +0100)]
registry: remove unneeded talloc stackframe variable.

Michael

14 years agoregistry: close regdb in error path (and use it) in init_registry().
Michael Adam [Sat, 22 Mar 2008 00:49:21 +0000 (01:49 +0100)]
registry: close regdb in error path (and use it) in init_registry().

Michael

14 years agoregistry: fix registry_init_smbconf() to close the registry at the end.
Michael Adam [Fri, 21 Mar 2008 22:50:49 +0000 (23:50 +0100)]
registry: fix registry_init_smbconf() to close the registry at the end.

Michael

14 years agolibsmbconf: add internal open/close handling to registry backend.
Michael Adam [Fri, 21 Mar 2008 22:39:01 +0000 (23:39 +0100)]
libsmbconf: add internal open/close handling to registry backend.

This internally keeps track of opened registry in the private data
struct. The first call that really accesses data, opens the registry
and it is kept open until the destructor is called.

This behaviour might be changed in the future.

Michael

14 years agolibsmbconf: add a comment.
Michael Adam [Fri, 21 Mar 2008 21:55:20 +0000 (22:55 +0100)]
libsmbconf: add a comment.

Michael

14 years agolibsmbconf: add private_data section to smbconf_ctx.
Michael Adam [Fri, 21 Mar 2008 21:52:27 +0000 (22:52 +0100)]
libsmbconf: add private_data section to smbconf_ctx.

This private data should be used by backends.
The token for the registry backend is moved from
the context to the private data section, since
this is registry specific.

Michael

14 years agolibsmbconf: add a "path" variable to the conf context.
Michael Adam [Fri, 21 Mar 2008 16:55:31 +0000 (17:55 +0100)]
libsmbconf: add a "path" variable to the conf context.

This is passed to the module init routines.
In case of the registry, this is the path of the
basekey in registry, that is to be used, defaulting
to KEY_SMBCONF (HKLM\software\samba\smbconf), when
NULL is given. This is the only case currently used.

In order to support other keys, registry initialization
for smbconf has to be changed to support different keys.

Michael

14 years agolibsmbconf: add structuring comments to the prototypes in the public header.
Michael Adam [Fri, 21 Mar 2008 15:45:25 +0000 (16:45 +0100)]
libsmbconf: add structuring comments to the prototypes in the public header.

Michael

14 years agolibsmbconf: adapt a comment to new circumstances
Michael Adam [Fri, 21 Mar 2008 15:42:42 +0000 (16:42 +0100)]
libsmbconf: adapt a comment to new circumstances

Michael

14 years agolibsmbconf: group together functions in smbconf.c more appropriately
Michael Adam [Fri, 21 Mar 2008 15:40:20 +0000 (16:40 +0100)]
libsmbconf: group together functions in smbconf.c more appropriately

Michael

14 years agolibsmbconf: add a comment.
Michael Adam [Fri, 21 Mar 2008 15:35:52 +0000 (16:35 +0100)]
libsmbconf: add a comment.

Michael

14 years agolibsmbconf: move registry implementation to a module of its own.
Michael Adam [Fri, 21 Mar 2008 15:26:50 +0000 (16:26 +0100)]
libsmbconf: move registry implementation to a module of its own.

Michael

14 years agoOn Solaris, size_t seems to be only 32 bit.
Volker Lendecke [Fri, 21 Mar 2008 12:39:48 +0000 (13:39 +0100)]
On Solaris, size_t seems to be only 32 bit.

Fix bug 5341, thanks a lot to Karoly Vegh for testing it!

Volker

14 years agoFix Coverity ID 473
Volker Lendecke [Fri, 21 Mar 2008 10:52:34 +0000 (11:52 +0100)]
Fix Coverity ID 473

Simo, S4 also has this bug, you might want to merge the fix.