12 years agoFixed a bug in object specific access checks.
Nadezhda Ivanova [Tue, 3 Nov 2009 10:27:43 +0000 (12:27 +0200)]
Fixed a bug in object specific access checks.

12 years agos3: Remove debug_ctx()
Volker Lendecke [Tue, 3 Nov 2009 09:59:18 +0000 (10:59 +0100)]
s3: Remove debug_ctx()

smbd just crashed on me: In a debug message I called a routine preparing a
string that itself used debug_ctx. The outer routine also used it after the
inner routine had returned. It was still referencing the talloc context
that the outer debug_ctx() had given us, which the inner DEBUG had already

12 years agoAdded some dn to the info in the log messages.
Nadezhda Ivanova [Tue, 3 Nov 2009 09:21:05 +0000 (11:21 +0200)]
Added some dn to the info in the log messages.

12 years agoRemoved the default DACL from token, as we will not be using it.
Nadezhda Ivanova [Mon, 2 Nov 2009 14:50:28 +0000 (16:50 +0200)]
Removed the default DACL from token, as we will not be using it.

12 years agoConvert from numbers to correct SMB_FIND_XX constant names.
Jeremy Allison [Tue, 3 Nov 2009 00:17:36 +0000 (16:17 -0800)]
Convert from numbers to correct SMB_FIND_XX constant names.

12 years agos3:registry: add an extra check for dsize==0 to regdb_fetch_keys_internal()
Michael Adam [Mon, 2 Nov 2009 23:51:27 +0000 (00:51 +0100)]
s3:registry: add an extra check for dsize==0 to regdb_fetch_keys_internal()

Don't only rely on dptr == NULL.
I stumbled over this one when rewriting some of the dbwrap_ctdb code.


12 years agos3:registry: add safety check for return value of tdb_unpack to regdb_fetch_keys_inte...
Michael Adam [Mon, 2 Nov 2009 23:47:37 +0000 (00:47 +0100)]
s3:registry: add safety check for return value of tdb_unpack to regdb_fetch_keys_internal()

Prevents segfaults in some situations.

(For a non existent or empty record, we sometimes rely on the fetch operation
 to return dsize==0 and sometimes we rely on dptr==NULL.)


12 years agos3:dbwrap_ctdb: add debug message to transaction_fetch_start()
Michael Adam [Sat, 31 Oct 2009 12:16:34 +0000 (13:16 +0100)]
s3:dbwrap_ctdb: add debug message to transaction_fetch_start()

for the case that another local process has started a transaction
bewteen releasing the transaction_lock record and starting the


12 years agos3:dbwrap_ctdb: split combined check in two and add descriptive debug
Michael Adam [Sat, 31 Oct 2009 12:13:04 +0000 (13:13 +0100)]
s3:dbwrap_ctdb: split combined check in two and add descriptive debug

in db_ctdb_transaction_fetch_start() for error conditions when re-fetching
the transaction_lock record inside the transaction


12 years agos3:dbwrap_ctdb: fix race condition with concurrent transactions on the same node.
Michael Adam [Wed, 28 Oct 2009 23:01:45 +0000 (00:01 +0100)]
s3:dbwrap_ctdb: fix race condition with concurrent transactions on the same node.

In ctdb_transaction_commit(), when the trans2_commit control fails, there
is a race condition in the 1 second sleep between the local transaction_cancel
and the call to ctdb_replay_transaction(): The database is not locked, and
neither is the transaction_lock record. So another client can start and possibly
complete a new transaction in this gap, but only on the same node: The locking
of the transaction_lock record on a different node which involves migration of
the record to the other node has been disabled by introduction of the
transaction_active flag on the db which closes precisely this gap from the start
of the commit until the call to TRANS2_FINISH or TRANS2_ERROR.
But this mechanism does not cover the case where a process on the same node
tries to start a transaction: There is no obstacle to locking the transaction_lock
record because the record does not need to be migrated.

This commit closes this race condition in ctdb_transaction_fetch_start()
by using the new ctdb_ctrl_transaction_active() call to ask the local
ctdb daemon whether it has a transaction running on the database.
If so, the check is repeated until the running transaction is done.

This does introduce an additional call to the local ctdbd when starting
transactions, but it does close the (hopefully) last race condition.


12 years agos3:configure: add a check for the new CTDB_CONTROL_TRANS2_ACTIVE
Michael Adam [Wed, 28 Oct 2009 22:56:59 +0000 (23:56 +0100)]
s3:configure: add a check for the new CTDB_CONTROL_TRANS2_ACTIVE


12 years agos3:dbwrap_ctdb: add new db_ctdb_transaction_active() that calls CTDB_CONTROL_TRANS2_C...
Michael Adam [Wed, 28 Oct 2009 22:56:03 +0000 (23:56 +0100)]
s3:dbwrap_ctdb: add new db_ctdb_transaction_active() that calls CTDB_CONTROL_TRANS2_COMMIT


12 years agos3:dbwrap_ctdb: fix a race in starting concurrent transactions on a single node
Michael Adam [Wed, 28 Oct 2009 00:54:04 +0000 (01:54 +0100)]
s3:dbwrap_ctdb: fix a race in starting concurrent transactions on a single node

There are two races in concurrent transactions on a single node.
One in starting a transaction and one with replay during commit.

This commit closes the first race by storing the client pid in the
transaction-lock record and comparing the stored pid against its own
pid after releasing the lock and refetching the record inside the


12 years agos3:dbwrap_ctdb: use db_ctdb_ltdb_fetch() inside db_ctdb_transaction_fetch_start
Michael Adam [Wed, 28 Oct 2009 00:50:15 +0000 (01:50 +0100)]
s3:dbwrap_ctdb: use db_ctdb_ltdb_fetch() inside db_ctdb_transaction_fetch_start


12 years agos3:dbwrap_ctdb: use db_ctdb_ltdb_fetch() inside db_ctdb_transaction_fetch()
Michael Adam [Wed, 28 Oct 2009 00:28:38 +0000 (01:28 +0100)]
s3:dbwrap_ctdb: use db_ctdb_ltdb_fetch() inside db_ctdb_transaction_fetch()


12 years agos3:dbwrap_ctdb: add a function db_ctdb_ltdb_fetch()
Michael Adam [Mon, 2 Nov 2009 23:55:41 +0000 (00:55 +0100)]
s3:dbwrap_ctdb: add a function db_ctdb_ltdb_fetch()

This fetches a record from the db and splits out the ctdb header.


12 years agos3:dbrwap_ctdb: add a function db_ctdb_ltdb_store()
Michael Adam [Thu, 22 Oct 2009 14:27:45 +0000 (16:27 +0200)]
s3:dbrwap_ctdb: add a function db_ctdb_ltdb_store()

and use it in db_ctdb_store() and db_ctdb_transaction_store().


12 years agos3:dbwrap_ctdb: reformat a comment slightly to enhance clearness.
Michael Adam [Thu, 22 Oct 2009 12:37:51 +0000 (14:37 +0200)]
s3:dbwrap_ctdb: reformat a comment slightly to enhance clearness.


12 years agoFix bug 6867 - trans2findnext returns reply_nterror(req, ntstatus) In a directory...
Jeremy Allison [Mon, 2 Nov 2009 20:15:25 +0000 (12:15 -0800)]
Fix bug 6867 - trans2findnext returns reply_nterror(req, ntstatus) In a directory with a lot of files.

12 years agos3: Fix a 100% CPU loop when ctdbd dies during a traverse
Volker Lendecke [Mon, 2 Nov 2009 15:59:15 +0000 (16:59 +0100)]
s3: Fix a 100% CPU loop when ctdbd dies during a traverse

12 years agos3-gencache: restore gencache_get behavior with NULL args (with torture test).
Günther Deschner [Mon, 2 Nov 2009 12:01:58 +0000 (13:01 +0100)]
s3-gencache: restore gencache_get behavior with NULL args (with torture test).

Without this, we panic in wins_srv_is_dead() and fail to start nmbd with
wins support.

Volker, please check.


12 years agos3: Make "debug hires timestamp" default to true
Volker Lendecke [Mon, 2 Nov 2009 09:05:38 +0000 (10:05 +0100)]
s3: Make "debug hires timestamp" default to true

It does not cost much and can help a lot when debugging

12 years agos4:dsdb Fix up after the MAP_ constants became LDB_MAP_
Andrew Bartlett [Fri, 30 Oct 2009 12:45:21 +0000 (23:45 +1100)]
s4:dsdb Fix up after the MAP_ constants became LDB_MAP_

12 years agos4:provision Remove LDB backend files in provision
Andrew Bartlett [Fri, 30 Oct 2009 12:42:03 +0000 (23:42 +1100)]
s4:provision Remove LDB backend files in provision

Rather than try and remove the records in the LDB files, make the
provision remove the whole file.  This also removes the need to try
and carry forward the old ldb filenames.

Andrew Bartlett

12 years agos4:provision Split ProvisionBackend out of the main provision script
Andrew Bartlett [Fri, 30 Oct 2009 04:18:42 +0000 (15:18 +1100)]
s4:provision Split ProvisionBackend out of the main provision script

This splits the code, while keeping the original behaviour.  The file had become just too long.

Andrew Bartlett

12 years agos4:provision Inline 'ldap_backend_shutdown' for clarity
Andrew Bartlett [Fri, 30 Oct 2009 03:54:21 +0000 (14:54 +1100)]
s4:provision Inline 'ldap_backend_shutdown' for clarity

12 years agos4:provision Fix samdb test with new provision code
Andrew Bartlett [Fri, 30 Oct 2009 03:51:57 +0000 (14:51 +1100)]
s4:provision Fix samdb test with new provision code

12 years agos4:provision Move 'Schema' into it's own file
Andrew Bartlett [Fri, 30 Oct 2009 03:31:25 +0000 (14:31 +1100)]
s4:provision Move 'Schema' into it's own file

12 years agos4:provision Make 'linked_attributes' and 'dnsyntax_attributes' a property of the...
Andrew Bartlett [Fri, 30 Oct 2009 03:05:21 +0000 (14:05 +1100)]
s4:provision Make 'linked_attributes' and 'dnsyntax_attributes' a property of the Schema

12 years agos4:provision Rework provision to always have a ProvisionBackend
Andrew Bartlett [Fri, 30 Oct 2009 02:16:10 +0000 (13:16 +1100)]
s4:provision Rework provision to always have a ProvisionBackend

Rather than treat the LDAP backend as a special case, treat all
backends the same, with different callbacks.

Andrew Bartlett

12 years agos4 - SID allocation using FDS DNA plugin
Endi S. Dewata [Wed, 28 Oct 2009 20:28:31 +0000 (15:28 -0500)]
s4 - SID allocation using FDS DNA plugin

12 years agos4:dsdb - Removed redundant domain SID filter.
Endi S. Dewata [Tue, 27 Oct 2009 19:59:28 +0000 (14:59 -0500)]
s4:dsdb - Removed redundant domain SID filter.

12 years agos4:dsdb - Store SID as string in FDS.
Endi S. Dewata [Sat, 24 Oct 2009 03:59:48 +0000 (22:59 -0500)]
s4:dsdb - Store SID as string in FDS.

12 years agos4 - Mapped AD schema to existing FDS schema.
Endi S. Dewata [Sat, 24 Oct 2009 01:09:07 +0000 (20:09 -0500)]
s4 - Mapped AD schema to existing FDS schema.

12 years agos4:dsdb - Fixed attribute dereferencing for FDS
Endi S. Dewata [Wed, 21 Oct 2009 21:02:18 +0000 (16:02 -0500)]
s4:dsdb - Fixed attribute dereferencing for FDS

12 years agoRemove special case logic in 'samdb_relative_path'.
Andrew Bartlett [Thu, 29 Oct 2009 22:03:10 +0000 (09:03 +1100)]
Remove special case logic in 'samdb_relative_path'.

While this logic (avoiding to prefix a non-filename with a path) is
important in the code this was copied from (private_dir()), none of
the callers of this function need it.

Andrew Bartlett

12 years agos4:dsdb Revert back to using DN:filename in the partitions record
Andrew Bartlett [Thu, 29 Oct 2009 22:00:13 +0000 (09:00 +1100)]
s4:dsdb Revert back to using DN:filename in the partitions record

This allows us to change the escaping function without breaking
existing installs.  The new escaping function (used for new databases)
is RFC1738 URI encoding, except for the trivial cases without special

The new databases are also placed in a subdirectory, sam.ldb.d per an
earlier suggestion by metze.

Andrew Bartlett

12 years agolib/util Use rfc1738.c from Squid for all our URL encode/decode needs.
Andrew Bartlett [Thu, 29 Oct 2009 21:58:34 +0000 (08:58 +1100)]
lib/util Use rfc1738.c from Squid for all our URL encode/decode needs.

Andrew Bartlett

12 years agolib/util Add rfc1738 escape/unescape code from Squid
Andrew Bartlett [Thu, 29 Oct 2009 06:09:49 +0000 (17:09 +1100)]
lib/util Add rfc1738 escape/unescape code from Squid

This is intended to replace our rfc1738_unescape(), and give us an
rfc1738_escape implementation (and hopefully is better tested and more

Andrew Bartlett

12 years agos4:credentials Put the 'secrets.keytab' in the same directory as secrets.ldb
Andrew Bartlett [Wed, 28 Oct 2009 05:49:30 +0000 (16:49 +1100)]
s4:credentials Put the 'secrets.keytab' in the same directory as secrets.ldb

This avoids trouble when the secrets.ldb is updated with ldbedit but
an smb.conf is not specified.

Andrew Bartlett

12 years agos4: Create a script for updating a running provision with change introduced since...
Matthieu Patou [Tue, 27 Oct 2009 12:31:40 +0000 (15:31 +0300)]
s4: Create a script for updating a running provision with change introduced since the initial provision

12 years agos4:torture/raw/samba3misc - Add "discard_const_p" macro before a string
Matthias Dieter Wallnöfer [Sat, 17 Oct 2009 20:37:24 +0000 (22:37 +0200)]
s4:torture/raw/samba3misc - Add "discard_const_p" macro before a string

12 years agos4:ldb Remove debug traces duplicated by the new generic trace code
Andrew Bartlett [Tue, 27 Oct 2009 02:56:40 +0000 (13:56 +1100)]
s4:ldb Remove debug traces duplicated by the new generic trace code

12 years agos3:ldap: don't search when no values where found
Björn Jacke [Fri, 30 Oct 2009 23:45:09 +0000 (00:45 +0100)]
s3:ldap: don't search when no values where found

12 years agouuid.c: Remove some dead code
Volker Lendecke [Sun, 1 Nov 2009 11:56:23 +0000 (12:56 +0100)]
uuid.c: Remove some dead code

12 years agos3: Fix the RPC server SUBSYSTEM declaration
Volker Lendecke [Sat, 31 Oct 2009 10:28:55 +0000 (11:28 +0100)]
s3: Fix the RPC server SUBSYSTEM declaration

If I read SMB_SUBSYSTEM right then the 2nd argument needs to be the file where
the static_init_rpc (in this case) is defined. This seems to have moved from
server.c to process.c.

Jelmer, please check!


12 years agos3:Makefile: add LIBREPLACE_LIBS for talloc, tdb and wbclient
Björn Jacke [Sat, 31 Oct 2009 09:37:44 +0000 (10:37 +0100)]
s3:Makefile: add LIBREPLACE_LIBS for talloc, tdb and wbclient

12 years agoѕ3:buildsystem: fix depenencies for libreplace
Björn Jacke [Fri, 30 Oct 2009 18:54:52 +0000 (19:54 +0100)]
ѕ3:buildsystem: fix depenencies for libreplace

This problem became visible after adding the picky -z defs linker option: On
Solaris libreplace had unresolved symbols, which showed up in the libtalloc
build. PAM_WINBIND_EXTRA_LIBS and WINBIND_NSS_EXTRA_LIBS had been workarounds
to make things work at two placeѕ. These variables have been obsoleted now.
This patch introduces LIBREPLACE_LIBS which contans the linker flags needed for
linking anything using libreplace.

12 years agoѕ3:ldap: search for account policies in objectclass sambaDomain, not *
Björn Jacke [Fri, 30 Oct 2009 20:50:41 +0000 (21:50 +0100)]
ѕ3:ldap: search for account policies in objectclass sambaDomain, not *

12 years agos3/docs: Fix typo.
Karolin Seeger [Fri, 30 Oct 2009 15:47:22 +0000 (16:47 +0100)]
s3/docs: Fix typo.

Fix bug #4250. Thanks to TAKAHASHI Motonobu <> for reporting!


12 years agos3/docs: Remove reference to nonexistent file.
Karolin Seeger [Fri, 30 Oct 2009 15:31:55 +0000 (16:31 +0100)]
s3/docs: Remove reference to nonexistent file.

Fix bug #4252. Thanks to TAKAHASHI Motonobu <> for reporting!


12 years agos4:nbt_server/wins/winsdb - Fix "const" warning
Matthias Dieter Wallnöfer [Sat, 17 Oct 2009 20:31:34 +0000 (22:31 +0200)]
s4:nbt_server/wins/winsdb - Fix "const" warning

12 years agos4-smbtorture: skip bigendian tests against s3 in RPC-LSA-SECRETS.
Günther Deschner [Thu, 29 Oct 2009 13:50:56 +0000 (14:50 +0100)]
s4-smbtorture: skip bigendian tests against s3 in RPC-LSA-SECRETS.


12 years agos3-rpcclient: add deletetrustdom command.
Günther Deschner [Wed, 28 Oct 2009 14:37:11 +0000 (15:37 +0100)]
s3-rpcclient: add deletetrustdom command.


12 years agos3-rpcclient: add createtrustdom command.
Günther Deschner [Wed, 28 Oct 2009 13:13:32 +0000 (14:13 +0100)]
s3-rpcclient: add createtrustdom command.


12 years agos3-lsa: expand struct lsa_info to carry name and sd.
Günther Deschner [Thu, 29 Oct 2009 22:50:20 +0000 (23:50 +0100)]
s3-lsa: expand struct lsa_info to carry name and sd.


12 years agos3-lsa: use switch in _lsa_QuerySecurity().
Günther Deschner [Thu, 29 Oct 2009 11:36:30 +0000 (12:36 +0100)]
s3-lsa: use switch in _lsa_QuerySecurity().


12 years agos4-smbtorture: fix warning in RPC-WKSSVC torture test.
Günther Deschner [Fri, 30 Oct 2009 11:13:21 +0000 (12:13 +0100)]
s4-smbtorture: fix warning in RPC-WKSSVC torture test.


12 years agos4:kdc/hdb-samba4 - Remove unused variable
Matthias Dieter Wallnöfer [Fri, 30 Oct 2009 11:13:26 +0000 (12:13 +0100)]
s4:kdc/hdb-samba4 - Remove unused variable

12 years agoChange RAW-STREAMS for s3 to allow rename over an existing stream,
Jeremy Allison [Thu, 29 Oct 2009 23:38:34 +0000 (16:38 -0700)]
Change RAW-STREAMS for s3 to allow rename over an existing stream,
we need to file a CAR to find out why Windows gives INVALID_PARAMETER
for this.

12 years agoStart fixing the RAW-STREAMS test - ensure that the xattr
Jeremy Allison [Thu, 29 Oct 2009 23:14:12 +0000 (16:14 -0700)]
Start fixing the RAW-STREAMS test - ensure that the xattr
used to store the stream info in is not
seen in when enumerating EAs.

12 years agos3: Fix incorrect rc check of nscd_flush_cache.
Jim McDonough [Thu, 29 Oct 2009 15:11:43 +0000 (11:11 -0400)]
s3: Fix incorrect rc check of nscd_flush_cache.

At least this only resulted in an incorrect debug message.

12 years agos3-secrets: use autogenerated code for TRUSTED_DOM_PASS struct parsing from a tdb.
Günther Deschner [Wed, 28 Oct 2009 15:42:44 +0000 (16:42 +0100)]
s3-secrets: use autogenerated code for TRUSTED_DOM_PASS struct parsing from a tdb.


12 years agos3: add secrets.idl.
Günther Deschner [Wed, 28 Oct 2009 15:21:53 +0000 (16:21 +0100)]
s3: add secrets.idl.


12 years agotdb: update README a bit
Kirill Smelkov [Wed, 21 Oct 2009 17:18:58 +0000 (21:18 +0400)]
tdb: update README a bit

While studying tdb, I've noticed a couple of mismatches between readme
and actual code:

- tdb_open_ex changed it's log_fn argument to log_ctx
- there is now no tdb_update(), which it seems was transformed into
  non-exported tdb_update_hash()

There were other mismatches, but I don't remember them now, sorry.

Signed-off-by: Kirill Smelkov <>
Signed-off-by: Rusty Russell <>
12 years agotdb: add tests for double .close() in pytdb
Kirill Smelkov [Wed, 21 Oct 2009 17:18:57 +0000 (21:18 +0400)]
tdb: add tests for double .close() in pytdb

The reason I do it is that when using older python-tdb as shipped in
Debian Lenny, python interpreter crashes on this test:

    (gdb) bt
    #0  0xb7f8c424 in __kernel_vsyscall ()
    #1  0xb7df5640 in raise () from /lib/i686/cmov/
    #2  0xb7df7018 in abort () from /lib/i686/cmov/
    #3  0xb7e3234d in __libc_message () from /lib/i686/cmov/
    #4  0xb7e38624 in malloc_printerr () from /lib/i686/cmov/
    #5  0xb7e3a826 in free () from /lib/i686/cmov/
    #6  0xb7b39c84 in tdb_close () from /usr/lib/
    #7  0xb7b43e14 in ?? () from /var/lib/python-support/python2.5/
    #8  0x0a038d08 in ?? ()
    #9  0x00000000 in ?? ()

master's pytdb does not (we have a check for self->closed in obj_close()),
but still...

Signed-off-by: Kirill Smelkov <>
Signed-off-by: Rusty Russell <>
12 years agotdb: reset tdb->fd to -1 in tdb_close()
Kirill Smelkov [Wed, 21 Oct 2009 17:18:56 +0000 (21:18 +0400)]
tdb: reset tdb->fd to -1 in tdb_close()

So that erroneous double tdb_close() calls do not try to close() same
fd again. This is like SAFE_FREE() but for fd.

Signed-off-by: Kirill Smelkov <>
Signed-off-by: Rusty Russell <>
12 years agotdb: fix typo in python's Tdb.get() docstring
Kirill Smelkov [Wed, 21 Oct 2009 17:18:55 +0000 (21:18 +0400)]
tdb: fix typo in python's Tdb.get() docstring

It's Tdb.get(), not Tdb.fetch().

Signed-off-by: Kirill Smelkov <>
Signed-off-by: Rusty Russell <>
12 years agotdb: kill last bits from swig
Kirill Smelkov [Wed, 21 Oct 2009 17:18:54 +0000 (21:18 +0400)]
tdb: kill last bits from swig

We no longer use swig for pytdb, so there is no need for swig make
rules. Also pytdb.c header should be updated.

Signed-off-by: Kirill Smelkov <>
Signed-off-by: Rusty Russell <>
12 years agoFix map readonly in smb.conf, it is a single word
Simo Sorce [Wed, 28 Oct 2009 23:10:08 +0000 (19:10 -0400)]
Fix map readonly in smb.conf, it is a single word

12 years agoAdd in Metze's new code to ndr encode the user.DOSATTRIB
Stefan (metze) Metzmacher [Wed, 28 Oct 2009 22:42:47 +0000 (15:42 -0700)]
Add in Metze's new code to ndr encode the user.DOSATTRIB
blobs. Next I'll change the create timestamp and dos attribute
code to use this.

12 years agoFix bug 6572 - libsmbclient: unable to access 'msdfs proxy' share.
SATOH Fumiyasu [Wed, 28 Oct 2009 19:48:36 +0000 (12:48 -0700)]
Fix bug 6572 - libsmbclient: unable to access 'msdfs proxy' share.

12 years agos3:net: fix output of net rpc trustdom list
Björn Jacke [Wed, 28 Oct 2009 13:33:40 +0000 (14:33 +0100)]
s3:net: fix output of net rpc trustdom list

Move some messages from stderr to stdout. When some trusting DCs were
unreachable we lacked \n's on stdout which screwed up whole the output.

12 years agos3:configure: only check for gpfs_gpl.h
Stefan Metzmacher [Wed, 28 Oct 2009 10:21:27 +0000 (11:21 +0100)]
s3:configure: only check for gpfs_gpl.h

The header is everything we need in order to build vfs_gpfs.


Signed-off-by: Michael Adam <>
12 years agos3-passdb: move open_schannel_session_store() to passdb/secrets_schannel.c.
Günther Deschner [Wed, 28 Oct 2009 10:36:13 +0000 (11:36 +0100)]
s3-passdb: move open_schannel_session_store() to passdb/secrets_schannel.c.


12 years agos3-net: acct_flags are uint32_t in net_sam_set_userflag().
Günther Deschner [Wed, 28 Oct 2009 09:56:01 +0000 (10:56 +0100)]
s3-net: acct_flags are uint32_t in net_sam_set_userflag().


12 years agoadssearch: dump some more nttime timestamps.
Günther Deschner [Wed, 28 Oct 2009 09:55:14 +0000 (10:55 +0100)]
adssearch: dump some more nttime timestamps.


12 years agos3-lsa: add lsa_trusted_domain_mapping.
Günther Deschner [Tue, 27 Oct 2009 14:29:02 +0000 (15:29 +0100)]
s3-lsa: add lsa_trusted_domain_mapping.


12 years agolsa: add LSA_TRUSTED_DOMAIN access masks.
Günther Deschner [Tue, 27 Oct 2009 14:28:06 +0000 (15:28 +0100)]
lsa: add LSA_TRUSTED_DOMAIN access masks.


12 years agos3-passdb: add secrets_delete_generic().
Günther Deschner [Tue, 27 Oct 2009 13:59:25 +0000 (14:59 +0100)]
s3-passdb: add secrets_delete_generic().


12 years agos3-lsa: add lsa_secret_mapping.
Günther Deschner [Tue, 27 Oct 2009 12:50:43 +0000 (13:50 +0100)]
s3-lsa: add lsa_secret_mapping.


12 years agolsa: add LSA_SECRET access masks.
Günther Deschner [Tue, 27 Oct 2009 12:49:21 +0000 (13:49 +0100)]
lsa: add LSA_SECRET access masks.


12 years agos3-lsa: use correct function name in_lsa_RemoveAccountRights().
Günther Deschner [Mon, 26 Oct 2009 22:47:01 +0000 (23:47 +0100)]
s3-lsa: use correct function name in_lsa_RemoveAccountRights().


12 years agos3-lsa: pure cosmetic indentation fixes.
Günther Deschner [Mon, 26 Oct 2009 22:37:21 +0000 (23:37 +0100)]
s3-lsa: pure cosmetic indentation fixes.


12 years agos3-lsa: use enum lsa_LookupNamesLevel in lsa_lookup_level_to_flags().
Günther Deschner [Mon, 26 Oct 2009 22:28:30 +0000 (23:28 +0100)]
s3-lsa: use enum lsa_LookupNamesLevel in lsa_lookup_level_to_flags().


12 years agoldb:tdb backend - be also here more careful with the result value
Matthias Dieter Wallnöfer [Tue, 27 Oct 2009 18:40:57 +0000 (19:40 +0100)]
ldb:tdb backend - be also here more careful with the result value

"msg_delete_attribute" doesn't return an LDB result constant.

12 years agoldb:python bindings - make the intention by Jelmer ("int" vs. "enum") more clear
Matthias Dieter Wallnöfer [Tue, 27 Oct 2009 18:11:15 +0000 (19:11 +0100)]
ldb:python bindings - make the intention by Jelmer ("int" vs. "enum") more clear

12 years agoRevert "ldb python bindungs - better use the "enum ldb_scope" for the search scope...
Matthias Dieter Wallnöfer [Tue, 27 Oct 2009 18:07:53 +0000 (19:07 +0100)]
Revert "ldb python bindungs - better use the "enum ldb_scope" for the search scope rather than "int""

This reverts commit 4f8826ff7f4789c5b5f363b733a42053f72aa526.

Jelmer pointed out that the "enum"s don't work so well in combination with python.

12 years agos3/docs: Document new pdbedit -K option.
Karolin Seeger [Tue, 27 Oct 2009 15:04:35 +0000 (16:04 +0100)]
s3/docs: Document new pdbedit -K option.


12 years agos3: pdbedit: add option --kickoff-time/-K to set the user's kickoff time
Michael Adam [Mon, 26 Oct 2009 15:07:58 +0000 (16:07 +0100)]
s3: pdbedit: add option --kickoff-time/-K to set the user's kickoff time

Use "never" as argument to set this to unlimited.


12 years agos4-dsdb: call dsdb_make_schema_global() from ldb_wrap
Andrew Tridgell [Tue, 27 Oct 2009 09:30:53 +0000 (20:30 +1100)]
s4-dsdb: call dsdb_make_schema_global() from ldb_wrap

Calling it from samdb_connect() can cause a stale schema to be put
into the global schema.

Thanks to Andrew Bartlett for spotting this.

12 years agoSecond part of the fix for bug 6828 - infinite timeout occurs when byte lock held...
Jeremy Allison [Tue, 27 Oct 2009 04:20:22 +0000 (21:20 -0700)]
Second part of the fix for bug 6828 - infinite timeout occurs when byte lock held outside of samba.
Fixes case where a connection with a pending lock can me marked "idle", and ensures
that the lock queue timeout is always recalculated.

12 years agos4-dsdb: always cancel transactions on all partitions
Andrew Tridgell [Tue, 27 Oct 2009 01:13:46 +0000 (12:13 +1100)]
s4-dsdb: always cancel transactions on all partitions

If we get an error ending a transaction on one partition we need to
continue on the other partitions.

12 years agos4-ldb: '+' can also happen in base64 encoded index DNs
Andrew Tridgell [Tue, 27 Oct 2009 00:44:05 +0000 (11:44 +1100)]
s4-ldb: '+' can also happen in base64 encoded index DNs

12 years agos4:ldb Add detail to failures in the indexing code
Andrew Bartlett [Tue, 27 Oct 2009 00:10:49 +0000 (11:10 +1100)]
s4:ldb Add detail to failures in the indexing code

12 years agos4:dsdb Rework partitions module for better tracing
Andrew Bartlett [Mon, 26 Oct 2009 23:54:16 +0000 (10:54 +1100)]
s4:dsdb Rework partitions module for better tracing

This means we need to create a fake 'module' which only has a 'next'
pointer, so that we can now ldb_next_request() (which incorporates
tracing).  The remainaing stub of partition_request() is retained so
that we can indicate which partition an operation is destined for.

Similar tracing is added to the transaction handlers.

Andrew Bartlett

12 years agos4:ldb Add additional tracing of the ldb API
Andrew Bartlett [Mon, 26 Oct 2009 23:43:51 +0000 (10:43 +1100)]
s4:ldb Add additional tracing of the ldb API

This helps pin down where errors occour, by printing a call stack and
setting error strings and trace messages in the transaction case.

Andrew Bartlett

12 years agos4:dsdb Remove partition_extended_schema_update_now
Andrew Bartlett [Sun, 25 Oct 2009 23:23:10 +0000 (10:23 +1100)]
s4:dsdb Remove partition_extended_schema_update_now

The schema update now request is now handled above the partitions

Andrew Bartlett

12 years agos3: Rename new parameter "ldap ref follow" to "ldap follow referral".
Karolin Seeger [Mon, 26 Oct 2009 11:11:59 +0000 (12:11 +0100)]
s3: Rename new parameter "ldap ref follow" to "ldap follow referral".

This parameter will be introduced with Samba 3.5.0.


12 years agos3:docs: Public is not a synonym for access based shareenum.
Karolin Seeger [Mon, 26 Oct 2009 09:14:51 +0000 (10:14 +0100)]
s3:docs: Public is not a synonym for access based shareenum.

Fix build warning.