ira/wip.git
13 years agoOnly add WBFLAG_PAM_CONTACT_TRUSTDOM when performing a krb5 auth request.
Gerald W. Carter [Thu, 27 Mar 2008 16:57:26 +0000 (11:57 -0500)]
Only add WBFLAG_PAM_CONTACT_TRUSTDOM when performing a krb5 auth request.

NTLM logons must go against our DC.
(This used to be commit 2e24f7c0243c67a00102c11258cfa6f61caf499f)

13 years agoDon't fill password policy structure for any domain other than our own.
Gerald W. Carter [Thu, 27 Mar 2008 16:56:29 +0000 (11:56 -0500)]
Don't fill password policy structure for any domain other than our own.

The samr connects will fail.  This is not independent of the CONTACT_TRUSTDOM
flag neede by krb5 logins.
(This used to be commit 4de4949e3bfcfb2169c329f19cb76936d9043d50)

13 years agoFix wbinfo -a trusted\\user%password on a Samba DC with trusts
Volker Lendecke [Thu, 27 Mar 2008 12:00:23 +0000 (13:00 +0100)]
Fix wbinfo -a trusted\\user%password on a Samba DC with trusts

Winbind can't be allowed to connect to the local smbd.
(This used to be commit 0d617f639a3c9c52e4327aed4bd02d9e8e7312a2)

13 years agoRemove unused DS_DOMAIN_CONTROLLER_INFO struct.
Günther Deschner [Thu, 27 Mar 2008 11:05:01 +0000 (12:05 +0100)]
Remove unused DS_DOMAIN_CONTROLLER_INFO struct.

Guenther
(This used to be commit 7eb4f6f6f9f27cda3d512f4042e36d70d0b26b6b)

13 years agoFix samlogon rpc client & server.
Günther Deschner [Thu, 27 Mar 2008 12:03:12 +0000 (13:03 +0100)]
Fix samlogon rpc client & server.

Guenther
(This used to be commit 0aaf975560dce3b4e58ab71687c3412c0c2a72cf)

13 years agoRe-run make idl.
Günther Deschner [Thu, 27 Mar 2008 11:57:03 +0000 (12:57 +0100)]
Re-run make idl.

Guenther
(This used to be commit 3f5fa596632077b0ffed1046d0a2fb6a011b16ea)

13 years agoMove netr_LogonLevel flags to IDL, rename old one to netr_LogonInfo.
Günther Deschner [Thu, 27 Mar 2008 11:03:20 +0000 (12:03 +0100)]
Move netr_LogonLevel flags to IDL, rename old one to netr_LogonInfo.

Guenther
(This used to be commit 1fc98ee431d3ebe0c5d8bed55dcb788c16228ddd)

13 years agoMove DSGETDC_VALID_FLAGS to IDL.
Günther Deschner [Thu, 27 Mar 2008 11:04:22 +0000 (12:04 +0100)]
Move DSGETDC_VALID_FLAGS to IDL.

Guenther
(This used to be commit a14b00ee19c6dc23ff687e57e8e6340702056317)

13 years agoMove LOGON_KRB5_FAIL_CLOCK_SKEW to winbindd_pam.
Günther Deschner [Thu, 27 Mar 2008 11:02:18 +0000 (12:02 +0100)]
Move LOGON_KRB5_FAIL_CLOCK_SKEW to winbindd_pam.

Guenther
(This used to be commit fa64c76ac8e54f385f277b5b39be70075b2eeee0)

13 years agoMove the known NETLOGON_CONTROL reply flags to IDL.
Günther Deschner [Thu, 27 Mar 2008 11:01:13 +0000 (12:01 +0100)]
Move the known NETLOGON_CONTROL reply flags to IDL.

Guenther
(This used to be commit 4bf2a17c2b9abff45afd50ea93b96b2a080d9168)

13 years agoMove inline comment about MSV1_0 flags to IDL.
Günther Deschner [Thu, 27 Mar 2008 10:58:19 +0000 (11:58 +0100)]
Move inline comment about MSV1_0 flags to IDL.

Guenther
(This used to be commit b22167fb608d3948f1473a5f3dee9e8d18e282e3)

13 years agolibwbclient: fix Coverity ID 536 remove duplicate error path (dead code).
Michael Adam [Thu, 27 Mar 2008 10:51:31 +0000 (11:51 +0100)]
libwbclient: fix Coverity ID 536 remove duplicate error path (dead code).

I leave the more explicit error path in the "if (cmd == 0)" block.

Michael
(This used to be commit 2ae19b5fb89e0a992962af14a81b641bf13b7892)

13 years agolibreplace: fix coverity ID 517 - untangle close from open in test/os2_delete.c
Michael Adam [Thu, 27 Mar 2008 10:26:33 +0000 (11:26 +0100)]
libreplace: fix coverity ID 517 - untangle close from open in test/os2_delete.c

This is not a proper bug but the code is clearer now
and we are tracking failure of open separate from that of close.

Michael
(This used to be commit 451fc9ae05f841883081a334e179cf31625a772c)

13 years agoRe-run make idl.
Günther Deschner [Thu, 27 Mar 2008 10:04:01 +0000 (11:04 +0100)]
Re-run make idl.

Guenther
(This used to be commit e16ca32b8e0485ceafee6a2ff62dc88e96329ec4)

13 years agoUse netr_LogonControlCode in netr_LogonControl2().
Günther Deschner [Thu, 27 Mar 2008 10:01:55 +0000 (11:01 +0100)]
Use netr_LogonControlCode in netr_LogonControl2().

Guenther
(This used to be commit 8474ef334fd0ff05ee67a49ad7c39687117b49d9)

13 years agoposix_acls: clarify loop condition code, removing unneeded counter variable.
Michael Adam [Thu, 27 Mar 2008 09:09:24 +0000 (10:09 +0100)]
posix_acls: clarify loop condition code, removing unneeded counter variable.

Coverity ID 545 falsely classified this as a NULL dereferencing bug.
By putting the loop of walking the list of aces more naturely not using
additional counters, it becomes much more obvious that it is not entered
when dir_ace == NULL.

The same modifications are done for the file_ace loop.

Michael
(This used to be commit 6dab6cf0647d7db01e5e472f8b5cf21395b7dbf0)

13 years agoFix typo.
Günther Deschner [Wed, 26 Mar 2008 21:25:51 +0000 (22:25 +0100)]
Fix typo.

Guenther
(This used to be commit ffe77dc8b0476b7a5d81d63c3cf67f81033df12e)

13 years agonet_conf: fix non-testmode import function.
Michael Adam [Wed, 26 Mar 2008 23:32:00 +0000 (00:32 +0100)]
net_conf: fix non-testmode import function.

Michael
(This used to be commit cd17cc745a35db8ee158f59a5fff1f0f26cf9c6e)

13 years agolibsmbconf: text - pass the cache instead of all private data to pm_process.
Michael Adam [Wed, 26 Mar 2008 22:58:52 +0000 (23:58 +0100)]
libsmbconf: text - pass the cache instead of all private data to pm_process.

Michael
(This used to be commit ee46f0eca6ea21d0c51103252fecf911bb448687)

13 years agolibsmbconf: text - change the cache to be talloced
Michael Adam [Wed, 26 Mar 2008 22:58:01 +0000 (23:58 +0100)]
libsmbconf: text - change the cache to be talloced

instead of having it directly as a member in the private data struct.
This makes it easier to flush and initialize the cache.

Michael
(This used to be commit 03efb72b4632e2bbb0838ca56a3e556448bda5c5)

13 years agolibsmbconf: in text backend, put flushing of the cache into a helper function.
Michael Adam [Wed, 26 Mar 2008 22:11:04 +0000 (23:11 +0100)]
libsmbconf: in text backend, put flushing of the cache into a helper function.

And use it also in the close operation.

Michael
(This used to be commit 8cb288124993eb59459e7e9777c65e58c0554d55)

13 years agoFix a bug in the output from print_canonical_sockaddr() fix from 36f8bafbd3dee66a8....
Gerald W. Carter [Wed, 26 Mar 2008 21:58:27 +0000 (16:58 -0500)]
Fix a bug in the output from print_canonical_sockaddr() fix from 36f8bafbd3dee66a8....

Make sure that IPv4 addresses are not enclised in []'s.
(This used to be commit 4ddf58dbdc3d74cb72788ef4a2ec7587d4948c40)

13 years agoFix winbind NETLOGON cred chain on a samba dc for w2k8 trusts.
Günther Deschner [Wed, 26 Mar 2008 20:08:53 +0000 (21:08 +0100)]
Fix winbind NETLOGON cred chain on a samba dc for w2k8 trusts.

Guenther
(This used to be commit 2586dc34e0f72204749f5bf10c8135cd3a753a42)

13 years agoRe-run make idl.
Günther Deschner [Wed, 26 Mar 2008 18:27:18 +0000 (19:27 +0100)]
Re-run make idl.

Guenther
(This used to be commit 9024aecdbf5d4df9996625f0cc8ce8a5ecdd247e)

13 years agoFix IDL for netr_NETLOGON_INFO_2.
Günther Deschner [Wed, 26 Mar 2008 18:25:54 +0000 (19:25 +0100)]
Fix IDL for netr_NETLOGON_INFO_2.

W2k8 generated NT_STATUS_ARRAY_BOUNDS_EXCEEDED errors while validating trusts.

Guenther
(This used to be commit 5d0aa3bbf8e56f5d2a1ab4d037d7fd146b095f9d)

13 years agoFix _netr_LogonControl2(). Return talloced dcname.
Günther Deschner [Wed, 26 Mar 2008 18:18:08 +0000 (19:18 +0100)]
Fix _netr_LogonControl2(). Return talloced dcname.

Guenther
(This used to be commit 42971b71acec9c9fd94011c06d41702dac6b4f87)

13 years agoAdd ntsvcs_getdevregprop command to rpcclient.
Günther Deschner [Mon, 18 Feb 2008 01:40:55 +0000 (02:40 +0100)]
Add ntsvcs_getdevregprop command to rpcclient.

Guenther
(This used to be commit 4abe30fdae511422dccd04d0287d962192beadcb)

13 years agonet_conf: reformat - re-indent one function call.
Michael Adam [Wed, 26 Mar 2008 13:46:43 +0000 (14:46 +0100)]
net_conf: reformat - re-indent one function call.

Michael
(This used to be commit 9ef9d4c4e77523d7f3cc5fdac199559896e585bd)

13 years agonet_conf: add casts to avoid compiler warnings.
Michael Adam [Wed, 26 Mar 2008 13:45:34 +0000 (14:45 +0100)]
net_conf: add casts to avoid compiler warnings.

Michael
(This used to be commit 1c6b9a0ac34c4a7b4e000300db8dffdbb09fe7da)

13 years agonet_conf: rename "ctx" to "mem_ctx" for clarity.
Michael Adam [Wed, 26 Mar 2008 13:39:02 +0000 (14:39 +0100)]
net_conf: rename "ctx" to "mem_ctx" for clarity.

There are also smbconf contexts arount...

Michael
(This used to be commit 5171df66eb54c9819b3b40045755f5e9b2cf36c2)

13 years agonet_conf: use talloc_stackframe() instead of talloc_init().
Michael Adam [Wed, 26 Mar 2008 13:34:21 +0000 (14:34 +0100)]
net_conf: use talloc_stackframe() instead of talloc_init().

Michael
(This used to be commit ab4fd03705c61114742d8438dece69b9c37c3b38)

13 years agonet_conf: fix import function by using the new text backend of smbconf.
Michael Adam [Wed, 26 Mar 2008 13:33:22 +0000 (14:33 +0100)]
net_conf: fix import function by using the new text backend of smbconf.

Originally, lp_load() was used to import files to registry.
This had several bugs. Most notably, options explicitly set to
default values were silently dropped, and all parametric options
were ignored.

This new implementation reads config from the text backend and
stuffs everything verbatim in to the registry backend.

Michael
(This used to be commit e41c6650f805eaf8bb009e34468dd2d311e52858)

13 years agolibsmbconf: add a text backend to libsmbconf based on the params.c parser.
Michael Adam [Wed, 26 Mar 2008 13:30:36 +0000 (14:30 +0100)]
libsmbconf: add a text backend to libsmbconf based on the params.c parser.

This is a simple implementation of text backend for libsmbconf.
It is read only. It uses the parser from params.c. It loads the
given config file and holds the parsed lists of strings in memory.
Config is only re-read if the time stamp of the config file has changed.
Brilliant performance on large files is not to be expected since the
string lists are not hashed. This might be added in the future.

Michael
(This used to be commit 4ea50843852b335a9bd4c0535a5b684134ad8326)

13 years agoloadparm: add userdata parameter to do_section() and do_parameter().
Michael Adam [Tue, 25 Mar 2008 21:53:47 +0000 (22:53 +0100)]
loadparm: add userdata parameter to do_section() and do_parameter().

The userdata is currently unused. It can be used in the future for
passing a context like in samba4 code.

Michael
(This used to be commit 31b31171bd88c41443268d3300c492e2347b9e73)

13 years agoWHATSNEW: Start to add changes since 3.2.0pre2.
Karolin Seeger [Wed, 26 Mar 2008 13:02:48 +0000 (14:02 +0100)]
WHATSNEW: Start to add changes since 3.2.0pre2.

Karolin
(This used to be commit 2b18b4d02aaf5d64fbcd0d60d4da1bd4837f6220)

13 years agoStrip whitespace in ntsvcs rpc server.
Günther Deschner [Wed, 26 Mar 2008 10:45:28 +0000 (11:45 +0100)]
Strip whitespace in ntsvcs rpc server.

Guenther
(This used to be commit 0c7af8bc136f45484eab3c36b761046f88653b93)

13 years agoRe-run make idl.
Günther Deschner [Wed, 26 Mar 2008 10:35:44 +0000 (11:35 +0100)]
Re-run make idl.

Guenther
(This used to be commit f67632f9b244800007bfaef9cc2ab932fda78b3c)

13 years agoFill in IDL for PNP_GetDeviceRegProp.
Günther Deschner [Mon, 18 Feb 2008 01:37:26 +0000 (02:37 +0100)]
Fill in IDL for PNP_GetDeviceRegProp.

Guenther
(This used to be commit b1b6e93aa1f1b6d80969b6e5dd8f723e21ae8ce8)

13 years agoComment out some svcctl headers which are now defined in IDL.
Günther Deschner [Wed, 26 Mar 2008 10:32:12 +0000 (11:32 +0100)]
Comment out some svcctl headers which are now defined in IDL.

Guenther
(This used to be commit 2201a8118c6abae3425dd5728af129bb8f71b564)

13 years agoRe-run make idl.
Günther Deschner [Wed, 26 Mar 2008 10:36:41 +0000 (11:36 +0100)]
Re-run make idl.

Guenther
(This used to be commit 0d8181dab75887231a168f910203e53ec54fa4eb)

13 years agoAdd svcctl_MgrAccessMask and svcctl_ServiceAccessMask.
Günther Deschner [Tue, 25 Mar 2008 18:07:48 +0000 (19:07 +0100)]
Add svcctl_MgrAccessMask and svcctl_ServiceAccessMask.

Guenther
(This used to be commit eeb7c7d9d0c9f7ac171641bc8cafe20db704fdc4)

13 years agosmbconf: reformat - fix intentation.
Michael Adam [Wed, 26 Mar 2008 09:55:26 +0000 (10:55 +0100)]
smbconf: reformat - fix intentation.

This time this won't make me stumble, since there is no
magic in indented function headers here - no automatic
prototype generation... :-)

Michael
(This used to be commit 6d72fc4373adff01cf6e0e18f78082d1eab90064)

13 years agoutil_tdb: remove trivial and unused tdb_wipe().
Michael Adam [Wed, 26 Mar 2008 10:13:47 +0000 (11:13 +0100)]
util_tdb: remove trivial and unused tdb_wipe().

It has been replaced by tdb_wipe_all().

Michael
(This used to be commit cdde2e4eaca51d51f036ad99d55df7bfd6535b03)

13 years agouse tdb_wipe_all() instead of tdb_wipe() - it is faster...
Michael Adam [Wed, 26 Mar 2008 09:50:08 +0000 (10:50 +0100)]
use tdb_wipe_all() instead of tdb_wipe() - it is faster...

Michael
(This used to be commit 3d2fdcd50fdbfb66a14360516836445d47eceeb0)

13 years agoutil_tdb: make the _byblob fetch/store functions public again.
Michael Adam [Wed, 26 Mar 2008 09:45:53 +0000 (10:45 +0100)]
util_tdb: make the _byblob fetch/store functions public again.

Users of these are currently being written...

Michael
(This used to be commit 1c51bec5318bad085c09931aa7e8f72f41d103fe)

13 years agoFix wbcAuthenticateUserEx().
Günther Deschner [Wed, 26 Mar 2008 00:27:36 +0000 (01:27 +0100)]
Fix wbcAuthenticateUserEx().

Guenther
(This used to be commit 79f7a519f8f61a31d84467c5b5975cae13db1c29)

13 years agoAdd debug statement in auth_winbind to display wbcAuthenticateUserEx error code.
Günther Deschner [Wed, 26 Mar 2008 00:25:57 +0000 (01:25 +0100)]
Add debug statement in auth_winbind to display wbcAuthenticateUserEx error code.

Guenther
(This used to be commit 0ad00a452f03d8af6e6b6fabd4a05ca26a9910d0)

13 years agoFix a valgrind error
Volker Lendecke [Tue, 25 Mar 2008 21:35:20 +0000 (22:35 +0100)]
Fix a valgrind error

In winbind, we're using the info3 struct to send it to the winbind client after
netsamlogon_cache_store. Without this info3->base.account_name.string was
prematurely freed.
(This used to be commit aa4377561b691e2c5108c18aeb34fff39d8775df)

13 years agoFix a segfault
Volker Lendecke [Tue, 25 Mar 2008 21:21:50 +0000 (22:21 +0100)]
Fix a segfault

When we get a NT_STATUS_WRONG_PASSWORD for example, my_info3 is not initialized
at all. So first check that we have NT_STATUS_IS_OK(status) before we
dereference my_info3.
(This used to be commit 559cd9e5a7fac3ce3769d457132cdcb28569b93d)

13 years agoFix typo
Volker Lendecke [Tue, 25 Mar 2008 20:35:41 +0000 (21:35 +0100)]
Fix typo
(This used to be commit 38683a73013865695e1b04f5f6a974bd0c5c1cac)

13 years agoRe-run make idl (after pidl change for adding header info to cli_ functions).
Günther Deschner [Tue, 25 Mar 2008 16:52:33 +0000 (17:52 +0100)]
Re-run make idl (after pidl change for adding header info to cli_ functions).

Guenther
(This used to be commit 492c26a9367d93802d3b6a9271dde16c49fffe69)

13 years agoutil_tdb: add my (C) for the tdb validation code
Michael Adam [Tue, 25 Mar 2008 14:55:03 +0000 (15:55 +0100)]
util_tdb: add my (C) for the tdb validation code

Michael
(This used to be commit abf02a5a142c55d9e0053d319c867e4fcc3e6c30)

13 years agoutil_tdb: add a wrapper tdb_wipe() for traverse with tdb_traverse_delete_fn().
Michael Adam [Tue, 25 Mar 2008 13:18:08 +0000 (14:18 +0100)]
util_tdb: add a wrapper tdb_wipe() for traverse with tdb_traverse_delete_fn().

Replace all callers of traverse with this tdb_traverse_delete_fn() and
don't export tdb_traverse_delete_fn() anymore.

Michael
(This used to be commit d4be4e30cd8c3bdc303da30e42280f892a45a8c9)

13 years agoutil_tdb: add the tdb_pack_append() prototype to util_tdb.h
Michael Adam [Tue, 25 Mar 2008 12:53:31 +0000 (13:53 +0100)]
util_tdb: add the tdb_pack_append() prototype to util_tdb.h

This function is currently not used but seems useful.

Michael
(This used to be commit 48149a954c1e737c9863cfa0991ab9bfc246c6da)

13 years agoutil_tdb: make the _byblob functions static - not currently used elsewhere.
Michael Adam [Tue, 25 Mar 2008 12:52:32 +0000 (13:52 +0100)]
util_tdb: make the _byblob functions static - not currently used elsewhere.

Michael
(This used to be commit b42cf3fc69414270be9d0f430f2e95a72894f00e)

13 years agoutil_tdb: group prototypes in util_tdb.h thematically
Michael Adam [Tue, 25 Mar 2008 12:41:51 +0000 (13:41 +0100)]
util_tdb: group prototypes in util_tdb.h thematically

Michael
(This used to be commit 4b9231d33eaea2ada5d67cc1d959df2b671e7bb9)

13 years agobuild: don't autogenerate prototypes for util_tdb and dbwrap anymore.
Michael Adam [Tue, 25 Mar 2008 11:54:14 +0000 (12:54 +0100)]
build: don't autogenerate prototypes for util_tdb and dbwrap anymore.

Stick to hand-written headers (that are there anyways).
Add some missing prototypes to util_tdb.h and dbwrap.h.

I did not bother to add a header for each single dbwrap backend
open function but put the prototypes for the open functions into
the central dbwrap.h.

Michael
(This used to be commit edf4dbed27a3c63c04e8110e75cdb76e31627eb6)

13 years agoFix usage message for 'net idmap dump'.
Karolin Seeger [Tue, 25 Mar 2008 11:00:42 +0000 (12:00 +0100)]
Fix usage message for 'net idmap dump'.

Karolin
(This used to be commit c967b62dd3c924419fa4a72aa2143d6bef959d18)

13 years agoFix _winreg_QueryValue().
Günther Deschner [Tue, 25 Mar 2008 09:11:47 +0000 (10:11 +0100)]
Fix _winreg_QueryValue().

Guenther
(This used to be commit b217dd674e22b6a7cc492f1a84a37ddc4ddca663)

13 years agoRe-run make idl.
Günther Deschner [Mon, 24 Mar 2008 10:48:16 +0000 (11:48 +0100)]
Re-run make idl.

Guenther
(This used to be commit 1570e1c597b43d83318860590b58e32143275f82)

13 years agoFix IDL for winreg_QueryValue.
Günther Deschner [Mon, 24 Mar 2008 10:46:51 +0000 (11:46 +0100)]
Fix IDL for winreg_QueryValue.

Guenther
(This used to be commit 0dac766109a0f76fd27832f5344460f1afdb2046)

13 years agoIgnore port when pulling IP addr from struct sockaddr_storage.
Gerald (Jerry) Carter [Mon, 24 Mar 2008 19:48:29 +0000 (14:48 -0500)]
Ignore port when pulling IP addr from struct sockaddr_storage.

Linux man page states that getaddinfo() will leave the port
uninitialized when passing in NULL for the service name.  So we
can't really trust that anymore.  I doubt non-default KDC ports
are an issues so just drop the port from the generated krb5.conf.
AIX exhibits this bug the most.
(This used to be commit 36f8bafbd3dee66a869aa26cfc2eb4aa62019325)

13 years agoFix libtdb some to move back towards allowing out of tree builds
Gerald (Jerry) Carter [Mon, 24 Mar 2008 19:27:01 +0000 (14:27 -0500)]
Fix libtdb some to move back towards allowing out of tree builds

Remaining problem is that not all *.syms linker scripts are generated
so the LD command needs to look in a single place.  Out of tree
builds now work but report write access to the source tree in order
to create the $(srcdir)/expotrs/libtdb.sysms file.
(This used to be commit 6e9287c5c3a6bbd15ec495593978c1a76e64ee60)

13 years agoMissing HAVE_UPDWTMPX check before using updwtmpx().
Eric Cronin [Mon, 24 Mar 2008 19:33:04 +0000 (12:33 -0700)]
Missing HAVE_UPDWTMPX check before using updwtmpx().

In 10.5 Mac OS X added enough utmpx support to make it past the
first two preprocessor checks around line 390 of src/smbd/utmp.c
and on to the utmpx block which uses updwtmpx().  Unfortunately,
as ./configure correctly surmised, 10.5 doesn't have that.

https://bugzilla.samba.org/show_bug.cgi?id=5184
(This used to be commit f19d1e3d93d0d9dfe80372c6c5635f1047f9aa88)

13 years agoFix Coverity ID 514
Volker Lendecke [Sun, 23 Mar 2008 18:43:36 +0000 (19:43 +0100)]
Fix Coverity ID 514

Not exactly an uninitialized variable, but having Coverity figure out that
we're only UNMARSHALLING here is probably asking for a bit too much.
(This used to be commit 07a9f7daa83c94afefe0d81db4812135121862c2)

13 years agoFix Coverity ID 504
Volker Lendecke [Sun, 23 Mar 2008 18:38:50 +0000 (19:38 +0100)]
Fix Coverity ID 504
(This used to be commit 4e6f8a19a6861c332ee6e9b49551e12440eefdc2)

13 years agoFix Coverity ID 503
Volker Lendecke [Sun, 23 Mar 2008 18:38:02 +0000 (19:38 +0100)]
Fix Coverity ID 503
(This used to be commit 5c43c38271bae7d96d0cfbdaba7bff838a684b40)

13 years agoFix Coverity ID 488
Volker Lendecke [Sun, 23 Mar 2008 18:30:47 +0000 (19:30 +0100)]
Fix Coverity ID 488

"status" was used uninitialized on success -- metze, please check
(This used to be commit a0859529c853ffb756b1deee946923b6fff6136e)

13 years agoFix Coverity ID 487
Volker Lendecke [Sun, 23 Mar 2008 18:26:35 +0000 (19:26 +0100)]
Fix Coverity ID 487
(This used to be commit 22cee9c1afbc33b4920b72bc81569d79642172af)

13 years agoFix Coverity ID 471
Volker Lendecke [Sun, 23 Mar 2008 17:10:28 +0000 (18:10 +0100)]
Fix Coverity ID 471
(This used to be commit d3b6df67fea0da5ffa962837400ebe07b34a5384)

13 years agoFix Coverity ID 472
Volker Lendecke [Sun, 23 Mar 2008 17:08:13 +0000 (18:08 +0100)]
Fix Coverity ID 472

Simo, S4 also has this code. You might want to cherry-pick.

Volker
(This used to be commit 94c29f55937e50dcf49124d28ad4e82c7fb4133e)

13 years agoFix Coverity ID 477
Volker Lendecke [Sun, 23 Mar 2008 16:58:26 +0000 (17:58 +0100)]
Fix Coverity ID 477
(This used to be commit f17b1b0fc6340d21f1a2f43aa7eb2e87f851c51f)

13 years agoFix Coverity ID 478
Volker Lendecke [Sun, 23 Mar 2008 16:57:01 +0000 (17:57 +0100)]
Fix Coverity ID 478
(This used to be commit 5f77938dc4a280b654b8d08656f19a7d04cea8c7)

13 years agoFix Coverity ID 479
Volker Lendecke [Sun, 23 Mar 2008 16:54:48 +0000 (17:54 +0100)]
Fix Coverity ID 479
(This used to be commit 70b33397ba6e18f40087fb642a1be62ee68d5f3a)

13 years agoFix Coverity ID 480
Volker Lendecke [Sun, 23 Mar 2008 16:53:05 +0000 (17:53 +0100)]
Fix Coverity ID 480
(This used to be commit 45677e8694f0e383baa65712faec6a565ec0ce5c)

13 years agoFix Coverity ID 450
Volker Lendecke [Sun, 23 Mar 2008 16:50:55 +0000 (17:50 +0100)]
Fix Coverity ID 450
(This used to be commit 700cceb6940c95997cfef374cffd50729a35528a)

13 years agoFix Coverity ID 453
Volker Lendecke [Sun, 23 Mar 2008 16:49:04 +0000 (17:49 +0100)]
Fix Coverity ID 453
(This used to be commit 8f875674e7cf9ebd405561b1e3ab72b0284ce321)

13 years agoFix Coverity ID 462
Volker Lendecke [Sun, 23 Mar 2008 16:32:46 +0000 (17:32 +0100)]
Fix Coverity ID 462
(This used to be commit 9cf1e16a9c3cade9cd905f719de07578b3a91b1e)

13 years agoFix Coverity ID 432
Volker Lendecke [Sun, 23 Mar 2008 14:58:09 +0000 (15:58 +0100)]
Fix Coverity ID 432
(This used to be commit 7070c77ee2a9c3c9ff1b3c7b93008b13b80ac02b)

13 years agoFix Coverity ID 436
Volker Lendecke [Sun, 23 Mar 2008 14:56:41 +0000 (15:56 +0100)]
Fix Coverity ID 436
(This used to be commit 9e0ee1ad4fe0f0e7dec0b6824ef234147d845b8d)

13 years agoFix Coverity warnings
Volker Lendecke [Sun, 23 Mar 2008 14:51:52 +0000 (15:51 +0100)]
Fix Coverity warnings

ID 449, 448, 447, 446, 445, 444, 443, 442, 441, 440, 439, 438, 437
(This used to be commit 0d50b4ee9068d04d1d9eb7786e08775d7ba16bc8)

13 years agoVERSION: Update pre release number.
Karolin Seeger [Sun, 23 Mar 2008 06:28:13 +0000 (07:28 +0100)]
VERSION: Update pre release number.

Karolin
(This used to be commit 4e609ffb2f9983362f817c1346e0a4116d2dd74a)

13 years agolibgpo: open the registry in gp_init_reg_ctx().
Michael Adam [Sat, 22 Mar 2008 01:45:04 +0000 (02:45 +0100)]
libgpo: open the registry in gp_init_reg_ctx().

I forgot the regdb_open() call: registry_init_basic() closes
the registry in the end... sorry.

Michael
(This used to be commit 4185ed03a3879ab708b004ef87b9ffaa6a9e6f3d)

13 years agolibgpo: replace hand-crafted registry initialization by registry_init_basic.
Michael Adam [Sat, 22 Mar 2008 01:29:02 +0000 (02:29 +0100)]
libgpo: replace hand-crafted registry initialization by registry_init_basic.

IMO there is no need to imitate a custom registry backend.
Only default regdb hooks are used here, so a plain initialization
of regdb should suffice.

This way, only reg_api is used in libgpo, and no registry
backend code is visible.

Michael
(This used to be commit 10ae8accb486956ebb1638cee540868a11623b11)

13 years agolibgpo: use reg_setkeysecurity() instead of regdb_set_secdesc().
Michael Adam [Sat, 22 Mar 2008 01:22:54 +0000 (02:22 +0100)]
libgpo: use reg_setkeysecurity() instead of regdb_set_secdesc().

That is, use the reg_api function instead of the backend function.
For this, code had to be changed, to take a "struct registry_key"
instead of a char *.

Michael
(This used to be commit 4717e6d0cf9df53a55e5d55ede5480181b33920d)

13 years agoregistry: add reg_init_basic() - init registry with only the db backend.
Michael Adam [Sat, 22 Mar 2008 01:05:53 +0000 (02:05 +0100)]
registry: add reg_init_basic() - init registry with only the db backend.

Michael
(This used to be commit 1831042bdcbfe569ae39177058dfe1d914416513)

13 years agoregistry: close registry in exit path in registry_init_smbconf().
Michael Adam [Sat, 22 Mar 2008 00:54:18 +0000 (01:54 +0100)]
registry: close registry in exit path in registry_init_smbconf().

Michael
(This used to be commit 5aa3141bff35a85dd97e9fd339e19b0fe3a73afc)

13 years agoregistry: some whitespace cleanup in init_registry().
Michael Adam [Sat, 22 Mar 2008 00:53:44 +0000 (01:53 +0100)]
registry: some whitespace cleanup in init_registry().

Michael
(This used to be commit f33095e44ba22f4451a5deeffdd4f9ed3f99ed85)

13 years agoregistry: remove unneeded talloc stackframe variable.
Michael Adam [Sat, 22 Mar 2008 00:52:03 +0000 (01:52 +0100)]
registry: remove unneeded talloc stackframe variable.

Michael
(This used to be commit 81993db828bf11b13d7ee1f43483968dc6241bcc)

13 years agoregistry: close regdb in error path (and use it) in init_registry().
Michael Adam [Sat, 22 Mar 2008 00:49:21 +0000 (01:49 +0100)]
registry: close regdb in error path (and use it) in init_registry().

Michael
(This used to be commit 73b325fe7a9d7fd67ac9b99144a3776f5a1a9e15)

13 years agoregistry: fix registry_init_smbconf() to close the registry at the end.
Michael Adam [Fri, 21 Mar 2008 22:50:49 +0000 (23:50 +0100)]
registry: fix registry_init_smbconf() to close the registry at the end.

Michael
(This used to be commit f4d87fdbf266a36fbb50dae863ee0784165c2fe1)

13 years agolibsmbconf: add internal open/close handling to registry backend.
Michael Adam [Fri, 21 Mar 2008 22:39:01 +0000 (23:39 +0100)]
libsmbconf: add internal open/close handling to registry backend.

This internally keeps track of opened registry in the private data
struct. The first call that really accesses data, opens the registry
and it is kept open until the destructor is called.

This behaviour might be changed in the future.

Michael
(This used to be commit 03e72e13076e3215eb8ae51cfb4e7cd3d3683d3e)

13 years agolibsmbconf: add a comment.
Michael Adam [Fri, 21 Mar 2008 21:55:20 +0000 (22:55 +0100)]
libsmbconf: add a comment.

Michael
(This used to be commit 513ae78ef78d3ddcb155f9c38b9a0c82809e0998)

13 years agolibsmbconf: add private_data section to smbconf_ctx.
Michael Adam [Fri, 21 Mar 2008 21:52:27 +0000 (22:52 +0100)]
libsmbconf: add private_data section to smbconf_ctx.

This private data should be used by backends.
The token for the registry backend is moved from
the context to the private data section, since
this is registry specific.

Michael
(This used to be commit a02163356bdd0c17a25a45e9904f8bd1e1c4bee4)

13 years agolibsmbconf: add a "path" variable to the conf context.
Michael Adam [Fri, 21 Mar 2008 16:55:31 +0000 (17:55 +0100)]
libsmbconf: add a "path" variable to the conf context.

This is passed to the module init routines.
In case of the registry, this is the path of the
basekey in registry, that is to be used, defaulting
to KEY_SMBCONF (HKLM\software\samba\smbconf), when
NULL is given. This is the only case currently used.

In order to support other keys, registry initialization
for smbconf has to be changed to support different keys.

Michael
(This used to be commit 96434d9dc7a66773e313cc128af57493dee245a1)

13 years agolibsmbconf: add structuring comments to the prototypes in the public header.
Michael Adam [Fri, 21 Mar 2008 15:45:25 +0000 (16:45 +0100)]
libsmbconf: add structuring comments to the prototypes in the public header.

Michael
(This used to be commit 4f816df27670c3b6aabea9f26ef2d26f3e882e78)

13 years agolibsmbconf: adapt a comment to new circumstances
Michael Adam [Fri, 21 Mar 2008 15:42:42 +0000 (16:42 +0100)]
libsmbconf: adapt a comment to new circumstances

Michael
(This used to be commit 83b9453c88bfdf615cc2b547645b0a71a870f473)

13 years agolibsmbconf: group together functions in smbconf.c more appropriately
Michael Adam [Fri, 21 Mar 2008 15:40:20 +0000 (16:40 +0100)]
libsmbconf: group together functions in smbconf.c more appropriately

Michael
(This used to be commit e8ed8ad077f69ae7237f49b150625d20eb509586)

13 years agolibsmbconf: add a comment.
Michael Adam [Fri, 21 Mar 2008 15:35:52 +0000 (16:35 +0100)]
libsmbconf: add a comment.

Michael
(This used to be commit 8974b283683799bc51223d27b7e6aecac741fbc2)

13 years agolibsmbconf: move registry implementation to a module of its own.
Michael Adam [Fri, 21 Mar 2008 15:26:50 +0000 (16:26 +0100)]
libsmbconf: move registry implementation to a module of its own.

Michael
(This used to be commit 431b10bfe0dba0a49e50bebfb3f8ad1a00955837)