ira/wip.git
20 years agofix bug #245; local_lookupsid() needed to make a getpwuid() call to get the username...
Gerald Carter [Tue, 5 Aug 2003 23:24:14 +0000 (23:24 +0000)]
fix bug #245; local_lookupsid() needed to make a getpwuid() call to get the username instead of making up unix_user.##
(This used to be commit b947fc3eed464d7a64914f3965964d29be031614)

20 years agoChanges to make gss-spnego ntlmssp client work against W2k AD.
Volker Lendecke [Mon, 4 Aug 2003 13:10:43 +0000 (13:10 +0000)]
Changes to make gss-spnego ntlmssp client work against W2k AD.

Now I know where the mechListMIC changes came from: Ethereal ;-)

Volker
(This used to be commit 4e9eed1273035d09ac3b427b9711327ba8c6ebfc)

20 years agoFix unused variable warning.
Tim Potter [Mon, 4 Aug 2003 06:16:03 +0000 (06:16 +0000)]
Fix unused variable warning.
(This used to be commit 73d02e3a2b0f9e84ab6d8685e4ad6a03ef9249b2)

20 years agoMemory leak fix for create_rpc_bind_req()
Tim Potter [Mon, 4 Aug 2003 02:51:30 +0000 (02:51 +0000)]
Memory leak fix for create_rpc_bind_req()
(This used to be commit 4d26feabd75d5b298276b0c5880b9765507bb6ae)

20 years agoMore patches from Brett:
Tim Potter [Mon, 4 Aug 2003 00:50:00 +0000 (00:50 +0000)]
More patches from Brett:

  - remove 'if(mem_ctx)' tests prior to 'talloc_destroy' call to make
consistent with other modules; 'talloc_destroy' already test for NULL
anyway.

  - initialize PyObject* result pointers to NULL in function
declarations; enables removal of redundant NULL assignments.

  - use local scope TALLOC_CTX in lsa_lookup_names to prevent unbounded
memory growth during python policy object lifetime.

  - change context name string used in lsa_lookup_sids from
'lsa_open_policy' to 'lsa_lookup_sids' (cut'npaste oversight from
previous patch)

  - change docstring to match module name (apparently another cut'npaste
situation)
(This used to be commit 98cac74c67c454f636df5c1ea2baa029c482e402)

20 years agoFix memory leak in py_smb_set_setdesc()
Tim Potter [Mon, 4 Aug 2003 00:48:49 +0000 (00:48 +0000)]
Fix memory leak in py_smb_set_setdesc()

Consistency fixups in py_smb_query_secdesc()

Thanks to Brett A. Funderburg for these patches.
(This used to be commit 6c33189e50ae3704275198e324fcdb7facd209f7)

20 years agoFix up #defines around utmp_host and utmp_name. Noticed by Cord.Hockemeyer@uni-graz.at
Jeremy Allison [Sun, 3 Aug 2003 18:50:00 +0000 (18:50 +0000)]
Fix up #defines around utmp_host and utmp_name. Noticed by Cord.Hockemeyer@uni-graz.at
Jeremy.
(This used to be commit 07c5ecb945c1189fd6e8628f5e989b90dd15163b)

20 years agoOutput message saying "signed connect" instead of just connect when signing
Jeremy Allison [Sun, 3 Aug 2003 07:20:05 +0000 (07:20 +0000)]
Output message saying "signed connect" instead of just connect when signing
is active.
Jeremy.
(This used to be commit c6674fa62865b64aa788a1903db118e4d773bcae)

20 years agoFix oplock break detection code on incoming oplock break responses. This
Jeremy Allison [Sun, 3 Aug 2003 07:12:46 +0000 (07:12 +0000)]
Fix oplock break detection code on incoming oplock break responses. This
fixes signing for oplocks.
Jeremy.
(This used to be commit 69c56ee8bce122839a8fec4e59198f84b0757166)

20 years agoRemoved duplicated file, no longer in use. Note: profiles.1.xml is still
John Terpstra [Sun, 3 Aug 2003 05:10:57 +0000 (05:10 +0000)]
Removed duplicated file, no longer in use. Note: profiles.1.xml is still
present and relevant.
(This used to be commit 7b24759c270ffbc914aa0a45c8b7facbf6217c69)

20 years agoChanged "winbind uid/gid" to "idmap uid/gid"
John Terpstra [Sun, 3 Aug 2003 05:09:19 +0000 (05:09 +0000)]
Changed "winbind uid/gid" to "idmap uid/gid"
(This used to be commit d205dd963bb306935d3c02c94684fa1143436158)

20 years agomake sure to initialize the backend methods when enumerating sequence numbers; report...
Gerald Carter [Sat, 2 Aug 2003 18:15:33 +0000 (18:15 +0000)]
make sure to initialize the backend methods when enumerating sequence numbers; reported by Ken Cross
(This used to be commit 10c7a1af67e556c17d4b3495934a2dad19728d77)

20 years agoEnsure we don't leak any sign records on cancel of pending requests.
Jeremy Allison [Sat, 2 Aug 2003 08:48:01 +0000 (08:48 +0000)]
Ensure we don't leak any sign records on cancel of pending requests.
Jeremy.
(This used to be commit 9a8ffc239c0f1aada713de7e9e007066738d8874)

20 years agoOnly look for mid sign records on incoming packets for oplock break replies.
Jeremy Allison [Sat, 2 Aug 2003 08:38:34 +0000 (08:38 +0000)]
Only look for mid sign records on incoming packets for oplock break replies.
Otherwise we find spurious mid sign records on reply_ntcancel calls (they cancel
by mid). That took a *lot* of tracking down. I still need to remove the mid
records from the sign state on reply_ntcancel to avoid leaking memory....
Jeremy.
(This used to be commit 270bf20fe3e226ab5cfc689bd20ed4c22b2fa7e6)

20 years agoMore fixes for client and server side signing. Ensure sequence numbers
Jeremy Allison [Sat, 2 Aug 2003 07:07:38 +0000 (07:07 +0000)]
More fixes for client and server side signing. Ensure sequence numbers
are updated correctly on returning an error for server trans streams.
Ensure we turn off client trans streams on error.
Jeremy.
(This used to be commit 3a789cb7f01115c37404e5a696de363287cb0e5f)

20 years agoLeave the packet sequence checkers enabled whilst I track down a smbclient -> smbd
Jeremy Allison [Sat, 2 Aug 2003 03:12:39 +0000 (03:12 +0000)]
Leave the packet sequence checkers enabled whilst I track down a smbclient -> smbd
sequence number problem.
Jeremy.
(This used to be commit 844898dbd8e99837ef1621aa73024714aa819ce4)

20 years agoAdd the same signing code to the server. Ensure we use identical session
Jeremy Allison [Sat, 2 Aug 2003 03:06:07 +0000 (03:06 +0000)]
Add the same signing code to the server. Ensure we use identical session
numbers and MIDs when in trans/trans2/nttrans code.
Jeremy.
(This used to be commit 901544b29b4d815709b3dbad3012f1d2c419d904)

20 years agoCorrect fix (removed the earlier band-aid) for what I thought was a signing
Jeremy Allison [Sat, 2 Aug 2003 00:29:45 +0000 (00:29 +0000)]
Correct fix (removed the earlier band-aid) for what I thought was a signing
bug with w2k. Turns out that when we're doing a trans/trans2/nttrans call
the MID and send_sequence_number and reply_sequence_number must remain constant.
This was something we got very wrong in earlier versions of Samba. I can now
get a directory listing from WINNT\SYSTEM32 with the older earlier parameters
for clilist.c
This still needs to be fixed for the server side of Samba, client appears to
be working happily now (I'm doing a signed smbtar download of an entire W2K3
image to test this :-).
Jeremy.
(This used to be commit 2093a3130d4087d0659b497eebd580e7a66e5aa3)

20 years agoFix the option processing for smbtar. Does no one check this !
Jeremy Allison [Fri, 1 Aug 2003 21:09:10 +0000 (21:09 +0000)]
Fix the option processing for smbtar. Does no one check this !
Jeremy.
(This used to be commit c4af1ec73584656fb9d2b372461da4748e1643f1)

20 years agoadd tests for IRIX attr functions
Herb Lewis [Fri, 1 Aug 2003 19:45:12 +0000 (19:45 +0000)]
add tests for IRIX attr functions
(This used to be commit ea57a57db036de6245ff44cd953dae3b482b4744)

20 years agoUpdate my copyrights according to my agreement with IBM
Jim McDonough [Fri, 1 Aug 2003 15:30:44 +0000 (15:30 +0000)]
Update my copyrights according to my agreement with IBM
(This used to be commit a2bd8f0bfa12f2a1e33c96bc9dabcc0e2171700d)

20 years agoUpdate my copyrights according to my agreement with IBM
Jim McDonough [Fri, 1 Aug 2003 15:21:20 +0000 (15:21 +0000)]
Update my copyrights according to my agreement with IBM
(This used to be commit c9b209be2b17c2e4677cc30b46b1074f48878f43)

20 years agoFix copyright statements for various pieces of Anthony Liguori's work.
Jim McDonough [Fri, 1 Aug 2003 14:47:39 +0000 (14:47 +0000)]
Fix copyright statements for various pieces of Anthony Liguori's work.
(This used to be commit 15d2bc47854df75f8b2644ccbc887d0357d9cd27)

20 years agofix cut-n-paste error found by abartlet
Gerald Carter [Fri, 1 Aug 2003 13:28:13 +0000 (13:28 +0000)]
fix cut-n-paste error found by abartlet
(This used to be commit 042492b862c4f2389086275dd8a0e044d7432537)

20 years agoAdd ntlmssp client support to ntlm_auth. Find the corresponding cyrus sasl
Volker Lendecke [Fri, 1 Aug 2003 07:59:23 +0000 (07:59 +0000)]
Add ntlmssp client support to ntlm_auth. Find the corresponding cyrus sasl
module under http://samba.sernet.de/cyrus-gss-spnego.diff

Volker
(This used to be commit a82f6a00969f7ea377626c28ec05ace04f8135a9)

20 years agoFix a memory leak. I did not check all the calls to winbindd_request, but
Volker Lendecke [Fri, 1 Aug 2003 07:46:42 +0000 (07:46 +0000)]
Fix a memory leak. I did not check all the calls to winbindd_request, but
we might leak the extra_data somewhere else as well.

Volker
(This used to be commit 5d379345fa06f4253f67b40cb8127b70072db561)

20 years agolocking.c now refers to map_nt_error_from_unix, so link it in with
Volker Lendecke [Fri, 1 Aug 2003 07:45:02 +0000 (07:45 +0000)]
locking.c now refers to map_nt_error_from_unix, so link it in with
smbstatus and smbcontrol

Volker
(This used to be commit c2c901e06b9723e33cccdb592c609072b4376c10)

20 years agoFinish reformatting.
Jeremy Allison [Fri, 1 Aug 2003 06:29:16 +0000 (06:29 +0000)]
Finish reformatting.
Jeremy.
(This used to be commit 5ef75fa36620a87e8fd8567b854ea0770d8125ea)

20 years agoFinal fix for the bug tridge found. Only push locks onto a blocking lock
Jeremy Allison [Fri, 1 Aug 2003 06:10:30 +0000 (06:10 +0000)]
Final fix for the bug tridge found. Only push locks onto a blocking lock
queue if the posix lock failed with EACCES or EAGAIN (this means another
lock conflicts). Else return an error and don't queue the request.
Jeremy.
(This used to be commit 43fbc18fdc184bf29c15186c16bc99fb208de963)

20 years agoReformat lots of clitar code as I hate the style so much :-).
Jeremy Allison [Fri, 1 Aug 2003 01:03:05 +0000 (01:03 +0000)]
Reformat lots of clitar code as I hate the style so much :-).
Jeremy.
(This used to be commit 77f2a91549c8b61e74e2088faef2b61612803aed)

20 years agoReformat clitar option processing - getting ready to fix it for popt...
Jeremy Allison [Fri, 1 Aug 2003 00:41:57 +0000 (00:41 +0000)]
Reformat clitar option processing - getting ready to fix it for popt...
Jeremy.
(This used to be commit 94b30e7b4a4f71d3aa2fefee60b9ea8ead2acccd)

20 years agoCVAL_NC() doesn't need the (unsigned) fix and breaks the IRIX build
Andrew Tridgell [Thu, 31 Jul 2003 23:22:21 +0000 (23:22 +0000)]
CVAL_NC() doesn't need the (unsigned) fix and breaks the IRIX build

Thanks to Herb for pointing this out!
(This used to be commit 87ede8d310db10d92b4ff57e67d3b53cbb7697fb)

20 years agoAdded a note inspired by andrew@cis.uoguelph.ca to explain when this
Jeremy Allison [Thu, 31 Jul 2003 21:47:22 +0000 (21:47 +0000)]
Added a note inspired by andrew@cis.uoguelph.ca to explain when this
parameter gets run.
Jeremy.
(This used to be commit c5e11fd01003fa2d85c91ec81afd2cb2498472f5)

20 years agoonly honor the first OID in the sessetup snego negotiate. Deviates
Gerald Carter [Thu, 31 Jul 2003 19:01:22 +0000 (19:01 +0000)]
only honor the first OID in the sessetup snego negotiate.  Deviates
from RFC but I'm smelling a client bug here.

/* only look at the first OID for determining the mechToken --
   accoirding to RFC2478, we should choose the one we want
   and renegotiate, but i smell a client bug here..

   Problem observed when connecting to a member (samba box)
   of an AD domain as a user in a Samba domain.  Samba member
   server sent back krb5/mskrb5/ntlmssp as mechtypes, but the
   client (2ksp3) replied with ntlmssp/mskrb5/krb5 and an
   NTLMSSP mechtoken.                 --jerry              */
(This used to be commit 731420b03dbc15977822f74047e931dc62284fc0)

20 years agoReturn proper error when it is impossible to change quota flags
Alexander Bokovoy [Thu, 31 Jul 2003 17:08:38 +0000 (17:08 +0000)]
Return proper error when it is impossible to change quota flags
(This used to be commit 44bae9da9e03a1df738367f8d86adb0f315da41f)

20 years agoFix off-by-one found by valgrind.
Volker Lendecke [Thu, 31 Jul 2003 15:53:59 +0000 (15:53 +0000)]
Fix off-by-one found by valgrind.

Volker
(This used to be commit bc39c9b57fa6258674e1ee44b3446f25bf63661e)

20 years agospnego.c has function definitions. Prototype them.
Volker Lendecke [Thu, 31 Jul 2003 15:53:26 +0000 (15:53 +0000)]
spnego.c has function definitions. Prototype them.

Anybody familiar with Makefile.in could you please look at this?
This is probably the wrong way to fix this.

Volker
(This used to be commit 9a04750dea1b614604e6f9a0f69a251391994a71)

20 years agoFixes for memory leaks in gss spnego handling by aliguori.
Volker Lendecke [Thu, 31 Jul 2003 10:24:10 +0000 (10:24 +0000)]
Fixes for memory leaks in gss spnego handling by aliguori.

Volker
(This used to be commit 946695242f0a6db0e8c712f9bd97ac3cb99c4119)

20 years agoThis fixes an error I must have made when playing with spnego.c found
Volker Lendecke [Thu, 31 Jul 2003 10:23:13 +0000 (10:23 +0000)]
This fixes an error I must have made when playing with spnego.c found
by aliguori: NegTokenInit.mechListMIC is an Octet String.

Second: add a free_spnego_data function.

Both thanks to aliguori.

Volker
(This used to be commit 6c252440fba33eb69827d5515a95fbb3e8e9a653)

20 years agoApply some const
Volker Lendecke [Thu, 31 Jul 2003 10:21:13 +0000 (10:21 +0000)]
Apply some const
(This used to be commit 692ff44ba39cd24dbc906e0319bc51c8be9cc267)

20 years agomake sure the domain sid is set when enumerating trusted domains
Gerald Carter [Thu, 31 Jul 2003 06:37:37 +0000 (06:37 +0000)]
make sure the domain sid is set when enumerating trusted domains
(we don't always get it back)
(This used to be commit 6e8f23d1b1dd5122691cd9363a5c572fcab182af)

20 years agoworking on transtive trusts issue:
Gerald Carter [Thu, 31 Jul 2003 05:43:47 +0000 (05:43 +0000)]
working on transtive trusts issue:

  * use DsEnumerateDomainTrusts() instead of LDAP search.
    wbinfo -m now lists all trusted downlevel domains and
    all domains in the forest.

Thnigs to do:

  o Look at Krb5 connection trusted domains
  o make sure to initial the trusted domain cache as soon
    as possible
(This used to be commit 0ab00ccaedf204b39c86a9e1c2fcac5f15d0e033)

20 years agoWhoops - this is probably better shell syntax.
Tim Potter [Thu, 31 Jul 2003 04:28:43 +0000 (04:28 +0000)]
Whoops - this is probably better shell syntax.
(This used to be commit 4644085b682c806796f9acf2ed73de9dd9872738)

20 years agoTurn on automatic winbindd support for FreeBSD and see what the compile farm
Tim Potter [Thu, 31 Jul 2003 04:27:41 +0000 (04:27 +0000)]
Turn on automatic winbindd support for FreeBSD and see what the compile farm
thinks of it.
(This used to be commit e6210295e4daa5f1768616b4d8390a173c5c67ae)

20 years agoThis is a critical bug fix for a data corruption bug. If you
Andrew Tridgell [Thu, 31 Jul 2003 04:01:32 +0000 (04:01 +0000)]
This is a critical bug fix for a data corruption bug. If you
maintain another tree then please apply!

On non-X86 machines out byte-order macros fails for one particular
value. If you asked for IVAL() of 0xFFFFFFFF and assigned it to a 64
bit quantity then you got a 63 bit number 0x7FFFFFFFFFFFFFFF rather
than the expected 0xFFFFFFFF. This is due to some rather bizarre and
obscure sign extension rules to do with unsigned chars and arithmetic
operators (basically if you | together two unsigned chars you get a
signed result!)

This affected a byte range lock using the large lockingX format and a
lock of offset 0 and length 0xFFFFFFFF. Microsoft Excel does one of
these locks when opening a .csv file. If the platform you run on does
not then handle locks of length 0x7FFFFFFFFFFFFFFF then the posix lock
fails and the client is given a lockingX failure. This causes the .csv
file to be trunated!!
(This used to be commit 886661c3777dbfd4fa431746c8a5f48674a12b8e)

20 years agoWrap calls to change_oem_password() in become_root()/unbecome_root() pairs
Jeremy Allison [Thu, 31 Jul 2003 01:33:44 +0000 (01:33 +0000)]
Wrap calls to change_oem_password() in become_root()/unbecome_root() pairs
to allow UNIX password change scripts to work correctly. This is safe as
the old password has been checked as correct before invoking this.
Jeremy.
(This used to be commit 1734d43eb55561d46a6ffb5d806afedfd3746f9f)

20 years agoTurn the 'doing_signing' variable on - fix bug where it was only being set
Jeremy Allison [Thu, 31 Jul 2003 00:30:01 +0000 (00:30 +0000)]
Turn the 'doing_signing' variable on - fix bug where it was only being set
on when signing was mandatory.
Jeremy.
(This used to be commit 7c58673a103195435ca75ebb2684880d1f7242d3)

20 years agoAdd a command line option (-S on|off|required) to enable signing on client
Jeremy Allison [Wed, 30 Jul 2003 23:49:29 +0000 (23:49 +0000)]
Add a command line option (-S on|off|required) to enable signing on client
connections. Overrides smb.conf parameter if set.
Jeremy.
(This used to be commit 879309671df6b530e0bff69559422a417da4a307)

20 years agoSave us from possibly uninitialised variable (caught by gcc).
Jeremy Allison [Wed, 30 Jul 2003 23:33:56 +0000 (23:33 +0000)]
Save us from possibly uninitialised variable (caught by gcc).
Jeremy.
(This used to be commit f3f29665bd2c396c4756cd23f603ac768fea66fd)

20 years agoFix bug we discovered in W2K client signing on secondary trans2 packets.
Jeremy Allison [Wed, 30 Jul 2003 19:00:52 +0000 (19:00 +0000)]
Fix bug we discovered in W2K client signing on secondary trans2 packets.
Use W2K parameters. tpot please re-test smbclient with your problem
directory.
Jeremy.
(This used to be commit 677d3a3c4ca0b67148e5e56fa876773a067679bd)

20 years agoEliminate valgrind error when client gets bad sig on list. Some reformatting.
Jeremy Allison [Wed, 30 Jul 2003 18:57:37 +0000 (18:57 +0000)]
Eliminate valgrind error when client gets bad sig on list. Some reformatting.
Jeremy.
(This used to be commit b8f6b836468b3a0ae75977dc65cae8400f74734c)

20 years agoadd a few more tidy ups. Now onto winbindd
Gerald Carter [Wed, 30 Jul 2003 17:37:46 +0000 (17:37 +0000)]
add a few more tidy ups.  Now onto winbindd
(This used to be commit f8abdd23e1d4aed56c263c3228e702b191af4c64)

20 years agoadd support for DsEnumerateDomainTrusted for enumerating all the
Gerald Carter [Wed, 30 Jul 2003 17:29:00 +0000 (17:29 +0000)]
add support for DsEnumerateDomainTrusted for enumerating all the
trusted domains in a forest.
(This used to be commit c691c7f7d9afb8af542dc83cf934df1dfd38ef17)

20 years agoDon't revert something until you've seen if volker has already fixed it :-).
Jeremy Allison [Wed, 30 Jul 2003 16:34:14 +0000 (16:34 +0000)]
Don't revert something until you've seen if volker has already fixed it :-).
Jeremy.
(This used to be commit d57d9b99dfc2a83d91b952a11eb1ae4cf37e6467)

20 years agoComment out mutex until I get dependencies sorted out...
Jeremy Allison [Wed, 30 Jul 2003 15:30:36 +0000 (15:30 +0000)]
Comment out mutex until I get dependencies sorted out...
Jeremy
(This used to be commit 382d1732ca8e4d0909eb5a95f7327213913da37b)

20 years agobin/net needs server_mutex as kerberos_verify now uses it.
Volker Lendecke [Wed, 30 Jul 2003 08:05:34 +0000 (08:05 +0000)]
bin/net needs server_mutex as kerberos_verify now uses it.

Volker
(This used to be commit ee09db891a9a45158e12fcd2a85092d64870fac4)

20 years agoPut mutex around access of replay cache for krb5 tickets. krb5 replay cache
Jeremy Allison [Tue, 29 Jul 2003 21:32:36 +0000 (21:32 +0000)]
Put mutex around access of replay cache for krb5 tickets. krb5 replay cache
is not multi-process safe.
Jeremy.
(This used to be commit 9e0534a1b69bbd4f21b4925337cbab127d060fc6)

20 years agosplit replace into replace and replace1 to allow setenv to be used by
Herb Lewis [Tue, 29 Jul 2003 20:11:18 +0000 (20:11 +0000)]
split replace into replace and replace1 to allow setenv to be used by
nsswitch modules. Add required libraries to get rid of undefined
functions for libns_winbind.so and libns_wins.so
(This used to be commit cec5bf5f99ca98b0f5ee84636fc18f0cb3079683)

20 years agoFix bug #226. Stop unmangle of name into a wildcard name from deleting more
Jeremy Allison [Tue, 29 Jul 2003 19:16:59 +0000 (19:16 +0000)]
Fix bug #226. Stop unmangle of name into a wildcard name from deleting more
than was intended.
Jeremy.
(This used to be commit e2742e0d897a35820a7d8f184292c32a4c3952e3)

20 years agoAdd NT quotas support. Users allowed now to manage quotas on systems with sysquotas...
Alexander Bokovoy [Tue, 29 Jul 2003 18:07:13 +0000 (18:07 +0000)]
Add NT quotas support. Users allowed now to manage quotas on systems with sysquotas interface detected (Linux at least) using native Windows tools. Also move default quota support for NT quotas to VFS module default_quota. Code by Metze
(This used to be commit e856a96c2c42c39843e5e1a3a6b0d538e7179900)

20 years agoFinish tridge's patch as referenced here :
Jeremy Allison [Tue, 29 Jul 2003 17:34:20 +0000 (17:34 +0000)]
Finish tridge's patch as referenced here :

make sure we don't allow the creation of directories containing
wildcard characters. I've only put this in mkdir at the moment, but I
suspect this will apply to all places that can create new filenames.

We need to allow the opening of existing filenames that contain
wildcards, but not allow the creation of new ones.

Jeremy.
(This used to be commit 7f111e545d198faa5fa89f6d360db0d5c32a8bd7)

20 years agoTypo on my part. I typed KRB5_KDB_BAD_ENCTYPE when I meant to type KRB5_BAD_ENCTYPE.
Jeremy Allison [Tue, 29 Jul 2003 17:03:51 +0000 (17:03 +0000)]
Typo on my part. I typed KRB5_KDB_BAD_ENCTYPE when I meant to type KRB5_BAD_ENCTYPE.
Heimdal has the latter, not the former.
Jeremy.
(This used to be commit e8425df77c2e917c819592d93833a164ee3b5338)

20 years agoFix the build on Heimdal. KRB5_KDB_BAD_ENCTYPE doesn't exist on Heimdal, and
Jim McDonough [Tue, 29 Jul 2003 16:34:31 +0000 (16:34 +0000)]
Fix the build on Heimdal.  KRB5_KDB_BAD_ENCTYPE doesn't exist on Heimdal, and
it's a different rc than KRB5_BAD_ENCTYPE (which exists on both MIT and
Heimdal).  This will just make the debug show up at level 3 always.

Jeremy, you may want to revisit this, but it's probably not worth the hassle.
(This used to be commit 4ff322ccf9c8485bcfe67e658d48f190f03547b0)

20 years agoThis adds gss-spnego to ntlm_auth. It contains some new spnego support
Volker Lendecke [Tue, 29 Jul 2003 15:00:38 +0000 (15:00 +0000)]
This adds gss-spnego to ntlm_auth. It contains some new spnego support
from Jim McDonough. It is to enable cyrus sasl to provide the
gss-spnego support. For a preliminary patch to cyrus sasl see

http://samba.sernet.de/cyrus-gss-spnego.diff

Volker
(This used to be commit 45cef8f66e46abe4a25fd2b803a7d1051c1c6602)

20 years agoTypo fix for bug 258.
Tim Potter [Tue, 29 Jul 2003 02:34:18 +0000 (02:34 +0000)]
Typo fix for bug 258.
(This used to be commit a4e342c20cbddbb4d9d6ac49258457751146d890)

20 years agoImproved debug messages whilst trying to track down kerb issues.
Jeremy Allison [Tue, 29 Jul 2003 00:31:44 +0000 (00:31 +0000)]
Improved debug messages whilst trying to track down kerb issues.
Jeremy.
(This used to be commit 29dd71ddea480f6163ebbc9d8860a7930ae84066)

20 years agoMore memory leak fixes from Brett! It turns out PyDict_SetItemString
Tim Potter [Tue, 29 Jul 2003 00:15:23 +0000 (00:15 +0000)]
More memory leak fixes from Brett!  It turns out PyDict_SetItemString
didn't behave exactly as I thought it did.  If you create an item using a
PyFoo_FromBar function you must decrement the reference to that object
afterwards (or use Py_BuildValue).
(This used to be commit 2a960963fbe43de753d44d617a7666a7b258092e)

20 years agoMemory leak fixes from Brett A. Funderburg - don't use the connection talloc
Tim Potter [Tue, 29 Jul 2003 00:08:05 +0000 (00:08 +0000)]
Memory leak fixes from Brett A. Funderburg - don't use the connection talloc
context for data that is only needed on a per-call basis.
(This used to be commit 3cb39ddee456f55b96e593c67c86082bbd590d86)

20 years agoAdd debug output api's from lsa/spoolss modules to smb module. Patch
Tim Potter [Tue, 29 Jul 2003 00:05:17 +0000 (00:05 +0000)]
Add debug output api's from lsa/spoolss modules to smb module.  Patch
from Brett A. Funderburg.
(This used to be commit 2cedaff044e5a5a03482b1e8f211218db5394930)

20 years agoCorrected description of SWAT FLAGS since they have changed as a result of the
John Terpstra [Mon, 28 Jul 2003 05:49:51 +0000 (05:49 +0000)]
Corrected description of SWAT FLAGS since they have changed as a result of the
cleanup of loadparm and swat.c
(This used to be commit 6956eb9a0b878f6fae37e4de14573cccd2af2156)

20 years agoCleanup of loadparm and swat to correctly display all parameters as required.
John Terpstra [Mon, 28 Jul 2003 05:47:15 +0000 (05:47 +0000)]
Cleanup of loadparm and swat to correctly display all parameters as required.
No change to what is displayed has been made at this time. I do intend to
change the display order before 3.0.0 ships.
(This used to be commit de7d3063d9e07255da2cc4e67afa50c1e2ddf321)

20 years agoAdd buttons to Printers View
John Terpstra [Sun, 27 Jul 2003 19:49:23 +0000 (19:49 +0000)]
Add buttons to Printers View
(This used to be commit 805c33b08902d0d02358b624ef9976dd0bde4909)

20 years agoClarified what the SWAT FLAGS mean and what they do.
John Terpstra [Sun, 27 Jul 2003 17:24:24 +0000 (17:24 +0000)]
Clarified what the SWAT FLAGS mean and what they do.
Note: The comments in this file regarding the FLAGS has been in need of
maintenance for some time.
(This used to be commit a0d2fa0f25abe22008080df2ad2e58e7ee424a2b)

20 years agoFix comment
Andrew Bartlett [Sun, 27 Jul 2003 10:25:44 +0000 (10:25 +0000)]
Fix comment
(This used to be commit 2c395a3904395c2743df9c3035459c6f3866232d)

20 years agothe testsuite lib needs dummyroot too.
Andrew Bartlett [Sun, 27 Jul 2003 03:43:41 +0000 (03:43 +0000)]
the testsuite lib needs dummyroot too.
(This used to be commit e09a7c767ee4a7ff32f21f292b3967486a751532)

20 years agoFix typo.
John Terpstra [Sun, 27 Jul 2003 03:43:40 +0000 (03:43 +0000)]
Fix typo.
(This used to be commit 4cf778937e84cfe486d5a65c550a2560d9e9c7c3)

20 years agoUse the specified workgroup in 'net ads'. (Defaults to lp_workgroup()).
Andrew Bartlett [Sun, 27 Jul 2003 03:42:10 +0000 (03:42 +0000)]
Use the specified workgroup in 'net ads'.  (Defaults to lp_workgroup()).

Andrew Bartlett
(This used to be commit e6cc5ca780f24f19dda65a499fda95bd2d99ea93)

20 years agoAllow the stat cache to better handle invalid multibyte strings, by using
Andrew Bartlett [Sun, 27 Jul 2003 03:40:45 +0000 (03:40 +0000)]
Allow the stat cache to better handle invalid multibyte strings, by using
strdup_upper().  This function may fail - and we can just drop out of using
the cache in that case.  (Rather than panicing).

This also should get us closer to supporting all of the weird 'longer/shorter'
on uppercase/lowercase.

Andrew Bartlett
(This used to be commit d4c9261725578231079ed83e8e6584f12bd1cc43)

20 years agoTry again to fix up 'session request' name exchange. This time we actualy
Andrew Bartlett [Sun, 27 Jul 2003 03:29:40 +0000 (03:29 +0000)]
Try again to fix up 'session request' name exchange.  This time we actualy
get the names...

Andrew Bartlett
(This used to be commit 7c9e204f7eb15139532f2cc522ed87d0ac34d118)

20 years agoIf we strupper_m after the alpha_strcpy() we know that it is less likaly
Andrew Bartlett [Sun, 27 Jul 2003 02:43:22 +0000 (02:43 +0000)]
If we strupper_m after the alpha_strcpy() we know that it is less likaly
to contain multibyte charcters, as these should have been stripped.

Andrew Bartlett
(This used to be commit 0f7c1dda222d583212b8be2febe95ce7e1c0ba24)

20 years agoWhen removing an 'unused' function, it helps to remove the 'unused' callers...
Andrew Bartlett [Sun, 27 Jul 2003 02:42:22 +0000 (02:42 +0000)]
When removing an 'unused' function, it helps to remove the 'unused' callers...

Andrew Bartlett
(This used to be commit 605a89493e971f653413b06eda4bbca75029072b)

20 years agoUse push_ucs2_allocate(), rather than convert_string_allocate() directly.
Andrew Bartlett [Sun, 27 Jul 2003 02:40:06 +0000 (02:40 +0000)]
Use push_ucs2_allocate(), rather than convert_string_allocate() directly.

Remove strdup_upper/strdup_lower from their old file, now that they have
been moved to charcnv.c

Note that string_replace assumes that s is a pstring.  (doco change only)

Andrew Bartlett
(This used to be commit 6c9056029bb3dfadb244f301598e12e69493fff9)

20 years agoSome small fixes to our charset conversion code:
Andrew Bartlett [Sun, 27 Jul 2003 02:28:25 +0000 (02:28 +0000)]
Some small fixes to our charset conversion code:

 - Treat the NMB names in the 'session request' packet as 'ASCII'.  This means
   that we do not get invalid multibyte from the wire, even if we truncate
   in the conversion.  (Otherwise we panic when we try to strupper_m it).

 - Remove acnv_uxu2(), as it was duplicated by push_ucs2_allocate()
 - Remove acnv_dosu2(), as it is not used.

 - In push_ucs2(), with the STR_UPPER flag, do the case conversion *after*
   the UCS2 conversion, when it we know that the length can't change.  Also
   faster, as we don't need to do another 2 UCS2 conversions.

Andrew Bartlett
(This used to be commit 912035af1178424583d0bf887a391a0cac2acd87)

20 years agoAdding idmap backend man page section.
John Terpstra [Sun, 27 Jul 2003 01:16:24 +0000 (01:16 +0000)]
Adding idmap backend man page section.
(This used to be commit c10a0a1a0fc8ca91472ec53f82169a6c3a9fea7b)

20 years agoEnsure all code paths set add_script.
Jeremy Allison [Sun, 27 Jul 2003 00:20:45 +0000 (00:20 +0000)]
Ensure all code paths set add_script.
Jeremy.
(This used to be commit 0021c83ff645a1923b5a3d3c484d44b20d7813f0)

20 years agoFormat tidy up.
John Terpstra [Sat, 26 Jul 2003 17:46:47 +0000 (17:46 +0000)]
Format tidy up.
(This used to be commit 79d6e72af56838bdc1da437f76c905a47da0c0da)

20 years agoFixes bug #243
John Terpstra [Sat, 26 Jul 2003 17:09:54 +0000 (17:09 +0000)]
Fixes bug #243
(This used to be commit 22d644505f7181e9951a76105d7f014d57fc98c6)

20 years agoAdded buttons to change view mode. Fixes bug #212
John Terpstra [Sat, 26 Jul 2003 16:56:38 +0000 (16:56 +0000)]
Added buttons to change view mode. Fixes bug #212
(This used to be commit 37d2eed445ec825e31082e4e71c858e1e6356566)

20 years agoremove unnceccsary $; spotted by Lee Taylor
Gerald Carter [Sat, 26 Jul 2003 15:50:00 +0000 (15:50 +0000)]
remove unnceccsary $; spotted by Lee Taylor
(This used to be commit 5cde975bec9c726857815c89cd479028bce64685)

20 years agofix typo in debug
Gerald Carter [Sat, 26 Jul 2003 12:01:35 +0000 (12:01 +0000)]
fix typo in debug
(This used to be commit ed61628d8b051049636f48ec4372b2e19090628c)

20 years agoUpdating missing flags.
John Terpstra [Sat, 26 Jul 2003 01:57:16 +0000 (01:57 +0000)]
Updating missing flags.
(This used to be commit 3b4693c3b28e9f428dc54b6c55298645431e0bda)

20 years agoCorrectly detect an "add user script" - check that *lp_adduser_script() != '\0',
Jeremy Allison [Sat, 26 Jul 2003 01:21:06 +0000 (01:21 +0000)]
Correctly detect an "add user script" - check that *lp_adduser_script() != '\0',
not lp_adduser_script() != NULL.
Jeremy.
(This used to be commit 2eac65ebe7147b36a34e0ca1c3f455f559ab0361)

20 years agoStart the packet signing engine in the kerberos case in the same place
Jeremy Allison [Fri, 25 Jul 2003 23:43:22 +0000 (23:43 +0000)]
Start the packet signing engine in the kerberos case in the same place
as the ntlmssp case.
Jeremy.
(This used to be commit 79e0bf829875fc985f1940dc31ee418aad910ed6)

20 years agoW00t! Client smb signing is now working correctly with krb5 and w2k server.
Jeremy Allison [Fri, 25 Jul 2003 23:15:30 +0000 (23:15 +0000)]
W00t! Client smb signing is now working correctly with krb5 and w2k server.
Server code *should* also work (I'll check shortly). May be the odd memory
leak. Problem was we (a) weren't setting signing on in the client krb5 sessionsetup
code (b) we need to ask for a subkey... (c). The client and server need to
ask for local and remote subkeys respectively.
Thanks to Paul Nelson @ Thursby for some sage advice on this :-).
Jeremy.
(This used to be commit 3f9e3b60709df5ab755045a093e642510d4cde00)

20 years agoFix bug #184; set max_pw_age in account_pol to -1 so the default is never to expire
Gerald Carter [Fri, 25 Jul 2003 19:57:26 +0000 (19:57 +0000)]
Fix bug #184; set max_pw_age in account_pol to -1 so the default is never to expire
(This used to be commit 833bc5c06018043cf0eb6bdcbb96922964286559)

20 years agodomain in schannel bind credentials must be the dest domain, not ours
Gerald Carter [Fri, 25 Jul 2003 18:00:57 +0000 (18:00 +0000)]
domain in schannel bind credentials must be the dest domain, not ours
(This used to be commit e12f6a8c13f27c3caea96b467cc4294e20dad341)

20 years agofix case where no realm or workgroup means to use our own
Gerald Carter [Fri, 25 Jul 2003 16:42:34 +0000 (16:42 +0000)]
fix case where no realm or workgroup means to use our own
(This used to be commit 6edc7e0a744a5d8c6332758b800a2646ef16dd77)

20 years agofix user_in_list to work with winbind groups again; my bug
Gerald Carter [Fri, 25 Jul 2003 16:03:46 +0000 (16:03 +0000)]
fix user_in_list to work with winbind groups again; my bug
(This used to be commit 850f4fafdbaf19ea13273a8bf82433ba50a11868)

20 years agofix some error returns and strings; patch from metze
Gerald Carter [Fri, 25 Jul 2003 14:35:17 +0000 (14:35 +0000)]
fix some error returns and strings; patch from metze
(This used to be commit 948b1b138cf1fce18c93645fbdf948e589b19dc5)

20 years agoMore printf portability fixes. Got caught out by some gcc'isms last
Tim Potter [Fri, 25 Jul 2003 04:24:40 +0000 (04:24 +0000)]
More printf portability fixes.  Got caught out by some gcc'isms last
time.  )-:
(This used to be commit 59dae1da66a5eb7e128263bd578f167d8746e9f0)