ira/wip.git
14 years agoMerge branch 'v3-2-test' of ssh://jra@git.samba.org/data/git/samba into v3-2-test
Jeremy Allison [Sat, 5 Jan 2008 03:06:37 +0000 (19:06 -0800)]
Merge branch 'v3-2-test' of ssh://jra@git.samba.org/data/git/samba into v3-2-test
(This used to be commit 3a45f62310faf63cd6864d2cb10f941492eda818)

14 years agoAdd missing patch to allow smbcacls to do krb5 auth, bug #5175
Jeremy Allison [Sat, 5 Jan 2008 01:15:04 +0000 (17:15 -0800)]
Add missing patch to allow smbcacls to do krb5 auth, bug #5175
from Tom Maher <tmaher@watson.org>.
Jeremy.
(This used to be commit 54ee718957b768a06e41857b96f0b5e18b3ca6a4)

14 years agoBetter way of testing enc.
Jeremy Allison [Sat, 5 Jan 2008 00:58:23 +0000 (16:58 -0800)]
Better way of testing enc.
Jeremy.
(This used to be commit c5800235018330f0c1bbe307cd733597ac9b6686)

14 years agoAdded -e tests for S3 smbtorture.
Jeremy Allison [Sat, 5 Jan 2008 00:09:48 +0000 (16:09 -0800)]
Added -e tests for S3 smbtorture.
Jeremy.
(This used to be commit deeeae3ee96f7207a49e1edaa876410b77c33458)

14 years agoAdded -e option to smbtorture to test encrypted versions
Jeremy Allison [Sat, 5 Jan 2008 00:09:24 +0000 (16:09 -0800)]
Added -e option to smbtorture to test encrypted versions
of the tests.
Jeremy.
(This used to be commit e85b346f3d73f50d6dea19ffb6cca1180345e687)

14 years agoNow conn is part of smb_request, we don't need it as
Jeremy Allison [Fri, 4 Jan 2008 23:37:24 +0000 (15:37 -0800)]
Now conn is part of smb_request, we don't need it as
an extra parameter. This cleans up quite a few places
we were passing it around without needing it.
Jeremy.
(This used to be commit 8f36def18e9f980e8db522e1de41e80cfd5f466e)

14 years agoFix idle client reading keepalive.
Jeremy Allison [Fri, 4 Jan 2008 22:56:56 +0000 (14:56 -0800)]
Fix idle client reading keepalive.
Jeremy.
(This used to be commit 4ce0bf785635371e2923217b1e0b7f30986c25bb)

14 years agoWe dont' modify the smb header for crypto anymore.
Jeremy Allison [Fri, 4 Jan 2008 22:43:43 +0000 (14:43 -0800)]
We dont' modify the smb header for crypto anymore.
Jeremy.
(This used to be commit f5b6b6dac66b4ecc113985a7e7db1855b324c465)

14 years agoallocate share_mode_str only when needed
Volker Lendecke [Fri, 4 Jan 2008 22:27:14 +0000 (23:27 +0100)]
allocate share_mode_str only when needed
(This used to be commit a98693bfa7bfe72ffa164d21b3e9636e268708aa)

14 years agoDo not pass emtpy wkssvc_PasswordBuffers to rpc functions.
Günther Deschner [Fri, 4 Jan 2008 21:56:31 +0000 (22:56 +0100)]
Do not pass emtpy wkssvc_PasswordBuffers to rpc functions.

Guenther
(This used to be commit fe75e5ccdfc2609380367e59215637b0de1ef241)

14 years agoMerge branch 'v3-2-test' of ssh://jra@git.samba.org/data/git/samba into v3-2-test
Jeremy Allison [Fri, 4 Jan 2008 21:59:52 +0000 (13:59 -0800)]
Merge branch 'v3-2-test' of ssh://jra@git.samba.org/data/git/samba into v3-2-test
(This used to be commit 4e1bf48e7eab927e70fde3408a42c56e06b9b178)

14 years agoFix interesting bug found with make valgrindtest. When cancelling
Jeremy Allison [Fri, 4 Jan 2008 21:59:26 +0000 (13:59 -0800)]
Fix interesting bug found with make valgrindtest. When cancelling
a lock due to file closure make sure we null out the fsp pointer
so it isn't dangling. This is an old bug (not related to the new
changes).
Jeremy.
(This used to be commit b5ee972b0c04b4d119573d95ac458a3b6be30c5c)

14 years agoRe-Indent function ldap_open_with_timeout().
Michael Adam [Fri, 4 Jan 2008 21:56:10 +0000 (22:56 +0100)]
Re-Indent function ldap_open_with_timeout().

This reverts commit #cafda34783f0961c9b463803c19cfcb69f836e3f .

I just learned (the hard way) that these indeted functions
are not indented by accident but that the intention of this
is to not include the prototype into proto.h.

Michael
(This used to be commit 2e5d01b2146bb9e057b2779d9fe7691ed46d9f45)

14 years agoMerge branch 'v3-2-test' of ssh://jra@git.samba.org/data/git/samba into v3-2-test
Jeremy Allison [Fri, 4 Jan 2008 21:24:41 +0000 (13:24 -0800)]
Merge branch 'v3-2-test' of ssh://jra@git.samba.org/data/git/samba into v3-2-test
(This used to be commit 3a62a177ba758b325ab98e9d77d302bc382e0df8)

14 years agoFix the build.
Jeremy Allison [Fri, 4 Jan 2008 21:24:24 +0000 (13:24 -0800)]
Fix the build.
Jeremy.
(This used to be commit 25a0084af5978cc11cf4e83a641bc57e0e64eb89)

14 years agoAdd a debug message (when the LDAP server has really been connected).
Michael Adam [Fri, 4 Jan 2008 21:06:15 +0000 (22:06 +0100)]
Add a debug message (when the LDAP server has really been connected).

Michael
(This used to be commit 7d9d2de39072b3291b95ac3965df0d19f83792b9)

14 years agoUntangle assignment and result check.
Michael Adam [Fri, 4 Jan 2008 20:56:57 +0000 (21:56 +0100)]
Untangle assignment and result check.

Michael
(This used to be commit 465a3b356cffb855e26569d3752f15cac07208c0)

14 years agoEnhance DEBUG-verbosity of ldap_open_with_timeout().
Michael Adam [Fri, 4 Jan 2008 20:54:02 +0000 (21:54 +0100)]
Enhance DEBUG-verbosity of ldap_open_with_timeout().

Michael
(This used to be commit 9e70d1f24dd304c363a1bde97b5af618b46edc49)

14 years agoUnindent function header.
Michael Adam [Fri, 4 Jan 2008 20:53:25 +0000 (21:53 +0100)]
Unindent function header.

Michael
(This used to be commit cafda34783f0961c9b463803c19cfcb69f836e3f)

14 years agoFix a misleading DEBUG message.
Michael Adam [Fri, 4 Jan 2008 20:45:28 +0000 (21:45 +0100)]
Fix a misleading DEBUG message.

At this stage, the (tcp) connection to the LDAP server has not
been established, this is what is about to be attempted. What
has been succesfully done, is a CLDAP netlogon query.

Michael
(This used to be commit 71c3c8ad4c92c5f6267b84ee1d207e5e49e9a4ec)

14 years agoMerge branch 'v3-2-test' of ssh://jra@git.samba.org/data/git/samba into v3-2-test
Jeremy Allison [Fri, 4 Jan 2008 20:59:36 +0000 (12:59 -0800)]
Merge branch 'v3-2-test' of ssh://jra@git.samba.org/data/git/samba into v3-2-test
(This used to be commit 16224e8f4f22a8db0ed278d741a7706967f55335)

14 years agoRefactor the crypto code after a very helpful conversation
Jeremy Allison [Fri, 4 Jan 2008 20:56:23 +0000 (12:56 -0800)]
Refactor the crypto code after a very helpful conversation
with Volker. Mostly making sure we have data on the incoming
packet type, not stored in the smb header.
Jeremy.
(This used to be commit c4e5a505043965eec77b5bb9bc60957e8f3b97c8)

14 years agoFix a DEBUG statement.
Michael Adam [Fri, 4 Jan 2008 20:35:29 +0000 (21:35 +0100)]
Fix a DEBUG statement.

Michael
(This used to be commit 18360b852c662d933ceff9854725f878a5de9a7d)

14 years agoFix spacing - spaces mixed with tabs.
Michael Adam [Fri, 4 Jan 2008 20:16:48 +0000 (21:16 +0100)]
Fix spacing - spaces mixed with tabs.

Michael
(This used to be commit a4ef828102417f04af1e9823c89404e77e4fd5c1)

14 years agoFix a comment.
Michael Adam [Fri, 4 Jan 2008 20:09:55 +0000 (21:09 +0100)]
Fix a comment.

Michael
(This used to be commit fc9c3f39b5af55026f1e5e964857c203cf6c9316)

14 years agoRemove the word "registry" from the help output of the "net conf" command.
Michael Adam [Fri, 4 Jan 2008 20:05:51 +0000 (21:05 +0100)]
Remove the word "registry" from the help output of the "net conf" command.

Michael
(This used to be commit 8d9e3e08f3cc6a1f54661d1e54a3902ad50be191)

14 years agoUpdate the introductory comment to net_conf.c to mention linbet_conf.
Michael Adam [Fri, 4 Jan 2008 20:03:24 +0000 (21:03 +0100)]
Update the introductory comment to net_conf.c to mention linbet_conf.

Michael
(This used to be commit e166b886375b450534c894676ab1f64571dd46b8)

14 years agoFix the inherited trust flags when spidering the trust heirarchy.
Gerald (Jerry) Carter [Fri, 4 Jan 2008 19:35:41 +0000 (13:35 -0600)]
Fix the inherited trust flags when spidering the trust heirarchy.

Also *do not* clear the trust list when rescanning or else it is possible
to suffer from a race condition where no trusted domains can be found.
(This used to be commit e7164a252bf213a74d6eeac5aa04645eed5be241)

14 years agoAdd a missing check for dealing with a one-way trust in query_user().
Gerald (Jerry) Carter [Fri, 4 Jan 2008 19:34:10 +0000 (13:34 -0600)]
Add a missing check for dealing with a one-way trust in query_user().
(This used to be commit f89e356bdaa203ef0a3ce6b8bd52170afa68a2c9)

14 years agoEnsure that winbindd_getgroups() can deal with a UPN name.
Gerald (Jerry) Carter [Fri, 4 Jan 2008 19:32:58 +0000 (13:32 -0600)]
Ensure that winbindd_getgroups() can deal with a UPN name.

A user logging in via GDM was not getting a complete list of supplementary
groups in his/her token.  This is because getgroup() was not able to
find the winbindd_domain* using the DNS name.  Fallback to matching the DNS
name is the short name match failes.
(This used to be commit 2030a8de19a2c7c735a8aa367dd953e4a5c447b8)

14 years agoWhen connecting to an AD DC, use the DsGetDCName variant.
Gerald (Jerry) Carter [Fri, 4 Jan 2008 19:31:07 +0000 (13:31 -0600)]
When connecting to an AD DC, use the DsGetDCName variant.

This allows us to deal with child domains in transitive forest trusts.
It also allows us to fill in the forest name to the target domain to the
struct winbindd_domain *.
(This used to be commit ed30516bb0f55f9ba466debf91b6e33d1c28a484)

14 years agoMap WERR_NO_SUCH_SERVICE with dos_errstr().
Michael Adam [Fri, 4 Jan 2008 18:58:19 +0000 (19:58 +0100)]
Map WERR_NO_SUCH_SERVICE with dos_errstr().

Michael
(This used to be commit df5839b5376e903486982ddc7c4f4fbd4550c60a)

14 years agoRemove the final regdb_close() from net_conf.c
Michael Adam [Fri, 4 Jan 2008 18:52:22 +0000 (19:52 +0100)]
Remove the final regdb_close() from net_conf.c

This is to hide the registry from net_conf.
Right now, it does not harm if "net conf" does not close
the registry file explicitly just before exiting.
I am working out a proper way of handling open/close
operations transparently in the libnet_conf library.

Michael
(This used to be commit 790ef789444945fbae5637f0b469665859171dcd)

14 years agoFix the behaviour of "net conf setparm" to create the share if necessary.
Michael Adam [Fri, 4 Jan 2008 18:49:57 +0000 (19:49 +0100)]
Fix the behaviour of "net conf setparm" to create the share if necessary.

This moves functionality taken away from libnet_conf_set_parameter() to the
higher level user frontend function. (Somehow I thought I had done this
already ... :-)

Michael
(This used to be commit fc0fca980f08a0af65d82784ef5a50a7b1ac0927)

14 years agoFix build warning.
Günther Deschner [Fri, 4 Jan 2008 16:33:24 +0000 (17:33 +0100)]
Fix build warning.

Guenther
(This used to be commit a43125d9e9052fab8eb561976f45d1db4622482e)

14 years agoRename server_name to dc_name in libnet join structures.
Günther Deschner [Fri, 4 Jan 2008 16:11:14 +0000 (17:11 +0100)]
Rename server_name to dc_name in libnet join structures.

Guenther
(This used to be commit ff5e15b1ba0d5c39ceef9f9995c107e510162564)

14 years agoSeparate out storing and removing secrets in libnet_join/unjoin.
Günther Deschner [Fri, 4 Jan 2008 16:09:21 +0000 (17:09 +0100)]
Separate out storing and removing secrets in libnet_join/unjoin.

Guenther
(This used to be commit b59ca2d9c3375c0d0b9f585e48d718689586bb92)

14 years agoIn libnet_join finally separate the admin from the machine pwd entirely.
Günther Deschner [Fri, 4 Jan 2008 16:01:52 +0000 (17:01 +0100)]
In libnet_join finally separate the admin from the machine pwd entirely.

Guenther
(This used to be commit d88bb94f0ef00ddbb48498797bd11448e0d74645)

14 years agoUse the proper boolean constants.
Michael Adam [Fri, 4 Jan 2008 14:20:46 +0000 (15:20 +0100)]
Use the proper boolean constants.

Michael
(This used to be commit 2ba625e473e8eb23d692566d32a8ac965785df4e)

14 years agoAdd debug switch to netdomjoin.
Günther Deschner [Fri, 4 Jan 2008 14:18:42 +0000 (15:18 +0100)]
Add debug switch to netdomjoin.

Guenther
(This used to be commit 2b221708c07967bccd68e8c7983791b4628405bb)

14 years agoMinor cosmetic cleanup for netdomjoin-gui.
Günther Deschner [Fri, 4 Jan 2008 14:08:28 +0000 (15:08 +0100)]
Minor cosmetic cleanup for netdomjoin-gui.

Guenther
(This used to be commit 02e3887f3962b469c965110b6141a6655f2347af)

14 years agoFix crash bug in regdb_close() when called with no ref count.
Günther Deschner [Fri, 4 Jan 2008 11:57:49 +0000 (12:57 +0100)]
Fix crash bug in regdb_close() when called with no ref count.

Michael, please check.

Guenther
(This used to be commit d6575ff5d240ec431b6e837494913dbd06e5a299)

14 years agoFix some error strings in netdomjoin-gui.
Günther Deschner [Fri, 4 Jan 2008 10:54:38 +0000 (11:54 +0100)]
Fix some error strings in netdomjoin-gui.

Guenther
(This used to be commit aaea8f1ed744e9662f92a3840d86ad1aff943d18)

14 years agoRobustness fix for libnet join when unjoining.
Günther Deschner [Fri, 4 Jan 2008 10:21:53 +0000 (11:21 +0100)]
Robustness fix for libnet join when unjoining.

Guenther
(This used to be commit d7f01d940feb7dfedb6c4b8b88f5443434e03428)

14 years agoAdd ads_get_joinable_ous().
Günther Deschner [Thu, 3 Jan 2008 16:28:09 +0000 (17:28 +0100)]
Add ads_get_joinable_ous().

Guenther
(This used to be commit 5bbceac88159ef6ff83d9cc62c77c7af2116967d)

14 years agoUse different error code for libnet_conf initialization failure.
Günther Deschner [Thu, 3 Jan 2008 15:46:26 +0000 (16:46 +0100)]
Use different error code for libnet_conf initialization failure.

Guenther
(This used to be commit 65537eae842065a1dd68d8e532e61502b61e1dbe)

14 years agoMinor libnetapi join cosmetic cleanup.
Günther Deschner [Thu, 3 Jan 2008 15:41:38 +0000 (16:41 +0100)]
Minor libnetapi join cosmetic cleanup.

Guenther
(This used to be commit 4deef80bed374af5032c0f3081d2ee3c70be99df)

14 years agoAdd some more join related werror codes.
Günther Deschner [Thu, 3 Jan 2008 15:40:04 +0000 (16:40 +0100)]
Add some more join related werror codes.

Guenther
(This used to be commit 62e7d467ab1b2f98327960eec3a3a925b2f04bda)

14 years agoMake libnet_conf handle opening/initialization of the registry.
Michael Adam [Thu, 3 Jan 2008 14:33:09 +0000 (15:33 +0100)]
Make libnet_conf handle opening/initialization of the registry.

Open state is currently tracked by a global variable
to avoid double initialization.

Later, this can possibly be replaced by a conf-context
created by an initialization function and passed around
to the other api functions.

Michael
(This used to be commit 77713e776405800ac54c692a77cd4efd153042cb)

14 years agoAdd a comment header and do some slight reformatting.
Michael Adam [Thu, 3 Jan 2008 13:34:31 +0000 (14:34 +0100)]
Add a comment header and do some slight reformatting.

Michael
(This used to be commit 5d557e3f95b8d53114c25ba7fa3e564a50be9e05)

14 years agoUse GLOBAL_NAME constant.
Michael Adam [Thu, 3 Jan 2008 13:17:42 +0000 (14:17 +0100)]
Use GLOBAL_NAME constant.

Michael
(This used to be commit 4c404d627ccfaf1c17f4b6b1ebab6fce357d9ab1)

14 years agoRename libnet_smbconf_set_global_param() to libnet_conf_set_global_parameter().
Michael Adam [Thu, 3 Jan 2008 13:15:05 +0000 (14:15 +0100)]
Rename libnet_smbconf_set_global_param() to libnet_conf_set_global_parameter().

Now all functions are converted to the consistent naming scheme.

Michael
(This used to be commit a559533c0c8a80f3f4078bbc2675de395359485f)

14 years agoRename libnet_smbconf_delparm() to libnet_conf_delete_parameter().
Michael Adam [Thu, 3 Jan 2008 13:11:20 +0000 (14:11 +0100)]
Rename libnet_smbconf_delparm() to libnet_conf_delete_parameter().

Michael
(This used to be commit 073eeca51e46da6a687175aadbfdbb9e029532d6)

14 years agoRename libnet_smbconf_getparm() to libnet_conf_get_parameter().
Michael Adam [Thu, 3 Jan 2008 13:08:45 +0000 (14:08 +0100)]
Rename libnet_smbconf_getparm() to libnet_conf_get_parameter().

Michael
(This used to be commit d08556dbc7071933feaeec538f01ac8f6a637b1d)

14 years agoRename libnet_smbconf_setparm() to libnet_conf_set_parameter().
Michael Adam [Thu, 3 Jan 2008 13:06:09 +0000 (14:06 +0100)]
Rename libnet_smbconf_setparm() to libnet_conf_set_parameter().

Michael
(This used to be commit e00cb415d30b3e72ccfb7e5c366c95ec0f9c6247)

14 years agoRename libnet_smbconf_delshare() to libnet_conf_delete_share().
Michael Adam [Thu, 3 Jan 2008 13:01:50 +0000 (14:01 +0100)]
Rename libnet_smbconf_delshare() to libnet_conf_delete_share().

Michael
(This used to be commit 2075baf551ca7fc6bcee6b93f63fd7fbf75f9a50)

14 years agoRename libnet_smbconf_getshare() to libnet_conf_get_share().
Michael Adam [Thu, 3 Jan 2008 12:59:14 +0000 (13:59 +0100)]
Rename libnet_smbconf_getshare() to libnet_conf_get_share().

Michael
(This used to be commit 1575612f1936312125e7778a9a4227e444ea36cf)

14 years agoRename libnet_smbconf_create_share() to libnet_conf_create_share().
Michael Adam [Thu, 3 Jan 2008 12:55:43 +0000 (13:55 +0100)]
Rename libnet_smbconf_create_share() to libnet_conf_create_share().

Michael
(This used to be commit 6bc4ee210855dbfbee9e86b59e90b08ecb3a9df9)

14 years agoRename libnet_smbconf_share_exists() to libnet_conf_share_exists().
Michael Adam [Thu, 3 Jan 2008 12:54:31 +0000 (13:54 +0100)]
Rename libnet_smbconf_share_exists() to libnet_conf_share_exists().

Michael
(This used to be commit 3258758e5c8dfc2c681e1285cb34aaacae697a55)

14 years agoRename libnet_smbconf_get_share_names() to libnet_conf_get_share_names().
Michael Adam [Thu, 3 Jan 2008 12:53:04 +0000 (13:53 +0100)]
Rename libnet_smbconf_get_share_names() to libnet_conf_get_share_names().

Michael
(This used to be commit 2e4beee66b3672c3259b312aca3d482598731119)

14 years agoRename libnet_smbconf_get_config() to libnet_conf_get_config().
Michael Adam [Thu, 3 Jan 2008 12:50:55 +0000 (13:50 +0100)]
Rename libnet_smbconf_get_config() to libnet_conf_get_config().

Michael
(This used to be commit e8f7c07699b5b93acd81b24bca908769f0b5e8d8)

14 years agoRename libnet_smbconf_drop() to libnet_conf_drop().
Michael Adam [Thu, 3 Jan 2008 12:48:56 +0000 (13:48 +0100)]
Rename libnet_smbconf_drop() to libnet_conf_drop().

Michael
(This used to be commit 42ae33a96228e916d7d530d844be6937a80d4fea)

14 years agoRename libnet_smbconf_reg_get_values() to libnet_conf_reg_get_values().
Michael Adam [Thu, 3 Jan 2008 12:46:45 +0000 (13:46 +0100)]
Rename libnet_smbconf_reg_get_values() to libnet_conf_reg_get_values().

Now all internal helper functions are converted to the consistent
naming scheme.

Michael
(This used to be commit c23e6636a886d93b98c9439ba081def0385f67ac)

14 years agoRename libnet_smbconf_format_registry_value() to libnet_conf_format_registry_value().
Michael Adam [Thu, 3 Jan 2008 12:45:14 +0000 (13:45 +0100)]
Rename libnet_smbconf_format_registry_value() to libnet_conf_format_registry_value().

Michael
(This used to be commit 3f9f35335127a673639fa30c88cdea6c79f04b92)

14 years agoRename libnet_smbconf_reg_set_value() to libnet_conf_reg_set_value().
Michael Adam [Thu, 3 Jan 2008 12:43:34 +0000 (13:43 +0100)]
Rename libnet_smbconf_reg_set_value() to libnet_conf_reg_set_value().

Michael
(This used to be commit 96b2923bc3c57700352869627c38609529d53cd2)

14 years agoRename libnet_smbconf_reg_create_service_key() to libnet_conf_reg_create_service_key().
Michael Adam [Thu, 3 Jan 2008 12:42:40 +0000 (13:42 +0100)]
Rename libnet_smbconf_reg_create_service_key() to libnet_conf_reg_create_service_key().

Michael
(This used to be commit cd1846943cbcc02ea9fa3b9237bd02e667a475db)

14 years agoRename libnet_smbconf_value_exists() to libnet_conf_value_exists().
Michael Adam [Thu, 3 Jan 2008 12:40:40 +0000 (13:40 +0100)]
Rename libnet_smbconf_value_exists() to libnet_conf_value_exists().

Michael
(This used to be commit 49f740797bb7fc5edacbd4c3e8b1eb1aab131ea4)

14 years agoRename libnet_smbconf_reg_open_basekey() to libnet_conf_reg_open_base_key().
Michael Adam [Thu, 3 Jan 2008 12:38:55 +0000 (13:38 +0100)]
Rename libnet_smbconf_reg_open_basekey() to libnet_conf_reg_open_base_key().

Michael
(This used to be commit c2ba52b2c34abc42b4ff7945715dc36e08a2f112)

14 years agoRename libnet_smbconf_reg_open_service_key() to libnet_conf_reg_open_service_key().
Michael Adam [Thu, 3 Jan 2008 12:36:25 +0000 (13:36 +0100)]
Rename libnet_smbconf_reg_open_service_key() to libnet_conf_reg_open_service_key().

Michael
(This used to be commit 4d86d2dd6f0a577e446ccb4b362b3cd80f819600)

14 years agoRename libnet_smbconf_reg_open_path() to libnet_conf_reg_open_path().
Michael Adam [Thu, 3 Jan 2008 12:33:10 +0000 (13:33 +0100)]
Rename libnet_smbconf_reg_open_path() to libnet_conf_reg_open_path().

Michael
(This used to be commit 9868364e2c7827ac7914bee711a65d4456a5e366)

14 years agoRename libnet_smbconf_add_string_to_array() to libnet_conf_add_string_to_array().
Michael Adam [Thu, 3 Jan 2008 12:31:23 +0000 (13:31 +0100)]
Rename libnet_smbconf_add_string_to_array() to libnet_conf_add_string_to_array().

This is the start of making nomenclature more consistent
(functions in libnet_conf.c should be called libnet_conf_*,
not libnet_smbconf_* ...

Michael
(This used to be commit 0dd3967bfd88a4d90941e80134c549f5ade63ad0)

14 years agoHappy new year again.
Michael Adam [Thu, 3 Jan 2008 11:08:49 +0000 (12:08 +0100)]
Happy new year again.

Michael
(This used to be commit e568f42e2146fa6510a86746581409450887ff16)

14 years agoUse -g instead of -gstabs as many have reported gdb problems with -gstabs.
Günther Deschner [Thu, 3 Jan 2008 12:40:42 +0000 (13:40 +0100)]
Use -g instead of -gstabs as many have reported gdb problems with -gstabs.

Guenther
(This used to be commit 8befb22672d54a9255e5bdaf9cb0bb4e2b631245)

14 years agoLet DsGetDCName figure out whether domain_name is a flat_name when unjoining.
Günther Deschner [Thu, 3 Jan 2008 12:36:56 +0000 (13:36 +0100)]
Let DsGetDCName figure out whether domain_name is a flat_name when unjoining.

Guenther
(This used to be commit 75165ba4e7acafaca42f6afd1fb8b56e00bcbed7)

14 years agoFix configure output for libnetapi.
Günther Deschner [Thu, 3 Jan 2008 12:34:40 +0000 (13:34 +0100)]
Fix configure output for libnetapi.

Guenther
(This used to be commit d00ce6685a2cad7cd5526d4b13d43d157cd13481)

14 years agoIn libnetjoin don't mix admin password with machine account pwd.
Günther Deschner [Thu, 3 Jan 2008 12:17:15 +0000 (13:17 +0100)]
In libnetjoin don't mix admin password with machine account pwd.

Guenther
(This used to be commit 5b2eec21c27f07653e2dbb75c0f9ab4a60736773)

14 years agoIgnore generated pkgconfig files.
Günther Deschner [Thu, 3 Jan 2008 11:13:20 +0000 (12:13 +0100)]
Ignore generated pkgconfig files.

Guenther
(This used to be commit 1688eae5e868744fb209f59ed526b1a91d1fe0db)

14 years agoSome coding convention pedantism.
Günther Deschner [Thu, 3 Jan 2008 11:10:27 +0000 (12:10 +0100)]
Some coding convention pedantism.

Guenther
(This used to be commit 338baf96cb957fa52e312d42fbf0fa227d7dafda)

14 years agoReturn existsing cache_tree if it has already been initialized.
Michael Adam [Thu, 3 Jan 2008 11:07:02 +0000 (12:07 +0100)]
Return existsing cache_tree if it has already been initialized.

So reghook_cache_init() does not leak memory when called more
than once.
Also, fix the return value while we are at it.

Michael
(This used to be commit 25f571f40a630bff5a47bba6b01e42d4e0ffed66)

14 years agoRename libnet_smbconf_reg_setvalue_internal() to libnet_smbconf_reg_set_value().
Michael Adam [Thu, 3 Jan 2008 10:35:21 +0000 (11:35 +0100)]
Rename libnet_smbconf_reg_setvalue_internal() to libnet_smbconf_reg_set_value().

Michael
(This used to be commit 3fc3fee88afd9e8b6232afc140a07090b4215c23)

14 years agoFix a comment.
Michael Adam [Thu, 3 Jan 2008 10:33:17 +0000 (11:33 +0100)]
Fix a comment.

Michael
(This used to be commit 2d0c7fe44f075205db1713ef2d69006f7192c490)

14 years agoRename libnet_smbconf_reg_createkey_internal to libnet_smbconf_reg_create_service_key.
Michael Adam [Thu, 3 Jan 2008 10:32:00 +0000 (11:32 +0100)]
Rename libnet_smbconf_reg_createkey_internal to libnet_smbconf_reg_create_service_key.

Michael
(This used to be commit 08056a2c8160a44d27744467da467faea9ba0686)

14 years agoAdd libnet_conf API function libnet_smbconf_create_share().
Michael Adam [Thu, 3 Jan 2008 10:30:14 +0000 (11:30 +0100)]
Add libnet_conf API function libnet_smbconf_create_share().

And make libnet_smbconf_setparm() return error if the share
does not already exist. Adapt net_conf_addshare to this new
situation.

Michael
(This used to be commit de349bd26db3341815f6d8f6c18a5ca1fd664dca)

14 years agoRemove unused vars.
Günther Deschner [Thu, 3 Jan 2008 09:39:19 +0000 (10:39 +0100)]
Remove unused vars.

Guenther
(This used to be commit ff3f0006d167a9bca85919bf6115d73413554909)

14 years agoTrivial simplification
Volker Lendecke [Thu, 3 Jan 2008 09:24:45 +0000 (10:24 +0100)]
Trivial simplification

... things you come across when you review code
(This used to be commit 1e006bcfb15d44ecb81b6994c588d30d87b48033)

14 years agoAdd comments
Volker Lendecke [Thu, 3 Jan 2008 09:24:11 +0000 (10:24 +0100)]
Add comments

Jeremy was able to use this correctly without comments, so the code can't be
*that* bad :-)
(This used to be commit 6f22f7c13fd08ee772ac3aa593d2f4b37eb2cbee)

14 years agoFix for bug #5163 from Laurent Pinchart <pinchart@skynet.be>
Jeremy Allison [Thu, 3 Jan 2008 02:20:23 +0000 (18:20 -0800)]
Fix for bug #5163 from Laurent Pinchart <pinchart@skynet.be>
Failure to change password in ldap is mapped to NT_STATUS_UNSUCCESSFUL unconditionally.
Jeremy.
(This used to be commit 9369d6e907a49da1fbf2a5690118412b8d1a0383)

14 years agoConvert the little caches in util_sock.c to use
Jeremy Allison [Thu, 3 Jan 2008 01:37:39 +0000 (17:37 -0800)]
Convert the little caches in util_sock.c to use
the singleton memcache. Vl please check (passes
make valgrindtest).
Jeremy.
(This used to be commit a4d613cde86caf5782c4bfc47122d6ba807990ac)

14 years agoDon't leak: Use a temporary context for the admin token and free it.
Michael Adam [Thu, 3 Jan 2008 00:26:31 +0000 (01:26 +0100)]
Don't leak: Use a temporary context for the admin token and free it.

Michael
(This used to be commit 9d7502115e0f6cdfd27943d52f0de04447582b92)

14 years agoUse libnet_smbconf_reg_open_path() in libnet_smbconf_drop().
Michael Adam [Thu, 3 Jan 2008 00:12:23 +0000 (01:12 +0100)]
Use libnet_smbconf_reg_open_path() in libnet_smbconf_drop().

Replaces creation of token and direct use of reg_open_path.

Michael
(This used to be commit 7e407e18be0761e7004acfbd2376c3a435922c25)

14 years agoAbstract opening of registry path out of libnet_smbconf_reg_open_service_key().
Michael Adam [Thu, 3 Jan 2008 00:07:30 +0000 (01:07 +0100)]
Abstract opening of registry path out of libnet_smbconf_reg_open_service_key().

Creates new function libnet_smbconf_reg_open_path().
Use libnet_smbconf_reg_open_path() directly in libnet_smbconf_reg_open_basekey().
Return error in libnet_smbconf_reg_open_service_key() when NULL
servicename is given.

Michael
(This used to be commit 1e46b479638c54e8bd7ba939bc7aba18a27b5155)

14 years agoAdd debug output in error path.
Michael Adam [Wed, 2 Jan 2008 23:53:34 +0000 (00:53 +0100)]
Add debug output in error path.

Michael
(This used to be commit a58ccbc6d70613f7572bc80621935d81f9e290e3)

14 years agoFix setting of error code in error path.
Michael Adam [Wed, 2 Jan 2008 23:52:55 +0000 (00:52 +0100)]
Fix setting of error code in error path.

Michael
(This used to be commit 8a7954a9ae13df527ccedb1004ee4f87d506ce5b)

14 years agoUse a better parameter name.
Michael Adam [Wed, 2 Jan 2008 23:51:36 +0000 (00:51 +0100)]
Use a better parameter name.

Michael
(This used to be commit 3972deb90c4b645fb4d207a7e132cd7e180e78bb)

14 years agoRename libnet_smbconf_reg_open_path() to libnet_smbconf_reg_open_service_key().
Michael Adam [Wed, 2 Jan 2008 23:49:53 +0000 (00:49 +0100)]
Rename libnet_smbconf_reg_open_path() to libnet_smbconf_reg_open_service_key().

Michael
(This used to be commit d95b4935d3a97ca9c4b7990bbcf4e85c81c79516)

14 years agoHey, it is 2008 now.
Michael Adam [Wed, 2 Jan 2008 23:44:47 +0000 (00:44 +0100)]
Hey, it is 2008 now.

:-)

Michael
(This used to be commit a1d3f60ea753a158447bb0208441453b76a0f3b9)

14 years agoChoose a more apropriate parameter name.
Michael Adam [Wed, 2 Jan 2008 23:43:29 +0000 (00:43 +0100)]
Choose a more apropriate parameter name.

Michael
(This used to be commit 39a73b6291fd028d44fc2712afa76abf1fcff9cb)

14 years agoRename libnet_smbconf_reg_open_basepath() to libnet_smbconf_reg_open_basekey().
Michael Adam [Wed, 2 Jan 2008 23:35:09 +0000 (00:35 +0100)]
Rename libnet_smbconf_reg_open_basepath() to libnet_smbconf_reg_open_basekey().

Michael
(This used to be commit 9e953a94e9b3a060769938ef6af25623e446c180)

14 years agoFix some C++ warnings (patch was Volker's) - implicit case from void* to char*
Gerald (Jerry) Carter [Wed, 2 Jan 2008 23:34:41 +0000 (17:34 -0600)]
Fix some C++ warnings (patch was Volker's) - implicit case from void* to char*
(This used to be commit 518168410c49ac25085714c73e76dcf358fc4b68)

14 years agoMerge branch 'work/v3-2-test' into v3-2-test
Gerald (Jerry) Carter [Wed, 2 Jan 2008 23:15:10 +0000 (17:15 -0600)]
Merge branch 'work/v3-2-test' into v3-2-test
(This used to be commit 761858312b3470ff2acc2980882bad534275c552)