13 years agolib/util: fix build warning.
Günther Deschner [Fri, 25 Sep 2009 10:17:17 +0000 (12:17 +0200)]
lib/util: fix build warning.


13 years agos4:LDIFs - enhance the section comments
Matthias Dieter Wallnöfer [Wed, 23 Sep 2009 17:40:14 +0000 (19:40 +0200)]
s4:LDIFs - enhance the section comments

13 years agos4:auth/gensec/schannel - fix a const warning
Matthias Dieter Wallnöfer [Fri, 25 Sep 2009 08:43:42 +0000 (10:43 +0200)]
s4:auth/gensec/schannel - fix a const warning

13 years agos3:smbd/password - move list pointers into blocks
Matthias Dieter Wallnöfer [Fri, 25 Sep 2009 08:17:17 +0000 (10:17 +0200)]
s3:smbd/password - move list pointers into blocks

13 years agos3-libndr: fix build warning.
Günther Deschner [Thu, 24 Sep 2009 21:39:18 +0000 (23:39 +0200)]
s3-libndr: fix build warning.


13 years agos3:winbindd_cm: don't invalidate the whole connection when just samr gave ACCCESS_DENIED
Stefan Metzmacher [Thu, 24 Sep 2009 19:35:38 +0000 (21:35 +0200)]
s3:winbindd_cm: don't invalidate the whole connection when just samr gave ACCCESS_DENIED


13 years agos4:schannel: fix some compiler warnings
Stefan Metzmacher [Thu, 17 Sep 2009 23:54:22 +0000 (01:54 +0200)]
s4:schannel: fix some compiler warnings

If we only do signing we can pass down a const data buffer.


13 years agos3:rpc_client: don't randomly fragment rpc pdu's in developer mode
Stefan Metzmacher [Sun, 20 Sep 2009 21:29:11 +0000 (23:29 +0200)]
s3:rpc_client: don't randomly fragment rpc pdu's in developer mode

This is really confusing and also breaks against windows,
as it doesn't accept fragmented bind requests.


13 years agoMerge branch 'master' of git://
Nadezhda Ivanova [Fri, 25 Sep 2009 01:57:27 +0000 (18:57 -0700)]
Merge branch 'master' of git://

13 years agoFixed a dereferenced null pointer.
Nadezhda Ivanova [Fri, 25 Sep 2009 01:29:57 +0000 (18:29 -0700)]
Fixed a dereferenced null pointer.

13 years agomount.cifs: print output to stderr
Jeff Layton [Fri, 25 Sep 2009 00:55:43 +0000 (20:55 -0400)]
mount.cifs: print output to stderr

When a mount fails, mount.cifs often prints an error message. In most
cases, this error goes to stdout instead of stderr like it should. Fix
it to print errors to stderr instead.

Reported-by: Jan Engelhardt <>
Signed-off-by: Jeff Layton <>
13 years agoReduce debug log level from 0 -> 7 on non-critical message.
Jeremy Allison [Fri, 25 Sep 2009 00:44:45 +0000 (17:44 -0700)]
Reduce debug log level from 0 -> 7 on non-critical message.

13 years agoPatches to fix typos thanks to OPC oota.
John H Terpstra [Fri, 25 Sep 2009 00:26:03 +0000 (19:26 -0500)]
Patches to fix typos thanks to OPC oota.

13 years agoBug fix thanks to vjbangis viray
John H Terpstra [Fri, 25 Sep 2009 00:18:33 +0000 (19:18 -0500)]
Bug fix thanks to vjbangis viray

13 years agoRemove the const from the str_list_XXX functions that
Jeremy Allison [Thu, 24 Sep 2009 22:52:58 +0000 (15:52 -0700)]
Remove the const from the str_list_XXX functions that
allocate both list and containing strings. This fixes
problems that people have tried to cast away and are
not needed.

13 years agoRevert b39c390280d1f268e2550c731057aec550a3f086 - casts should not
Jeremy Allison [Thu, 24 Sep 2009 22:44:28 +0000 (15:44 -0700)]
Revert b39c390280d1f268e2550c731057aec550a3f086 - casts should not
be here.

13 years agoRevert 918b5a7e057bd91289ec06b3ef8d95da43a50ede. This code
Jeremy Allison [Thu, 24 Sep 2009 22:42:36 +0000 (15:42 -0700)]
Revert 918b5a7e057bd91289ec06b3ef8d95da43a50ede. This code
should *not* return const.

13 years agos3: Fix up various string "const" warnings
Matthias Dieter Wallnöfer [Thu, 24 Sep 2009 21:52:19 +0000 (23:52 +0200)]
s3: Fix up various string "const" warnings

My changed introduced some warnings. Fix them.

13 years agos3:util_str "str_list_make_v3" - introduce also here the "const" result
Matthias Dieter Wallnöfer [Thu, 24 Sep 2009 21:50:05 +0000 (23:50 +0200)]
s3:util_str "str_list_make_v3" - introduce also here the "const" result

I did this to match with the default util strlist library.

13 years agos3:vfs_default - correct function parameters
Matthias Dieter Wallnöfer [Thu, 24 Sep 2009 21:49:41 +0000 (23:49 +0200)]
s3:vfs_default - correct function parameters

13 years agos3-winbindd: no reason to call winbindd_can_contact_domain() three times in query_user().
Günther Deschner [Thu, 24 Sep 2009 16:20:50 +0000 (18:20 +0200)]
s3-winbindd: no reason to call winbindd_can_contact_domain() three times in query_user().


13 years agos3: remove unused printing macros.
Günther Deschner [Thu, 24 Sep 2009 16:20:13 +0000 (18:20 +0200)]
s3: remove unused printing macros.


13 years agos3 onefs: Fix 1 second share mode delay handling
Steven Danneman [Thu, 14 May 2009 23:14:03 +0000 (23:14 +0000)]
s3 onefs: Fix 1 second share mode delay handling

When racing to the open and loosing we may get a share_mode violation.
In this case handle the 1-second delay via a defferred open properly.

This requires us to retrieve the share_mode_lock before deferring
open so we don't dereference a NULL pointer assuming we already had
the lck because we were the first opener.

13 years agos3 onefs: Fix a race condition exists in onefs_open.c between multiple opens to the...
Steven Danneman [Thu, 14 May 2009 23:12:23 +0000 (23:12 +0000)]
s3 onefs: Fix a race condition exists in onefs_open.c between multiple opens to the same file.

Two openers can stat a file at the same time, see that it doesn't exist,
and then both race to open it first.  The loser will enter
onefs_open_file_ntcreate believing that the file doesnt exist, and thus
skip any current state lookups for that file.  This includes setting
the file_id, and having a valid stat buffer.

Normally on first create the file_id will be set during the open, but
the second opener in this scenario may fail the open (oplock/share mode)
and file_id will not be set, nor will the stat buffer be valid.

In the error paths of this patch, we now double check that the file_id
and the stat buffer are valid before doing other operations.

13 years agos3 onefs: Add some debugging/asserts to give more info when there is bad deferred...
Zack Kirsch [Wed, 22 Apr 2009 23:30:55 +0000 (23:30 +0000)]
s3 onefs: Add some debugging/asserts to give more info when there is bad deferred open state.

Signed-off-by: Tim Prouty <>
13 years agos4 torture: Fix RAW-STREAMS to request more specific permissions
Tim Prouty [Fri, 28 Aug 2009 22:53:09 +0000 (22:53 +0000)]
s4 torture: Fix RAW-STREAMS to request more specific permissions

This allows RAW-STREAMS to pass when the user isn't root on some
systems that don't give full access rights to non-root users.

13 years agos3: Add more helpful debugging to some of the streams code
Tim Prouty [Fri, 28 Aug 2009 22:53:05 +0000 (22:53 +0000)]
s3: Add more helpful debugging to some of the streams code

13 years agovfs catia: Fix a NULL dereference when CATIA is loaded with no mappings specified.
Aravind Srinivasan [Wed, 23 Sep 2009 20:37:04 +0000 (20:37 +0000)]
vfs catia: Fix a NULL dereference when CATIA is loaded with no mappings specified.

When we use the CATIA vfs module and don't have any mapping specified,
we return NULL for the mapped_name, thereby resulting in segfaults.
When we don't have catia mapping, we should just use the old name
instead of returning NULL for the mapped_name.

Signed-off-by: Tim Prouty <>
13 years agovfs catia: Fix the double translation that was happening with createfile and open.
Aravind Srinivasan [Thu, 3 Sep 2009 20:46:10 +0000 (20:46 +0000)]
vfs catia: Fix the double translation that was happening with createfile and open.

Since the catia translation is implemented for open, it should not
also be done in createfile.  By removing createfile from catia,
translation is now done correctly for the primary open path.

In order to support systems that have custom createfile
implementations that don't eventually call SMB_VFS_OPEN,
SMB_VFS_TRANSLATE_NAME has been expanded to take an additional
argument that specifies direction.

Signed-off-by: Tim Prouty <>
13 years agovfs catia: Fix a possible NULL dereference
Aravind Srinivasan [Wed, 2 Sep 2009 17:20:21 +0000 (17:20 +0000)]
vfs catia: Fix a possible NULL dereference

Also free some unfreed memory.

Signed-off-by: Tim Prouty <>
13 years agos4-drs: el may not be a talloc pointer
Andrew Tridgell [Thu, 24 Sep 2009 14:08:31 +0000 (07:08 -0700)]
s4-drs: el may not be a talloc pointer

Use msg->elements for the new element values

13 years agos4-drs: regenerate IDL after ndr size change
Andrew Tridgell [Thu, 24 Sep 2009 14:19:46 +0000 (07:19 -0700)]
s4-drs: regenerate IDL after ndr size change

13 years agos4-drs: add defines for replication flags on attributes
Andrew Tridgell [Thu, 24 Sep 2009 14:19:01 +0000 (07:19 -0700)]
s4-drs: add defines for replication flags on attributes

13 years agos4-ldb: sort replPropertyMetaData by attid
Andrew Tridgell [Thu, 24 Sep 2009 14:18:21 +0000 (07:18 -0700)]
s4-ldb: sort replPropertyMetaData by attid

We need to sort on both module add and modify

13 years agos4-ldb: add instanceType in repl_meta_data module
Andrew Tridgell [Thu, 24 Sep 2009 14:16:50 +0000 (07:16 -0700)]
s4-ldb: add instanceType in repl_meta_data module

We need to add instanceType on new records if not added by caller. This is needed in repl_meta_data
to ensure we fill in the meta data for replication

13 years agos4-drs: fixed the size of DN binary blobs on the wire
Andrew Tridgell [Thu, 24 Sep 2009 14:02:47 +0000 (07:02 -0700)]
s4-drs: fixed the size of DN binary blobs on the wire

Comparison with w2k8 traces shows the size field of
drsuapi_DsReplicaObjectIdentifier3Binary is taken from

Thanks to metze for spotting this

13 years agos4-drs: include deleted objects in getncchanges reply
Andrew Tridgell [Thu, 24 Sep 2009 14:12:14 +0000 (07:12 -0700)]
s4-drs: include deleted objects in getncchanges reply

Even though we don't create deleted objects ourselves yet, we need to
pass along deleted objects we receive from other replication partners

13 years agos4-drs: add SHOW_DELETED control on dsdb utility calls
Andrew Tridgell [Thu, 24 Sep 2009 14:05:07 +0000 (07:05 -0700)]
s4-drs: add SHOW_DELETED control on dsdb utility calls

The dsdb_find_dn_by_guid() and dsdb_find_sid_by_dn() are using by
the DRS server call getncchanges on objects that may be deleted.

13 years agos4-libnet: allow the functional level of becomeDC to be specified
Andrew Tridgell [Wed, 23 Sep 2009 21:53:28 +0000 (14:53 -0700)]
s4-libnet: allow the functional level of becomeDC to be specified

   ads:functional level = 4
for DS_DC_FUNCTION_2008_R2

See libds/common/flags.h

13 years agos4-libnet: avoid a steal with references error
Andrew Tridgell [Thu, 24 Sep 2009 17:33:36 +0000 (10:33 -0700)]
s4-libnet: avoid a steal with references error

13 years agoAdd init file for DCE/RPC tests.
Jelmer Vernooij [Wed, 23 Sep 2009 17:52:52 +0000 (19:52 +0200)]
Add init file for DCE/RPC tests.

13 years agoPEP8
Jelmer Vernooij [Wed, 23 Sep 2009 17:52:45 +0000 (19:52 +0200)]

13 years agoRevert "s4:python fixed subunit tests of dcerpc"
Jelmer Vernooij [Wed, 23 Sep 2009 14:54:17 +0000 (16:54 +0200)]
Revert "s4:python  fixed subunit tests of dcerpc"

This reverts commit ffd48a79ee34dc90c0f6f16564c3a0de8b53d3d2.

13 years agos3: Forgot to check in one build failure for vfs_gpfs.c
Volker Lendecke [Thu, 24 Sep 2009 11:11:14 +0000 (13:11 +0200)]
s3: Forgot to check in one build failure for vfs_gpfs.c

13 years agos3: Remove an unused variable
Volker Lendecke [Thu, 24 Sep 2009 11:10:54 +0000 (13:10 +0200)]
s3: Remove an unused variable

13 years agos3: Make the vfs_gpfs compile at least
Volker Lendecke [Thu, 24 Sep 2009 10:49:18 +0000 (12:49 +0200)]
s3: Make the vfs_gpfs compile at least

Not sure whether it works in this state :-)

13 years agoRevert "s3:winbindd: use a tcp connection for lsa in case lookup_names/lookup_sids...
Stefan Metzmacher [Thu, 24 Sep 2009 04:45:10 +0000 (06:45 +0200)]
Revert "s3:winbindd: use a tcp connection for lsa in case lookup_names/lookup_sids doesn't work over ncacn_np"

This reverts commit f23691cffd39e5df81b7b075e61ed1def6cce9f6.

This should not have been commited...


13 years agos3:rpc_server: we need to make a copy of my_name in serverinfo_to_SamInfo_base()
Stefan Metzmacher [Thu, 24 Sep 2009 04:38:08 +0000 (06:38 +0200)]
s3:rpc_server: we need to make a copy of my_name in serverinfo_to_SamInfo_base()

This is important for the case the server_info already contains a logon_server.


13 years agos3:winbindd: use a tcp connection for lsa in case lookup_names/lookup_sids doesn...
Günther Deschner [Thu, 17 Sep 2009 07:43:36 +0000 (09:43 +0200)]
s3:winbindd: use a tcp connection for lsa in case lookup_names/lookup_sids doesn't work over ncacn_np


Anatoliy Atanasov [Wed, 23 Sep 2009 23:51:55 +0000 (16:51 -0700)]

When this flag is specified in the request these attributes are treated as
secret: currentValue, dBCSPwd, initialAuthIncoming, initialAuthOutgoing,
lmPwdHistory, ntPwdHistory, priorValue, supplementalCredentials,
trustAuthIncoming, trustAuthOutgoing, unicodePwd
Their value is changed to NULL and the meta_data.originating_change_time to 0

13 years agos4: Handle DRSUAPI_DS_REPLICA_NEIGHBOUR_ASYNC_REP in getncchanges
Anatoliy Atanasov [Wed, 23 Sep 2009 23:52:34 +0000 (16:52 -0700)]

When this flag is specified in the request we should return
for ncRoot only and so scope of search is LDB_SCOPE_BASE.

13 years agos4: Handle DRSUAPI_DS_REPLICA_NEIGHBOUR_FULL_SYNC_PACKET in getncchanges
Anatoliy Atanasov [Wed, 23 Sep 2009 23:58:58 +0000 (16:58 -0700)]

When this flag is specified in the request we shouldn't use the
uptodateness vector in the request.

13 years agoidl: regenerate idl
Anatoliy Atanasov [Wed, 23 Sep 2009 22:48:10 +0000 (15:48 -0700)]
idl: regenerate idl

13 years agos4: Handle DRSUAPI_DS_REPLICA_NEIGHBOUR_CRITICAL_ONLY req in getncchanges
Anatoliy Atanasov [Wed, 23 Sep 2009 22:47:14 +0000 (15:47 -0700)]

13 years agoRevert "r20074: this values seem to be typos in drsuapi"
Stefan Metzmacher [Fri, 8 Dec 2006 00:11:39 +0000 (00:11 +0000)]
Revert "r20074: this values seem to be typos in drsuapi"

This reverts commit 1dfd365d57dcd712d315a1a903c8d3d0a0f0fc12

This change was from and the flags I was seeing have another meaning.


Signed-off-by: Anatoliy Atanasov <>
13 years agos4:ldif_handlers Fix memory leak in objectCategory LDIF handler
Andrew Bartlett [Tue, 1 Sep 2009 09:56:56 +0000 (19:56 +1000)]
s4:ldif_handlers Fix memory leak in objectCategory LDIF handler

13 years agos4-drs: fill in more guids and SIDs, plus filter rDN
Andrew Tridgell [Wed, 23 Sep 2009 20:56:10 +0000 (13:56 -0700)]
s4-drs: fill in more guids and SIDs, plus filter rDN

In DsGetNCChanges we need to fill in the parentGUID and objectGUID of
each object, plus we need to filter out the rDN from the meta data,
and always send the instanceType

13 years agos4-dsdb: cope with windows sending extra pad bytes
Andrew Tridgell [Wed, 23 Sep 2009 20:54:47 +0000 (13:54 -0700)]
s4-dsdb: cope with windows sending extra pad bytes

13 years agos4-dsdb: added dsdb_find_sid_by_dn()
Andrew Tridgell [Wed, 23 Sep 2009 20:52:39 +0000 (13:52 -0700)]
s4-dsdb: added dsdb_find_sid_by_dn()

13 years agos4-drsserver: fixed addition of sort control
Andrew Tridgell [Wed, 23 Sep 2009 03:57:18 +0000 (20:57 -0700)]
s4-drsserver: fixed addition of sort control

13 years agofixed spelling
Andrew Tridgell [Wed, 23 Sep 2009 03:56:54 +0000 (20:56 -0700)]
fixed spelling

13 years agos4-drs: ignore zero value elements in DRS add operations
Andrew Tridgell [Wed, 23 Sep 2009 03:56:32 +0000 (20:56 -0700)]
s4-drs: ignore zero value elements in DRS add operations

w2k8 sometimes sends us a new object via DRS with an attribute with no

13 years agos4-netlogon: always set the dNSHostName in GetDomainInfo
Andrew Tridgell [Mon, 21 Sep 2009 23:30:31 +0000 (16:30 -0700)]
s4-netlogon: always set the dNSHostName in GetDomainInfo

This seems to be what w2k8 does

13 years agoregenerate IDL
Andrew Tridgell [Mon, 21 Sep 2009 17:45:14 +0000 (10:45 -0700)]
regenerate IDL

13 years agos4-netlogon: make GetDomainInfo response match w2k8
Andrew Tridgell [Mon, 21 Sep 2009 17:42:42 +0000 (10:42 -0700)]
s4-netlogon: make GetDomainInfo response match w2k8

13 years agos4-cldap: return domainFunctionality from SAM
Andrew Tridgell [Mon, 21 Sep 2009 17:41:06 +0000 (10:41 -0700)]
s4-cldap: return domainFunctionality from SAM

13 years agoidl: fixed string termination for netlogon GetDomainInfo
Andrew Tridgell [Mon, 21 Sep 2009 17:38:40 +0000 (10:38 -0700)]
idl: fixed string termination for netlogon GetDomainInfo

13 years agos4-nbt: added NBT_SERVER_DNS_FOREST
Andrew Tridgell [Mon, 21 Sep 2009 17:38:09 +0000 (10:38 -0700)]

13 years agos3:gencache: Make gencache_del() return success for expired entries
Volker Lendecke [Wed, 23 Sep 2009 13:47:05 +0000 (15:47 +0200)]
s3:gencache: Make gencache_del() return success for expired entries

This fixes nasty error messages from "net cache flush"

13 years agos3:gencache: Remove some over-paranoid locking
Volker Lendecke [Wed, 23 Sep 2009 13:41:06 +0000 (15:41 +0200)]
s3:gencache: Remove some over-paranoid locking

13 years agos3:gencache: Add a "was_expired" argument to gencache_get_data_blob
Volker Lendecke [Wed, 23 Sep 2009 13:21:40 +0000 (15:21 +0200)]
s3:gencache: Add a "was_expired" argument to gencache_get_data_blob

This is set to true if the routine returns failure due to an existing but
expired entry.

13 years agoCheck for PyString_FromString being NULL.
Jelmer Vernooij [Wed, 23 Sep 2009 12:22:36 +0000 (14:22 +0200)]
Check for PyString_FromString being NULL.

13 years agoprovision: Avoid linking in multiple copies of security python module.
Jelmer Vernooij [Wed, 23 Sep 2009 09:01:52 +0000 (11:01 +0200)]
provision: Avoid linking in multiple copies of security python module.

13 years agos3:winbind: Fix an uninitialized variable
Volker Lendecke [Wed, 23 Sep 2009 04:23:50 +0000 (06:23 +0200)]
s3:winbind: Fix an uninitialized variable

13 years agos4-drsserver: sort by DN to give tree order
Andrew Tridgell [Wed, 23 Sep 2009 00:07:33 +0000 (17:07 -0700)]
s4-drsserver: sort by DN to give tree order

This might help the windows client with ordered requests. Later we
need to support the "ancestors" mode flag.

13 years agos4-ldb: server side sort args are const char *
Andrew Tridgell [Wed, 23 Sep 2009 00:06:38 +0000 (17:06 -0700)]
s4-ldb: server side sort args are const char *

13 years agos4-ldb: fixed call argument order for ldb_dn_from_ldb_val
Andrew Tridgell [Wed, 23 Sep 2009 00:06:14 +0000 (17:06 -0700)]
s4-ldb: fixed call argument order for ldb_dn_from_ldb_val

This caused _lots_ of problems, especially in server side sort

13 years agos4-ldb: added a bunch more debug for DC join
Andrew Tridgell [Tue, 22 Sep 2009 21:26:59 +0000 (14:26 -0700)]
s4-ldb: added a bunch more debug for DC join

These additional debug messages were added to help us track down
w2k8->s4 domain join

13 years agos4-ldb: when tracing, show ldb_set_debug messages
Andrew Tridgell [Tue, 22 Sep 2009 21:25:52 +0000 (14:25 -0700)]
s4-ldb: when tracing, show ldb_set_debug messages

13 years agos4-ldbmodules: allow instanceType to be specified by clients
Andrew Tridgell [Tue, 22 Sep 2009 21:25:12 +0000 (14:25 -0700)]
s4-ldbmodules: allow instanceType to be specified by clients

This is needed for the WSPP ADS testsuite

13 years agos4-util: windows only accepts lowercase hex encodings for extended DNs
Andrew Tridgell [Tue, 22 Sep 2009 21:20:36 +0000 (14:20 -0700)]
s4-util: windows only accepts lowercase hex encodings for extended DNs

13 years agos4-torture: add some debug info to RPC-HANDLES
Andrew Tridgell [Tue, 22 Sep 2009 07:18:25 +0000 (00:18 -0700)]
s4-torture: add some debug info to RPC-HANDLES

13 years agos4-rpcserver: added support for shared handles
Andrew Tridgell [Tue, 22 Sep 2009 07:18:03 +0000 (00:18 -0700)]
s4-rpcserver: added support for shared handles

This supports shared RPC handles across connections on all RPC

It turns out that w2k3 and w2k8 don't actually support this on all
pipes. We need to test which pipes we should enable this on.

13 years agos4-lsa: added support for QuerySecurity on LSA
Andrew Tridgell [Tue, 22 Sep 2009 07:16:58 +0000 (00:16 -0700)]
s4-lsa: added support for QuerySecurity on LSA

This follows the sd pattern from samba3

13 years agos4-rpcserver: added shared association groups
Andrew Tridgell [Tue, 22 Sep 2009 04:36:54 +0000 (21:36 -0700)]
s4-rpcserver: added shared association groups

This patch allows us to share association groups and their rpc handles
between connections. This is needed for some DRSUAPI behaviour when
recent windows clients connect.

13 years agos4-rpcserver: run all RPC operations in a single task
Andrew Tridgell [Tue, 22 Sep 2009 02:57:27 +0000 (19:57 -0700)]
s4-rpcserver: run all RPC operations in a single task

This will make it much easier to implement shared handles with
association groups. It also means we can shared the ldb between RPC

13 years agos4-rpc: remove two unused functions
Andrew Tridgell [Tue, 22 Sep 2009 02:56:36 +0000 (19:56 -0700)]
s4-rpc: remove two unused functions

13 years agos4-ldb: only show the outer level of ldb ops when tracing
Andrew Tridgell [Tue, 22 Sep 2009 01:15:19 +0000 (18:15 -0700)]
s4-ldb: only show the outer level of ldb ops when tracing

13 years agos4-ldb: don't show timestamps on every line of ldb traces
Andrew Tridgell [Tue, 22 Sep 2009 00:52:21 +0000 (17:52 -0700)]
s4-ldb: don't show timestamps on every line of ldb traces

This adds ldb_debug_add() and ldb_debug_end() to format multiline

13 years agobuild: use AS_HELP_STRING() for --with-localedir
Michael Adam [Tue, 22 Sep 2009 22:52:03 +0000 (00:52 +0200)]
build: use AS_HELP_STRING() for --with-localedir


13 years agobuild: add switch "--with-codepagedir=DIR" to configure.
Michael Adam [Tue, 22 Sep 2009 22:48:44 +0000 (00:48 +0200)]
build: add switch "--with-codepagedir=DIR" to configure.

This is to address bug #6444.


13 years agobuild: add datadir to "make showlayout"
Michael Adam [Tue, 22 Sep 2009 21:23:02 +0000 (23:23 +0200)]
build: add datadir to "make showlayout"


13 years agoMove the check above the talloc
Anatoliy Atanasov [Tue, 22 Sep 2009 21:37:58 +0000 (14:37 -0700)]
Move the check above the talloc

13 years agos3-winbindd: Fix Bug #6711: trusts to windows 2008 (2008 r2) not working.
Günther Deschner [Thu, 17 Sep 2009 07:43:36 +0000 (09:43 +0200)]
s3-winbindd: Fix Bug #6711: trusts to windows 2008 (2008 r2) not working.

Winbindd should always try to use LSA via an schannel authenticated ncacn_ip_tcp
connection when talking to AD for LSA lookup calls.

In Samba <-> W2k8 interdomain trust scenarios, LookupSids3 and LookupNames4 via an
schannel ncacn_ip_tcp LSA connection are the *only* options to successfully resolve
sids and names.


13 years agos3-winbindd: add cm_connect_lsa_tcp().
Günther Deschner [Sat, 12 Sep 2009 21:30:39 +0000 (23:30 +0200)]
s3-winbindd: add cm_connect_lsa_tcp().


13 years agolib/tevent: a cleaner fix for be4ac227842530d484659f2db683453366326d8b segv
Rusty Russell [Tue, 22 Sep 2009 01:02:10 +0000 (10:32 +0930)]
lib/tevent: a cleaner fix for be4ac227842530d484659f2db683453366326d8b segv

Revert 23abcd2318c69753aa2a144e1dc0f9cf9efdb705 and fix logic bug.

The current code loops through the event contexts, when it sees a different
one, it notifies the current one (ev) and updates ev to point to the new one.

This is dumb, because:
(1) ev starts as NULL, so this code crashes, and
(2) The final context will not be notified.

The correct fix for this is to update ev to the new one, then notify it.
Volker's fix works because we currently always have one event context.

Signed-off-by: Rusty Russell <>
13 years agos4:dsdb Fix of double addition of SD-s
Nadezhda Ivanova [Tue, 22 Sep 2009 03:08:52 +0000 (20:08 -0700)]
s4:dsdb Fix of double addition of SD-s

Also add error strings in descriptor module

13 years agos4:ldb Add 'single-value' support to LDB.
Andrew Bartlett [Tue, 22 Sep 2009 02:26:59 +0000 (19:26 -0700)]
s4:ldb Add 'single-value' support to LDB.

This is currently only triggered via Samba4's schema code.

13 years agoMerge branch 'master' of git://
Nadezhda Ivanova [Tue, 22 Sep 2009 00:29:28 +0000 (17:29 -0700)]
Merge branch 'master' of git://

13 years agoInitial Implementation of the DS objects access checks.
Nadezhda Ivanova [Tue, 22 Sep 2009 00:27:50 +0000 (17:27 -0700)]
Initial Implementation of the DS objects access checks.

Currently disabled. The search will be greatly modified,
also the object tree stuff will be simplified.