20 years agoSpelling fix.
Tim Potter [Mon, 7 Jan 2002 02:58:31 +0000 (02:58 +0000)]
Spelling fix.
(This used to be commit dfcc97a15837e2d13561e023ad5a7532faa441b8)

20 years agoDon't log the password in pam_sm_authenticate() unless DEBUG_PASSWORD is
Tim Potter [Mon, 7 Jan 2002 02:57:06 +0000 (02:57 +0000)]
Don't log the password in pam_sm_authenticate() unless DEBUG_PASSWORD is
defined.  This is done with --enable-developer mode.
(This used to be commit caff5dc1d66953cb52f94cd6407778b23e1810eb)

20 years ago sync up comments with 2.2
Gerald Carter [Sun, 6 Jan 2002 23:21:23 +0000 (23:21 +0000)]
 sync up comments with 2.2
(This used to be commit 3d4adad1501fc02ee0c60c69c01a92bdb16a1711)

20 years agoConverted enumprinters and enumports cmd functions to use WERROR
Tim Potter [Sun, 6 Jan 2002 09:03:48 +0000 (09:03 +0000)]
Converted enumprinters and enumports cmd functions to use WERROR
values returned from cli functions.  They are converted to NTSTATUS codes
using the error map functions.

Do buffer size loop checks by setting offered = 0 and using the return
value of needed in the next call.
(This used to be commit 4efbdda3fcfd1fad2f2b8909d250735382497836)

20 years agoConverted enumprinters and enumports cli functions to return WERRORs.
Tim Potter [Sun, 6 Jan 2002 09:02:14 +0000 (09:02 +0000)]
Converted enumprinters and enumports cli functions to return WERRORs.

Make the offered and needed buffer size into parameters.
(This used to be commit 9d9e7fb74d420913cda1c592765b498fd64384f0)

20 years agoCheck for winbind separator in user name for cli_session_setup()
Tim Potter [Sun, 6 Jan 2002 04:03:26 +0000 (04:03 +0000)]
Check for winbind separator in user name for cli_session_setup()

Patch from Alexander Bokovoy <>
(This used to be commit 6c42bf208976ed3020e57efff6281f984d9fe893)

20 years agospoolss rpc client cleanup:
Tim Potter [Sun, 6 Jan 2002 03:54:40 +0000 (03:54 +0000)]
spoolss rpc client cleanup:

 - converted OpenPrinterEx and ClosePrinter to WERROR instead of NT_STATUS
 - doc
(This used to be commit 248d114f856f1adb76c903b683e0927530771443)

20 years agoDefine a rpc_client doc group.
Tim Potter [Sun, 6 Jan 2002 03:49:28 +0000 (03:49 +0000)]
Define a rpc_client doc group.
(This used to be commit 87bc0a71ecb0fc047fec5e0d240045fab09dd5d0)

20 years agoMinor doc cleanups.
Tim Potter [Sun, 6 Jan 2002 03:48:41 +0000 (03:48 +0000)]
Minor doc cleanups.
(This used to be commit 5c8f6be290e78c4e72c821abdc9f06b7150e68e7)

20 years agoAdded a get_dos_error_msg() function to mirror the get_nt_error_msg()
Tim Potter [Sun, 6 Jan 2002 03:41:29 +0000 (03:41 +0000)]
Added a get_dos_error_msg() function to mirror the get_nt_error_msg()

One day I'll get around to refactoring the DOS error handling so it mirrors
the NT error handling code.
(This used to be commit f4535721d350f3068e8dfb612331eb609ea03da0)

20 years agoDisplay nicer message when server name could not be resolved.
Tim Potter [Sun, 6 Jan 2002 03:24:51 +0000 (03:24 +0000)]
Display nicer message when server name could not be resolved.
(This used to be commit 950d8e365626ecbd82e9ee965dc1724dc50c64a4)

20 years agoDOS error 31 is ERRgeneral, General Failure. This is the WERROR equivalent
Tim Potter [Sun, 6 Jan 2002 02:55:37 +0000 (02:55 +0000)]
DOS error 31 is ERRgeneral, General Failure.  This is the WERROR equivalent
to NT_STATUS_UNSUCCESSFUL according to AB's funky new error map.
(This used to be commit 9c968fbb017d3369ac207e65348a9a22dbed0213)

20 years agoGet this code back to where it belongs...
Andrew Bartlett [Sun, 6 Jan 2002 01:37:14 +0000 (01:37 +0000)]
Get this code back to where it belongs...

Apparently (and I will doublecheck) its legal to do an annoymous session setup
when we negoitiated SPNEGO, but we can't do an authenticated one becouse we
didn't give a challange.

Andrew Bartlett
(This used to be commit 08a5c5bf940fac7a779be01db01ae7d97df80f79)

20 years agoSome more SPNEGO fixes.
Andrew Bartlett [Sun, 6 Jan 2002 00:49:23 +0000 (00:49 +0000)]
Some more SPNEGO fixes.
(This used to be commit 0e564cb32acc70c1fc43f1be5ceb3637f0dc7361)

20 years agofixed another DATA_BLOB constructor
Andrew Tridgell [Sat, 5 Jan 2002 23:34:06 +0000 (23:34 +0000)]
fixed another DATA_BLOB constructor
(This used to be commit c6affae4bf749a67c90468702eb6d4eeb97a4363)

20 years agosimple fix for creating blank data blobs
Andrew Tridgell [Sat, 5 Jan 2002 23:30:59 +0000 (23:30 +0000)]
simple fix for creating blank data blobs
(This used to be commit 08bb2dfec2ca0282e9268d09da2b966d3bdf493a)

20 years agomerge from 2.2
Gerald Carter [Sat, 5 Jan 2002 19:27:26 +0000 (19:27 +0000)]
merge from 2.2
(This used to be commit 67c6a24344e31c417c8c6f5db27697e268524401)

20 years agoFix up the SPNEGO segfault.
Andrew Bartlett [Sat, 5 Jan 2002 12:04:33 +0000 (12:04 +0000)]
Fix up the SPNEGO segfault.
(This used to be commit 17b1c83dd02035048bd38b305460c96c6c09343a)

20 years agoyeah! I think I figured it out now
Gerald Carter [Sat, 5 Jan 2002 06:11:29 +0000 (06:11 +0000)]
yeah!  I think I figured it out now
(This used to be commit 9713bce0354009fb4d9c06989ff86900101eae0c)

20 years agoI've decided to move the auth code around a bit more...
Andrew Bartlett [Sat, 5 Jan 2002 04:55:41 +0000 (04:55 +0000)]
I've decided to move the auth code around a bit more...

The auth_authsupplied_info typedef is now just a plain struct - auth_context,
but it has been modified to contain the function pointers to the rest
of the auth subsystem's components.

(Who needs non-static functions anyway?)

In working all this mess out, I fixed a number of memory leaks and moved the
entire auth subsystem over to talloc().

Note that the TALLOC_CTX attached to the auth_context can be rather long-lived,
it is provided for things that are intended to live as long.  (The
global_negprot_auth_context lasts the whole life of the smbd).

I've also adjusted a few things in auth_domain.c, mainly passing the domain as
a paramater to a few functions instead of looking up lp_workgroup().  I'm
hopign to make this entire thing a bit more trusted domains (as PDC) freindly
in the near future.

Other than that, I moved a bit of the code around, hence the rather messy diff.

Andrew Bartlett
(This used to be commit 12f5515f556cf39fea98134fe3e2ac4540501048)

20 years agoAdd a talloc varient of the data_blob functions.
Andrew Bartlett [Sat, 5 Jan 2002 04:23:12 +0000 (04:23 +0000)]
Add a talloc varient of the data_blob functions.

Also change the structure so it has its own (optional) 'free' pointer - so we
don't free() a talloc'ed version.

also split out the data_blob_clear() functionaility.

Andrew Bartlett
(This used to be commit 207ee8aac42cf4b35f07e496b15fdeabe50950bc)

20 years agoAdd a comment on how this error map was derrived.
Andrew Bartlett [Sat, 5 Jan 2002 04:04:03 +0000 (04:04 +0000)]
Add a comment on how this error map was derrived.

This applies only to the NT->Dos map, I'm still trying to come up with a way to
do the reverse.
(This used to be commit 323dd422bd4bdeeee72c9200821e28f86d3072c8)

20 years agoforgot a few files
Gerald Carter [Sat, 5 Jan 2002 03:53:42 +0000 (03:53 +0000)]
forgot a few files
(This used to be commit 9844ec33995316843567fc32d2ea276c565cf56c)

20 years agomerge from 2.2 and regenerate docs
Gerald Carter [Sat, 5 Jan 2002 03:52:39 +0000 (03:52 +0000)]
merge from 2.2 and regenerate docs
(This used to be commit f7d900873c3553dde88d42d903b74dc49c9a6c71)

20 years agoOne line fix to get smbmount working again.
Andrew Bartlett [Sat, 5 Jan 2002 03:45:50 +0000 (03:45 +0000)]
One line fix to get smbmount working again.

This just turns of SPNGO becouse Win2k breaks if you attempt this and DOS
errors at the same time.

Andrew Bartlett
(This used to be commit 2c09907b537147189e77810f586558be6004733b)

20 years agoAdded DEBUG in set_share_mode to track down logic insanity.
Jeremy Allison [Sat, 5 Jan 2002 02:37:23 +0000 (02:37 +0000)]
Added DEBUG in set_share_mode to track down logic insanity.
(This used to be commit 32f4f3a45d473b3be1ae07f6c60897c12323d60c)

20 years agoAdd a touch of const
Andrew Bartlett [Sat, 5 Jan 2002 01:33:45 +0000 (01:33 +0000)]
Add a touch of const
(This used to be commit b2af4372b1dac2e8f283184191fbb0231409a625)

20 years agoprint the timezone in the same format as 'date +%z' - much better for scripting
Andrew Tridgell [Fri, 4 Jan 2002 23:02:14 +0000 (23:02 +0000)]
print the timezone in the same format as 'date +%z' - much better for scripting
(This used to be commit faa1b222f170abe34f6930bb3493cbe8b4df4082)

20 years agoMissed error return is can_rename fails.
Jeremy Allison [Fri, 4 Jan 2002 22:30:00 +0000 (22:30 +0000)]
Missed error return is can_rename fails.
(This used to be commit 2db99fa49b538e230f2c606d1004871111ea2bf6)

20 years agoRe-wrote the guts of the rename_internals code to cope with a reported
Jeremy Allison [Fri, 4 Jan 2002 21:11:35 +0000 (21:11 +0000)]
Re-wrote the guts of the rename_internals code to cope with a reported
bug (renaming name -> name was failing, on W2K it succeeds). Simplified
the common case, did a lot of work to ensure NT error codes are correctly
reported back to client.
(This used to be commit e6b27f3d8069ae304baaebe09341c58d46b05fe4)

20 years agosync with 2.2
Gerald Carter [Fri, 4 Jan 2002 00:05:23 +0000 (00:05 +0000)]
sync with 2.2
(This used to be commit 9e3b432c57747e6fd876c53a576858ef1227ba8e)

20 years agoAdded WERROR for non local domain.
Jeremy Allison [Thu, 3 Jan 2002 23:26:00 +0000 (23:26 +0000)]
Added WERROR for non local domain.
(This used to be commit 6c51d90f13a40359baef08424f7ea1940f93d511)

20 years agoFixed nasty cast of tdb_delete in traversals.
Jeremy Allison [Thu, 3 Jan 2002 22:48:48 +0000 (22:48 +0000)]
Fixed nasty cast of tdb_delete in traversals.
(This used to be commit a0cdec3acc82d1ce0292fadd4b8dac23638450f3)

20 years agoNote: This does NOT work yet. More work is in progress - please wait before using.
John Terpstra [Thu, 3 Jan 2002 22:26:54 +0000 (22:26 +0000)]
Note: This does NOT work yet. More work is in progress - please wait before using.
(This used to be commit 72bda5e82173a95af58c58f8b454850f8794c356)

20 years agoDon't use static memory, malloc it...
Jeremy Allison [Thu, 3 Jan 2002 21:48:17 +0000 (21:48 +0000)]
Don't use static memory, malloc it...
(This used to be commit 8aee8211cddb6705c9aa545fc57ece2c721ef448)

20 years agoFix the fix.... (sigh).
Jeremy Allison [Thu, 3 Jan 2002 21:37:45 +0000 (21:37 +0000)]
Fix the fix.... (sigh).
(This used to be commit 73cf9d04f6a35aa3b6bdb4e921de34e0021b5a2c)

20 years agoEnsure modtime is set correctly on destination files in copy command.
Jeremy Allison [Thu, 3 Jan 2002 20:49:06 +0000 (20:49 +0000)]
Ensure modtime is set correctly on destination files in copy command.
(This used to be commit fb1ab02553e01df0464f0df3eea7ae6a66b4104b)

20 years agoFixed embarressing 16k strack trashing bug :-(.
Jeremy Allison [Thu, 3 Jan 2002 19:57:12 +0000 (19:57 +0000)]
Fixed embarressing 16k strack trashing bug :-(.
(This used to be commit b52c3219d6f46df6e98742447d65ecda2ecbac65)

20 years agoadded nTSecurityDescriptor field to host acct dump
Andrew Tridgell [Thu, 3 Jan 2002 11:59:33 +0000 (11:59 +0000)]
added nTSecurityDescriptor field to host acct dump
(This used to be commit f383e19e095eab975bf3d4e622a5c1d1f823171b)

20 years agoUpdate the NT_STATUS -> DOS error table.
Andrew Bartlett [Thu, 3 Jan 2002 08:36:47 +0000 (08:36 +0000)]
Update the NT_STATUS -> DOS error table.

This new table is rather different to the old one (see diff posted to the
list for a sorted list of differences) and needs a *lot* of testing.

It does however seem to line up much better with what NT is using, as
exampled by the change to the OBJECT_NAME_COLLISION DOS error, it now matches
win2k where it didn't before.

I can't see any critical errors we now get wrong, and I know that the auth
errors are correct as per my on-the-wire observations.

This table was produced (and I hope to comment this better later) by
using the ERRMAPEXTRACT smbtorture tool, a Win2k domain member and the
'name_to_ntstatus' auth module on the HEAD PDC.  This module returned
the username as the error, and the NT box was forced to give me a dos
error becouse thats all I negotiated on that connection.  Hence the map.

Andrew Bartlett
(This used to be commit a855dfb2e0b899d03087860e5462c2aed3ca4cad)

20 years agoClarify doc for SAFE_FREE.
Martin Pool [Thu, 3 Jan 2002 07:49:07 +0000 (07:49 +0000)]
Clarify doc for SAFE_FREE.
(This used to be commit 269a7d3c9ba8ca1444653c1aa56b843b8b1df08b)

20 years agoMake a couple more of the warnings also be C comments
Andrew Bartlett [Thu, 3 Jan 2002 07:42:15 +0000 (07:42 +0000)]
Make a couple more of the warnings also be C comments
(This used to be commit 8f343beae7455141ce6a5e27e46ed2970aed8e7f)

20 years agoA few changes to always output the erorr mapping even when the error was
Andrew Bartlett [Thu, 3 Jan 2002 07:36:26 +0000 (07:36 +0000)]
A few changes to always output the erorr mapping even when the error was
'squashed' or the session setup succeeded.  (How the latter occurs I don't know).
(This used to be commit d879d2ffffc47ce161afb3d96bc5c4b92de662c3)

20 years agoWorkaround some 'smarts' in Win2k.
Andrew Bartlett [Thu, 3 Jan 2002 07:00:18 +0000 (07:00 +0000)]
Workaround some 'smarts' in Win2k.

Win2k kills off connections that have issued a negprot but havn't yet issued
a session setup when a second connection appears from the same host.
(This used to be commit d47e61eb468218cae631e78edbd5d02982c78ab0)

20 years agoRe-add bail on failure.
Andrew Bartlett [Thu, 3 Jan 2002 06:10:25 +0000 (06:10 +0000)]
Re-add bail on failure.
(This used to be commit da9444d98f212af8f1b1e1df191adf3c31d50f6d)

20 years agoFix talloc msg registration
Martin Pool [Thu, 3 Jan 2002 05:57:41 +0000 (05:57 +0000)]
Fix talloc msg registration
(This used to be commit 9a473ecf96fca35d146756c0c313b156aba8d9d9)

20 years agoPut a name on lp_talloc pool
Martin Pool [Thu, 3 Jan 2002 05:57:21 +0000 (05:57 +0000)]
Put a name on lp_talloc pool
(This used to be commit 472121749460a73f684bdbd02b828e89fad101af)

20 years agoMake talloctort call talloc_describe_all before exiting
Martin Pool [Thu, 3 Jan 2002 05:57:02 +0000 (05:57 +0000)]
Make talloctort call talloc_describe_all before exiting
(This used to be commit 4877501da92762d233e5e4f24d1cb2bdd1eab8ae)

20 years agoCope nicely with pools with no name.
Martin Pool [Thu, 3 Jan 2002 05:52:27 +0000 (05:52 +0000)]
Cope nicely with pools with no name.
(This used to be commit 86abefc17260387b6b68c71ad5587ef0212162c0)

20 years agofixed ERRMAPEXTRACT torture to work with win2k
Andrew Tridgell [Thu, 3 Jan 2002 05:48:49 +0000 (05:48 +0000)]
fixed ERRMAPEXTRACT torture to work with win2k
(This used to be commit 27143900e76033026ecd5a7b4525c0150f3a535d)

20 years agosmbd children should also register for POOL_USAGE
Martin Pool [Thu, 3 Jan 2002 05:41:13 +0000 (05:41 +0000)]
smbd children should also register for POOL_USAGE
(This used to be commit b46d874f4736493bdc4244ec6cdf95e77347e7d5)

20 years agoCleanup format.
Martin Pool [Thu, 3 Jan 2002 05:36:21 +0000 (05:36 +0000)]
Cleanup format.
(This used to be commit a9b9ae47e1a11492f036b308c408c6a239a690f6)

20 years agotalloc accounting now includes number of chunks and bytes allocated.
Martin Pool [Thu, 3 Jan 2002 05:34:33 +0000 (05:34 +0000)]
talloc accounting now includes number of chunks and bytes allocated.
(This used to be commit cd25d01e42e7874bc93f6ca336c5b2cde453bb52)

20 years agoSend back talloc allocation information when POOL_USAGE is received.
Martin Pool [Thu, 3 Jan 2002 05:26:57 +0000 (05:26 +0000)]
Send back talloc allocation information when POOL_USAGE is received.
(This used to be commit 7cb8e95f9332d4c278d2aac5416f963639609d5a)

20 years agoAdd talloc_asprintf_append, which grows an existing string buffer to
Martin Pool [Thu, 3 Jan 2002 05:25:30 +0000 (05:25 +0000)]
Add talloc_asprintf_append, which grows an existing string buffer to
contain new print-formatted information.  (Also
talloc_vasprintf_append.)  Idea borrowed from glib.
(This used to be commit 53723e874885936dd67483ebf46601fc73489d17)

20 years agosmbd now sends a reply to MSG_REQ_POOL_USAGE, though it's pretty
Martin Pool [Thu, 3 Jan 2002 04:22:55 +0000 (04:22 +0000)]
smbd now sends a reply to MSG_REQ_POOL_USAGE, though it's pretty
boring so far.
(This used to be commit 9b217dce7fe89d1e36a91d7d011c2a9fe185e0d3)

20 years agosmbd should register to receive MSG_REQ_POOL_USAGE. Response should
Martin Pool [Thu, 3 Jan 2002 03:53:41 +0000 (03:53 +0000)]
smbd should register to receive MSG_REQ_POOL_USAGE.  Response should
be information about memory usage, but this is not done yet.
(This used to be commit 830a126a442bdde28fc42e23e7260c344b6534b9)

20 years agoFixed crash bug in display_print_info_2()
Tim Potter [Thu, 3 Jan 2002 03:51:13 +0000 (03:51 +0000)]
Fixed crash bug in display_print_info_2()
(This used to be commit b70f870cd98e30d0ce74d322391cc79d65c5f838)

20 years agoIgnore dmalloc.log.
Martin Pool [Thu, 3 Jan 2002 03:47:09 +0000 (03:47 +0000)]
Ignore dmalloc.log.
(This used to be commit cfa89169e0bbc9cbd7448c96139ecaf459d0af81)

20 years agoIf we receive a message that is not handled then emit a gentle warning
Martin Pool [Thu, 3 Jan 2002 03:42:33 +0000 (03:42 +0000)]
If we receive a message that is not handled then emit a gentle warning
to the log.
(This used to be commit 53dd8b45397f5de7660594b9287341f8f4c91c43)

20 years agodebug output on receipt of message.
Martin Pool [Thu, 3 Jan 2002 03:35:02 +0000 (03:35 +0000)]
debug output on receipt of message.
(This used to be commit 6bd5b7ce8ec54faefcf129fcc98cc4440bb355d6)

20 years agoOops, rerun autoconf after last change.
Martin Pool [Thu, 3 Jan 2002 03:14:51 +0000 (03:14 +0000)]
Oops, rerun autoconf after last change.
(This used to be commit 73743c2ec9da239f5d1340b68e92bdeb00cee97d)

20 years agoWelcome to preprocessor hell. Had to put a #ifndef around SAFE_FREE to
Tim Potter [Thu, 3 Jan 2002 03:07:51 +0000 (03:07 +0000)]
Welcome to preprocessor hell.  Had to put a #ifndef around SAFE_FREE to
stop smb_macros.h and tdb.h from fighting with each other.

I tried to rearrange the #include file order but that breaks other stuff.
(This used to be commit aae8cc6e450a6a0b33045ed1e6d49f8eebeb48b2)

20 years agoAdd instructions on using dmalloc.
Martin Pool [Thu, 3 Jan 2002 03:04:35 +0000 (03:04 +0000)]
Add instructions on using dmalloc.
(This used to be commit ee6d33a8db2afc43c8784f2e43572ae8959126e5)

20 years agoFixed crash bug in display_print_info_1()
Tim Potter [Thu, 3 Jan 2002 02:48:23 +0000 (02:48 +0000)]
Fixed crash bug in display_print_info_1()
(This used to be commit d1564fbf1f4950c12516470d4566efeca3ad79e5)

20 years agoInitialise result on success in cli_spoolss_enum_printers() so we don't get
Tim Potter [Thu, 3 Jan 2002 02:47:50 +0000 (02:47 +0000)]
Initialise result on success in cli_spoolss_enum_printers() so we don't get
stuck in an infinite loop.
(This used to be commit fe1fb6589a0a4b4cff7a0ee0267f6e09e10e2a85)

20 years agoThe werror<->nt status code map has changed and has broken all the spoolss
Tim Potter [Thu, 3 Jan 2002 02:36:08 +0000 (02:36 +0000)]
The werror<->nt status code map has changed and has broken all the spoolss
commands in rpcclient.  Replacing ERROR_INSUFFICIENT_BUFFER with

I always thought the caller (i.e cmd_spoolss.c) should take care of the
whole requested/needed buffer size thingy though...
(This used to be commit 6c950db05a2772f11b20cc13c65a123ea8b878c2)

20 years agoRemoved unused #define
Tim Potter [Thu, 3 Jan 2002 02:28:51 +0000 (02:28 +0000)]
Removed unused #define
(This used to be commit ab1bd916cf59e12366d9005f6ce1cf6521ff02be)

20 years agodebug statement fixups.
Jeremy Allison [Wed, 2 Jan 2002 23:28:55 +0000 (23:28 +0000)]
debug statement fixups.
Merge SAFE_FREE fix in tdb from 2.2, and IRIX fix.
(This used to be commit eb6607466565bcd5b3800492d0bc1ae8a44da4f6)

20 years agoremoved stuff I wasn't using
Gerald Carter [Wed, 2 Jan 2002 23:11:24 +0000 (23:11 +0000)]
removed stuff I wasn't using
(This used to be commit 27ffce157a655e267f225126f586847e5a0b8614)

20 years agosync up ldap defaults with 2.2
Gerald Carter [Wed, 2 Jan 2002 22:44:15 +0000 (22:44 +0000)]
sync up ldap defaults with 2.2
(This used to be commit 59174310d419aa835031c7a318d85fe25ba28227)

20 years agoooops./ forgot one
Gerald Carter [Wed, 2 Jan 2002 22:22:22 +0000 (22:22 +0000)]
ooops./  forgot one
(This used to be commit 501f3f3a8fb5ea27155f8c2fe266f1f659d7d22d)

20 years agofixing compile error
Gerald Carter [Wed, 2 Jan 2002 22:02:11 +0000 (22:02 +0000)]
fixing compile error
(This used to be commit 999a2f5c847c6a4336df60807e2fb546a2a4894f)

20 years agoWe should be SHLD not LINK when creating shared libraries.
Jeremy Allison [Wed, 2 Jan 2002 21:54:38 +0000 (21:54 +0000)]
We should be SHLD not LINK when creating shared libraries.
Tidyup in passdb.c
(This used to be commit 676eea502a1bb2114a6e8055ecaf97ecab2e3a91)

20 years agoWe go to a lot of effort to avoid strcpy() in Samba, but its not much use if
Andrew Bartlett [Wed, 2 Jan 2002 09:02:28 +0000 (09:02 +0000)]
We go to a lot of effort to avoid strcpy() in Samba, but its not much use if
people start doing using strlen(src) in strncpy() :-)

This occured when the talloc based passdb was reverted in favor of a pstring
based one.  In the talloc version this was fine, becouse the buffer was
strlen(src) bytes long.  This no longer applies...

This doesn't seem to have broken anything, but I'm chasing up an oddity with NT
password changing from the last merge.

Test & MERGE for 2.2.3

Andrew Bartlett
(This used to be commit 673ece2841e8b60966a17ece3591f9f202807332)

20 years agoAdd prs_dump_before to dump everything from the start of the prs
Martin Pool [Wed, 2 Jan 2002 07:48:07 +0000 (07:48 +0000)]
Add prs_dump_before to dump everything from the start of the prs
buffer up to the current position, and use this to dump pipe buffers
just before parsing.
(This used to be commit 92a3ab274e6cf09a8ba39b91f8bbacba6de40b37)

20 years agoActually enforce the passdb API.
Andrew Bartlett [Wed, 2 Jan 2002 07:41:54 +0000 (07:41 +0000)]
Actually enforce the passdb API.

Thou shalt not reference SAM_ACCOUNT members directly - always use

This is achived by making the whole of SAM_ACCOUNT have a .private member,
where the real members live.  This caught a pile of examples, and these have
beeen fixed.

The pdb_get..() functions are 'const' (have been for some time) and this
required a few small changes to constify other functions.

I've also added some debugs to the pdb get and set, they can be removed if

I've rewritten the copy_id2x_to_sam_pass() functions to use the new passdb
interface, but I need the flags info to do it properly.

The pdb_free_sam() funciton now blanks out the LM and NT hashes, and as such
I have removed many extra 'samr_clear_sam_passwd(smbpass)' calls as a result.

Finally, any and all testing is always appriciated - but the basics seem to

Andrew Bartlett
(This used to be commit d3dd28f6c443187b8d820d5a39c7c5b3be2fa95c)

20 years agoMake user enumeration work for w2k and win9x.
Jeremy Allison [Wed, 2 Jan 2002 07:27:33 +0000 (07:27 +0000)]
Make user enumeration work for w2k and win9x.
This means different return sizes depending on client bugs. This sucks :-(.
(This used to be commit f6592628eb526c487069bb3fcd809aca930e668e)

20 years agoAnother touch of 'const'
Andrew Bartlett [Wed, 2 Jan 2002 06:55:21 +0000 (06:55 +0000)]
Another touch of 'const'
(This used to be commit 3d812aacff98eec62c748cb89109a2e58806d92d)

20 years agoDoc.
Martin Pool [Wed, 2 Jan 2002 06:29:56 +0000 (06:29 +0000)]
(This used to be commit b354163834e0f2da7d3caacfe8d2ac6e2a6949e8)

20 years agoAlso capture received data
Martin Pool [Wed, 2 Jan 2002 06:08:02 +0000 (06:08 +0000)]
Also capture received data
(This used to be commit 93fadcd1118b390605d2504bee63a1e8b6373ac5)

20 years agostruct cli_state remembers the pipe name that it's talking to, if any,
Martin Pool [Wed, 2 Jan 2002 05:39:49 +0000 (05:39 +0000)]
struct cli_state remembers the pipe name that it's talking to, if any,
so that we can print it in later debug messages.

Call prs_dump to dump out requests sent by the client at sufficiently
high debug levels.
(This used to be commit 9973b22b34dc2a88a20b821d4e69f39d2a6aa6a3)

20 years agostruct cli_state remembers the pipe name that it's talking to, if any,
Martin Pool [Wed, 2 Jan 2002 05:38:09 +0000 (05:38 +0000)]
struct cli_state remembers the pipe name that it's talking to, if any,
so that we can print it in later debug messages.
(This used to be commit 37ae84f782e1de6fcea92acb2189683cdf8e7e92)

20 years agoMinor update to make the output 'real C'. (The output is intended to be a C
Andrew Bartlett [Wed, 2 Jan 2002 03:54:40 +0000 (03:54 +0000)]
Minor update to make the output 'real C'.  (The output is intended to be a C
format table for inclusion back into Samba).

Andrew Bartlett
(This used to be commit 95abb2473bb4f93df163a0e8af79d5292e1389b3)

20 years agoRemoved reference to rpc_client/cli_netlogon.o from dependencies for
Tim Potter [Wed, 2 Jan 2002 00:52:30 +0000 (00:52 +0000)]
Removed reference to rpc_client/cli_netlogon.o from dependencies for
samsync.  The libsmb version should do fine.
(This used to be commit 001fe3481f26e27964b3d60c067524b45f085304)

20 years agothe pdbedit tool manpage
Simo Sorce [Wed, 2 Jan 2002 00:40:47 +0000 (00:40 +0000)]
the pdbedit tool manpage
(This used to be commit 4aecb650e1ece234fb7359270deb74fe1c1a4a16)

20 years agotry to handle broken const in headers on cray unicos
Andrew Tridgell [Tue, 1 Jan 2002 06:55:33 +0000 (06:55 +0000)]
try to handle broken const in headers on cray unicos
(This used to be commit 8143052e6917d4ae774192ed463ea7359cf0a5fb)

20 years agoThis brings the NT->DOS error mapping into better line with what NT does.
Andrew Bartlett [Tue, 1 Jan 2002 06:16:43 +0000 (06:16 +0000)]
This brings the NT->DOS error mapping into better line with what NT does.

I'll post the changes to the actual map to the list for comment, but this fixes
the 'unknown' case.

Andrew Bartlett
(This used to be commit 024843a2cedb0b9f06a3351c5838caea372b6c5c)

20 years agoAdd a function to convert 'NT_STATUS...' strings back into their actual error
Andrew Bartlett [Tue, 1 Jan 2002 05:52:02 +0000 (05:52 +0000)]
Add a function to convert 'NT_STATUS...' strings back into their actual error

Andrew Bartlett
(This used to be commit f0089b089b319009576bb39a076397bb44aff628)

20 years agoAllow usernames in the form of 'NT_STATUS_....' to map to that as the error
Andrew Bartlett [Tue, 1 Jan 2002 05:51:03 +0000 (05:51 +0000)]
Allow usernames in the form of 'NT_STATUS_....' to map to that as the error
when using the 'name_to_ntstatus' auth module.

This could be useful in testing.

Andrew Bartlett
(This used to be commit 5cdc67d0bda8ef41305cae9c5be70d11593ffdd8)

20 years agoNow that winbind doesn't rely on this, we may as well remove it...
Andrew Bartlett [Tue, 1 Jan 2002 05:49:27 +0000 (05:49 +0000)]
Now that winbind doesn't rely on this, we may as well remove it...

Andrew Bartlett
(This used to be commit 6673fdda3cb6b90189d8f82274fdffa89f68101b)

20 years agoFurther rpc_client removal, this time from winbindd.
Andrew Bartlett [Tue, 1 Jan 2002 04:50:45 +0000 (04:50 +0000)]
Further rpc_client removal, this time from winbindd.

Also removed the dependency on auth_util.o, which makes things nicer.

makefile variable - becouse Samba dependencies are starting to be sane again!

Andrew Bartlett
(This used to be commit 4609edcac3b70c11025f0c5aa0ddbeed93369c84)

20 years agorenamed ans1.h to asn_1.h to prevent conflict caused by krb5 headers
Andrew Tridgell [Tue, 1 Jan 2002 04:05:10 +0000 (04:05 +0000)]
renamed ans1.h to asn_1.h to prevent conflict caused by krb5 headers
on some platforms using "" instead of <> in include statements
(This used to be commit d0ba307032340a22d77cb1d8fc78b4234e1a963c)

20 years agoA farily large commit:
Andrew Bartlett [Tue, 1 Jan 2002 03:10:32 +0000 (03:10 +0000)]
A farily large commit:

 - Move rpc_client/cli_trust.c to smbd/change_trust_pw.c
  - It hasn't been used by anything else since smbpasswd lost its -j

 - Add a TALLOC_CTX to the auth subsytem.  These are only valid for the length
   of the calls to the individual modules, if you want a longer context hide it
   in your private data.

   Similarly, all returns (like the server_info) should still be malloced.

 - Move the 'ntdomain' module (security=domain in oldspeak) over to use the new
   libsmb domain logon code.  Also rework much of the code to use some better
   helper functions for the connection - getting us much better error returns
   (the new code is NTSTATUS).

   The only remaining thing to do is to figure out if tpot's 0xdead 0xbeef for
   the LUID feilds is sufficient, or if we should do random LUIDs as per the old

   Similarly, I'll move winbind over to this when I get a chance.

This leaves the SPOOLSS code and some cli_pipe code as the only stuff still in
rpc_client, at least as far as smbd is concerned.

While I've given this a basic rundown, any testing is as always appriciated.

Andrew Bartlett
(This used to be commit d870edce76ecca259230fbdbdacd0c86793b4837)

20 years agoAdd a specialised version of tpot's libsmb samlogon code for use with
Andrew Bartlett [Tue, 1 Jan 2002 02:34:29 +0000 (02:34 +0000)]
Add a specialised version of tpot's libsmb samlogon code for use with
presupplied challange-response pairs, and only using the 'network' version.

This will be used to move the auth subsystem over to a libsmb (rather than
rpc_client) base.

Andrew Bartlett
(This used to be commit fe9d77791583737320f8c7560861168df7388c2f)

20 years agoFix up C99 comment.
Andrew Bartlett [Tue, 1 Jan 2002 02:31:32 +0000 (02:31 +0000)]
Fix up C99 comment.
// -> /* */
(This used to be commit a308abbab717df56b982adf1717da96603d2045f)

20 years agoNamed constants are always much better than magic numbers...
Andrew Bartlett [Tue, 1 Jan 2002 00:18:47 +0000 (00:18 +0000)]
Named constants are always much better than magic numbers...
(I defined the constants when I put in 'net rpc shutdown')

Andrew Bartlett
(This used to be commit 4d90cc1d991f3894b9f39b2a75078148834701bb)

20 years agolast_enum not used.
Jeremy Allison [Mon, 31 Dec 2001 23:24:48 +0000 (23:24 +0000)]
last_enum not used.
(This used to be commit efbec935fe727d5d5bd852c7bae9baf92df18686)

20 years agoFixed enumeration of a large (<1500) users from a Samba PDC to a W2k
Jeremy Allison [Mon, 31 Dec 2001 22:37:51 +0000 (22:37 +0000)]
Fixed enumeration of a large (<1500) users from a Samba PDC to a W2k
member server. Firstly, use the same max enumeration size (0x400) as W2K
uses, otherwise W2K won't ask for any more. Secondly, if a enumeration
request with a non-zero offset comes in on a handle that hasn't started
an enumeration, don't bitch about it (return NT_STATUS_UNSUCCESSFUL),
just load the db on that handle and return at that offset.
(This used to be commit 0b7da4a50ea02e28ab23e71de1e5f8b9194a9af3)

20 years agoadded a simple test to see whether building shared libraries actually
Andrew Tridgell [Mon, 31 Dec 2001 22:10:24 +0000 (22:10 +0000)]
added a simple test to see whether building shared libraries actually
(This used to be commit 3aeefbca4f272f57e83e753177ee6e8157b2dbd5)