From: Volker Lendecke <vl@samba.org>
Date: Fri, 31 Oct 2008 21:02:45 +0000 (+0100)
Subject: Remove a pointles call to smb_bufrem
X-Git-Tag: samba-4.0.0alpha6~589^2
X-Git-Url: http://git.samba.org/samba.git/?p=ira%2Fwip.git;a=commitdiff_plain;h=ff274e57eacb9ac4c81adfcfea4f7b4b668a7d94;hp=-c;ds=sidebyside

Remove a pointles call to smb_bufrem

This call expanded to

(smb_buflen(req->inbuf)
  - PTR_DIFF(smb_buf(req->inbuf) - smb_buf(req->inbuf)))

which seems pretty pointless :-)
---

ff274e57eacb9ac4c81adfcfea4f7b4b668a7d94
diff --git a/source3/smbd/sesssetup.c b/source3/smbd/sesssetup.c
index a482b3398a2..b2583861217 100644
--- a/source3/smbd/sesssetup.c
+++ b/source3/smbd/sesssetup.c
@@ -1447,8 +1447,7 @@ void reply_sesssetup_and_X(struct smb_request *req)
 		remove_from_common_flags2(FLAGS2_32_BIT_ERROR_CODES);
 
 		if ((passlen1 > MAX_PASS_LEN)
-		    || (passlen1 > smb_bufrem(req->inbuf,
-					      smb_buf(req->inbuf)))) {
+		    || (passlen1 > smb_buflen(req->inbuf))) {
 			reply_nterror(req, nt_status_squash(
 					      NT_STATUS_INVALID_PARAMETER));
 			END_PROFILE(SMBsesssetupX);