From: Andrew Bartlett <abartlet@samba.org>
Date: Fri, 25 Sep 2009 23:40:30 +0000 (-0700)
Subject: s4:dsdb Return correct error on invalid attribute
X-Git-Tag: talloc-2.0.1~170
X-Git-Url: http://git.samba.org/samba.git/?p=ira%2Fwip.git;a=commitdiff_plain;h=e6d82267454a4678484b62cd5b28527f845af84f;hp=ab9c2320661901c05b217cc86a46e8b15e3f8425

s4:dsdb Return correct error on invalid attribute

This error per the Microsoft testsuite
---

diff --git a/source4/dsdb/samdb/ldb_modules/objectclass.c b/source4/dsdb/samdb/ldb_modules/objectclass.c
index cc88d6b96d0..6d22141a3be 100644
--- a/source4/dsdb/samdb/ldb_modules/objectclass.c
+++ b/source4/dsdb/samdb/ldb_modules/objectclass.c
@@ -361,7 +361,8 @@ static int fix_attributes(struct ldb_context *ldb, const struct dsdb_schema *sch
 		if (!attribute) {
 			if (strcasecmp(msg->elements[i].name, "clearTextPassword") != 0) {
 				ldb_asprintf_errstring(ldb, "attribute %s is not a valid attribute in schema", msg->elements[i].name);
-				return LDB_ERR_UNDEFINED_ATTRIBUTE_TYPE;
+				/* Apparently Windows sends exactly this behaviour */
+				return LDB_ERR_NO_SUCH_ATTRIBUTE;
 			}
 		} else {
 			msg->elements[i].name = attribute->lDAPDisplayName;