From: Jeremy Allison <jra@samba.org>
Date: Sat, 20 Jun 2009 00:26:53 +0000 (-0700)
Subject: Fix coverity #729. Resource leak in error path.
X-Git-Tag: tevent-0.9.8~974
X-Git-Url: http://git.samba.org/samba.git/?p=ira%2Fwip.git;a=commitdiff_plain;h=661f0ba73b28d6165e0ba958413adf9cb97662d5

Fix coverity #729. Resource leak in error path.
Jeremy.
---

diff --git a/source3/client/client.c b/source3/client/client.c
index 36a70d012fe..ed45f4e2caa 100644
--- a/source3/client/client.c
+++ b/source3/client/client.c
@@ -1666,6 +1666,7 @@ static int do_put(const char *rname, const char *lname, bool reput)
 		if (f && reput) {
 			if (x_tseek(f, start, SEEK_SET) == -1) {
 				d_printf("Error seeking local file\n");
+				x_fclose(f);
 				return 1;
 			}
 		}
@@ -1692,7 +1693,9 @@ static int do_put(const char *rname, const char *lname, bool reput)
 
 	if (!NT_STATUS_IS_OK(cli_close(targetcli, fnum))) {
 		d_printf("%s closing remote file %s\n",cli_errstr(cli),rname);
-		x_fclose(f);
+		if (f != x_stdin) {
+			x_fclose(f);
+		}
 		return 1;
 	}