From: Slava Semushin <php-coder@altlinux.ru>
Date: Sat, 18 Jul 2009 09:28:53 +0000 (+0700)
Subject: lib/util/util_file.c(file_save): fixed file descriptor leak when read(2) fails.
X-Git-Tag: tevent-0.9.8~710^2~41^2~3
X-Git-Url: http://git.samba.org/samba.git/?p=ira%2Fwip.git;a=commitdiff_plain;h=5f8df164716a43bd9e6c22dfd1f066bf96ccf273

lib/util/util_file.c(file_save): fixed file descriptor leak when read(2) fails.

Found by cppcheck:
[./lib/util/util_file.c:383]: (error) Resource leak: fd
---

diff --git a/lib/util/util_file.c b/lib/util/util_file.c
index 0275e78c54f..7466004e5ce 100644
--- a/lib/util/util_file.c
+++ b/lib/util/util_file.c
@@ -380,6 +380,7 @@ _PUBLIC_ bool file_save(const char *fname, const void *packet, size_t length)
 		return false;
 	}
 	if (write(fd, packet, length) != (size_t)length) {
+		close(fd);
 		return false;
 	}
 	close(fd);