From: Andrew Bartlett <abartlet@samba.org>
Date: Fri, 14 Aug 2009 02:48:10 +0000 (+1000)
Subject: s4:ldap_server Don't talloc_steal (with references) in ldap_backend
X-Git-Tag: tevent-0.9.8~404
X-Git-Url: http://git.samba.org/samba.git/?p=ira%2Fwip.git;a=commitdiff_plain;h=5c3cf58a842a8ddd5dca785bf5464e0788003400

s4:ldap_server Don't talloc_steal (with references) in ldap_backend

There may or may not be a need to take a reference to the 'name' in
the ldb_map code, but given we seal the whole msg just above here, it
makes no senst to steal the name, but not the values.

Andrew Bartlett
---

diff --git a/source4/ldap_server/ldap_backend.c b/source4/ldap_server/ldap_backend.c
index 67cc893ff25..d479ff83b48 100644
--- a/source4/ldap_server/ldap_backend.c
+++ b/source4/ldap_server/ldap_backend.c
@@ -419,7 +419,7 @@ static NTSTATUS ldapsrv_SearchRequest(struct ldapsrv_call *call)
 			ent->attributes = talloc_array(ent_r, struct ldb_message_element, ent->num_attributes);
 			NT_STATUS_HAVE_NO_MEMORY(ent->attributes);
 			for (j=0; j < ent->num_attributes; j++) {
-				ent->attributes[j].name = talloc_steal(ent->attributes, res->msgs[i]->elements[j].name);
+				ent->attributes[j].name = res->msgs[i]->elements[j].name;
 				ent->attributes[j].num_values = 0;
 				ent->attributes[j].values = NULL;
 				if (req->attributesonly && (res->msgs[i]->elements[j].num_values == 0)) {