From: Günther Deschner <gd@samba.org>
Date: Fri, 20 Mar 2009 10:21:36 +0000 (+0100)
Subject: s3-netapi: Fix Coverity #774 (REVERSE_INULL).
X-Git-Tag: tdb-1.1.5~1078^2~2
X-Git-Url: http://git.samba.org/samba.git/?p=ira%2Fwip.git;a=commitdiff_plain;h=3a6133d70202ef80ead4203740c000be5e93b288;ds=sidebyside

s3-netapi: Fix Coverity #774 (REVERSE_INULL).

Guenther
---

diff --git a/source3/lib/netapi/user.c b/source3/lib/netapi/user.c
index b1bd27af2a5..e760a8b1de5 100644
--- a/source3/lib/netapi/user.c
+++ b/source3/lib/netapi/user.c
@@ -2806,6 +2806,7 @@ WERROR NetUserGetGroups_r(struct libnetapi_ctx *ctx,
 
 	*r->out.buffer = NULL;
 	*r->out.entries_read = 0;
+	*r->out.total_entries = 0;
 
 	switch (r->in.level) {
 		case 0:
@@ -2899,12 +2900,8 @@ WERROR NetUserGetGroups_r(struct libnetapi_ctx *ctx,
 		}
 	}
 
-	if (r->out.entries_read) {
-		*r->out.entries_read = entries_read;
-	}
-	if (r->out.total_entries) {
-		*r->out.total_entries = entries_read;
-	}
+	*r->out.entries_read = entries_read;
+	*r->out.total_entries = entries_read;
 
  done:
 	if (ctx->disable_policy_handle_cache) {