From: Stefan Metzmacher <metze@samba.org>
Date: Tue, 9 Feb 2010 17:54:41 +0000 (+0100)
Subject: s3:smbd: Fix really ugly bool vs. int bug!!!
X-Git-Tag: samba-3.6.0pre1~5492
X-Git-Url: http://git.samba.org/samba.git/?p=ira%2Fwip.git;a=commitdiff_plain;h=1686a5e7e7eb1b411b003cbbde5c0d28741c6d02

s3:smbd: Fix really ugly bool vs. int bug!!!

A comparison function for qsort needs to return an 'int'!
Otherwise you'll get random results depending on the compiler
and the architecture...

metze
---

diff --git a/source3/smbd/lanman.c b/source3/smbd/lanman.c
index 721883f775b..f673970ceca 100644
--- a/source3/smbd/lanman.c
+++ b/source3/smbd/lanman.c
@@ -1351,7 +1351,7 @@ static int fill_srv_info(struct srv_info_struct *service,
 }
 
 
-static bool srv_comp(struct srv_info_struct *s1,struct srv_info_struct *s2)
+static int srv_comp(struct srv_info_struct *s1,struct srv_info_struct *s2)
 {
 #undef strcasecmp
 	return strcasecmp(s1->name,s2->name);
@@ -1515,7 +1515,7 @@ static bool api_RNetServerEnum2(connection_struct *conn, uint16 vuid,
 	return True;
 }
 
-static bool srv_name_match(const char *n1, const char *n2)
+static int srv_name_match(const char *n1, const char *n2)
 {
 	/*
 	 * [MS-RAP] footnote <88> for Section 3.2.5.15 says: