From: Andrew Tridgell <tridge@samba.org>
Date: Sat, 9 Jan 2010 04:12:18 +0000 (+1100)
Subject: s4-drs: need to set the getncchanges extended_ret on success too
X-Git-Tag: samba-4.0.0alpha11~44
X-Git-Url: http://git.samba.org/samba.git/?p=ira%2Fwip.git;a=commitdiff_plain;h=1158c138611d388fcae066a009cd6033a60a5944

s4-drs: need to set the getncchanges extended_ret on success too
---

diff --git a/source4/rpc_server/drsuapi/getncchanges.c b/source4/rpc_server/drsuapi/getncchanges.c
index f9e2f98b2e7..ad35de88330 100644
--- a/source4/rpc_server/drsuapi/getncchanges.c
+++ b/source4/rpc_server/drsuapi/getncchanges.c
@@ -650,6 +650,7 @@ static WERROR getncchanges_rid_alloc(struct drsuapi_bind_state *b_state,
 	if (ret != LDB_SUCCESS) {
 		DEBUG(0,(__location__ ": Failed to find fSMORoleOwner in RID Manager object - %s\n",
 			 ldb_errstring(ldb)));
+		ctr6->extended_ret = DRSUAPI_EXOP_ERR_FSMO_NOT_OWNER;
 		return WERR_DS_DRA_INTERNAL_ERROR;
 	}
 
@@ -695,6 +696,8 @@ static WERROR getncchanges_rid_alloc(struct drsuapi_bind_state *b_state,
 	DEBUG(2,("Allocated RID pool for server %s\n",
 		 GUID_string(mem_ctx, &req8->destination_dsa_guid)));
 
+	ctr6->extended_ret = DRSUAPI_EXOP_ERR_SUCCESS;
+
 	return WERR_OK;
 }