s3-netlogon: kill an fstring in rpc_server.
authorGünther Deschner <gd@samba.org>
Mon, 27 Oct 2008 17:23:50 +0000 (18:23 +0100)
committerGünther Deschner <gd@samba.org>
Mon, 27 Oct 2008 23:13:50 +0000 (00:13 +0100)
Guenther

source3/rpc_server/srv_netlog_nt.c

index 2dc6cd639383fee09eb0003a592743e8e870f39d..75fc99401edfce986f310f07743d4a6b6c160279 100644 (file)
@@ -797,22 +797,19 @@ NTSTATUS _netr_LogonSamLogon(pipes_struct *p,
        }
 
        if (process_creds) {
-               fstring remote_machine;
 
                /* Get the remote machine name for the creds store. */
                /* Note this is the remote machine this request is coming from (member server),
                   not neccessarily the workstation name the user is logging onto.
                */
 
-               fstrcpy(remote_machine, r->in.computer_name);
-
                if (!p->dc) {
                        /* Restore the saved state of the netlogon creds. */
                        bool ret;
 
                        become_root();
                        ret = secrets_restore_schannel_session_info(
-                               p, remote_machine, &p->dc);
+                               p, r->in.computer_name, &p->dc);
                        unbecome_root();
                        if (!ret) {
                                return NT_STATUS_INVALID_HANDLE;
@@ -827,13 +824,13 @@ NTSTATUS _netr_LogonSamLogon(pipes_struct *p,
                if (!netlogon_creds_server_step(p->dc, r->in.credential,  r->out.return_authenticator)) {
                        DEBUG(2,("_netr_LogonSamLogon: creds_server_step failed. Rejecting auth "
                                "request from client %s machine account %s\n",
-                               remote_machine, p->dc->mach_acct ));
+                               r->in.computer_name, p->dc->mach_acct ));
                        return NT_STATUS_INVALID_PARAMETER;
                }
 
                /* We must store the creds state after an update. */
                become_root();
-               secrets_store_schannel_session_info(p, remote_machine, p->dc);
+               secrets_store_schannel_session_info(p, r->in.computer_name, p->dc);
                unbecome_root();
        }