git.samba.org
/
ira
/
wip.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
63ff9e0
)
Attempt to fix Coverity ID 595
author
Volker Lendecke
<vl@sernet.de>
Sat, 16 Aug 2008 09:17:09 +0000
(11:17 +0200)
committer
Jeremy Allison
<jra@samba.org>
Sat, 16 Aug 2008 17:34:42 +0000
(10:34 -0700)
is_ipaddress already dereferences "name", so the NULL check is pointless after
calling it.
(This used to be commit
31ca7b2dbbbfbb3a55670b58c08ebda68888af7e
)
source3/libcli/nbt/nbtname.c
patch
|
blob
|
history
diff --git
a/source3/libcli/nbt/nbtname.c
b/source3/libcli/nbt/nbtname.c
index 2025ef70e7374d40e371c79dadcfcbf10c1754e4..fbb9550655ae1bde8f7c7850d12935c6c6eedb0e 100644
(file)
--- a/
source3/libcli/nbt/nbtname.c
+++ b/
source3/libcli/nbt/nbtname.c
@@
-420,7
+420,7
@@
_PUBLIC_ void nbt_choose_called_name(TALLOC_CTX *mem_ctx,
n->scope = NULL;
n->type = type;
- if (
is_ipaddress(name) || name == NULL
) {
+ if (
(name == NULL) || is_ipaddress(name)
) {
n->name = "*SMBSERVER";
return;
}