Attempt to fix Coverity ID 595

is_ipaddress already dereferences "name", so the NULL check is pointless after
calling it.
(This used to be commit 31ca7b2dbbbfbb3a55670b58c08ebda68888af7e)

diff --git a/source3/libcli/nbt/nbtname.c b/source3/libcli/nbt/nbtname.c
index 2025ef70e7374d40e371c79dadcfcbf10c1754e4..fbb9550655ae1bde8f7c7850d12935c6c6eedb0e 100644 (file)
--- a/source3/libcli/nbt/nbtname.c
+++ b/source3/libcli/nbt/nbtname.c
@@ -420,7 +420,7 @@ _PUBLIC_ void nbt_choose_called_name(TALLOC_CTX *mem_ctx,
        n->scope = NULL;
        n->type = type;
 
-       if (is_ipaddress(name) || name == NULL) {
+       if ((name == NULL) || is_ipaddress(name)) {
                n->name = "*SMBSERVER";
                return;
        }