smbcontrol in non-interactive mode was returning True for success --

need to invert this to give the shell 0.
(This used to be commit ecc624067c54314834aacbf21d0f2ee54fce37e9)

diff --git a/source3/utils/smbcontrol.c b/source3/utils/smbcontrol.c
index 2d5b20e7eeaa9fb18ba41aa6087588c028302745..98e998a4f768e7c9048ed87191a3710921d1d675 100644 (file)
--- a/source3/utils/smbcontrol.c
+++ b/source3/utils/smbcontrol.c
@@ -451,7 +451,10 @@ static BOOL do_command(char *dest, char *msg_name, int iparams, char **params)
 
        if (!interactive) {
                if (argc < 2) usage(True);
-               return (do_command(argv[0],argv[1], argc-2, argc > 2 ? &argv[2] : 0));
+               /* Need to invert sense of return code -- samba
+                * routines mostly return True==1 for success, but
+                * shell needs 0. */ 
+               return ! do_command(argv[0],argv[1], argc-2, argc > 2 ? &argv[2] : 0);
        }
 
        while (True) {