r22226: move discard_const macros to librelace

metze

diff --git a/source/lib/ldb/include/includes.h b/source/lib/ldb/include/includes.h
index a04f7a0e97f68775f15a15fb80d9767b59897429..85f99280da05be0f390638257b3e0796f8dcea4b 100644 (file)
--- a/source/lib/ldb/include/includes.h
+++ b/source/lib/ldb/include/includes.h
@@ -16,11 +16,6 @@
 #define dyn_MODULESDIR dyn_LIBDIR
 #endif
 
-
-
-#define discard_const(ptr) ((void *)((intptr_t)(ptr)))
-#define discard_const_p(type, ptr) ((type *)discard_const(ptr))
-
 #include "replace.h"
 #include "system/filesys.h"
 #include "system/network.h"

diff --git a/source/lib/replace/replace.h b/source/lib/replace/replace.h
index 7d6dcec7f1271cc906765e56f767b41aecc9a333..959d44b33e75a778c2b35b3254e3b0380151419b 100644 (file)
--- a/source/lib/replace/replace.h
+++ b/source/lib/replace/replace.h
@@ -79,6 +79,29 @@
 #include <stddef.h>
 #endif
 
+/**
+  this is a warning hack. The idea is to use this everywhere that we
+  get the "discarding const" warning from gcc. That doesn't actually
+  fix the problem of course, but it means that when we do get to
+  cleaning them up we can do it by searching the code for
+  discard_const.
+
+  It also means that other error types aren't as swamped by the noise
+  of hundreds of const warnings, so we are more likely to notice when
+  we get new errors.
+
+  Please only add more uses of this macro when you find it
+  _really_ hard to fix const warnings. Our aim is to eventually use
+  this function in only a very few places.
+
+  Also, please call this via the discard_const_p() macro interface, as that
+  makes the return type safe.
+*/
+#define discard_const(ptr) ((void *)((intptr_t)(ptr)))
+
+/** Type-safe version of discard_const */
+#define discard_const_p(type, ptr) ((type *)discard_const(ptr))
+
 #ifndef HAVE_STRERROR
 extern char *sys_errlist[];
 #define strerror(i) sys_errlist[i]

diff --git a/source/lib/replace/strptime.c b/source/lib/replace/strptime.c
index 8fb919472e10a27bd26068ef5d05e2c02cf4195d..d415b7826e5957e5465b31562ee3d54f5cac8d8f 100644 (file)
--- a/source/lib/replace/strptime.c
+++ b/source/lib/replace/strptime.c
@@ -974,7 +974,7 @@ strptime_internal (rp, fmt, tm, decided, era_cnt)
   if (want_xday && !have_yday)
     day_of_the_year (tm);
 
-  return (char *) rp;
+  return discard_const_p(char, rp);
 }
 
 

diff --git a/source/lib/util/util.h b/source/lib/util/util.h
index c7acc2ea33487b2d1881162968349a7dfd4fede1..dd6c1499bdf7e1bf3e2198e3b2d8a51223605329 100644 (file)
--- a/source/lib/util/util.h
+++ b/source/lib/util/util.h
@@ -107,27 +107,4 @@ extern const char *panic_action;
 #define strlen(x) valgrind_strlen(x)
 #endif
 
-/**
-  this is a warning hack. The idea is to use this everywhere that we
-  get the "discarding const" warning from gcc. That doesn't actually
-  fix the problem of course, but it means that when we do get to
-  cleaning them up we can do it by searching the code for
-  discard_const.
-
-  It also means that other error types aren't as swamped by the noise
-  of hundreds of const warnings, so we are more likely to notice when
-  we get new errors.
-
-  Please only add more uses of this macro when you find it
-  _really_ hard to fix const warnings. Our aim is to eventually use
-  this function in only a very few places.
-
-  Also, please call this via the discard_const_p() macro interface, as that
-  makes the return type safe.
-*/
-#define discard_const(ptr) ((void *)((intptr_t)(ptr)))
-
-/** Type-safe version of discard_const */
-#define discard_const_p(type, ptr) ((type *)discard_const(ptr))
-
 #endif /* _SAMBA_UTIL_H_ */