Fix a silly memory (getpnam_alloc()) leak spotted by Elrond, and move

the DATA_BLOB code into its own file.

It would be nice to go over some of the other util.c functions, and check
that we still use them all, and that we use them in more than one place.

Andrew Bartlett
(This used to be commit d0ea70fce55df9a5b5878f50fce7bc115ffb37c2)

diff --git a/source3/Makefile.in b/source3/Makefile.in
index 2cc41b9d56663415305011b870dc1719a3afdfa6..fb16344f43a20b6d763c452046ca8b83c6232662 100644 (file)
--- a/source3/Makefile.in
+++ b/source3/Makefile.in
@@ -126,7 +126,7 @@ LIB_OBJ = lib/charcnv.o lib/debug.o lib/fault.o \
          lib/bitmap.o lib/crc32.o lib/snprintf.o lib/dprintf.o \
          lib/xfile.o lib/wins_srv.o \
          lib/util_str.o lib/util_sid.o \
-         lib/util_unistr.o lib/util_file.o \
+         lib/util_unistr.o lib/util_file.o lib/data_blob.o \
          lib/util.o lib/util_sock.o lib/util_sec.o \
          lib/talloc.o lib/hash.o lib/substitute.o lib/fsusage.o \
          lib/ms_fnmatch.o lib/select.o lib/error.o lib/messages.o \

diff --git a/source3/lib/data_blob.c b/source3/lib/data_blob.c
new file mode 100644 (file)
index 0000000..6b9f5cb
--- /dev/null
+++ b/source3/lib/data_blob.c
@@ -0,0 +1,109 @@
+/* 
+   Unix SMB/CIFS implementation.
+   Easy management of byte-length data
+   Copyright (C) Andrew Tridgell 2001
+   Copyright (C) Andrew Bartlett 2001
+   
+   This program is free software; you can redistribute it and/or modify
+   it under the terms of the GNU General Public License as published by
+   the Free Software Foundation; either version 2 of the License, or
+   (at your option) any later version.
+   
+   This program is distributed in the hope that it will be useful,
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+   GNU General Public License for more details.
+   
+   You should have received a copy of the GNU General Public License
+   along with this program; if not, write to the Free Software
+   Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
+*/
+
+#include "includes.h"
+
+/*******************************************************************
+ free() a data blob
+*******************************************************************/
+static void free_data_blob(DATA_BLOB *d)
+{
+       if ((d) && (d->free)) {
+               SAFE_FREE(d->data);
+       }
+}
+
+/*******************************************************************
+ construct a data blob, must be freed with data_blob_free()
+ you can pass NULL for p and get a blank data blob
+*******************************************************************/
+DATA_BLOB data_blob(const void *p, size_t length)
+{
+       DATA_BLOB ret;
+
+       if (!length) {
+               ZERO_STRUCT(ret);
+               return ret;
+       }
+
+       if (p) {
+               ret.data = smb_xmemdup(p, length);
+       } else {
+               ret.data = smb_xmalloc(length);
+       }
+       ret.length = length;
+       ret.free = free_data_blob;
+       return ret;
+}
+
+/*******************************************************************
+ construct a data blob, using supplied TALLOC_CTX
+*******************************************************************/
+DATA_BLOB data_blob_talloc(TALLOC_CTX *mem_ctx, const void *p, size_t length)
+{
+       DATA_BLOB ret;
+
+       if (!p || !length) {
+               ZERO_STRUCT(ret);
+               return ret;
+       }
+
+       ret.data = talloc_memdup(mem_ctx, p, length);
+       if (ret.data == NULL)
+               smb_panic("data_blob_talloc: talloc_memdup failed.\n");
+
+       ret.length = length;
+       ret.free = NULL;
+       return ret;
+}
+
+/*******************************************************************
+free a data blob
+*******************************************************************/
+void data_blob_free(DATA_BLOB *d)
+{
+       if (d) {
+               if (d->free) {
+                       (d->free)(d);
+               }
+               ZERO_STRUCTP(d);
+       }
+}
+
+/*******************************************************************
+clear a DATA_BLOB's contents
+*******************************************************************/
+void data_blob_clear(DATA_BLOB *d)
+{
+       if (d->data) {
+               memset(d->data, 0, d->length);
+       }
+}
+
+/*******************************************************************
+free a data blob and clear its contents
+*******************************************************************/
+void data_blob_clear_free(DATA_BLOB *d)
+{
+       data_blob_clear(d);
+       data_blob_free(d);
+}
+

diff --git a/source3/lib/util.c b/source3/lib/util.c
index d9be67599fc75c6d1818eaf1bdc1016d6550e55d..e143364db5402a36d7ba28b07053ac336efc7307 100644 (file)
--- a/source3/lib/util.c
+++ b/source3/lib/util.c
@@ -1082,7 +1082,7 @@ char *gidtoname(gid_t gid)
 }
 
 /*******************************************************************
- Convert a user name into a uid. If winbindd is present uses this.
+ Convert a user name into a uid. 
 ********************************************************************/
 
 uid_t nametouid(char *name)
@@ -1091,21 +1091,22 @@ uid_t nametouid(char *name)
        char *p;
        uid_t u;
 
-       u = (uid_t)strtol(name, &p, 0);
-       if ((p != name) && (*p == '\0'))
-               return u;
-
        pass = getpwnam_alloc(name);
        if (pass) {
-               return(pass->pw_uid);
+               u = pass->pw_uid;
                passwd_free(&pass);
+               return u;
        }
+
+       u = (uid_t)strtol(name, &p, 0);
+       if ((p != name) && (*p == '\0'))
+               return u;
+
        return (uid_t)-1;
 }
 
 /*******************************************************************
- Convert a name to a gid_t if possible. Return -1 if not a group. If winbindd
- is present does a shortcut lookup...
+ Convert a name to a gid_t if possible. Return -1 if not a group. 
 ********************************************************************/
 
 gid_t nametogid(const char *name)
@@ -2122,92 +2123,6 @@ BOOL unix_wild_match(char *pattern, char *string)
        return unix_do_match(p2, s2) == 0;      
 }
 
-/*******************************************************************
- free() a data blob
-*******************************************************************/
-static void free_data_blob(DATA_BLOB *d)
-{
-       if ((d) && (d->free)) {
-               SAFE_FREE(d->data);
-       }
-}
-
-/*******************************************************************
- construct a data blob, must be freed with data_blob_free()
- you can pass NULL for p and get a blank data blob
-*******************************************************************/
-DATA_BLOB data_blob(const void *p, size_t length)
-{
-       DATA_BLOB ret;
-
-       if (!length) {
-               ZERO_STRUCT(ret);
-               return ret;
-       }
-
-       if (p) {
-               ret.data = smb_xmemdup(p, length);
-       } else {
-               ret.data = smb_xmalloc(length);
-       }
-       ret.length = length;
-       ret.free = free_data_blob;
-       return ret;
-}
-
-/*******************************************************************
- construct a data blob, using supplied TALLOC_CTX
-*******************************************************************/
-DATA_BLOB data_blob_talloc(TALLOC_CTX *mem_ctx, const void *p, size_t length)
-{
-       DATA_BLOB ret;
-
-       if (!p || !length) {
-               ZERO_STRUCT(ret);
-               return ret;
-       }
-
-       ret.data = talloc_memdup(mem_ctx, p, length);
-       if (ret.data == NULL)
-               smb_panic("data_blob_talloc: talloc_memdup failed.\n");
-
-       ret.length = length;
-       ret.free = NULL;
-       return ret;
-}
-
-/*******************************************************************
-free a data blob
-*******************************************************************/
-void data_blob_free(DATA_BLOB *d)
-{
-       if (d) {
-               if (d->free) {
-                       (d->free)(d);
-               }
-               ZERO_STRUCTP(d);
-       }
-}
-
-/*******************************************************************
-clear a DATA_BLOB's contents
-*******************************************************************/
-void data_blob_clear(DATA_BLOB *d)
-{
-       if (d->data) {
-               memset(d->data, 0, d->length);
-       }
-}
-
-/*******************************************************************
-free a data blob and clear its contents
-*******************************************************************/
-void data_blob_clear_free(DATA_BLOB *d)
-{
-       data_blob_clear(d);
-       data_blob_free(d);
-}
-
 #ifdef __INSURE__
 
 /*******************************************************************