wbinfo: fix various valgrind warnings and an invalid free.

Kai, please check.

Guenther

diff --git a/nsswitch/wbinfo.c b/nsswitch/wbinfo.c
index 813846f138833b51d87317743936d4beebb27264..a80b69f2b6bcb05e529e82f04e5c0355c3898745 100644 (file)
--- a/nsswitch/wbinfo.c
+++ b/nsswitch/wbinfo.c
@@ -1318,7 +1318,6 @@ static bool wbinfo_auth_krb5(char *username, const char *cctype, uint32_t flags)
        }
  done:
 
-       TALLOC_FREE(frame);
        wbcFreeMemory(params.blobs);
 
        return WBC_ERROR_IS_OK(wbc_status);
@@ -1363,8 +1362,6 @@ static bool wbinfo_auth(char *username)
                         response.data.auth.error_string);
 #endif
 
-       TALLOC_FREE(frame);
-
        return WBC_ERROR_IS_OK(wbc_status);
 }
 
@@ -1424,7 +1421,7 @@ static bool wbinfo_auth_crap(char *username, bool use_ntlmv2, bool use_lanman)
                                      &lm, &nt, NULL, NULL)) {
                        data_blob_free(&names_blob);
                        data_blob_free(&server_chal);
-                       SAFE_FREE(pass);
+                       TALLOC_FREE(pass);
                        return false;
                }
                data_blob_free(&names_blob);
@@ -1471,7 +1468,6 @@ static bool wbinfo_auth_crap(char *username, bool use_ntlmv2, bool use_lanman)
 
        data_blob_free(&nt);
        data_blob_free(&lm);
-       TALLOC_FREE(frame);
 
        return WBC_ERROR_IS_OK(wbc_status);
 }
@@ -1650,8 +1646,6 @@ static bool wbinfo_change_user_password(const char *username)
        d_printf("Password change for user %s %s\n", username,
                WBC_ERROR_IS_OK(wbc_status) ? "succeeded" : "failed");
 
-       TALLOC_FREE(frame);
-
        return WBC_ERROR_IS_OK(wbc_status);
 }