FIXME: At the moment, if the user should happen to give the options

ahead of the service name (in standard Unix fashion) then smbclient
just spits out the usage message with no explanation of what in
particular was wrong.  Is there any reason we can't just parse out the
service name and password after running getopt??
(This used to be commit 5f6feb55d7e7566549141ebb1786b6f2f9f2645b)

diff --git a/source3/client/client.c b/source3/client/client.c
index 33ce7e30f74ed75acca7a0e4ef03e1262688827c..f5f27474d994c7c821ce5ef0280aa5c053af4141 100644 (file)
--- a/source3/client/client.c
+++ b/source3/client/client.c
@@ -2499,7 +2499,13 @@ static int do_message_op(void)
                usage(pname);
                exit(1);
        }
                usage(pname);
                exit(1);
        }

-  
+
+       /* FIXME: At the moment, if the user should happen to give the
+        * options ahead of the service name (in standard Unix
+        * fashion) then smbclient just spits out the usage message
+        * with no explanation of what in particular was wrong.  Is
+        * there any reason we can't just parse out the service name
+        * and password after running getopt?? -- mbp */

        if (*argv[1] != '-') {
                pstrcpy(service,argv[1]);  
                /* Convert any '/' characters in the service name to '\' characters */
        if (*argv[1] != '-') {
                pstrcpy(service,argv[1]);  
                /* Convert any '/' characters in the service name to '\' characters */