nbt: fix WinXP S3 domain join: alignment of nbt_netlogon_response_from_pdc

This fixes WinXP joining a Samba3 domain, which was broken on hosts
with an even number of characters in the host name.  The alignment
requested in the structure was ignored because of the overall
NDR_NOALIGN set on the packet.

Andrew Bartlett

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Thu Jul 28 00:30:26 CEST 2011 on sn-devel-104

diff --git a/librpc/idl/nbt.idl b/librpc/idl/nbt.idl
index cbfa9666701bb3862b88c440428e077d4cbb5c7f..ee9a64ed3e588ef9d861f2a4496e40559ede347d 100644 (file)
--- a/librpc/idl/nbt.idl
+++ b/librpc/idl/nbt.idl
@@ -494,7 +494,7 @@ interface nbt
        } nbt_netlogon_query_for_pdc;
 
        /* response from pdc */
        } nbt_netlogon_query_for_pdc;
 
        /* response from pdc */

-       typedef [flag(NDR_NOALIGN),public] struct {
+       typedef [public] struct {

                netlogon_command command;
                astring pdc_name;
                [flag(NDR_ALIGN2)]   DATA_BLOB _pad;
                netlogon_command command;
                astring pdc_name;
                [flag(NDR_ALIGN2)]   DATA_BLOB _pad;