Avoid use of uninitialized memory
authorVolker Lendecke <vl@samba.org>
Tue, 22 Jan 2008 11:46:51 +0000 (12:46 +0100)
committerVolker Lendecke <vl@samba.org>
Tue, 22 Jan 2008 11:46:51 +0000 (12:46 +0100)
source/lib/version.c

index 38c4f45ac6ae2726776f26e4a77959c447cc2adf..dff45f62597068dde5d9234529558703f3317f5c 100644 (file)
@@ -84,7 +84,10 @@ void samba_extended_info_version(struct smb_extended_info *extended_info)
        /* FIXME: samba_gitcommitdate should contain the git commit date. */
        unix_to_nt_time(&extended_info->samba_gitcommitdate, time(NULL));
 
+       memset(extended_info->samba_version_string, 0,
+              sizeof(extended_info->samba_version_string));
+
        snprintf (extended_info->samba_version_string,
-                 SAMBA_EXTENDED_INFO_VERSION_STRING_LENGTH,
+                 sizeof(extended_info->samba_version_string),
                  "%s", samba_version_string());
 }