when doing a 'net rpc vampire' a pdb_init_sam_pw() is used to create a

sam account object, then pdb_update_sam_account() can be used to
update an account. This code path could lead to the methods element of
the account being used when uninitialised (leading to a segv)

Easiest fix is to always make that that when creating a sam_account
object we initialise the methods to null, so that the passdb code
knows that it needs to be filled in.
(This used to be commit fb79fa5a31c2fa8ebdcddbc49b1d9c1aa3059691)

diff --git a/source3/passdb/passdb.c b/source3/passdb/passdb.c
index 4ce5b93abd58f2658fff9b7e95f7137a904b592d..de737f7df70a5db176864acb172272a0c0c461de 100644 (file)
--- a/source3/passdb/passdb.c
+++ b/source3/passdb/passdb.c
@@ -42,6 +42,9 @@ static void pdb_fill_default_sam(SAM_ACCOUNT *user)
 {
        ZERO_STRUCT(user->private); /* Don't touch the talloc context */
 
+       /* no initial methods */
+       user->methods = NULL;
+
         /* Don't change these timestamp settings without a good reason.
            They are important for NT member server compatibility. */