Fix an uninitialized variable access in callers of parse_msdfs_symlink

At least form_junctions() does not initialize refcount, and I don't see it in
get_referred_path(). For the latters, the callers might initialize it. But even
if they did, I think parse_msdfs_symlink() should unconditionally return the
number of referrals it found. I don't think it makes sense to count them up
from somewhere else.
(This used to be commit 73172113484a2c6c9af014f59e84707716c61a7d)

diff --git a/source3/smbd/msdfs.c b/source3/smbd/msdfs.c
index 25b22f4cc04b9e049cbd18829ee8c629203b324e..bdcdc92df2070ef176a8b9a93354820cca819dcc 100644 (file)
--- a/source3/smbd/msdfs.c
+++ b/source3/smbd/msdfs.c
@@ -370,9 +370,10 @@ static bool parse_msdfs_symlink(TALLOC_CTX *ctx,
                reflist[i].ttl = REFERRAL_TTL;
                DEBUG(10, ("parse_msdfs_symlink: Created alt path: %s\n",
                                        reflist[i].alternate_path));
-               *refcount += 1;
        }
 
+       *refcount = count;
+
        TALLOC_FREE(alt_path);
        return True;
 }