s4:libnet/libnet_become_dc - Fix a small glitch in "becomeDC_drsuapi1_add_entry_send"
authorMatthias Dieter Wallnöfer <mwallnoefer@yahoo.de>
Fri, 11 Dec 2009 10:17:37 +0000 (11:17 +0100)
committerMatthias Dieter Wallnöfer <mwallnoefer@yahoo.de>
Fri, 11 Dec 2009 10:19:32 +0000 (11:19 +0100)
We shouldn't use the now uninitialised "status" variable anymore.

source4/libnet/libnet_become_dc.c

index f64ef6f8ddefc5891c7a820f4f27a22551134b93..b8fed68b5960eb17dce0847cbf4cbb833496345f 100644 (file)
@@ -1939,7 +1939,6 @@ static void becomeDC_drsuapi1_add_entry_send(struct libnet_BecomeDC_state *s)
                struct drsuapi_DsAttributeValue *vs;
                DATA_BLOB *vd;
                const struct GUID *v;
-               NTSTATUS status;
 
                vs = talloc_array(attrs, struct drsuapi_DsAttributeValue, 1);
                if (composite_nomem(vs, c)) return;
@@ -1950,9 +1949,7 @@ static void becomeDC_drsuapi1_add_entry_send(struct libnet_BecomeDC_state *s)
                v = &s->dest_dsa.invocation_id;
 
                c->status = GUID_to_ndr_blob(v, vd, &vd[0]);
-               if (!NT_STATUS_IS_OK(status)) {
-                       if (!composite_is_ok(c)) return;
-               }
+               if (!composite_is_ok(c)) return;
 
                vs[0].blob              = &vd[0];