fixed a crash bug in domain auth caused by an uninitialised nt_status
authorAndrew Tridgell <tridge@samba.org>
Fri, 11 Jan 2002 13:14:28 +0000 (13:14 +0000)
committerAndrew Tridgell <tridge@samba.org>
Fri, 11 Jan 2002 13:14:28 +0000 (13:14 +0000)
source/auth/auth_domain.c
source/libsmb/cliconnect.c

index a81af3b7381381c792b8adcf127cfe024f6eaa23..eba61114d66279ab477b68bd120ad8eb442ffa67 100644 (file)
@@ -242,7 +242,7 @@ static NTSTATUS domain_client_validate(TALLOC_CTX *mem_ctx,
        fstring remote_machine;
        NET_USER_INFO_3 info3;
        struct cli_state *cli;
-       NTSTATUS nt_status;
+       NTSTATUS nt_status = NT_STATUS_UNSUCCESSFUL;
        struct passwd *pass;
 
        /*
index 7649a88ffdd56778ccb7583778f2b387baf2252f..1812416426dd4fd28604cfaaae5cbd30fed91fc2 100644 (file)
@@ -1270,6 +1270,7 @@ again:
                DEBUG(1,("failed session setup\n"));
                nt_status = cli_nt_error(cli);
                cli_shutdown(cli);
+               if (NT_STATUS_IS_OK(nt_status)) nt_status = NT_STATUS_UNSUCCESSFUL;
                return nt_status;
        } 
 
@@ -1281,6 +1282,7 @@ again:
                        DEBUG(1,("failed tcon_X\n"));
                        nt_status = cli_nt_error(cli);
                        cli_shutdown(cli);
+                       if (NT_STATUS_IS_OK(nt_status)) nt_status = NT_STATUS_UNSUCCESSFUL;
                        return nt_status;
                }
        }